decidim 0.2.0 → 0.3.0

data/decidim-surveys/spec/commands/decidim/surveys/admin/update_survey_spec.rb

@@ -0,0 +1,147 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    module Admin
+      describe UpdateSurvey, :db do
+        let(:current_organization) { create(:organization) }
+        let(:participatory_process) { create(:participatory_process, organization: current_organization) }
+        let(:feature) { create(:feature, manifest_name: "surveys", participatory_process: participatory_process) }
+        let(:survey) { create(:survey, feature: feature) }
+        let(:published_at) { nil }
+        let(:form_params) do
+          {
+            "description" => {
+              "en" => "<p>Content</p>",
+              "ca" => "<p>Contingut</p>",
+              "es" => "<p>Contenido</p>"
+            },
+            "questions" => [
+              {
+                "body" => {
+                  "en" => "First question",
+                  "ca" => "Primera pregunta",
+                  "es" => "Primera pregunta"
+                },
+                "position" => "0",
+                "question_type" => "short_answer",
+                "answer_options" => []
+              },
+              {
+                "body" => {
+                  "en" => "Second question",
+                  "ca" => "Segona pregunta",
+                  "es" => "Segunda pregunta"
+                },
+                "position" => "1",
+                "mandatory" => "1",
+                "question_type" => "long_answer",
+                "answer_options" => []
+              },
+              {
+                "body" => {
+                  "en" => "Third question",
+                  "ca" => "Tercera pregunta",
+                  "es" => "Tercera pregunta"
+                },
+                "position" => "2",
+                "question_type" => "single_option",
+                "answer_options" => [
+                  {
+                    "body" => {
+                      "en" => "First answer",
+                      "ca" => "Primera resposta",
+                      "es" => "Primera respuesta"
+                    }
+                  },
+                  {
+                    "body" => {
+                      "en" => "Second answer",
+                      "ca" => "Segona resposta",
+                      "es" => "Segunda respuesta"
+                    }
+                  }
+                ]
+              }
+            ],
+            "published_at" => published_at
+          }
+        end
+        let(:form) do
+          SurveyForm.from_params(
+            form_params
+          ).with_context(
+            current_organization: current_organization
+          )
+        end
+        let(:command) { described_class.new(form, survey) }
+
+        describe "when the form is invalid" do
+          before do
+            expect(form).to receive(:invalid?).and_return(true)
+          end
+
+          it "broadcasts invalid" do
+            expect { command.call }.to broadcast(:invalid)
+          end
+
+          it "doesn't update the survey" do
+            expect(survey).not_to receive(:update_attributes!)
+            command.call
+          end
+        end
+
+        describe "when the form is valid" do
+          it "broadcasts ok" do
+            expect { command.call }.to broadcast(:ok)
+          end
+
+          it "updates the survey" do
+            command.call
+            survey.reload
+
+            expect(survey.description["en"]).to eq("<p>Content</p>")
+            expect(survey.questions.length).to eq(3)
+
+            survey.questions.each_with_index do |question, idx|
+              expect(question.body["en"]).to eq(form_params["questions"][idx]["body"]["en"])
+            end
+
+            expect(survey.questions[1]).to be_mandatory
+            expect(survey.questions[1].question_type).to eq("long_answer")
+            expect(survey.questions[2].answer_options[1]["body"]["en"]).to eq(form_params["questions"][2]["answer_options"][1]["body"]["en"])
+          end
+        end
+
+        describe "when the survey has an existing question" do
+          let!(:survey_question) { create(:survey_question, survey: survey) }
+
+          context "and the question should be removed" do
+            let(:form_params) do
+              {
+                "questions" => [
+                  {
+                    "id" => survey_question.id,
+                    "body" => survey_question.body,
+                    "position" => 0,
+                    "question_type" => "short_answer",
+                    "deleted" => "true"
+                  }
+                ]
+              }
+            end
+
+            it "deletes the survey question" do
+              command.call
+              survey.reload
+
+              expect(survey.questions.length).to eq(0)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/commands/decidim/surveys/answer_survey_spec.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe AnswerSurvey, :db do
+      let(:current_organization) { create(:organization) }
+      let(:current_user) { create(:user, organization: current_organization) }
+      let(:participatory_process) { create(:participatory_process, organization: current_organization) }
+      let(:feature) { create(:feature, manifest_name: "surveys", participatory_process: participatory_process) }
+      let(:survey) { create(:survey, feature: feature) }
+      let(:survey_question_1) { create(:survey_question, survey: survey) }
+      let(:survey_question_2) { create(:survey_question, survey: survey) }
+      let(:form_params) do
+        {
+          "answers" => [
+            {
+              "body" => "This is my first answer",
+              "question_id" => survey_question_1.id
+            },
+            {
+              "body" => "This is my first answer",
+              "question_id" => survey_question_2.id
+            }
+          ],
+          "tos_agreement" => "1"
+        }
+      end
+      let(:form) do
+        SurveyForm.from_params(
+          form_params
+        ).with_context(
+          current_organization: current_organization,
+          current_feature: feature
+        )
+      end
+      let(:command) { described_class.new(form, current_user, survey) }
+
+      describe "when the form is invalid" do
+        before do
+          expect(form).to receive(:invalid?).and_return(true)
+        end
+
+        it "broadcasts invalid" do
+          expect { command.call }.to broadcast(:invalid)
+        end
+
+        it "doesn't create survey answers" do
+          expect do
+            command.call
+          end.not_to change { SurveyAnswer.count }
+        end
+      end
+
+      describe "when the form is valid" do
+        it "broadcasts ok" do
+          expect { command.call }.to broadcast(:ok)
+        end
+
+        it "creates a survey answer for each question answered" do
+          expect do
+            command.call
+          end.to change { SurveyAnswer.count }.by(2)
+          last_answer = SurveyAnswer.last
+          expect(last_answer.survey).to eq(survey)
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/commands/decidim/surveys/create_survey_spec.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe CreateSurvey, :db do
+      describe "call" do
+        let(:feature) { create(:feature, manifest_name: "surveys") }
+        let(:command) { described_class.new(feature) }
+
+        describe "when the survey is not saved" do
+          before do
+            expect_any_instance_of(Survey).to receive(:save).and_return(false)
+          end
+
+          it "broadcasts invalid" do
+            expect { command.call }.to broadcast(:invalid)
+          end
+
+          it "doesn't create a survey" do
+            expect do
+              command.call
+            end.not_to change { Survey.count }
+          end
+        end
+
+        describe "when the survey is saved" do
+          it "broadcasts ok" do
+            expect { command.call }.to broadcast(:ok)
+          end
+
+          it "creates a new survey with the same name as the feature" do
+            expect(Survey).to receive(:new).with(feature: feature).and_call_original
+
+            expect do
+              command.call
+            end.to change { Survey.count }.by(1)
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/factories.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require "decidim/surveys/test/factories"

data/decidim-surveys/spec/features/admin_manages_surveys_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Admin manages surveys", type: :feature do
+  let(:manifest_name) { "surveys" }
+  let!(:survey) { create :survey, feature: feature }
+
+  include_context "feature admin"
+
+  it_behaves_like "edit surveys"
+  it_behaves_like "export survey user answers"
+end

data/decidim-surveys/spec/features/process_admin_manages_surveys_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Process admin manages surveys", type: :feature do
+  let(:manifest_name) { "surveys" }
+  let!(:survey) { create :survey, feature: feature }
+
+  include_context "feature process admin"
+
+  it_behaves_like "edit surveys"
+  it_behaves_like "export survey user answers"
+end

data/decidim-surveys/spec/features/survey_spec.rb

@@ -0,0 +1,235 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Answer a survey", type: :feature do
+  let(:manifest_name) { "surveys" }
+
+  let(:title) do
+    {
+      "en" => "Survey's title",
+      "ca" => "Títol de l'enquesta'",
+      "es" => "Título de la encuesta"
+    }
+  end
+  let(:description) do
+    {
+      "en" => "<p>Survey's content</p>",
+      "ca" => "<p>Contingut de l'enquesta</p>",
+      "es" => "<p>Contenido de la encuesta</p>"
+    }
+  end
+  let(:user) { create(:user, :confirmed, organization: feature.organization) }
+  let!(:survey) { create(:survey, feature: feature, title: title, description: description) }
+  let!(:survey_question_1) { create(:survey_question, survey: survey, position: 1) }
+  let!(:survey_question_2) { create(:survey_question, survey: survey, position: 0) }
+
+  include_context "feature"
+
+  context "when the survey doesn't allow answers" do
+    it "the survey cannot be answered" do
+      visit_feature
+
+      expect(page).to have_i18n_content(survey.title, upcase: true)
+      expect(page).to have_i18n_content(survey.description)
+
+      expect(page).not_to have_i18n_content(survey_question_1.body)
+      expect(page).not_to have_i18n_content(survey_question_2.body)
+
+      expect(page).to have_content("The survey is closed and cannot be answered.")
+    end
+  end
+
+  context "when the survey allow answers" do
+    before do
+      feature.update_attributes(
+        step_settings: {
+          feature.participatory_process.active_step.id => {
+            allow_answers: true
+          }
+        }
+      )
+    end
+
+    context "when the user is not logged in" do
+      it "the survey cannot be answered" do
+        visit_feature
+
+        expect(page).to have_i18n_content(survey.title, upcase: true)
+        expect(page).to have_i18n_content(survey.description)
+
+        expect(page).not_to have_i18n_content(survey_question_1.body)
+        expect(page).not_to have_i18n_content(survey_question_2.body)
+
+        expect(page).to have_content("Sign in with your account or sign up to answer the survey.")
+      end
+    end
+
+    context "when the user is logged in" do
+      before do
+        login_as user, scope: :user
+      end
+
+      it "the survey can be answered" do
+        visit_feature
+
+        expect(page).to have_i18n_content(survey.title, upcase: true)
+        expect(page).to have_i18n_content(survey.description)
+
+        fill_in "survey_#{survey.id}_question_#{survey_question_1.id}_answer_body", with: "My first answer"
+        fill_in "survey_#{survey.id}_question_#{survey_question_2.id}_answer_body", with: "My second answer"
+
+        check "survey_tos_agreement"
+
+        click_button "Submit"
+
+        within ".success.flash" do
+          expect(page).to have_content("successfully")
+        end
+
+        expect(page).to have_content("You have already answered this survey.")
+        expect(page).not_to have_i18n_content(survey_question_1.body)
+        expect(page).not_to have_i18n_content(survey_question_2.body)
+      end
+
+      it "the questions are ordered by position" do
+        visit_feature
+
+        form_fields = all(".answer-survey .row")
+
+        expect(form_fields[0]).to have_i18n_content(survey_question_2.body)
+        expect(form_fields[1]).to have_i18n_content(survey_question_1.body)
+      end
+
+      context "when a question is mandatory" do
+        let!(:survey_question_2) { create(:survey_question, survey: survey, position: 0, mandatory: true) }
+
+        it "users cannot leave that question blank" do
+          visit_feature
+
+          check "survey_tos_agreement"
+
+          click_button "Submit"
+
+          within ".alert.flash" do
+            expect(page).to have_content("error")
+          end
+          expect(page).to have_content("can't be blank")
+        end
+      end
+
+      context "when question type is long answer" do
+        let!(:survey_question_1) { create(:survey_question, survey: survey, question_type: "long_answer") }
+        let!(:survey_question_2) { create(:survey_question, survey: survey, question_type: "long_answer") }
+
+        it "the question answer is rendered as a textarea" do
+          visit_feature
+
+          expect(page).to have_selector("textarea#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body")
+          expect(page).to have_selector("textarea#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body")
+        end
+      end
+
+      context "when question type is single option" do
+        let(:answer_options) { Array.new(4) { { "body" => Decidim::Faker::Localized.sentence } } }
+        let!(:survey_question_1) { create(:survey_question, survey: survey, question_type: "single_option", answer_options: [answer_options[0], answer_options[1]]) }
+        let!(:survey_question_2) { create(:survey_question, survey: survey, question_type: "single_option", answer_options: [answer_options[2], answer_options[3]]) }
+
+        it "the question answers are rendered as a collection of radio buttons" do
+          visit_feature
+
+          expect(page).to have_selector("#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body_answer_options input[type='radio']", count: 2)
+          expect(page).to have_selector("#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body_answer_options input[type='radio']", count: 2)
+
+          within "#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body_answer_options" do
+            choose answer_options[1]["body"][:en]
+          end
+
+          within "#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body_answer_options" do
+            choose answer_options[2]["body"][:en]
+          end
+
+          check "survey_tos_agreement"
+
+          click_button "Submit"
+
+          within ".success.flash" do
+            expect(page).to have_content("successfully")
+          end
+
+          expect(page).to have_content("You have already answered this survey.")
+          expect(page).not_to have_i18n_content(survey_question_1.body)
+          expect(page).not_to have_i18n_content(survey_question_2.body)
+        end
+      end
+
+      context "when question type is multiple option" do
+        let(:answer_options) { Array.new(4) { { "body" => Decidim::Faker::Localized.sentence } } }
+        let!(:survey_question_1) { create(:survey_question, survey: survey, question_type: "multiple_option", answer_options: [answer_options[0], answer_options[1]]) }
+        let!(:survey_question_2) { create(:survey_question, survey: survey, question_type: "multiple_option", answer_options: [answer_options[2], answer_options[3]]) }
+
+        it "the question answers are rendered as a collection of radio buttons" do
+          visit_feature
+
+          expect(page).to have_selector("#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body_answer_options input[type='checkbox']", count: 2)
+          expect(page).to have_selector("#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body_answer_options input[type='checkbox']", count: 2)
+
+          within "#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body_answer_options" do
+            check answer_options[0]["body"][:en]
+            check answer_options[1]["body"][:en]
+          end
+
+          within "#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body_answer_options" do
+            check answer_options[2]["body"][:en]
+          end
+
+          check "survey_tos_agreement"
+
+          click_button "Submit"
+
+          within ".success.flash" do
+            expect(page).to have_content("successfully")
+          end
+
+          expect(page).to have_content("You have already answered this survey.")
+          expect(page).not_to have_i18n_content(survey_question_1.body)
+          expect(page).not_to have_i18n_content(survey_question_2.body)
+        end
+      end
+
+      context "when question type is multiple option" do
+        let(:answer_options) { Array.new(4) { { "body" => Decidim::Faker::Localized.sentence } } }
+        let!(:survey_question_1) { create(:survey_question, survey: survey, question_type: "multiple_option", answer_options: [answer_options[0], answer_options[1]]) }
+        let!(:survey_question_2) { create(:survey_question, survey: survey, question_type: "multiple_option", answer_options: [answer_options[2], answer_options[3]]) }
+
+        it "the question answers are rendered as a collection of radio buttons" do
+          visit_feature
+
+          expect(page).to have_selector("#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body_answer_options input[type='checkbox']", count: 2)
+          expect(page).to have_selector("#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body_answer_options input[type='checkbox']", count: 2)
+
+          within "#survey_#{survey.id}_question_#{survey_question_1.id}_answer_body_answer_options" do
+            check answer_options[0]["body"][:en]
+            check answer_options[1]["body"][:en]
+          end
+
+          within "#survey_#{survey.id}_question_#{survey_question_2.id}_answer_body_answer_options" do
+            check answer_options[2]["body"][:en]
+          end
+
+          check "survey_tos_agreement"
+
+          click_button "Submit"
+
+          within ".success.flash" do
+            expect(page).to have_content("successfully")
+          end
+
+          expect(page).to have_content("You have already answered this survey.")
+          expect(page).not_to have_i18n_content(survey_question_1.body)
+          expect(page).not_to have_i18n_content(survey_question_2.body)
+        end
+      end
+    end
+  end
+end