decidim 0.1.0 → 0.2.0

data/decidim-proposals/spec/controllers/decidim/admin/proposal_answers_controller_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/controllers/decidim/proposal_votes_controller_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim
@@ -97,14 +98,12 @@ module Decidim
             create(:proposal_feature, :with_votes_enabled)
           end
 
-          it "does not allow deleting a vote" do
+          it "deletes the vote" do
             expect do
               delete :destroy, format: :js, params: params
-            end.not_to change { ProposalVote.count }
+            end.to change { ProposalVote.count }.by(-1)
 
-            expect(flash[:alert]).not_to be_empty
-            expect(response).to have_http_status(302)
-            expect(ProposalVote.count).to eq(1)
+            expect(ProposalVote.count).to eq(0)
           end
         end
       end

data/decidim-proposals/spec/controllers/decidim/proposals_controller_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/factories.rb

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
+
 require "decidim/proposals/test/factories"

data/decidim-proposals/spec/features/comments_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 describe "Comments", type: :feature, perform_enqueued: true do

data/decidim-proposals/spec/features/proposals_spec.rb

@@ -1,16 +1,11 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 describe "Proposals", type: :feature do
   include_context "feature"
-  let!(:feature) do
-    create(:proposal_feature,
-           manifest: manifest,
-           participatory_process: participatory_process)
-  end
   let(:manifest_name) { "proposals" }
 
-  let!(:proposals) { create_list(:proposal, 3, feature: feature) }
   let!(:category) { create :category, participatory_process: participatory_process }
   let!(:scope) { create :scope, organization: organization }
   let!(:user) { create :user, :confirmed, organization: organization }
@@ -212,6 +207,14 @@ describe "Proposals", type: :feature do
   end
 
   context "viewing a single proposal" do
+    let!(:feature) do
+      create(:proposal_feature,
+             manifest: manifest,
+             participatory_process: participatory_process)
+    end
+
+    let!(:proposals) { create_list(:proposal, 3, feature: feature) }
+
     it "allows viewing a single proposal" do
       proposal = proposals.first
 
@@ -354,6 +357,11 @@ describe "Proposals", type: :feature do
   end
 
   context "when a proposal has been linked in a project" do
+    let(:feature) do
+      create(:proposal_feature,
+             manifest: manifest,
+             participatory_process: participatory_process)
+    end
     let(:proposal) { create(:proposal, feature: feature) }
     let(:budget_feature) do
       create(:feature, manifest_name: :budgets, participatory_process: proposal.feature.participatory_process)
@@ -374,10 +382,77 @@ describe "Proposals", type: :feature do
 
   context "listing proposals in a participatory process" do
     it "lists all the proposals" do
+      create(:proposal_feature,
+             manifest: manifest,
+             participatory_process: participatory_process)
+
+      create_list(:proposal, 3, feature: feature)
+
       visit_feature
       expect(page).to have_css(".card--proposal", count: 3)
     end
 
+    context "when voting phase is over" do
+      let!(:feature) do
+        create(:proposal_feature,
+               :with_votes_blocked,
+               manifest: manifest,
+               participatory_process: participatory_process)
+      end
+
+      let!(:most_voted_proposal) do
+        proposal = create(:proposal, feature: feature)
+        create_list(:proposal_vote, 3, proposal: proposal)
+        proposal
+      end
+
+      let!(:less_voted_proposal) { create(:proposal, feature: feature) }
+
+      before { visit_feature }
+
+      it "lists the proposals ordered by votes by default" do
+        expect(page).to have_selector("a", text: "Most voted")
+        expect(page).to have_selector("#proposals .card-grid .column:first-child", text: most_voted_proposal.title)
+        expect(page).to have_selector("#proposals .card-grid .column:last-child", text: less_voted_proposal.title)
+      end
+
+      it "shows a disabled vote button for each proposal, but no links to full proposals" do
+        expect(page).to have_button("Voting disabled", disabled: true, count: 2)
+        expect(page).to have_no_link("View proposal")
+      end
+    end
+
+    context "when voting is disabled" do
+      let!(:feature) do
+        create(:proposal_feature,
+               :with_votes_disabled,
+               manifest: manifest,
+               participatory_process: participatory_process)
+      end
+
+      let!(:lucky_proposal) { create(:proposal, title: "A", feature: feature) }
+      let!(:unlucky_proposal) { create(:proposal, title: "B", feature: feature) }
+
+      it "lists the proposals ordered randomly by default" do
+        allow_any_instance_of(Decidim::Proposals::Proposal::ActiveRecord_Relation).to \
+          receive(:order_randomly) { |scope, _seed| scope.order(title: :asc) }
+
+        visit_feature
+
+        expect(page).to have_selector("a", text: "Random")
+        expect(page).to have_selector("#proposals .card-grid .column:first-child", text: lucky_proposal.title)
+        expect(page).to have_selector("#proposals .card-grid .column:last-child", text: unlucky_proposal.title)
+      end
+
+      it "shows only links to full proposals" do
+        visit_feature
+
+        expect(page).to have_no_button("Voting disabled", disabled: true)
+        expect(page).to have_no_button("Vote")
+        expect(page).to have_link("View proposal", count: 2)
+      end
+    end
+
     context "when there are a lot of proposals" do
       before do
         create_list(:proposal, 17, feature: feature)
@@ -388,11 +463,11 @@ describe "Proposals", type: :feature do
 
         expect(page).to have_css(".card--proposal", count: 12)
 
-        find(".pagination-next a").click
+        click_link "Next"
 
         expect(page).to have_selector(".pagination .current", text: "2")
 
-        expect(page).to have_css(".card--proposal", count: 8)
+        expect(page).to have_css(".card--proposal", count: 5)
       end
     end
 
@@ -412,28 +487,31 @@ describe "Proposals", type: :feature do
 
         context "by origin 'official'" do
           it "lists the filtered proposals" do
-            create(:proposal, :official, feature: feature, scope: scope)
+            create_list(:proposal, 2, :official, feature: feature, scope: scope)
+            create(:proposal, feature: feature, scope: scope)
             visit_feature
 
             within ".filters" do
               choose "Official"
             end
 
-            expect(page).to have_css(".card--proposal", count: 1)
-            expect(page).to have_content("1 PROPOSAL")
+            expect(page).to have_css(".card--proposal", count: 2)
+            expect(page).to have_content("2 PROPOSALS")
           end
         end
 
         context "by origin 'citizenship'" do
           it "lists the filtered proposals" do
+            create_list(:proposal, 2, feature: feature, scope: scope)
+            create(:proposal, :official, feature: feature, scope: scope)
             visit_feature
 
             within ".filters" do
               choose "Citizenship"
             end
 
-            expect(page).to have_css(".card--proposal", count: proposals.size)
-            expect(page).to have_content("#{proposals.size} PROPOSALS")
+            expect(page).to have_css(".card--proposal", count: 2)
+            expect(page).to have_content("2 PROPOSALS")
           end
         end
       end
@@ -578,7 +656,7 @@ describe "Proposals", type: :feature do
     end
 
     context "when ordering" do
-      context "by 'most_support'" do
+      context "by 'most_voted'" do
         let!(:feature) do
           create(:proposal_feature,
                  :with_votes_enabled,
@@ -586,12 +664,6 @@ describe "Proposals", type: :feature do
                  participatory_process: participatory_process)
         end
 
-        before do
-          proposals.each do |proposal|
-            create(:proposal_vote, proposal: proposal)
-          end
-        end
-
         it "lists the proposals ordered by votes" do
           most_voted_proposal = create(:proposal, feature: feature)
           create_list(:proposal_vote, 3, proposal: most_voted_proposal)
@@ -600,13 +672,13 @@ describe "Proposals", type: :feature do
           visit_feature
 
           within ".order-by" do
-            page.find(".dropdown.menu .is-dropdown-submenu-parent").hover
+            expect(page).to have_selector("ul[data-dropdown-menu$=dropdown-menu]", text: "Random")
+            page.find("a", text: "Random").click
+            click_link "Most voted"
           end
 
-          click_link "Most voted"
-
-          expect(page.find("#proposals .card-grid .column:first-child", text: most_voted_proposal.title)).to be
-          expect(page.find("#proposals .card-grid .column:last-child", text: less_voted_proposal.title)).to be
+          expect(page).to have_selector("#proposals .card-grid .column:first-child", text: most_voted_proposal.title)
+          expect(page).to have_selector("#proposals .card-grid .column:last-child", text: less_voted_proposal.title)
         end
       end
 
@@ -618,13 +690,13 @@ describe "Proposals", type: :feature do
           visit_feature
 
           within ".order-by" do
-            page.find(".dropdown.menu .is-dropdown-submenu-parent").hover
+            expect(page).to have_selector("ul[data-dropdown-menu$=dropdown-menu]", text: "Random")
+            page.find("a", text: "Random").click
+            click_link "Recent"
           end
 
-          click_link "Recent"
-
-          expect(page.find("#proposals .card-grid .column:first-child", text: recent_proposal.title)).to be
-          expect(page.find("#proposals .card-grid .column:last-child", text: older_proposal.title)).to be
+          expect(page).to have_selector("#proposals .card-grid .column:first-child", text: recent_proposal.title)
+          expect(page).to have_selector("#proposals .card-grid .column:last-child", text: older_proposal.title)
         end
       end
     end

data/decidim-proposals/spec/features/report_proposal_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 describe "Report Proposal", type: :feature do

data/decidim-proposals/spec/features/vote_proposal_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 describe "Vote Proposal", type: :feature do
@@ -9,16 +10,10 @@ describe "Vote Proposal", type: :feature do
   let!(:proposal) { Decidim::Proposals::Proposal.where(feature: feature).first }
   let!(:user) { create :user, :confirmed, organization: organization }
 
-  let!(:feature) do
-    create(:proposal_feature,
-           manifest: manifest,
-           participatory_process: participatory_process)
-  end
-
   context "when votes are not enabled" do
     it "doesn't show the vote proposal button and counts" do
-      expect(page).not_to have_css(".card__button", text: "Vote")
-      expect(page).not_to have_css(".card__support__data span", text: "0 VOTES")
+      expect(page).to have_no_button("Vote")
+      expect(page).to have_no_css(".card__support__data span", text: "0 VOTES")
     end
   end
 
@@ -50,7 +45,7 @@ describe "Vote Proposal", type: :feature do
         visit_feature
 
         within ".card__support", match: :first do
-          page.find(".card__button").click
+          click_button "Vote"
         end
 
         expect(page).to have_css("#loginModal", visible: true)
@@ -60,14 +55,17 @@ describe "Vote Proposal", type: :feature do
     context "when the user is logged in" do
       before do
         login_as user, scope: :user
-        visit_feature
       end
 
       context "when the proposal is not voted yet" do
+        before do
+          visit_feature
+        end
+
         it "should be able to vote the proposal" do
           within "#proposal-#{proposal.id}-vote-button" do
-            page.find(".card__button").click
-            expect(page).to have_css(".card__button.success", text: "Already voted")
+            click_button "Vote"
+            expect(page).to have_button("Already voted")
           end
 
           within "#proposal-#{proposal.id}-votes-count" do
@@ -84,14 +82,25 @@ describe "Vote Proposal", type: :feature do
 
         it "should not be able to vote it again" do
           within "#proposal-#{proposal.id}-vote-button" do
-            expect(page).to have_css(".card__button.success", text: "Already voted")
-            page.find(".card__button").click
+            expect(page).to have_button("Already voted")
+            expect(page).to have_no_button("Vote")
           end
 
           within "#proposal-#{proposal.id}-votes-count" do
             expect(page).to have_content("1 VOTE")
           end
         end
+
+        it "should be able to undo the vote" do
+          within "#proposal-#{proposal.id}-vote-button" do
+            click_button "Already voted"
+            expect(page).to have_button("Vote")
+          end
+
+          within "#proposal-#{proposal.id}-votes-count" do
+            expect(page).to have_content("0 VOTES")
+          end
+        end
       end
 
       context "when the feature has a vote limit" do
@@ -107,10 +116,14 @@ describe "Vote Proposal", type: :feature do
         end
 
         context "when the proposal is not voted yet" do
+          before do
+            visit_feature
+          end
+
           it "should update the remaining votes counter" do
             within "#proposal-#{proposal.id}-vote-button" do
-              page.find(".card__button").click
-              expect(page).to have_css(".card__button.success")
+              click_button "Vote"
+              expect(page).to have_button("Already voted")
             end
 
             expect(page).to have_content("REMAINING 9 VOTES")
@@ -125,7 +138,7 @@ describe "Vote Proposal", type: :feature do
 
           it "should show a modal dialog" do
             within "#proposal-#{proposal.id}-vote-button" do
-              page.find(".card__button").click
+              click_button "Vote"
             end
 
             expect(page).to have_content("Authorization required")
@@ -138,10 +151,17 @@ describe "Vote Proposal", type: :feature do
             visit_feature
           end
 
+          it "should not be able to vote it again" do
+            within "#proposal-#{proposal.id}-vote-button" do
+              expect(page).to have_button("Already voted")
+              expect(page).to have_no_button("Vote")
+            end
+          end
+
           it "should be able to undo the vote" do
             within "#proposal-#{proposal.id}-vote-button" do
-              expect(page).to have_css(".card__button.success")
-              page.find(".card__button").click
+              click_button "Already voted"
+              expect(page).to have_button("Vote")
             end
 
             within "#proposal-#{proposal.id}-votes-count" do

data/decidim-proposals/spec/forms/decidim/proposals/admin_proposal_form_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/forms/decidim/proposals/proposal_answer_form_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/forms/decidim/proposals/proposal_form_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/helpers/application_helper_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/helpers/proposal_votes_helper_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "spec_helper"
 
 module Decidim

data/decidim-proposals/spec/i18n_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require "decidim/dev/test/i18n_shared_examples"
+
+RSpec.describe "I18n sanity" do
+  include_examples "I18n sanity"
+end