RubyGems - decidim - Versions diffs - 0.1.0 → 0.2.0 - Mend

decidim 0.1.0 → 0.2.0

Potentially problematic release.

This version of decidim might be problematic. Click here for more details.

Files changed (627) hide show

data/decidim-comments/spec/types/mutation_type_spec.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "spec_helper"
 require "decidim/api/test/type_context"

data/decidim-comments/spec/types/query_type_spec.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "spec_helper"
 require "decidim/api/test/type_context"

data/decidim-dev/Rakefile CHANGED

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
 require "bundler/gem_tasks"

data/decidim-dev/app/assets/images/decidim/dummy.svg ADDED

@@ -0,0 +1,4 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 36.02 36.02">
+  <circle cx="18.01" cy="18.01" r="15.75" stroke="#2ecc71" stroke-width="4" fill="none"></circle>
+  <circle cx="18.01" cy="18.01" r="11.25" stroke="#08BCD0" stroke-width="4" fill="none" />
+</svg>

data/decidim-dev/config/i18n-tasks.yml CHANGED

@@ -1,4 +1,6 @@
 base_locale: en
-locales: [en]
 ignore_unused:
 - "decidim.resource_links.test_link.*"
+- "decidim.dummy.admin.exports.dummies"
+search:
+  strict: false

data/decidim-dev/config/locales/ca.yml CHANGED

@@ -1,5 +1,9 @@
 ca:
   decidim:
+    dummy:
+      admin:
+        exports:
+          dummies: "Maniquins"
     resource_links:
       test_link:
         dummy_resource_dummy: Fictici relacionat

data/decidim-dev/config/locales/en.yml CHANGED

@@ -1,5 +1,9 @@
 en:
   decidim:
+    dummy:
+      admin:
+        exports:
+          dummies: "Dummies"
     resource_links:
       test_link:
         dummy_resource_dummy: Related dummy

data/decidim-dev/config/locales/es.yml CHANGED

@@ -1,5 +1,9 @@
 es:
   decidim:
+    dummy:
+      admin:
+        exports:
+          dummies: "Maniquíes"
     resource_links:
       test_link:
         dummy_resource_dummy: Ficticio relacionado

data/decidim-dev/config/locales/eu.yml CHANGED

@@ -1,5 +1,9 @@
 eu:
   decidim:
+    dummy:
+      admin:
+        exports:
+          dummies: "Manikiak"
     resource_links:
       test_link:
         dummy_resource_dummy: ' Honi buruzko adibidea '

data/decidim-dev/decidim-dev.gemspec CHANGED

@@ -16,8 +16,8 @@ Gem::Specification.new do |s|
   s.add_dependency "decidim", Decidim.version
   s.add_dependency "factory_girl_rails"
-  s.add_dependency "database_cleaner", "~> 1.5.0"
-  s.add_dependency "capybara", "~> 2.13.0"
+  s.add_dependency "database_cleaner", "~> 1.6.0"
+  s.add_dependency "capybara", "~> 2.14.0"
   s.add_dependency "capybara-screenshot", "~> 1.0.14"
   s.add_dependency "rspec-rails", "~> 3.5"
   s.add_dependency "rspec-repeat", "~> 1.0.2"
@@ -25,14 +25,14 @@ Gem::Specification.new do |s|
   s.add_dependency "wisper-rspec", "~> 0.0.3"
   s.add_dependency "listen", "~> 3.1.0"
   s.add_dependency "launchy"
-  s.add_dependency "i18n-tasks", "0.9.13"
+  s.add_dependency "i18n-tasks", "0.9.15"
   s.add_dependency "faker", "~> 1.7.3"
-  s.add_dependency "poltergeist", "~> 1.14.0"
+  s.add_dependency "poltergeist", "~> 1.15.0"
   s.add_dependency "rails-controller-testing", "~> 1.0.1"
   s.add_dependency "simplecov", "~> 0.13"
   s.add_dependency "codecov", "~> 0.1.9"
-  s.add_dependency "rubocop", "~> 0.46.0"
-  s.add_dependency "db-query-matchers", "~> 0.8.0"
+  s.add_dependency "rubocop", "~> 0.49.0"
+  s.add_dependency "db-query-matchers", "~> 0.9.0"
   s.add_dependency "letter_opener_web", "~> 1.3.0"
   s.add_dependency "rspec-html-matchers", "~> 0.9.1"
   s.add_dependency "webmock", "~> 3.0.1"

data/decidim-dev/lib/decidim/dev/common_rake.rb CHANGED

@@ -1,10 +1,7 @@
 # frozen_string_literal: true
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
-RSpec::Core::RakeTask.new(:spec) do |t|
-  # The i18n_spec part needs to go first or it won't be include. It seems like a
-  # bug in RSpec to me... https://github.com/rspec/rspec-core/issues/2418
-  t.rspec_opts = "--pattern #{__dir__}/test/i18n_spec.rb,**/*_spec.rb"
-end
+RSpec::Core::RakeTask.new(:spec)
 task default: [:spec]

data/decidim-dev/lib/decidim/dev/dummy_authorization_handler.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 module Decidim
   # An example implementation of an AuthorizationHandler to be used in tests.
   class DummyAuthorizationHandler < AuthorizationHandler

data/decidim-dev/lib/decidim/dev/railtie.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 module Decidim
   module Dev
     class Railtie < Rails::Railtie

data/decidim-dev/lib/decidim/dev/test/authorization_shared_examples.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.shared_examples "an authorization handler" do
   before do
     unless respond_to?(:handler)

data/decidim-dev/lib/decidim/dev/test/base_spec_helper.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 ENV["RAILS_ENV"] ||= "test"
 root_path = File.join(Dir.pwd, "..")
@@ -17,7 +18,7 @@ if ENV["SIMPLECOV"]
     add_filter "/vendor/"
     add_filter do |src|
-      !(src.filename =~ /^#{root_path}/)
+      src.filename !~ /^#{root_path}/
     end
   end

data/decidim-dev/lib/decidim/dev/test/{i18n_spec.rb → i18n_shared_examples.rb} RENAMED

@@ -1,19 +1,22 @@
 # frozen_string_literal: true
 require "i18n/tasks"
-RSpec.describe "I18n" do
-  let(:i18n) { I18n::Tasks::BaseTask.new(locales: [I18n.default_locale]) }
+RSpec.shared_examples_for "I18n sanity" do
+  let(:locales) do
+    ENV["ENFORCED_LOCALES"].present? ? ENV["ENFORCED_LOCALES"].split(",") : [:en]
+  end
+  let(:i18n) { I18n::Tasks::BaseTask.new(locales: locales) }
   let(:missing_keys) { i18n.missing_keys }
   let(:unused_keys) { i18n.unused_keys }
   it "does not have missing keys" do
-    expect(missing_keys).to be_empty,
-                            "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing` to show them"
+    expect(missing_keys).to be_empty, "#{missing_keys.inspect} are missing"
   end
   it "does not have unused keys" do
-    expect(unused_keys).to be_empty,
-                           "#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused` to show them"
+    expect(unused_keys).to be_empty, "#{unused_keys.inspect} are unused"
   end
   it "is normalized" do

data/decidim-dev/lib/decidim/dev/test/rspec_support/action_mailer.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "nokogiri"
 RSpec.configure do |config|

data/decidim-dev/lib/decidim/dev/test/rspec_support/authenticated_controller_context.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.shared_context "authenticated user" do
   let(:user) { create(:user, :confirmed) }

data/decidim-dev/lib/decidim/dev/test/rspec_support/authorization_handlers.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "decidim/dev/dummy_authorization_handler"
 RSpec.configure do |config|
   config.before(:each) do

data/decidim-dev/lib/decidim/dev/test/rspec_support/capybara.rb CHANGED

@@ -7,7 +7,7 @@ module Decidim
   # Helpers meant to be used only during capybara test runs.
   module CapybaraTestHelpers
     def switch_to_host(host = "lvh.me")
-      unless /lvh\.me$/ =~ host
+      unless /lvh\.me$/.match?(host)
         raise "Can't switch to a custom host unless it really exists. Use `whatever.lvh.me` as a workaround."
       end
@@ -31,7 +31,8 @@ capybara_options = {
     )
   ],
   js_errors: true,
-  url_whitelist: ["http://*.lvh.me", "localhost", "127.0.0.1"]
+  url_whitelist: ["http://*.lvh.me", "localhost", "127.0.0.1"],
+  timeout: 1.minute
 }
 Capybara.register_driver :poltergeist do |app|
@@ -48,7 +49,6 @@ Capybara::Screenshot::RSpec.add_link_to_screenshot_for_failed_examples = true
 Capybara.configure do |config|
   config.always_include_port = true
   config.default_driver = :poltergeist
-  config.always_include_port = true
 end
 RSpec.configure do |config|

data/decidim-dev/lib/decidim/dev/test/rspec_support/database_cleaner.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.configure do |config|
   config.before(:suite) do
     DatabaseCleaner.strategy = :truncation

data/decidim-dev/lib/decidim/dev/test/rspec_support/engine_routes.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 module Decidim
   # This is a quick hack so all controller specs have their engine's routes
   # included as well as our Devise mapping.

data/decidim-dev/lib/decidim/dev/test/rspec_support/factory_girl.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods
 end

data/decidim-dev/lib/decidim/dev/test/rspec_support/feature.rb CHANGED

@@ -14,6 +14,14 @@ module Decidim
     end
   end
+  class DummyAdminEngine < Rails::Engine
+    engine_name "dummy_admin"
+    routes do
+      root to: proc { [200, {}, ["DUMMY ADMIN ENGINE"]] }
+    end
+  end
   class DummyResource < ActiveRecord::Base
     include HasFeature
     include Resourceable
@@ -45,8 +53,22 @@ module Decidim
   end
 end
+class DummySerializer
+  def initialize(id)
+    @id = id
+  end
+  def serialize
+    {
+      id: @id
+    }
+  end
+end
 Decidim.register_feature(:dummy) do |feature|
   feature.engine = Decidim::DummyEngine
+  feature.admin_engine = Decidim::DummyAdminEngine
+  feature.icon = "decidim/dummy.svg"
   feature.actions = %w(foo bar)
@@ -67,6 +89,14 @@ Decidim.register_feature(:dummy) do |feature|
     resource.model_class_name = "Decidim::DummyResource"
     resource.template = "decidim/dummy_resource/linked_dummys"
   end
+  feature.exports :dummies do |exports|
+    exports.collection do
+      [1, 2, 3]
+    end
+    exports.serializer DummySerializer
+  end
 end
 RSpec.configure do |config|

data/decidim-dev/lib/decidim/dev/test/rspec_support/feature_context.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.shared_context "feature" do
   let!(:manifest_name) { raise NotImplementedError }
   let(:manifest) { Decidim.find_feature_manifest(manifest_name) }

data/decidim-dev/lib/decidim/dev/test/rspec_support/geocoder.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.configure do |config|
   config.before(:each) do
     # Set geocoder configuration in test mode

data/decidim-dev/lib/decidim/dev/test/rspec_support/html_matchers.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "rspec-html-matchers"
 RSpec.configure do |config|

data/decidim-dev/lib/decidim/dev/test/rspec_support/i18n.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.configure do |config|
   config.before(:suite) do
     I18n.config.enforce_available_locales = false

data/decidim-dev/lib/decidim/dev/test/rspec_support/translation_helpers.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 # A collection of methods to help dealing with translated attributes.
 module TranslationHelpers
   # Gives the localized version of the attribute for the given locale. The

data/decidim-dev/lib/decidim/dev/test/rspec_support/warden.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 RSpec.configure do |config|
   config.include Warden::Test::Helpers, type: :feature
   config.include Devise::Test::ControllerHelpers, type: :controller

data/decidim-dev/lib/decidim/dev/test/rspec_support/webmock.rb CHANGED

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 require "webmock/rspec"
 WebMock.allow_net_connect!

data/decidim-dev/lib/decidim/dev/test/rspec_support/wisper.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "wisper/rspec/matchers"
 RSpec.configure do |config|

data/decidim-dev/lib/decidim/dev/test/spec_helper.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 ENV["RAILS_ENV"] ||= "test"
 require "rails"

data/decidim-dev/lib/generators/decidim/dummy_generator.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "rails/generators"
 require "generators/decidim/app_generator"
@@ -39,17 +40,13 @@ module Decidim
           "--skip-bundle",
           "--skip-git",
           "--skip-keeps",
+          "--skip-listen",
+          "--skip-spring",
           "--skip-test",
           "--recreate_db"
         ]
       end
-      def set_locales
-        inject_into_file "#{dummy_app_path}/config/application.rb", after: "class Application < Rails::Application" do
-          "\n    config.i18n.available_locales = %w(en ca es)\n    config.i18n.default_locale = :en"
-        end
-      end
       def decidim_dev
         template "decidim_dev.rb", "#{dummy_app_path}/config/initializers/decidim_dev.rb"

data/decidim-dev/lib/generators/decidim/templates/autoprefixer_initializer.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 module AutoprefixerRails
   class Sprockets
     singleton_class.send(:alias_method, :call_original, :call)
@@ -9,7 +10,7 @@ module AutoprefixerRails
       # Disable autoprefixer for the graphiql-rails gem's assets because it
       # breaks some of the API tests when the '-webkit' prefixes are applied to
       # its CSS.
-      return if filename =~ %r{^graphiql/.*}
+      return if filename.match?(%r{^graphiql/.*})
       call_original(input)
     end

data/decidim-dev/lib/generators/decidim/templates/decidim_dev.rb CHANGED

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
 require "decidim/dev"

data/decidim-dev/lib/tasks/locale_checker.rake ADDED

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+namespace :decidim do
+  desc "Allows a decidim installation to check whether its locales are complete"
+  task :check_locales do
+    env = {
+      "BUNDLE_GEMFILE" => File.expand_path("Gemfile"),
+      "ENFORCED_LOCALES" => Decidim.available_locales.join(",")
+    }
+    Bundler.definition.specs.each do |spec|
+      next unless spec.name.match?(/decidim-/)
+      Dir.chdir(spec.full_gem_path) do
+        Bundler.with_clean_env do
+          system(env, "bundle exec rspec spec/i18n_spec.rb")
+        end
+      end
+    end
+  end
+end

data/decidim-dev/lib/tasks/test_app.rake CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require "generators/decidim/dummy_generator"
 namespace :decidim do
@@ -13,7 +14,5 @@ namespace :decidim do
         "--quiet"
       ]
     )
-    sh "cd #{dummy_app_path} && bundle exec rake assets:precompile"
   end
 end