decidim-proposals 0.30.2 → 0.31.0.rc1

data/app/commands/decidim/proposals/hashtags_methods.rb

@@ -1,36 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A module with all the hash tags common methods for proposals
-    # and collaborative draft commands.
-    module HashtagsMethods
-      private
-
-      def title_with_hashtags
-        @title_with_hashtags ||= Decidim::ContentProcessor.parse_with_processor(:hashtag, form.title, current_organization: form.current_organization).rewrite
-      end
-
-      def body_with_hashtags
-        @body_with_hashtags ||= begin
-          ret = Decidim::ContentProcessor.parse(form.body, current_organization: form.current_organization).rewrite.strip
-          ret += "\n\n#{body_extra_hashtags.strip}" unless body_extra_hashtags.empty?
-          ret
-        end
-      end
-
-      def body_extra_hashtags
-        @body_extra_hashtags ||= if form.respond_to?(:extra_hashtags)
-                                   Decidim::ContentProcessor.parse_with_processor(
-                                     :hashtag,
-                                     form.extra_hashtags.map { |hashtag| "##{hashtag}" }.join(" "),
-                                     current_organization: form.current_organization,
-                                     extra_hashtags: true
-                                   ).rewrite
-                                 else
-                                   ""
-                                 end
-      end
-    end
-  end
-end

data/app/controllers/decidim/proposals/admin/valuation_assignments_controller.rb

@@ -1,55 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Admin
-      class ValuationAssignmentsController < Admin::ApplicationController
-        def create
-          @form = form(Admin::ValuationAssignmentForm).from_params(params)
-
-          @form.proposals.each do |proposal|
-            enforce_permission_to :assign_to_valuator, :proposals, proposal:
-          end
-
-          Admin::AssignProposalsToValuator.call(@form) do
-            on(:ok) do |_proposal|
-              flash[:notice] = I18n.t("valuation_assignments.create.success", scope: "decidim.proposals.admin")
-              redirect_to EngineRouter.admin_proxy(current_component).root_path
-            end
-
-            on(:invalid) do
-              flash.now[:alert] = I18n.t("valuation_assignments.create.invalid", scope: "decidim.proposals.admin")
-              redirect_to EngineRouter.admin_proxy(current_component).root_path
-            end
-          end
-        end
-
-        def destroy
-          @form = form(Admin::ValuationAssignmentForm).from_params(params)
-
-          @form.valuator_roles.each do |valuator_role|
-            enforce_permission_to :unassign_from_valuator, :proposals, valuator: valuator_role.user
-          end
-
-          Admin::UnassignProposalsFromValuator.call(@form) do
-            on(:ok) do |_proposal|
-              flash.keep[:notice] = I18n.t("valuation_assignments.delete.success", scope: "decidim.proposals.admin")
-              redirect_back fallback_location: EngineRouter.admin_proxy(current_component).root_path
-            end
-
-            on(:invalid) do
-              flash.keep[:alert] = I18n.t("valuation_assignments.delete.invalid", scope: "decidim.proposals.admin")
-              redirect_back fallback_location: EngineRouter.admin_proxy(current_component).root_path
-            end
-          end
-        end
-
-        private
-
-        def skip_manage_component_permission
-          true
-        end
-      end
-    end
-  end
-end

data/app/events/decidim/proposals/proposal_endorsed_event.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    class ProposalEndorsedEvent < Decidim::Events::SimpleEvent
-      i18n_attributes :endorser_nickname, :endorser_name, :endorser_path, :nickname
-
-      delegate :nickname, :name, to: :endorser, prefix: true
-
-      def nickname
-        endorser_nickname
-      end
-
-      def endorser_path
-        endorser.profile_path
-      end
-
-      def resource_text
-        resource.body
-      end
-
-      private
-
-      def endorser
-        @endorser ||= Decidim::UserPresenter.new(endorser_user)
-      end
-
-      def endorser_user
-        @endorser_user ||= Decidim::User.find_by(id: extra[:endorser_id])
-      end
-    end
-  end
-end

data/app/forms/decidim/proposals/admin/proposals_file_import_form.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Admin
-      # A form object to be used when admin users want to import proposals from
-      # a file.
-      class ProposalsFileImportForm < Decidim::Admin::ImportForm
-        attribute :user_group_id, Integer
-
-        def user_groups
-          Decidim::UserGroups::ManageableUserGroups.for(current_user).verified
-        end
-
-        protected
-
-        def user_group
-          @user_group ||= Decidim::UserGroup.find_by(
-            organization: current_organization,
-            id: user_group_id.to_i
-          )
-        end
-
-        def importer_context
-          context[:user_group] = user_group
-          context
-        end
-      end
-    end
-  end
-end

data/app/forms/decidim/proposals/admin/valuation_assignment_form.rb

@@ -1,38 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Admin
-      class ValuationAssignmentForm < Decidim::Form
-        attribute :id, Integer
-        attribute :proposal_ids, Array
-        attribute :valuator_role_ids, Array
-
-        validates :valuator_roles, :proposals, :current_component, presence: true
-        validate :same_participatory_space
-
-        def proposals
-          @proposals ||= Decidim::Proposals::Proposal.where(component: current_component, id: proposal_ids).uniq
-        end
-
-        def valuator_roles
-          @valuator_roles ||= current_component.participatory_space
-                                               .user_roles(:valuator)
-                                               .order_by_name
-                                               .where(id: valuator_role_ids)
-        end
-
-        def same_participatory_space
-          return if valuator_roles.empty? || !current_component
-
-          valuator_roles.each do |valuator_role|
-            if current_component.participatory_space != valuator_role.participatory_space
-              errors.add(:id, :invalid)
-              break
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/metrics/accepted_proposals_metric_manage.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Metrics
-      class AcceptedProposalsMetricManage < Decidim::Proposals::Metrics::ProposalsMetricManage
-        def metric_name
-          "accepted_proposals"
-        end
-
-        private
-
-        def query
-          return @query if @query
-
-          spaces = Decidim.participatory_space_manifests.flat_map do |manifest|
-            manifest.participatory_spaces.call(@organization).public_spaces
-          end
-          @query = Decidim::Proposals::Proposal.where(component: visible_components_from_spaces(spaces)).joins(:component)
-                                               .left_outer_joins(:category)
-          @query = @query.where(decidim_proposals_proposals: { created_at: ..end_time }).accepted
-          @query = @query.group("decidim_categorizations.id", :participatory_space_type, :participatory_space_id)
-          @query
-        end
-
-        def quantity
-          @quantity ||= query.where(decidim_proposals_proposals: { created_at: start_time.. }).count
-        end
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/metrics/endorsements_metric_manage.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Metrics
-      class EndorsementsMetricManage < Decidim::MetricManage
-        def metric_name
-          "endorsements"
-        end
-
-        def save
-          cumulative.each do |key, cumulative_value|
-            next if cumulative_value.zero?
-
-            quantity_value = quantity[key] || 0
-            taxonomy_id, space_type, space_id, proposal_id = key
-            record = Decidim::Metric.find_or_initialize_by(day: @day.to_s, metric_type: @metric_name,
-                                                           organization: @organization, decidim_taxonomy_id: taxonomy_id,
-                                                           participatory_space_type: space_type, participatory_space_id: space_id,
-                                                           related_object_type: "Decidim::Proposals::Proposal", related_object_id: proposal_id)
-            record.assign_attributes(cumulative: cumulative_value, quantity: quantity_value)
-            record.save!
-          end
-        end
-
-        private
-
-        def query
-          return @query if @query
-
-          components = Decidim::Component.where(participatory_space: retrieve_participatory_spaces).published
-          proposals = Decidim::Proposals::Proposal.where(component: components).not_withdrawn
-          join_components = "INNER JOIN decidim_components ON decidim_components.manifest_name = 'proposals' AND proposals.decidim_component_id = decidim_components.id"
-          join_taxonomies = <<~EOJOINCATS
-            LEFT OUTER JOIN decidim_taxonomizations
-            ON (proposals.id = decidim_taxonomizations.taxonomizable_id
-            AND decidim_taxonomizations.taxonomizable_type = 'Decidim::Proposals::Proposal')
-          EOJOINCATS
-          @query = Decidim::Endorsement.joins("INNER JOIN decidim_proposals_proposals proposals ON resource_id = proposals.id")
-                                       .joins(join_components)
-                                       .joins(join_taxonomies)
-                                       .where(resource_id: proposals.pluck(:id))
-                                       .where(resource_type: Decidim::Proposals::Proposal.name)
-          @query = @query.where(decidim_endorsements: { created_at: ..end_time })
-          @query = @query.group("decidim_taxonomizations.taxonomy_id",
-                                :participatory_space_type,
-                                :participatory_space_id,
-                                :resource_id)
-          @query
-        end
-
-        def quantity
-          @quantity ||= query.where(decidim_endorsements: { created_at: start_time.. }).count
-        end
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/metrics/proposal_followers_metric_measure.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Metrics
-      # Searches for unique Users following the next objects
-      #  - Proposals
-      #  - CollaborativeDrafts
-      class ProposalFollowersMetricMeasure < Decidim::MetricMeasure
-        def valid?
-          super && @resource.is_a?(Decidim::Component)
-        end
-
-        def calculate
-          cumulative_users = []
-          cumulative_users |= retrieve_proposals_followers.pluck(:decidim_user_id)
-          cumulative_users |= retrieve_drafts_followers.pluck(:decidim_user_id)
-
-          quantity_users = []
-          quantity_users |= retrieve_proposals_followers(from_start: true).pluck(:decidim_user_id)
-          quantity_users |= retrieve_drafts_followers(from_start: true).pluck(:decidim_user_id)
-
-          {
-            cumulative_users: cumulative_users.uniq,
-            quantity_users: quantity_users.uniq
-          }
-        end
-
-        private
-
-        def retrieve_proposals_followers(from_start: false)
-          @proposals_followers ||= Decidim::Follow.where(followable: retrieve_proposals).joins(:user)
-                                                  .where(decidim_follows: { created_at: ..end_time })
-
-          return @proposals_followers.where(decidim_follows: { created_at: start_time.. }) if from_start
-
-          @proposals_followers
-        end
-
-        def retrieve_drafts_followers(from_start: false)
-          @drafts_followers ||= Decidim::Follow.where(followable: retrieve_collaborative_drafts).joins(:user)
-                                               .where(decidim_follows: { created_at: ..end_time })
-          return @drafts_followers.where(decidim_follows: { created_at: start_time.. }) if from_start
-
-          @drafts_followers
-        end
-
-        def retrieve_proposals
-          Decidim::Proposals::Proposal.where(component: @resource).not_withdrawn
-        end
-
-        def retrieve_collaborative_drafts
-          Decidim::Proposals::CollaborativeDraft.where(component: @resource).except_withdrawn
-        end
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/metrics/proposal_participants_metric_measure.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Metrics
-      # Searches for Participants in the following actions
-      #  - Create a proposal (Proposals)
-      #  - Vote to a proposal (Proposals)
-      #  - Endorse (Proposals)
-      class ProposalParticipantsMetricMeasure < Decidim::MetricMeasure
-        def valid?
-          super && @resource.is_a?(Decidim::Component)
-        end
-
-        def calculate
-          cumulative_users = []
-          cumulative_users |= retrieve_votes.pluck(:decidim_author_id)
-          cumulative_users |= retrieve_endorsements.pluck(:decidim_author_id)
-          cumulative_users |= retrieve_proposals.pluck("decidim_coauthorships.decidim_author_id") # To avoid ambiguousness must be called this way
-
-          quantity_users = []
-          quantity_users |= retrieve_votes(from_start: true).pluck(:decidim_author_id)
-          quantity_users |= retrieve_endorsements(from_start: true).pluck(:decidim_author_id)
-          quantity_users |= retrieve_proposals(from_start: true).pluck("decidim_coauthorships.decidim_author_id") # To avoid ambiguousness must be called this way
-
-          {
-            cumulative_users: cumulative_users.uniq,
-            quantity_users: quantity_users.uniq
-          }
-        end
-
-        private
-
-        def retrieve_proposals(from_start: false)
-          @proposals ||= Decidim::Proposals::Proposal.where(component: @resource).joins(:coauthorships)
-                                                     .includes(:votes, :endorsements)
-                                                     .where(decidim_coauthorships: {
-                                                              decidim_author_type: [
-                                                                "Decidim::UserBaseEntity",
-                                                                "Decidim::Organization",
-                                                                "Decidim::Meetings::Meeting"
-                                                              ]
-                                                            })
-                                                     .where(decidim_proposals_proposals: { published_at: ..end_time })
-                                                     .not_withdrawn
-
-          return @proposals.where(decidim_proposals_proposals: { published_at: start_time.. }) if from_start
-
-          @proposals
-        end
-
-        def retrieve_votes(from_start: false)
-          @votes ||= Decidim::Proposals::ProposalVote.joins(:proposal).where(proposal: retrieve_proposals).joins(:author)
-                                                     .where(decidim_proposals_proposal_votes: { created_at: ..end_time })
-
-          return @votes.where(decidim_proposals_proposal_votes: { created_at: start_time.. }) if from_start
-
-          @votes
-        end
-
-        def retrieve_endorsements(from_start: false)
-          @endorsements ||= Decidim::Endorsement.joins("INNER JOIN decidim_proposals_proposals proposals ON resource_id = proposals.id")
-                                                .where(resource: retrieve_proposals)
-                                                .where(decidim_endorsements: { created_at: ..end_time })
-                                                .where(decidim_author_type: "Decidim::UserBaseEntity")
-
-          return @endorsements.where(decidim_endorsements: { created_at: start_time.. }) if from_start
-
-          @endorsements
-        end
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/metrics/proposals_metric_manage.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Metrics
-      class ProposalsMetricManage < Decidim::MetricManage
-        def metric_name
-          "proposals"
-        end
-
-        def save
-          cumulative.each do |key, cumulative_value|
-            next if cumulative_value.zero?
-
-            quantity_value = quantity[key] || 0
-            taxonomy_id, space_type, space_id = key
-            record = Decidim::Metric.find_or_initialize_by(day: @day.to_s, metric_type: @metric_name,
-                                                           organization: @organization, decidim_taxonomy_id: taxonomy_id,
-                                                           participatory_space_type: space_type, participatory_space_id: space_id)
-            record.assign_attributes(cumulative: cumulative_value, quantity: quantity_value)
-            record.save!
-          end
-        end
-
-        private
-
-        def query
-          return @query if @query
-
-          spaces = Decidim.participatory_space_manifests.flat_map do |manifest|
-            manifest.participatory_spaces.call(@organization)
-          end
-          @query = Decidim::Proposals::Proposal.where(component: visible_components_from_spaces(spaces)).joins(:component)
-                                               .left_outer_joins(:taxonomizations)
-          @query = @query.where(decidim_proposals_proposals: { published_at: ..end_time }).not_withdrawn.not_hidden
-          @query = @query.group("decidim_taxonomizations.taxonomy_id",
-                                :participatory_space_type,
-                                :participatory_space_id)
-          @query
-        end
-
-        def quantity
-          @quantity ||= query.where(decidim_proposals_proposals: { published_at: start_time.. }).count
-        end
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/metrics/votes_metric_manage.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    module Metrics
-      class VotesMetricManage < Decidim::MetricManage
-        def metric_name
-          "votes"
-        end
-
-        def save
-          cumulative.each do |key, cumulative_value|
-            next if cumulative_value.zero?
-
-            quantity_value = quantity[key] || 0
-            taxonomy_id, space_type, space_id, proposal_id = key
-            record = Decidim::Metric.find_or_initialize_by(day: @day.to_s, metric_type: @metric_name,
-                                                           organization: @organization, decidim_taxonomy_id: taxonomy_id,
-                                                           participatory_space_type: space_type, participatory_space_id: space_id,
-                                                           related_object_type: "Decidim::Proposals::Proposal", related_object_id: proposal_id)
-            record.assign_attributes(cumulative: cumulative_value, quantity: quantity_value)
-            record.save!
-          end
-        end
-
-        private
-
-        def query
-          return @query if @query
-
-          spaces = Decidim.participatory_space_manifests.flat_map do |manifest|
-            manifest.participatory_spaces.call(@organization).public_spaces
-          end
-          proposal_ids = Decidim::Proposals::Proposal.where(component: visible_components_from_spaces(spaces)).not_withdrawn.not_hidden.pluck(:id)
-          @query = Decidim::Proposals::ProposalVote.joins(proposal: :component)
-                                                   .left_outer_joins(proposal: :taxonomizations)
-                                                   .where(proposal: proposal_ids)
-          @query = @query.where(decidim_proposals_proposal_votes: { created_at: ..end_time })
-          @query = @query.group("decidim_taxonomizations.taxonomy_id",
-                                :participatory_space_type,
-                                :participatory_space_id,
-                                :decidim_proposal_id)
-          @query
-        end
-
-        def quantity
-          @quantity ||= query.where(decidim_proposals_proposal_votes: { created_at: start_time.. }).count
-        end
-      end
-    end
-  end
-end

data/app/views/decidim/proposals/admin/imports/_proposals_fields.html.erb

@@ -1,11 +0,0 @@
-<% if current_organization.user_groups_enabled? && form.object.user_groups.any? %>
-  <div>
-    <%= form.select(
-        :user_group_id,
-        form.object.user_groups.map { |g| [g.name, g.id] },
-        selected: form.object.user_group_id.presence,
-        include_blank: current_user.name,
-        label: true
-    ) %>
-  </div>
-<% end %>

data/app/views/decidim/proposals/admin/proposals/_endorsers.html.erb

@@ -1,25 +0,0 @@
-<div class="card-section">
-  <div class="row column">
-    <span class="component__show-title"><%= t "endorsers", scope: "decidim.proposals.admin.proposals.show" %></span>
-    <ul id="proposal-endorsers-list">
-      <% presented_endorsers.first(5).each do |presented_endorser| %>
-        <li>
-          <%= link_to_if(
-                presented_endorser.profile_path.present?,
-                presented_endorser.name,
-                presented_endorser.profile_path,
-                target: :blank
-              ) %>
-        </li>
-      <% end %>
-      <% if presented_endorsers.count > 5 %>
-        <li>
-          <%= link_to(
-                t("n_more_endorsers", scope: "decidim.proposals.admin.proposals.show", count: presented_endorsers.count - 5),
-                resource_locator(proposal).path
-              ) %>
-        </li>
-      <% end %>
-    </ul>
-  </div>
-</div>

data/app/views/decidim/proposals/admin/proposals/bulk_actions/_assign_to_valuator.html.erb

@@ -1,19 +0,0 @@
-<div id="js-assign-proposals-to-valuator-actions" class="item_show__header__action-options js-bulk-action-form hide">
-  <%= form_tag(valuation_assignment_path, method: :post, id: "js-form-assign-proposals-to-valuator", class: "form form-defaults w-full") do %>
-    <div class="hide">
-      <% proposals.each do |proposal| %>
-        <%= check_box_tag "proposal_ids[]", proposal.id, false, class: "js-check-all-proposal js-proposal-id-#{proposal.id}" %>
-      <% end %>
-    </div>
-
-    <label class="w-full font-semibold" for="assign_valuator_role_ids">
-      <%= t("decidim.proposals.admin.proposals.index.assign_to_valuator") %>
-      <%= render partial: "decidim/proposals/admin/proposals/bulk_actions/valuators_picker", locals: { participatory_space: current_participatory_space, select_id: "assign_valuator_role_ids" } %>
-    </label>
-
-    <div class="flex justify-end gap-x-4 mt-2">
-      <%= submit_tag(t("decidim.proposals.admin.proposals.index.assign_to_valuator_button"), id: "js-submit-assign-proposals-to-valuator", class: "button button__sm button__secondary small button--simple float-left") %>
-      <button class="button button__sm button__secondary js-cancel-bulk-action" type="button"><%= t("decidim.proposals.admin.proposals.index.cancel") %></button>
-    </div>
-  <% end %>
-</div>

data/app/views/decidim/proposals/admin/proposals/bulk_actions/_unassign_from_valuator.html.erb

@@ -1,19 +0,0 @@
-<div id="js-unassign-proposals-from-valuator-actions" class="item_show__header__action-options js-bulk-action-form hide">
-  <%= form_tag(valuation_assignment_path, method: :delete, id: "js-form-unassign-proposals-from-valuator", class: "form form-defaults w-full") do %>
-    <div class="hide">
-      <% proposals.each do |proposal| %>
-        <%= check_box_tag "proposal_ids[]", proposal.id, false, class: "js-check-all-proposal js-proposal-id-#{proposal.id}" %>
-      <% end %>
-    </div>
-
-    <label class="w-full font-semibold" for="unassign_valuator_role_ids">
-      <%= t("decidim.proposals.admin.proposals.index.unassign_from_valuator") %>
-      <%= render partial: "decidim/proposals/admin/proposals/bulk_actions/valuators_picker", locals: { participatory_space: current_participatory_space, select_id: "unassign_valuator_role_ids" } %>
-    </label>
-
-    <div class="flex justify-end gap-x-4 mt-2">
-      <%= submit_tag(t("decidim.proposals.admin.proposals.index.unassign_from_valuator_button"), id: "js-submit-unassign-proposals-from-valuator", class: "button button__sm button__secondary small button--simple float-left") %>
-      <button class="button button__sm button__secondary js-cancel-bulk-action" type="button"><%= t("decidim.proposals.admin.proposals.index.cancel") %></button>
-    </div>
-  <% end %>
-</div>

data/lib/decidim/proposals/valuatable.rb

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A set of methods and features related to proposal valuations.
-    module Valuatable
-      extend ActiveSupport::Concern
-      include Decidim::Comments::Commentable
-
-      included do
-        has_many :valuation_assignments, foreign_key: "decidim_proposal_id", dependent: :destroy,
-                                         counter_cache: :valuation_assignments_count, class_name: "Decidim::Proposals::ValuationAssignment"
-
-        def valuators
-          valuator_role_ids = valuation_assignments.where(proposal: self).pluck(:valuator_role_id)
-          user_ids = participatory_space.user_roles(:valuator).where(id: valuator_role_ids).pluck(:decidim_user_id)
-          participatory_space.organization.users.where(id: user_ids)
-        end
-      end
-    end
-  end
-end