decidim-initiatives 0.27.4 → 0.28.0.rc5

data/lib/decidim/initiatives/menu.rb

@@ -0,0 +1,150 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    class Menu
+      def self.register_menu!
+        Decidim.menu :menu do |menu|
+          menu.add_item :initiatives,
+                        I18n.t("menu.initiatives", scope: "decidim"),
+                        decidim_initiatives.initiatives_path,
+                        position: 2.4,
+                        active: %r{^/(initiatives|create_initiative)},
+                        if: !Decidim::InitiativesType.joins(:scopes).where(organization: current_organization).all.empty?
+        end
+      end
+
+      def self.register_home_content_block_menu!
+        Decidim.menu :home_content_block_menu do |menu|
+          menu.add_item :initiatives,
+                        I18n.t("menu.initiatives", scope: "decidim"),
+                        decidim_initiatives.initiatives_path,
+                        position: 30,
+                        active: :inclusive,
+                        if: !Decidim::InitiativesType.joins(:scopes).where(organization: current_organization).all.empty?
+        end
+      end
+
+      def self.register_admin_menu_modules!
+        Decidim.menu :admin_menu_modules do |menu|
+          menu.add_item :initiatives,
+                        I18n.t("menu.initiatives", scope: "decidim.admin"),
+                        decidim_admin_initiatives.initiatives_path,
+                        icon_name: "lightbulb-flash-line",
+                        position: 2.4,
+                        active: is_active_link?(decidim_admin_initiatives.initiatives_path) ||
+                                is_active_link?(decidim_admin_initiatives.initiatives_types_path) ||
+                                is_active_link?(
+                                  decidim_admin_initiatives.edit_initiatives_setting_path(
+                                    Decidim::InitiativesSettings.find_or_create_by!(organization: current_organization)
+                                  )
+                                ),
+                        if: allowed_to?(:enter, :space_area, space_name: :initiatives)
+        end
+      end
+
+      def self.register_admin_initiatives_components_menu!
+        Decidim.menu :admin_initiatives_components_menu do |menu|
+          current_participatory_space.components.each do |component|
+            caption = translated_attribute(component.name)
+            if component.primary_stat.present?
+              caption += content_tag(:span, component.primary_stat,
+                                     class: component.primary_stat.zero? ? "component-counter component-counter--off" : "component-counter")
+            end
+
+            menu.add_item [component.manifest_name, component.id].join("_"),
+                          caption.html_safe,
+                          manage_component_path(component),
+                          active: is_active_link?(manage_component_path(component)) ||
+                                  is_active_link?(decidim_admin_initiatives.edit_component_path(current_participatory_space, component)) ||
+                                  is_active_link?(decidim_admin_initiatives.edit_component_permissions_path(current_participatory_space, component)) ||
+                                  participatory_space_active_link?(component),
+                          if: component.manifest.admin_engine # && user_role_config.component_is_accessible?(component.manifest_name)
+          end
+        end
+      end
+
+      def self.register_admin_initiative_menu!
+        Decidim.menu :admin_initiative_menu do |menu|
+          menu.add_item :edit_initiative,
+                        I18n.t("menu.information", scope: "decidim.admin"),
+                        decidim_admin_initiatives.edit_initiative_path(current_participatory_space),
+                        icon_name: "information-line",
+                        if: allowed_to?(:edit, :initiative, initiative: current_participatory_space)
+
+          menu.add_item :initiative_committee_requests,
+                        I18n.t("menu.committee_members", scope: "decidim.admin"),
+                        decidim_admin_initiatives.initiative_committee_requests_path(current_participatory_space),
+                        icon_name: "group-line",
+                        if: current_participatory_space.promoting_committee_enabled? && allowed_to?(:manage_membership, :initiative,
+                                                                                                    initiative: current_participatory_space)
+
+          menu.add_item :components,
+                        I18n.t("menu.components", scope: "decidim.admin"),
+                        decidim_admin_initiatives.components_path(current_participatory_space),
+                        icon_name: "tools-line",
+                        active: is_active_link?(decidim_admin_initiatives.components_path(current_participatory_space),
+                                                ["decidim/initiatives/admin/components", %w(index new edit)]),
+                        if: allowed_to?(:read, :component, initiative: current_participatory_space),
+                        submenu: { target_menu: :admin_initiatives_components_menu }
+          menu.add_item :initiative_attachments,
+                        I18n.t("menu.attachments", scope: "decidim.admin"),
+                        decidim_admin_initiatives.initiative_attachments_path(current_participatory_space),
+                        icon_name: "attachment-2",
+                        if: allowed_to?(:read, :attachment, initiative: current_participatory_space)
+
+          menu.add_item :moderations,
+                        I18n.t("menu.moderations", scope: "decidim.admin"),
+                        decidim_admin_initiatives.moderations_path(current_participatory_space),
+                        icon_name: "flag-line",
+                        if: allowed_to?(:read, :moderation)
+        end
+      end
+
+      def self.register_admin_initiative_actions_menu!
+        Decidim.menu :admin_initiative_actions_menu do |menu|
+          menu.add_item :answer_initiative,
+                        I18n.t("actions.answer", scope: "decidim.initiatives"),
+                        decidim_admin_initiatives.edit_initiative_answer_path(current_participatory_space),
+                        if: allowed_to?(:answer, :initiative, initiative: current_participatory_space)
+
+          menu.add_item :initiative_permissions,
+                        I18n.t("actions.permissions", scope: "decidim.admin"),
+                        decidim_admin_initiatives.edit_initiative_permissions_path(current_participatory_space, resource_name: :initiative),
+                        if: current_participatory_space.allow_resource_permissions? && allowed_to?(:update, :initiative, initiative: current_participatory_space)
+        end
+      end
+
+      def self.register_admin_initiatives_menu!
+        Decidim.menu :admin_initiatives_menu do |menu|
+          menu.add_item :initiatives,
+                        I18n.t("menu.initiatives", scope: "decidim.admin"),
+                        decidim_admin_initiatives.initiatives_path,
+                        position: 1.0,
+                        active: is_active_link?(decidim_admin_initiatives.initiatives_path),
+                        if: allowed_to?(:index, :initiative)
+
+          menu.add_item :initiatives_types,
+                        I18n.t("menu.initiatives_types", scope: "decidim.admin"),
+                        decidim_admin_initiatives.initiatives_types_path,
+                        active: is_active_link?(decidim_admin_initiatives.initiatives_types_path),
+                        if: allowed_to?(:manage, :initiative_type)
+
+          menu.add_item :initiatives_settings,
+                        I18n.t("menu.initiatives_settings", scope: "decidim.admin"),
+                        decidim_admin_initiatives.edit_initiatives_setting_path(
+                          Decidim::InitiativesSettings.find_or_create_by!(
+                            organization: current_organization
+                          )
+                        ),
+                        active: is_active_link?(
+                          decidim_admin_initiatives.edit_initiatives_setting_path(
+                            Decidim::InitiativesSettings.find_or_create_by!(organization: current_organization)
+                          )
+                        ),
+                        if: allowed_to?(:update, :initiatives_settings)
+        end
+      end
+    end
+  end
+end

data/lib/decidim/initiatives/participatory_space.rb

@@ -15,11 +15,13 @@ Decidim.register_participatory_space(:initiatives) do |participatory_space|
   end
 
   participatory_space.participatory_spaces do |organization|
-    Decidim::Initiative.where(organization: organization)
+    Decidim::Initiative.where(organization:)
   end
 
   participatory_space.query_type = "Decidim::Initiatives::InitiativeType"
 
+  participatory_space.breadcrumb_cell = "decidim/initiatives/initiative_dropdown_metadata"
+
   participatory_space.register_resource(:initiative) do |resource|
     resource.actions = %w(comment)
     resource.permissions_class_name = "Decidim::Initiatives::Permissions"
@@ -30,7 +32,7 @@ Decidim.register_participatory_space(:initiatives) do |participatory_space|
 
   participatory_space.register_resource(:initiatives_type) do |resource|
     resource.model_class_name = "Decidim::InitiativesType"
-    resource.actions = %w(vote)
+    resource.actions = %w(vote create)
   end
 
   participatory_space.model_class_name = "Decidim::Initiative"
@@ -45,95 +47,8 @@ Decidim.register_participatory_space(:initiatives) do |participatory_space|
   end
 
   participatory_space.seeds do
-    seeds_root = File.join(__dir__, "..", "..", "..", "db", "seeds")
-    organization = Decidim::Organization.first
-
-    Decidim::ContentBlock.create(
-      organization: organization,
-      weight: 33,
-      scope_name: :homepage,
-      manifest_name: :highlighted_initiatives,
-      published_at: Time.current
-    )
-
-    3.times do |n|
-      type = Decidim::InitiativesType.create!(
-        title: Decidim::Faker::Localized.sentence(word_count: 5),
-        description: Decidim::Faker::Localized.sentence(word_count: 25),
-        organization: organization,
-        banner_image: ActiveStorage::Blob.create_and_upload!(
-          io: File.open(File.join(seeds_root, "city2.jpeg")),
-          filename: "banner_image.jpeg",
-          content_type: "image/jpeg",
-          metadata: nil
-        )
-      )
-
-      organization.top_scopes.each do |scope|
-        Decidim::InitiativesTypeScope.create(
-          type: type,
-          scope: scope,
-          supports_required: (n + 1) * 1000
-        )
-      end
-    end
-
-    Decidim::Initiative.states.keys.each do |state|
-      Decidim::Initiative.skip_callback(:save, :after, :notify_state_change, raise: false)
-      Decidim::Initiative.skip_callback(:create, :after, :notify_creation, raise: false)
-
-      params = {
-        title: Decidim::Faker::Localized.sentence(word_count: 3),
-        description: Decidim::Faker::Localized.sentence(word_count: 25),
-        scoped_type: Decidim::InitiativesTypeScope.reorder(Arel.sql("RANDOM()")).first,
-        state: state,
-        signature_type: "online",
-        signature_start_date: Date.current - 7.days,
-        signature_end_date: Date.current + 7.days,
-        published_at: 7.days.ago,
-        author: Decidim::User.reorder(Arel.sql("RANDOM()")).first,
-        organization: organization
-      }
+    require "decidim/initiatives/seeds"
 
-      initiative = Decidim.traceability.perform_action!(
-        "publish",
-        Decidim::Initiative,
-        organization.users.first,
-        visibility: "all"
-      ) do
-        Decidim::Initiative.create!(params)
-      end
-      initiative.add_to_index_as_search_resource
-
-      Decidim::Comments::Seed.comments_for(initiative)
-
-      Decidim::Attachment.create!(
-        title: Decidim::Faker::Localized.sentence(word_count: 2),
-        description: Decidim::Faker::Localized.sentence(word_count: 5),
-        attached_to: initiative,
-        content_type: "image/jpeg",
-        file: ActiveStorage::Blob.create_and_upload!(
-          io: File.open(File.join(seeds_root, "city.jpeg")),
-          filename: "city.jpeg",
-          content_type: "image/jpeg",
-          metadata: nil
-        )
-      )
-
-      Decidim::Initiatives.default_components.each do |component_name|
-        component = Decidim::Component.create!(
-          name: Decidim::Components::Namer.new(initiative.organization.available_locales, component_name).i18n_name,
-          manifest_name: component_name,
-          published_at: Time.current,
-          participatory_space: initiative
-        )
-
-        next unless component_name.in? ["pages", :pages]
-
-        Decidim::Pages::CreatePage.call(component) do
-          on(:invalid) { raise "Can't create page" }
-        end
-      end
-    end
+    Decidim::Initiatives::Seeds.new.call
   end
 end

data/lib/decidim/initiatives/query_extensions.rb

@@ -15,7 +15,7 @@ module Decidim
           description "Lists all initiative types"
         end
 
-        type.field :initiatives_type, InitiativeApiType, null: true, description: "Finds a initiative type" do
+        type.field :initiatives_type, InitiativeApiType, null: true, description: "Finds an initiative type" do
           argument :id, GraphQL::Types::ID, "The ID of the initiative type", required: true
         end
 
@@ -30,7 +30,7 @@ module Decidim
         type.field :initiative,
                    Decidim::Initiatives::InitiativeType,
                    null: true,
-                   description: "Finds a initiative" do
+                   description: "Finds an initiative" do
           argument :id, GraphQL::Types::ID, "The ID of the participatory space", required: false
         end
       end
@@ -44,19 +44,19 @@ module Decidim
       def initiatives_type(id:)
         Decidim::InitiativesType.find_by(
           organization: context[:current_organization],
-          id: id
+          id:
         )
       end
 
       def initiatives(filter: {}, order: {})
         manifest = Decidim.participatory_space_manifests.select { |m| m.name == :initiatives }.first
-        Decidim::Core::ParticipatorySpaceListBase.new(manifest: manifest).call(object, { filter: filter, order: order }, context)
+        Decidim::Core::ParticipatorySpaceListBase.new(manifest:).call(object, { filter:, order: }, context)
       end
 
       def initiative(id: nil)
         manifest = Decidim.participatory_space_manifests.select { |m| m.name == :initiatives }.first
 
-        Decidim::Core::ParticipatorySpaceFinderBase.new(manifest: manifest).call(object, { id: id }, context)
+        Decidim::Core::ParticipatorySpaceFinderBase.new(manifest:).call(object, { id: }, context)
       end
     end
   end

data/lib/decidim/initiatives/seeds.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+require "decidim/components/namer"
+require "decidim/seeds"
+
+module Decidim
+  module Initiatives
+    class Seeds < Decidim::Seeds
+      def call
+        organization = Decidim::Organization.first
+
+        Decidim::ContentBlock.create(
+          organization:,
+          weight: 33,
+          scope_name: :homepage,
+          manifest_name: :highlighted_initiatives,
+          published_at: Time.current
+        )
+
+        3.times do |n|
+          type = Decidim::InitiativesType.create!(
+            title: Decidim::Faker::Localized.sentence(word_count: 5),
+            description: Decidim::Faker::Localized.sentence(word_count: 25),
+            organization:,
+            banner_image: ::Faker::Boolean.boolean(true_ratio: 0.5) ? banner_image : nil # Keep after organization
+          )
+
+          organization.top_scopes.each do |scope|
+            Decidim::InitiativesTypeScope.create(
+              type:,
+              scope:,
+              supports_required: (n + 1) * 1000
+            )
+          end
+        end
+
+        Decidim::Initiative.states.keys.each do |state|
+          Decidim::Initiative.skip_callback(:save, :after, :notify_state_change, raise: false)
+          Decidim::Initiative.skip_callback(:create, :after, :notify_creation, raise: false)
+
+          params = {
+            title: Decidim::Faker::Localized.sentence(word_count: 3),
+            description: Decidim::Faker::Localized.sentence(word_count: 25),
+            scoped_type: Decidim::InitiativesTypeScope.all.sample,
+            state:,
+            signature_type: "online",
+            signature_start_date: Date.current - 7.days,
+            signature_end_date: Date.current + 7.days,
+            published_at: 7.days.ago,
+            author: Decidim::User.all.sample,
+            organization:
+          }
+
+          initiative = Decidim.traceability.perform_action!(
+            "publish",
+            Decidim::Initiative,
+            organization.users.first,
+            visibility: "all"
+          ) do
+            Decidim::Initiative.create!(params)
+          end
+          initiative.add_to_index_as_search_resource
+
+          if %w(published rejected accepted).include? state
+            users = []
+            rand(50).times do
+              author = (Decidim::User.all - users).sample
+              initiative.votes.create!(author:, scope: initiative.scope, hash_id: SecureRandom.hex)
+              users << author
+            end
+          end
+
+          Decidim::Comments::Seed.comments_for(initiative)
+
+          create_attachment(attached_to: initiative, filename: "city.jpeg")
+
+          Decidim::Initiatives.default_components.each do |component_name|
+            component = Decidim::Component.create!(
+              name: Decidim::Components::Namer.new(initiative.organization.available_locales, component_name).i18n_name,
+              manifest_name: component_name,
+              published_at: Time.current,
+              participatory_space: initiative
+            )
+
+            next unless component_name.in? ["pages", :pages]
+
+            Decidim::Pages::CreatePage.call(component) do
+              on(:invalid) { raise "Cannot create page" }
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/decidim/initiatives/test/factories.rb

@@ -110,10 +110,28 @@ FactoryBot.define do
   end
 
   factory :initiative, class: "Decidim::Initiative" do
-    title { generate_localized_title }
-    description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
+    transient do
+      skip_injection { false }
+    end
+
+    title do
+      if skip_injection
+        Decidim::Faker::Localized.localized { generate(:title) }
+      else
+        Decidim::Faker::Localized.localized { "<script>alert(\"Initiative TITLE\")</script> #{generate(:title)}" }
+      end
+    end
+    description do
+      Decidim::Faker::Localized.wrapped("<p>", "</p>") do
+        if skip_injection
+          Decidim::Faker::Localized.localized { generate(:title) }
+        else
+          Decidim::Faker::Localized.localized { "<script>alert(\"Meetings description\");</script> #{generate(:title)}" }
+        end
+      end
+    end
     organization
-    author { create(:user, :confirmed, organization: organization) }
+    author { create(:user, :confirmed, organization:) }
     published_at { Time.current }
     state { "published" }
     signature_type { "online" }
@@ -122,14 +140,14 @@ FactoryBot.define do
 
     scoped_type do
       create(:initiatives_type_scope,
-             type: create(:initiatives_type, organization: organization, signature_type: signature_type))
+             type: create(:initiatives_type, organization:, signature_type:))
     end
 
     after(:create) do |initiative|
       if initiative.author.is_a?(Decidim::User) && Decidim::Authorization.where(user: initiative.author).where.not(granted_at: nil).none?
         create(:authorization, user: initiative.author, granted_at: Time.now.utc)
       end
-      create_list(:initiatives_committee_member, 3, initiative: initiative)
+      create_list(:initiatives_committee_member, 3, initiative:)
     end
 
     trait :created do
@@ -199,12 +217,12 @@ FactoryBot.define do
     trait :with_user_extra_fields_collection do
       scoped_type do
         create(:initiatives_type_scope,
-               type: create(:initiatives_type, :with_user_extra_fields_collection, organization: organization))
+               type: create(:initiatives_type, :with_user_extra_fields_collection, organization:))
       end
     end
 
     trait :with_area do
-      area { create(:area, organization: organization) }
+      area { create(:area, organization:) }
     end
 
     trait :with_documents do

data/lib/decidim/initiatives/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-initiatives version.
   module Initiatives
     def self.version
-      "0.27.4"
+      "0.28.0.rc5"
     end
   end
 end

data/lib/decidim/initiatives.rb

@@ -75,7 +75,7 @@ module Decidim
     # a printed version of the initiative from the administration
     # panel.
     config_accessor :print_enabled do
-      true
+      false
     end
 
     # Set a service to generate a timestamp on each vote. The

data/lib/tasks/decidim_initiatives.rake

@@ -26,7 +26,7 @@ namespace :decidim_initiatives do
       .where.not(first_progress_notification_at: nil)
       .where(second_progress_notification_at: nil).find_each do |initiative|
       if initiative.percentage >= Decidim::Initiatives.second_notification_percentage
-        notifier = Decidim::Initiatives::ProgressNotifier.new(initiative: initiative)
+        notifier = Decidim::Initiatives::ProgressNotifier.new(initiative:)
         notifier.notify
 
         initiative.second_progress_notification_at = Time.now.utc
@@ -38,7 +38,7 @@ namespace :decidim_initiatives do
       .published
       .where(first_progress_notification_at: nil).find_each do |initiative|
       if initiative.percentage >= Decidim::Initiatives.first_notification_percentage
-        notifier = Decidim::Initiatives::ProgressNotifier.new(initiative: initiative)
+        notifier = Decidim::Initiatives::ProgressNotifier.new(initiative:)
         notifier.notify
 
         initiative.first_progress_notification_at = Time.now.utc

data/lib/tasks/initiatives/upgrade/decidim_initiatives_upgrade_tasks.rake

@@ -7,7 +7,7 @@ namespace :decidim do
       task fix_broken_pages: :environment do
         Decidim::Initiative.find_each do |initiative|
           initiative.components.where(manifest_name: "pages").each do |component|
-            next unless Decidim::Pages::Page.where(component: component).empty?
+            next unless Decidim::Pages::Page.where(component:).empty?
 
             Decidim::Pages::CreatePage.call(component) do
               on(:invalid) { raise "Cannot create page" }