decidim-forms 0.28.5 → 0.29.0.rc1

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_questions.rb

@@ -5,24 +5,24 @@ require "spec_helper"
 shared_examples_for "add questions" do
   shared_examples_for "updating the max choices selector according to the configured options" do
     it "updates them" do
-      expect(page).not_to have_select("Maximum number of choices")
+      expect(page).to have_no_select("Maximum number of choices")
 
       select "Multiple option", from: "Type"
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
 
-      click_button "Add answer option"
+      click_on "Add answer option"
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
 
-      click_button "Add answer option"
+      click_on "Add answer option"
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3 4))
 
-      within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+      within(".questionnaire-question-answer-option:last-of-type") { click_on "Remove" }
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
 
-      within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+      within(".questionnaire-question-answer-option:last-of-type") { click_on "Remove" }
       expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
 
-      click_button "Add question"
+      click_on "Add question"
       expand_all_questions
 
       within(".questionnaire-question:last-of-type") do
@@ -30,7 +30,7 @@ shared_examples_for "add questions" do
         expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
 
         select single_option_string, from: "Type"
-        expect(page).not_to have_select("Maximum number of choices")
+        expect(page).to have_no_select("Maximum number of choices")
       end
     end
   end
@@ -39,12 +39,12 @@ shared_examples_for "add questions" do
     fields_body = ["This is the first question", "This is the second question", "This is the first title and description"]
 
     within "form.edit_questionnaire" do
-      click_button "Add question"
-      click_button "Add separator"
-      click_button "Add title and description"
-      click_button "Add question"
+      click_on "Add question"
+      click_on "Add separator"
+      click_on "Add title and description"
+      click_on "Add question"
 
-      expect(page).to have_selector(".questionnaire-question", count: 4)
+      expect(page).to have_css(".questionnaire-question", count: 4)
 
       expand_all_questions
 
@@ -54,22 +54,22 @@ shared_examples_for "add questions" do
         end
       end
 
-      click_button "Save"
+      click_on "Save"
     end
 
     expect(page).to have_admin_callout("successfully")
 
     visit_questionnaire_edit_path_and_expand_all
 
-    expect(page).to have_selector("input[value='This is the first question']")
-    expect(page).to have_selector("input[value='This is the second question']")
-    expect(page).to have_selector("input[value='This is the first title and description']")
+    expect(page).to have_css("input[value='This is the first question']")
+    expect(page).to have_css("input[value='This is the second question']")
+    expect(page).to have_css("input[value='This is the first title and description']")
     expect(page).to have_content("Separator #2")
   end
 
   it "adds a question with a rich text description" do
     within "form.edit_questionnaire" do
-      click_button "Add question"
+      click_on "Add question"
       expand_all_questions
 
       within ".questionnaire-question" do
@@ -78,7 +78,7 @@ shared_examples_for "add questions" do
         fill_in_editor find_nested_form_field_locator("description_en", visible: false), with: "<p>\n<strong>Superkalifragilistic description</strong>\n</p>"
       end
 
-      click_button "Save"
+      click_on "Save"
     end
 
     expect(page).to have_admin_callout("successfully")
@@ -93,12 +93,12 @@ shared_examples_for "add questions" do
 
     visit questionnaire_public_path
 
-    expect(page).to have_selector("strong", text: "Superkalifragilistic description")
+    expect(page).to have_css("strong", text: "Superkalifragilistic description")
   end
 
   it "adds a title-and-description" do
     within "form.edit_questionnaire" do
-      click_button "Add title and description"
+      click_on "Add title and description"
       expand_all_questions
 
       within ".questionnaire-question" do
@@ -107,7 +107,7 @@ shared_examples_for "add questions" do
         fill_in_editor find_nested_form_field_locator("description_en", visible: false), with: "<p>\n<strong>Superkalifragilistic description</strong>\n</p>"
       end
 
-      click_button "Save"
+      click_on "Save"
     end
 
     expect(page).to have_admin_callout("successfully")
@@ -122,7 +122,7 @@ shared_examples_for "add questions" do
 
     visit questionnaire_public_path
 
-    expect(page).to have_selector("strong", text: "Superkalifragilistic description")
+    expect(page).to have_css("strong", text: "Superkalifragilistic description")
   end
 
   it "adds a question with answer options" do
@@ -141,8 +141,8 @@ shared_examples_for "add questions" do
     ]
 
     within "form.edit_questionnaire" do
-      click_button "Add question"
-      click_button "Add question"
+      click_on "Add question"
+      click_on "Add question"
       expand_all_questions
 
       page.all(".questionnaire-question").each_with_index do |question, idx|
@@ -151,12 +151,12 @@ shared_examples_for "add questions" do
         end
       end
 
-      expect(page).not_to have_content "Add answer option"
+      expect(page).to have_no_content "Add answer option"
 
       page.all(".questionnaire-question").each do |question|
         within question do
           select "Single option", from: "Type"
-          click_button "Add answer option"
+          click_on "Add answer option"
         end
       end
 
@@ -168,58 +168,58 @@ shared_examples_for "add questions" do
         end
       end
 
-      click_button "Save"
+      click_on "Save"
     end
 
     expect(page).to have_admin_callout("successfully")
 
     visit_questionnaire_edit_path_and_expand_all
 
-    expect(page).to have_selector("input[value='This is the first question']")
-    expect(page).to have_selector("input[value='This is the Q1 first option']")
-    expect(page).to have_selector("input[value='This is the Q1 second option']")
-    expect(page).to have_selector("input[value='This is the Q1 third option']")
-    expect(page).to have_selector("input[value='This is the second question']")
-    expect(page).to have_selector("input[value='This is the Q2 first option']")
-    expect(page).to have_selector("input[value='This is the Q2 second option']")
-    expect(page).to have_selector("input[value='This is the Q2 third option']")
+    expect(page).to have_css("input[value='This is the first question']")
+    expect(page).to have_css("input[value='This is the Q1 first option']")
+    expect(page).to have_css("input[value='This is the Q1 second option']")
+    expect(page).to have_css("input[value='This is the Q1 third option']")
+    expect(page).to have_css("input[value='This is the second question']")
+    expect(page).to have_css("input[value='This is the Q2 first option']")
+    expect(page).to have_css("input[value='This is the Q2 second option']")
+    expect(page).to have_css("input[value='This is the Q2 third option']")
   end
 
   it "adds a sane number of options for each attribute type" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Long answer", from: "Type"
-    expect(page).not_to have_selector(".questionnaire-question-answer-option")
-    expect(page).not_to have_selector(".questionnaire-question-matrix-row")
+    expect(page).to have_no_css(".questionnaire-question-answer-option")
+    expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Single option", from: "Type"
-    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-    expect(page).not_to have_selector(".questionnaire-question-matrix-row")
+    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Multiple option", from: "Type"
-    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-    expect(page).not_to have_selector(".questionnaire-question-matrix-row")
+    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Matrix (Multiple option)", from: "Type"
-    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-    expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
+    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_css(".questionnaire-question-matrix-row", count: 2)
 
     select "Short answer", from: "Type"
-    expect(page).not_to have_selector(".questionnaire-question-answer-option")
-    expect(page).not_to have_selector(".questionnaire-question-matrix-row")
+    expect(page).to have_no_css(".questionnaire-question-answer-option")
+    expect(page).to have_no_css(".questionnaire-question-matrix-row")
 
     select "Matrix (Single option)", from: "Type"
-    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-    expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
+    expect(page).to have_css(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_css(".questionnaire-question-matrix-row", count: 2)
   end
 
   it "does not incorrectly reorder when clicking answer options" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Single option", from: "Type"
-    2.times { click_button "Add answer option" }
+    2.times { click_on "Add answer option" }
 
     within ".questionnaire-question-answer-option:first-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
@@ -245,11 +245,11 @@ shared_examples_for "add questions" do
   end
 
   it "does not incorrectly reorder when clicking matrix rows" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Matrix (Multiple option)", from: "Type"
-    2.times { click_button "Add row" }
+    2.times { click_on "Add row" }
 
     within ".questionnaire-question-matrix-row:first-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
@@ -275,18 +275,18 @@ shared_examples_for "add questions" do
   end
 
   it "preserves question form across submission failures" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Long answer", from: "Type"
-    click_button "Save"
+    click_on "Save"
 
     expand_all_questions
     expect(page).to have_select("Type", selected: "Long answer")
   end
 
   it "does not preserve spurious answer options from previous type selections" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Single option", from: "Type"
@@ -297,7 +297,7 @@ shared_examples_for "add questions" do
 
     select "Long answer", from: "Type"
 
-    click_button "Save"
+    click_on "Save"
     expand_all_questions
 
     select "Single option", from: "Type"
@@ -308,7 +308,7 @@ shared_examples_for "add questions" do
   end
 
   it "does not preserve spurious matrix rows from previous type selections" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Matrix (Single option)", from: "Type"
@@ -319,7 +319,7 @@ shared_examples_for "add questions" do
 
     select "Long answer", from: "Type"
 
-    click_button "Save"
+    click_on "Save"
     expand_all_questions
 
     select "Matrix (Single option)", from: "Type"
@@ -330,7 +330,7 @@ shared_examples_for "add questions" do
   end
 
   it "preserves answer options form across submission failures" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Multiple option", from: "Type"
@@ -339,7 +339,7 @@ shared_examples_for "add questions" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
     end
 
-    click_button "Add answer option"
+    click_on "Add answer option"
 
     within ".questionnaire-question-answer-option:last-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Else"
@@ -347,7 +347,7 @@ shared_examples_for "add questions" do
 
     select "3", from: "Maximum number of choices"
 
-    click_button "Save"
+    click_on "Save"
     expand_all_questions
 
     within ".questionnaire-question-answer-option:first-of-type" do
@@ -362,7 +362,7 @@ shared_examples_for "add questions" do
   end
 
   it "preserves matrix rows form across submission failures" do
-    click_button "Add question"
+    click_on "Add question"
     expand_all_questions
 
     select "Matrix (Multiple option)", from: "Type"
@@ -371,9 +371,9 @@ shared_examples_for "add questions" do
       fill_in find_nested_form_field_locator("body_en"), with: "Something"
     end
 
-    click_button "Add row"
+    click_on "Add row"
 
-    click_button "Save"
+    click_on "Save"
     expand_all_questions
 
     within ".questionnaire-question-matrix-row:first-of-type" do
@@ -382,21 +382,21 @@ shared_examples_for "add questions" do
   end
 
   it "allows switching translated field tabs after form failures" do
-    click_button "Add question"
-    click_button "Save"
+    click_on "Add question"
+    click_on "Save"
 
     expand_all_questions
 
     within ".questionnaire-question:first-of-type" do
       fill_in find_nested_form_field_locator("body_en"), with: "Bye"
-      click_link "Català", match: :first
+      click_on "Català", match: :first
 
       fill_in find_nested_form_field_locator("body_ca"), with: "Adeu"
-      click_link "English", match: :first
+      click_on "English", match: :first
 
       expect(page).to have_nested_field("body_en", with: "Bye")
-      expect(page).not_to have_selector(nested_form_field_selector("body_ca"))
-      expect(page).not_to have_content("Adeu")
+      expect(page).to have_no_selector(nested_form_field_selector("body_ca"))
+      expect(page).to have_no_content("Adeu")
     end
   end
 
@@ -408,7 +408,7 @@ shared_examples_for "add questions" do
       visit questionnaire_edit_path
 
       within "form.edit_questionnaire" do
-        click_button "Add question"
+        click_on "Add question"
 
         expand_all_questions
 
@@ -416,22 +416,22 @@ shared_examples_for "add questions" do
           fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
         end
 
-        expect(page).not_to have_content "Add answer option"
-        expect(page).not_to have_select("Maximum number of choices")
+        expect(page).to have_no_content "Add answer option"
+        expect(page).to have_no_select("Maximum number of choices")
       end
     end
 
     it "updates the free text option selector according to the selected question type" do
-      expect(page).not_to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_no_css("input[type=checkbox][id$=_free_text]")
 
       select "Multiple option", from: "Type"
-      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_css("input[type=checkbox][id$=_free_text]")
 
       select "Short answer", from: "Type"
-      expect(page).not_to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_no_css("input[type=checkbox][id$=_free_text]")
 
       select "Single option", from: "Type"
-      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_css("input[type=checkbox][id$=_free_text]")
     end
 
     it_behaves_like "updating the max choices selector according to the configured options"
@@ -445,30 +445,30 @@ shared_examples_for "add questions" do
       visit questionnaire_edit_path
 
       within "form.edit_questionnaire" do
-        click_button "Add question"
+        click_on "Add question"
         expand_all_questions
 
         within ".questionnaire-question" do
           fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
         end
 
-        expect(page).not_to have_content "Add answer option"
-        expect(page).not_to have_content "Add row"
-        expect(page).not_to have_select("Maximum number of choices")
+        expect(page).to have_no_content "Add answer option"
+        expect(page).to have_no_content "Add row"
+        expect(page).to have_no_select("Maximum number of choices")
       end
     end
 
     it "updates the free text option selector according to the selected question type" do
-      expect(page).not_to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_no_css("input[type=checkbox][id$=_free_text]")
 
       select "Matrix (Multiple option)", from: "Type"
-      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_css("input[type=checkbox][id$=_free_text]")
 
       select "Short answer", from: "Type"
-      expect(page).not_to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_no_css("input[type=checkbox][id$=_free_text]")
 
       select "Matrix (Single option)", from: "Type"
-      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+      expect(page).to have_css("input[type=checkbox][id$=_free_text]")
     end
 
     it_behaves_like "updating the max choices selector according to the configured options"

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/update_display_conditions.rb

@@ -23,7 +23,7 @@ shared_examples_for "update display conditions" do
     end
 
     it "the related form appears" do
-      expect(page).to have_selector(".questionnaire-question-display-condition")
+      expect(page).to have_css(".questionnaire-question-display-condition")
     end
 
     it "loads condition_question in select" do
@@ -54,19 +54,19 @@ shared_examples_for "update display conditions" do
 
     it "can be removed" do
       within ".questionnaire-question-display-condition:last-of-type" do
-        click_button "Remove"
+        click_on "Remove"
       end
 
-      click_button "Save"
+      click_on "Save"
 
       visit_questionnaire_edit_path_and_expand_all
 
-      expect(page).to have_selector(".questionnaire-question-display-condition", count: 0)
+      expect(page).to have_css(".questionnaire-question-display-condition", count: 0)
     end
 
     it "still removes the question even if previous editions rendered the conditions invalid" do
       within "form.edit_questionnaire" do
-        expect(page).to have_selector(".questionnaire-question", count: 2)
+        expect(page).to have_css(".questionnaire-question", count: 2)
 
         within ".questionnaire-question-display-condition:first-of-type" do
           select condition_question.body["en"], from: "Question"
@@ -75,10 +75,10 @@ shared_examples_for "update display conditions" do
         end
 
         within ".questionnaire-question:last-of-type" do
-          click_button "Remove", match: :first
+          click_on "Remove", match: :first
         end
 
-        click_button "Save"
+        click_on "Save"
       end
 
       expect(page).to have_admin_callout("successfully")
@@ -86,7 +86,7 @@ shared_examples_for "update display conditions" do
       visit_questionnaire_edit_path_and_expand_all
 
       within "form.edit_questionnaire" do
-        expect(page).to have_selector(".questionnaire-question", count: 1)
+        expect(page).to have_css(".questionnaire-question", count: 1)
       end
     end
   end