decidim-decidim_awesome 0.6.6 → 0.8.0

data/lib/decidim/decidim_awesome/checksums.yml

@@ -1,23 +1,30 @@
 decidim-admin:
   /app/views/layouts/decidim/admin/_header.html.erb:
-    decidim-0.22: 6af51ec6b8a760b0ee6e00a7834f5f9a
-    decidim-0.23: 45f0e15f1b02a1c1a73b1a2184fd55af
+    decidim-0.25: 1aff077428830b12306d6c42e6b37216
 decidim-core:
   /app/views/layouts/decidim/_head.html.erb:
-    decidim-0.22: bf16a58cd9e6d3f73e6875ff3d0b1e48
-    decidim-0.23: e7f5eea07e884665474948ea750fc720
-  /app/assets/javascripts/decidim/editor.js.es6:
-    decidim-0.22: 797d0ec1c9e79453cf6718f82d2fdd27
-    decidim-0.23: cb059b8ff0ffc62c67eb99d8d7a6637b
-    decidim-0.23.1: 4787f73f0f33661e3897404f10019d26
+    decidim-0.25: eb490aa482477ff70f541d20cddec773
+    decidim-0.26: 0927fc81123addec70853c2e7986c538
+  /app/packs/src/decidim/editor.js:
+    decidim-0.25: 742698903a30034094c01aecaca6de84
+    decidim-0.26: 651830d87aeeeff39316a787fc70d461
   /app/presenters/decidim/menu_presenter.rb:
-    decidim-0.22: 042743c44a2aff284b493c7bebbccbb3
-    decidim-0.23: 042743c44a2aff284b493c7bebbccbb3
+    decidim-0.25: f3b05daf279f909f8b3b628658dd5810
   /app/presenters/decidim/menu_item_presenter.rb:
-    decidim-0.22: 70db39954b5840924530bf94d2a0a73a
-    decidim-0.23: 70db39954b5840924530bf94d2a0a73a
+    decidim-0.25: 860ffb160ec5f8552cc2855a6a47851b
+  /app/helpers/decidim/amendments_helper.rb:
+    decidim-0.25: 63532a04fcf07cf92b789833a9421416
+    decidim-0.26: 636943ccb2e994fe0124dc87e72e49e9
 decidim-proposals:
-  /app/presenters/decidim/proposals/proposal_presenter.rb:
-    decidim-0.22: 7d60c8310d7fa4e38d9a27080c22b12c
-    decidim-0.23: 437c0c25151f605401a4f14d090ba5ea
-    decidim-0.23.1: 892021b2ce9ac10c2e1b738e6948cde0
+  /app/forms/decidim/proposals/proposal_wizard_create_step_form.rb:
+    decidim-0.24: db69edd0ba8ffa3965a5c44a6bfaba8d
+  /app/helpers/decidim/proposals/application_helper.rb:
+    decidim-0.24: c5f99f5fa7de9a6e45776983330e9d73
+    decidim-0.26: 216c974bc425393c18b01bfc4eed4f0b
+  /app/views/decidim/proposals/collaborative_drafts/show.html.erb:
+    decidim-0.24: 2a7e0a4c65361f238fd1b917f39c8642
+  /app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb:
+    decidim-0.24: 6f717555a20e2ab3f555003c337d3003
+    decidim-0.26: 97fa28043a26fc2940d30d38d9a7369b
+  /app/views/decidim/proposals/admin/proposals/_form.html.erb:
+    decidim-0.25: 90a04984d4269398b7cd21aa33763a1f

data/lib/decidim/decidim_awesome/config.rb

@@ -9,13 +9,14 @@ module Decidim
         @vars = AwesomeConfig.for_organization(organization).includes(:constraints)
         @context = {
           participatory_space_manifest: nil,
-          participatory_slug: nil,
+          participatory_space_slug: nil,
           component_id: nil,
           component_manifest: nil
         }
+        @sub_configs = {}
       end
 
-      attr_reader :context
+      attr_reader :context, :organization, :vars
       attr_writer :defaults
 
       def defaults
@@ -84,12 +85,59 @@ module Decidim
         # if no constraints defined, applies to everything
         return true if constraints.blank?
 
+        # if containts the "none" constraints, deactivate everything else
+        return false if constraints.detect { |c| c.settings["participatory_space_manifest"] == "none" }
+
         # check if current context matches some constraint
         constraints.detect do |constraint|
-          # if some setting is different, rejects
-          invalid = constraint.settings.detect { |key, val| context[key.to_sym].to_s != val.to_s }
-          invalid.blank?
+          settings = constraint.settings.symbolize_keys
+          match_method = settings.delete(:match)
+          if match_method == "exclusive"
+            # all keys must match
+            settings == context
+          else
+            # constraints keys can match the context partially (ie: if slug is not specified, any space matches in the same manifest)
+            # if some setting is different, rejects
+            invalid = constraint.settings.detect { |key, val| context[key.to_sym].to_s != val.to_s }
+            invalid.blank?
+          end
+        end
+      end
+
+      # adds some custom constraints for the instance that can be generated dynamically
+      def inject_sub_config_constraints(singular_key, subkey, constraints)
+        sub_configs_for(singular_key)[subkey.to_sym]&.add_constraints constraints
+      end
+
+      # Merges all subconfigs values for custom_styles or any other scoped confs
+      # by default filtered according to the current scope, a block can be passed for custom filtering
+      # ie, collect everything:
+      #    collect_sub_configs_values("scoped_style") { true }
+      def collect_sub_configs_values(singular_key)
+        plural_key = singular_key.pluralize.to_sym
+        return [] unless config[plural_key].respond_to?(:filter)
+
+        fields = config[plural_key]&.filter do |key, _value|
+          subconfig = sub_configs_for(singular_key)[key]
+          # allow custom filtering if block given
+          if block_given?
+            yield subconfig
+          else
+            valid_in_context?(subconfig&.all_constraints)
+          end
         end
+        fields.values
+      end
+
+      def sub_configs_for(singular_key)
+        return @sub_configs[singular_key] if @sub_configs[singular_key]
+
+        plural_key = singular_key.pluralize.to_sym
+        return {} unless config[plural_key]
+
+        @sub_configs[singular_key] = config[plural_key].map do |key, _value|
+          [key, AwesomeConfig.find_by(var: "#{singular_key}_#{key}", organization: @organization)]
+        end.to_h
       end
 
       private
@@ -107,7 +155,7 @@ module Decidim
 
       def calculate_config
         # filter vars compliant with current context
-        valid = @vars.filter { |item| enabled_for_organization?(item.var) && valid_in_context?(item.constraints) }
+        valid = @vars.filter { |item| enabled_for_organization?(item.var) && valid_in_context?(item.all_constraints) }
                      .map { |v| [v.var.to_sym, v.value] }.to_h
 
         map_defaults do |key|
@@ -119,9 +167,7 @@ module Decidim
       def enabled_for_organization?(key)
         case key.to_sym
         when :allow_images_in_proposals
-          if @organization.respond_to? :rich_text_editor_in_public_views
-            return false if @organization.rich_text_editor_in_public_views
-          end
+          return false if @organization.rich_text_editor_in_public_views
         end
         true
       end

data/lib/decidim/decidim_awesome/content_parsers/editor_images_parser.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module ContentParsers
+      # A parser that searches for editor images from CarrierWave in html
+      # contents and replaces them with migrated images to ActiveStorage
+      #
+      # @see BaseParser Examples of how to use a content parser
+      class EditorImagesParser < Decidim::ContentParsers::BaseParser
+        # @return [String] the content with the CarrierWave images replaced.
+        def rewrite
+          return content if editor_images.blank?
+
+          replace_editor_images
+          parsed_content.to_html
+        end
+
+        def editor_images
+          @editor_images ||= parsed_content.search(:img).index_with do |image|
+            context[:routes_mappings].find { |mapping| image.attr(:src).end_with?(mapping[:origin_path]) }
+          end.compact
+        end
+
+        private
+
+        def parsed_content
+          @parsed_content ||= Nokogiri::HTML(content)
+        end
+
+        def replace_editor_images
+          editor_images.each do |image, mapping|
+            image.set_attribute(:src, mapping[:instance].attached_uploader(:file).path)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/decidim/decidim_awesome/context_analyzers/request_analyzer.rb

@@ -5,17 +5,32 @@ module Decidim
     module ContextAnalyzers
       # Translates some Decidim URL path to detected participatory spaces and components
       class RequestAnalyzer
+        class << self
+          def context_for(request)
+            analyzer = new request
+            analyzer.extract_context!
+            analyzer.context
+          end
+
+          # In the frontend there's no a 100% correspondence between url and manifest name
+          def participatory_spaces_routes
+            spaces = Decidim.participatory_space_manifests \
+                            .filter { |space| !DecidimAwesome.config.participatory_spaces_routes_context.has_key?(space.name) } \
+                            .map { |space| [space.name.to_s, space.name.to_s] }.to_h
+            DecidimAwesome.config.participatory_spaces_routes_context.each do |manifest, routes|
+              routes.each do |route|
+                spaces[route.to_s] = manifest.to_s
+              end
+            end
+            spaces
+          end
+        end
+
         def initialize(request)
           @request = request
           @context = {}
         end
 
-        def self.context_for(request)
-          analyzer = new request
-          analyzer.extract_context!
-          analyzer.context
-        end
-
         attr_reader :request, :context
 
         def extract_context!
@@ -25,20 +40,8 @@ module Decidim
 
         private
 
-        # In the frontend there's no a 100% correspondence between url and manifest name
-        def participatory_spaces
-          spaces = Decidim.participatory_space_manifests.map do |space|
-            [space.name.to_s, space.name.to_s]
-          end.to_h
-          spaces.merge(
-            "processes" => "participatory_processes",
-            "participatory_process_groups" => "participatory_processes",
-            "assemblies_types" => "assemblies"
-          )
-        end
-
         def process_admin_segments(segments)
-          spaces = participatory_spaces
+          spaces = RequestAnalyzer.participatory_spaces_routes
           return unless spaces[segments[0]]
 
           @context[:participatory_space_manifest] = spaces[segments[0]]
@@ -53,7 +56,7 @@ module Decidim
         end
 
         def process_front_segments(segments)
-          spaces = participatory_spaces
+          spaces = RequestAnalyzer.participatory_spaces_routes
           return unless spaces[segments[0]]
 
           @context[:participatory_space_manifest] = spaces[segments[0]]
@@ -70,8 +73,11 @@ module Decidim
         def system_manifest?(path)
           patterns = [
             %r{^/admin/newsletters},
+            %r{^/admin/moderations},
+            %r{^/admin/users},
             %r{^/admin/organization},
-            %r{^/admin/static_pages}
+            %r{^/admin/static_pages},
+            %r{^/admin/logs}
           ]
           path.match(Regexp.union(patterns))
         end

data/lib/decidim/decidim_awesome/custom_fields.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    class CustomFields
+      def initialize(fields)
+        @fields = if fields.respond_to? :map
+                    fields.map { |f| JSON.parse(f) }.flatten
+                  else
+                    JSON.parse(fields)
+                  end
+      end
+
+      attr_reader :fields, :xml, :errors, :data
+
+      def apply_xml(xml)
+        parse_xml(xml)
+        map_fields!
+      rescue StandardError => e
+        @errors = e.message
+      end
+
+      def to_json(*_args)
+        @fields
+      end
+
+      def translate!
+        translate_values!
+      end
+
+      private
+
+      def parse_xml(xml)
+        @xml = xml
+        @data = Nokogiri.XML(xml).xpath("//dl/dd")
+        return if @data.present?
+
+        apply_to_first_textarea
+      end
+
+      def map_fields!
+        return unless data
+
+        @fields.map! do |field|
+          if field["name"] # ignore headers/paragraphs
+            value = data.search("##{field["name"]} div")
+            field["userData"] = value.map { |v| v.attribute("alt")&.value || v.inner_html(encoding: "UTF-8") } if value.present?
+          end
+
+          field
+        end
+      end
+
+      # Finds the first textarea and applies non-xml compatible content
+      # when textarea has not wysiwyg assigned, strips html
+      def apply_to_first_textarea
+        # quill editor might leave html traces without any user content
+        # so we won't process it if there is no text (html free) result
+        text = Nokogiri.HTML(xml).html? ? Nokogiri.HTML(xml).text.strip : text.strip
+        return if text.blank?
+
+        textarea = @fields.find { |field| field["type"] == "textarea" }
+        @errors = I18n.t(".invalid_xml", scope: "decidim.decidim_awesome.custom_fields.errors")
+        return unless textarea
+
+        textarea["userData"] = [textarea["subtype"] == "textarea" ? text : xml]
+        @errors = I18n.t(".invalid_fields", scope: "decidim.decidim_awesome.custom_fields.errors", field: textarea["label"] || textarea["name"])
+      end
+
+      def translate_values!
+        deep_transform_values!(@fields) do |value|
+          next value unless value.is_a? String
+          next value unless (match = value.match(/^(.*\..*)$/))
+
+          I18n.t(match[1], raise: true)
+        rescue I18n::MissingTranslationData
+          value
+        end
+        @fields
+      end
+
+      def deep_transform_values!(object, &block)
+        case object
+        when Hash
+          object.transform_values! { |value| deep_transform_values!(value, &block) }
+        when Array
+          object.map! { |e| deep_transform_values!(e, &block) }
+        else
+          yield(object)
+        end
+      end
+    end
+  end
+end

data/lib/decidim/decidim_awesome/engine.rb

@@ -8,30 +8,58 @@ module Decidim
   module DecidimAwesome
     # This is the engine that runs on the public interface of decidim_awesome.
     class Engine < ::Rails::Engine
+      include AwesomeHelpers
+
       isolate_namespace Decidim::DecidimAwesome
 
       routes do
         post :editor_images, to: "editor_images#create"
       end
 
-      initializer "decidim_awesome.view_helpers" do
-        ActionView::Base.send :include, AwesomeHelpers
-      end
-
-      initializer "decidim_decidim_awesome.assets" do |app|
-        app.config.assets.precompile += %w(decidim_decidim_awesome_manifest.js decidim_decidim_awesome_manifest.css)
-        # add to precompile any present theme asset
-        Dir.glob(Rails.root.join("app", "assets", "themes", "*.*")).each do |path|
-          app.config.assets.precompile << path
-        end
-      end
-
       # Prepare a zone to create overrides
       # https://edgeguides.rubyonrails.org/engines.html#overriding-models-and-controllers
+      # overrides
       config.to_prepare do
-        Dir.glob("#{Engine.root}/app/awesome_overrides/**/*_override.rb").each do |override|
-          require_dependency override
+        # activate Decidim LayoutHelper for the overriden views
+        ActiveSupport.on_load :action_controller do
+          helper Decidim::LayoutHelper if respond_to?(:helper)
+        end
+        # Include additional helpers globally
+        ActionView::Base.include(Decidim::DecidimAwesome::AwesomeHelpers)
+
+        # override user's admin property
+        Decidim::User.include(Decidim::DecidimAwesome::UserOverride) if DecidimAwesome.enabled?(:scoped_admins)
+
+        # redirect unauthorized scoped admins to allowed places or custom redirects if configured
+        Decidim::ErrorsController.include(Decidim::DecidimAwesome::NotFoundRedirect) if DecidimAwesome.enabled?([:scoped_admins, :custom_redirects])
+
+        # Custom fields need to deal with several places
+        if DecidimAwesome.enabled?(:proposal_custom_fields)
+          Decidim::Proposals::ApplicationHelper.include(Decidim::DecidimAwesome::Proposals::ApplicationHelperOverride)
+          Decidim::Proposals::ProposalWizardCreateStepForm.include(Decidim::DecidimAwesome::Proposals::ProposalWizardCreateStepFormOverride)
+          Decidim::AmendmentsHelper.include(Decidim::DecidimAwesome::AmendmentsHelperOverride)
         end
+
+        Decidim::MenuPresenter.include(Decidim::DecidimAwesome::MenuPresenterOverride)
+        Decidim::MenuItemPresenter.include(Decidim::DecidimAwesome::MenuItemPresenterOverride)
+
+        # Late registering of components to take into account initializer values
+        DecidimAwesome.registered_components.each do |manifest, block|
+          Decidim.register_component(manifest, &block) unless DecidimAwesome.disabled_components.include?(manifest)
+        end
+      end
+
+      initializer "decidim.middleware" do |app|
+        app.config.middleware.insert_after Decidim::Middleware::CurrentOrganization, Decidim::DecidimAwesome::CurrentConfig
+      end
+
+      initializer "decidim_decidim_awesome.webpacker.assets_path" do
+        Decidim.register_assets_path File.expand_path("app/packs", root)
+      end
+
+      initializer "decidim_decidim_awesome.add_cells_view_paths" do
+        Cell::ViewModel.view_paths << File.expand_path("#{Decidim::DecidimAwesome::Engine.root}/app/cells")
+        Cell::ViewModel.view_paths << File.expand_path("#{Decidim::DecidimAwesome::Engine.root}/app/views")
       end
     end
   end

data/lib/decidim/decidim_awesome/iframe_component/admin_engine.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require "rails"
+require "decidim/core"
+
+module Decidim
+  module DecidimAwesome
+    module IframeComponent
+      # This is the engine is used to create the component Map.
+      class AdminEngine < ::Rails::Engine
+        isolate_namespace Decidim::DecidimAwesome::IframeComponent
+
+        routes do
+          root to: "iframe#settings"
+        end
+
+        def load_seed
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/decidim/decidim_awesome/iframe_component/component.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require_dependency "decidim/components/namer"
+require "decidim/components/namer"
 
-Decidim.register_component(:awesome_iframe) do |component|
+Decidim::DecidimAwesome.register_component(:awesome_iframe) do |component|
   component.engine = Decidim::DecidimAwesome::IframeComponent::Engine
-  # component.admin_engine = Decidim::DecidimAwesome::AdminIframeEngine
+  component.admin_engine = Decidim::DecidimAwesome::IframeComponent::AdminEngine
   component.icon = "decidim/meetings/icon.svg" # TODO: create a Icon
   component.permissions_class_name = "Decidim::DecidimAwesome::Permissions"
 
@@ -15,7 +15,7 @@ Decidim.register_component(:awesome_iframe) do |component|
     # Add your global settings
     # Available types: :integer, :boolean
     settings.attribute :announcement, type: :text, translated: true, editor: true
-    settings.attribute :iframe, type: :text
+    settings.attribute :iframe, type: :text, default: ""
     settings.attribute :viewport_width, type: :boolean, default: false
     settings.attribute :no_margins, type: :boolean, default: false
   end
@@ -23,7 +23,7 @@ Decidim.register_component(:awesome_iframe) do |component|
   component.settings(:step) do |settings|
     # Add your settings per step
     settings.attribute :announcement, type: :text, translated: true, editor: true
-    settings.attribute :iframe, type: :text
+    settings.attribute :iframe, type: :text, default: ""
   end
 
   # component.register_stat :some_stat do |context, start_at, end_at|
@@ -43,7 +43,7 @@ Decidim.register_component(:awesome_iframe) do |component|
       published_at: Time.current,
       participatory_space: participatory_space,
       settings: {
-        announcement: { en: Faker::Lorem.paragraphs(2).join("\n") }
+        announcement: { en: Faker::Lorem.paragraphs(number: 2).join("\n") }
       }
     }
 

data/lib/decidim/decidim_awesome/map_component/admin_engine.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require "rails"
+require "decidim/core"
+
+module Decidim
+  module DecidimAwesome
+    module MapComponent
+      # This is the engine is used to create the component Map.
+      class AdminEngine < ::Rails::Engine
+        isolate_namespace Decidim::DecidimAwesome::MapComponent
+
+        routes do
+          root to: "map#settings"
+        end
+
+        def load_seed
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/decidim/decidim_awesome/map_component/component.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require_dependency "decidim/components/namer"
+require "decidim/components/namer"
 
-Decidim.register_component(:awesome_map) do |component|
+Decidim::DecidimAwesome.register_component(:awesome_map) do |component|
   component.engine = Decidim::DecidimAwesome::MapComponent::Engine
-  # component.admin_engine = Decidim::DecidimAwesome::AdminMapEngine
+  component.admin_engine = Decidim::DecidimAwesome::MapComponent::AdminEngine
   component.icon = "decidim/meetings/icon.svg" # TODO: create a Icon
   component.permissions_class_name = "Decidim::DecidimAwesome::Permissions"
 
@@ -16,7 +16,15 @@ Decidim.register_component(:awesome_map) do |component|
     # Available types: :integer, :boolean
     settings.attribute :announcement, type: :text, translated: true, editor: true
     settings.attribute :map_height, type: :integer, default: 700
+    settings.attribute :map_center, type: :string, default: ""
+    settings.attribute :map_zoom, type: :integer, default: 8
+    settings.attribute :truncate, type: :integer, default: 255
     settings.attribute :collapse, type: :boolean, default: false
+    settings.attribute :menu_amendments, type: :boolean, default: true
+    settings.attribute :menu_meetings, type: :boolean, default: true
+    settings.attribute :menu_categories, type: :boolean, default: true
+    settings.attribute :menu_hashtags, type: :boolean, default: true
+    settings.attribute :menu_merge_components, type: :boolean, default: false
   end
 
   component.settings(:step) do |settings|
@@ -25,8 +33,7 @@ Decidim.register_component(:awesome_map) do |component|
     settings.attribute :show_not_answered, type: :boolean, default: true
     settings.attribute :show_evaluating, type: :boolean, default: true
     settings.attribute :show_accepted, type: :boolean, default: true
-    # Not possible yet (needs graphql update):
-    # settings.attribute :show_rejected, type: :boolean, default: false
+    settings.attribute :show_rejected, type: :boolean, default: false
     settings.attribute :show_withdrawn, type: :boolean, default: false
   end
 
@@ -47,7 +54,7 @@ Decidim.register_component(:awesome_map) do |component|
       published_at: Time.current,
       participatory_space: participatory_space,
       settings: {
-        announcement: { en: Faker::Lorem.paragraphs(2).join("\n") }
+        announcement: { en: Faker::Lorem.paragraphs(number: 2).join("\n") }
       }
     }
 

data/lib/decidim/decidim_awesome/map_component/engine.rb

@@ -14,6 +14,40 @@ module Decidim
           root to: "map#show"
         end
 
+        initializer "decidim_decidim_awesome.content_blocks" do |_app|
+          # do not register this if awesome_map is disabled
+          next if DecidimAwesome.disabled_components.include?(:awesome_map)
+
+          # === Home Map block ===
+          Decidim.content_blocks.register(:homepage, :awesome_map) do |content_block|
+            content_block.cell = "decidim/decidim_awesome/content_blocks/map"
+            content_block.settings_form_cell = "decidim/decidim_awesome/content_blocks/map_form"
+            content_block.public_name_key = "decidim.decidim_awesome.content_blocks.map.name"
+
+            content_block.settings do |settings|
+              settings.attribute :title, type: :text, translated: true
+
+              settings.attribute :map_height, type: :integer, default: 500
+              settings.attribute :map_center, type: :string, default: ""
+              settings.attribute :map_zoom, type: :integer, default: 8
+              settings.attribute :truncate, type: :integer, default: 255
+              settings.attribute :collapse, type: :boolean, default: false
+              settings.attribute :menu_amendments, type: :boolean, default: true
+              settings.attribute :menu_meetings, type: :boolean, default: true
+              settings.attribute :menu_hashtags, type: :boolean, default: true
+              settings.attribute :menu_categories, type: :boolean, default: true
+              settings.attribute :menu_merge_components, type: :boolean, default: true
+
+              settings.attribute :show_not_answered, type: :boolean, default: true
+              settings.attribute :show_accepted, type: :boolean, default: true
+              settings.attribute :show_withdrawn, type: :boolean, default: false
+              settings.attribute :show_evaluating, type: :boolean, default: true
+              settings.attribute :show_rejected, type: :boolean, default: false
+            end
+          end
+          # === TODO: processes groups map block ===
+        end
+
         def load_seed
           nil
         end

data/lib/decidim/decidim_awesome/menu_hacker.rb

@@ -4,6 +4,7 @@ module Decidim
   module DecidimAwesome
     class MenuHacker
       include Decidim::TranslatableAttributes
+
       def initialize(name, view)
         @name = name
         @organization = view.try(:current_organization)
@@ -12,7 +13,7 @@ module Decidim
       end
 
       # returns a combined array of the Decidim defined menu and the hacked stored as config vars
-      def items(include_invisible = false)
+      def items(include_invisible: false)
         return @items if @items
 
         @items = default_items

data/lib/decidim/decidim_awesome/system_checker.rb

@@ -14,7 +14,7 @@ module Decidim
           @overrides = checksums.map do |package, files|
             props = {
               spec: ::Gem::Specification.find_by_name(package),
-              files: files.map { |file, signatures| [file, signatures.values] }.to_h
+              files: files.transform_values(&:values)
             }
             [package, to_struct(props)]
           end

data/lib/decidim/decidim_awesome/test/factories.rb

@@ -15,8 +15,8 @@ FactoryBot.define do
     awesome_config { create :awesome_config }
   end
 
-  factory :editor_image, class: "Decidim::DecidimAwesome::EditorImage" do
-    image { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
+  factory :awesome_editor_image, class: "Decidim::DecidimAwesome::EditorImage" do
+    file { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
     path { Faker::Internet.url(host: "", scheme: "") }
     author { create :user }
     organization { create :organization }