decidim-core 0.4.4 → 0.5.0

data/lib/decidim/core/test/factories.rb

@@ -16,6 +16,14 @@ FactoryGirl.define do
     "#{Faker::Internet.slug(nil, "-")}-#{n}"
   end
 
+  sequence(:scope_name) do |n|
+    "#{Faker::Lorem.sentence(1, true, 3)} #{n}"
+  end
+
+  sequence(:scope_code) do |n|
+    "#{Faker::Lorem.characters(4).upcase}-#{n}"
+  end
+
   factory :category, class: Decidim::Category do
     name { Decidim::Faker::Localized.sentence(3) }
     description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(2) } }
@@ -24,10 +32,6 @@ FactoryGirl.define do
 
   factory :subcategory, parent: :category do
     parent { build(:category) }
-
-    before(:create) do |object|
-      object.parent.save unless object.parent.persisted?
-    end
   end
 
   factory :organization, class: Decidim::Organization do
@@ -43,7 +47,7 @@ FactoryGirl.define do
     welcome_text { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(2) } }
     homepage_image { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
     favicon { Decidim::Dev.test_file("icon.png", "image/png") }
-    default_locale { I18n.default_locale }
+    default_locale { Decidim.default_locale }
     available_locales { Decidim.available_locales }
     official_img_header { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") }
     official_img_footer { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") }
@@ -81,13 +85,6 @@ FactoryGirl.define do
       published_at { Time.current }
     end
 
-    trait :with_scope do
-      after(:create) do |participatory_process, _evaluator|
-        create(:scope,
-               organization: participatory_process.organization)
-      end
-    end
-
     trait :with_steps do
       transient { current_step_ends 1.month.from_now }
 
@@ -152,6 +149,10 @@ FactoryGirl.define do
       admin { true }
     end
 
+    trait :user_manager do
+      roles { ["user_manager"] }
+    end
+
     trait :process_admin do
       transient do
         participatory_process { create(:participatory_process) }
@@ -181,6 +182,28 @@ FactoryGirl.define do
                role: :collaborator
       end
     end
+
+    trait :process_moderator do
+      transient do
+        participatory_process { create(:participatory_process) }
+      end
+
+      organization { participatory_process.organization }
+
+      after(:create) do |user, evaluator|
+        create :participatory_process_user_role,
+               user: user,
+               participatory_process: evaluator.participatory_process,
+               role: :moderator
+      end
+    end
+
+    trait :managed do
+      email { "" }
+      password { "" }
+      password_confirmation { "" }
+      managed { true }
+    end
   end
 
   factory :participatory_process_user_role, class: Decidim::ParticipatoryProcessUserRole do
@@ -260,14 +283,6 @@ FactoryGirl.define do
     trait :with_pdf do
       file { Decidim::Dev.test_file("Exampledocument.pdf", "application/pdf") }
     end
-
-    trait :with_doc do
-      file { Decidim::Dev.test_file("Exampledocument.doc", "application/msword") }
-    end
-
-    trait :with_odt do
-      file { Decidim::Dev.test_file("Exampledocument.odt", "application/vnd.oasis.opendocument") }
-    end
   end
 
   factory :feature, class: Decidim::Feature do
@@ -285,11 +300,27 @@ FactoryGirl.define do
     end
   end
 
-  factory :scope, class: Decidim::Scope do
-    name { generate(:name) }
+  factory :scope_type, class: Decidim::ScopeType do
+    name { Decidim::Faker::Localized.word }
+    plural { Decidim::Faker::Localized.literal(name.values.first.pluralize) }
     organization
   end
 
+  factory :scope, class: Decidim::Scope do
+    name { Decidim::Faker::Localized.literal(generate(:scope_name)) }
+    code { generate(:scope_code) }
+    scope_type
+    organization { parent ? parent.organization : build(:organization) }
+  end
+
+  factory :subscope, parent: :scope do
+    parent { build(:scope) }
+
+    before(:create) do |object|
+      object.parent.save unless object.parent.persisted?
+    end
+  end
+
   factory :dummy_resource, class: Decidim::DummyResource do
     title { generate(:name) }
     feature { create(:feature, manifest_name: "dummy") }
@@ -320,4 +351,10 @@ FactoryGirl.define do
     user { build(:user, organization: moderation.reportable.organization) }
     reason "spam"
   end
+
+  factory :impersonation_log, class: Decidim::ImpersonationLog do
+    admin { build(:user, :admin) }
+    user { build(:user, :managed, organization: admin.organization) }
+    started_at Time.current
+  end
 end

data/lib/decidim/core/test/shared_examples/announcements_examples.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+shared_examples "manage announcements" do
+  it "customize a general announcement for the feature" do
+    visit edit_feature_path(current_feature)
+
+    fill_in_i18n_editor(
+      :feature_settings_announcement,
+      "#global-settings-announcement-tabs",
+      en: "An important announcement",
+      es: "Un aviso muy importante",
+      ca: "Un avís molt important"
+    )
+
+    click_button "Update"
+
+    visit main_feature_path(current_feature)
+
+    within ".callout.secondary" do
+      expect(page).to have_content("An important announcement")
+    end
+  end
+
+  context "when the general announcement is set" do
+    before do
+      current_feature.update_attributes!(
+        settings: {
+          announcement: {
+            en: "An important announcement",
+            es: "Un aviso muy importante",
+            ca: "Un avís molt important"
+          }
+        }
+      )
+    end
+
+    it "customize an announcement for the current step and it has more priority" do
+      visit edit_feature_path(current_feature)
+
+      fill_in_i18n_editor(
+        :feature_step_settings_1_announcement,
+        "#step-1-settings-announcement-tabs",
+        en: "An announcement for this step",
+        es: "Un aviso para esta fase",
+        ca: "Un avís per a aquesta fase"
+      )
+
+      click_button "Update"
+
+      visit main_feature_path(current_feature)
+
+      within ".callout.secondary" do
+        expect(page).to have_no_content("An important announcement")
+        expect(page).to have_content("An announcement for this step")
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -1,7 +1,6 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
-RSpec.shared_examples "comments" do
+shared_examples "comments" do
   let!(:organization) { create(:organization) }
   let!(:user) { create(:user, :confirmed, organization: organization) }
   let!(:comments) { create_list(:comment, 3, commentable: commentable) }
@@ -44,7 +43,7 @@ RSpec.shared_examples "comments" do
   context "when not authenticated" do
     it "does not show form to add comments to user" do
       visit resource_path
-      expect(page).not_to have_selector(".add-comment form")
+      expect(page).to have_no_selector(".add-comment form")
     end
   end
 
@@ -67,22 +66,18 @@ RSpec.shared_examples "comments" do
       end
 
       it "shows comment to the user" do
-        within "#comments" do
-          expect(page).to have_content user.name
-          expect(page).to have_content "This is a new comment"
-        end
+        expect(page).to have_comment_from(user, "This is a new comment")
       end
 
       it "send notifications" do
+        expect(page).to have_comment_from(user, "This is a new comment")
+
         if commentable.notifiable?(author: user)
           wait_for_email subject: "new comment"
           relogin_as commentable.users_to_notify.first, scope: :user
           visit last_email_first_link
 
-          within "#comments" do
-            expect(page).to have_content user.name
-            expect(page).to have_content "This is a new comment"
-          end
+          expect(page).to have_comment_from(user, "This is a new comment")
         else
           expect do
             wait_for_email subject: "new comment"
@@ -109,10 +104,7 @@ RSpec.shared_examples "comments" do
           click_button "Send"
         end
 
-        within "#comments" do
-          expect(page).to have_content user_group.name
-          expect(page).to have_content "This is a new comment"
-        end
+        expect(page).to have_comment_from(user_group, "This is a new comment")
       end
     end
 
@@ -127,25 +119,23 @@ RSpec.shared_examples "comments" do
 
         within "#comments #comment_#{comment.id}" do
           click_button "Reply"
-          find("textarea").set("This is a reply")
+          fill_in "add-comment-Decidim::Comments::Comment-#{comment.id}", with: "This is a reply"
           click_button "Send"
         end
       end
 
       it "shows reply to the user" do
-        within "#comments #comment_#{comment.id}" do
-          expect(page).to have_content "This is a reply"
-        end
+        expect(page).to have_reply_to(comment, "This is a reply")
       end
 
       it "sends notifications received by commentable's author" do
+        expect(page).to have_reply_to(comment, "This is a reply")
+
         wait_for_email subject: "new reply"
         relogin_as comment.author, scope: :user
         visit last_email_first_link
 
-        within "#comments #comment_#{comment.id}" do
-          expect(page).to have_content "This is a reply"
-        end
+        expect(page).to have_reply_to(comment, "This is a reply")
       end
     end
 
@@ -170,7 +160,7 @@ RSpec.shared_examples "comments" do
               expect(page).to have_selector "span.success.label", text: "In favor"
             end
           else
-            expect(page).not_to have_selector(".opinion-toggle--ok")
+            expect(page).to have_no_selector(".opinion-toggle--ok")
           end
         end
       end
@@ -189,17 +179,13 @@ RSpec.shared_examples "comments" do
               page.find(".comment__votes--up").click
               expect(page).to have_selector(".comment__votes--up", text: /1/)
             else
-              expect(page).to_not have_selector(".comment__votes--up", text: /0/)
+              expect(page).to have_no_selector(".comment__votes--up", text: /0/)
             end
           end
         end
       end
 
       context "downvoting a comment" do
-        before do
-          visit resource_path
-        end
-
         it "works according to the setting in the commentable" do
           within "#comment_#{comments[0].id}" do
             if commentable.comments_have_votes?
@@ -207,7 +193,7 @@ RSpec.shared_examples "comments" do
               page.find(".comment__votes--down").click
               expect(page).to have_selector(".comment__votes--down", text: /1/)
             else
-              expect(page).to_not have_selector(".comment__votes--down", text: /0/)
+              expect(page).to have_no_selector(".comment__votes--down", text: /0/)
             end
           end
         end

data/lib/decidim/core/test/shared_examples/errors.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.shared_examples_for "a 404 page" do
+shared_examples_for "a 404 page" do
   before do
     allow(Rails.application).to \
       receive(:env_config).with(no_args).and_wrap_original do |m, *|

data/lib/decidim/core/test/shared_examples/has_attachments.rb

@@ -3,15 +3,10 @@
 require "spec_helper"
 
 shared_examples_for "has attachments" do
-  context "when it has attachments" do
-    let!(:document) do
-      Decidim::AttachmentUploader.enable_processing = true
-      create(:attachment, :with_pdf, attached_to: attached_to)
-    end
-    let!(:image) do
-      Decidim::AttachmentUploader.enable_processing = true
-      create(:attachment, attached_to: attached_to)
-    end
+  context "when it has attachments", processing_uploads_for: Decidim::AttachmentUploader do
+    let!(:document) { create(:attachment, :with_pdf, attached_to: attached_to) }
+
+    let!(:image) { create(:attachment, attached_to: attached_to) }
 
     before do
       visit current_path

data/lib/decidim/core/test/shared_examples/manage_moderations_examples.rb

@@ -1,7 +1,6 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
-RSpec.shared_examples "manage moderations" do
+shared_examples "manage moderations" do
   let!(:moderations) do
     reportables.first(reportables.length - 1).map do |reportable|
       moderation = create(:moderation, reportable: reportable, report_count: 1)
@@ -25,8 +24,6 @@ RSpec.shared_examples "manage moderations" do
 
   context "listing moderations" do
     it "user can review them" do
-      click_link "Moderations"
-
       moderations.each do |moderation|
         within "tr[data-id=\"#{moderation.id}\"]" do
           expect(page).to have_content moderation.reportable.reported_content_url
@@ -36,8 +33,6 @@ RSpec.shared_examples "manage moderations" do
     end
 
     it "user can un-report a resource" do
-      click_link "Moderations"
-
       within "tr[data-id=\"#{moderation.id}\"]" do
         find("a.action-icon--unreport").click
       end
@@ -48,8 +43,6 @@ RSpec.shared_examples "manage moderations" do
     end
 
     it "user can hide a resource" do
-      click_link "Moderations"
-
       within "tr[data-id=\"#{moderation.id}\"]" do
         find("a.action-icon--hide").click
       end

data/lib/decidim/core/test/shared_examples/paginated_resource_examples.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.shared_examples "a paginated resource" do
+shared_examples "a paginated resource" do
   let(:collection_size) { 30 }
 
   before do
@@ -21,6 +21,6 @@ RSpec.shared_examples "a paginated resource" do
     end
 
     expect(page).to have_css(resource_selector, count: collection_size)
-    expect(page).not_to have_css(".pagination")
+    expect(page).to have_no_css(".pagination")
   end
 end

data/lib/decidim/core/test/shared_examples/process_announcements_examples.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+shared_examples "manage processes announcements" do
+  let!(:participatory_process) { create(:participatory_process, organization: organization) }
+
+  it "customize an general announcement for the process" do
+    click_link translated(participatory_process.title)
+
+    fill_in_i18n_editor(
+      :participatory_process_announcement,
+      "#participatory_process-announcement-tabs",
+      en: "An important announcement",
+      es: "Un aviso muy importante",
+      ca: "Un avís molt important"
+    )
+
+    within ".edit_participatory_process" do
+      find("*[type=submit]").click
+    end
+
+    within ".callout-wrapper" do
+      expect(page).to have_content("successfully")
+    end
+
+    visit decidim_admin.participatory_processes_path
+
+    within "tr", text: translated(participatory_process.title) do
+      page.find("a.action-icon--preview").click
+    end
+
+    expect(page).to have_content("An important announcement")
+  end
+end

data/lib/decidim/core/test/shared_examples/reports_examples.rb

@@ -1,7 +1,6 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
-RSpec.shared_examples "reports" do
+shared_examples "reports" do
   context "when the user is not logged in" do
     it "should be given the option to sign in" do
       visit reportable_path