decidim-core 0.4.4 → 0.5.0

data/app/helpers/decidim/icon_helper.rb

@@ -10,8 +10,18 @@ module Decidim
     #
     # Returns an HTML tag with the icon.
     def feature_icon(feature)
-      if feature.manifest.icon
-        external_icon feature.manifest.icon
+      feature_manifest_icon(feature.manifest)
+    end
+
+    # Public: Returns an icon given an instance of a Feature Manifest. It defaults to
+    # a question mark when no icon is found.
+    #
+    # feature_manifest - The feature manifest to generate the icon for.
+    #
+    # Returns an HTML tag with the icon.
+    def feature_manifest_icon(feature_manifest)
+      if feature_manifest.icon
+        external_icon feature_manifest.icon
       else
         icon "question-mark"
       end

data/app/helpers/decidim/participatory_process_helper.rb

@@ -13,29 +13,5 @@ module Decidim
       dates = [participatory_process_step.start_date, participatory_process_step.end_date]
       dates.map { |date| date ? localize(date.to_date, format: :default) : "?" }.join(" - ")
     end
-
-    # Public: Returns an icon given an instance of a Feature. It defaults to
-    # a question mark when no icon is found.
-    #
-    # feature - The feature to generate the icon for.
-    #
-    # Returns an HTML tag with the icon.
-    def feature_icon(feature)
-      feature_manifest_icon(feature.manifest)
-    end
-
-    # Public: Returns an icon given an instance of a Feature Manifest. It defaults to
-    # a question mark when no icon is found.
-    #
-    # feature_manifest - The feature manifest to generate the icon for.
-    #
-    # Returns an HTML tag with the icon.
-    def feature_manifest_icon(feature_manifest)
-      if feature_manifest.icon
-        external_icon feature_manifest.icon
-      else
-        icon "question-mark"
-      end
-    end
   end
 end

data/app/helpers/decidim/scopes_helper.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Decidim
+  # A Helper to render scopes, including a global scope, for forms.
+  module ScopesHelper
+    Option = Struct.new(:id, :name)
+
+    # Check whether the resource has a visible scope or not.
+    #
+    # Returns boolean.
+    def has_visible_scopes?(resource)
+      current_participatory_process.scopes_enabled? && !current_participatory_process.scope.present? && resource.scope.present?
+    end
+  end
+end

data/app/helpers/decidim/translations_helper.rb

@@ -22,7 +22,7 @@ module Decidim
     #           available locales by default.
     #
     # Returns a Hash with the locales as keys and the translations as values.
-    def multi_translation(key, locales = I18n.available_locales)
+    def multi_translation(key, locales = Decidim.available_locales)
       locales.each_with_object({}) do |locale, result|
         I18n.with_locale(locale) do
           result[locale.to_sym] = I18n.t(key)

data/app/mailers/decidim/reported_mailer.rb

@@ -36,7 +36,7 @@ module Decidim
     end
 
     def manage_moderations_url
-      @manage_moderations_url ||= decidim_admin.participatory_process_moderations_url(@participatory_process.id, host: @organization.host)
+      @manage_moderations_url ||= decidim_admin.moderations_url(@participatory_process.id, host: @organization.host)
     end
   end
 end

data/app/models/decidim/abilities/admin_ability.rb

@@ -19,6 +19,7 @@ module Decidim
         can :read, :admin_dashboard
         can :read, ParticipatoryProcess
         can :read, Feature
+        can :impersonate, :managed_users
       end
 
       def admin?

data/app/models/decidim/abilities/everyone_ability.rb

@@ -15,6 +15,8 @@ module Decidim
 
         can :read, Feature, &:published?
 
+        can :search, Scope
+
         can :manage, User do |other|
           other == user
         end

data/app/models/decidim/abilities/user_manager_ability.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Abilities
+    # Defines the abilities for an user with role 'user_manager'.
+    # Intended to be used with `cancancan`.
+    class UserManagerAbility
+      include CanCan::Ability
+
+      attr_reader :user
+
+      def initialize(user, context)
+        @user = user
+        @context = context
+
+        define_abilities if not_admin? && user_manager?
+      end
+
+      def define_abilities
+        can :read, :admin_dashboard
+        can :impersonate, :managed_users
+      end
+
+      # Whether the user is an admin or not.
+      def not_admin?
+        @user && !@user.admin?
+      end
+
+      # Whether the user has the user_manager role or not.
+      def user_manager?
+        @user.role? "user_manager"
+      end
+    end
+  end
+end

data/app/models/decidim/impersonation_log.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Decidim
+  # ImpersonationLogs are created whenever an admin impersonate a managed user
+  class ImpersonationLog < ApplicationRecord
+    SESSION_TIME_IN_MINUTES = 30
+
+    belongs_to :admin, foreign_key: "decidim_admin_id", class_name: "Decidim::User"
+    belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User"
+
+    validate :same_organization, :non_active_impersonation
+
+    scope :active, -> { where(ended_at: nil) }
+
+    def ended?
+      ended_at.present?
+    end
+
+    def expired?
+      expired_at.present?
+    end
+
+    private
+
+    def same_organization
+      return if admin&.organization == user&.organization
+      errors.add(:admin, :invalid)
+    end
+
+    def non_active_impersonation
+      return if ended? || expired?
+      errors.add(:admin, :invalid) if Decidim::ImpersonationLog.where(admin: admin).active.any?
+    end
+  end
+end

data/app/models/decidim/organization.rb

@@ -9,7 +9,9 @@ module Decidim
 
     has_many :static_pages, foreign_key: "decidim_organization_id", class_name: "Decidim::StaticPage", inverse_of: :organization
     has_many :scopes, -> { order(name: :asc) }, foreign_key: "decidim_organization_id", class_name: "Decidim::Scope", inverse_of: :organization
+    has_many :scope_types, -> { order(name: :asc) }, foreign_key: "decidim_organization_id", class_name: "Decidim::ScopeType", inverse_of: :organization
     has_many :admins, -> { where(admin: true) }, foreign_key: "decidim_organization_id", class_name: "Decidim::User"
+    has_many :users_with_any_role, -> { where.not(roles: []) }, foreign_key: "decidim_organization_id", class_name: "Decidim::User"
     has_many :users, foreign_key: "decidim_organization_id", class_name: "Decidim::User"
 
     validates :name, :host, uniqueness: true
@@ -21,6 +23,13 @@ module Decidim
     mount_uploader :logo, Decidim::OrganizationLogoUploader
     mount_uploader :favicon, Decidim::OrganizationFaviconUploader
 
+    # Returns top level scopes for this organization.
+    #
+    # Returns an ActiveRecord::Relation.
+    def top_scopes
+      @top_scopes ||= scopes.top_level
+    end
+
     def homepage_big_url
       homepage_image.big.url
     end

data/app/models/decidim/participatory_process.rb

@@ -9,6 +9,7 @@ module Decidim
   class ParticipatoryProcess < ApplicationRecord
     include Decidim::HasAttachments
     include Decidim::Publicable
+    include Decidim::Scopable
 
     belongs_to :organization,
                foreign_key: "decidim_organization_id",
@@ -18,10 +19,6 @@ module Decidim
                class_name: "Decidim::ParticipatoryProcessGroup",
                inverse_of: :participatory_processes,
                optional: true
-    belongs_to :scope,
-               foreign_key: "decidim_scope_id",
-               class_name: "Decidim::Scope",
-               optional: true
     has_many :steps,
              -> { order(position: :asc) },
              foreign_key: "decidim_participatory_process_id",

data/app/models/decidim/scope.rb

@@ -10,6 +10,70 @@ module Decidim
                class_name: "Decidim::Organization",
                inverse_of: :scopes
 
-    validates :name, presence: true, uniqueness: { scope: :organization }
+    belongs_to :scope_type,
+               foreign_key: "scope_type_id",
+               class_name: "Decidim::ScopeType",
+               inverse_of: :scopes,
+               optional: true
+
+    belongs_to :parent,
+               foreign_key: "parent_id",
+               class_name: "Decidim::Scope",
+               inverse_of: :children,
+               optional: true
+
+    has_many :children,
+             foreign_key: "parent_id",
+             class_name: "Decidim::Scope",
+             inverse_of: :parent
+
+    before_validation :update_part_of, on: :update
+
+    validates :name, :code, :organization, presence: true
+    validates :code, uniqueness: { scope: :organization }
+    validate :forbid_cycles
+
+    after_create_commit :create_part_of
+
+    # Scope to return only the top level scopes.
+    #
+    # Returns an ActiveRecord::Relation.
+    def self.top_level
+      where parent_id: nil
+    end
+
+    def descendants
+      organization.scopes.where("? = ANY(decidim_scopes.part_of)", id)
+    end
+
+    # Gets the scopes from the part_of list
+    #
+    # Returns an ActiveRecord::Relation.
+    def part_of_scopes
+      organization.scopes.where(id: part_of)
+    end
+
+    private
+
+    def forbid_cycles
+      errors.add(:parent_id, :cycle_detected) if parent && parent.part_of.include?(id)
+    end
+
+    def create_part_of
+      self[:part_of] = calculate_part_of
+      save if changed?
+    end
+
+    def update_part_of
+      self[:part_of] = calculate_part_of
+    end
+
+    def calculate_part_of
+      if parent
+        [id] + parent.part_of
+      else
+        [id]
+      end
+    end
   end
 end

data/app/models/decidim/scope_type.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Decidim
+  # Scope types allows to use different types of scopes in participatory process
+  # (municipalities, provinces, states, countries, etc.)
+  class ScopeType < ApplicationRecord
+    belongs_to :organization,
+               foreign_key: "decidim_organization_id",
+               class_name: "Decidim::Organization",
+               inverse_of: :scope_types
+
+    has_many :scopes, foreign_key: "decidim_scope_type_id", class_name: "Decidim::Scope", inverse_of: :scope_type
+
+    validates :name, presence: true
+  end
+end

data/app/models/decidim/user.rb

@@ -6,6 +6,7 @@ module Decidim
   # A User is a citizen that wants to join the platform to participate.
   class User < ApplicationRecord
     MAXIMUM_AVATAR_FILE_SIZE = 5.megabytes
+    ROLES = %w(admin user_manager).freeze
 
     devise :invitable, :database_authenticatable, :registerable, :confirmable,
            :recoverable, :rememberable, :trackable, :decidim_validatable,
@@ -19,13 +20,16 @@ module Decidim
     has_many :user_groups, through: :memberships, class_name: "Decidim::UserGroup", foreign_key: :decidim_user_group_id
 
     validates :name, presence: true, unless: -> { deleted? }
-    validates :locale, inclusion: { in: I18n.available_locales.map(&:to_s) }, allow_blank: true
+    validates :locale, inclusion: { in: Decidim.available_locales.map(&:to_s) }, allow_blank: true
     validates :tos_agreement, acceptance: true, allow_nil: false, on: :create
     validates :avatar, file_size: { less_than_or_equal_to: MAXIMUM_AVATAR_FILE_SIZE }
-    validates :email, uniqueness: { scope: :organization }, unless: -> { deleted? }
+    validates :email, uniqueness: { scope: :organization }, unless: -> { deleted? || managed? }
+    validate :all_roles_are_valid
+
     mount_uploader :avatar, Decidim::AvatarUploader
 
     scope :not_deleted, -> { where(deleted_at: nil) }
+    scope :managed, -> { where(managed: true) }
 
     # Public: Allows customizing the invitation instruction email content when
     # inviting a user.
@@ -33,6 +37,21 @@ module Decidim
     # Returns a String.
     attr_accessor :invitation_instructions
 
+    # Checks if the user has the given `role` or not.
+    #
+    # role - a String or a Symbol that represents the role that is being
+    #   checked
+    #
+    # Returns a boolean.
+    def role?(role)
+      roles.include?(role.to_s)
+    end
+
+    # Public: Returns the active role of the user
+    def active_role
+      admin ? "admin" : roles.first
+    end
+
     # Public: returns the user's name or the default one
     def name
       super || I18n.t("decidim.anonymous_user")
@@ -60,9 +79,17 @@ module Decidim
     protected
 
     # Overrides devise email required validation.
-    # If the user has been deleted the email field is not required anymore.
+    # If the user has been deleted or it is managed the email field is not required anymore.
     def email_required?
-      !deleted?
+      return false if deleted? || managed?
+      super
+    end
+
+    # Overrides devise password required validation.
+    # If the user is managed the password field is not required anymore.
+    def password_required?
+      return false if managed?
+      super
     end
 
     private
@@ -71,5 +98,9 @@ module Decidim
     def send_devise_notification(notification, *args)
       devise_mailer.send(notification, self, *args).deliver_later
     end
+
+    def all_roles_are_valid
+      errors.add(:roles, :invalid) unless roles.all? { |role| ROLES.include?(role) }
+    end
   end
 end

data/app/presenters/decidim/participatory_process_stats_presenter.rb

@@ -4,7 +4,7 @@ module Decidim
   # A presenter to render statistics in the homepage.
   class ParticipatoryProcessStatsPresenter < Rectify::Presenter
     attribute :participatory_process, Decidim::ParticipatoryProcess
-    include Decidim::ParticipatoryProcessHelper
+    include Decidim::IconHelper
 
     # Public: Render a collection of primary stats.
     def highlighted

data/app/queries/decidim/freetext_scopes.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Decidim
+  # This query searches scopes by name.
+  class FreetextScopes < Rectify::Query
+    # Syntactic sugar to initialize the class and return the queried objects.
+    #
+    # organization - an Organization context for the scope search
+    # lang - the language code to be used for the search
+    # text - the text to be searched in scopes names
+    # root - root scope
+    def self.for(organization, lang, text, root = nil)
+      new(organization, lang, text, root).query
+    end
+
+    # Initializes the class.
+    #
+    # organization - an Organization context for the scope search
+    # lang - the language code to be used for the search
+    # text - the text to be searched in scopes names
+    def initialize(organization, lang, text, root = nil)
+      @organization = organization
+      @lang = lang
+      @text = text
+      @root = root
+    end
+
+    # Finds scopes in the given organization and language whose name begins with the indicated text.
+    #
+    # Returns an ActiveRecord::Relation.
+    def query
+      if @root
+        @root.descendants.where("name->>? ilike ?", @lang, @text + "%")
+      else
+        @organization.scopes.where("name->>? ilike ?", @lang, @text + "%")
+      end
+    end
+  end
+end