decidim-core 0.27.8 → 0.28.0.rc4

data/lib/decidim/core/test/factories.rb

@@ -8,39 +8,8 @@ require "decidim/participatory_processes/test/factories"
 require "decidim/assemblies/test/factories"
 require "decidim/comments/test/factories"
 
-def generate_component_name(locales, manifest_name, skip_injection: false)
-  prepend = skip_injection ? "" : "<script>alert('#{manifest_name}');</script>"
-
-  Decidim::Components::Namer.new(locales, manifest_name).i18n_name.transform_values { |v| [prepend, v].compact_blank.join(" ") }
-end
-
-def generate_localized_description(field = nil, skip_injection: false, before: "<p>", after: "</p>")
-  Decidim::Faker::Localized.wrapped(before, after) do
-    generate_localized_title(field, skip_injection: skip_injection)
-  end
-end
-
-def generate_localized_word(field = nil, skip_injection: false)
-  skip_injection = true if field.nil?
-  Decidim::Faker::Localized.localized do
-    if skip_injection
-      Faker::Lorem.word
-    else
-      "<script>alert('#{field}');</script> #{Faker::Lorem.word}"
-    end
-  end
-end
-
-def generate_localized_title(field = nil, skip_injection: false)
-  skip_injection = true if field.nil?
-
-  Decidim::Faker::Localized.localized do
-    if skip_injection
-      generate(:title)
-    else
-      "<script>alert('#{field}');</script> #{generate(:title)}"
-    end
-  end
+def generate_localized_title
+  Decidim::Faker::Localized.localized { generate(:title) }
 end
 
 FactoryBot.define do
@@ -85,29 +54,21 @@ FactoryBot.define do
   end
 
   factory :category, class: "Decidim::Category" do
-    transient do
-      skip_injection { false }
-    end
-
-    name { generate_localized_title(:category_name, skip_injection: skip_injection) }
-    description { generate_localized_description(:category_description, skip_injection: skip_injection) }
+    name { generate_localized_title }
+    description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
     weight { 0 }
 
     association :participatory_space, factory: :participatory_process
   end
 
   factory :subcategory, parent: :category do
-    transient do
-      skip_injection { false }
-    end
-    parent { build(:category, skip_injection: skip_injection) }
+    parent { build(:category) }
 
     participatory_space { parent.participatory_space }
   end
 
   factory :organization, class: "Decidim::Organization" do
     transient do
-      skip_injection { false }
       create_static_pages { true }
     end
 
@@ -120,12 +81,11 @@ FactoryBot.define do
     youtube_handler { Faker::Hipster.word }
     github_handler { Faker::Hipster.word }
     sequence(:host) { |n| "#{n}.lvh.me" }
-    description { generate_localized_description(:organization_description, skip_injection: skip_injection) }
+    description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
     favicon { Decidim::Dev.test_file("icon.png", "image/png") }
     default_locale { Decidim.default_locale }
     available_locales { Decidim.available_locales }
     users_registration_mode { :enabled }
-    official_img_header { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") }
     official_img_footer { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") }
     official_url { Faker::Internet.url }
     highlighted_content_banner_enabled { false }
@@ -134,7 +94,7 @@ FactoryBot.define do
     user_groups_enabled { true }
     send_welcome_notification { true }
     comments_max_length { 1000 }
-    admin_terms_of_use_body { generate_localized_description(:admin_terms_of_service_body, skip_injection: skip_injection) }
+    admin_terms_of_service_body { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
     force_users_to_authenticate_before_access_organization { false }
     machine_translation_display_priority { "original" }
     external_domain_whitelist { ["example.org", "twitter.com", "facebook.com", "youtube.com", "github.com", "mytesturl.me"] }
@@ -149,6 +109,14 @@ FactoryBot.define do
     end
     file_upload_settings { Decidim::OrganizationSettings.default(:upload) }
     enable_participatory_space_filters { true }
+    content_security_policy { {} }
+    colors do
+      {
+        primary: "#e02d2d",
+        secondary: "#155abf",
+        tertiary: "#ebc34b"
+      }
+    end
 
     trait :secure_context do
       host { "localhost" }
@@ -156,16 +124,13 @@ FactoryBot.define do
 
     after(:create) do |organization, evaluator|
       if evaluator.create_static_pages
-        tos_page = Decidim::StaticPage.find_by(slug: "terms-and-conditions", organization: organization)
-        create(:static_page, :tos, organization: organization, skip_injection: evaluator.skip_injection) if tos_page.nil?
+        tos_page = Decidim::StaticPage.find_by(slug: "terms-of-service", organization:)
+        create(:static_page, :tos, organization:) if tos_page.nil?
       end
     end
   end
 
   factory :user, class: "Decidim::User" do
-    transient do
-      skip_injection { false }
-    end
     email { generate(:email) }
     name { generate(:name) }
     nickname { generate(:nickname) }
@@ -174,7 +139,7 @@ FactoryBot.define do
     tos_agreement { "1" }
     avatar { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") }
     personal_url { Faker::Internet.url }
-    about { generate_localized_title(:user_about, skip_injection: skip_injection) }
+    about { "<script>alert(\"ABOUT\");</script>#{Faker::Lorem.paragraph(sentence_count: 2)}" }
     confirmation_sent_at { Time.current }
     accepted_tos_version { organization.tos_version }
     notifications_sending_frequency { "real_time" }
@@ -216,14 +181,13 @@ FactoryBot.define do
     trait :managed do
       email { "" }
       password { "" }
-      password_confirmation { "" }
       encrypted_password { "" }
       managed { true }
     end
 
     trait :officialized do
       officialized_at { Time.current }
-      officialized_as { generate_localized_title(:officialized_as, skip_injection: skip_injection) }
+      officialized_as { generate_localized_title }
     end
 
     after(:build) do |user, evaluator|
@@ -231,29 +195,21 @@ FactoryBot.define do
       # to do this to ensure the user creation does not fail due to the short
       # password.
       user.password ||= evaluator.password || "decidim123456789"
-      user.password_confirmation ||= evaluator.password_confirmation || user.password
     end
   end
 
   factory :participatory_space_private_user, class: "Decidim::ParticipatorySpacePrivateUser" do
-    transient do
-      skip_injection { false }
-    end
     user
-    privatable_to { create(:participatory_process, organization: user.organization, skip_injection: skip_injection) }
+    privatable_to { create(:participatory_process, organization: user.organization) }
   end
 
   factory :assembly_private_user, class: "Decidim::ParticipatorySpacePrivateUser" do
-    transient do
-      skip_injection { false }
-    end
     user
-    privatable_to { create(:assembly, organization: user.organization, skip_injection: skip_injection) }
+    privatable_to { create(:assembly, organization: user.organization) }
   end
 
   factory :user_group, class: "Decidim::UserGroup" do
     transient do
-      skip_injection { false }
       document_number { "#{Faker::Number.number(digits: 8)}X" }
       phone { Faker::PhoneNumber.phone_number }
       rejected_at { nil }
@@ -263,7 +219,7 @@ FactoryBot.define do
     sequence(:name) { |n| "#{Faker::Company.name} #{n}" }
     email { generate(:user_group_email) }
     nickname { generate(:nickname) }
-    about { generate_localized_title(:user_group_about, skip_injection: skip_injection) }
+    about { "<script>alert(\"ABOUT\");</script>#{Faker::Lorem.paragraph(sentence_count: 2)}" }
     organization
     avatar { Decidim::Dev.test_file("avatar.jpg", "image/jpeg") } # Keep after organization
 
@@ -304,27 +260,21 @@ FactoryBot.define do
       next if users.empty?
 
       creator = users.shift
-      create(:user_group_membership, user: creator, user_group: user_group, role: :creator, skip_injection: evaluator.skip_injection)
+      create(:user_group_membership, user: creator, user_group:, role: :creator)
 
       users.each do |user|
-        create(:user_group_membership, user: user, user_group: user_group, role: :admin, skip_injection: evaluator.skip_injection)
+        create(:user_group_membership, user:, user_group:, role: :admin)
       end
     end
   end
 
   factory :user_group_membership, class: "Decidim::UserGroupMembership" do
-    transient do
-      skip_injection { false }
-    end
-    user { create(:user, :confirmed, organization: user_group.organization, skip_injection: skip_injection) }
+    user { create(:user, :confirmed, organization: user_group.organization) }
     role { :creator }
     user_group
   end
 
   factory :identity, class: "Decidim::Identity" do
-    transient do
-      skip_injection { false }
-    end
     provider { "facebook" }
     sequence(:uid)
     user
@@ -332,9 +282,6 @@ FactoryBot.define do
   end
 
   factory :authorization, class: "Decidim::Authorization" do
-    transient do
-      skip_injection { false }
-    end
     sequence(:name) { |n| "dummy_authorization_#{n}" }
     user
     metadata { {} }
@@ -349,14 +296,39 @@ FactoryBot.define do
     end
   end
 
-  factory :static_page, class: "Decidim::StaticPage" do
+  factory :authorization_transfer, class: "Decidim::AuthorizationTransfer" do
+    transient do
+      organization { create(:organization) }
+    end
+
+    user { create(:user, :confirmed, organization:) }
+    source_user { create(:user, :confirmed, :deleted, organization: user.try(:organization) || organization) }
+    authorization do
+      create(
+        :authorization,
+        user: source_user || create(:user, :confirmed, :deleted, organization: user.try(:organization) || organization)
+      )
+    end
+
+    trait :transferred do
+      authorization { create(:authorization, user:) }
+    end
+  end
+
+  factory :authorization_transfer_record, class: "Decidim::AuthorizationTransferRecord" do
     transient do
-      skip_injection { false }
+      organization { resource.try(:organization) || create(:organization) }
     end
+
+    transfer { create(:authorization_transfer, organization:) }
+    resource { create(:dummy_resource) }
+  end
+
+  factory :static_page, class: "Decidim::StaticPage" do
     slug { generate(:slug) }
-    title { generate_localized_title(:static_page_title, skip_injection: skip_injection) }
-    content { generate_localized_description(:static_page_content, skip_injection: skip_injection) }
-    organization { build(:organization, skip_injection: skip_injection) }
+    title { generate_localized_title }
+    content { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
+    organization { build(:organization) }
     allow_public_access { false }
 
     trait :default do
@@ -364,7 +336,7 @@ FactoryBot.define do
     end
 
     trait :tos do
-      slug { "terms-and-conditions" }
+      slug { "terms-of-service" }
       after(:create) do |tos_page|
         tos_page.organization.tos_version = tos_page.updated_at
         tos_page.organization.save!
@@ -372,8 +344,8 @@ FactoryBot.define do
     end
 
     trait :with_topic do
-      after(:create) do |static_page, evaluator|
-        topic = create(:static_page_topic, organization: static_page.organization, skip_injection: evaluator.skip_injection)
+      after(:create) do |static_page|
+        topic = create(:static_page_topic, organization: static_page.organization)
         static_page.topic = topic
         static_page.save
       end
@@ -381,33 +353,24 @@ FactoryBot.define do
   end
 
   factory :static_page_topic, class: "Decidim::StaticPageTopic" do
-    transient do
-      skip_injection { false }
-    end
-    title { generate_localized_title(:static_page_topic_title, skip_injection: skip_injection) }
-    description { generate_localized_description(:static_page_topic_description, skip_injection: skip_injection) }
+    title { generate_localized_title }
+    description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
     organization
   end
 
   factory :attachment_collection, class: "Decidim::AttachmentCollection" do
-    transient do
-      skip_injection { false }
-    end
-    name { generate_localized_title(:attachment_collection_name, skip_injection: skip_injection) }
-    description { generate_localized_title(:attachment_collection_description, skip_injection: skip_injection) }
+    name { generate_localized_title }
+    description { generate_localized_title }
     weight { Faker::Number.number(digits: 1) }
 
     association :collection_for, factory: :participatory_process
   end
 
   factory :attachment, class: "Decidim::Attachment" do
-    transient do
-      skip_injection { false }
-    end
-    title { generate_localized_title(:attachment_title, skip_injection: skip_injection) }
-    description { generate_localized_title(:attachment_description, skip_injection: skip_injection) }
+    title { generate_localized_title }
+    description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
     weight { Faker::Number.number(digits: 1) }
-    attached_to { build(:participatory_process, skip_injection: skip_injection) }
+    attached_to { build(:participatory_process) }
     content_type { "image/jpeg" }
     file { Decidim::Dev.test_file("city.jpeg", "image/jpeg") } # Keep after attached_to
     file_size { 108_908 }
@@ -425,24 +388,23 @@ FactoryBot.define do
 
   factory :component, class: "Decidim::Component" do
     transient do
-      skip_injection { false }
-      organization { create(:organization, skip_injection: skip_injection) }
+      organization { create(:organization) }
     end
 
-    name { generate_localized_title(:component_name, skip_injection: skip_injection) }
-    participatory_space { create(:participatory_process, organization: organization, skip_injection: skip_injection) }
+    name { generate_localized_title }
+    participatory_space { create(:participatory_process, organization:) }
     manifest_name { "dummy" }
     published_at { Time.current }
     settings do
       {
-        dummy_global_translatable_text: generate_localized_title(:dummy_global_translatable_text, skip_injection: skip_injection),
+        dummy_global_translatable_text: generate_localized_title,
         comments_max_length: participatory_space.organization.comments_max_length || organization.comments_max_length
       }
     end
 
     default_step_settings do
       {
-        dummy_step_translatable_text: generate_localized_title(:dummy_step_translatable_text, skip_injection: skip_injection)
+        dummy_step_translatable_text: generate_localized_title
       }
     end
 
@@ -480,8 +442,7 @@ FactoryBot.define do
         create(:participatory_process_step,
                active: true,
                end_date: 1.month.from_now,
-               participatory_process: participatory_space,
-               skip_injection: skip_injection)
+               participatory_process: participatory_space)
         participatory_space.reload
         participatory_space.steps.reload
       end
@@ -524,29 +485,20 @@ FactoryBot.define do
   end
 
   factory :scope_type, class: "Decidim::ScopeType" do
-    transient do
-      skip_injection { false }
-    end
-    name { generate_localized_word(:scope_type_name, skip_injection: skip_injection) }
+    name { Decidim::Faker::Localized.word }
     plural { Decidim::Faker::Localized.literal(name.values.first.pluralize) }
     organization
   end
 
   factory :scope, class: "Decidim::Scope" do
-    transient do
-      skip_injection { false }
-    end
     name { Decidim::Faker::Localized.literal(generate(:scope_name)) }
     code { generate(:scope_code) }
-    scope_type { create(:scope_type, organization: organization, skip_injection: skip_injection) }
-    organization { parent ? parent.organization : build(:organization, skip_injection: skip_injection) }
+    scope_type { create(:scope_type, organization:) }
+    organization { parent ? parent.organization : build(:organization) }
   end
 
   factory :subscope, parent: :scope do
-    transient do
-      skip_injection { false }
-    end
-    parent { build(:scope, skip_injection: skip_injection) }
+    parent { build(:scope) }
 
     before(:create) do |object|
       object.parent.save unless object.parent.persisted?
@@ -554,111 +506,84 @@ FactoryBot.define do
   end
 
   factory :area_type, class: "Decidim::AreaType" do
-    transient do
-      skip_injection { false }
-    end
-    name { generate_localized_word(:area_type_name, skip_injection: skip_injection) }
+    name { Decidim::Faker::Localized.word }
     plural { Decidim::Faker::Localized.literal(name.values.first.pluralize) }
     organization
   end
 
   factory :area, class: "Decidim::Area" do
-    transient do
-      skip_injection { false }
-    end
     name { Decidim::Faker::Localized.literal(generate(:area_name)) }
     organization
   end
 
   factory :coauthorship, class: "Decidim::Coauthorship" do
-    transient do
-      skip_injection { false }
-    end
-    coauthorable { create(:dummy_resource, skip_injection: skip_injection) }
+    coauthorable { create(:dummy_resource) }
     transient do
       organization { coauthorable.component.participatory_space.organization }
     end
-    author { create(:user, :confirmed, organization: organization, skip_injection: skip_injection) }
+    author { create(:user, :confirmed, organization:) }
   end
 
   factory :dummy_resource, class: "Decidim::DummyResources::DummyResource" do
     transient do
-      skip_injection { false }
       users { nil }
       # user_groups correspondence to users is by sorting order
       user_groups { [] }
     end
-    title { generate_localized_title(:dummy_resource_title, skip_injection: skip_injection) }
-    component { create(:dummy_component, skip_injection: skip_injection) }
-    author { create(:user, :confirmed, organization: component.organization, skip_injection: skip_injection) }
-    scope { create(:scope, organization: component.organization, skip_injection: skip_injection) }
+    title { Decidim::Faker::Localized.localized { generate(:name) } }
+    component { create(:component, manifest_name: "dummy") }
+    author { create(:user, :confirmed, organization: component.organization) }
+    scope { create(:scope, organization: component.organization) }
 
     trait :published do
       published_at { Time.current }
     end
 
     trait :with_endorsements do
-      after :create do |resource, evaluator|
+      after :create do |resource|
         5.times.collect do
-          create(:endorsement, resource: resource, skip_injection: evaluator.skip_injection,
-                               author: build(:user, organization: resource.component.organization, skip_injection: evaluator.skip_injection))
+          create(:endorsement, resource:, author: build(:user, organization: resource.component.organization))
         end
       end
     end
-
-    trait :moderated do
-      after(:create) do |resource, evaluator|
-        create(:moderation, reportable: resource, hidden_at: 2.days.ago, skip_injection: evaluator.skip_injection)
-      end
-    end
   end
 
   factory :nested_dummy_resource, class: "Decidim::DummyResources::NestedDummyResource" do
-    transient do
-      skip_injection { false }
-    end
     title { generate(:name) }
-    dummy_resource { create(:dummy_resource, skip_injection: skip_injection) }
+    dummy_resource { create(:dummy_resource) }
   end
 
   factory :coauthorable_dummy_resource, class: "Decidim::DummyResources::CoauthorableDummyResource" do
-    transient do
-      skip_injection { false }
+    title { generate(:name) }
+    component { create(:component, manifest_name: "dummy") }
 
-      authors_list { [create(:user, organization: component.organization, skip_injection: skip_injection)] }
+    transient do
+      authors_list { [create(:user, organization: component.organization)] }
     end
-    title { generate(:name) }
-    component { create(:component, manifest_name: "dummy", skip_injection: skip_injection) }
 
     after :build do |resource, evaluator|
       evaluator.authors_list.each do |coauthor|
-        resource.coauthorships << if coauthor.is_a?(::Decidim::UserGroup)
-                                    build(:coauthorship, author: coauthor.users.first, user_group: coauthor, coauthorable: resource,
-                                                         organization: evaluator.component.organization, skip_injection: evaluator.skip_injection)
+        resource.coauthorships << if coauthor.is_a?(Decidim::UserGroup)
+                                    build(:coauthorship, author: coauthor.users.first, user_group: coauthor, coauthorable: resource, organization: evaluator.component.organization)
                                   else
-                                    build(:coauthorship, author: coauthor, coauthorable: resource,
-                                                         organization: evaluator.component.organization, skip_injection: evaluator.skip_injection)
+                                    build(:coauthorship, author: coauthor, coauthorable: resource, organization: evaluator.component.organization)
                                   end
       end
     end
   end
 
   factory :resource_link, class: "Decidim::ResourceLink" do
-    transient do
-      skip_injection { false }
-    end
     name { generate(:slug) }
-    to { build(:dummy_resource, skip_injection: skip_injection) }
-    from { build(:dummy_resource, component: to.component, skip_injection: skip_injection) }
+    to { build(:dummy_resource) }
+    from { build(:dummy_resource, component: to.component) }
   end
 
   factory :newsletter, class: "Decidim::Newsletter" do
     transient do
-      skip_injection { false }
-      body { generate_localized_description(:newsletter_body, skip_injection: skip_injection) }
+      body { Decidim::Faker::Localized.wrapped("<p>", "</p>") { generate_localized_title } }
     end
 
-    author { build(:user, :confirmed, organization: organization, skip_injection: skip_injection) }
+    author { build(:user, :confirmed, organization:) }
     organization
 
     subject { generate_localized_title }
@@ -670,8 +595,7 @@ FactoryBot.define do
         organization: evaluator.organization,
         scoped_resource_id: newsletter.id,
         manifest_name: "basic_only_text",
-        settings: evaluator.body.transform_keys { |key| "body_#{key}" },
-        skip_injection: evaluator.skip_injection
+        settings: evaluator.body.transform_keys { |key| "body_#{key}" }
       )
     end
 
@@ -681,10 +605,7 @@ FactoryBot.define do
   end
 
   factory :moderation, class: "Decidim::Moderation" do
-    transient do
-      skip_injection { false }
-    end
-    reportable { build(:dummy_resource, skip_injection: skip_injection) }
+    reportable { build(:dummy_resource) }
     participatory_space { reportable.component.participatory_space }
 
     trait :hidden do
@@ -693,49 +614,37 @@ FactoryBot.define do
   end
 
   factory :report, class: "Decidim::Report" do
-    transient do
-      skip_injection { false }
-    end
     moderation
-    user { build(:user, organization: moderation.reportable.organization, skip_injection: skip_injection) }
+    user { build(:user, organization: moderation.reportable.organization) }
     reason { "spam" }
   end
 
   factory :impersonation_log, class: "Decidim::ImpersonationLog" do
-    transient do
-      skip_injection { false }
-    end
-    admin { build(:user, :admin, skip_injection: skip_injection) }
-    user { build(:user, :managed, organization: admin.organization, skip_injection: skip_injection) }
+    admin { build(:user, :admin) }
+    user { build(:user, :managed, organization: admin.organization) }
     started_at { 10.minutes.ago }
   end
 
   factory :follow, class: "Decidim::Follow" do
-    transient do
-      skip_injection { false }
-    end
     user do
       build(
         :user,
-        organization: followable.try(:organization) || build(:organization, skip_injection: skip_injection)
+        organization: followable.try(:organization) || build(:organization)
       )
     end
-    followable { build(:dummy_resource, skip_injection: skip_injection) }
+    followable { build(:dummy_resource) }
   end
 
   factory :notification, class: "Decidim::Notification" do
-    transient do
-      skip_injection { false }
-    end
     user do
       build(
         :user,
-        organization: resource.try(:organization) || build(:organization, skip_injection: skip_injection)
+        organization: resource.try(:organization) || build(:organization)
       )
     end
-    resource { build(:dummy_resource, skip_injection: skip_injection) }
+    resource { build(:dummy_resource) }
     event_name { resource.class.name.underscore.tr("/", ".") }
-    event_class { "Decidim::DummyResourceEvent" }
+    event_class { "Decidim::DummyResources::DummyResourceEvent" }
     extra do
       {
         some_extra_data: "1"
@@ -743,60 +652,16 @@ FactoryBot.define do
     end
   end
 
-  factory :conversation, class: "Decidim::Messaging::Conversation" do
-    transient do
-      skip_injection { false }
-    end
-
-    originator { build(:user) }
-    interlocutors { [build(:user)] }
-    body { Faker::Lorem.sentence }
-    user
-
-    after(:create) do |object|
-      object.participants ||= [originator + interlocutors].flatten
-    end
-
-    initialize_with { Decidim::Messaging::Conversation.start(originator: originator, interlocutors: interlocutors, body: body, user: user) }
-  end
-
-  factory :message, class: "Decidim::Messaging::Message" do
-    transient do
-      skip_injection { false }
-    end
-
-    body { generate_localized_description(:message_body) }
-    conversation
-
-    before(:create) do |object|
-      object.sender ||= object.conversation.participants.take
-    end
-  end
-
-  factory :push_notification_message, class: "Decidim::PushNotificationMessage" do
-    transient do
-      skip_injection { false }
-    end
-
-    recipient { build(:user) }
-    conversation { create(:conversation) }
-    message { generate_localized_description(:push_notification_message_message) }
-
-    skip_create
-    initialize_with { Decidim::PushNotificationMessage.new(recipient: recipient, conversation: conversation, message: message) }
-  end
-
   factory :action_log, class: "Decidim::ActionLog" do
     transient do
-      skip_injection { false }
       extra_data { {} }
     end
 
     organization { user.organization }
     user
-    participatory_space { build(:participatory_process, organization: organization, skip_injection: skip_injection) }
-    component { build(:component, participatory_space: participatory_space, skip_injection: skip_injection) }
-    resource { build(:dummy_resource, component: component, skip_injection: skip_injection) }
+    participatory_space { build(:participatory_process, organization:) }
+    component { build(:component, participatory_space:) }
+    resource { build(:dummy_resource, component:) }
     action { "create" }
     visibility { "admin-only" }
     extra do
@@ -822,9 +687,6 @@ FactoryBot.define do
   end
 
   factory :oauth_application, class: "Decidim::OAuthApplication" do
-    transient do
-      skip_injection { false }
-    end
     organization
     sequence(:name) { |n| "OAuth application #{n}" }
     sequence(:organization_name) { |n| "OAuth application owner #{n}" }
@@ -835,11 +697,8 @@ FactoryBot.define do
   end
 
   factory :oauth_access_token, class: "Doorkeeper::AccessToken" do
-    transient do
-      skip_injection { false }
-    end
-    resource_owner_id { create(:user, organization: application.organization, skip_injection: skip_injection).id }
-    application { build(:oauth_application, skip_injection: skip_injection) }
+    resource_owner_id { create(:user, organization: application.organization).id }
+    application { build(:oauth_application) }
     token { SecureRandom.hex(32) }
     expires_in { 1.month.from_now }
     created_at { Time.current }
@@ -847,10 +706,7 @@ FactoryBot.define do
   end
 
   factory :searchable_resource, class: "Decidim::SearchableResource" do
-    transient do
-      skip_injection { false }
-    end
-    resource { build(:dummy_resource, skip_injection: skip_injection) }
+    resource { build(:dummy_resource) }
     resource_id { resource.id }
     resource_type { resource.class.name }
     organization { resource.component.organization }
@@ -862,9 +718,6 @@ FactoryBot.define do
   end
 
   factory :content_block, class: "Decidim::ContentBlock" do
-    transient do
-      skip_injection { false }
-    end
     organization
     scope_name { :homepage }
     manifest_name { :hero }
@@ -878,84 +731,58 @@ FactoryBot.define do
   end
 
   factory :hashtag, class: "Decidim::Hashtag" do
-    transient do
-      skip_injection { false }
-    end
     name { generate(:hashtag_name) }
     organization
   end
 
   factory :metric, class: "Decidim::Metric" do
-    transient do
-      skip_injection { false }
-    end
     organization
     day { Time.zone.today }
     metric_type { "random_metric" }
     cumulative { 2 }
     quantity { 1 }
-    category { create :category }
-    participatory_space { create(:participatory_process, organization: organization, skip_injection: skip_injection) }
-    related_object { create(:component, participatory_space: participatory_space, skip_injection: skip_injection) }
+    category { create(:category) }
+    participatory_space { create(:participatory_process, organization:) }
+    related_object { create(:component, participatory_space:) }
   end
 
   factory :amendment, class: "Decidim::Amendment" do
-    transient do
-      skip_injection { false }
-    end
-    amendable { build(:dummy_resource, skip_injection: skip_injection) }
-    emendation { build(:dummy_resource, skip_injection: skip_injection) }
+    amendable { build(:dummy_resource) }
+    emendation { build(:dummy_resource) }
     amender { emendation.try(:creator_author) || emendation.try(:author) }
     state { "evaluating" }
 
-    trait :draft do
-      state { "draft" }
-    end
-
-    trait :rejected do
-      state { "rejected" }
+    Decidim::Amendment::STATES.keys.each do |defined_state|
+      trait defined_state do
+        state { defined_state }
+      end
     end
   end
 
   factory :user_report, class: "Decidim::UserReport" do
-    transient do
-      skip_injection { false }
-    end
     reason { "spam" }
-    moderation { create(:user_moderation, user: user, skip_injection: skip_injection) }
+    moderation { create(:user_moderation, user:) }
     user { build(:user) }
   end
 
   factory :user_moderation, class: "Decidim::UserModeration" do
-    transient do
-      skip_injection { false }
-    end
-    user { build(:user, skip_injection: skip_injection) }
+    user { build(:user) }
   end
 
   factory :endorsement, class: "Decidim::Endorsement" do
-    transient do
-      skip_injection { false }
-    end
-    resource { build(:dummy_resource, skip_injection: skip_injection) }
-    author { resource.try(:creator_author) || resource.try(:author) || build(:user, organization: resource.organization, skip_injection: skip_injection) }
+    resource { build(:dummy_resource) }
+    author { resource.try(:creator_author) || resource.try(:author) || build(:user, organization: resource.organization) }
   end
 
   factory :user_group_endorsement, class: "Decidim::Endorsement" do
-    transient do
-      skip_injection { false }
-    end
-    resource { build(:dummy_resource, skip_injection: skip_injection) }
-    author { build(:user, organization: resource.organization, skip_injection: skip_injection) }
-    user_group { create(:user_group, verified_at: Time.current, organization: resource.organization, users: [author], skip_injection: skip_injection) }
+    resource { build(:dummy_resource) }
+    author { build(:user, organization: resource.organization) }
+    user_group { create(:user_group, verified_at: Time.current, organization: resource.organization, users: [author]) }
   end
 
   factory :share_token, class: "Decidim::ShareToken" do
-    transient do
-      skip_injection { false }
-    end
-    token_for { build(:component, skip_injection: skip_injection) }
-    user { build(:user, organization: token_for.organization, skip_injection: skip_injection) }
+    token_for { build(:component) }
+    user { build(:user, organization: token_for.organization) }
 
     before(:create) do |object|
       object.organization ||= object.token_for.organization
@@ -972,48 +799,39 @@ FactoryBot.define do
   end
 
   factory :editor_image, class: "Decidim::EditorImage" do
-    transient do
-      skip_injection { false }
-    end
     organization
-    author { create(:user, :admin, :confirmed, organization: organization, skip_injection: skip_injection) }
+    author { create(:user, :admin, :confirmed, organization:) }
     file { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
   end
 
   factory :reminder, class: "Decidim::Reminder" do
-    transient do
-      skip_injection { false }
-    end
-    user { build(:user, skip_injection: skip_injection) }
-    component { build(:dummy_component, organization: user.organization, skip_injection: skip_injection) }
+    user { build(:user) }
+    component { build(:dummy_component, organization: user.organization) }
   end
 
   factory :reminder_record, class: "Decidim::ReminderRecord" do
-    transient do
-      skip_injection { false }
+    reminder { create(:reminder) }
+    remindable { build(:dummy_resource) }
+
+    Decidim::ReminderRecord::STATES.keys.each do |defined_state|
+      trait defined_state do
+        state { defined_state }
+      end
     end
-    reminder { create(:reminder, skip_injection: skip_injection) }
-    remindable { build(:dummy_resource, skip_injection: skip_injection) }
   end
 
   factory :reminder_delivery, class: "Decidim::ReminderDelivery" do
-    transient do
-      skip_injection { false }
-    end
-    reminder { create(:reminder, skip_injection: skip_injection) }
+    reminder { create(:reminder) }
   end
 
   factory :short_link, class: "Decidim::ShortLink" do
-    transient do
-      skip_injection { false }
-    end
-    target { create(:component, manifest_name: "dummy", skip_injection: skip_injection) }
+    target { create(:component, manifest_name: "dummy") }
     route_name { nil }
     params { {} }
 
-    before(:create) do |object, evaluator|
+    before(:create) do |object|
       object.organization ||= object.target if object.target.is_a?(Decidim::Organization)
-      object.organization ||= object.target.try(:organization) || create(:organization, skip_injection: evaluator.skip_injection)
+      object.organization ||= object.target.try(:organization) || create(:organization)
       object.identifier ||= Decidim::ShortLink.unique_identifier_within(object.organization)
       object.mounted_engine_name ||=
         if object.target.respond_to?(:participatory_space)