decidim-core 0.22.0 → 0.23.0

data/app/cells/decidim/diff/diff_mode_html.erb

@@ -8,19 +8,19 @@
       <ul class="dropdown menu" data-dropdown-menu>
         <li class="is-dropdown-submenu-parent">
           <a id="diff-view-selected">
-            <%= t("versions.dropdown.option_escaped") %>
+            <%= t("versions.dropdown.option_unescaped") %>
           </a>
 
           <ul class="menu">
             <li>
-              <%= link_to "#escaped-html", class: "diff-view-html", id:"escaped-html" do %>
-                <%= t("versions.dropdown.option_escaped") %>
+              <%= link_to "#unescaped-html", class: "diff-view-html", id:"unescaped-html" do %>
+                <%= t("versions.dropdown.option_unescaped") %>
               <% end %>
             </li>
 
             <li>
-              <%= link_to "#unescaped-html", class: "diff-view-html", id:"unescaped-html" do %>
-                <%= t("versions.dropdown.option_unescaped") %>
+              <%= link_to "#escaped-html", class: "diff-view-html", id:"escaped-html" do %>
+                <%= t("versions.dropdown.option_escaped") %>
               <% end %>
             </li>
           </ul>

data/app/cells/decidim/follow_button/show.erb

@@ -4,8 +4,8 @@
       <%= button_to decidim.follow_path, class: button_classes, params: { follow: { followable_gid: model.to_sgid.to_s, inline: inline? } }, data: { disable: true }, method: :delete, remote: true do %>
         <span class="icon-wrap">
           <%= icon "bell", icon_options %>
-          <span aria-hidden="true"><%= model.followers.count %></span>
-          <span class="show-for-sr"><%= t("decidim.followers.followers_count", count: model.followers.count) %></span>
+          <span aria-hidden="true"><%= followers_count %></span>
+          <span class="show-for-sr"><%= t("decidim.followers.followers_count", count: followers_count) %></span>
         </span>
         <span class="text-wrap">
           <%= t("follows.destroy.button", scope: "decidim") %>
@@ -16,8 +16,8 @@
       <%= button_to decidim.follow_path, class: button_classes, params: { follow: { followable_gid: model.to_sgid.to_s, inline: inline? } }, data: { disable: true }, remote: true do %>
         <span class="icon-wrap">
           <%= icon "bell", icon_options %>
-          <span aria-hidden="true"><%= model.followers.count %></span>
-          <span class="show-for-sr"><%= t("decidim.followers.followers_count", count: model.followers.count) %></span>
+          <span aria-hidden="true"><%= followers_count %></span>
+          <span class="show-for-sr"><%= t("decidim.followers.followers_count", count: followers_count) %></span>
         </span>
         <span class="text-wrap">
           <% if current_user.follows?(model.try(:participatory_space)) %>
@@ -42,8 +42,8 @@
       remote: true) do %>
       <span class="icon-wrap">
         <%= icon "bell", icon_options %>
-        <span aria-hidden="true"><%= model.followers.count %></span>
-        <span class="show-for-sr"><%= t("decidim.followers.followers_count", count: model.followers.count) %></span>
+        <span aria-hidden="true"><%= followers_count %></span>
+        <span class="show-for-sr"><%= t("decidim.followers.followers_count", count: followers_count) %></span>
       </span>
       <span class="text-wrap">
         <%= t("follows.create.button", scope: "decidim") %>

data/app/cells/decidim/follow_button_cell.rb

@@ -15,6 +15,14 @@ module Decidim
 
     private
 
+    def followers_count
+      if model.respond_to?(:followers_count)
+        model.followers_count
+      else
+        model.followers.count
+      end
+    end
+
     def button_classes
       return "card__button secondary text-uppercase follow-button mb-none has-tip" if inline?
 

data/app/cells/decidim/progress_bar/show.erb

@@ -1,14 +1,21 @@
-<div id="<%= element_id %>" class="progress__bar<%= " progress__bar--vertical" unless small? %>">
+<div id="<%= element_id %>" class="<%= container_class %>">
   <div class="progress__bar__title">
-    <span class="progress__bar__number"><%= progress %></span><%= "/#{total}" if total != 0 %>
-    <span class="progress__bar__text"><%= units_name_text %></span>
+
+    <% if horizontal? %>
+      <span class="progress__bar__text"><%= subtitle_text %></span>
+      <span class="progress__bar__number"><%= progress %></span><%= "/#{total}" if total != 0 %>
+    <% else %>
+      <span class="progress__bar__number"><%= progress %></span><%= "/#{total}" if total != 0 %>
+      <span class="progress__bar__text"><%= units_name_text %></span>
+    <% end %>
   </div>
   <% if total != 0 %>
     <div class="progress progress__bar__bar" role="progressbar" tabindex="0" aria-valuenow="<%= percentage %>" aria-valuemin="0" aria-valuetext="<%= percentage %> percent" aria-valuemax="100">
       <div class="progress-meter progress__bar__bar--complete" style="width: <%= percentage %>%"></div>
       <div class="progress__bar__bar--incomplete" style="width:calc(100% - <%= percentage %>%);"></div>
     </div>
-    <% if subtitle_text.present? %>
+
+    <% if display_subtitle? %>
       <div class="progress__bar__subtitle">
         <%= subtitle_text %>
       </div>

data/app/cells/decidim/progress_bar_cell.rb

@@ -22,7 +22,7 @@ module Decidim
   # Example:
   #
   #    cell(
-  #      "decidim/progress_bar_list",
+  #      "decidim/progress_bar",
   #      7,
   #      element_id: "my-id",
   #      units_name: "my.i18n.key",
@@ -49,10 +49,29 @@ module Decidim
       options[:subtitle_text]
     end
 
+    def container_class
+      container_class = "progress__bar"
+      container_class += " progress__bar--horizontal" if horizontal? && !small?
+      container_class += " progress__bar--vertical" if vertical?
+      container_class
+    end
+
+    def display_subtitle?
+      subtitle_text.present? && !small? && !horizontal?
+    end
+
     def small?
       options[:small].to_s == "true"
     end
 
+    def vertical?
+      !small? && !horizontal?
+    end
+
+    def horizontal?
+      options[:horizontal].to_s == "true"
+    end
+
     def progress
       model
     end

data/app/cells/decidim/translation_bar/show.erb

@@ -0,0 +1,6 @@
+<div class="wrapper-mini translation-bar">
+  <div class="row column">
+    <%= link %>
+    <span class="translation-button-help"><%= help_text %></span>
+  </div>
+</div>

data/app/cells/decidim/translation_bar_cell.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module Decidim
+  # This cell is used to render a button to toggle machine translations. It will
+  # only render if the translations are enabled.
+  class TranslationBarCell < Decidim::ViewModel
+    include Decidim::TranslatableAttributes
+
+    def show
+      return unless renderable?
+
+      render
+    end
+
+    def renderable?
+      Decidim.config.enable_machine_translations &&
+        model.enable_machine_translations
+    end
+
+    def link
+      original_url = request.original_url
+      parsed_url = URI.parse(original_url)
+      query = parsed_url.query
+      new_query_params = "toggle_translations=true"
+
+      new_query = if RequestStore.store[:toggle_machine_translations]
+                    query.gsub("toggle_translations=true", "")
+                  elsif query.nil?
+                    new_query_params
+                  else
+                    query + "&" + new_query_params
+                  end
+
+      parsed_url.query = new_query
+      url = parsed_url.to_s
+
+      link_to button_text, url, class: "button small hollow"
+    end
+
+    def button_text
+      if must_render_translation?(model)
+        t("decidim.translation_bar.show_original")
+      else
+        t("decidim.translation_bar.show_translated")
+      end
+    end
+
+    def help_text
+      t("decidim.translation_bar.help_text")
+    end
+  end
+end

data/app/cells/decidim/version_cell.rb

@@ -77,7 +77,7 @@ module Decidim
     end
 
     def resource_path
-      resource_locator(versioned_resource).path
+      resource_locator(versioned_resource).path(filter_link_params)
     end
   end
 end

data/app/cells/decidim/versions_list_cell.rb

@@ -13,7 +13,7 @@ module Decidim
     end
 
     def resource_path
-      resource_locator(versioned_resource).path
+      resource_locator(versioned_resource).path(filter_link_params)
     end
 
     def i18n_changes_title

data/app/commands/decidim/amendable/accept.rb

@@ -50,12 +50,18 @@ module Decidim
       end
 
       def update_amendable!
-        @amendable = Decidim.traceability.update!(
+        @amendable = Decidim.traceability.perform_action!(
+          :update,
           @amendable,
           @amender,
-          form.emendation_params,
           visibility: "public-only"
-        )
+        ) do
+          @amendable.assign_attributes(form.emendation_params)
+          @amendable.title = { I18n.locale => form.emendation_params.with_indifferent_access[:title] }
+          @amendable.body = { I18n.locale => form.emendation_params.with_indifferent_access[:body] }
+          @amendable.save!
+          @amendable
+        end
         @amendable.add_coauthor(@amender, user_group: @user_group)
       end
 

data/app/commands/decidim/amendable/create_draft.rb

@@ -49,6 +49,8 @@ module Decidim
             visibility: "public-only"
           ) do
             emendation = amendable.class.new(form.emendation_params)
+            emendation.title = { I18n.locale => form.emendation_params.with_indifferent_access[:title] }
+            emendation.body = { I18n.locale => form.emendation_params.with_indifferent_access[:body] }
             emendation.component = amendable.component
             emendation.add_author(current_user, user_group)
             emendation.save!

data/app/commands/decidim/amendable/update_draft.rb

@@ -45,6 +45,8 @@ module Decidim
       def update_draft
         PaperTrail.request(enabled: false) do
           emendation.assign_attributes(form.emendation_params)
+          emendation.title = { I18n.locale => form.emendation_params.with_indifferent_access[:title] }
+          emendation.body = { I18n.locale => form.emendation_params.with_indifferent_access[:body] }
           emendation.add_author(current_user, user_group)
           emendation.save!
         end

data/app/commands/decidim/attachment_methods.rb

@@ -5,11 +5,14 @@ module Decidim
   module AttachmentMethods
     private
 
-    def build_attachment
+    def build_attachment(attached_to = nil)
+      attached_to = @attached_to if attached_to.blank?
+      attached_to = form.current_organization if attached_to.blank? && form.respond_to?(:current_organization)
+
       @attachment = Attachment.new(
-        title: @form.attachment.title,
-        file: @form.attachment.file,
-        attached_to: @attached_to
+        title: { I18n.locale => @form.attachment.title },
+        attached_to: attached_to,
+        file: @form.attachment.file # Define attached_to before this
       )
     end
 
@@ -24,6 +27,10 @@ module Decidim
       @form.attachment.file.present?
     end
 
+    def attachment_file_uploaded?
+      !@form.attachment.file.is_a?(Decidim::ApplicationUploader)
+    end
+
     def create_attachment
       attachment.attached_to = @attached_to
       attachment.save!
@@ -34,7 +41,7 @@ module Decidim
     end
 
     def process_attachments?
-      attachments_allowed? && attachment_present?
+      attachments_allowed? && attachment_present? && attachment_file_uploaded?
     end
   end
 end

data/app/commands/decidim/destroy_account.rb

@@ -34,6 +34,7 @@ module Decidim
       @user.nickname = ""
       @user.email = ""
       @user.delete_reason = @form.delete_reason
+      @user.admin = false if @user.admin?
       @user.deleted_at = Time.current
       @user.skip_reconfirmation!
       @user.remove_avatar!

data/app/commands/decidim/gallery_methods.rb

@@ -6,15 +6,15 @@ module Decidim
   module GalleryMethods
     private
 
-    def build_gallery
+    def build_gallery(attached_to = nil)
       @gallery = []
       @form.add_photos.each do |photo|
         next unless image? photo
 
         @gallery << Attachment.new(
-          title: photo.original_filename,
-          file: photo,
-          attached_to: @attached_to
+          title: { I18n.locale => photo.original_filename },
+          attached_to: attached_to || gallery_attached_to,
+          file: photo # Define attached_to before this
         )
       end
     end
@@ -26,7 +26,7 @@ module Decidim
     end
 
     def gallery_invalid?
-      gallery.each do |photo|
+      @gallery.each do |photo|
         if photo.invalid? && photo.errors.has_key?(:file)
           @form.errors.add(:add_photos, photo.errors[:file])
           return true
@@ -37,19 +37,19 @@ module Decidim
 
     def create_gallery
       @gallery.map! do |photo|
-        photo.attached_to = @attached_to
+        photo.attached_to = gallery_attached_to
         photo.save!
         @form.photos << photo.id.to_s
       end
     end
 
     def photo_cleanup!
-      @attached_to.photos.each do |photo|
+      gallery_attached_to.photos.each do |photo|
         photo.destroy! if @form.photos.exclude? photo.id.to_s
       end
       # manually reset cached photos
-      @attached_to.reload
-      @attached_to.instance_variable_set(:@photos, nil)
+      gallery_attached_to.reload
+      gallery_attached_to.instance_variable_set(:@photos, nil)
     end
 
     # maybe a custom settings options would be nice
@@ -60,5 +60,12 @@ module Decidim
     def process_gallery?
       gallery_allowed? && @form.add_photos.any?
     end
+
+    def gallery_attached_to
+      return @attached_to if @attached_to.present?
+      return form.current_organization if form.respond_to?(:current_organization)
+
+      form.current_component.organization if form.respond_to?(:current_component)
+    end
   end
 end

data/app/commands/decidim/messaging/reply_to_conversation.rb

@@ -28,7 +28,7 @@ module Decidim
 
           broadcast(:ok, message)
         else
-          broadcast(:invalid)
+          broadcast(:invalid, message.errors.full_messages)
         end
       end
 

data/app/commands/decidim/multiple_attachments_methods.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module Decidim
+  module MultipleAttachmentsMethods
+    private
+
+    def build_attachments
+      @documents = []
+      @form.add_documents.each do |file|
+        @documents << Attachment.new(
+          title: { I18n.locale => file.original_filename },
+          attached_to: @attached_to || documents_attached_to,
+          file: file
+        )
+      end
+    end
+
+    def attachments_invalid?
+      @documents.each do |file|
+        if file.invalid? && file.errors.has_key?(:file)
+          @form.errors.add(:add_documents, file.errors[:file])
+          return true
+        end
+      end
+      false
+    end
+
+    def create_attachments
+      @documents.map! do |file|
+        file.attached_to = documents_attached_to
+        file.save!
+        @form.documents << file.id.to_s
+      end
+    end
+
+    def document_cleanup!
+      documents_attached_to.documents.each do |file|
+        file.destroy! if @form.documents.exclude? file.id.to_s
+      end
+
+      documents_attached_to.reload
+      documents_attached_to.instance_variable_set(:@documents, nil)
+    end
+
+    def process_attachments?
+      @form.add_documents.any?
+    end
+
+    def documents_attached_to
+      return @attached_to if @attached_to.present?
+      return form.current_organization if form.respond_to?(:current_organization)
+
+      form.current_component.organization if form.respond_to?(:current_component)
+    end
+  end
+end

data/app/controllers/concerns/decidim/devise_controllers.rb

@@ -18,6 +18,7 @@ module Decidim
       include ImpersonateUsers
       include NeedsPermission
       include Decidim::SafeRedirect
+      include NeedsSnippets
 
       helper Decidim::TranslationsHelper
       helper Decidim::MetaTagsHelper