decidim-admin 0.31.6 → 0.32.0.rc1

data/app/controllers/decidim/admin/share_tokens_controller.rb

@@ -31,7 +31,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("share_tokens.create.invalid", scope: "decidim.admin")
-            render action: "new", status: :unprocessable_entity
+            render action: "new", status: :unprocessable_content
           end
         end
       end
@@ -53,7 +53,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("share_tokens.update.error", scope: "decidim.admin")
-            render :edit, status: :unprocessable_entity
+            render :edit, status: :unprocessable_content
           end
         end
       end

data/app/controllers/decidim/admin/space_publications_controller.rb

@@ -17,7 +17,7 @@ module Decidim
             flash.now[:alert] = I18n.t("create.error", scope: i18n_scope)
           end
 
-          redirect_back(fallback_location:)
+          redirect_back_or_to(fallback_location)
         end
       end
 
@@ -33,7 +33,7 @@ module Decidim
             flash.now[:alert] = I18n.t("destroy.error", scope: i18n_scope)
           end
 
-          redirect_back(fallback_location:)
+          redirect_back_or_to(fallback_location)
         end
       end
 

data/app/controllers/decidim/admin/static_page_topics_controller.rb

@@ -30,7 +30,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("static_page_topics.create.error", scope: "decidim.admin")
-            render :new, status: :unprocessable_entity
+            render :new, status: :unprocessable_content
           end
         end
       end
@@ -52,7 +52,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("static_page_topics.update.error", scope: "decidim.admin")
-            render :edit, status: :unprocessable_entity
+            render :edit, status: :unprocessable_content
           end
         end
       end

data/app/controllers/decidim/admin/static_pages_controller.rb

@@ -62,7 +62,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("static_pages.create.error", scope: "decidim.admin")
-            render :new, status: :unprocessable_entity
+            render :new, status: :unprocessable_content
           end
         end
       end
@@ -85,7 +85,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("static_pages.update.error", scope: "decidim.admin")
-            render :edit, status: :unprocessable_entity
+            render :edit, status: :unprocessable_content
           end
         end
       end

data/app/controllers/decidim/admin/taxonomies_controller.rb

@@ -39,7 +39,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("create.invalid", scope: "decidim.admin.taxonomies")
-            render action: "new", status: :unprocessable_entity
+            render action: "new", status: :unprocessable_content
           end
         end
       end
@@ -66,7 +66,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("update.invalid", scope: "decidim.admin.taxonomies")
-            render action: "edit", status: :unprocessable_entity
+            render action: "edit", status: :unprocessable_content
           end
         end
       end
@@ -83,7 +83,7 @@ module Decidim
             flash.now[:alert] = I18n.t("destroy.invalid", scope: "decidim.admin.taxonomies")
           end
         end
-        redirect_back(fallback_location: taxonomies_path)
+        redirect_back_or_to(taxonomies_path)
       end
 
       def reorder

data/app/controllers/decidim/admin/taxonomy_filters_controller.rb

@@ -41,7 +41,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("create.error", scope: "decidim.admin.taxonomy_filters")
-            render :new, status: :unprocessable_entity
+            render :new, status: :unprocessable_content
           end
         end
       end
@@ -63,7 +63,7 @@ module Decidim
           end
           on(:invalid) do
             flash.now[:alert] = I18n.t("update.error", scope: "decidim.admin.taxonomy_filters")
-            render :edit, status: :unprocessable_entity
+            render :edit, status: :unprocessable_content
           end
         end
       end
@@ -78,7 +78,7 @@ module Decidim
             flash[:alert] = I18n.t("destroy.error", scope: "decidim.admin.taxonomy_filters")
           end
         end
-        redirect_back(fallback_location: decidim_admin.taxonomy_filters_path(root_taxonomy))
+        redirect_back_or_to(decidim_admin.taxonomy_filters_path(root_taxonomy))
       end
 
       private

data/app/controllers/decidim/admin/taxonomy_items_controller.rb

@@ -9,7 +9,7 @@ module Decidim
       before_action do
         if taxonomy_item && taxonomy_item.parent_ids.exclude?(taxonomy.id)
           flash[:alert] = I18n.t("update.invalid", scope: "decidim.admin.taxonomies")
-          render plain: I18n.t("update.invalid", scope: "decidim.admin.taxonomies"), status: :unprocessable_entity
+          render plain: I18n.t("update.invalid", scope: "decidim.admin.taxonomies"), status: :unprocessable_content
         end
       end
 
@@ -29,7 +29,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("create.invalid", scope: "decidim.admin.taxonomies")
-            render action: "new", status: :unprocessable_entity
+            render action: "new", status: :unprocessable_content
           end
         end
       end
@@ -50,7 +50,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("update.invalid", scope: "decidim.admin.taxonomies")
-            render action: "edit", status: :unprocessable_entity
+            render action: "edit", status: :unprocessable_content
           end
         end
       end

data/app/controllers/decidim/admin/users_controller.rb

@@ -38,7 +38,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = I18n.t("users.create.error", scope: "decidim.admin")
-            render :new, status: :unprocessable_entity
+            render :new, status: :unprocessable_content
           end
         end
       end

data/app/forms/decidim/admin/content_block_form.rb

@@ -12,12 +12,39 @@ module Decidim
       attribute :settings, Object
       attribute :images, Hash
 
+      validate :validate_settings
+
       def map_model(model)
         self.images = model.images_container
       end
 
       def settings?
-        settings.manifest.settings.any?
+        return false unless settings.respond_to?(:manifest)
+
+        settings.manifest.attributes.any?
+      end
+
+      private
+
+      def validate_settings
+        coerce_settings if settings.respond_to?(:to_h) && !settings.respond_to?(:valid?)
+
+        return unless settings.respond_to?(:valid?)
+        return if settings.valid?
+
+        settings.errors.each do |error|
+          errors.add(:settings, error.message)
+        end
+      end
+
+      def coerce_settings
+        content_block = context[:content_block]
+        return unless content_block
+
+        self.settings = content_block.manifest.settings.schema.new(
+          settings.to_h,
+          content_block.organization.default_locale
+        )
       end
     end
   end

data/app/forms/decidim/admin/organization_form.rb

@@ -20,7 +20,6 @@ module Decidim
       attribute :rich_text_editor_in_public_views, Boolean
       attribute :enable_machine_translations, Boolean
       attribute :machine_translation_display_priority, String
-      attribute :enable_participatory_space_filters, Boolean
 
       attribute :twitter_handler, String
       attribute :facebook_handler, String

data/app/forms/decidim/admin/participatory_space/member_csv_import_form.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require "csv"
+
+module Decidim
+  module Admin
+    module ParticipatorySpace
+      # A form object used to upload CSV to batch members.
+      #
+      class MemberCsvImportForm < Form
+        include Decidim::HasUploadValidations
+        include Decidim::Admin::CustomImport
+
+        attribute :file, Decidim::Attributes::Blob
+        attribute :user_name, String
+        attribute :email, String
+
+        validates :file, presence: true, file_content_type: { allow: ["text/csv"] }
+        validate :validate_csv
+
+        def validate_csv
+          return if file.blank?
+
+          process_import_file(file) do |(_email, user_name)|
+            errors.add(:user_name, :invalid) if user_name.blank? || !user_name.match?(UserBaseEntity::REGEXP_NAME)
+          end
+        rescue CSV::MalformedCSVError
+          errors.add(:file, :malformed)
+        end
+      end
+    end
+  end
+end

data/app/forms/decidim/admin/participatory_space/member_form.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    module ParticipatorySpace
+      # A form object used to create members from the
+      # admin dashboard.
+      #
+      class MemberForm < Form
+        include TranslatableAttributes
+
+        mimic :member
+
+        attribute :name, String
+        attribute :email, String
+        attribute :published, Boolean
+
+        translatable_attribute :role, String
+
+        validates :name, :email, presence: true
+
+        validates :name, format: { with: UserBaseEntity::REGEXP_NAME }
+      end
+    end
+  end
+end

data/app/forms/decidim/admin/participatory_space_admin_user_form.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module Admin
-    class ParticipatorySpaceAdminUserForm < ParticipatorySpacePrivateUserForm
+    class ParticipatorySpaceAdminUserForm < Decidim::Admin::ParticipatorySpace::MemberForm
       attribute :role, String
 
       validates :role, presence: true

data/app/forms/decidim/admin/selective_newsletter_form.rb

@@ -12,13 +12,13 @@ module Decidim
       attribute :send_to_verified_users, Boolean
       attribute :send_to_participants, Boolean
       attribute :send_to_followers, Boolean
-      attribute :send_to_private_members, Boolean
+      attribute :send_to_members, Boolean
 
       validates :send_to_all_users, presence: true, unless: :other_groups_selected_for_all_users?
       validates :send_to_verified_users, presence: true, unless: :other_groups_selected_for_verified_users?
       validates :send_to_followers, presence: true, if: :only_followers_selected?
       validates :send_to_participants, presence: true, if: :only_participants_selected?
-      validates :send_to_private_members, presence: true, if: :only_private_members_selected?
+      validates :send_to_members, presence: true, if: :only_members_selected?
 
       validate :at_least_one_participatory_space_selected
 
@@ -49,31 +49,31 @@ module Decidim
         send_to_verified_users.present? ||
           send_to_participants.present? ||
           send_to_followers.present? ||
-          send_to_private_members.present?
+          send_to_members.present?
       end
 
       def other_groups_selected_for_verified_users?
         send_to_all_users.present? ||
           send_to_participants.present? ||
           send_to_followers.present? ||
-          send_to_private_members.present?
+          send_to_members.present?
       end
 
       def only_followers_selected?
         send_to_all_users.blank? &&
           send_to_participants.blank? &&
-          send_to_private_members.blank? &&
+          send_to_members.blank? &&
           send_to_verified_users.blank?
       end
 
       def only_participants_selected?
         send_to_all_users.blank? &&
           send_to_followers.blank? &&
-          send_to_private_members.blank? &&
+          send_to_members.blank? &&
           send_to_verified_users.blank?
       end
 
-      def only_private_members_selected?
+      def only_members_selected?
         send_to_all_users.blank? &&
           send_to_followers.blank? &&
           send_to_participants.blank? &&

data/app/forms/decidim/admin/taxonomy_filter_form.rb

@@ -5,6 +5,7 @@ module Decidim
     # A form object to create or update areas.
     class TaxonomyFilterForm < Form
       include TranslatableAttributes
+
       Item = Struct.new(:name, :value, :children)
       Manifest = Struct.new(:id, :name)
 
@@ -43,7 +44,7 @@ module Decidim
       def items_collection
         return [] unless root_taxonomy
 
-        @items_collection ||= build_items_collection
+        @items_collection ||= map_items_collection(root_taxonomy)
       end
 
       def root_taxonomy
@@ -61,24 +62,22 @@ module Decidim
 
       private
 
-      def build_items_collection
-        children_by_parent_id = root_taxonomy.all_children.group_by(&:parent_id)
-        build_subtree(root_taxonomy.id, children_by_parent_id)
-      end
-
-      def build_subtree(parent_id, children_by_parent_id)
-        Array(children_by_parent_id[parent_id]).map do |item|
+      def map_items_collection(taxonomy)
+        taxonomy.children.map do |item|
           Item.new(
             name: translated_attribute(item.name),
             value: item.id,
-            children: build_subtree(item.id, children_by_parent_id)
+            children: map_items_collection(item)
           )
         end
       end
 
       def valid_taxonomy_items
-        valid_ids = root_taxonomy ? root_taxonomy.all_children.pluck(:id).to_set : Set.new
-        return if taxonomy_items.all? { |item| valid_ids.include?(item.to_i) }
+        return if taxonomy_items.all? do |item|
+          next unless root_taxonomy
+
+          root_taxonomy.all_children.map(&:id).include?(item.to_i)
+        end
 
         errors.add(:taxonomy_items, :invalid)
       end

data/app/helpers/decidim/admin/newsletters_helper.rb

@@ -23,10 +23,13 @@ module Decidim
         return if spaces_user_can_admin[space_type.manifest_name.to_sym].blank?
 
         html = ""
-        form_object.fields_for "participatory_space_types[#{space_type.manifest_name}]", space_type do |ff|
-          html += participatory_space_title(space_type)
-          html += ff.hidden_field :manifest_name, value: space_type.manifest_name
-          html += select_tag_participatory_spaces(space_type.manifest_name, spaces_for_select(space_type.manifest_name.to_sym), ff)
+
+        form_object.fields_for :participatory_space_types do |f|
+          f.fields_for space_type.manifest_name, space_type do |ff|
+            html += participatory_space_title(space_type)
+            html += ff.hidden_field :manifest_name, value: space_type.manifest_name
+            html += select_tag_participatory_spaces(space_type.manifest_name, spaces_for_select(space_type.manifest_name.to_sym), ff)
+          end
         end
         html.html_safe
       end
@@ -80,7 +83,7 @@ module Decidim
           recipients << content_tag(:strong, t("index.verified_users", scope: "decidim.admin.newsletters")) if newsletter.sent_to_verified_users?
           recipients << content_tag(:strong, t("index.followers", scope: "decidim.admin.newsletters")) if newsletter.sent_to_followers?
           recipients << content_tag(:strong, t("index.participants", scope: "decidim.admin.newsletters")) if newsletter.sent_to_participants?
-          recipients << content_tag(:strong, t("index.private_members", scope: "decidim.admin.newsletters")) if newsletter.sent_to_private_members?
+          recipients << content_tag(:strong, t("index.members", scope: "decidim.admin.newsletters")) if newsletter.sent_to_members?
 
           concat recipients.join(t("index.and", scope: "decidim.admin.newsletters")).html_safe
         end

data/app/helpers/decidim/admin/search_form_helper.rb

@@ -11,9 +11,26 @@ module Decidim
       # as datetime pickers.
       def search_form_for(record, options = {}, &)
         options[:builder] ||= SearchFormBuilder
+        options[:url] = url_for(params.to_unsafe_h.except("locale", :locale).merge(locale: nil)) if options[:url].blank?
 
         super
       end
+
+      def sort_link(search_object, attribute, *args, &)
+        options = args.extract_options!
+        options = options.merge(params: sort_link_params)
+        args << options
+
+        super
+      end
+
+      private
+
+      def sort_link_params
+        request_params = params.to_unsafe_h.except("locale", :locale).merge(locale: nil)
+        request_params["q"] = request_params["q"].except("s", :s) if request_params["q"].is_a?(Hash)
+        request_params
+      end
     end
   end
 end

data/app/helpers/decidim/admin/settings_helper.rb

@@ -161,6 +161,7 @@ module Decidim
       #
       # @param attribute [Decidim::SettingsManifest::Attribute]
       # @return [Symbol] The FormBuilder's method used to render
+      # @param [Object] options
       def form_method_for_attribute(attribute, options)
         return :editor if attribute.type.to_sym == :text && options[:editor]
 
@@ -225,6 +226,7 @@ module Decidim
       #
       # @param name (see #settings_attribute_input)
       # @param i18n_scope (see #settings_attribute_input)
+      # @param [Object] form
       def taxonomy_filters(form, name, i18n_scope)
         return disabled_taxonomy_filters(name, i18n_scope) if @component&.new_record?
 

data/app/jobs/decidim/admin/newsletter_job.rb

@@ -6,7 +6,7 @@ module Decidim
     #
     class NewsletterJob < ApplicationJob
       queue_as :newsletter
-      self.enqueue_after_transaction_commit = :never
+      self.enqueue_after_transaction_commit = false
 
       def perform(newsletter, form, recipients_ids)
         @newsletter = newsletter
@@ -37,7 +37,7 @@ module Decidim
           send_to_verified_users: @form["send_to_verified_users"],
           send_to_followers: @form["send_to_followers"],
           send_to_participants: @form["send_to_participants"],
-          send_to_private_members: @form["send_to_private_members"],
+          send_to_members: @form["send_to_members"],
           participatory_space_types: @form["participatory_space_types"],
           verification_types: @form["verification_types"]
         }

data/app/jobs/decidim/admin/participatory_space/destroy_members_follows_job.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    module ParticipatorySpace
+      class DestroyMembersFollowsJob < ApplicationJob
+        queue_as :default
+
+        def perform(decidim_user_id, space)
+          return unless space.respond_to?(:restricted?) && space.restricted?
+          return if space.respond_to?(:transparent?) && space.transparent?
+
+          user = Decidim::User.find_by(id: decidim_user_id)
+
+          return if user.blank?
+
+          return if space.respond_to?(:can_participate?) && space.can_participate?(user)
+
+          follows = Decidim::Follow.where(user:)
+          follows.where(followable: space).destroy_all
+
+          destroy_children_follows(follows, space)
+        end
+
+        def destroy_children_follows(follows, space)
+          follows.map do |follow|
+            object = follow.followable.presence
+            next unless object.respond_to?(:decidim_component_id)
+
+            follow.destroy if space.component_ids.include?(object.decidim_component_id)
+          end
+        end
+      end
+    end
+  end
+end

data/app/jobs/decidim/admin/participatory_space/import_member_csv_job.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    module ParticipatorySpace
+      # Custom ApplicationJob scoped to the admin panel.
+      #
+      class ImportMemberCsvJob < ApplicationJob
+        queue_as :exports
+
+        def perform(email, user_name, participatory_space, current_user)
+          return if email.blank? || user_name.blank?
+
+          params = {
+            name: user_name,
+            email: email.downcase.strip
+          }
+          member_form = MemberForm.from_params(params, participatory_space:)
+                                  .with_context(
+                                    current_user:,
+                                    current_participatory_space: participatory_space
+                                  )
+
+          CreateMember.call(member_form, participatory_space, via_csv: true)
+        end
+      end
+    end
+  end
+end

data/app/packs/src/decidim/admin/admin_autocomplete.js

@@ -10,6 +10,7 @@ import AutoComplete from "src/decidim/refactor/moved/autocomplete";
  * - name: assembly_member[user_id],
  * - options: [],
  * - placeholder: "Select a participant",
+ * - searchURL: "http://..."
  * - selected: "",
  *
  * @param {HTMLElement} el The element to generate the autocomplete for.
@@ -17,6 +18,7 @@ import AutoComplete from "src/decidim/refactor/moved/autocomplete";
  */
 const autoConfigure = (el) => {
   const config = JSON.parse(el.dataset.autocomplete);
+  const searchUrl = new URL(config.searchURL);
   const textInput = document.createElement("input");
   textInput.type = "text";
   textInput.className = "autocomplete-input";
@@ -44,24 +46,16 @@ const autoConfigure = (el) => {
     }
   }
 
-  const graphqlEscapedQuery = (query) => query.replace(/\\/g, "\\\\").replace(/"/g, "\\\"");
-
   const dataSource = (query, callback) => {
-    const apiPath = window.Decidim.config.get("api_path");
-    fetch(apiPath, {
-      method: "POST",
-      headers: { "Content-Type": "application/json" },
-      body: JSON.stringify({
-        query: `{users(filter:{wildcard:"${graphqlEscapedQuery(query)}"}){id,nickname,name,__typename}}`
-      })
+    const params = new URLSearchParams({
+      ...Object.fromEntries(searchUrl.searchParams),
+      term: query
+    });
+    fetch(`${searchUrl.origin}${searchUrl.pathname}?${params.toString()}`, {
+      method: "GET",
+      headers: { "Content-Type": "application/json" }
     }).then((response) => response.json()).then((data) => {
-      const users = data?.data?.users || [];
-      callback(users.map((user) => ({
-        value: user.id,
-        label: `${user.name} (${user.nickname})`
-      })))
-    }).catch(() => {
-      callback([])
+      callback(data)
     });
   };
 

data/app/packs/src/decidim/admin/controllers/access_mode/access_mode.test.js

@@ -0,0 +1,68 @@
+/* global jest */
+
+import { Application } from "@hotwired/stimulus"
+import AccessModeController from "src/decidim/admin/controllers/access_mode/controller"
+
+describe("AccessModeController", () => {
+  let application = null
+  let controller = null
+  let element = null
+  let checkbox = null
+  let accessModeFieldset = null
+
+  beforeEach(async () => {
+    document.body.innerHTML = `
+      <div data-controller="access-mode">
+        <div id="has_members">
+          <input type="hidden" name="has_members" value="0">
+          <input type="checkbox" id="has_members_checkbox" name="has_members" value="1">
+        </div>
+        <fieldset id="access_mode">
+          <legend>Access mode</legend>
+          <label>Open<input type="radio" name="access_mode" value="open"></label>
+        </fieldset>
+      </div>
+    `
+
+    application = Application.start()
+    application.register("access-mode", AccessModeController)
+
+    element = document.querySelector("[data-controller='access-mode']")
+    checkbox = element.querySelector("#has_members input[type='checkbox']")
+    accessModeFieldset = element.querySelector("#access_mode")
+
+    await new Promise((resolve) => {
+      setTimeout(() => {
+        controller = application.getControllerForElementAndIdentifier(element, "access-mode")
+        resolve()
+      }, 0)
+    })
+  })
+
+  afterEach(() => {
+    controller.disconnect()
+    application.stop()
+    document.body.innerHTML = ""
+  })
+
+  it("hides the access_mode fieldset when members checkbox is unchecked", () => {
+    expect(accessModeFieldset.hidden).toBe(true)
+    expect(accessModeFieldset.style.display).toBe("none")
+  })
+
+  it("shows the fieldset when the members checkbox becomes checked", () => {
+    checkbox.checked = true
+    checkbox.dispatchEvent(new Event("change"))
+
+    expect(accessModeFieldset.hidden).toBe(false)
+    expect(accessModeFieldset.style.display).toBe("")
+  })
+
+  it("removes the event listener on disconnect", () => {
+    const removeSpy = jest.spyOn(checkbox, "removeEventListener")
+
+    controller.disconnect()
+
+    expect(removeSpy).toHaveBeenCalledWith("change", controller.toggleAccessMode)
+  })
+})