dcm_dict 0.1.0

data/spec/dcm_dict/dictionary/uid_record_spec.rb

@@ -0,0 +1,53 @@
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe DcmDict::Dictionary::UidRecord do
+  [
+    { uid_value: '1.2.840.10008.1.2',
+      uid_name: "Implicit VR Little Endian: Default Transfer Syntax for DICOM",
+      uid_type: :transfer_syntax }
+  ].each do |data|
+    it "Handle Data Element Data correctly" do
+      ur = DcmDict::Dictionary::UidRecord.new(data.dup)
+      expect(ur.uid_value).to eq(data[:uid_value])
+      expect(ur.uid).to eq(data[:uid_value])
+      expect(ur.uid_name).to eq(data[:uid_name])
+      expect(ur.uid_type).to eq(data[:uid_type])
+    end
+
+
+    include_examples "Record handle methods correctly",
+                     DcmDict::Dictionary::UidRecord.new(data),
+                     data
+
+    it "data should be not modifiable" do
+      uid = DcmDict::Dictionary::UidRecord.new(data.dup)
+      old_value = uid.uid_value.dup
+      expect{uid.uid_value << 'aaa'}.to raise_error
+      expect(uid.uid_value).to eq(old_value)
+    end
+
+  end
+end

data/spec/dcm_dict/encoder/data_to_code_spec.rb

@@ -0,0 +1,109 @@
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+require 'xml_sample_spec_helper'
+
+describe DcmDict::Encoder::DataToCode do
+  describe "should print out data element with" do
+    it "data elements header code" do
+      header = DcmDict::Encoder::DataToCode.data_element_header
+      expected_header = <<END
+module DcmDict
+  module SourceData
+    DataElementsData = [
+END
+      expect(header).to eq(expected_header)
+    end
+
+    it "data elements footer code" do
+      footer = DcmDict::Encoder::DataToCode.data_element_footer
+      expected_footer=<<END
+    ]
+  end
+end
+END
+      expect(footer).to eq(expected_footer)
+    end
+
+    describe "data element data field" do
+      using DcmDict::Refine::Internal::ArrayRefineInternal
+
+      XmlSampleSpecHelper.xml_tag_single_set.each do |xml_string, data|
+        it "for data element sample as #{data[:tag_ps].inspect}" do
+          indent = 4
+          tag_ary_str = "[0x#{data[:tag_ary].tag_group_str},0x#{data[:tag_ary].tag_element_str}]"
+          src_text = "#{' '*indent}{ tag_ps: '#{data[:tag_ps]}', tag_name: \"#{data[:tag_name]}\", tag_key: '#{data[:tag_key]}', tag_vr: #{data[:tag_vr]}, tag_vm: #{data[:tag_vm]}, tag_str: '#{data[:tag_str]}', tag_sym: #{data[:tag_sym].inspect}, tag_ndm: '#{data[:tag_ndm]}', tag_ary: #{tag_ary_str}, tag_multiple: #{data[:tag_multiple].inspect}, tag_note: '#{data[:tag_note]}'},"
+          src_line = DcmDict::Encoder::DataToCode.data_element_data_to_code(data)
+          expect(src_line).to eq(src_text)
+          src_line = DcmDict::Encoder::DataToCode.data_element_data_to_code(data, indent)
+          expect(src_line).to eq(src_text)
+          indent = 6
+          src_line = DcmDict::Encoder::DataToCode.data_element_data_to_code(data, indent)
+          expect(src_line.start_with?("#{' '*indent}{")).to be true
+        end
+      end
+
+    end
+  end
+
+   describe "should print out uid with" do
+    it "uid header code" do
+      header = DcmDict::Encoder::DataToCode.uid_header
+      expected_header = <<END
+module DcmDict
+  module SourceData
+    UidValuesData = [
+END
+      expect(header).to eq(expected_header)
+    end
+
+    it "uid footer code" do
+      footer = DcmDict::Encoder::DataToCode.uid_footer
+      expected_footer=<<END
+    ]
+  end
+end
+END
+      expect(footer).to eq(expected_footer)
+    end
+
+    describe "uid data field" do
+      XmlSampleSpecHelper.xml_uid_set.each do |xml_string, data|
+      it "for uid sample as #{data[:uid_value].inspect}" do
+        indent = 4
+        src_text = "#{' '*indent}{ uid_value: '#{data[:uid_value]}', uid_name: \"#{data[:uid_name]}\", uid_type: #{data[:uid_type].inspect}},"
+        src_line = DcmDict::Encoder::DataToCode.uid_data_to_code(data)
+        expect(src_line).to eq(src_text)
+        src_line = DcmDict::Encoder::DataToCode.uid_data_to_code(data, indent)
+        expect(src_line).to eq(src_text)
+        indent = 6
+        src_line = DcmDict::Encoder::DataToCode.uid_data_to_code(data, indent)
+        expect(src_line.start_with?("#{' '*indent}{")).to be true
+      end
+      end
+    end
+
+  end
+
+end

data/spec/dcm_dict/ext/object_extension_spec.rb

@@ -0,0 +1,53 @@
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Object extension" do
+
+  describe "should check object for nil or empty status" do
+    describe "for class with empty? method" do
+      it "as string object" do
+        expect("bla bla".nil_or_empty?).to be_falsy
+        expect("".nil_or_empty?).to be_truthy
+      end
+
+      it "as array object" do
+        expect([1, 2].nil_or_empty?).to be_falsy
+        expect([].nil_or_empty?).to be_truthy
+      end
+
+    end
+
+    describe "for class without empty? method" do
+      it "as fixnum object" do
+        expect(5.nil_or_empty?).to be_falsy
+      end
+
+      it "as nil object" do
+        expect(nil.nil_or_empty?).to be_truthy
+      end
+    end
+
+  end
+end

data/spec/dcm_dict/refine/array_refine_spec.rb

@@ -0,0 +1,61 @@
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Array refinement" do
+  using DcmDict::Refine::ArrayRefine
+
+  describe "should permit access to single data element dictionary information" do
+
+    include_examples "refinement for standard tag",
+                     [[0x0010,0x1005], [0x0028,0x1200], [0x0014,0x3050]],
+                     Proc.new{|tag| tag}
+
+
+    multi_data = { [0x6046,0x0040] => {
+                     tag_name: "Overlay Type",
+                     tag_multiple: true,
+                     tag_name: "Overlay Type",
+                     tag_keyword: "OverlayType",
+                     tag_key: "OverlayType",
+                     tag_vr: [:CS], tag_vm: ["1"],
+                     tag: [0x6046, 0x0040], tag_ary: [0x6046, 0x0040],
+                     tag_ps: "(60XX,0040)",
+                     tag_sym: :overlay_type,
+                     tag_ndm: "60460040",
+                     tag_str: "(6046,0040)",
+                     tag_group: 0x6046,
+                     tag_element: 0x0040 } }
+
+    include_examples "refinement for multiple tag",
+                     multi_data,
+                     Proc.new {|tag| tag}
+
+  end
+
+  include_examples "Raise exception for wrong input",
+                   [ [0,1,2,3], [-0x0010,-0x0010], [0x1ffff,0x0010], [0x1ffff,0x10010], [0x0010, 0x1ffff]],
+                   [],
+                   Proc.new {|tag| tag}
+end

data/spec/dcm_dict/refine/internal/array_refine_internal_spec.rb

@@ -0,0 +1,98 @@
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Array Refinement" do
+
+  using DcmDict::Refine::Internal::ArrayRefineInternal
+  it "should implement tag_ary metod" do
+    expect([0x0010,0x0020].to_tag_ary).to eq([0x0010,0x0020])
+  end
+
+  describe "should extract group and element from 'array tag'" do
+    it "for correct object" do
+      expect([0x0010,0x0020].tag_group_num).to eq(0x0010)
+      expect([0x0010,0x0020].tag_element_num).to eq(0x0020)
+    end
+
+    describe "and for wrong array must be raise error" do
+      [
+        [0x0010],
+        [0x0010,0x0020,0x0030],
+        ['0010', '0020'],
+        [16.0, 0x0020],
+        [0x1ffff,0x10000],
+        [-1,-2]
+      ].each do |tag|
+        it "as #{tag.inspect}" do
+          expect{ tag.tag_group_num }.to raise_error
+          expect{ tag.tag_element_num }.to raise_error
+
+        end
+      end
+    end
+
+  end
+
+  describe "should convert group and element to hex string" do
+    {
+      [0xfffe,0xe0dd] => {group: 'FFFE', element: 'E0DD', tag_str: '(FFFE,E0DD)', tag_ndm: 'FFFEE0DD'},
+      [0x0010,0x0020] => {group: '0010', element: '0020', tag_str: '(0010,0020)', tag_ndm: '00100020'}
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.tag_group_str).to eq(value[:group])
+        expect(tag.tag_element_str).to eq(value[:element])
+        expect(tag.to_tag_str).to eq(value[:tag_str])
+        expect(tag.to_tag_ndm).to eq(value[:tag_ndm])
+      end
+    end
+  end
+
+  describe "should check for group-length tag" do
+    {
+      [0x0010, 0x0020] => false,
+      [0x0010, 0x0000] => true,
+      [0x0000, 0x0002] => false,
+      [0x0000, 0x0000] => true
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.group_length_tag?).to eq(value)
+      end
+    end
+  end
+
+  describe "should check for private-creator tag" do
+    {
+      [0x0010, 0x0010] => false,
+      [0x0011, 0x0010] => true,
+      [0x0011, 0x0110] => false,
+      [0x0028, 0x2468] => false
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.private_creator_tag?).to eq(value)
+      end
+    end
+  end
+
+end

data/spec/dcm_dict/refine/internal/hash_refine_internal_spec.rb

@@ -0,0 +1,64 @@
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Hash internal refinement" do
+  using DcmDict::Refine::Internal::HashRefineInternal
+
+  it "should check for lowercase tag_ps field" do
+    h = {tag_ps: '(fffe,E000)'}
+    h.check_tag_ps!
+    expect(h).to eq({tag_ps: '(FFFE,E000)'})
+  end
+
+  it "should check for missing tag_ps field" do
+    expect{ {tag_ps: ''}.check_tag_ps! }.to raise_error("Missing tag_ps field")
+    expect{ {}.check_tag_ps! }.to raise_error("Missing tag_ps field")
+  end
+
+  context "Placeholders data: no Name or Keyword or VR or VM is specified" do
+    {
+      { tag_ps: '(0018,9445)', tag_name: '', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_name: '', tag_key: '', tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_name: '', tag_key: '', tag_vr: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_name: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+    }.each do |src_data, expected_data|
+      it "should check for placeholder data (#{src_data[:tag_ps].inspect} with keys #{src_data.keys.inspect})" do
+        src_data.check_placeholder_data!
+        expect(src_data).to eq(expected_data)
+      end
+    end
+
+    [
+      { tag_ps: '', tag_name: '', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' },
+      { tag_name: '', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' }
+    ].each do |data|
+      it "should raise error if :tag_ps field is missing (tag_ps=#{data[:tag_ps].inspect})" do
+        expect{data.check_placeholder_data!}.to raise_error("Missing tag_ps field")
+      end
+    end
+
+  end
+end

data/spec/dcm_dict/refine/internal/string_refine_internal_spec.rb

@@ -0,0 +1,214 @@
+# coding: utf-8
+#
+#  Copyright (C) 2014  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "String refinement (internal)" do
+
+  using DcmDict::Refine::Internal::StringRefineInternal
+  describe "should remove unwanted space characters" do
+
+    [
+      ["FileSetDescriptorFileID ", "trailing spaces"],
+      ["  FileSetDescriptorFileID", "leading spaces"],
+      ["  FileSetDescriptorFileID  ", "leading and trailing spaces"],
+      ["File​Set​Descriptor​FileID", "zero width spaces"],
+      ["  File​Set​Descriptor​FileID  ", "leading, trailing and zero width spaces"]
+    ].each do |wrong_string, comment|
+      it "for string containing #{comment}" do
+        expect(wrong_string.dcm_unspace).to eq('FileSetDescriptorFileID')
+      end
+    end
+  end
+
+  describe "should convert keyword tag string to symbol object" do
+    [
+      ['DarkCurrentCounts', :dark_current_counts],
+      ['InstanceCreationDate', :instance_creation_date],
+      ['RecognitionCode', :recognition_code],
+      ['CoefficientsSDVN', :coefficients_sdvn],
+      ['OffsetOfReferencedLowerLevelDirectoryEntity', :offset_of_referenced_lower_level_directory_entity],
+      ['FileSetDescriptorFileID', :file_set_descriptor_file_id],
+      ['SOPClassUID', :sop_class_uid],
+      ['RelatedGeneralSOPClassUID', :related_general_sop_class_uid],
+      ['ReferencedSOPClassUIDInFile', :referenced_sop_class_uid_in_file],
+      ['MAUsedInGainCalibration', :ma_used_in_gain_calibration],
+      ['OtherPatientIDsSequence', :other_patient_ids_sequence],
+      ['RelativeXRayExposure', :relative_x_ray_exposure],
+      ['DisplayedZValue', :displayed_z_value],
+      ['PhysicalUnitsXDirection', :physical_units_x_direction],
+      ['XRay3DFrameTypeSequence', :x_ray_3d_frame_type_sequence],
+      ['SOPInstanceUIDOfConcatenationSource',  :sop_instance_uid_of_concatenation_source],
+      ['RowsForNthOrderCoefficients', :rows_for_nth_order_coefficients],
+      ['EquivalentCDADocumentSequence', :equivalent_cda_document_sequence],
+      ['ALineRate', :a_line_rate],
+      ['ThreeDPointCoordinates', :three_d_point_coordinates],
+      ['SourceImageIDs', :source_image_ids],
+      ['ModifyingDeviceID', :modifying_device_id],
+      ['TIDOffset', :tid_offset]
+    ].each do |str, value|
+      it "from #{str.inspect} to #{value.inspect}" do
+        expect(str.tag_key_to_sym).to eq(value)
+      end
+    end
+  end
+
+  describe "should convert standard string tag" do
+    [
+      ['(0014,3050)', '00143050', [0x0014,0x3050]],
+      ['(0008,0012)', '00080012', [0x0008,0x0012]],
+      ['(FFFE,E00D)', 'FFFEE00D', [0xfffe,0xe00d]]
+    ].each do |str, value_str, value_ary|
+      it "from #{str.inspect} to a numeric string tag as #{value_str.inspect}" do
+        expect(str.to_tag_ndm).to eq(value_str)
+      end
+
+      it "from #{str.inspect} to an array object as #{value_ary.inspect}" do
+        expect(str.to_tag_ary).to eq(value_ary)
+      end
+    end
+  end
+
+  {
+    '(0010,0020)'=> [0x0010,0x0020],
+    '00100020' => [0x0010,0x0020]
+
+  }.each do |src, expected_val|
+    it "should implement to_tag_ary metod" do
+      expect(src.to_tag_ary).to eq(expected_val)
+    end
+  end
+
+  {
+    '(0010,0020)'=> '(0010,0020)',
+    '00100020' => '(0010,0020)'
+
+  }.each do |src, expected_val|
+    it "should implement to_tag_str method" do
+      expect(src.to_tag_str).to eq(expected_val)
+    end
+  end
+
+  {
+    '(0010,0020)'=> [0x0010,0x0020],
+    '00100020' => [0x0010,0x0020]
+
+  }.each do |src, expected_val|
+    it "should implement tag_group_num and tag_element_num method" do
+      expect(src.tag_group_num).to eq(expected_val[0])
+      expect(src.tag_element_num).to eq(expected_val[1])
+    end
+  end
+
+  {
+    '(0010,0020)'=> ['0010','0020'],
+    '00100020' => ['0010','0020'],
+    '(FFFE,E000)'=> ['FFFE','E000'],
+
+  }.each do |src, expected_val|
+    it "should implement tag_group_str and tag_element_str method" do
+      expect(src.tag_group_str).to eq(expected_val[0])
+      expect(src.tag_element_str).to eq(expected_val[1])
+    end
+  end
+
+  [
+    '(0010,00208)',
+    'abracadabra',
+    Time.now.to_s,
+    '(1ffff,123)',
+    '(123,1fff0)'
+  ].each do |src|
+    it "should manage wrong value #{src.inspect}" do
+      expect{src.to_tag_str}.to raise_error
+      expect{src.to_tag_ndm}.to raise_error
+      expect{src.to_tag_ary}.to raise_error
+    end
+  end
+
+  {
+    'SOP Class' => :sop_class,
+    'Transfer Syntax' => :transfer_syntax,
+    'Well-known frame of reference' => :well_known_frame_of_reference,
+    'Well-known SOP Instance' => :well_known_sop_instance,
+    'DICOM UIDs as a Coding Scheme' => :dicom_uids_as_a_coding_scheme,
+    'Coding Scheme' => :coding_scheme,
+    'Query/Retrieve' => :query_retrieve,
+    'LDAP OID' => :ldap_oid
+
+
+  }.each do |src, expected_val|
+    it "should implement uid_type_to_sym method #{src.inspect} > #{expected_val.inspect}" do
+      expect(src.uid_type_to_sym).to eq(expected_val)
+    end
+  end
+
+  {
+    '1.2.3.4.5.6' => true,
+    'not uid string' => false,
+    '0.1.2.3.4' => true,
+    '1.2.3456.789.0.1.2.3' => true,
+    '1.2.3.4.5.6.7.8.9.0.1.2.3.4.5.6.7.8.9.0.1.2.3.4.5.6.7.8.9.0.1.2.3' => false,
+    '1,2.3' => false,
+    '1.2.3.04.5' => false
+  }.each do |string, expected_as_uid|
+    it "should check for UID string #{string.inspect} -> #{expected_as_uid}" do
+      expect(string.uid_value?).to eq(expected_as_uid)
+    end
+  end
+
+  describe "should check for group-length tag" do
+    {
+      "00100020" => false,
+      "(0010,0020)" => false,
+      "00100000" => true,
+      "(0010,0000)" => true,
+      "00000002" => false,
+      "(0000,0002)" => false,
+      "00000000" => true,
+      "(0000,0000)" => true
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.group_length_tag?).to eq(value)
+      end
+    end
+  end
+
+  describe "should check for private-creator tag" do
+    {
+      '00100010' => false,
+      '(0010,0010)' => false,
+      '00110010' => true,
+      '(0011,0010)' => true,
+      '00110110' => false,
+      '(0011,0110)' => false,
+      '00282468' => false,
+      '(0028,2468)' => false
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.private_creator_tag?).to eq(value)
+      end
+    end
+  end
+end