datacite-mapping 0.1.17.2 → 0.2.0

data/spec/data/datacite4/datacite-example-relationTypeIsIdenticalTo-v4.0.xml

@@ -0,0 +1,65 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://datacite.org/schema/kernel-4" xsi:schemaLocation="http://datacite.org/schema/kernel-4 http://schema.datacite.org/meta/kernel-4/metadata.xsd">
+  <identifier identifierType="DOI">10.5072/10.CPoS-example</identifier>
+  <creators>
+    <creator>
+      <creatorName>Kreyenfeld, Michaela</creatorName>
+      <givenName>Michaela</givenName>
+      <familyName>Kreyenfeld</familyName>
+      <nameIdentifier nameIdentifierScheme="ISNI" schemeURI="http://isni.org/isni/">0000000117540116</nameIdentifier>
+    </creator>
+    <creator>
+      <creatorName>Hornung, Anne</creatorName>
+      <givenName>Anne</givenName>
+      <familyName>Hornung</familyName>
+      <nameIdentifier nameIdentifierScheme="VIAF" schemeURI="http://viaf.org/viaf/">304639093</nameIdentifier>
+    </creator>
+    <creator>
+      <creatorName>Kubisch, Karolin</creatorName>
+      <givenName>Karolin</givenName>
+      <familyName>Kubisch</familyName>
+      <nameIdentifier nameIdentifierScheme="VIAF" schemeURI="http://viaf.org/viaf/">303937450</nameIdentifier>
+    </creator>
+  </creators>
+  <titles>
+    <title>The German Generations and Gender Survey</title>
+    <title xml:lang="en" titleType="Subtitle">Some Critical Reflections on the Validity of Fertility Histories</title>
+  </titles>
+  <publisher>Federal Institute for Population Research, Germany</publisher>
+  <publicationYear>2013</publicationYear>
+  <subjects>
+    <subject>Fertility</subject>
+    <subject>Marriage</subject>
+    <subject>Germany</subject>
+    <subject>Data validation</subject>
+    <subject>Mikrozensus</subject>
+    <subject>Gender survey</subject>
+    <subject schemeURI="http://www.gesis.org/en/services/research/tools-for-searching/classification" subjectScheme="GESIS">10300 Demography, Population Research</subject>
+  </subjects>
+  <contributors>
+    <contributor contributorType="Editor">
+      <contributorName>Federal Institute for Population Research</contributorName>
+      <nameIdentifier nameIdentifierScheme="ISNI" schemeURI="http://isni.org/isni/">0000000094455866</nameIdentifier>
+    </contributor>
+  </contributors>
+  <language>eng</language>
+  <resourceType resourceTypeGeneral="Text">Article</resourceType>
+  <alternateIdentifiers>
+    <alternateIdentifier alternateIdentifierType="internal ID">da|ra.14.103</alternateIdentifier>
+  </alternateIdentifiers>
+  <relatedIdentifiers>
+    <relatedIdentifier relatedIdentifierType="URN" relationType="IsIdenticalTo">urn:nbn:de:bib-cpos-2013-02en8</relatedIdentifier>
+    <relatedIdentifier relatedIdentifierType="DOI" relationType="IsIdenticalTo">10.4232/10.CPoS-2013-02en</relatedIdentifier>
+  </relatedIdentifiers>
+  <formats>
+    <format>PDF</format>
+  </formats>
+  <version>1</version>
+  <rightsList>
+    <rights rightsURI="http://creativecommons.org/licenses/by-nc-nd/3.0/deed">Creative Commons License: Attribution-NonCommercial-NoDerivs 3.0 Unported</rights>
+  </rightsList>
+  <descriptions>
+    <description descriptionType="SeriesInformation">Comparative Population Studies Vol 38, No 1 (2013)</description>
+    <description descriptionType="Abstract">This paper validates the fertility histories of the German Generations and Gender Survey (GGS). Focusing on the cohorts 1930-69 of West German women, the total number of children, the parity distribution and the parity progression ratios are comparedto external sources. One major result from this validation is that the German GGS understates the fertility for the older cohorts and overstates it for the younger ones.</description>
+  </descriptions>
+</resource>

data/spec/data/datacite4/datacite-example-video-v4.0.xml

@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://datacite.org/schema/kernel-4" xsi:schemaLocation="http://datacite.org/schema/kernel-4 http://schema.datacite.org/meta/kernel-4/metadata.xsd">
+  <identifier identifierType="DOI">10.5072/1153992</identifier>
+  <creators>
+    <creator>
+      <creatorName>Lynn, Briscoe</creatorName>
+      <givenName>Briscoe</givenName>
+      <familyName>Lynn</familyName>
+    </creator>
+  </creators>
+  <titles>
+    <title>Walking Your Space, Evaluating Your Home</title>
+    <title titleType="Subtitle">Making Energy Efficiency Work for You</title>
+  </titles>
+  <publisher>Photovoltaic Institute</publisher>
+  <publicationYear>2013</publicationYear>
+  <subjects>
+    <subject>Solar Energy</subject>
+  </subjects>
+  <language>eng</language>
+  <resourceType resourceTypeGeneral="Audiovisual">narrated video</resourceType>
+  <formats>
+    <format>MP4</format>
+  </formats>
+  <descriptions>
+    <description descriptionType="Abstract">
+      This hour-long video features John Halter as the narrator. Mr. Halter is best known as a journalist rather than a TV star, and here he plays that role as he does an "expose" type of walkthrough a new home. The home has been advertised as a house with
+      the very latest in state-of-the art energy efficiency, especially solar. Mr. Halter puts the home through an investigation and determines that it can, indeed, live up to its claims.
+    </description>
+  </descriptions>
+</resource>

data/spec/data/datacite4/datacite-example-workflow-v4.0.xml

@@ -0,0 +1,55 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://datacite.org/schema/kernel-4" xsi:schemaLocation="http://datacite.org/schema/kernel-4 http://schema.datacite.org/meta/kernel-4/metadata.xsd">
+  <identifier identifierType="DOI">10.5072/100044</identifier>
+  <creators>
+    <creator>
+      <creatorName>Luo, R</creatorName>
+    </creator>
+    <creator>
+      <creatorName>Liu, B</creatorName>
+    </creator>
+    <creator>
+      <creatorName>Xie, Y</creatorName>
+    </creator>
+    <creator>
+      <creatorName>Li, Z</creatorName>
+    </creator>
+  </creators>
+  <titles>
+    <title>
+      Software and supporting material for "SOAPdenovo2: An empirically improved memory-efficient short read de novo assembly"
+    </title>
+  </titles>
+  <publisher>GigaScience Database</publisher>
+  <publicationYear>2012</publicationYear>
+  <subjects>
+    <subject>DNA (Genetics)</subject>
+    <subject>Computer Program</subject>
+  </subjects>
+  <dates>
+    <date dateType="Available">2012-12-13</date>
+  </dates>
+  <language>eng</language>
+  <resourceType resourceTypeGeneral="Workflow">Software</resourceType>
+  <relatedIdentifiers>
+    <relatedIdentifier relatedIdentifierType="DOI" relationType="IsReferencedBy">10.5072/2047-217X-1-1</relatedIdentifier>
+    <relatedIdentifier relatedIdentifierType="DOI" relationType="Compiles">10.5072/100038</relatedIdentifier>
+  </relatedIdentifiers>
+  <sizes>
+    <size>31 MB</size>
+  </sizes>
+  <rightsList>
+    <rights rightsURI="http://creativecommons.org/publicdomain/zero/1.0/">CC0 1.0 Universal</rights>
+  </rightsList>
+  <descriptions>
+    <description descriptionType="Abstract">
+      SOAPdenovo2 is the latest de novo genome assembly package from BGI's SOAP (short oligonucleotide analysis package) suite of tools (homepage here: http://soap.genomics.org.cn/). Compared to SOAPdenovo1, this new version has the advantage of a new
+      algorithm design that reduces memory consumption in graph construction, resolves more repeat regions in contig assembly, increases coverage and length in scaffold construction, improves gap closure, and is optimized for large genomes. Using new
+      sequencing data from the YH (Homo sapiens) diploid genome - the first sequenced Han Chinese individual, an updated assembly was produced (see dataset here: doi:10.5524/100038), with the N50 scores for the contig and scaffold being 3-fold and 50-fold
+      longer, respectively, than the first published version. The genome coverage increased from 81.16% to 93.91%, and memory consumption was ~2/3 times lower during the point of largest memory consumption. Benchmarking with Assemblathon1 and GAGE datasets
+      shows that SOAPdenovo2 greatly surpasses its predecessor SOAPdenovo1 and is competitive to other assemblers on both assembly length and accuracy. In order to facilitate readers to repeat and recreate these findings, configured packages with the
+      compressed pipelines containing all of the necessary shell scripts and tools are available from the BGI FTP server (ftp://public.genomics.org.cn/BGI/SOAPdenovo2). The latest version of SOAPdenovo2 is available from Sourceforge:
+      http://soapdenovo2.sourceforge.net/ These pipelines will also soon be made available from our data platform as Galaxy workflows: http://galaxy.cbiit.cuhk.edu.hk/
+    </description>
+  </descriptions>
+</resource>

data/spec/rspec_custom_matchers.rb

@@ -28,7 +28,7 @@ RSpec::Matchers.define :be_xml do |expected|
   end
 
   match do |actual|
-    expected_xml = to_nokogiri(expected) || fail("expected value #{expected} does not appear to be XML")
+    expected_xml = to_nokogiri(expected) || fail("expected value #{expected || 'nil'} does not appear to be XML")
     actual_xml = to_nokogiri(actual)
 
     EquivalentXml.equivalent?(expected_xml, actual_xml, element_order: false, normalize_whitespace: true)
@@ -37,6 +37,10 @@ RSpec::Matchers.define :be_xml do |expected|
   failure_message do |actual|
     expected_string = to_pretty(to_nokogiri(expected))
     actual_string = to_pretty(to_nokogiri(actual)) || actual
+
+    File.open('tmp/actual.xml', 'w') { |f| f.write(actual_string) }
+    File.open('tmp/expected.xml', 'w') { |f| f.write(expected_string) }
+
     "expected XML:\n#{expected_string}\n\nbut was:\n#{actual_string}"
   end
 

data/spec/spec_helper.rb

@@ -26,6 +26,6 @@ end
 require 'rspec_custom_matchers'
 
 # ------------------------------------------------------------
-# Stash::Wrapper
+# Datacite::Mapping
 
 require 'datacite/mapping'

data/spec/unit/datacite/mapping/contributor_spec.rb

@@ -65,6 +65,13 @@ module Datacite
           expect { contrib.name = '' }.to raise_error(ArgumentError)
           expect(contrib.name).to eq('Hershlag, Natalie')
         end
+        it 'strips' do
+          contrib = Contributor.allocate
+          contrib.name = '
+            Hershlag, Natalie
+          '
+          expect(contrib.name).to eq('Hershlag, Natalie')
+        end
       end
 
       describe '#type=' do

data/spec/unit/datacite/mapping/creator_spec.rb

@@ -25,6 +25,16 @@ module Datacite
           creator = Creator.new(name: 'Hedy Lamarr')
           expect(creator.affiliations).to eq([])
         end
+
+        it 'sets the given and family names' do
+          creator = Creator.new(name: 'Hedy Lamarr', given_name: 'Hedy', family_name: 'Lamarr')
+          expect(creator.given_name).to eq('Hedy')
+          expect(creator.family_name).to eq('Lamarr')
+        end
+
+        it 'defaults to nil given and family names' do
+
+        end
       end
 
       describe '#name=' do
@@ -43,6 +53,43 @@ module Datacite
           expect { creator.name = '' }.to raise_error(ArgumentError)
           expect(creator.name).to eq('Hedy Lamarr')
         end
+        it 'strips' do
+          creator = Creator.allocate
+          creator.name = '
+            Hedy Lamarr
+          '
+          expect(creator.name).to eq('Hedy Lamarr')
+        end
+      end
+
+      describe '#given_name=' do
+        it 'sets the given_name' do
+          creator = Creator.allocate
+          creator.given_name = 'Hedy'
+          expect(creator.given_name).to eq('Hedy')
+        end
+        it 'strips' do
+          creator = Creator.allocate
+          creator.given_name = '
+            Hedy
+          '
+          expect(creator.given_name).to eq('Hedy')
+        end
+      end
+
+      describe '#family_name=' do
+        it 'sets the family_name' do
+          creator = Creator.allocate
+          creator.family_name = 'Lamarr'
+          expect(creator.family_name).to eq('Lamarr')
+        end
+        it 'strips' do
+          creator = Creator.allocate
+          creator.family_name = '
+            Lamarr
+          '
+          expect(creator.family_name).to eq('Lamarr')
+        end
       end
 
       describe '#identifier=' do
@@ -118,6 +165,51 @@ module Datacite
           expect(creator.save_to_xml).to be_xml(expected_xml)
         end
       end
+
+      describe 'DC4 family and given names' do
+        describe 'DC3 mapping' do
+          it 'doesn\'t write DC4 family and given names' do
+            id = NameIdentifier.new(scheme: 'ISNI', scheme_uri: URI('http://isni.org/'), value: '0000-0001-1690-159X')
+            creator = Creator.new(name: 'Hedy Lamarr', given_name: 'Hedy', family_name: 'Lamarr', identifier: id, affiliations: ['United Artists', 'Metro-Goldwyn-Mayer'])
+            expected_xml = '<creator>
+                              <creatorName>Hedy Lamarr</creatorName>
+                              <nameIdentifier schemeURI="http://isni.org/" nameIdentifierScheme="ISNI">0000-0001-1690-159X</nameIdentifier>
+                              <affiliation>United Artists</affiliation>
+                              <affiliation>Metro-Goldwyn-Mayer</affiliation>
+                            </creator>'
+            expect(creator.save_to_xml(mapping: :datacite_3)).to be_xml(expected_xml)
+          end
+        end
+
+        describe 'DC4 mapping' do
+          it 'reads DC4 family and given names' do
+            xml = '<creator>
+                     <creatorName>Hedy Lamarr</creatorName>
+                     <givenName>Hedy</givenName>
+                     <familyName>Lamarr</familyName>
+                     <nameIdentifier schemeURI="http://isni.org/" nameIdentifierScheme="ISNI">0000-0001-1690-159X</nameIdentifier>
+                     <affiliation>United Artists</affiliation>
+                     <affiliation>Metro-Goldwyn-Mayer</affiliation>
+                   </creator>'
+            creator = Creator.parse_xml(xml)
+            expect(creator.given_name).to eq('Hedy')
+            expect(creator.family_name).to eq('Lamarr')
+          end
+          it 'writes DC4 family and given names' do
+            expected_xml = '<creator>
+                              <creatorName>Hedy Lamarr</creatorName>
+                              <givenName>Hedy</givenName>
+                              <familyName>Lamarr</familyName>
+                              <nameIdentifier schemeURI="http://isni.org/" nameIdentifierScheme="ISNI">0000-0001-1690-159X</nameIdentifier>
+                              <affiliation>United Artists</affiliation>
+                              <affiliation>Metro-Goldwyn-Mayer</affiliation>
+                            </creator>'
+            id = NameIdentifier.new(scheme: 'ISNI', scheme_uri: URI('http://isni.org/'), value: '0000-0001-1690-159X')
+            creator = Creator.new(name: 'Hedy Lamarr', given_name: 'Hedy', family_name: 'Lamarr', identifier: id, affiliations: ['United Artists', 'Metro-Goldwyn-Mayer'])
+            expect(creator.save_to_xml).to be_xml(expected_xml)
+          end
+        end
+      end
     end
   end
 end

data/spec/unit/datacite/mapping/date_spec.rb

@@ -4,108 +4,30 @@ module Datacite
   module Mapping
     describe Date do
 
-      before(:each) do
-        @values = {
-          with_date_time: DateTime.new(1914, 8, 4, 11, 01, 6.0123, '+1'),
-          with_date: ::Date.new(1914, 8, 4),
-          with_year: 1914,
-          with_year_str: '1914',
-          with_year_month: '1914-08',
-          iso8601: '1914-08-04T11:01+01:00',
-          iso8601_secs: '1914-08-04T11:01:06+01:00',
-          iso8601_frac: '1914-08-04T11:01:06.0123+01:00',
-          year_range: '1914-1915'
-        }
-        @dates = @values.map { |format, v| [format, Date.new(type: DateType::AVAILABLE, value: v)] }.to_h
-      end
-
-      describe '#initialize' do
-        it 'accepts a DateTime' do
-          d = @dates[:with_date_time]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts a Date' do
-          d = @dates[:with_date]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts a year as an integer' do
-          d = @dates[:with_year]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts a year as a string' do
-          d = @dates[:with_year_str]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts a year-month string' do
-          d = @dates[:with_year_month]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts an ISO 8601 date string with hours and minutes' do
-          d = @dates[:iso8601]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts an ISO 8601 date string with hours, minutes, and seconds' do
-          d = @dates[:iso8601_secs]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
-        end
-
-        it 'accepts an ISO 8601 date string with hours, minutes, seconds, and fractional seconds' do
-          d = @dates[:iso8601_frac]
-          expect(d).to be_a(Date)
-          expect(d.value).not_to be_nil
+      describe 'RKMS-ISO8601 support' do
+        it 'supports closed datetime ranges' do
+          date = Date.new(value: '1997-07-16T19:30+10:00/1997-07-17T15:30-05:00', type: DateType::VALID)
+          expect(date.date_value).to be_nil
+          expect(date.range_start).to eq(DateValue.new('1997-07-16T19:30+10:00'))
+          expect(date.range_end).to eq(DateValue.new('1997-07-17T15:30-05:00'))
         end
 
-        it 'accepts a year range' do
-          d = @dates[:year_range]
-          expect(d).to be_a(Date)
-          expect(d.value).to eq('1914-1915')
+        it 'supports left open datetime ranges' do
+          date = Date.new(value: '/1997-07-17T15:30-05:00', type: DateType::VALID)
+          expect(date.date_value).to be_nil
+          expect(date.range_start).to be_nil
+          expect(date.range_end).to eq(DateValue.new('1997-07-17T15:30-05:00'))
         end
 
-        it 'rejects invalid dates' do
-          expect { Date.new(value: 'elvis') }.to raise_error(ArgumentError)
+        it 'supports right open datetime ranges' do
+          date = Date.new(value: '1997-07-16T19:30+10:00/', type: DateType::VALID)
+          expect(date.date_value).to be_nil
+          expect(date.range_start).to eq(DateValue.new('1997-07-16T19:30+10:00'))
+          expect(date.range_end).to be_nil
         end
 
-        it 'rejects nil' do
-          expect { Date.new(value: nil) }.to raise_error(ArgumentError)
-        end
-      end
-
-      describe 'value=' do
-        it 'accepts all date formats' do
-          @values.each_value do |v|
-            d = Date.allocate
-            d.value = v
-            expect(d.value).not_to be_nil, "Expected non-nil value for #{v}, got nil"
-          end
-        end
-
-        it 'supports RKMS-ISO8601 date ranges'
-
-        it 'rejects invalid dates' do
-          d = Date.new(value: 1914, type: DateType::AVAILABLE)
-          old_value = d.value
-          expect { d.value = 'elvis' }.to raise_error(ArgumentError)
-          expect(d.value).to eq(old_value)
-        end
-
-        it 'rejects nil' do
-          d = Date.new(value: 1914, type: DateType::AVAILABLE)
-          old_value = d.value
-          expect { d.value = nil }.to raise_error(ArgumentError)
-          expect(d.value).to eq(old_value)
+        it 'fails on range-like non-ranges' do
+          expect { Date.new(value: '5/18/72', type: DateType::VALID) }.to raise_error(ArgumentError)
         end
       end
 
@@ -123,123 +45,6 @@ module Datacite
         end
       end
 
-      describe 'value' do
-        it 'returns a string for a DateTime' do
-          expect(@dates[:with_date_time].value).to eq(@values[:with_date_time].iso8601)
-        end
-        it 'returns a string for a Date' do
-          expect(@dates[:with_date].value).to eq(@values[:with_date].iso8601)
-        end
-        it 'returns a string for a year as an integer' do
-          expect(@dates[:with_year].value).to eq(@values[:with_year].to_s)
-        end
-        it 'returns a string for a year as a string' do
-          expect(@dates[:with_year_str].value).to eq(@values[:with_year_str])
-        end
-        it 'returns a string for a year-month string' do
-          expect(@dates[:with_year_month].value).to eq(@values[:with_year_month])
-        end
-        it 'preserves an ISO 8601 date string with hours and minutes' do
-          expect(@dates[:iso8601].value).to eq(@values[:iso8601])
-        end
-        it 'preserves an ISO 8601 date string with hours, minutes, and seconds' do
-          expect(@dates[:iso8601_secs].value).to eq(@values[:iso8601_secs])
-        end
-        it 'preserves an ISO 8601 date string with hours, minutes, seconds, and fractional seconds' do
-          expect(@dates[:iso8601_frac].value).to eq(@values[:iso8601_frac])
-        end
-      end
-
-      describe 'year' do
-        it 'returns the year for all date formats' do
-          @dates.each_value do |d|
-            expect(d.year).to eq(1914)
-          end
-        end
-      end
-
-      describe 'month' do
-        it 'returns the month for all date formats that have it' do
-          expected = 8
-          @dates.each_pair do |format, d|
-            if [:with_year, :with_year_str, :year_range].include?(format)
-              expect(d.month).to be_nil
-            else
-              expect(d.month).to eq(expected), "expected #{expected}, got #{d.month} for :#{format} (#{d.value})"
-            end
-          end
-        end
-      end
-
-      describe 'day' do
-        it 'returns the day for all date formats that have it' do
-          expected = 4
-          @dates.each_pair do |format, d|
-            if [:with_year, :with_year_str, :with_year_month, :year_range].include?(format)
-              expect(d.day).to be_nil
-            else
-              expect(d.day).to eq(expected), "expected #{expected}, got #{d.day} for :#{format} (#{d.value})"
-            end
-          end
-        end
-      end
-
-      describe 'hour' do
-        it 'returns the hour for all formats that have it' do
-          expected = 11
-          @dates.each_pair do |format, d|
-            if [:with_date, :with_year, :with_year_str, :with_year_month, :year_range].include?(format)
-              expect(d.hour).to be_nil, "expected nil, got #{d.hour} for :#{format} (#{d.value})"
-            else
-              expect(d.hour).to eq(expected), "expected #{expected}, got #{d.hour} for :#{format} (#{d.value})"
-            end
-          end
-        end
-      end
-
-      describe 'minute' do
-        it 'returns the minutes for all formats that have it' do
-          expected = 1
-          @dates.each_pair do |format, d|
-            if [:with_date, :with_year, :with_year_str, :with_year_month, :year_range].include?(format)
-              expect(d.minute).to be_nil, "expected nil, got #{d.hour} for :#{format} (#{d.value})"
-            else
-              expect(d.minute).to eq(expected), "expected #{expected}, got #{d.minute} for :#{format} (#{d.value})"
-            end
-          end
-        end
-      end
-
-      describe 'sec' do
-        it 'returns the seconds for all formats that have it' do
-          expected = 6
-          @dates.each_pair do |format, d|
-            if [:with_date, :with_year, :with_year_str, :with_year_month, :year_range].include?(format)
-              expect(d.sec).to be_nil, "expected nil, got #{d.hour} for :#{format} (#{d.value})"
-            elsif format == :iso8601
-              expect(d.sec).to eq(0)
-            else
-              expect(d.sec).to eq(expected), "expected #{expected}, got #{d.sec} for :#{format} (#{d.value})"
-            end
-          end
-        end
-      end
-
-      describe 'nsec' do
-        it 'returns the nanoseconds for all formats that have it' do
-          expected = 12_300_000
-          @dates.each_pair do |format, d|
-            if [:with_date, :with_year, :with_year_str, :with_year_month, :year_range].include?(format)
-              expect(d.nsec).to be_nil, "expected nil, got #{d.hour} for :#{format} (#{d.value})"
-            elsif [:iso8601, :iso8601_secs].include?(format)
-              expect(d.nsec).to eq(0)
-            else
-              expect(d.nsec).to eq(expected), "expected #{expected}, got #{d.nsec} for :#{format} (#{d.value})"
-            end
-          end
-        end
-      end
-
       describe '#save_to_xml' do
         it 'writes XML' do
           d = Date.new(value: '1914-08-04T11:01:06.0123+01:00', type: DateType::AVAILABLE)
@@ -248,7 +53,13 @@ module Datacite
         end
       end
 
-      describe '#load_from_xml'
+      describe '#load_from_xml' do
+        it 'reads XML' do
+          xml = '<date dateType="Available">1914-08-04T11:01:06.0123+01:00</date>'
+          d = Date.parse_xml(xml)
+          expect(d.date_value).to eq(DateValue.new(DateTime.new(1914, 8, 4, 11, 0o1, 6.0123, '+1')))
+        end
+      end
     end
   end
 end