danger-wcc 0.0.3 → 0.1.1

data/spec/wcc/utils_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do
@@ -50,7 +50,7 @@ module Danger
             [
               load_diff('spec/fixtures/todo.rb', 'no_todo'),
               load_diff('spec/fixtures/find_in_diff.rb',
-                'find_in_diff_2_chunks')
+                        'find_in_diff_2_chunks')
             ]
           )
 

data/spec/wcc/yarn_deduplicate_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require File.expand_path('../spec_helper', __dir__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:pr_json)
+        .and_return(JSON.parse(load_fixture('github_pr.json')))
+      allow(subject).to receive(:run)
+        .with(/npm/)
+        .and_return('')
+      allow(subject).to receive(:run_and_diff)
+        .and_return(load_fixture('yarn_deduplicate/list.diff'))
+
+      allow(File).to receive(:exist?).and_call_original
+      allow(File).to receive(:read).and_call_original
+      allow(File).to receive(:exist?).with('yarn.lock')
+        .and_return(true)
+      allow(File).to receive(:readlines).with('yarn.lock')
+        .and_return(load_fixture('yarn_deduplicate/yarn.lock').split("\n"))
+    end
+
+    describe 'yarn_deduplicate' do
+      let(:subject) { Danger::DangerWCC::YarnDeduplicate.new(@my_plugin) }
+
+      it 'runs yarn-deduplicate and parses diff' do
+        # act
+        subject.perform
+
+        # assert
+        warnings = @dangerfile.violation_report[:warnings]
+        expect(warnings.length).to eq(2)
+
+        expect(warnings[0].message)
+          .to include('You have an opportunity to deduplicate "@babel/core".')
+        expect(warnings[0].message)
+          .to include('It wants >=7.1.0 and could unify with 7.12.10,'\
+            ' but instead 7.4.0')
+        expect(warnings[0].message)
+          .to include('npx yarn-deduplicate -s fewer --packages "@babel/core"')
+        expect(warnings[0].file).to eq('yarn.lock')
+        expect(warnings[0].line).to eq(24)
+
+        expect(warnings[1].message)
+          .to include('npx yarn-deduplicate -s fewer --packages "@babel/core"')
+        expect(warnings[1].file).to eq('yarn.lock')
+        expect(warnings[1].line).to eq(24)
+      end
+    end
+  end
+end

data/spec/wcc_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: danger-wcc
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.1
 platform: ruby
 authors:
 - Watermark Dev
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: brakeman
   requirement: !ruby/object:Gem::Requirement
@@ -154,16 +168,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.81'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.81'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -279,18 +293,37 @@ files:
 - lib/wcc/commit_lint/subject_words_check.rb
 - lib/wcc/default.jshintrc
 - lib/wcc/defaults.reek
+- lib/wcc/dependencies.rb
 - lib/wcc/github.rb
 - lib/wcc/jshint.rb
 - lib/wcc/plugin.rb
 - lib/wcc/reek.rb
 - lib/wcc/rubocop_exceptions.rb
 - lib/wcc/todos.rb
+- lib/wcc/util/yarn_info.rb
 - lib/wcc/utils.rb
+- lib/wcc/yarn_deduplicate.rb
 - spec/fixtures/brakeman/a.tmp
 - spec/fixtures/brakeman/b.tmp
 - spec/fixtures/brakeman/brakeman.diff
 - spec/fixtures/brakeman/brakeman.out
+- spec/fixtures/dependencies/package.json
+- spec/fixtures/dependencies/package.json.diff
+- spec/fixtures/dependencies/package.json_patch_bumps_minor.diff
+- spec/fixtures/dependencies/package.json_patch_bumps_minor.json
+- spec/fixtures/dependencies/package.json_second_level_effect.diff
+- spec/fixtures/dependencies/package.json_second_level_effect.json
+- spec/fixtures/dependencies/yarn.lock
+- spec/fixtures/dependencies/yarn.lock_patch_bumps_minor.lock
+- spec/fixtures/dependencies/yarn.lock_second_level_effect.lock
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt.diff
+- spec/fixtures/dependencies/yarn_minor_version.diff
+- spec/fixtures/dependencies/yarn_minor_version.txt
+- spec/fixtures/dependencies/yarn_old.txt
+- spec/fixtures/dependencies/yarn_patch_bumps_minor.diff
 - spec/fixtures/exception_context.diff
+- spec/fixtures/exception_inline_disabled_rule.diff
 - spec/fixtures/exception_insert_context.diff
 - spec/fixtures/exception_misspelled.diff
 - spec/fixtures/exception_multiline_context.diff
@@ -315,9 +348,14 @@ files:
 - spec/fixtures/todo_link_same_line.diff
 - spec/fixtures/todo_no_link.diff
 - spec/fixtures/todo_removed.diff
+- spec/fixtures/yarn_deduplicate/list.a.txt
+- spec/fixtures/yarn_deduplicate/list.b.txt
+- spec/fixtures/yarn_deduplicate/list.diff
+- spec/fixtures/yarn_deduplicate/yarn.lock
 - spec/fixtures_helper.rb
 - spec/spec_helper.rb
 - spec/wcc/commit_lint_spec.rb
+- spec/wcc/dependencies_spec.rb
 - spec/wcc/github_spec.rb
 - spec/wcc/jshint_spec.rb
 - spec/wcc/plugin_spec.rb
@@ -325,12 +363,13 @@ files:
 - spec/wcc/rubocop_exceptions_spec.rb
 - spec/wcc/todos_spec.rb
 - spec/wcc/utils_spec.rb
+- spec/wcc/yarn_deduplicate_spec.rb
 - spec/wcc_spec.rb
 homepage: https://github.com/watermarkchurch/danger-wcc
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -345,9 +384,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.5.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: A Danger plugin for Watermark Church custom rules.
 test_files:
@@ -355,7 +394,23 @@ test_files:
 - spec/fixtures/brakeman/b.tmp
 - spec/fixtures/brakeman/brakeman.diff
 - spec/fixtures/brakeman/brakeman.out
+- spec/fixtures/dependencies/package.json
+- spec/fixtures/dependencies/package.json.diff
+- spec/fixtures/dependencies/package.json_patch_bumps_minor.diff
+- spec/fixtures/dependencies/package.json_patch_bumps_minor.json
+- spec/fixtures/dependencies/package.json_second_level_effect.diff
+- spec/fixtures/dependencies/package.json_second_level_effect.json
+- spec/fixtures/dependencies/yarn.lock
+- spec/fixtures/dependencies/yarn.lock_patch_bumps_minor.lock
+- spec/fixtures/dependencies/yarn.lock_second_level_effect.lock
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt.diff
+- spec/fixtures/dependencies/yarn_minor_version.diff
+- spec/fixtures/dependencies/yarn_minor_version.txt
+- spec/fixtures/dependencies/yarn_old.txt
+- spec/fixtures/dependencies/yarn_patch_bumps_minor.diff
 - spec/fixtures/exception_context.diff
+- spec/fixtures/exception_inline_disabled_rule.diff
 - spec/fixtures/exception_insert_context.diff
 - spec/fixtures/exception_misspelled.diff
 - spec/fixtures/exception_multiline_context.diff
@@ -380,9 +435,14 @@ test_files:
 - spec/fixtures/todo_link_same_line.diff
 - spec/fixtures/todo_no_link.diff
 - spec/fixtures/todo_removed.diff
+- spec/fixtures/yarn_deduplicate/list.a.txt
+- spec/fixtures/yarn_deduplicate/list.b.txt
+- spec/fixtures/yarn_deduplicate/list.diff
+- spec/fixtures/yarn_deduplicate/yarn.lock
 - spec/fixtures_helper.rb
 - spec/spec_helper.rb
 - spec/wcc/commit_lint_spec.rb
+- spec/wcc/dependencies_spec.rb
 - spec/wcc/github_spec.rb
 - spec/wcc/jshint_spec.rb
 - spec/wcc/plugin_spec.rb
@@ -390,4 +450,5 @@ test_files:
 - spec/wcc/rubocop_exceptions_spec.rb
 - spec/wcc/todos_spec.rb
 - spec/wcc/utils_spec.rb
+- spec/wcc/yarn_deduplicate_spec.rb
 - spec/wcc_spec.rb