danger-wcc 0.0.3 → 0.1.1

data/spec/fixtures_helper.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 module FixturesHelper

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+ROOT = Pathname.new(File.expand_path('..', __dir__))
 $LOAD_PATH.unshift((ROOT + 'lib').to_s)
 $LOAD_PATH.unshift((ROOT + 'spec').to_s)
 

data/spec/wcc/commit_lint_spec.rb

@@ -4,7 +4,7 @@
 # https://github.com/jonallured/danger-commit_lint
 # which is licensed under the MIT License
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 TEST_MESSAGES = {
   subject_cap: 'this subject needs a capital',
@@ -16,7 +16,7 @@ TEST_MESSAGES = {
     'separating the subject and the body.",
   all_errors: "this is a really long subject and it even ends in a period.\n'\
     'Not to mention the missing empty line!",
-  valid:  "This is a valid message\n\nYou can tell because it meets all the '\
+  valid: "This is a valid message\n\nYou can tell because it meets all the '\
     'criteria and the linter does not complain."
 }.freeze
 
@@ -24,8 +24,6 @@ NOOP_MESSAGE = Danger::DangerWCC::CommitLint::NOOP_MESSAGE
 SUBJECT_LENGTH_CHECK_MESSAGE = 'Please limit commit subject line to 50 '\
   'characters.'
 
-# rubocop:enable Metrics/LineLength
-
 def report_counts(status_report)
   status_report.values.flatten.count
 end
@@ -132,7 +130,7 @@ module Danger
 
               checks.each do |check, _|
                 commit = double(:commit,
-                  message: TEST_MESSAGES[check], sha: sha)
+                                message: TEST_MESSAGES[check], sha: sha)
                 allow(@git).to receive(:commits).and_return([commit])
 
                 commit_lint disable: [check]
@@ -195,7 +193,7 @@ module Danger
 
               checks.each do |check, warning|
                 commit = double(:commit,
-                  message: TEST_MESSAGES[check], sha: sha)
+                                message: TEST_MESSAGES[check], sha: sha)
                 allow(@git).to receive(:commits).and_return([commit])
 
                 expect {
@@ -281,7 +279,7 @@ module Danger
 
               checks.each do |check, warning|
                 commit = double(:commit,
-                  message: TEST_MESSAGES[check], sha: sha)
+                                message: TEST_MESSAGES[check], sha: sha)
                 allow(@git).to receive(:commits).and_return([commit])
 
                 expect {
@@ -369,7 +367,7 @@ module Danger
 
             options.each_with_index do |(check, opts), i|
               commit = double(:commit,
-                message: TEST_MESSAGES[:valid], sha: sha)
+                              message: TEST_MESSAGES[:valid], sha: sha)
               allow(@git).to receive(:commits).and_return([commit])
 
               arg = {}
@@ -388,5 +386,3 @@ module Danger
     end
   end
 end
-
-# rubocop:enable Metrics/ClassLength

data/spec/wcc/dependencies_spec.rb

@@ -0,0 +1,129 @@
+# frozen_string_literal: true
+
+require File.expand_path('../spec_helper', __dir__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:html_link) do |text|
+        "<a href=\"github_html_link\">#{text}</a>"
+      end
+
+      allow(File).to receive(:exist?).and_call_original
+      allow(File).to receive(:read).and_call_original
+      allow(File).to receive(:exist?).with('yarn.lock')
+        .and_return(true)
+      allow(File).to receive(:readlines).with('yarn.lock')
+        .and_return(load_fixture('dependencies/yarn.lock').split("\n"))
+      allow(File).to receive(:read).with('package.json')
+        .and_return(load_fixture('dependencies/package.json'))
+    end
+
+    describe 'yarn dependencies' do
+      let(:subject) { Danger::DangerWCC::Dependencies.new(@my_plugin) }
+
+      it 'Errors when minor version changes' do
+        allow(subject).to receive(:run_and_diff)
+          .with(/yarn list/)
+          .and_return(load_fixture('dependencies/yarn_minor_version.diff'))
+        allow(@git).to receive(:diff)
+          .and_return([
+                        load_diff(
+                          'spec/fixtures/dependencies/package.json',
+                          'dependencies/package.json'
+                        )
+                      ])
+
+        # act
+        subject.perform
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([Violation.new(
+            'Dangerous change! react-instantsearch was updated '\
+            'from 5.3.2 to 5.7.0 without a corresponding '\
+            'change to package.json!',
+            false,
+            'yarn.lock',
+            15_613,
+            type: :error
+          )])
+      end
+
+      it 'Errors when patch bump causes minor version changes' do
+        allow(File).to receive(:readlines).with('yarn.lock')
+          .and_return(
+            load_fixture('dependencies/yarn.lock_patch_bumps_minor.lock')
+            .split("\n")
+          )
+
+        allow(subject).to receive(:run_and_diff)
+          .with(/yarn list/)
+          .and_return(load_fixture('dependencies/yarn_patch_bumps_minor.diff'))
+        allow(@git).to receive(:diff)
+          .and_return(
+            [
+              load_diff(
+                'spec/fixtures/dependencies/'\
+                  'package.json_patch_bumps_minor.json',
+                'dependencies/package.json_patch_bumps_minor'
+              )
+            ]
+          )
+
+        # act
+        subject.perform
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([Violation.new(
+            'Dangerous change! lodash was updated '\
+            'from 4.17.15 to 4.18.1 without a corresponding '\
+            'change to package.json!',
+            false,
+            'yarn.lock',
+            # make sure we pick out the right lodash!  There's 3 of them.
+            12_111,
+            type: :error
+          )])
+      end
+
+      it 'ignores all changes when top level major version changes' do
+        allow(File).to receive(:readlines).with('yarn.lock')
+          .and_return(
+            load_fixture('dependencies/yarn.lock_second_level_effect.lock')
+            .split("\n")
+          )
+        allow(File).to receive(:read).with('package.json')
+          .and_return(
+            load_fixture('dependencies/'\
+              'package.json_second_level_effect.json')
+          )
+
+        allow(subject).to receive(:run_and_diff)
+          .with(/yarn list/)
+          .and_return(load_fixture(
+                        'dependencies/yarn_list_second_level_effect.txt.diff'
+                      ))
+        allow(@git).to receive(:diff)
+          .and_return(
+            [
+              load_diff(
+                'package.json',
+                'dependencies/package.json_second_level_effect'
+              )
+            ]
+          )
+
+        # act
+        subject.perform
+
+        expect(@dangerfile.violation_report[:warnings].map(&:message))
+          .to eq([])
+      end
+    end
+  end
+end

data/spec/wcc/github_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 require 'webmock'
 
 module Danger
@@ -37,8 +37,10 @@ module Danger
       end
 
       it '#add_labels adds existing labels to issue' do
-        stub = stub_request(:post,
-          API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels')
+        stub = stub_request(
+          :post,
+          API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels'
+        )
           .with(body: '["backlog","bug","duplicate"]')
 
         # act
@@ -49,11 +51,15 @@ module Danger
       end
 
       it '#add_labels creates new labels before adding to issue' do
-        stub = stub_request(:post,
-          API_URL + '/repos/watermarkchurch/danger-wcc/labels')
+        stub = stub_request(
+          :post,
+          API_URL + '/repos/watermarkchurch/danger-wcc/labels'
+        )
           .with(body: '{"name":"new_label","color":"ffffff"}')
-        stub_request(:post,
-          API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels')
+        stub_request(
+          :post,
+          API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels'
+        )
           .with(body: '["backlog","new_label"]')
 
         # act

data/spec/wcc/jshint_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/plugin_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do
@@ -16,18 +16,24 @@ module Danger
     end
 
     describe 'all' do
-      it 'runs all checks and passes default options' do
-        Danger::DangerWCC::CHECKS.each do |check|
+      it 'runs all default and passes default options' do
+        %i[
+          rubocop_exceptions todos brakeman
+          dependencies yarn_deduplicate
+        ].each do |check|
           expect(@my_plugin).to receive(check)
             .with({})
         end
+        %i[commit_lint flay reek jshint].each do |check|
+          expect(@my_plugin).to_not receive(check)
+        end
 
         # act
         @my_plugin.all
       end
 
       it 'errors if all checks disabled' do
-        disabled = Danger::DangerWCC::CHECKS
+        disabled = Danger::DangerWCC::DEFAULT_OPTIONS.keys
         options = disabled.each_with_object({}) { |v, h| h[v] = false; }
 
         # expect
@@ -42,20 +48,19 @@ module Danger
       end
 
       it 'runs only enabled checks' do
-        enabled = %i[todos commit_lint]
-        disabled =
-          Danger::DangerWCC::CHECKS.reject do |check|
-            enabled.include?(check)
-          end
-        options = disabled.each_with_object({}) { |v, h| h[v] = false; }
+        options = {
+          rubocop_exceptions: false,
+          yarn_deduplicate: false,
+          todos: false,
+          brakeman: false,
+          reek: true
+        }
 
         # expect
-        enabled.each do |check|
-          expect(@my_plugin).to receive(check)
-        end
-        disabled.each do |check|
-          expect(@my_plugin).to_not receive(check)
-        end
+        expect(@my_plugin).to receive(:reek)
+        expect(@my_plugin).to receive(:dependencies)
+        expect(@my_plugin).to_not receive(:rubocop_exceptions)
+        expect(@my_plugin).to_not receive(:commit_lint)
 
         # act
         @my_plugin.all options
@@ -63,7 +68,7 @@ module Danger
 
       it 'passes options' do
         options =
-          Danger::DangerWCC::CHECKS.each_with_object({}) do |v, h|
+          Danger::DangerWCC::DEFAULT_OPTIONS.keys.each_with_object({}) do |v, h|
             h[v] = false
           end
         options[:commit_lint] = { test: { options: 1 } }

data/spec/wcc/reek_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do

data/spec/wcc/rubocop_exceptions_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do
@@ -30,9 +30,9 @@ module Danger
           .to eq([Violation.new('Rubocop rule Rails/SomeRule disabled in '\
             '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
               "  \nPlease provide an explanation why this rule was disabled.",
-            false,
-            'spec/fixtures/rubocop_exception.rb',
-            5)])
+                                false,
+                                'spec/fixtures/rubocop_exception.rb',
+                                5)])
       end
 
       it 'Errors when rubocop exception not reenabled' do
@@ -52,9 +52,28 @@ module Danger
               "\n\nThe rule was not reenabled!\n"\
               'Please add a `rubocop:enable` comment so the rule is disabled '\
               'for the minimal scope.',
-            false,
+                                false,
+                                'spec/fixtures/rubocop_exception.rb',
+                                10)])
+      end
+
+      it 'does not require reenabling for inline comments' do
+        allow(@git).to receive(:diff)
+          .and_return([load_diff(
             'spec/fixtures/rubocop_exception.rb',
-            10)])
+            'exception_inline_disabled_rule'
+          )])
+
+        # act
+        @my_plugin.rubocop_exceptions
+
+        expect(@dangerfile.violation_report[:warnings])
+          .to eq([Violation.new('Rubocop rule Rails/SomeRule disabled in '\
+            '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
+              "  \nPlease provide an explanation why this rule was disabled.",
+                                false,
+                                'spec/fixtures/rubocop_exception.rb',
+                                40)])
       end
 
       it 'Messages when exception added with context' do
@@ -71,9 +90,9 @@ module Danger
           .to eq([Violation.new('Rubocop rule Metrics/LineLength disabled in '\
             '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
             "  explanation:\n\t> Disabling because I want to.",
-            false,
-            'spec/fixtures/rubocop_exception.rb',
-            15)])
+                                false,
+                                'spec/fixtures/rubocop_exception.rb',
+                                15)])
       end
 
       it 'Messages when exception added with multiline context' do
@@ -92,9 +111,9 @@ module Danger
             '  explanation:'\
             "\n\t> I want to disable this because.."\
             "\n\t> I forgot the reasons.",
-            false,
-            'spec/fixtures/rubocop_exception.rb',
-            30)])
+                                false,
+                                'spec/fixtures/rubocop_exception.rb',
+                                30)])
       end
 
       it 'Messages when exception added in between existing comments' do
@@ -112,9 +131,9 @@ module Danger
             '<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
             '  explanation:'\
             "\n\t> here is my comment why we are disabling ABC",
-            false,
-            'spec/fixtures/rubocop_exception.rb',
-            21)])
+                                false,
+                                'spec/fixtures/rubocop_exception.rb',
+                                21)])
       end
 
       it 'Does not message when no exception added' do

data/spec/wcc/todos_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerWCC do
@@ -27,9 +27,9 @@ module Danger
           .to eq([Violation.new('TODO added in '\
             '<a href="github_html_link">spec/fixtures/todo.rb</a>'\
               ' - is there a card associated with that?',
-            false,
-            'spec/fixtures/todo.rb',
-            9)])
+                                false,
+                                'spec/fixtures/todo.rb',
+                                9)])
       end
 
       it 'Does not warn when TODO removed' do
@@ -68,9 +68,9 @@ module Danger
             '<a href="github_html_link">spec/fixtures/todo.rb</a> '\
               'referencing [https://zube.io/watermark/asdf1234]'\
               '(https://zube.io/watermark/asdf1234)',
-            false,
-            'spec/fixtures/todo.rb',
-            13)])
+                                false,
+                                'spec/fixtures/todo.rb',
+                                13)])
       end
 
       it 'Sends message when todo below link' do
@@ -87,9 +87,9 @@ module Danger
             '<a href="github_html_link">spec/fixtures/todo.rb</a> '\
               'referencing [https://www.github.com/watermarkchurch/asdf/1234]'\
               '(https://www.github.com/watermarkchurch/asdf/1234)',
-            false,
-            'spec/fixtures/todo.rb',
-            18)])
+                                false,
+                                'spec/fixtures/todo.rb',
+                                18)])
       end
     end
   end