danger-samsao 0.1.0

data/spec/samsao_merge_commit_detected_spec.rb

@@ -0,0 +1,81 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @merge_commits_detected = 'Some merge commits were detected, you must use rebase to sync with base branch.'
+
+        allow(@plugin.github).to receive(:branch_for_base).and_return('develop')
+      end
+
+      describe 'merge commit detected' do
+        it 'continues when no commits' do
+          allow(@plugin.git).to receive(:commits).and_return([])
+
+          @plugin.fail_when_merge_commit_detected
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues when no merge commits' do
+          allow(@plugin.git).to receive(:commits).and_return([
+            commit('One'),
+            commit('two'),
+          ])
+
+          @plugin.fail_when_merge_commit_detected
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues when one merge commits' do
+          allow(@plugin.git).to receive(:commits).and_return([
+            commit('one'),
+            commit("Merge branch 'develop'"),
+          ])
+
+          @plugin.fail_when_merge_commit_detected
+
+          expect(@dangerfile).to have_error(@merge_commits_detected)
+        end
+
+        it 'continues on multiple merge commits' do
+          allow(@plugin.git).to receive(:commits).and_return([
+            commit("Merge branch 'develop'"),
+            commit("Merge branch 'develop'"),
+          ])
+
+          @plugin.fail_when_merge_commit_detected
+
+          expect(@dangerfile).to have_error(@merge_commits_detected)
+        end
+
+        it 'uses correctly github base branch' do
+          allow(@plugin.github).to receive(:branch_for_base).and_return('test')
+          allow(@plugin.git).to receive(:commits).and_return([
+            commit("Merge branch 'test'"),
+          ])
+
+          @plugin.fail_when_merge_commit_detected
+
+          expect(@dangerfile).to have_error(@merge_commits_detected)
+        end
+      end
+
+      def commit(message)
+        Commit.new(message)
+      end
+
+      class Commit
+        attr_reader :message
+
+        def initialize(message)
+          @message = message
+        end
+      end
+    end
+  end
+end

data/spec/samsao_regexp_spec.rb

@@ -0,0 +1,35 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+require 'samsao/regexp'
+
+module Samsao
+  describe Samsao::Regexp do
+    describe '#from_sources' do
+      it 'returns regexp with prefixed with ^ when string' do
+        expect(Samsao::Regexp.from_source('src')).to eq(/^src/)
+      end
+
+      it 'returns regexp as-is on regexp' do
+        expect(Samsao::Regexp.from_source(/[abc]*/)).to eq(/[abc]*/)
+      end
+    end
+
+    describe '#from_matcher' do
+      it 'returns quoted string on string' do
+        expect(Samsao::Regexp.from_matcher('.*')).to eq(/\.\*/)
+      end
+
+      it 'returns as-is on regexp' do
+        expect(Samsao::Regexp.from_matcher(/.*/)).to eq(/.*/)
+      end
+
+      it 'supports string regexp modifier' do
+        expect(Samsao::Regexp.from_matcher('common/src', when_string_pattern_prefix_with: '^')).to eq(%r{^common/src})
+      end
+
+      it 'discards string regexp modifier when mathcer is a regexp' do
+        expect(Samsao::Regexp.from_matcher(/.*/, when_string_pattern_prefix_with: '^')).to eq(/.*/)
+      end
+    end
+  end
+end

data/spec/samsao_spec.rb

@@ -0,0 +1,9 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    it 'should be a plugin' do
+      expect(Danger::DangerSamsao.new(nil)).to be_a Danger::Plugin
+    end
+  end
+end

data/spec/samsao_trivial_change_spec.rb

@@ -0,0 +1,57 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+
+        allow(@plugin.github).to receive(:branch_for_head).and_return('something')
+        allow(@plugin.github).to receive(:pr_title).and_return('Something')
+      end
+
+      describe 'trivial_change?' do
+        ['#trivial', '#typo'].each do |marker|
+          it "returns true when PR title contains #{marker} at the end" do
+            allow(@plugin.github).to receive(:pr_title).and_return("Trivial at the end #{marker}")
+
+            expect(@plugin.trivial_change?).to be(true)
+          end
+
+          it "returns true when PR title contains #{marker} at the start" do
+            allow(@plugin.github).to receive(:pr_title).and_return("#{marker} Trivial at the start")
+
+            expect(@plugin.trivial_change?).to be(true)
+          end
+
+          it "returns true when PR title contains #{marker} in the middle" do
+            allow(@plugin.github).to receive(:pr_title).and_return("Trivial in #{marker} the middle")
+
+            expect(@plugin.trivial_change?).to be(true)
+          end
+
+          it "returns true when branch is a trivial branch and PR include #{marker}" do
+            allow(@plugin.github).to receive(:branch_for_head).and_return('trivial/a')
+            allow(@plugin.github).to receive(:pr_title).and_return("##{marker}")
+
+            expect(@plugin.trivial_change?).to be(true)
+          end
+        end
+
+        it 'returns false when not trivial branch and no trivial marker(s) in PR title' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.github).to receive(:pr_title).and_return('Something')
+
+          expect(@plugin.trivial_change?).to be(false)
+        end
+
+        it 'returns true when branch is a trivial branch' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('trivial/a')
+
+          expect(@plugin.trivial_change?).to be(true)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_work_in_progress_pr_spec.rb

@@ -0,0 +1,50 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @work_in_progress = 'Do not merge, PR is a work in progess [WIP]!'
+
+        allow(@plugin.github).to receive(:branch_for_head).and_return('something')
+        allow(@plugin.github).to receive(:pr_title).and_return('Something')
+      end
+
+      describe 'warn_when_work_in_progess_pr?' do
+        it 'warns when PR title contains [WIP] at the end' do
+          allow(@plugin.github).to receive(:pr_title).and_return('Marker at the end [WIP]')
+
+          @plugin.warn_when_work_in_progess_pr
+
+          expect(@dangerfile).to have_warning(@work_in_progress)
+        end
+
+        it 'warns when PR title contains [WIP] at the start' do
+          allow(@plugin.github).to receive(:pr_title).and_return('[WIP] Marker at start')
+
+          @plugin.warn_when_work_in_progess_pr
+
+          expect(@dangerfile).to have_warning(@work_in_progress)
+        end
+
+        it 'warns when PR title contains [WIP] in the middle' do
+          allow(@plugin.github).to receive(:pr_title).and_return('Marker in [WIP] the middle')
+
+          @plugin.warn_when_work_in_progess_pr
+
+          expect(@dangerfile).to have_warning(@work_in_progress)
+        end
+
+        it 'continues when PR title does not contain [WIP] marker' do
+          allow(@plugin.github).to receive(:pr_title).and_return('A WIP PR')
+
+          @plugin.warn_when_work_in_progess_pr
+
+          expect(@dangerfile).to have_no_warning
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,56 @@
+require 'pathname'
+ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+$LOAD_PATH.unshift((ROOT + 'lib').to_s)
+$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+
+require 'bundler/setup'
+
+require 'danger'
+require 'danger_plugin'
+require 'pry'
+require 'rspec'
+
+# Configure RSpec
+RSpec.configure do |config|
+  config.filter_gems_from_backtrace 'bundler'
+  config.color = true
+  config.tty = true
+end
+
+Dir["#{File.expand_path('../matchers', __FILE__)}/*.rb"].each do |file|
+  require file
+end
+
+# rubocop:disable Lint/NestedMethodDefinition
+def testing_ui
+  @output = StringIO.new
+  def @output.winsize
+    [20, 9999]
+  end
+
+  cork = Cork::Board.new(out: @output)
+  def cork.string
+    out.string.gsub(/\e\[([;\d]+)?m/, '')
+  end
+
+  cork
+end
+# rubocop:enable Lint/NestedMethodDefinition
+
+# Testing environment (ENV)
+def testing_env
+  {
+    'BITRISE_IO' => 'true',
+    'BITRISE_PULL_REQUEST' => '92',
+    'DANGER_GITHUB_API_BASE_URL' => 'https://api.github.com',
+    'DANGER_GITHUB_API_TOKEN' => ENV['DANGER_GITHUB_API_TOKEN'],
+    'GIT_REPOSITORY_URL' => 'git@github.com:samsao/verdant.git',
+  }
+end
+
+# A stubbed out Dangerfile for use in tests
+def testing_dangerfile
+  env = Danger::EnvironmentManager.new(testing_env)
+
+  Danger::Dangerfile.new(env, testing_ui)
+end

metadata

@@ -0,0 +1,240 @@
+--- !ruby/object:Gem::Specification
+name: danger-samsao
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Samsao Development Inc.
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2017-05-04 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: danger-plugin-api
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.11.0.pre2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.11.0.pre2
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.41'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.41'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+description: Danger plugin for Samsao PR guidelines.
+email:
+- mvachon@samsao.co
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".env.example"
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
+- CHANGELOG.md
+- Gemfile
+- Gemfile.lock
+- Guardfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- bitrise.wrapper.yml
+- bitrise.yml
+- danger-samsao.gemspec
+- lib/danger_plugin.rb
+- lib/danger_samsao.rb
+- lib/samsao/actions.rb
+- lib/samsao/config.rb
+- lib/samsao/gem_version.rb
+- lib/samsao/helpers.rb
+- lib/samsao/plugin.rb
+- lib/samsao/regexp.rb
+- spec/matchers/have_error.rb
+- spec/matchers/have_no_error.rb
+- spec/matchers/have_no_warning.rb
+- spec/matchers/have_warning.rb
+- spec/samsao_branch_helper_spec.rb
+- spec/samsao_branching_model_spec.rb
+- spec/samsao_changelog_modified_spec.rb
+- spec/samsao_changelog_updated_spec.rb
+- spec/samsao_config_spec.rb
+- spec/samsao_feature_single_commit_spec.rb
+- spec/samsao_has_app_changes_spec.rb
+- spec/samsao_merge_commit_detected_spec.rb
+- spec/samsao_regexp_spec.rb
+- spec/samsao_spec.rb
+- spec/samsao_trivial_change_spec.rb
+- spec/samsao_work_in_progress_pr_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/samsao/danger-samsao
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.6.10
+signing_key: 
+specification_version: 4
+summary: A longer description of danger-samsao.
+test_files:
+- spec/matchers/have_error.rb
+- spec/matchers/have_no_error.rb
+- spec/matchers/have_no_warning.rb
+- spec/matchers/have_warning.rb
+- spec/samsao_branch_helper_spec.rb
+- spec/samsao_branching_model_spec.rb
+- spec/samsao_changelog_modified_spec.rb
+- spec/samsao_changelog_updated_spec.rb
+- spec/samsao_config_spec.rb
+- spec/samsao_feature_single_commit_spec.rb
+- spec/samsao_has_app_changes_spec.rb
+- spec/samsao_merge_commit_detected_spec.rb
+- spec/samsao_regexp_spec.rb
+- spec/samsao_spec.rb
+- spec/samsao_trivial_change_spec.rb
+- spec/samsao_work_in_progress_pr_spec.rb
+- spec/spec_helper.rb