danger-samsao 0.1.0

data/spec/matchers/have_no_warning.rb

@@ -0,0 +1,14 @@
+require 'rspec/expectations'
+
+RSpec::Matchers.define :have_no_warning do
+  match do |actual|
+    actual.status_report[:warnings].empty?
+  end
+
+  failure_message do |actual|
+    message = "expected that #{Danger} would have no warning but found '#{actual.status_report[:warnings].size}'"
+    actual.status_report[:warnings].each do |warning|
+      message += "\n * #{warning}"
+    end
+  end
+end

data/spec/matchers/have_warning.rb

@@ -0,0 +1,25 @@
+require 'rspec/expectations'
+
+RSpec::Matchers.define :have_warning do |expected|
+  match do |actual|
+    actual.status_report[:warnings].any? do |warning|
+      expected.is_a?(Regexp) ? warning =~ matcher : warning.start_with?(expected)
+    end
+  end
+
+  failure_message do |actual|
+    message = "expected that #{Danger} would have warning '#{expected}'"
+
+    warnings = actual.status_report[:warnings]
+    if warnings.empty?
+      message += ' but there is none'
+      return message
+    end
+
+    actual.status_report[:warnings].each do |warning|
+      message += "\n * #{warning}"
+    end
+
+    message
+  end
+end

data/spec/samsao_branch_helper_spec.rb

@@ -0,0 +1,66 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'branch helpers' do
+        it 'supports feature_branch? correctly' do
+          data_set = [
+            { branch: 'feature/a', expected: true },
+            { branch: 'fix/a', expected: false },
+            { branch: 'random', expected: false },
+          ]
+
+          data_set.each do |data|
+            allow(@plugin.github).to receive(:branch_for_head).and_return(data[:branch])
+            expect(@plugin.feature_branch?).to be(data[:expected])
+          end
+        end
+
+        it 'supports fix_branch? correctly' do
+          data_set = [
+            { branch: 'feature/a', expected: false },
+            { branch: 'fix/a', expected: true },
+            { branch: 'random', expected: false },
+          ]
+
+          data_set.each do |data|
+            allow(@plugin.github).to receive(:branch_for_head).and_return(data[:branch])
+            expect(@plugin.fix_branch?).to be(data[:expected])
+          end
+        end
+
+        it 'supports release_branch? correctly' do
+          data_set = [
+            { branch: 'release/a', expected: true },
+            { branch: 'fix/a', expected: false },
+            { branch: 'random', expected: false },
+          ]
+
+          data_set.each do |data|
+            allow(@plugin.github).to receive(:branch_for_head).and_return(data[:branch])
+            expect(@plugin.release_branch?).to be(data[:expected])
+          end
+        end
+
+        it 'supports trivial_branch? correctly' do
+          data_set = [
+            { branch: 'trivial/a', expected: true },
+            { branch: 'fix/a', expected: false },
+            { branch: 'random', expected: false },
+          ]
+
+          data_set.each do |data|
+            allow(@plugin.github).to receive(:branch_for_head).and_return(data[:branch])
+            expect(@plugin.trivial_branch?).to be(data[:expected])
+          end
+        end
+      end
+    end
+  end
+end

data/spec/samsao_branching_model_spec.rb

@@ -0,0 +1,41 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @wrong_branching_model = 'Your branch should be prefixed with feature/, fix/, trivial/ or release/!'
+      end
+
+      describe 'branching model' do
+        ['fix', 'feature', 'release', 'trivial'].each do |branch_prefix|
+          it "continues on #{branch_prefix}/ prefix" do
+            allow(@plugin.github).to receive(:branch_for_head).and_return("#{branch_prefix}/something")
+
+            @plugin.fail_when_wrong_branching_model
+
+            expect(@dangerfile).to have_no_error
+          end
+        end
+
+        it 'fails on wrong prefix' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('wrong/12')
+
+          @plugin.fail_when_wrong_branching_model
+
+          expect(@dangerfile).to have_error(@wrong_branching_model)
+        end
+
+        it 'fails on good prefix but wrong format' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature_12')
+
+          @plugin.fail_when_wrong_branching_model
+
+          expect(@dangerfile).to have_error(@wrong_branching_model)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_changelog_modified_spec.rb

@@ -0,0 +1,48 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'changelog updated' do
+        it 'returns true when modified with single entry' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.md'])
+
+          expect(@plugin.changelog_modified?('CHANGELOG.md')).to be(true)
+        end
+
+        it 'returns true when modified with multiple entries' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.yml'])
+
+          expect(@plugin.changelog_modified?('CHANGELOG.md', 'CHANGELOG.yml')).to be(true)
+        end
+
+        it 'returns true when modified with multiple entries and multiple matches' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.yml', 'CHANGELOG.md'])
+
+          expect(@plugin.changelog_modified?('CHANGELOG.md', 'CHANGELOG.yml')).to be(true)
+        end
+
+        it 'returns false when not matching file' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.yml'])
+
+          expect(@plugin.changelog_modified?('CHANGELOG.md')).to be(false)
+        end
+
+        it 'uses plugin config changelogs when no arguments passed' do
+          @plugin.config do
+            changelogs 'CHANGELOG.md', 'CHANGELOG.yml'
+          end
+
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.yml'])
+
+          expect(@plugin.changelog_modified?).to be(true)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_changelog_updated_spec.rb

@@ -0,0 +1,87 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @changelog_needs_update = 'You did a fix or a feature without updating CHANGELOG file!'
+
+        allow(@plugin.github).to receive(:pr_title).and_return('Something')
+      end
+
+      describe 'changelog updated' do
+        it 'continues on non-feature & non-fix branch' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('trivial/a')
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues on feature branch and CHANGELOG updated' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.md'])
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues on fix branch and CHANGELOG updated' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.md'])
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'accepts customized changelogs path' do
+          @plugin.config do
+            changelogs 'CHANGELOG.yml'
+          end
+
+          allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
+          allow(@plugin.git).to receive(:modified_files).and_return(['CHANGELOG.yml'])
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'accepts multiple changelog paths' do
+          @plugin.config do
+            changelogs 'CHANGELOG.yml', 'web/CHANGELOG.md'
+          end
+
+          allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
+          allow(@plugin.git).to receive(:modified_files).and_return(['web/CHANGELOG.md'])
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues on trivial_change and CHANGELOG not updated' do
+          allow(@plugin).to receive(:trivial_change?).and_return(true)
+          allow(@plugin.git).to receive(:modified_files).and_return([])
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails on feature branch and CHANGELOG not updated' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.git).to receive(:modified_files).and_return([])
+
+          @plugin.fail_when_changelog_update_missing
+
+          expect(@dangerfile).to have_error(@changelog_needs_update)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_config_spec.rb

@@ -0,0 +1,30 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'samsao_config' do
+        it 'can configure single source' do
+          @plugin.config do
+            sources 'app/src'
+          end
+
+          expect(@plugin.config.sources).to eq(['app/src'])
+        end
+
+        it 'can configure multiple sources' do
+          @plugin.config do
+            sources 'app/src', 'lib/src'
+          end
+
+          expect(@plugin.config.sources).to eq(['app/src', 'lib/src'])
+        end
+      end
+    end
+  end
+end

data/spec/samsao_feature_single_commit_spec.rb

@@ -0,0 +1,42 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @must_have_single_commit = 'Your feature branch should have a single commit but found 2, squash them together!'
+      end
+
+      describe 'feature branch commits' do
+        it 'continues on feature branch and one commit' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.git).to receive(:commits).and_return(['sha1'])
+
+          @plugin.fail_when_non_single_commit_feature
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues on non-feature branch and multiple commits' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
+          allow(@plugin.git).to receive(:commits).and_return(['sha1', 'sha2'])
+
+          @plugin.fail_when_non_single_commit_feature
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails on feature branch and multiple commits' do
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.git).to receive(:commits).and_return(['sha1', 'sha2'])
+
+          @plugin.fail_when_non_single_commit_feature
+
+          expect(@dangerfile).to have_error(@must_have_single_commit)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_has_app_changes_spec.rb

@@ -0,0 +1,102 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+
+        allow(@plugin.github).to receive(:branch_for_head).and_return('something')
+        allow(@plugin.github).to receive(:pr_title).and_return('Something')
+      end
+
+      describe 'has_app_changes?' do
+        it 'returns true when single source has changed' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['src/a.txt'])
+
+          expect(@plugin.has_app_changes?('src/')).to be(true)
+        end
+
+        it 'returns true when single nested source has changed' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['src/a/b/c.txt'])
+
+          expect(@plugin.has_app_changes?('src/')).to be(true)
+        end
+
+        it 'returns true when single source has changed with multiple sources defined' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['common/src/c.txt'])
+
+          expect(@plugin.has_app_changes?('common/src/', 'web/src')).to be(true)
+        end
+
+        it 'returns true when single nested source has changed with multiple sources defined' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['web/src/a/b/c.txt'])
+
+          expect(@plugin.has_app_changes?('common/src/', 'web/src')).to be(true)
+        end
+
+        it 'returns true when multiple nested source has changed' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['c.txt', 'src/a/c.txt'])
+
+          expect(@plugin.has_app_changes?('src')).to be(true)
+        end
+
+        it 'returns true when multiple nested source has changed with multiple sources' do
+          allow(@plugin.git).to receive(:modified_files).and_return([
+            'c.txt',
+            'common/src/a/c.txt',
+            'web/src/a/c.txt',
+          ])
+
+          expect(@plugin.has_app_changes?('common/src', 'web/src')).to be(true)
+        end
+
+        it 'returns false when source is in the middle of a modified file' do
+          allow(@plugin.git).to receive(:modified_files).and_return([
+            'a/src/c.txt',
+            'a/src.txt',
+          ])
+
+          expect(@plugin.has_app_changes?('src')).to be(false)
+        end
+
+        it 'returns false when no source has changed' do
+          allow(@plugin.git).to receive(:modified_files).and_return([
+            'c.txt',
+            'common/a/c.txt',
+            'web/a/c.txt',
+          ])
+
+          expect(@plugin.has_app_changes?('src')).to be(false)
+        end
+
+        it 'returns false when no source has changed with multiple sources' do
+          allow(@plugin.git).to receive(:modified_files).and_return([
+            'c.txt',
+            'common/a/c.txt',
+            'web/a/c.txt',
+          ])
+
+          expect(@plugin.has_app_changes?('common/src', 'web/src')).to be(false)
+        end
+
+        it 'supports regexp source' do
+          allow(@plugin.git).to receive(:modified_files).and_return(['ab/1.txt'])
+
+          expect(@plugin.has_app_changes?(%r{[abc]+/[123]\.txt})).to be(true)
+        end
+
+        it 'uses plugin config sources when no arguments passed' do
+          @plugin.config do
+            sources %r{[abc]+/[123]\.txt}
+          end
+
+          allow(@plugin.git).to receive(:modified_files).and_return(['ab/1.txt'])
+
+          expect(@plugin.has_app_changes?).to be(true)
+        end
+      end
+    end
+  end
+end