danger-dangermattic 1.2.2 → 1.2.4

data/spec/pr_size_checker_spec.rb

@@ -72,19 +72,19 @@ module Danger
             end
 
             context 'when fail on error is false and a custom message is given' do
-              include_examples 'reporting diff size custom warnings or errors', false, 'this is my custom warning message'
+              it_behaves_like 'reporting diff size custom warnings or errors', false, 'this is my custom warning message'
             end
 
             context 'when fail on error is false' do
-              include_examples 'reporting diff size custom warnings or errors', false
+              it_behaves_like 'reporting diff size custom warnings or errors', false
             end
 
             context 'when fail on error is true' do
-              include_examples 'reporting diff size custom warnings or errors', true
+              it_behaves_like 'reporting diff size custom warnings or errors', true
             end
 
             context 'when a custom error message is given and fail on error is true' do
-              include_examples 'reporting diff size custom warnings or errors', true, 'this is my custom error message'
+              it_behaves_like 'reporting diff size custom warnings or errors', true, 'this is my custom error message'
             end
           end
         end
@@ -146,35 +146,36 @@ module Danger
             allow(@plugin.git).to receive_messages(added_files: [added_config, added_file], modified_files: [modified_file1, modified_file2, added_test_file, modified_strings], deleted_files: [deleted_file1, deleted_test_file, deleted_strings, deleted_file2])
 
             allow(@plugin.git).to receive(:diff).and_return(instance_double(Git::Diff))
-            expected_files = { added_test_file => {}, added_config => {}, added_file => {}, modified_file1 => {}, modified_file2 => {}, modified_strings => {}, deleted_file1 => {}, deleted_file2 => {}, deleted_test_file => {}, deleted_strings => {} }
+            # Populate stats hash directly with insertions/deletions data for the optimized code path
+            expected_files = {
+              added_test_file => { insertions: 201 },
+              added_config => { insertions: 311 },
+              added_file => { insertions: 13 },
+              modified_file1 => { insertions: 127, deletions: 159 },
+              modified_file2 => { insertions: 43, deletions: 37 },
+              modified_strings => { insertions: 432, deletions: 297 },
+              deleted_file1 => { deletions: 246 },
+              deleted_file2 => { deletions: 493 },
+              deleted_test_file => { deletions: 222 },
+              deleted_strings => { deletions: 593 }
+            }
             allow(@plugin.git.diff).to receive(:stats).and_return({ files: expected_files })
-
-            allow(@plugin.git).to receive(:info_for_file).with(added_test_file).and_return({ insertions: 201 })
-            allow(@plugin.git).to receive(:info_for_file).with(added_config).and_return({ insertions: 311 })
-            allow(@plugin.git).to receive(:info_for_file).with(added_file).and_return({ insertions: 13 })
-            allow(@plugin.git).to receive(:info_for_file).with(modified_file1).and_return({ insertions: 127, deletions: 159 })
-            allow(@plugin.git).to receive(:info_for_file).with(modified_file2).and_return({ insertions: 43, deletions: 37 })
-            allow(@plugin.git).to receive(:info_for_file).with(modified_strings).and_return({ insertions: 432, deletions: 297 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_file1).and_return({ deletions: 246 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_file2).and_return({ deletions: 493 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_test_file).and_return({ deletions: 222 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_strings).and_return({ deletions: 593 })
           end
         end
 
         context 'with the entire diff' do
-          include_examples 'using the default diff size counter, without a file selector', :all
-          include_examples 'using a file selector to filter and count the changes in a diff', :all, [422, 520, 1541]
+          it_behaves_like 'using the default diff size counter, without a file selector', :all
+          it_behaves_like 'using a file selector to filter and count the changes in a diff', :all, [422, 520, 1541]
         end
 
         context 'with the insertions in the diff' do
-          include_examples 'using the default diff size counter, without a file selector', :insertions
-          include_examples 'using a file selector to filter and count the changes in a diff', :insertions, [200, 139, 384]
+          it_behaves_like 'using the default diff size counter, without a file selector', :insertions
+          it_behaves_like 'using a file selector to filter and count the changes in a diff', :insertions, [200, 139, 384]
         end
 
         context 'with the deletions in the diff' do
-          include_examples 'using the default diff size counter, without a file selector', :deletions
-          include_examples 'using a file selector to filter and count the changes in a diff', :deletions, [221, 380, 1157]
+          it_behaves_like 'using the default diff size counter, without a file selector', :deletions
+          it_behaves_like 'using a file selector to filter and count the changes in a diff', :deletions, [221, 380, 1157]
         end
       end
 
@@ -221,19 +222,19 @@ module Danger
           end
 
           context 'when fail on error is false and a custom message is given' do
-            include_examples 'reporting PR length check custom warnings or errors', false, 'this is my custom warning message'
+            it_behaves_like 'reporting PR length check custom warnings or errors', false, 'this is my custom warning message'
           end
 
           context 'when fail on error is false' do
-            include_examples 'reporting PR length check custom warnings or errors', false
+            it_behaves_like 'reporting PR length check custom warnings or errors', false
           end
 
           context 'when fail on error is true' do
-            include_examples 'reporting PR length check custom warnings or errors', true
+            it_behaves_like 'reporting PR length check custom warnings or errors', true
           end
 
           context 'when a custom error message is given and fail on error is true' do
-            include_examples 'reporting PR length check custom warnings or errors', true, 'this is my custom error message'
+            it_behaves_like 'reporting PR length check custom warnings or errors', true, 'this is my custom error message'
           end
         end
       end

data/spec/spec_helper.rb

@@ -58,8 +58,14 @@ def testing_dangerfile
   Danger::Dangerfile.new(env, testing_ui)
 end
 
-def fixture(name)
-  File.read("spec/fixtures/#{name}")
+# Returns the full path of the fixture at the given subpath (relative to `spec/fixtures`)
+def fixture_path(*path_components)
+  File.join('spec', 'fixtures', *path_components)
+end
+
+# Returns the content of the fixture at the given path (relative to `spec/fixtures`)
+def fixture(*path_components)
+  File.read(fixture_path(*path_components))
 end
 
 # custom matchers

data/spec/view_changes_checker_spec.rb

@@ -123,62 +123,62 @@ module Danger
 
       context 'when checking an iOS PR' do
         context 'with view code changes in Swift files' do
-          include_examples 'PR with view code changes', ['TestView.swift', 'SimpleViewHelper.m']
+          it_behaves_like 'PR with view code changes', ['TestView.swift', 'SimpleViewHelper.m']
         end
 
         context 'with button changes in Swift files' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'MyAwesomeButton.swift']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.m', 'MyAwesomeButton.swift']
         end
 
         context 'with view code changes in ObjC files' do
-          include_examples 'PR with view code changes', ['TestView.m', 'SimpleViewHelper.m']
+          it_behaves_like 'PR with view code changes', ['TestView.m', 'SimpleViewHelper.m']
         end
 
         context 'with button changes in ObjC files' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'MyAwesomeButton.m']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.m', 'MyAwesomeButton.m']
         end
 
         context 'with changes in a .xib file' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'top_bar.xib']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.m', 'top_bar.xib']
         end
 
         context 'with changes in a Storyboard' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.m', 'main_screen.storyboard']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.m', 'main_screen.storyboard']
         end
 
         context 'with no view changes' do
-          include_examples 'PR without view code changes',
-                           ['SimpleViewHelper.m', 'MyButtonTester.swift', 'Version.xcconfig']
+          it_behaves_like 'PR without view code changes',
+                          ['SimpleViewHelper.m', 'MyButtonTester.swift', 'Version.xcconfig']
         end
       end
 
       context 'when checking an Android PR' do
         context 'with view code changes in Kotlin files' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.kt', 'MySimpleView.kt']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.kt', 'MySimpleView.kt']
         end
 
         context 'with button changes in Kotlin files' do
-          include_examples 'PR with view code changes', ['MyAwesomeButton.kt', 'SimpleViewHelper.java']
+          it_behaves_like 'PR with view code changes', ['MyAwesomeButton.kt', 'SimpleViewHelper.java']
         end
 
         context 'with view code changes in Java files' do
-          include_examples 'PR with view code changes', ['TestView.java', 'SimpleViewHelper.kt']
+          it_behaves_like 'PR with view code changes', ['TestView.java', 'SimpleViewHelper.kt']
         end
 
         context 'with button changes in Java files' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.kt', 'MyAwesomeButton.java']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.kt', 'MyAwesomeButton.java']
         end
 
         context 'with view code changes in a XML file' do
-          include_examples 'PR with view code changes', ['test_view.xml', 'SimpleViewHelper.kt', 'strings.xml']
+          it_behaves_like 'PR with view code changes', ['test_view.xml', 'SimpleViewHelper.kt', 'strings.xml']
         end
 
         context 'with button changes in a XML file' do
-          include_examples 'PR with view code changes', ['SimpleViewHelper.kt', 'strings.xml', 'my_awesome_button.xml']
+          it_behaves_like 'PR with view code changes', ['SimpleViewHelper.kt', 'strings.xml', 'my_awesome_button.xml']
         end
 
         context 'with no view changes' do
-          include_examples 'PR without view code changes', ['SimpleViewHelper.java', 'values.xml', 'MyButtonTester.kt']
+          it_behaves_like 'PR without view code changes', ['SimpleViewHelper.java', 'values.xml', 'MyButtonTester.kt']
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-dangermattic
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.4
 platform: ruby
 authors:
 - Automattic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-25 00:00:00.000000000 Z
+date: 2025-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -247,6 +247,7 @@ files:
 - spec/fixtures/android_unit_test_checker/Abcdef.kt
 - spec/fixtures/android_unit_test_checker/AbcdefgViewHelper.java
 - spec/fixtures/android_unit_test_checker/AnotherViewHelper.kt
+- spec/fixtures/android_unit_test_checker/MixDataPlusNormalClass.kt
 - spec/fixtures/android_unit_test_checker/MyNewClass.java
 - spec/fixtures/android_unit_test_checker/Polygon.kt
 - spec/fixtures/android_unit_test_checker/PublicAndPrivateType.kt
@@ -267,6 +268,14 @@ files:
 - spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/PublicTypeTest.kt
 - spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/TestMyNewClass.java
 - spec/fixtures/android_unit_test_checker/src/androidTest/java/org/test/ToolTest.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/api/ApiResult.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/api/WebRecordApi.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/domain/drive/UiStates.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/main/settings/integrations/connect/AppIntegrationModule.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/main/streaks/StreaksViewModel.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/mediastorage/MediaStorageConfiguration.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/utils/AccountType.kt
+- spec/fixtures/android_unit_test_checker/src/main/java/com/dayoneapp/dayone/utils/usecase/SelectPhotoUseCase.kt
 - spec/fixtures/android_unit_test_checker/src/main/java/org/wordpress/android/widgets/NestedWebView.kt
 - spec/fixtures/android_unit_test_checker/src/main/java/org/wordpress/util/config/BloggingPromptsFeatureConfig.kt
 - spec/fixtures/android_unit_test_checker/src/test/java/org/test/TestsINeedThem.java