danger-dangermattic 1.2.2 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dee5f031f75e2069d6d197e11a2c20be5e8bdd24792e04c36733632886bcbe56
-  data.tar.gz: 6375edfd326a90f60eb89b073d43896582fe23626624ccf08c148ada39bdacb2
+  metadata.gz: ad580440b78f9c9bd16790cb679c1a38a2ab32f22e9936f12e88398cef578a9f
+  data.tar.gz: ca179653e7759647821a2653f659ff04d56d38ce725993a31454f493180f1ffa
 SHA512:
-  metadata.gz: 2c6fdb6234e0f0957b20ab49aa4fc855a546edd73ac26b6d0ecafd8808a2dc5168530e784dc0341044684e0477e77b8d528bf5922753f6286dca47ff8f8d5407
-  data.tar.gz: 64ec129dac49b60046827c2ca42f91728fc395202cfbe2e4cf8d34773113fd6da4064c02f4f971fab9736f7a2842fd86f9f25d23c6208257c862d55fe7b9c39c
+  metadata.gz: a30553a0ff163ac72fa5492fc6db0047bf8e7569241a8cdce1de71bf8e8224703a271ca32afe0947ba61a751bcfbb048ed744c22e527513a2d0ae26adbd40ef0
+  data.tar.gz: f7657a8e47f25a63169a0e965a067792df749ee3fd8468199744dff509083f8b292da4475bef161bd38edcfe3acbf1c747e7a929d24136b3cd59bce0130e408c

data/.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rake
   - rubocop-rspec
 

data/CHANGELOG.md

@@ -20,6 +20,18 @@ _None_
 
 _None_
 
+## 1.2.4
+
+### Internal Changes
+
+- `pr_size_checker` and `manifest_pr_checker`: optimize performance for large PRs [#103]
+
+## 1.2.3
+
+### Bug Fixes
+
+- `android_unit_test_checker`: add `annotation` classes as an exception when reporting missing Android unit tests [#101]
+
 ## 1.2.2
 
 ### Bug Fixes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-dangermattic (1.2.2)
+    danger-dangermattic (1.2.4)
       danger (~> 9.4)
       danger-plugin-api (~> 1.0)
       danger-rubocop (~> 0.13)
@@ -10,10 +10,25 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
+    activesupport (8.0.2)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
-    ast (2.4.2)
-    base64 (0.2.0)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
     claide (1.1.0)
     claide-plugins (0.9.2)
       cork
@@ -21,48 +36,55 @@ GEM
       open4 (~> 1.3)
     coderay (1.1.3)
     colored2 (3.1.2)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (9.5.1)
+    danger (9.5.3)
       base64 (~> 0.2)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
-      colored2 (~> 3.1)
+      colored2 (>= 3.1, < 5)
       cork (~> 0.1)
       faraday (>= 0.9.0, < 3.0)
       faraday-http-cache (~> 2.0)
-      git (~> 1.13)
-      kramdown (~> 2.3)
+      git (>= 1.13, < 3.0)
+      kramdown (>= 2.5.1, < 3.0)
       kramdown-parser-gfm (~> 1.0)
       octokit (>= 4.0)
       pstore (~> 0.1)
-      terminal-table (>= 1, < 4)
+      terminal-table (>= 1, < 5)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     danger-rubocop (0.13.0)
       danger
       rubocop (~> 1.0)
-    diff-lcs (1.5.1)
-    faraday (2.12.0)
-      faraday-net_http (>= 2.0, < 3.4)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    faraday (2.13.4)
+      faraday-net_http (>= 2.0, < 3.5)
       json
       logger
     faraday-http-cache (2.5.1)
       faraday (>= 0.8)
-    faraday-net_http (3.3.0)
-      net-http
-    ffi (1.17.0)
-    ffi (1.17.0-arm64-darwin)
-    formatador (1.1.0)
-    git (1.19.1)
+    faraday-net_http (3.4.1)
+      net-http (>= 0.5.0)
+    ffi (1.17.2)
+    ffi (1.17.2-arm64-darwin)
+    formatador (1.1.1)
+    git (2.3.3)
+      activesupport (>= 5.0)
       addressable (~> 2.8)
+      process_executer (~> 1.1)
       rchardet (~> 1.8)
-    guard (2.19.0)
+    guard (2.19.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
+      logger (~> 1.6)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
+      ostruct (~> 0.6)
       pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
@@ -71,86 +93,102 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    json (2.7.5)
-    kramdown (2.4.0)
-      rexml
+    i18n (1.14.7)
+      concurrent-ruby (~> 1.0)
+    json (2.13.2)
+    kramdown (2.5.1)
+      rexml (>= 3.3.9)
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    language_server-protocol (3.17.0.3)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    logger (1.6.1)
-    lumberjack (1.2.10)
+    logger (1.7.0)
+    lumberjack (1.4.0)
     method_source (1.1.0)
+    minitest (5.25.5)
     nap (1.1.0)
     nenv (0.3.0)
-    net-http (0.4.1)
+    net-http (0.6.0)
       uri
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (9.2.0)
+    octokit (10.0.0)
       faraday (>= 1, < 3)
       sawyer (~> 0.9)
     open4 (1.3.4)
-    parallel (1.26.3)
-    parser (3.3.5.1)
+    ostruct (0.6.3)
+    parallel (1.27.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
-    pry (0.14.2)
+    prism (1.4.0)
+    process_executer (1.3.0)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pstore (0.1.3)
-    public_suffix (6.0.1)
+    pstore (0.2.0)
+    public_suffix (6.0.2)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.3.0)
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rchardet (1.8.0)
-    regexp_parser (2.9.2)
-    rexml (3.3.9)
-    rspec (3.13.0)
+    rchardet (1.9.0)
+    regexp_parser (2.11.0)
+    rexml (3.4.2)
+    rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.2)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.3)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.2)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.1)
-    rubocop (1.68.0)
+    rspec-support (3.13.4)
+    rubocop (1.79.2)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.2, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.33.0)
-      parser (>= 3.3.1.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
-    rubocop-rspec (3.2.0)
-      rubocop (~> 1.61)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.46.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
     sawyer (0.9.2)
       addressable (>= 2.3.5)
       faraday (>= 0.17.3, < 3)
+    securerandom (0.4.1)
     shellany (0.0.1)
-    terminal-table (3.0.2)
-      unicode-display_width (>= 1.1.1, < 3)
-    thor (1.3.2)
-    unicode-display_width (2.6.0)
-    uri (0.13.1)
+    terminal-table (4.0.0)
+      unicode-display_width (>= 1.1.1, < 4)
+    thor (1.4.0)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    uri (1.0.3)
     yard (0.9.37)
 
 PLATFORMS
@@ -170,4 +208,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   2.4.13
+   2.6.8

data/lib/dangermattic/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dangermattic
-  VERSION = '1.2.2'
+  VERSION = '1.2.4'
 end

data/lib/dangermattic/plugins/android_unit_test_checker.rb

@@ -24,14 +24,15 @@ module Danger
   #
   class AndroidUnitTestChecker < Plugin
     ANY_CLASS_DETECTOR = /class\s+([A-Z]\w+)\s*(.*?)\s*{/m
-    CLASS_MODIFIER_DETECTOR = /((?:\s|public|internal|protected|private|final|abstract|static|data|enum|sealed|value)*)class\s+([A-Z]\w+)\s*(.*?)\s*{/m
+    CLASS_MODIFIER_DETECTOR = /((?:\s|public|internal|protected|private|final|abstract|static|data|enum|sealed|value|annotation)*)class\s+([A-Z]\w+)\s*(.*?)\s*({|\n\n)/m
 
     CLASS_MODIFIER_EXCEPTIONS = [
       /\s*data\s*/,
       /\s*private\s*/,
       /\s*enum\s*/,
       /\s*sealed\s*/,
-      /\s*value\s*/
+      /\s*value\s*/,
+      /\s*annotation\s*/
     ].freeze
 
     DEFAULT_CLASSES_EXCEPTIONS = [
@@ -95,6 +96,7 @@ module Danger
     private
 
     ClassViolation = Struct.new(:classname, :file)
+    private_constant :ClassViolation
 
     # @param git_diff [Git::Diff] the git diff object
     # @param classes_exceptions [Array<String>] Regexes matching class names to exclude from the check.
@@ -151,7 +153,7 @@ module Danger
     # @return [Array<ClassViolation>] An array of ClassViolation objects representing the violations found.
     def find_violations(path:, diff_patch:, classes_exceptions:, subclasses_exceptions:)
       added_lines = git_utils.added_lines(diff_patch: diff_patch)
-      matches = added_lines.scan(CLASS_MODIFIER_DETECTOR)
+      matches = "#{added_lines}\n".scan(CLASS_MODIFIER_DETECTOR) # add a newline to ensure the regex matches the last class in the file
       matches.reject! do |m|
         class_match_is_exception?(
           m,
@@ -180,10 +182,11 @@ module Danger
     # @param classes_exceptions [Array<String>] Regexes matching class names to exclude from the check.
     # @param subclasses_exceptions [Array<String>] Regexes matching base class names to exclude from the check
     #
-    # @return [void]
+    # @return [Boolean]
     def class_match_is_exception?(match, file, classes_exceptions, subclasses_exceptions)
       return true if classes_exceptions.any? { |re| match[1] =~ re }
       return true if CLASS_MODIFIER_EXCEPTIONS.any? { |re| match[0] =~ re }
+      return true unless match[3].include?('{') # Ignore classes that don't have a body
 
       subclass_regexp = File.extname(file) == '.java' ? /extends\s+([A-Z]\w+)/m : /\s*:\s*([A-Z]\w+)/m
       subclass = match[2].scan(subclass_regexp)&.last&.last

data/lib/dangermattic/plugins/manifest_pr_checker.rb

@@ -29,7 +29,17 @@ module Danger
   #
   class ManifestPRChecker < Plugin
     MESSAGE = '`%s` was changed without updating its corresponding `%s`. %s.'
-    SWIFT_INSTRUCTION = 'Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running `swift package resolve`)'
+
+    # The two new lines at the start are intentional.
+    # This will be interpolated in MESSAGE into the final %s.
+    # The first new line moves it to a new line, the second adds visual padding.
+    SWIFT_INSTRUCTION = <<~INSTRUCTION
+
+
+      If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running `swift package resolve`).
+
+      If the change to the `Package.swift` did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case.
+    INSTRUCTION
 
     # Performs all the checks, asserting that changes on `Gemfile`, `Podfile` and `Package.swift` must have corresponding
     # lock file changes.
@@ -88,6 +98,8 @@ module Danger
     # Check if the `Package.swift` file was modified without a corresponding `Package.resolved` update,
     # checking for exact path matches
     #
+    # @param manifest_path [String] The path to the `Package.swift` file.
+    # @param manifest_lock_path [String] The path to the `Package.resolved` file.
     # @param report_type [Symbol] (optional) The type of report for the message. Types: :error, :warning (default), :message.
     #
     # @return [void]
@@ -103,13 +115,19 @@ module Danger
     private
 
     def check_manifest_lock_updated(file_name:, lock_file_name:, instruction:, report_type: :warning)
+      all_files = git_utils.all_changed_files
+
       # Find all the modified manifest files
-      manifest_modified_files = git_utils.all_changed_files.select { |f| File.basename(f) == file_name }
+      manifest_modified_files = all_files.select { |f| File.basename(f) == file_name }
+
+      # Build a hash mapping directory -> set of basenames for O(1) lookup
+      files_by_dir = all_files.group_by { |f| File.dirname(f) }
+                              .transform_values { |files| files.to_set { |f| File.basename(f) } }
 
       # For each manifest file, check if the corresponding lockfile (in the same dir) was also modified
       manifest_modified_files.each do |manifest_file|
-        lockfile_modified = git_utils.all_changed_files.any? { |f| File.dirname(f) == File.dirname(manifest_file) && File.basename(f) == lock_file_name }
-        next if lockfile_modified
+        manifest_dir = File.dirname(manifest_file)
+        next if files_by_dir[manifest_dir]&.include?(lock_file_name)
 
         message = format(MESSAGE, manifest_file, lock_file_name, instruction)
         reporter.report(message: message, type: report_type)
@@ -117,11 +135,10 @@ module Danger
     end
 
     def check_manifest_lock_updated_strict(manifest_path:, manifest_lock_path:, instruction:, report_type: :warning)
-      manifest_modified = git_utils.all_changed_files.include?(manifest_path)
-      return unless manifest_modified
+      all_files_set = git_utils.all_changed_files.to_set
 
-      lockfile_modified = git_utils.all_changed_files.include?(manifest_lock_path)
-      return if lockfile_modified
+      return unless all_files_set.include?(manifest_path)
+      return if all_files_set.include?(manifest_lock_path)
 
       message = format(MESSAGE, manifest_path, File.basename(manifest_lock_path), instruction)
       reporter.report(message: message, type: report_type)

data/lib/dangermattic/plugins/podfile_checker.rb

@@ -86,7 +86,9 @@ module Danger
     private
 
     COMMIT_REFERENCE_REGEXP = /\(from `\S+`, commit `\S+`\)/
+    private_constant :COMMIT_REFERENCE_REGEXP
     BRANCH_REFERENCE_REGEXP = /\(from `\S+`, branch `\S+`\)/
+    private_constant :BRANCH_REFERENCE_REGEXP
 
     def check_podfile_does_not_match(
       regexp:,

data/lib/dangermattic/plugins/pr_size_checker.rb

@@ -76,13 +76,12 @@ module Danger
     def insertions_size(file_selector: nil)
       return danger.git.insertions unless file_selector
 
-      filtered_files = git_utils.all_changed_files.select(&file_selector)
+      # Only check added and modified files - deleted files have 0 insertions
+      filtered_files = git_utils.added_and_modified_files.select(&file_selector)
 
       filtered_files.sum do |file|
-        # stats for a file in the GitHub API might be nil, making `info_for_file()` crash
-        next 0 if danger.git.diff.stats[:files][file].nil?
-
-        danger.git.info_for_file(file)&.[](:insertions).to_i
+        # Use cached stats directly instead of calling info_for_file for each file
+        danger.git.diff.stats[:files][file]&.[](:insertions).to_i
       end
     end
 
@@ -97,10 +96,8 @@ module Danger
       filtered_files = git_utils.all_changed_files.select(&file_selector)
 
       filtered_files.sum do |file|
-        # stats for a file in the GitHub API might be nil, making `info_for_file()` crash
-        next 0 if danger.git.diff.stats[:files][file].nil?
-
-        danger.git.info_for_file(file)&.[](:deletions).to_i
+        # Use cached stats directly instead of calling info_for_file for each file
+        danger.git.diff.stats[:files][file]&.[](:deletions).to_i
       end
     end
 
@@ -115,10 +112,11 @@ module Danger
       filtered_files = git_utils.all_changed_files.select(&file_selector)
 
       filtered_files.sum do |file|
-        # stats for a file in the GitHub API might be nil, making `info_for_file()` crash
-        next 0 if danger.git.diff.stats[:files][file].nil?
+        # Use cached stats directly instead of calling info_for_file for each file
+        stats = danger.git.diff.stats[:files][file]
+        next 0 unless stats
 
-        danger.git.info_for_file(file)&.[](:deletions).to_i + danger.git.info_for_file(file)&.[](:insertions).to_i
+        stats[:deletions].to_i + stats[:insertions].to_i
       end
     end
   end

data/rakelib/console.rake

@@ -38,7 +38,7 @@ module Console
     answer
   end
 
-  def self.confirm(text)
+  def self.confirm?(text)
     color_puts("#{text} [y/n]?", color_code: GREEN)
     answer = $stdin.gets.chomp
     answer.downcase == 'y'

data/rakelib/git_helpers.rake

@@ -17,7 +17,7 @@ module GitHelper
     elsif branch_exists
       Rake.sh('git', 'checkout', release_branch)
     else # create it
-      abort('Aborted, as not run from trunk nor release branch') unless current_branch == 'trunk' || Console.confirm("You are not on 'trunk', nor already on '#{release_branch}'. Do you really want to cut the release branch from #{current_branch}?")
+      abort('Aborted, as not run from trunk nor release branch') unless current_branch == 'trunk' || Console.confirm?("You are not on 'trunk', nor already on '#{release_branch}'. Do you really want to cut the release branch from #{current_branch}?")
 
       Rake.sh('git', 'checkout', '-b', release_branch)
     end

data/spec/android_unit_test_checker_spec.rb

@@ -144,6 +144,93 @@ module Danger
         expect(@dangerfile).to not_report
       end
 
+      it 'ensures data classes with no {…} body don\'t mess up detection of subsequent classes in the same file' do
+        # Ensure the CLASS_MODIFIER_DETECTOR regex doesn't assume class declaration always ends with `{` marking the class body
+        # (which would lead the regex to either miss the data class or extend the regex to the next `{`… that potentially belongs to the next class)
+        # This is especially important given data classes might not have a body at all
+
+        mix_data_plus_normal_class_file = 'MixDataPlusNormalClass.kt'
+        data_and_normal_class_diff = generate_add_diff_from_fixtures([mix_data_plus_normal_class_file])
+
+        allow(@dangerfile.git).to receive(:diff).and_return(data_and_normal_class_diff)
+
+        @plugin.check_missing_tests
+
+        expect_class_names_match_report(class_names: ['DummyClassMissingTest'], error_report: @dangerfile.status_report[:errors])
+      end
+
+      context 'when detecting classes and class modifiers' do
+        let(:added_files) do
+          dayone_source_fixtures_subdir = %w[src main java com dayoneapp dayone]
+          Dir.glob('**/*.kt', base: fixture_path('android_unit_test_checker', dayone_source_fixtures_subdir))
+             .map { |file| File.join(dayone_source_fixtures_subdir, file) }
+        end
+        let(:diff) { generate_add_diff_from_fixtures(added_files) }
+
+        # ClassName => Expected to be detected (true) or ignored (false)
+        let(:expected_detected_classes) do
+          {
+            # ApiResult.kt
+            'ApiResult' => false,   # `sealed class ApiResult<T>`
+            'Success' => false,     # `data class Success<T>`
+            'Empty' => false,       # `class Empty<T> : ApiResult<T>()` (but no body)
+            'Failure' => false,     # `data class Failure<T>(…)`
+            'FailureType' => false, # `enum class FailureType`
+
+            # WebRecordApi.kt
+            'CursorTime' => false,       # `value class CursorTime`
+            'WebRecordChanges' => false, # `data class WebRecordChanges`
+
+            # UiStates.kt
+            'LoadKeyUiState' => false, # `sealed class LoadKeyUiState`
+
+            # AppIntegrationModule.kt
+            'AppIntegrationHandlers' => false, # `annotation class AppIntegrationHandlers`
+
+            # StreaksViewModel.kt
+            'StreaksViewModel' => true,     # `class StreaksViewModel`
+            'Streaks' => false,             # `data class Streaks`
+            'JournalOptionsState' => false, # `class JournalOptionsState` (but no body)
+            'StreakWeekDay' => false,       # `data class StreakWeekDay`
+            'DayJournaled' => false,        # `value class DayJournaled`
+            'StreakJournal' => false,       # `data class StreakJournal`
+            'DaysOfWeekList' => false,      # `private class DaysOfWeekList`
+            'PreviousDays' => false,        # `class PreviousDays` (but no body)
+
+            # MediaStorageConfiguration.kt
+            'CompressQuality' => false,           # `value class CompressQuality`
+            'MediaStorageConfiguration' => false, # `class MediaStorageConfiguration` (but no body)
+            'ThumbnailsConfiguration' => false,   # `class ThumbnailsConfiguration` (but no body)
+
+            # AccountType.kt
+            'AccountType' => false, # `enum class AccountType`
+
+            # SelectPhotoUseCase.kt
+            'SelectPhotoUseCase' => true, # `class SelectPhotoUseCase`
+            'GetMultipleImages' => false, # `private class GetMultipleImages`
+            'GetSingleImage' => false # `private class GetSingleImage`
+          }
+        end
+
+        before do
+          allow(@dangerfile.git).to receive(:diff).and_return(diff)
+        end
+
+        it 'reports only classes that don\'t have a modifier that is part of modifier exceptions' do
+          @plugin.check_missing_tests
+          expected_violating_classes = expected_detected_classes.filter_map { |k, v| k if v } # only keys whose value is true
+          expect_class_names_match_report(class_names: expected_violating_classes, error_report: @dangerfile.status_report[:errors])
+        end
+
+        it 'validates that the RegEx matches all classes from source code' do
+          # Mock detection of exceptions in order to make `check_missing_tests` report all classes regardless of modifiers
+          # This allows us to validate that our RegEx matches all classes from the source code in the first place
+          allow(@plugin).to receive(:class_match_is_exception?).and_return(false)
+          @plugin.check_missing_tests
+          expect_class_names_match_report(class_names: expected_detected_classes.keys, error_report: @dangerfile.status_report[:errors])
+        end
+      end
+
       it 'does not report that a PR with the tests bypass label is missing tests' do
         added_files = %w[
           Abc.java
@@ -301,7 +388,7 @@ module Danger
 
     def generate_add_diff_from_fixtures(paths)
       paths.map do |path|
-        content = fixture(File.join('android_unit_test_checker', path))
+        content = fixture('android_unit_test_checker', path)
         diff_str = generate_add_diff(file_path: path, content: content)
 
         GitDiffStruct.new('new', path, diff_str)
@@ -310,7 +397,7 @@ module Danger
 
     def generate_delete_diff_from_fixtures(paths)
       paths.map do |path|
-        content = fixture(File.join('android_unit_test_checker', path))
+        content = fixture('android_unit_test_checker', path)
         diff_str = generate_delete_diff(file_path: path, content: content)
 
         GitDiffStruct.new('deleted', path, diff_str)
@@ -348,7 +435,10 @@ module Danger
     end
 
     def expect_class_names_match_report(class_names:, error_report:)
-      expect(class_names.length).to eq(error_report.length)
+      if error_report.length != class_names.length
+        reported_class_names = error_report.map { |e| e.match(/class `(.*?)`/)[1] }
+        expect(reported_class_names).to eq(class_names)
+      end
       class_names.zip(error_report).each do |cls, error|
         expect(error).to include "Please add tests for class `#{cls}`"
       end

data/spec/fixtures/android_unit_test_checker/MixDataPlusNormalClass.kt

@@ -0,0 +1,14 @@
+import javax.inject.Inject
+import javax.inject.Singleton
+
+internal data class DummyDataClassNotNeedingTests(
+    val title: String,
+    val id: String
+)
+
+@Singleton
+internal class DummyClassMissingTest @Inject constructor(
+    private val name: String,
+) : ParentClass {
+    private val loggingTag = 'mylogging'
+}