dandify 0.0.1 → 3.0.1

data/spec/features/dandy_style_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 feature 'Dandy stylesheet' do
   scenario 'store contains dandystylesheet' do
     visit spree.root_path
+
     expect(page).to(
       have_xpath('//link[contains(@href, "/dandystyles.css")]', visible: false)
     )

data/spec/features/managing_stylesheet_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+
+feature 'Managing stylesheets' do
+  stub_authorization!
+
+  let(:show_path)    { spree.admin_stylesheets_path }
+  let(:new_path)     { spree.new_admin_stylesheets_path }
+  let(:edit_path)    { spree.edit_admin_stylesheets_path }
+  let(:restore_path) { spree.restore_admin_stylesheets_path }
+  let(:style) { 'body {display: none;}' }
+  let(:css_path) { 'table#listing_versions tbody tr' }
+
+  context 'without existing style' do
+    scenario 'user views page with no stylesheet' do
+      visit show_path
+
+      expect(page).to have_text Spree.t('dandify.admin.no_resource_found')
+      expect(page).to have_text Spree.t('dandify.admin.create_one')
+    end
+
+    scenario 'user can create styles' do
+      visit new_path
+
+      fill_in Spree.t('dandify.admin.labels.style_raw'), with: style
+      click_button Spree.t(:create)
+
+      expect(page).to have_text Spree.t('dandify.admin.title.show')
+    end
+  end
+
+  context 'with existing style', versioning: true do
+    before { create :stylesheet }
+
+    scenario 'user does not see audit trail with no revisions' do
+      visit show_path
+
+      expect(page).not_to have_css(css_path, count: 1)
+    end
+
+    scenario 'after first edit user can see previous revisions' do
+      visit edit_path
+
+      fill_in Spree.t('dandify.admin.labels.style_raw'), with: '.moon { display: none}'
+      click_button Spree.t(:update)
+
+      expect(page).to have_css(css_path, count: 2)
+    end
+
+    scenario 'user can edit exiting styles' do
+      visit edit_path
+
+      fill_in Spree.t('dandify.admin.labels.style_raw'), with: style
+      click_button Spree.t(:update)
+
+      expect(page).to have_text(Spree.t('dandify.admin.title.show'))
+    end
+
+    scenario 'user creates new audit trail on edit', versioning: true, js: true do
+      visit edit_path
+      fill_in Spree.t('dandify.admin.labels.style_raw'), with: style
+
+      click_button Spree.t(:update)
+
+      expect(page).to have_css(css_path, count: 2)
+    end
+  end
+
+  context 'restoring stylesheet' do
+    before { create :stylesheet }
+
+    scenario 'not possible when there is only one version', versioning: true do
+      visit show_path
+
+      expect(page).not_to have_css(css_path)
+    end
+
+    scenario 'user can restore to previous version', versioning: true, js: true do
+      visit edit_path
+      fill_in Spree.t('dandify.admin.labels.style_raw'), with: style
+
+      click_button Spree.t(:update)
+
+      expect(page).to have_css(css_path, count: 2)
+    end
+  end
+end

data/spec/features/sidebar_spec.rb

@@ -1,24 +1,23 @@
 require 'spec_helper'
 
-describe 'In the admin' do
+feature 'In the admin sidebar' do
   stub_authorization!
 
   let(:configuration_path) { spree.edit_admin_general_settings_path }
-  let(:show_path) { spree.admin_stylesheets_path }
-  let(:new_path) { spree.new_admin_stylesheets_path }
-  let(:edit_path) { spree.edit_admin_stylesheets_path }
+  let(:show_path)          { spree.admin_stylesheets_path }
+  let(:new_path)           { spree.new_admin_stylesheets_path }
+  let(:edit_path)          { spree.edit_admin_stylesheets_path }
 
   context 'on the configuration page' do
-    it 'the user views Dandify link in sidebar' do
-      visit configuration_path
-      expect(page).to have_link(Spree.t('dandify.sidebar'), href: show_path)
-    end
+    before { visit configuration_path }
 
     it 'the user views non-highlighted Dandify link in sidebar' do
-      visit configuration_path
       expect(page).to_not(
         have_selector(:css, "li.active a[href='#{show_path}']")
       )
+      expect(page).to have_link(
+        Spree.t('dandify.admin.sidebar'), href: show_path
+      )
     end
   end
 
@@ -26,16 +25,25 @@ describe 'In the admin' do
     it 'on Dandify show page' do
       visit show_path
       expect(page).to have_selector(:css, "li.active a[href='#{show_path}']")
+      expect(page).to have_link(
+        Spree.t('dandify.admin.sidebar'), href: show_path
+      )
     end
 
     it 'on Dandify edit page' do
       visit edit_path
       expect(page).to have_selector(:css, "li.active a[href='#{show_path}']")
+      expect(page).to have_link(
+        Spree.t('dandify.admin.sidebar'), href: show_path
+      )
     end
 
     it 'on Dandify new page' do
       visit new_path
       expect(page).to have_selector(:css, "li.active a[href='#{show_path}']")
+      expect(page).to have_link(
+        Spree.t('dandify.admin.sidebar'), href: show_path
+      )
     end
   end
 end

data/spec/helpers/admin/navigation_helper_spec.rb

@@ -1,13 +1,19 @@
 require 'spec_helper'
 
-describe Spree::Admin::NavigationHelper do
-  describe '#link_to_restore_url' do
-    let(:restore_path) { spree.edit_admin_stylesheets_path }
+module Spree
+  module Admin
+    describe NavigationHelper do
+      describe '#link_to_restore_url' do
+        let(:restore_path) { spree.edit_admin_stylesheets_path }
 
-    context 'link to restore URL' do
-      it 'should build circular restore button' do
-        restore_button = helper.link_to_restore_url(restore_path)
-        restore_button.should include(Spree.t('dandify.confirm.restore'))
+        context 'link to restore URL' do
+          it 'should build circular restore button' do
+            restore_button = helper.link_to_restore_url(restore_path)
+
+            expect(restore_button).
+              to include(Spree.t('dandify.admin.confirm.restore'))
+          end
+        end
       end
     end
   end

data/spec/helpers/admin/stylesheet_helper_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe StylesheetHelper do
+      describe '#dandify_version_email' do
+        context 'with nil or unknown values' do
+          let(:fake_unknown_user) { instance_double(UnknownUser, email: 'foo') }
+
+          before do
+            allow(UnknownUser).to receive(:new) { fake_unknown_user }
+          end
+
+          context 'when user_id is nil' do
+            it 'instantiates a new UknownUser and calls #email' do
+              helper.dandify_version_email(nil)
+
+              expect(UnknownUser).to have_received(:new)
+              expect(fake_unknown_user).to have_received(:email)
+            end
+          end
+
+          context 'when user_id equals Spree.t("dandify.admin.unknown")' do
+            it 'instantiates a new UknownUser and calls #email' do
+              helper.dandify_version_email(Spree.t('dandify.admin.unknown'))
+
+              expect(UnknownUser).to have_received(:new)
+              expect(fake_unknown_user).to have_received(:email)
+            end
+          end
+        end
+
+        context 'with everything else' do
+          it 'sends user_id to User#find and calls email' do
+            fake_user = instance_double(User, email: 'foo')
+            allow(User).to receive(:find) { fake_user }
+
+            helper.dandify_version_email('1')
+
+            expect(User).to have_received(:find).with '1'
+            expect(fake_user).to have_received(:email)
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/blank_stylesheet_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 
-describe Spree::BlankStylesheet, '#style_compressed' do
-  it 'returns a blank string' do
-    expect(Spree::BlankStylesheet.new.style_compressed).to eq ''
+module Spree
+  describe BlankStylesheet, '#style_compressed' do
+    it 'returns a blank string' do
+      expect(subject.style_compressed).to eq ''
+    end
   end
 end

data/spec/models/spree/stylesheet_spec.rb

@@ -1,102 +1,106 @@
 require 'spec_helper'
 
-describe Spree::Stylesheet do
-  context 'versions', versioning: true do
-    it { should be_versioned }
+module Spree
+  describe Stylesheet do
+    context 'versions', versioning: true do
+      it { should be_versioned }
 
-    it 'restores previous versions' do
-      style = create :stylesheet
-      style.update style_raw: 'h1{display:none; color: blue;}'
+      it 'restores previous versions' do
+        style = create :stylesheet
+        style.update style_raw: 'h1{display:none; color: blue;}'
 
-      expect(style.versions.size).to eq(2)
+        expect(style.versions.size).to eq(2)
+      end
     end
-  end
 
-  context 'validations' do
-    let(:valid_css) { '#main {background-color: #0000ff}' }
-    let(:invalid_css) { 'main {background-color #0000ff}' }
+    context 'validations' do
+      let(:valid_css)   { '#main {background-color: #0000ff}' }
+      let(:invalid_css) { 'main {background-color #0000ff}' }
 
-    it { should validate_presence_of(:style_raw) }
+      it { should validate_presence_of(:style_raw) }
 
-    it 'pass with proper vanilla syntax' do
-      expect(style_with valid_css).to be_valid
-    end
+      it 'pass with proper vanilla syntax' do
+        expect(style_with valid_css).to be_valid
+      end
 
-    it 'fail with bad vanilla syntax' do
-      expect(style_with invalid_css).to_not be_valid
+      it 'fail with bad vanilla syntax' do
+        expect(style_with invalid_css).to_not be_valid
+      end
     end
-  end
 
-  context 'processing raw' do
-    it 'allows both css and scss' do
-      expect(style_with(<<-CSS)).to be_valid
+    context 'processing raw' do
+      it 'allows both css and scss' do
+        expect(style_with(<<-CSS)).to be_valid
 
-$font-stack: Helvetica, sans-serif;
+  $font-stack: Helvetica, sans-serif;
 
-body {
-  font: 100% $font-stack
-}
+  body {
+    font: 100% $font-stack
+  }
 
-h1 { display: inline ;}
+  h1 { display: inline ;}
 
-      CSS
-    end
+        CSS
+      end
 
-    context 'compresses' do
-      it 'vanilla css' do
-        compressed = "#main{display:block}.foo{width:300px;height:200px}\n"
-        expect(create_style_with(<<-CSS).style_compressed).to eq compressed
+      context 'compresses' do
+        it 'vanilla css' do
+          compressed = "#main{display:block}.foo{width:300px;height:200px}\n"
+          expect(create_style_with(<<-CSS).style_compressed).to eq compressed
 
-#main {
-   display: block;
-}
+  #main {
+     display: block;
+  }
 
-.foo {
-  width: 300px;
-  height: 200px;
-}
+  .foo {
+    width: 300px;
+    height: 200px;
+  }
 
-        CSS
-      end
+          CSS
+        end
 
-      it 'compresses scss' do
-        compressed = "nav ul{margin:0;padding:0}a{display:block}\n"
-        expect(create_style_with(<<-CSS).style_compressed).to eq compressed
+        it 'compresses scss' do
+          compressed = "nav ul{margin:0;padding:0}a{display:block}\n"
+          expect(create_style_with(<<-CSS).style_compressed).to eq compressed
 
-nav {
-  ul {
-    margin: 0;
-    padding: 0;
+  nav {
+    ul {
+      margin: 0;
+      padding: 0;
+    }
   }
-}
 
-a {
-  display: block;
-}
+  a {
+    display: block;
+  }
 
-        CSS
+          CSS
+        end
       end
     end
-  end
 
-  def create_style_with(css)
-    style = style_with(css)
-    style.save
-    style
-  end
+    def create_style_with(css)
+      style = style_with(css)
+      style.save
+      style
+    end
 
-  def style_with(css)
-    Spree::Stylesheet.new(style_raw: css)
+    def style_with(css)
+      Spree::Stylesheet.new(style_raw: css)
+    end
   end
-end
 
-describe Spree::Stylesheet, '#load_style' do
-  it 'returns Blanksheet when no sheet is found' do
-    expect(Spree::Stylesheet.load_style).to be_a Spree::BlankStylesheet
-  end
+  describe Stylesheet, '#load_style' do
+    it 'returns Blanksheet when no sheet is found' do
+      expect(described_class.load_style).to be_a Spree::BlankStylesheet
+    end
 
-  it 'returns a found instance of itself' do
-    styles = create :stylesheet
-    expect(Spree::Stylesheet.load_style).to eq styles
+    it 'returns a found instance of itself' do
+      styles = create :stylesheet
+      expect(described_class.load_style).to eq styles
+    end
   end
 end
+
+

data/spec/spec_helper.rb

@@ -10,30 +10,33 @@ rescue LoadError
   exit
 end
 
-require 'rspec/rails'
-require 'shoulda-matchers'
-require 'ffaker'
-require 'database_cleaner'
 require 'capybara'
-require 'capybara/rspec'
-require 'capybara/rails'
 require 'capybara/poltergeist'
+require 'capybara/rails'
+require 'capybara/rspec'
+require 'database_cleaner'
+require 'ffaker'
 require 'paper_trail/frameworks/rspec'
+require 'pry-byebug'
+require 'rspec/rails'
+require 'shoulda-matchers'
 
 Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
 
-require 'spree/testing_support/factories'
-require 'spree/testing_support/controller_requests'
 require 'spree/testing_support/authorization_helpers'
-require 'spree/testing_support/url_helpers'
 require 'spree/testing_support/capybara_ext'
+require 'spree/testing_support/controller_requests'
+require 'spree/testing_support/factories'
+require 'spree/testing_support/url_helpers'
+
+Capybara.javascript_driver = :poltergeist
 
 FactoryGirl.find_definitions
 
 RSpec.configure do |config|
   config.deprecation_stream = 'rspec.log'
-  config.include Spree::TestingSupport::ControllerRequests
   config.include FactoryGirl::Syntax::Methods
+  config.include Spree::TestingSupport::ControllerRequests, type: :controller
   config.include Spree::TestingSupport::UrlHelpers
   config.include Devise::TestHelpers, type: :controller
   config.use_transactional_fixtures = false
@@ -54,6 +57,4 @@ RSpec.configure do |config|
   config.after do
     DatabaseCleaner.clean
   end
-
-  Capybara.javascript_driver = :poltergeist
 end