dandify 0.0.1 → 3.0.1

data/config/locales/en.yml

@@ -1,37 +1,49 @@
 ---
 en:
-  activerecord:
-    attributes:
-      spree/stylesheet:
-        style_raw: Styles
   spree:
     dandify:
-      unknown: Unknown
-      sidebar: Store Stylesheet
-      show:
-        title: Custom Styles
+      admin:
+        action:
+          create: Created
+          update: Revised
+          destroy: Deleted
+        unknown: Unknown
+        no_resource_found: No stylesheet found
+        create_one: Let's get dandy
+        sidebar: Store Stylesheet
+        confirm:
+          restore: Are you sure you want to restore this version of the stylesheet?
+          destroy: Are you sure you want to delete your stylesheet?
         buttons:
-          new: Create stylesheet
-          edit: Edit stylesheet
-        none: No custom style yet! Let's get dandy!
+          new: Create Stylesheet
+          edit: Edit
+          destroy: Delete
+        icons:
+          restore: Restore
+          destroy: Destroy
+        title:
+          show: Custom Styles
+          new: Creating Custom Styles
+          edit: Editing Custom Styles
+        flash:
+          success:
+            new: New stylesheet has been created.
+            edit: Stylesheet has been updated. A new revision has been created.
+            restore: Stylesheet has been restored. A new revision has been created.
+            destroyed: Stylesheet has been destroyed. A new revision has been created.
+          error:
+            restore: Unable to restore stylesheet.
         headers:
-          created_at: Created
+          on: On
           author: Author
           action: Action
-      new:
-        title: Creating Custom Styles
-        success: New stylesheet has been created.
-      edit:
-        title: Editing Custom Styles
-        success: Stylesheet has been updated. A new revision has been created.
-      restore:
-        name: Restore
-        success: Stylesheet has been restored. A new revision has been created.
-        error: Unable to restore stylesheet.
-      form:
-        fieldset: Stylesheet
-        label: Styles
+          revision: Revisions
+        labels: &dandify_labels
+          style_raw: Styles
         notes:
           sass: Stylesheets are compiled and minified using a CSS preprocessor. Valid SCSS can be used here.
-      confirm:
-        restore: Are you sure you want to restore this version of the stylesheet?
+
+  activerecord:
+    attributes:
+      spree/stylesheet:
+        <<: *dandify_labels

data/config/routes.rb

@@ -1,7 +1,7 @@
 Spree::Core::Engine.add_routes do
   namespace :admin do
     resource :stylesheets do
-      post 'restore', to: 'stylesheets#restore'
+      post :restore
     end
   end
 

data/db/migrate/20140617221725_add_paper_trail_versions.rb

@@ -1,11 +1,11 @@
 class AddPaperTrailVersions < ActiveRecord::Migration
   def change
     create_table :versions do |t|
-      t.string   :item_type, :null => false
-      t.integer  :item_id,   :null => false
-      t.string   :event,     :null => false
-      t.string   :whodunnit
-      t.text     :object
+      t.string :item_type, null: false
+      t.integer :item_id, null: false
+      t.string :event, null: false
+      t.string :whodunnit
+      t.text :object
       t.datetime :created_at
     end
     add_index :versions, [:item_type, :item_id]

data/lib/dandify.rb

@@ -1,5 +1,4 @@
 require 'spree_core'
-require 'sass'
 require 'paper_trail'
 require 'dandify/engine'
 

data/lib/dandify/version.rb

@@ -1,3 +1,3 @@
 module Dandify
-  VERSION = '0.0.1'
+  VERSION = '3.0.1'
 end

data/lib/generators/dandify/install/install_generator.rb

@@ -3,21 +3,22 @@ module Dandify
     class InstallGenerator < Rails::Generators::Base
       class_option :auto_run_migrations, type: :boolean, default: true
 
-      def add_migrations
-        run 'bundle exec rake railties:install:migrations FROM=dandify'
+      def add_javascripts
+        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/dandify\n"
+        append_file 'vendor/assets/javascripts/spree/backend/all.js',  "//= require spree/backend/dandify\n"
       end
 
       def add_stylesheets
-        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', "*= require spree/backend/dandify\n", before: /\*\//, verbose: true
+        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', "*= require spree/frontend/dandify\n ", before: /\*\//, verbose: true
+        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css',  "*= require spree/backend/dandify\n ",  before: /\*\//, verbose: true
+      end
+
+      def add_migrations
+        run 'bundle exec rake railties:install:migrations FROM=dandify'
       end
 
       def run_migrations
-        res = ask('Would you like to run the migrations now? [Y/n]').downcase
-        if ['', 'y'].include?(res)
-          run 'bundle exec rake db:migrate'
-        else
-          logger 'Skipping rake db:migrate, don\'t forget to run it!'
-        end
+        run 'bundle exec rake db:migrate'
       end
     end
   end

data/spec/controllers/spree/admin/stylesheets_controller_spec.rb

@@ -1,71 +1,125 @@
 require 'spec_helper'
 
-describe Spree::Admin::StylesheetsController do
-  stub_authorization!
+module Spree
+  module Admin
+    describe StylesheetsController, type: :controller do
+      stub_authorization!
 
-  let(:show_path) { spree.admin_stylesheets_path }
-  let(:good_style) { 'body {color:#ffff00;}' }
-  let(:bad_style) { 'body {color:#ffff00;' }
+      let(:show_path) { spree.admin_stylesheets_path }
+      let(:good_style) { 'body {color:#ffff00;}' }
+      let(:bad_style) { 'body {color:#ffff00;' }
 
-  before do
-    user = create :admin_user
-    controller.stub(try_spree_current_user: user)
-  end
+      before do
+        user = create :admin_user
+        controller.stub(try_spree_current_user: user)
+      end
 
-  context '#show' do
-    it 'assigns new instance when none is found' do
-       spree_get :show
-       expect(assigns[:style]).to be_new_record
-    end
+      describe 'GET #show' do
+        it 'assigns new instance when none is found' do
+          spree_get :show
 
-    it 'assigns existing' do
-      style = create :stylesheet
-      spree_get :show
-      expect(assigns[:style]).to eq style
-    end
-  end
+          expect(assigns[:style]).to be_new_record
+        end
 
-  context '#new' do
-    it 'can create first a revision' do
-      style = create :stylesheet
-      spree_get :show
-      expect(assigns[:style]).to eq style
-      expect(response).to render_template(:show)
-    end
+        it 'assigns existing' do
+          style = create :stylesheet
 
-    it 'can not create first revision because error' do
-      spree_post :create, stylesheet: { style_raw: bad_style }
-      expect(response).to render_template(:new)
-    end
-  end
+          spree_get :show
 
-  context '#edit' do
-    it 'can create a revision' do
-       create :stylesheet
-       spree_get :show
-       expect(response).to render_template(:show)
-    end
+          expect(assigns[:style]).to eq style
+        end
+      end
 
-    it 'can not create a revision because error' do
-      spree_post :update, stylesheet: { style_raw: bad_style }
-      expect(response).to render_template(:edit)
-    end
-  end
+      describe 'GET #new' do
+        it 'renders template' do
+          spree_get :new
 
-  context '#restore', versioning: true do
-    before { create :stylesheet }
+          expect(response).to render_template(:new)
+        end
+      end
 
-    it 'fails to reify when there is only one revision' do
-      spree_post :restore
-      expect(flash[:error]).to eq Spree.t('dandify.restore.error')
-      expect(response).to redirect_to show_path
-    end
+      describe 'POST #create' do
+        it 'redirects to show with good data' do
+          spree_post :create,
+                     stylesheet: { style_raw: '#main { display: inline; }' }
+
+          expect(response).to redirect_to(admin_stylesheets_path)
+        end
+
+        it 'renders new with bad data' do
+          spree_post :create, stylesheet: { style_raw: bad_style }
+
+          expect(response).to render_template(:new)
+        end
+      end
+
+      describe 'GET #edit' do
+        it 'can create a revision' do
+          stylesheet = create :stylesheet
+
+          spree_get :edit
+
+          expect(assigns[:style]).to eq stylesheet
+        end
+      end
+
+      describe 'PUT #update' do
+        before { create :stylesheet }
+
+        it 'redirects to show with good data' do
+          spree_post :update,
+                     stylesheet: { style_raw: '#main { display: inline; }' }
+
+          expect(response).to redirect_to(admin_stylesheets_path)
+        end
+
+        it 'renders edit with bad data' do
+          spree_post :update, stylesheet: { style_raw: bad_style }
+
+          expect(response).to render_template(:edit)
+        end
+      end
+
+      describe 'POST #restore', versioning: true do
+        before { create :stylesheet }
+
+        it 'fails to reify when there is only one revision' do
+          spree_post :restore
+
+          expect(flash[:error]).to eq(
+            Spree.t('dandify.admin.flash.error.restore')
+          )
+
+          expect(response).to redirect_to show_path
+        end
+
+        it 'able to reify when there is more than one revision' do
+          style = Spree::Stylesheet.first
+
+          style.update_attributes style_raw: '#main { display: block; }'
+          style.update_attributes style_raw: '#main { display: none; }'
+
+          spree_post :restore, id: PaperTrail::Version.second.id
+
+          expect(flash[:success]).to eq(
+            Spree.t('dandify.admin.flash.success.restore')
+          )
+          expect(response).to redirect_to show_path
+        end
+      end
+
+      describe 'DELETE #destroy' do
+        it 'sends #destroy to returned model from #first_or_initialize' do
+          fake_stylesheet = instance_double(Spree::Stylesheet, destroy: true)
+          allow(Spree::Stylesheet).to receive(:first_or_initialize).
+            and_return fake_stylesheet
+
+          spree_delete :destroy
 
-    it 'able to reify when there is more than one revision' do
-      spree_post :update, stylesheet: { style_raw: good_style }
-      spree_post :restore
-      expect(flash[:success]).to eq Spree.t('dandify.restore.success')
-      expect(response).to redirect_to show_path
+          expect(fake_stylesheet).to have_received(:destroy)
+          expect(response).to redirect_to admin_stylesheets_path
+        end
+      end
     end
   end
 end

data/spec/controllers/spree/stylesheets_controller_spec.rb

@@ -1,36 +1,40 @@
 require 'spec_helper'
 
-describe Spree::StylesheetsController, '#show' do
-  context 'with a bad format' do
-    it 'responds with blank sheet' do
-      spree_get :show, format: :xml
+module Spree
+  describe StylesheetsController, '#show', type: :controller do
+    stub_authorization!
 
-      expect(response.header['Content-Type']).to include 'text/css'
-    end
+    context 'with a bad format' do
+      it 'responds with blank sheet' do
+        spree_get :show, format: :xml
+
+        expect(response.header['Content-Type']).to include 'text/css'
+      end
 
-    it 'responds with found sheet' do
-      css = create(:stylesheet).style_compressed
-      spree_get :show, format: :atom
+      it 'responds with found sheet' do
+        css = create(:stylesheet).style_compressed
+        spree_get :show, format: :atom
 
-      expect(response.header['Content-Type']).to include 'text/css'
-      expect(assigns[:style].style_compressed).to eq css
+        expect(response.header['Content-Type']).to include 'text/css'
+        expect(assigns[:style].style_compressed).to eq css
+      end
     end
-  end
 
-  context 'when there is no stylesheet' do
-    it 'displays a blank stylesheet' do
-      spree_get :show, format: :css
+    context 'when there is no stylesheet' do
+      it 'displays a blank stylesheet' do
+        spree_get :show, format: :css
 
-      expect(assigns[:style]).to be_a Spree::BlankStylesheet
+        expect(assigns[:style]).to be_a Spree::BlankStylesheet
+      end
     end
-  end
 
-  context 'when there is a stylesheet' do
-    it 'assigns the stored sheet' do
-      create :stylesheet
-      spree_get :show, format: :css
+    context 'when there is a stylesheet' do
+      it 'assigns the stored sheet' do
+        create :stylesheet
+        spree_get :show, format: :css
 
-      expect(assigns[:style]).to be_a Spree::Stylesheet
+        expect(assigns[:style]).to be_a Spree::Stylesheet
+      end
     end
   end
 end

data/spec/features/buttons_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+feature 'Managing stylesheet' do
+  stub_authorization!
+
+  let(:show_path) { spree.admin_stylesheets_path }
+  let(:new_path)  { spree.new_admin_stylesheets_path }
+  let(:edit_path) { spree.edit_admin_stylesheets_path }
+
+  context 'create stylesheet link' do
+    it 'is available when there are no stylesheets' do
+      visit show_path
+
+      expect(page).to have_link(
+        Spree.t('dandify.admin.buttons.new'), href: new_path
+      )
+    end
+
+    it 'is not available when there are stylesheets' do
+      create(:stylesheet)
+
+      visit show_path
+
+      expect(page).to_not have_link(
+        Spree.t('dandify.admin.buttons.new'), href: new_path
+      )
+    end
+  end
+
+  context 'edit stylesheet link' do
+    it 'is not available when there are stylesheets' do
+      visit show_path
+
+      expect(page).to_not have_link(
+        Spree.t('dandify.admin.buttons.edit'), href: edit_path
+      )
+    end
+
+    it 'is available when there are stylesheets' do
+      create(:stylesheet)
+
+      visit show_path
+
+      expect(page).to have_link(
+        Spree.t('dandify.admin.buttons.edit'), href: edit_path
+      )
+    end
+  end
+
+  context 'cancel button' do
+    it 'is available on `new` page' do
+      visit new_path
+
+      expect(page).to have_link(Spree.t('actions.cancel'), href: show_path)
+    end
+
+    it 'is available on `edit` page' do
+      visit edit_path
+
+      expect(page).to have_link(Spree.t('actions.cancel'), href: show_path)
+    end
+
+    it 'is not available on listing page' do
+      visit show_path
+
+      expect(page).not_to have_link(Spree.t('actions.cancel'), href: show_path)
+    end
+  end
+end