currency_cloud 0.7.2 → 0.8.0

data/spec/integration/rates_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Rates', :vcr => true do
+describe 'Rates', vcr: true do
   before do
     CurrencyCloud.reset_session
     CurrencyCloud.environment = :demonstration

data/spec/integration/reference_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Reference', :vcr => true do
+describe 'Reference', vcr: true do
   before do
     CurrencyCloud.reset_session
     CurrencyCloud.environment = :demonstration
@@ -8,28 +8,28 @@ describe 'Reference', :vcr => true do
   end
 
   it 'can retrieve #beneficiary_required_details' do
-    details = CurrencyCloud::Reference.beneficiary_required_details(:currency => 'GBP', :bank_account_country => 'GB', :beneficiary_country => 'GB')
+    details = CurrencyCloud::Reference.beneficiary_required_details(currency: 'GBP', bank_account_country: 'GB', beneficiary_country: 'GB')
     expect(details).to_not be_empty
 
     details = details.first
     expect(details['payment_type']).to eq('priority')
-    expect(details["payment_type"]).to eq("priority")
-    expect(details["beneficiary_entity_type"]).to eq("individual")
-    expect(details["beneficiary_address"]).to eq("^.{1,255}")
-    expect(details["beneficiary_city"]).to eq("^.{1,255}")
-    expect(details["beneficiary_country"]).to eq("^[A-z]{2}$")
-    expect(details["beneficiary_first_name"]).to eq("^.{1,255}")
-    expect(details["beneficiary_last_name"]).to eq("^.{1,255}")
-    expect(details["acct_number"]).to eq("^[0-9A-Z]{1,50}$")
-    expect(details["sort_code"]).to eq("^\\d{6}$")
+    expect(details['payment_type']).to eq('priority')
+    expect(details['beneficiary_entity_type']).to eq('individual')
+    expect(details['beneficiary_address']).to eq('^.{1,255}')
+    expect(details['beneficiary_city']).to eq('^.{1,255}')
+    expect(details['beneficiary_country']).to eq('^[A-z]{2}$')
+    expect(details['beneficiary_first_name']).to eq('^.{1,255}')
+    expect(details['beneficiary_last_name']).to eq('^.{1,255}')
+    expect(details['acct_number']).to eq('^[0-9A-Z]{1,50}$')
+    expect(details['sort_code']).to eq('^\\d{6}$')
   end
 
   it 'can retrieve #conversion_dates' do
-    dates = CurrencyCloud::Reference.conversion_dates(:conversion_pair => 'GBPUSD')
+    dates = CurrencyCloud::Reference.conversion_dates(conversion_pair: 'GBPUSD')
 
     expect(dates.invalid_conversion_dates).to_not be_empty
     invalid_conversion_date = dates.invalid_conversion_dates.first
-    expect(invalid_conversion_date).to eq(["2015-05-02", "No trading on Saturday"])
+    expect(invalid_conversion_date).to eq(['2015-05-02', 'No trading on Saturday'])
     expect(dates.first_conversion_date).to eq('2015-04-30')
     expect(dates.default_conversion_date).to eq('2015-04-30')
   end
@@ -46,12 +46,12 @@ describe 'Reference', :vcr => true do
   end
 
   it 'can retrieve #settlement_accounts' do
-    settlement_accounts = CurrencyCloud::Reference.settlement_accounts(:currency => 'GBP')
+    settlement_accounts = CurrencyCloud::Reference.settlement_accounts(currency: 'GBP')
     expect(settlement_accounts).to_not be_empty
 
     settlement_account = settlement_accounts.first
     expect(settlement_account).to be_a_kind_of(CurrencyCloud::SettlementAccount)
-    expect(settlement_account.bank_account_holder_name).to eq("The Currency Cloud GBP - Client Seg A/C")
+    expect(settlement_account.bank_account_holder_name).to eq('The Currency Cloud GBP - Client Seg A/C')
     expect(settlement_account.bank_address).to be_empty
   end
 end

data/spec/integration/settlements_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Settlements', :vcr => true do
+describe 'Settlements', vcr: true do
   before(:all) do
     CurrencyCloud.reset_session
     CurrencyCloud.environment = :demonstration
@@ -14,7 +14,6 @@ describe 'Settlements', :vcr => true do
       reason: 'mortgage payment',
       term_agreement: true
     }
-
   end
 
   it 'can #add_conversion' do
@@ -25,20 +24,20 @@ describe 'Settlements', :vcr => true do
 
     expect(settlement).to eq(updated_settlement)
 
-    expect(settlement.conversion_ids).to eq( ["24d2ee7f-c7a3-4181-979e-9c58dbace992"])
+    expect(settlement.conversion_ids).to eq(['24d2ee7f-c7a3-4181-979e-9c58dbace992'])
     expect(settlement.entries).to_not be_empty
 
     gbp_currency = settlement.entries[0]
-    expect(gbp_currency).to include("GBP" => { "receive_amount" => "1000.00", "send_amount" => "0.00" })
+    expect(gbp_currency).to include('GBP' => { 'receive_amount' => '1000.00', 'send_amount' => '0.00' })
 
     usd_currency = settlement.entries[1]
-    expect(usd_currency).to include("USD" => { "receive_amount" => "0.00", "send_amount" => "1511.70" })
+    expect(usd_currency).to include('USD' => { 'receive_amount' => '0.00', 'send_amount' => '1511.70' })
 
     expect(settlement.updated_at).to eq('2015-05-04T20:40:56+00:00')
   end
 
   it 'can #remove_conversion' do
-    settlement = CurrencyCloud::Settlement.retrieve("63eeef54-3531-4e65-827a-7d0f37503fcc")
+    settlement = CurrencyCloud::Settlement.retrieve('63eeef54-3531-4e65-827a-7d0f37503fcc')
     deleted_settlement = settlement.remove_conversion('24d2ee7f-c7a3-4181-979e-9c58dbace992')
 
     expect(deleted_settlement).to_not be_nil
@@ -48,7 +47,7 @@ describe 'Settlements', :vcr => true do
   end
 
   it 'can #release' do
-    settlement = CurrencyCloud::Settlement.retrieve("51c619e0-0256-40ad-afba-ca4114b936f9")
+    settlement = CurrencyCloud::Settlement.retrieve('51c619e0-0256-40ad-afba-ca4114b936f9')
     released_settlement = settlement.release
 
     expect(released_settlement).to eq(settlement)
@@ -57,7 +56,7 @@ describe 'Settlements', :vcr => true do
   end
 
   it 'can #unrelease' do
-    settlement = CurrencyCloud::Settlement.retrieve("51c619e0-0256-40ad-afba-ca4114b936f9")
+    settlement = CurrencyCloud::Settlement.retrieve('51c619e0-0256-40ad-afba-ca4114b936f9')
     unreleased_settlement = settlement.unrelease
 
     expect(unreleased_settlement).to eq(settlement)

data/spec/spec_helper.rb

@@ -6,7 +6,7 @@ VCR.configure do |c|
   c.cassette_library_dir = 'spec/support/vcr_cassettes'
   c.configure_rspec_metadata!
   c.allow_http_connections_when_no_cassette = true
-  c.default_cassette_options = {:record => :new_episodes}
+  c.default_cassette_options = { record: :new_episodes }
 end
 
 require 'currency_cloud'

data/spec/support/vcr_cassettes/Actions/can_create.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/create
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/create
     body:
       encoding: UTF-8
       string: bank_account_holder_name=Test%20User&bank_country=GB&currency=GBP&name=Test%20User&account_number=12345678&routing_code_type_1=sort_code&routing_code_value_1=123456&payment_types[]=regular

data/spec/support/vcr_cassettes/Actions/can_current.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/accounts/current
+    uri: https://devapi.currencycloud.com/v2/accounts/current
     body:
       encoding: US-ASCII
       string: ''
@@ -31,7 +31,7 @@ http_interactions:
     body:
       encoding: UTF-8
       string: '{"id":"8ec3a69b-02d1-4f09-9a6b-6bd54a61b3a8","account_name":"Currency
-        Cloud","brand":"thecurrencycloud","your_reference":null,"status":"enabled","street":null,"city":null,"state_or_province":null,"country":null,"postal_code":null,"spread_table":"fxcg_rfx_default","legal_entity_type":null,"created_at":"2015-04-24T15:57:55+00:00","updated_at":"2015-04-24T15:57:55+00:00","identification_type":null,"identification_value":null,"short_reference":"150424-00002"}'
+        Cloud","brand":"currencycloud","your_reference":null,"status":"enabled","street":null,"city":null,"state_or_province":null,"country":null,"postal_code":null,"spread_table":"fxcg_rfx_default","legal_entity_type":null,"created_at":"2015-04-24T15:57:55+00:00","updated_at":"2015-04-24T15:57:55+00:00","identification_type":null,"identification_value":null,"short_reference":"150424-00002"}'
     http_version: 
   recorded_at: Mon, 27 Apr 2015 21:52:17 GMT
 recorded_with: VCR 2.9.3

data/spec/support/vcr_cassettes/Actions/can_delete.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c/delete
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c/delete
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Actions/can_find.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/find
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/find
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Actions/can_first.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/find?bank_account_holder_name=Test%20User&per_page=1
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/find?bank_account_holder_name=Test%20User&per_page=1
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Actions/can_retrieve.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Actions/can_update.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c
     body:
       encoding: UTF-8
       string: bank_account_holder_name=Test%20User%202

data/spec/support/vcr_cassettes/Actions/can_use_currency_to_retrieve_balance.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/balances/GBP
+    uri: https://devapi.currencycloud.com/v2/balances/GBP
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Actions/can_validate_beneficiaries.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/validate
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/validate
     body:
       encoding: UTF-8
       string: bank_country=GB&currency=GBP&account_number=12345678&routing_code_type_1=sort_code&routing_code_value_1=123456&payment_types[]=regular

data/spec/support/vcr_cassettes/Authentication/can_be_closed.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=rjnienaber%40gmail.com&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0
@@ -33,7 +33,7 @@ http_interactions:
   recorded_at: Fri, 24 Apr 2015 22:17:33 GMT
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/close_session
+    uri: https://devapi.currencycloud.com/v2/authenticate/close_session
     body:
       encoding: UTF-8
       string: ''

data/spec/support/vcr_cassettes/Authentication/can_use_just_a_token.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/find
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/find
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Authentication/handles_session_timeout_error.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/find
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/find
     body:
       encoding: US-ASCII
       string: ''
@@ -36,7 +36,7 @@ http_interactions:
   recorded_at: Sat, 25 Apr 2015 06:32:32 GMT
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=rjnienaber%40gmail.com&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0
@@ -67,7 +67,7 @@ http_interactions:
   recorded_at: Sat, 25 Apr 2015 06:32:32 GMT
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/find
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/find
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Authentication/happens_lazily.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=rjnienaber%40gmail.com&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0

data/spec/support/vcr_cassettes/Error/contains_full_details_for_api_error.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=non-existent-login-id&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb57528f0

data/spec/support/vcr_cassettes/Error/is_raised_on_a_bad_request.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: US-ASCII
       string: login_id=non-existent-login-id&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb57528f0

data/spec/support/vcr_cassettes/Error/is_raised_on_a_forbidden_request.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=rjnienaber%40gmail.com&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0

data/spec/support/vcr_cassettes/Error/is_raised_on_an_internal_server_error.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=rjnienaber%40gmail.com&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0

data/spec/support/vcr_cassettes/Error/is_raised_on_incorrect_authentication_details.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: US-ASCII
       string: login_id=non-existent-login-id&api_key=efb5ae2af84978b7a37f18dd61c8bbe139b403009faea83484405a3dcb64c4d8

data/spec/support/vcr_cassettes/Error/is_raised_when_a_resource_is_not_found.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c
+    uri: https://devapi.currencycloud.com/v2/beneficiaries/081596c9-02de-483e-9f2a-4cf55dcdf98c
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Error/is_raised_when_too_many_requests_have_been_issued.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/authenticate/api
+    uri: https://devapi.currencycloud.com/v2/authenticate/api
     body:
       encoding: UTF-8
       string: login_id=rjnienaber%40gmail.com2&api_key=ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0

data/spec/support/vcr_cassettes/Rates/can_find.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/rates/find?currency_pair=GBPUSD,EURGBP
+    uri: https://devapi.currencycloud.com/v2/rates/find?currency_pair=GBPUSD,EURGBP
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Rates/can_provided_detailed_rate.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/rates/detailed?amount=10000&buy_currency=GBP&fixed_side=buy&sell_currency=USD
+    uri: https://devapi.currencycloud.com/v2/rates/detailed?amount=10000&buy_currency=GBP&fixed_side=buy&sell_currency=USD
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Reference/can_retrieve_beneficiary_required_details.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/reference/beneficiary_required_details?bank_account_country=GB&beneficiary_country=GB&currency=GBP
+    uri: https://devapi.currencycloud.com/v2/reference/beneficiary_required_details?bank_account_country=GB&beneficiary_country=GB&currency=GBP
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Reference/can_retrieve_conversion_dates.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/reference/conversion_dates?conversion_pair=GBPUSD
+    uri: https://devapi.currencycloud.com/v2/reference/conversion_dates?conversion_pair=GBPUSD
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Reference/can_retrieve_currencies.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/reference/currencies
+    uri: https://devapi.currencycloud.com/v2/reference/currencies
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Reference/can_retrieve_settlement_accounts.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://devapi.thecurrencycloud.com/v2/reference/settlement_accounts?currency=GBP
+    uri: https://devapi.currencycloud.com/v2/reference/settlement_accounts?currency=GBP
     body:
       encoding: US-ASCII
       string: ''

data/spec/support/vcr_cassettes/Settlements/can_add_conversion.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/conversions/create
+    uri: https://devapi.currencycloud.com/v2/conversions/create
     body:
       encoding: UTF-8
       string: buy_currency=GBP&sell_currency=USD&fixed_side=buy&amount=1000&reason=mortgage%20payment&term_agreement=true
@@ -35,7 +35,7 @@ http_interactions:
   recorded_at: Mon, 04 May 2015 20:28:29 GMT
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/settlements/create
+    uri: https://devapi.currencycloud.com/v2/settlements/create
     body:
       encoding: US-ASCII
       string: ''
@@ -68,7 +68,7 @@ http_interactions:
   recorded_at: Mon, 04 May 2015 20:29:16 GMT
 - request:
     method: post
-    uri: https://devapi.thecurrencycloud.com/v2/settlements/63eeef54-3531-4e65-827a-7d0f37503fcc/add_conversion
+    uri: https://devapi.currencycloud.com/v2/settlements/63eeef54-3531-4e65-827a-7d0f37503fcc/add_conversion
     body:
       encoding: UTF-8
       string: conversion_id=24d2ee7f-c7a3-4181-979e-9c58dbace992