currency_cloud 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56244f4c79912b074416b099f75d2d8b6b64fae8
-  data.tar.gz: 9e0a5976808d20873f383eface2acecb96a17554
+  metadata.gz: d03914430ce3008c972006bfdce468cc9d5247c4
+  data.tar.gz: 45a61b8743f130d88c690db610532deefec3e65c
 SHA512:
-  metadata.gz: 8a46e98ba3b1f58a7ea720d6637fd90f9d000b898365fa47328b923d527ac1ff8ab164a326008489889e4d9ac7196a47365446e3e8cd1001fb7875358a909237
-  data.tar.gz: 6d22fdca021e1c1eded5def2e69ae701fa77bdbf9b4c68ff0e2cf723203fbe6437b91e8b4d4d27b8f064e14a1d60f4d70db7e1f54cf7796ceefca9b999efe0d6
+  metadata.gz: 9fdf242df295a23bc62137212cc3ee8fed27806be15d0c20a50c1ba6b77c09f86bbeb368e1cd4793ac42df96ec6f50232a568ca13e0968943d26c8f8759c86b0
+  data.tar.gz: becd764f0a82a9582411705245d3699b5ca501a372f813618aeff8c7b2d98837a7b2ba43241db74bdccf093c17255b4ef73c0c127ce36537473ec4389e7c32a0

data/.rubocop.yml

@@ -0,0 +1,5 @@
+Metrics/LineLength:
+  Max: 120
+
+Style/Documentation:
+  Enabled: false

data/.travis.yml

@@ -1,3 +1,4 @@
+dist: trusty
 language: ruby
 script: bundle exec rspec
 cache: bundler
@@ -7,6 +8,8 @@ rvm:
   - 2.0.0
   - 2.1
   - 2.2
+  - 2.3.4
+  - 2.4.1
   - jruby-19mode
-  - jruby-head
-  - rbx-2
+  - jruby-9.1.5.0 
+  - rbx-3.74

data/Gemfile

@@ -2,5 +2,6 @@ source 'https://rubygems.org'
 
 gem 'sinatra'
 gem 'guard-rspec', require: false
+gem 'guard', '2.12.6'
 
 gemspec

data/README.md

@@ -1,9 +1,9 @@
 [![Gem Version](https://badge.fury.io/rb/currency_cloud.svg)](http://badge.fury.io/rb/currency_cloud) [![Build Status](https://travis-ci.org/CurrencyCloud/currencycloud-ruby.png?branch=master)](https://travis-ci.org/CurrencyCloud/currencycloud-ruby)
 
-# Currency Cloud
+# Currencycloud
 
-This is the official Ruby SDK for v2 of Currency Cloud's API. Additional documentation
-for each API endpoint can be found at [connect.currencycloud.com][connect]. If you have any queries or you require support, please contact our implementation team at implementation@currencycloud.com.
+This is the official Ruby SDK for v2 of Currencycloud's API. Additional documentation
+for each API endpoint can be found at [developer.currencycloud.com][developer]. If you have any queries or you require support, please contact our sales team at sales@currencycloud.com.
 
 ## Installation
 
@@ -93,7 +93,7 @@ request:
     login_id: non-existent-login-id
     api_key: ef0fd50fca1fb14c1fab3a8436b9ecb57528f0
   verb: post
-  url: https://devapi.thecurrencycloud.com/v2/authenticate/api
+  url: https://devapi.currencycloud.com/v2/authenticate/api
 response:
   status_code: 400
   date: Wed, 29 Apr 2015 22:46:53 GMT
@@ -121,7 +121,7 @@ The final section contains valuable information:
 - Message: A human readable message that explains the error
 - Params: A hash that contains dynamic parts of the error message for building custom error messages
 
-When troubleshooting API calls with Currency Cloud support, including the full
+When troubleshooting API calls with Currencycloud support, including the full
 error in any correspondence can be very helpful.
 
 # Development
@@ -141,9 +141,9 @@ to be backwards compatible.
 
 # Copyright
 
-Copyright (c) 2015 Currency Cloud. See [LICENSE][license] for details.
+Copyright (c) 2016 Currencycloud. See [LICENSE][license] for details.
 
-[connect]:   https://connect.currencycloud.com/documentation/getting-started/introduction
+[developer]: https://developer.currencycloud.com/documentation/getting-started/introduction/
 [travis]:    https://travis-ci.org/CurrencyCloud/currencycloud-ruby
 [jruby]:     http://jruby.org/
 [rubinius]:  http://rubini.us/

data/currency_cloud.gemspec

@@ -20,6 +20,7 @@ spec = Gem::Specification.new do |s|
   s.add_development_dependency('rake', '~> 10.3')
   s.add_development_dependency('webmock', '~> 1.21')
   s.add_development_dependency('vcr', '~> 2.9')
+  s.add_development_dependency('addressable', '<= 2.4.0')
 
   s.files = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- spec/*`.split("\n")

data/lib/currency_cloud.rb

@@ -5,7 +5,7 @@ require 'json'
 require 'currency_cloud/resource'
 require 'currency_cloud/errors/error_utils'
 lib_path = File.join(File.dirname(__FILE__), '**/*.*')
-Dir[lib_path].sort.each { |f| require f}
+Dir[lib_path].sort.each { |f| require f }
 
 module CurrencyCloud
   UUID_REGEX = /[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/i

data/lib/currency_cloud/actions.rb

@@ -1,11 +1,11 @@
-require_relative "actions/create"
-require_relative "actions/current"
-require_relative "actions/delete"
-require_relative "actions/find"
-require_relative "actions/instance_delete"
-require_relative "actions/retrieve"
-require_relative "actions/save"
-require_relative "actions/update"
+require_relative 'actions/create'
+require_relative 'actions/current'
+require_relative 'actions/delete'
+require_relative 'actions/find'
+require_relative 'actions/instance_delete'
+require_relative 'actions/retrieve'
+require_relative 'actions/save'
+require_relative 'actions/update'
 
 module CurrencyCloud
   module Actions

data/lib/currency_cloud/actions/create.rb

@@ -2,7 +2,7 @@ module CurrencyCloud
   module Actions
     module Create
       def create(params = {})
-        attrs = client.post("create", params)
+        attrs = client.post('create', params)
         new(attrs)
       end
     end

data/lib/currency_cloud/actions/current.rb

@@ -2,7 +2,7 @@ module CurrencyCloud
   module Actions
     module Current
       def current
-        attrs = client.get("current")
+        attrs = client.get('current')
         new(attrs)
       end
     end

data/lib/currency_cloud/actions/find.rb

@@ -1,24 +1,23 @@
 module CurrencyCloud
   module Actions
-
     module Find
-
-      def find(params={})
-        response = client.get("find", params)
-        mixin_class.new(self.resource, self, response)
+      def find(params = {})
+        response = client.get('find', params)
+        mixin_class.new(resource, self, response)
       end
 
-      def first(params={})
+      def first(params = {})
         entities = find(params.merge(per_page: 1)) || []
         entities.first
       end
 
       private
+
       def mixin_class
-        unless CurrencyCloud.const_defined?(self.resource.capitalize)
-          CurrencyCloud.const_set(self.resource.capitalize, Class.new(CurrencyCloud::ResourcefulCollection))
+        unless CurrencyCloud.const_defined?(resource.capitalize)
+          CurrencyCloud.const_set(resource.capitalize, Class.new(CurrencyCloud::ResourcefulCollection))
         end
-        CurrencyCloud.const_get(self.resource.capitalize)
+        CurrencyCloud.const_get(resource.capitalize)
       end
     end
   end

data/lib/currency_cloud/actions/update.rb

@@ -8,7 +8,7 @@ module CurrencyCloud
       # TODO: Add .save instance method, which calls update on changed attributes
 
       def update(id, params)
-        attrs = client.post("#{id}", params)
+        attrs = client.post(id.to_s, params)
         new(attrs)
       end
     end

data/lib/currency_cloud/beneficiary.rb

@@ -6,7 +6,7 @@ module CurrencyCloud
     actions :create, :retrieve, :find, :update, :delete
 
     def self.validate(params)
-      new(client.post("validate", params))
+      new(client.post('validate', params))
     end
   end
 end

data/lib/currency_cloud/client.rb

@@ -4,11 +4,11 @@ module CurrencyCloud
       @resource = resource
     end
 
-    def get(url, params={})
+    def get(url, params = {})
       request.get(build_url(url), params)
     end
 
-    def post(url, params={})
+    def post(url, params = {})
       request.post(build_url(url), params)
     end
 

data/lib/currency_cloud/errors/api_error.rb

@@ -1,6 +1,5 @@
 module CurrencyCloud
   class ApiErrorMessage
-
     attr_reader :field, :code, :message, :params
 
     def initialize(field, error)
@@ -45,7 +44,7 @@ module CurrencyCloud
     def to_s
       class_name = super
 
-      string_params = Hash[@params.map { |k, v| [k.to_s, v.to_s]}]
+      string_params = Hash[@params.map { |k, v| [k.to_s, v.to_s] }]
 
       error_details = {
         'platform' => platform,
@@ -71,4 +70,4 @@ module CurrencyCloud
   class TooManyRequestsError < ApiError; end
   class InternalApplicationError < ApiError; end
   class NotFoundError < ApiError; end
-end
+end

data/lib/currency_cloud/errors/error_utils.rb

@@ -11,4 +11,4 @@ module CurrencyCloud
       "#{base}#{implementation}"
     end
   end
-end
+end

data/lib/currency_cloud/errors/general_error.rb

@@ -1,5 +1,3 @@
 module CurrencyCloud
-
   class GeneralError < StandardError; end
-
-end
+end

data/lib/currency_cloud/errors/unexpected_error.rb

@@ -1,5 +1,4 @@
 module CurrencyCloud
-  
   class UnexpectedError < StandardError
     include ErrorUtils
 
@@ -15,7 +14,7 @@ module CurrencyCloud
     def to_s
       class_name = super
 
-      string_params = Hash[@params.map { |k, v| [k.to_s, v.to_s]}]
+      string_params = Hash[@params.map { |k, v| [k.to_s, v.to_s] }]
 
       error_details = {
         'platform' => platform,
@@ -28,5 +27,5 @@ module CurrencyCloud
       }
       "#{class_name}#{$/}#{YAML.dump(error_details)}"
     end
-  end   
-end
+  end
+end

data/lib/currency_cloud/rate.rb

@@ -5,17 +5,17 @@ module CurrencyCloud
     resource :rates
 
     def self.find(params)
-      response = client.get("find", params)
+      response = client.get('find', params)
 
-      rates = response["rates"].map do |currency_pair, (bid, offer)|
+      rates = response['rates'].map do |currency_pair, (bid, offer)|
         new(currency_pair: currency_pair, bid: bid, offer: offer)
       end
 
-      Rates.new(currencies: rates, unavailable: response["unavailable"])
+      Rates.new(currencies: rates, unavailable: response['unavailable'])
     end
 
     def self.detailed(params)
-      new(client.get("detailed", params))
+      new(client.get('detailed', params))
     end
   end
 end

data/lib/currency_cloud/reference.rb

@@ -5,21 +5,21 @@ module CurrencyCloud
     resource :reference
 
     def self.currencies
-      response = client.get("currencies")
-      response['currencies'].map { |c| Currency.new(c)}
+      response = client.get('currencies')
+      response['currencies'].map { |c| Currency.new(c) }
     end
 
-    def self.beneficiary_required_details(params={})
-      client.get("beneficiary_required_details", params)["details"]
+    def self.beneficiary_required_details(params = {})
+      client.get('beneficiary_required_details', params)['details']
     end
 
     def self.conversion_dates(params)
-      dates = client.get("conversion_dates", params)
+      dates = client.get('conversion_dates', params)
       ConversionDates.new(dates)
     end
 
-    def self.settlement_accounts(params={})
-      response = client.get("settlement_accounts", params)
+    def self.settlement_accounts(params = {})
+      response = client.get('settlement_accounts', params)
       response['settlement_accounts'].map { |s| SettlementAccount.new(s) }
     end
   end

data/lib/currency_cloud/request_handler.rb

@@ -6,16 +6,16 @@ module CurrencyCloud
       @session = session
     end
 
-    def get(route, params={}, opts={})
-      retry_authenticate('get', route, params, opts) do |url, params, options|
-        options.merge!(:query => params)
+    def get(route, params = {}, opts = {})
+      retry_authenticate('get', route, params, opts) do |url, new_params, options|
+        options[:query] = new_params
         HTTParty.get(url, options)
       end
     end
 
-    def post(route, params={}, opts={})
-      retry_authenticate('post', route, params, opts) do |url, params, options|
-        options.merge!(:body => params)
+    def post(route, params = {}, opts = {})
+      retry_authenticate('post', route, params, opts) do |url, new_params, options|
+        options[:body] = new_params
         HTTParty.post(url, options)
       end
     end
@@ -31,7 +31,7 @@ module CurrencyCloud
       response = nil
       retry_count = should_retry ? 0 : 2
       while retry_count < 3
-        options = process_options(verb, opts)
+        options = process_options(opts)
         response = yield(full_url, params, options)
         break unless response.code == 401 && should_retry
         session.reauthenticate
@@ -46,8 +46,8 @@ module CurrencyCloud
       raise UnexpectedError.new(verb, full_url, params, e)
     end
 
-    def process_options(verb, opts)
-      options = {:headers => headers }
+    def process_options(opts)
+      options = { headers: headers }
       # options[:debug_output] = $stdout
       options.merge(opts)
       # options
@@ -55,7 +55,7 @@ module CurrencyCloud
 
     def process_params(params)
       if session && session.on_behalf_of && CurrencyCloud::UUID_REGEX.match(session.on_behalf_of)
-        params.merge!(on_behalf_of: session.on_behalf_of)
+        params[:on_behalf_of] = session.on_behalf_of
       end
 
       params

data/lib/currency_cloud/resource.rb

@@ -1,5 +1,5 @@
-require "set"
-require_relative "./actions"
+require 'set'
+require_relative './actions'
 
 module CurrencyCloud
   module Resource
@@ -12,11 +12,11 @@ module CurrencyCloud
     def initialize(attributes)
       @attributes = attributes
       @changed_attributes = Set.new
-      set_accessors(valid_attributes)
+      self.accessors = valid_attributes
     end
 
     def inspect
-      "#<#{self.class}:0x#{self.object_id.to_s(16)} #{@attributes.inspect}>"
+      "#<#{self.class}:0x#{object_id.to_s(16)} #{@attributes.inspect}>"
     end
 
     private
@@ -47,7 +47,7 @@ module CurrencyCloud
       class << self; self; end
     end
 
-    def set_accessors(attributes)
+    def accessors=(attributes)
       metaclass.instance_eval do
         attributes.each do |attribute|
           define_method(attribute) { @attributes[attribute] }
@@ -66,9 +66,9 @@ module CurrencyCloud
 
       def actions(*actions)
         actions.each do |action|
-          self.class_eval do
+          class_eval do
             action_module = CurrencyCloud::Actions.const_get(action.to_s.capitalize)
-            self.extend(action_module)
+            extend(action_module)
           end
         end
       end

data/lib/currency_cloud/resourceful_collection.rb

@@ -1,7 +1,7 @@
 module CurrencyCloud
   class ResourcefulCollection
     include Enumerable
-    
+
     extend Forwardable
     def_delegators :@collection, :[], :length, :empty?, :each
 
@@ -11,5 +11,5 @@ module CurrencyCloud
       @collection = collection[resource.to_s].map { |object| klass.new(object) }
       @pagination = Pagination.new(collection['pagination'])
     end
-  end  
-end
+  end
+end

data/lib/currency_cloud/response_handler.rb

@@ -10,11 +10,8 @@ module CurrencyCloud
     end
 
     def process
-      if success?
-        return parsed_response
-      else
-        handle_failure
-      end
+      return parsed_response if success?
+      handle_failure
     end
 
     private