curb 0.8.5 → 1.3.6

data/ext/extconf.rb

@@ -1,4 +1,10 @@
 require 'mkmf'
+require 'tmpdir'
+begin
+  require 'etc'
+rescue LoadError
+  # Etc may not be available on all Ruby builds (very rare). Fallback later.
+end
 
 dir_config('curl')
 
@@ -9,7 +15,7 @@ if find_executable('curl-config')
   else
     $LIBS << " #{`curl-config --libs`.strip}"
   end
-  ca_bundle_path=`curl-config --ca`.strip
+  ca_bundle_path=`curl-config --ca`.strip.gsub(/^"([^"]+)"$/,'\1')
   if !ca_bundle_path.nil? and ca_bundle_path != ''
     $defs.push( %{-D HAVE_CURL_CONFIG_CA} )
     $defs.push( %{-D CURL_CONFIG_CA='#{ca_bundle_path.inspect}'} )
@@ -18,6 +24,8 @@ elsif !have_library('curl') or !have_header('curl/curl.h')
   fail <<-EOM
   Can't find libcurl or curl/curl.h
 
+  Make sure development libs (ie libcurl4-openssl-dev) are installed on the system.
+
   Try passing --with-curl-dir or --with-curl-lib and --with-curl-include
   options to extconf.
   EOM
@@ -35,30 +43,202 @@ end
 #  puts "Selected arch: #{archs.first}"
 #end
 
-def define(s, v=1)
-  $defs.push( format("-D HAVE_%s=%d", s.to_s.upcase, v) )
+def define(s, v = 1)
+  $defs.push(format("-D HAVE_%s=%d", s.to_s.upcase, v))
 end
 
-def have_constant(name)
-  sname = name.is_a?(Symbol) ? name.to_s : name.upcase
-  checking_for name do
-    src = %{
-      #include <curl/curl.h>
-      int main() {
-        int test = (int)#{sname};
-        return 0;
-      }
+# Optional parallelization support for constant checks only.
+# Enable automatically when job hints are present (JOBS, BUNDLE_JOBS, MAKEFLAGS -jN),
+# or explicitly via EXTCONF_JOBS/EXTCONF_PARALLEL.
+
+def parse_jobs_from_makeflags(flags)
+  return nil if flags.nil? || flags.empty?
+  tokens = flags.to_s.split(/\s+/)
+  jobs = nil
+  tokens.each_with_index do |tok, i|
+    case tok
+    when /\A-j(\d+)\z/
+      jobs = $1.to_i
+    when '-j'
+      nxt = tokens[i + 1]
+      jobs = nxt.to_i if nxt && nxt =~ /\A\d+\z/
+    when /\A--jobs(?:=(\d+)|\s+(\d+))\z/
+      jobs = ($1 || $2).to_i
+    when /\Aj(\d+)\z/ # sometimes make condenses flags
+      jobs = $1.to_i
+    end
+    break if jobs && jobs > 0
+  end
+  jobs
+end
+
+def detect_job_hints
+  # Priority: explicit extconf hint, then common envs used by bundler/rubygems
+  [
+    ENV['EXTCONF_JOBS'],
+    ENV['JOBS'],
+    ENV['BUNDLE_JOBS'],
+    parse_jobs_from_makeflags(ENV['MAKEFLAGS'])
+  ].each do |v|
+    n = v.to_i if v
+    return n if n && n > 0
+  end
+  nil
+end
+
+explicit_parallel = ENV.key?('EXTCONF_PARALLEL') && ENV['EXTCONF_PARALLEL'] == '1'
+job_hints = detect_job_hints
+
+DEFAULT_PARALLEL_JOBS = begin
+  n = Etc.respond_to?(:nprocessors) ? Etc.nprocessors.to_i : 1
+  n = 1 if n <= 0
+  # Use half the CPUs by default (rounded up), but at least 1
+  jobs = [(n.to_f / 2).ceil, 1].max
+  jobs
+rescue
+  1
+end
+
+PARALLEL_JOBS = begin
+  if job_hints && job_hints > 0
+    job_hints
+  else
+    # If no hints provided, default to half the CPUs.
+    DEFAULT_PARALLEL_JOBS
+  end
+end
+
+# Only enable if the platform supports fork. On Windows this stays sequential.
+PARALLEL_CONSTANT_CHECKS = PARALLEL_JOBS > 1 && Process.respond_to?(:fork)
+
+$queued_constants = []
+
+def try_constant_compile(sname)
+  src = %{
+    #include <curl/curl.h>
+    int main() {
+      int test = (int)#{sname};
+      (void)test;
+      return 0;
     }
-    if try_compile(src,"#{$CFLAGS} #{$LIBS}")
-      define name
-      true
-    else
-      #define name, 0
-      false
+  }
+  try_compile(src, "#{$CFLAGS} #{$LIBS}")
+end
+
+def have_constant(name)
+  # Queue constants for optional parallel probing. Falls back to sequential.
+  if PARALLEL_CONSTANT_CHECKS
+    $queued_constants << name
+    true
+  else
+    sname = name.is_a?(Symbol) ? name.to_s : name.upcase
+    checking_for name do
+      if try_constant_compile(sname)
+        define name
+        true
+      else
+        false
+      end
     end
   end
 end
 
+def flush_constant_checks
+  return if $queued_constants.empty?
+
+  constants = $queued_constants.uniq
+  $queued_constants.clear
+
+  # On platforms without fork (e.g., Windows), run sequentially.
+  unless PARALLEL_CONSTANT_CHECKS
+    constants.each { |name| have_constant(name) }
+    return
+  end
+
+  # Run constant probes in isolated child processes to avoid mkmf
+  # scratch file and logfile contention.
+  results = {}
+  pending = constants.dup
+  running = {}
+  max_jobs = PARALLEL_JOBS
+
+  spawn_probe = lambda do |const_name|
+    r, w = IO.pipe
+    pid = fork do
+      begin
+        r.close
+        Dir.mktmpdir('curb-mkmf-') do |dir|
+          Dir.chdir(dir) do
+            begin
+              # Avoid clobbering the main mkmf.log
+              Logging::logfile = File.open(File::NULL, 'w') rescue File.open(File.join(dir, 'mkmf.log'), 'w')
+            rescue
+              # best-effort
+            end
+            sname = const_name.is_a?(Symbol) ? const_name.to_s : const_name.upcase
+            ok = try_constant_compile(sname)
+            w.write([const_name, ok ? 1 : 0].join("\t"))
+          end
+        end
+      rescue
+        # Treat as failure if anything unexpected happens in child
+        begin
+          w.write([const_name, 0].join("\t"))
+        rescue
+        end
+      ensure
+        begin w.close rescue nil end
+        # Ensure the child exits without running at_exit handlers
+        exit! 0
+      end
+    end
+    w.close
+    running[pid] = r
+  end
+
+  # Start initial batch
+  while running.size < max_jobs && !pending.empty?
+    spawn_probe.call(pending.shift)
+  end
+
+  # Collect results and keep spawning until done
+  until running.empty?
+    pid = Process.wait
+    io = running.delete(pid)
+    if io
+      begin
+        msg = io.read.to_s
+        name_str, ok_str = msg.split("\t", 2)
+        if name_str
+          # Map back to the original object if symbol-like
+          original = constants.find { |n| n.to_s == name_str }
+          results[original || name_str] = ok_str.to_i == 1
+        end
+      ensure
+        begin io.close rescue nil end
+      end
+    end
+    # Fill next task slot
+    spawn_probe.call(pending.shift) unless pending.empty?
+  end
+
+  # Apply results to $defs and output summary via checking_for
+  results.each do |const_name, ok|
+    sname = const_name.is_a?(Symbol) ? const_name.to_s : const_name.upcase
+    checking_for const_name do
+      if ok
+        define const_name
+        true
+      else
+        false
+      end
+    end
+  end
+end
+
+have_constant "curlopt_tcp_keepalive"
+have_constant "curlopt_tcp_keepidle"
+have_constant "curlopt_tcp_keepintvl"
 have_constant "curlinfo_appconnect_time"
 have_constant "curlinfo_redirect_time"
 have_constant "curlinfo_response_code"
@@ -66,6 +246,7 @@ have_constant "curlinfo_filetime"
 have_constant "curlinfo_redirect_count"
 have_constant "curlinfo_os_errno"
 have_constant "curlinfo_num_connects"
+have_constant "curlinfo_cookielist"
 have_constant "curlinfo_ftp_entry_path"
 have_constant "curl_version_ssl"
 have_constant "curl_version_libz"
@@ -78,9 +259,12 @@ have_constant "curl_version_largefile"
 have_constant "curl_version_idn"
 have_constant "curl_version_sspi"
 have_constant "curl_version_conv"
+have_constant "curl_version_http2"
 have_constant "curlproxy_http"
 have_constant "curlproxy_socks4"
+have_constant "curlproxy_socks4a"
 have_constant "curlproxy_socks5"
+have_constant "curlproxy_socks5_hostname"
 have_constant "curlauth_basic"
 have_constant "curlauth_digest"
 have_constant "curlauth_gssnegotiate"
@@ -99,6 +283,12 @@ have_constant "curle_send_fail_rewind"
 have_constant "curle_ssl_engine_initfailed"
 have_constant "curle_login_denied"
 
+# older than 7.10.0
+have_constant "curlopt_nosignal"
+
+# older than 7.16.0
+have_constant "curlmopt_pipelining"
+
 # older than 7.16.3
 have_constant "curlmopt_maxconnects"
 
@@ -108,6 +298,40 @@ have_constant "curlopt_sockoptfunction"
 have_constant "curlopt_sockoptdata"
 have_constant "curlopt_opensocketfunction"
 have_constant "curlopt_opensocketdata"
+have_constant "curlopt_prereqfunction"
+have_constant "curlopt_prereqdata"
+
+# Deprecated constants (still check for them for backward compat)
+have_constant "curlopt_ioctlfunction"
+have_constant "curlopt_ioctldata"
+have_constant "curlopt_progressfunction"
+have_constant "curlopt_progressdata"
+have_constant "curlopt_conv_to_network_function"
+have_constant "curlopt_conv_from_network_function"
+have_constant "curlopt_conv_from_utf8_function"
+
+# Replacements for deprecated constants
+# CURLOPT_PROGRESSFUNCTION -> CURLOPT_XFERINFOFUNCTION (since 7.32.0)
+have_constant "curlopt_xferinfofunction"
+have_constant "curlopt_xferinfodata"
+
+# CURLOPT_PROTOCOLS -> CURLOPT_PROTOCOLS_STR (since 7.85.0)
+have_constant "curlopt_protocols_str"
+have_constant "curlopt_redir_protocols_str"
+
+# CURLOPT_SOCKS5_GSSAPI_SERVICE -> CURLOPT_PROXY_SERVICE_NAME (since 7.49.0)
+have_constant "curlopt_proxy_service_name"
+
+# CURLOPT_HTTPPOST -> CURLOPT_MIMEPOST (since 7.56.0)
+have_constant "curlopt_mimepost"
+
+# CURLINFO_* -> CURLINFO_*_T (since 7.55.0)
+have_constant "curlinfo_size_upload_t"
+have_constant "curlinfo_size_download_t"
+have_constant "curlinfo_speed_upload_t"
+have_constant "curlinfo_speed_download_t"
+have_constant "curlinfo_content_length_download_t"
+have_constant "curlinfo_content_length_upload_t"
 
 # additional consts
 have_constant "curle_conv_failed"
@@ -143,6 +367,8 @@ have_func("curl_multi_timeout")
 have_func("curl_multi_fdset")
 have_func("curl_multi_perform")
 
+have_constant "curlopt_haproxyprotocol"
+
 # constants
 have_constant "curlopt_interleavefunction"
 have_constant "curlopt_interleavedata"
@@ -167,6 +393,7 @@ have_constant "curlopt_socks5_gssapi_nec"
 have_constant "curlopt_interface"
 have_constant "curlopt_localport"
 have_constant "curlopt_dns_cache_timeout"
+have_constant "curlopt_dns_servers"
 have_constant "curlopt_dns_use_global_cache"
 have_constant "curlopt_buffersize"
 have_constant "curlopt_port"
@@ -207,6 +434,7 @@ have_constant "curlopt_httppost"
 have_constant "curlopt_referer"
 have_constant "curlopt_useragent"
 have_constant "curlopt_httpheader"
+have_constant "curlopt_proxyheader"
 have_constant "curlopt_http200aliases"
 have_constant "curlopt_cookie"
 have_constant "curlopt_cookiefile"
@@ -306,7 +534,9 @@ have_constant "curlusessl_none"
 have_constant "curlusessl_try"
 have_constant "curlusessl_control"
 have_constant "curlusessl_all"
+have_constant "curlopt_connect_to"
 have_constant "curlopt_resolve"
+have_constant "curlopt_request_target"
 have_constant "curlopt_sslcert"
 have_constant "curlopt_sslcerttype"
 have_constant "curlopt_sslkey"
@@ -319,7 +549,23 @@ have_constant "curl_sslversion_default"
 have_constant :CURL_SSLVERSION_TLSv1
 have_constant :CURL_SSLVERSION_SSLv2
 have_constant :CURL_SSLVERSION_SSLv3
+
+# Added in 7.30.0
+have_constant "curlmopt_max_host_connections"
+
+# Added in 7.34.0
+have_constant :CURL_SSLVERSION_TLSv1_0
+have_constant :CURL_SSLVERSION_TLSv1_1
+have_constant :CURL_SSLVERSION_TLSv1_2
+
+# Added in 7.52.0
+have_constant :CURL_SSLVERSION_TLSv1_3
+
 have_constant "curlopt_ssl_verifypeer"
+have_constant "curlopt_doh_url"
+have_constant "curlopt_doh_ssl_verifypeer"
+have_constant "curlopt_doh_ssl_verifyhost"
+have_constant "curlopt_doh_ssl_verifystatus"
 have_constant "curlopt_cainfo"
 have_constant "curlopt_issuercert"
 have_constant "curlopt_capath"
@@ -352,15 +598,77 @@ have_constant "curle_not_built_in"
 
 have_constant "curle_obsolete" # removed in 7.24 ?
 
+have_constant "curle_ftp_pret_failed"
+have_constant "curle_rtsp_cseq_error"
+have_constant "curle_rtsp_session_error"
+have_constant "curle_ftp_bad_file_list"
+have_constant "curle_chunk_failed"
+have_constant "curle_no_connection_available"
+have_constant "curle_ssl_pinnedpubkeynotmatch"
+have_constant "curle_ssl_invalidcertstatus"
+have_constant "curle_http2_stream"
+
 # gssapi/spnego delegation related constants
 have_constant "curlopt_gssapi_delegation"
 have_constant "curlgssapi_delegation_policy_flag"
 have_constant "curlgssapi_delegation_flag"
 
+have_constant "CURLM_ADDED_ALREADY"
+
+# added in 7.40.0
+have_constant "curlopt_unix_socket_path"
+
+# added in 7.42.0
+have_constant "curlopt_path_as_is"
+
+# added in 7.43.0
+have_constant "curlopt_pipewait"
+
+have_constant "curlopt_proxy_ssl_verifyhost"
+
+# protocol constants
+have_constant "curlproto_all"
+have_constant "curlproto_dict"
+have_constant "curlproto_file"
+have_constant "curlproto_ftp"
+have_constant "curlproto_ftps"
+have_constant "curlproto_gopher"
+have_constant "curlproto_http"
+have_constant "curlproto_https"
+have_constant "curlproto_imap"
+have_constant "curlproto_imaps"
+have_constant "curlproto_ldap"
+have_constant "curlproto_ldaps"
+have_constant "curlproto_pop3"
+have_constant "curlproto_pop3s"
+have_constant "curlproto_rtmp"
+have_constant "curlproto_rtmpe"
+have_constant "curlproto_rtmps"
+have_constant "curlproto_rtmpt"
+have_constant "curlproto_rtmpte"
+have_constant "curlproto_rtmpts"
+have_constant "curlproto_rtsp"
+have_constant "curlproto_scp"
+have_constant "curlproto_sftp"
+have_constant "curlproto_smb"
+have_constant "curlproto_smbs"
+have_constant "curlproto_smtp"
+have_constant "curlproto_smtps"
+have_constant "curlproto_telnet"
+have_constant "curlproto_tftp"
+
 if try_compile('int main() { return 0; }','-Wall')
   $CFLAGS << ' -Wall'
 end
 
+# Clang-specific warning suppressions (not recognized by GCC)
+# These are used to suppress warnings in Ruby header macros
+%w[-Wno-self-assign -Wno-parentheses-equality -Wno-constant-logical-operand].each do |flag|
+  if try_compile('int main() { return 0; }', flag)
+    $CFLAGS << " #{flag}"
+  end
+end
+
 # do some checking to detect ruby 1.8 hash.c vs ruby 1.9 hash.c
 def test_for(name, const, src)
   checking_for name do
@@ -372,23 +680,6 @@ def test_for(name, const, src)
     end
   end
 end
-test_for("Ruby 1.9 Hash", "RUBY19_HASH", %{
-  #include <ruby.h>
-  int main() {
-    VALUE hash = rb_hash_new();
-    if( RHASH(hash)->ntbl->num_entries ) {
-      return 0;
-    }
-    return 1;
-  }
-})
-test_for("Ruby 1.9 st.h", "RUBY19_ST_H", %{
-  #include <ruby.h>
-  #include <ruby/st.h>
-  int main() {
-    return 0;
-  }
-})
 
 test_for("curl_easy_escape", "CURL_EASY_ESCAPE", %{
   #include <curl/curl.h>
@@ -400,6 +691,35 @@ test_for("curl_easy_escape", "CURL_EASY_ESCAPE", %{
 })
 
 have_func('rb_thread_blocking_region')
+have_header('ruby/thread.h') && have_func('rb_thread_call_without_gvl', 'ruby/thread.h')
+have_header('ruby/io.h')
+# Ruby 4.x exports rb_thread_fd_select without declaring it in ruby/io.h.
+have_func('rb_thread_fd_select')
+have_func('rb_wait_for_single_fd', 'ruby/io.h')
+have_header('ruby/fiber/scheduler.h')
+have_func('rb_fiber_scheduler_current', 'ruby/fiber/scheduler.h')
+have_func('rb_fiber_scheduler_io_wait', 'ruby/fiber/scheduler.h')
+have_func('rb_fiber_scheduler_io_select', 'ruby/fiber/scheduler.h')
+have_func('rb_io_stdio_file')
+have_func('curl_multi_wait')
+have_func('curl_multi_socket_action')
+have_func('curl_multi_assign')
+have_func('curl_multi_wakeup')
+have_func('curl_multi_poll')
+have_func('curl_multi_socket')
+have_func('curl_multi_timer_callback')
+have_constant 'curlmopt_socketfunction'
+have_constant 'curlmopt_timerfunction'
+have_func('curl_easy_duphandle')
+
+# Optional: enable verbose socket-action debug logging.
+# Set CURB_SOCKET_DEBUG=1 in the environment before running extconf to enable.
+if ENV['CURB_SOCKET_DEBUG'] == '1'
+  $defs << '-DCURB_SOCKET_DEBUG=1'
+end
+
+# Run any queued constant checks (in parallel if enabled) before header generation.
+flush_constant_checks
 
 create_header('curb_config.h')
 create_makefile('curb_core')

data/lib/curb.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 require 'curl'

data/lib/curl/download.rb

@@ -0,0 +1,160 @@
+# frozen_string_literal: true
+
+require 'uri'
+require 'tempfile'
+
+module Curl
+  class DownloadTargetExistsError < Errno::EEXIST; end
+  DOWNLOAD_OPTION_KEYS = [:download_dir, :overwrite].freeze
+
+  class << self
+    def download_options_hash?(value)
+      value.is_a?(Hash) && value.keys.all? { |key| DOWNLOAD_OPTION_KEYS.include?(key) }
+    end
+
+    def normalize_download_arguments(filename, options)
+      if download_options_hash?(filename) && options.empty?
+        options = filename
+        filename = nil
+      end
+
+      [filename, options || {}]
+    end
+
+    def parse_download_options(options)
+      raise ArgumentError, "download options must be a Hash" unless options.is_a?(Hash)
+
+      options = options.dup
+      download_dir = options.delete(:download_dir)
+      overwrite = options.key?(:overwrite) ? !!options.delete(:overwrite) : false
+      raise ArgumentError, "unsupported download option(s): #{options.keys.join(', ')}" unless options.empty?
+
+      [download_dir, overwrite]
+    end
+
+    def resolve_download_output(url, filename = nil, options = {})
+      filename, options = normalize_download_arguments(filename, options)
+      download_dir, overwrite = parse_download_options(options)
+
+      if filename.is_a?(IO)
+        filename.binmode if filename.respond_to?(:binmode)
+        return [nil, filename, false, overwrite]
+      end
+
+      path = if download_dir
+        safe_download_path(url, download_dir, filename: filename)
+      elsif filename.nil?
+        safe_download_path(url)
+      else
+        filename.to_s
+      end
+
+      [path, nil, true, overwrite]
+    end
+
+    def prepare_download_output(url, filename = nil, options = {})
+      path, io, safe_output, overwrite = resolve_download_output(url, filename, options)
+      return [path, io, safe_output] unless safe_output
+
+      [path, open_safe_download_output(path, overwrite: overwrite), true]
+    end
+
+    def download_filename_from_url(url)
+      path = begin
+        URI.parse(url.to_s).path
+      rescue URI::InvalidURIError
+        url.to_s.split(/\?/, 2).first
+      end
+
+      basename = File.basename(path.to_s)
+      validate_download_filename!(basename)
+    end
+
+    def safe_download_path(url, destination_dir = Dir.pwd, filename: nil)
+      dir = File.expand_path(destination_dir.to_s)
+      raise ArgumentError, "download destination directory does not exist: #{destination_dir}" unless File.directory?(dir)
+
+      File.join(dir, filename.nil? ? download_filename_from_url(url) : validate_download_filename!(filename))
+    end
+
+    def validate_download_filename!(filename)
+      filename = filename.to_s
+      invalid = filename.empty? ||
+                filename == '.' ||
+                filename == '..' ||
+                filename == File::SEPARATOR ||
+                filename.start_with?('.') ||
+                filename.include?("\0") ||
+                filename.include?(File::SEPARATOR) ||
+                filename.include?('\\') ||
+                filename.match?(/\A[A-Za-z]:/) ||
+                (File::ALT_SEPARATOR && filename.include?(File::ALT_SEPARATOR))
+
+      raise ArgumentError, "unsafe download filename derived from URL: #{filename.inspect}" if invalid
+
+      filename
+    end
+
+    def open_safe_download_output(path, overwrite: false)
+      SafeDownloadOutput.new(path, overwrite: overwrite)
+    end
+  end
+
+  class SafeDownloadOutput
+    def initialize(path, overwrite: false)
+      @path = File.expand_path(path.to_s)
+      @overwrite = overwrite
+      raise DownloadTargetExistsError, @path if !@overwrite && File.exist?(@path)
+
+      @tmp = Tempfile.new(['.curb-download-', '.tmp'], File.dirname(@path))
+      @tmp.binmode
+      @closed = false
+    end
+
+    attr_reader :path
+
+    def write(data)
+      @tmp.write(data)
+    end
+
+    def <<(data)
+      write(data)
+    end
+
+    def close(success = false)
+      return if @closed
+
+      @tmp.flush unless @tmp.closed?
+      @tmp.close unless @tmp.closed?
+      install_tmp_file if success
+    ensure
+      @tmp.close! if @tmp
+      @closed = true
+    end
+
+    private
+
+    def install_tmp_file
+      if @overwrite
+        File.rename(@tmp.path, @path)
+      else
+        File.link(@tmp.path, @path)
+      end
+    rescue Errno::EEXIST
+      raise DownloadTargetExistsError, @path
+    rescue NotImplementedError
+      install_tmp_file_by_copy
+    end
+
+    def install_tmp_file_by_copy
+      flags = File::WRONLY | File::CREAT | File::EXCL
+      flags |= File::BINARY if File.const_defined?(:BINARY)
+
+      File.open(@path, flags) do |dest|
+        File.open(@tmp.path, 'rb') { |src| IO.copy_stream(src, dest) }
+      end
+    rescue Errno::EEXIST
+      raise DownloadTargetExistsError, @path
+    end
+  end
+end