curb 0.8.5 → 1.3.6

data/tests/leak_trace.rb

@@ -0,0 +1,237 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'fileutils'
+require 'objspace'
+require 'optparse'
+require 'rbconfig'
+require 'tmpdir'
+
+TOPDIR = File.expand_path('..', __dir__)
+LIBDIR = File.join(TOPDIR, 'lib')
+EXTDIR = File.join(TOPDIR, 'ext')
+$LOAD_PATH.unshift(LIBDIR)
+$LOAD_PATH.unshift(EXTDIR)
+
+require 'curb'
+
+module LeakTrace
+  Record = Struct.new(:identifier, :created_location, :closed, keyword_init: true)
+
+  module_function
+
+  def install_multi_trace!
+    return if @multi_trace_installed
+
+    @multi_trace_installed = true
+    @multi_records = {}
+
+    multi_singleton = class << Curl::Multi
+      self
+    end
+
+    multi_singleton.alias_method(:__leak_trace_new, :new)
+    multi_singleton.define_method(:new) do |*args, **kwargs, &block|
+      multi = if kwargs.empty?
+        __leak_trace_new(*args, &block)
+      else
+        __leak_trace_new(*args, **kwargs, &block)
+      end
+
+      LeakTrace.multi_records[multi.object_id] ||= Record.new(
+        identifier: multi.object_id,
+        created_location: caller_locations(1, 6).map(&:to_s),
+        closed: false
+      )
+      multi
+    end
+
+    Curl::Multi.class_eval do
+      alias_method :__leak_trace__close, :_close
+
+      def _close(*args, **kwargs, &block)
+        record = LeakTrace.multi_records[object_id]
+        record.closed = true if record
+
+        if kwargs.empty?
+          __leak_trace__close(*args, &block)
+        else
+          __leak_trace__close(*args, **kwargs, &block)
+        end
+      end
+    end
+  end
+
+  def multi_records
+    @multi_records ||= {}
+  end
+
+  def live_multis
+    ObjectSpace.each_object(Curl::Multi).to_a
+  end
+
+  def fixture_path
+    File.expand_path('helper.rb', __dir__)
+  end
+
+  def fixture_url
+    path = fixture_path.tr('\\', '/')
+    "file://#{path.start_with?('/') ? '' : '/'}#{path}"
+  end
+
+  def full_gc(compact: false)
+    GC.start(full_mark: true, immediate_sweep: true)
+    GC.compact if compact && GC.respond_to?(:compact)
+    GC.start(full_mark: true, immediate_sweep: true)
+  end
+
+  def close_multi(multi)
+    return unless multi
+
+    multi.instance_variable_set(:@requests, {}) if multi.respond_to?(:instance_variable_set)
+    multi._close
+  rescue StandardError
+    multi.close rescue nil
+  end
+
+  def multi_perform(iterations:, handles:, close:, compact:)
+    iterations.times do
+      multi = Curl::Multi.new
+      handles.times { multi.add(Curl::Easy.new(fixture_url)) }
+      multi.perform
+    ensure
+      close_multi(multi) if close
+      multi = nil
+      full_gc(compact: compact)
+    end
+  end
+
+  def multi_gc_cleanup(iterations:, handles:, compact:)
+    iterations.times do
+      multi = Curl::Multi.new
+      handles.times { multi.add(Curl::Easy.new(fixture_url)) }
+      multi.perform
+      multi = nil
+      full_gc(compact: compact)
+    end
+  end
+
+  def easy_perform(iterations:, compact:)
+    iterations.times do
+      easy = Curl::Easy.new(fixture_url)
+      easy.perform
+      easy.close
+      easy = nil
+      full_gc(compact: compact)
+    end
+  end
+
+  def download(iterations:, compact:)
+    iterations.times do |i|
+      Dir.mktmpdir("curb-leak-trace-#{i}") do |dir|
+        Curl::Easy.download(fixture_url, File.join(dir, 'helper-copy.rb'))
+      end
+      full_gc(compact: compact)
+    end
+  end
+
+  def report(io:, verbose:)
+    live = live_multis
+    tracked_live = live.filter_map { |multi| multi_records[multi.object_id] }
+
+    io.puts "scanned live Curl::Multi objects: #{live.size}"
+    io.puts "tracked Curl::Multi allocations: #{multi_records.size}"
+    io.puts "tracked Curl::Multi closes: #{multi_records.count { |_id, record| record.closed }}"
+
+    grouped = tracked_live.group_by { |record| record.created_location.first || '<unknown>' }
+    grouped.sort_by { |location, records| [-records.size, location] }.each do |location, records|
+      io.puts "live #{records.size}: #{location}"
+      next unless verbose
+
+      records.each do |record|
+        io.puts "  object_id=#{record.identifier}"
+        record.created_location.drop(1).each do |line|
+          io.puts "    #{line}"
+        end
+      end
+    end
+  end
+end
+
+options = {
+  scenario: 'multi_perform',
+  iterations: 25,
+  handles: 3,
+  close: true,
+  compact: false,
+  verbose: false,
+  fail_on_live: false
+}
+
+OptionParser.new do |opts|
+  opts.banner = 'Usage: ruby tests/leak_trace.rb [options]'
+
+  opts.on('--scenario NAME', 'multi_perform, multi_gc_cleanup, easy_perform, download') do |value|
+    options[:scenario] = value
+  end
+
+  opts.on('--iterations N', Integer, 'number of iterations to run') do |value|
+    options[:iterations] = value
+  end
+
+  opts.on('--handles N', Integer, 'number of easy handles per multi iteration') do |value|
+    options[:handles] = value
+  end
+
+  opts.on('--[no-]close', 'explicitly close multi handles when the scenario finishes') do |value|
+    options[:close] = value
+  end
+
+  opts.on('--compact', 'run GC.compact between iterations when available') do
+    options[:compact] = true
+  end
+
+  opts.on('--verbose', 'print full creation stacks for live multi handles') do
+    options[:verbose] = true
+  end
+
+  opts.on('--fail-on-live', 'exit non-zero when any live Curl::Multi objects remain') do
+    options[:fail_on_live] = true
+  end
+end.parse!
+
+LeakTrace.install_multi_trace!
+
+case options[:scenario]
+when 'multi_perform'
+  LeakTrace.multi_perform(
+    iterations: options[:iterations],
+    handles: options[:handles],
+    close: options[:close],
+    compact: options[:compact]
+  )
+when 'multi_gc_cleanup'
+  LeakTrace.multi_gc_cleanup(
+    iterations: options[:iterations],
+    handles: options[:handles],
+    compact: options[:compact]
+  )
+when 'easy_perform'
+  LeakTrace.easy_perform(
+    iterations: options[:iterations],
+    compact: options[:compact]
+  )
+when 'download'
+  LeakTrace.download(
+    iterations: options[:iterations],
+    compact: options[:compact]
+  )
+else
+  warn "unknown scenario: #{options[:scenario]}"
+  exit 64
+end
+
+LeakTrace.full_gc(compact: options[:compact])
+LeakTrace.report(io: $stdout, verbose: options[:verbose])
+
+exit 1 if options[:fail_on_live] && LeakTrace.live_multis.any?

data/tests/mem_check.rb

@@ -6,6 +6,9 @@ require File.expand_path(File.join(File.dirname(__FILE__), 'helper'))
 # Run some tests to measure the memory usage of curb, these tests require fork and ps
 #
 class TestCurbMemory < Test::Unit::TestCase
+  def setup
+    omit('Memory fork/ps tests not supported on Windows') if WINDOWS || NO_FORK
+  end
 
   def test_easy_memory
     easy_avg, easy_std = measure_object_memory(Curl::Easy)

data/tests/tc_curl.rb

@@ -31,7 +31,37 @@ class TestCurl < Test::Unit::TestCase
     assert_equal "OPTIONSfoo=bar", curl.body_str
   end
 
-  include TestServerMethods 
+  def test_urlalize_without_extra_params
+    url_no_params = 'http://localhost/test'
+    url_with_params = 'http://localhost/test?a=1'
+
+    assert_equal(url_no_params, Curl.urlalize(url_no_params))
+    assert_equal(url_with_params, Curl.urlalize(url_with_params))
+  end
+
+  def test_urlalize_with_nil_as_params
+    url = 'http://localhost/test'
+    assert_equal(url, Curl.urlalize(url, nil))
+  end
+
+  def test_urlalize_with_extra_params
+    url_no_params = 'http://localhost/test'
+    url_with_params = 'http://localhost/test?a=1'
+    extra_params = { :b => 2 }
+
+    expected_url_no_params = 'http://localhost/test?b=2'
+    expected_url_with_params = 'http://localhost/test?a=1&b=2'
+
+    assert_equal(expected_url_no_params, Curl.urlalize(url_no_params, extra_params))
+    assert_equal(expected_url_with_params, Curl.urlalize(url_with_params, extra_params))
+  end
+
+  def test_urlalize_does_not_strip_trailing_?
+    url_empty_params = 'http://localhost/test?'
+    assert_equal(url_empty_params, Curl.urlalize(url_empty_params))
+  end
+
+  include TestServerMethods
 
   def setup
     server_setup

data/tests/tc_curl_download.rb

@@ -1,4 +1,5 @@
 require File.expand_path(File.join(File.dirname(__FILE__), 'helper'))
+require 'tmpdir'
 
 class TestCurbCurlDownload < Test::Unit::TestCase
   include TestServerMethods 
@@ -6,24 +7,109 @@ class TestCurbCurlDownload < Test::Unit::TestCase
   def setup
     server_setup
   end
-  
+
   def test_download_url_to_file_via_string
     dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
     dl_path = File.join(Dir::tmpdir, "dl_url_test.file")
 
-    curb = Curl::Easy.download(dl_url, dl_path)
+    Curl::Easy.download(dl_url, dl_path)
     assert File.exist?(dl_path)
     assert_equal File.read(File.join(File.dirname(__FILE__), '..','ext','curb_easy.c')), File.read(dl_path)
   ensure
     File.unlink(dl_path) if File.exist?(dl_path)
   end
 
+  def test_download_default_path_does_not_overwrite_existing_file
+    dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
+
+    Dir.mktmpdir('curb-download-') do |dir|
+      Dir.chdir(dir) do
+        File.write('curb_easy.c', 'sentinel')
+
+        assert_raise(Curl::DownloadTargetExistsError) do
+          Curl::Easy.download(dl_url)
+        end
+
+        assert_equal 'sentinel', File.read('curb_easy.c')
+      end
+    end
+  end
+
+  def test_download_default_path_strips_query_from_url_basename
+    dl_url = "http://127.0.0.1:9129/ext/curb_easy.c?cache=1"
+    source_path = File.expand_path(File.join(File.dirname(__FILE__), '..','ext','curb_easy.c'))
+
+    Dir.mktmpdir('curb-download-') do |dir|
+      Dir.chdir(dir) do
+        Curl::Easy.download(dl_url)
+
+        assert File.exist?('curb_easy.c')
+        assert !File.exist?('curb_easy.c?cache=1')
+        assert_equal File.read(source_path), File.read('curb_easy.c')
+      end
+    end
+  end
+
+  def test_download_safe_directory_rejects_unsafe_names
+    dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
+
+    Dir.mktmpdir('curb-download-') do |dir|
+      ['../escape.c', '.env', 'nested/file', '/tmp/escape.c', "bad\0name"].each do |name|
+        assert_raise(ArgumentError, "expected #{name.inspect} to be rejected") do
+          Curl::Easy.download(dl_url, name, :download_dir => dir)
+        end
+      end
+    end
+  end
+
+  def test_download_safe_directory_rejects_dotfile_from_url
+    dl_url = "http://127.0.0.1:9129/ext/.env"
+
+    Dir.mktmpdir('curb-download-') do |dir|
+      assert_raise(ArgumentError) do
+        Curl::Easy.download(dl_url, :download_dir => dir)
+      end
+
+      assert !File.exist?(File.join(dir, '.env'))
+    end
+  end
+
+  def test_download_overwrite_true_replaces_existing_file
+    dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
+
+    Dir.mktmpdir('curb-download-') do |dir|
+      dl_path = File.join(dir, 'curb_easy.c')
+      File.write(dl_path, 'sentinel')
+
+      Curl::Easy.download(dl_url, dl_path, :overwrite => true)
+
+      assert_equal File.read(File.join(File.dirname(__FILE__), '..','ext','curb_easy.c')), File.read(dl_path)
+    end
+  end
+
+  def test_download_callback_abort_does_not_replace_existing_file
+    dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
+
+    Dir.mktmpdir('curb-download-') do |dir|
+      dl_path = File.join(dir, 'curb_easy.c')
+      File.write(dl_path, 'sentinel')
+
+      assert_raise(Curl::Err::WriteError, Curl::Err::RecvError) do
+        Curl::Easy.download(dl_url, dl_path, :overwrite => true) do |curl|
+          curl.on_body { |_data| 0 }
+        end
+      end
+
+      assert_equal 'sentinel', File.read(dl_path)
+    end
+  end
+
   def test_download_url_to_file_via_file_io
     dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
     dl_path = File.join(Dir::tmpdir, "dl_url_test.file")
     io = File.open(dl_path, 'wb')
 
-    curb = Curl::Easy.download(dl_url, io)
+    Curl::Easy.download(dl_url, io)
     assert io.closed?
     assert File.exist?(dl_path)
     assert_equal File.read(File.join(File.dirname(__FILE__), '..','ext','curb_easy.c')), File.read(dl_path)
@@ -32,15 +118,19 @@ class TestCurbCurlDownload < Test::Unit::TestCase
   end
 
   def test_download_url_to_file_via_io
+    omit('fork not available on this platform') if NO_FORK || WINDOWS
     dl_url = "http://127.0.0.1:9129/ext/curb_easy.c"
     dl_path = File.join(Dir::tmpdir, "dl_url_test.file")
     reader, writer = IO.pipe
 
     # Write to local file
-    fork do
+    child_pid = fork do
       begin
         writer.close
         File.open(dl_path, 'wb') { |file| file << reader.read }
+        exit! 0
+      rescue StandardError
+        exit! 1
       ensure
         reader.close rescue IOError # if the stream has already been closed
       end
@@ -49,8 +139,9 @@ class TestCurbCurlDownload < Test::Unit::TestCase
     # Download remote source
     begin
       reader.close
-      curb = Curl::Easy.download(dl_url, writer)
-      Process.wait
+      Curl::Easy.download(dl_url, writer)
+      _pid, status = Process.wait2(child_pid)
+      assert_predicate status, :success?
     ensure
       writer.close rescue IOError # if the stream has already been closed, which occurs in Easy::download
     end
@@ -58,7 +149,7 @@ class TestCurbCurlDownload < Test::Unit::TestCase
     assert File.exist?(dl_path)
     assert_equal File.read(File.join(File.dirname(__FILE__), '..','ext','curb_easy.c')), File.read(dl_path)
   ensure
-    File.unlink(dl_path) if File.exist?(dl_path)
+    File.unlink(dl_path) if dl_path && File.exist?(dl_path)
   end
 
   def test_download_bad_url_gives_404