curation_concerns 1.7.0.beta1 → 1.7.0

data/spec/presenters/curation_concerns/inspect_work_presenter_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+RSpec.describe CurationConcerns::InspectWorkPresenter, no_clean: true do
+  let(:solr_document) { SolrDocument.new(attributes) }
+  let(:attributes) do
+    { "id" => '888888',
+      "has_model_ssim" => ["GenericWork"] }
+  end
+
+  let(:user) { create(:user) }
+  let(:ability) { Ability.new(user) }
+  let(:presenter) { described_class.new(solr_document, ability) }
+  let(:entity) { instance_double(Sipity::Entity) }
+
+  describe "#workflow" do
+    let(:comments) do
+      { comment: 'comment', created_at: 'unknown' }
+    end
+    let(:roles) do
+      { id: '1', name: 'reviewing', users: ['user1', 'user2'] }
+    end
+    before do
+      allow(entity).to receive(:id).and_return('1')
+      allow(entity).to receive(:workflow_name).and_return('generic_workflow')
+      allow(entity).to receive(:workflow_id).and_return('1')
+      allow(entity).to receive(:proxy_for_global_id).and_return(attributes["id"])
+      allow(entity).to receive(:workflow_id).and_return('1')
+      allow(entity).to receive(:workflow_state_id).and_return('1')
+      allow(entity).to receive(:workflow_state_name).and_return('completed')
+      allow(presenter).to receive(:sipity_entity).and_return(entity)
+      allow(presenter).to receive(:workflow_comments).and_return(comments)
+      allow(presenter).to receive(:sipity_entity_roles).and_return(roles)
+    end
+
+    context "when a valid sipity_entity with workflow exists" do
+      subject { presenter.workflow }
+      it 'returns a hash of workflow related values for ispection' do
+        expect(subject[:entity_id]).to eq '1'
+        expect(subject[:workflow_name]).to eq 'generic_workflow'
+        expect(subject[:workflow_id]).to eq '1'
+        expect(subject[:proxy_for]).to eq attributes["id"]
+        expect(subject[:state_id]).to eq '1'
+        expect(subject[:state_name]).to eq 'completed'
+        expect(subject[:comments][:comment]).to eq 'comment'
+        expect(subject[:roles][:id]).to eq '1'
+        expect(subject[:roles][:name]).to eq 'reviewing'
+        expect(subject[:roles][:users][0]).to eq 'user1'
+      end
+    end
+
+    context "when no sipity_entity with workflow exists" do
+      let(:invalid) { described_class.new('no_solr_document', ability) }
+      it "raises PowerConverter::ConversionError" do
+        expect { invalid.workflow }.to raise_exception(PowerConverter::ConversionError)
+      end
+    end
+  end
+end

data/spec/presenters/curation_concerns/work_show_presenter_spec.rb

@@ -188,6 +188,15 @@ describe CurationConcerns::WorkShowPresenter do
     end
   end
 
+  context "with inspect_work" do
+    let(:user) { create(:user) }
+    let(:ability) { Ability.new(user) }
+    describe "#inspect_work" do
+      subject { presenter.inspect_work }
+      it { is_expected.to be_kind_of CurationConcerns::InspectWorkPresenter }
+    end
+  end
+
   describe "graph export methods" do
     let(:graph) do
       RDF::Graph.new.tap do |g|

data/spec/presenters/curation_concerns/workflow_presenter_spec.rb

@@ -14,26 +14,40 @@ RSpec.describe CurationConcerns::WorkflowPresenter, no_clean: true do
 
   describe "#actions" do
     let(:workflow) { create(:workflow, name: 'testing') }
-    before do
-      allow(CurationConcerns::Workflow::PermissionQuery).to receive(:scope_permitted_workflow_actions_available_for_current_state).and_return([Sipity::WorkflowAction.new(name: "complete", workflow: workflow)])
-      allow(presenter).to receive(:sipity_entity).and_return(entity)
-    end
-
     subject { presenter.actions }
-    it "is an Array of Sipity::Action#name and translated names" do
-      allow(I18n).to receive(:t).with('curation_concerns.workflow.testing.complete', default: 'Complete').and_return("Approve")
-      is_expected.to eq [['complete', 'Approve']]
+    context 'with a Sipity::Entity' do
+      before do
+        allow(CurationConcerns::Workflow::PermissionQuery).to receive(:scope_permitted_workflow_actions_available_for_current_state).and_return([Sipity::WorkflowAction.new(name: "complete", workflow: workflow)])
+        allow(presenter).to receive(:sipity_entity).and_return(entity)
+      end
+      it "is an Array of Sipity::Action#name and translated names" do
+        allow(I18n).to receive(:t).with('curation_concerns.workflow.testing.complete', default: 'Complete').and_return("Approve")
+        is_expected.to eq [['complete', 'Approve']]
+      end
+    end
+    context 'without a Sipity::Entity' do
+      before do
+        allow(presenter).to receive(:sipity_entity).and_return(nil)
+      end
+      it { is_expected.to eq [] }
     end
   end
 
   describe "#comments" do
-    let(:comment) { instance_double(Sipity::Comment) }
-    before do
-      allow(entity).to receive(:comments).and_return([comment])
-      allow(presenter).to receive(:sipity_entity).and_return(entity)
-    end
-
     subject { presenter.comments }
-    it { is_expected.to eq [comment] }
+    context 'with a Sipity::Entity' do
+      let(:comment) { instance_double(Sipity::Comment) }
+      before do
+        allow(entity).to receive(:comments).and_return([comment])
+        allow(presenter).to receive(:sipity_entity).and_return(entity)
+      end
+      it { is_expected.to eq [comment] }
+    end
+    context 'without a Sipity::Entity' do
+      before do
+        allow(presenter).to receive(:sipity_entity).and_return(nil)
+      end
+      it { is_expected.to eq [] }
+    end
   end
 end

data/spec/routing/route_spec.rb

@@ -39,6 +39,10 @@ describe 'Routes', type: :routing do
     it 'routes to file_manager' do
       expect(get: 'concern/generic_works/6/file_manager').to route_to(controller: 'curation_concerns/generic_works', action: 'file_manager', id: '6')
     end
+
+    it 'routes to inspect_work' do
+      expect(get: 'concern/generic_works/6/inspect_work').to route_to(controller: 'curation_concerns/generic_works', action: 'inspect_work', id: '6')
+    end
   end
 
   describe 'Permissions' do

data/spec/services/curation_concerns/workflow/action_taken_service_spec.rb

@@ -6,18 +6,17 @@ RSpec.describe CurationConcerns::Workflow::ActionTakenService do
     it { is_expected.to respond_to(:handle_action_taken) }
   end
 
-  let(:triggered_methods) { [instance_double(Sipity::Method, service_name: 'foo_bar')] }
+  let(:triggered_methods) { [instance_double(Sipity::Method, service_name: 'FooBar')] }
   let(:triggered_methods_rel) do
     instance_double(Sipity::Method::ActiveRecord_Relation,
                     order: triggered_methods,
                     any?: true)
   end
-  let(:work) { instance_double(GenericWork) }
+  let(:work) { instance_double(GenericWork, id: '9999') }
   let(:action) { instance_double(Sipity::WorkflowAction, triggered_methods: triggered_methods_rel) }
-  let(:entity) { instance_double(Sipity::Entity, id: 9999, proxy_for: work) }
   let(:user) { User.new }
   let(:instance) do
-    described_class.new(entity: entity,
+    described_class.new(target: work,
                         action: action,
                         comment: "A pleasant read",
                         user: user)
@@ -38,14 +37,14 @@ RSpec.describe CurationConcerns::Workflow::ActionTakenService do
       context "and the method succeedes" do
         it "calls the method and saves the object" do
           expect(work).to receive(:save)
-          expect(FooBar).to receive(:call).with(entity: entity, user: user, comment: "A pleasant read").and_return(true)
+          expect(FooBar).to receive(:call).with(target: work, user: user, comment: "A pleasant read").and_return(true)
           subject
         end
       end
       context "and the method fails" do
         it "calls the method and saves the object" do
           expect(work).not_to receive(:save)
-          expect(FooBar).to receive(:call).with(entity: entity, user: user, comment: "A pleasant read").and_return(false)
+          expect(FooBar).to receive(:call).with(target: work, user: user, comment: "A pleasant read").and_return(false)
           expect(Rails.logger).to receive(:error).with("Not all workflow methods were successful, so not saving (9999)")
           subject
         end

data/spec/services/curation_concerns/workflow/activate_object_spec.rb

@@ -1,20 +1,21 @@
 require 'spec_helper'
 
 RSpec.describe CurationConcerns::Workflow::ActivateObject do
-  let(:work) { instance_double(GenericWork) }
-  let(:entity) { instance_double(Sipity::Entity, id: 9999, proxy_for: work) }
-  let(:user) { User.new }
-
+  let(:work) { create(:generic_work) }
+  let(:user) { create(:user) }
   describe ".call" do
-    subject do
-      described_class.call(entity: entity,
-                           comment: "A pleasant read",
-                           user: user)
-    end
-
     it "makes it active" do
-      expect(work).to receive(:state=).with(Vocab::FedoraResourceStatus.active)
-      subject
+      if RDF::VERSION.to_s < '2.0'
+        expect { described_class.call(target: work, comment: "A pleasant read", user: user) }
+          .to change { work.state }
+          .from(nil)
+          .to(instance_of(ActiveTriples::Resource))
+      else
+        expect { described_class.call(target: work, comment: "A pleasant read", user: user) }
+          .to change { work.state }
+          .from(nil)
+          .to(::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#active'))
+      end
     end
   end
 end

data/spec/services/curation_concerns/workflow/deactivate_object_spec.rb

@@ -1,20 +1,21 @@
 require 'spec_helper'
 
 RSpec.describe CurationConcerns::Workflow::DeactivateObject do
-  let(:work) { instance_double(GenericWork) }
-  let(:entity) { instance_double(Sipity::Entity, id: 9999, proxy_for: work) }
-  let(:user) { User.new }
-
+  let(:work) { create(:generic_work) }
+  let(:user) { create(:user) }
   describe ".call" do
-    subject do
-      described_class.call(entity: entity,
-                           comment: "A pleasant read",
-                           user: user)
-    end
-
-    it "makes it active" do
-      expect(work).to receive(:state=).with(Vocab::FedoraResourceStatus.inactive)
-      subject
+    it "makes it inactive" do
+      if RDF::VERSION.to_s < '2.0'
+        expect { described_class.call(target: work, comment: "A pleasant read", user: user) }
+          .to change { work.state }
+          .from(nil)
+          .to(instance_of(ActiveTriples::Resource))
+      else
+        expect { described_class.call(target: work, comment: "A pleasant read", user: user) }
+          .to change { work.state }
+          .from(nil)
+          .to(::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#inactive'))
+      end
     end
   end
 end

data/spec/services/curation_concerns/workflow/grant_edit_to_depositor_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+RSpec.describe CurationConcerns::Workflow::GrantEditToDepositor do
+  let(:depositor) { create(:user) }
+  let(:work) { create(:work_without_access, depositor: depositor.user_key) }
+  let(:user) { User.new }
+
+  describe ".call" do
+    subject do
+      described_class.call(target: work,
+                           comment: "A pleasant read",
+                           user: user)
+    end
+
+    it "adds edit access " do
+      expect { subject }.to change { work.edit_users }.from([]).to([depositor.user_key])
+      expect(work).to be_valid
+    end
+  end
+end

data/spec/services/curation_concerns/workflow/permission_query_spec.rb

@@ -24,7 +24,7 @@ module CurationConcerns
                                workflow_state: PowerConverter.convert_to_sipity_workflow_state('initial', scope: sipity_workflow)
                               )
       end
-      let(:sipity_workflow) { Sipity::Workflow.first }
+      let(:sipity_workflow) { Sipity::Workflow.find_by(name: 'testing') }
 
       def expect_actions_for(user:, entity:, actions:)
         actions = Array.wrap(actions).map { |action| PowerConverter.convert_to_sipity_action(action, scope: entity.workflow) }
@@ -169,8 +169,8 @@ module CurationConcerns
           let(:user) { create(:user) }
           subject { described_class.scope_processing_agents_for(user: user) }
           it 'will equal [kind_of(Sipity::Agent)]' do
-            is_expected.to eq([PowerConverter.convert_to_sipity_agent(user),
-                               PowerConverter.convert_to_sipity_agent(Group.new('registered'))])
+            is_expected.to contain_exactly(PowerConverter.convert_to_sipity_agent(user),
+                                           PowerConverter.convert_to_sipity_agent(Group.new('registered')))
           end
         end
       end

data/spec/services/curation_concerns/workflow/status_list_service_spec.rb

@@ -4,6 +4,7 @@ RSpec.describe CurationConcerns::Workflow::StatusListService do
   describe "#each" do
     let(:user) { create(:user) }
     let(:service) { described_class.new(user) }
+    let!(:sipity_entity) { create(:sipity_entity) }
     let(:document) { { id: '33333',
                        has_model_ssim: ['GenericWork'],
                        actionable_workflow_roles_ssim: ["generic_work-approving", "generic_work-rejecting"],
@@ -15,7 +16,6 @@ RSpec.describe CurationConcerns::Workflow::StatusListService do
     let(:workflow_role) { instance_double(Sipity::Role, name: 'approving') }
     let(:workflow_roles) { [instance_double(Sipity::WorkflowRole, role: workflow_role)] }
     before do
-      create(:sipity_entity)
       ActiveFedora::SolrService.add([document, ability], commit: true)
     end
 
@@ -24,6 +24,9 @@ RSpec.describe CurationConcerns::Workflow::StatusListService do
     context "when user has roles" do
       before do
         allow(CurationConcerns::Workflow::PermissionQuery).to receive(:scope_processing_workflow_roles_for_user_and_workflow).and_return(workflow_roles)
+        allow_any_instance_of(described_class).to receive(:roles_for_user) do
+          "generic_work-#{workflow_role.name}"
+        end
       end
 
       it "returns status rows" do

data/spec/services/curation_concerns/workflow/workflow_importer_spec.rb

@@ -34,7 +34,6 @@ RSpec.describe CurationConcerns::Workflow::WorkflowImporter do
   end
 
   context 'data generation' do
-    let(:path) { Rails.root.join('config/workflows/default_workflow.json').to_s }
     it 'creates the requisite data from the configuration' do
       expect(CurationConcerns::Workflow::WorkflowPermissionsGenerator).to receive(:call).and_call_original
       expect(CurationConcerns::Workflow::SipityActionsGenerator).to receive(:call).and_call_original
@@ -43,8 +42,8 @@ RSpec.describe CurationConcerns::Workflow::WorkflowImporter do
         result = described_class.generate_from_json_file(path: path)
       end.to change { Sipity::Workflow.count }.by(1)
       expect(result).to match_array(kind_of(Sipity::Workflow))
-      expect(result.first.label).to eq "Default workflow"
-      expect(result.first.description).to eq "A single submission step, default workflow"
+      expect(result.first.label).to eq "This is the label"
+      expect(result.first.description).to eq "This description could get really long"
     end
   end
 end

data/spec/services/curation_concerns/working_directory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe CurationConcerns::WorkingDirectory do
+  let(:path1) { described_class.send(:full_filename, 'abcdefghijklmnop1', 'foo.tif') }
+  let(:path2) { described_class.send(:full_filename, 'abcdefghijklmnop2', 'foo.tif') }
+
+  describe "#full_filename" do
+    it "generates unique filenames for different files" do
+      expect(path1).not_to eq(path2)
+    end
+  end
+end

data/spec/views/curation_concerns/base/unavailable.html.erb_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe 'curation_concerns/base/unavailable.html.erb', type: :view do
+  let(:model) do
+    double('model',
+           persisted?: true,
+           to_param: '123',
+           model_name: GenericWork.model_name)
+  end
+  let(:workflow) do
+    double('workflow', state: 'deposited', state_label: 'really deposited')
+  end
+  let(:presenter) do
+    double('presenter',
+           to_s: 'super cool',
+           workflow: workflow,
+           human_readable_type: 'Generic Work')
+  end
+  let(:parent_presenter) do
+    double('parent_presenter',
+           to_s: 'parental remark',
+           to_model: model,
+           human_readable_type: 'Foo Bar')
+  end
+  before do
+    assign(:presenter, presenter)
+    assign(:parent_presenter, parent_presenter)
+    stub_template 'shared/_brand_bar.html.erb' => ''
+    stub_template 'shared/_title_bar.html.erb' => ''
+    flash[:notice] = I18n.t("curation_concerns.workflow.unauthorized")
+    render template: 'curation_concerns/base/unavailable.html.erb', layout: 'layouts/curation_concerns'
+  end
+  it "renders with the flash message" do
+    expect(rendered).to have_content 'super cool'
+    expect(rendered).to have_content 'really deposited'
+    expect(rendered).to have_content 'parental remark'
+    expect(rendered).to have_content 'Generic Work'
+    expect(rendered).to have_content 'The work is not currently available because it has not yet completed the approval process'
+  end
+end