curation_concerns 1.7.0.beta1 → 1.7.0

data/app/services/curation_concerns/workflow/deactivate_object.rb

@@ -1,10 +1,15 @@
 module CurationConcerns
   module Workflow
-    # This is a built in function for workflow, so that a workflow action can be created that
-    # deactivates an object.
+    ##
+    # This is a built in function for workflow, setting the `#state`
+    # of the target to the Fedora 'inactive' status URI
+    #
+    # @param target [#state] an instance of a model that includes `CurationConcerns::Suppressible`
+    #
+    # @return [RDF::Vocabulary::Term] the Fedora Resource Status 'inactive' term
     class DeactivateObject
-      def self.call(entity:, **)
-        entity.proxy_for.state = Vocab::FedoraResourceStatus.inactive
+      def self.call(target:, **)
+        target.state = Vocab::FedoraResourceStatus.inactive
       end
     end
   end

data/app/services/curation_concerns/workflow/{remove_depositor_permissions.rb → grant_edit_to_depositor.rb}

@@ -1,10 +1,10 @@
 module CurationConcerns
   module Workflow
     # This is a built in function for workflow, so that a workflow action can be created that
-    # removes the creators ability to alter it.
-    class RemoveDepositorPermissions
-      def self.call(entity:, **)
-        entity.proxy_for.edit_users = []
+    # grants the creator the ability to alter it.
+    class GrantEditToDepositor
+      def self.call(target:, **)
+        target.edit_users = [target.depositor]
       end
     end
   end

data/app/services/curation_concerns/workflow/workflow_action_service.rb

@@ -45,7 +45,7 @@ module CurationConcerns
         # Run any configured custom methods
         def handle_additional_sipity_workflow_action_processing(comment:)
           CurationConcerns::Workflow::ActionTakenService.handle_action_taken(
-            entity: subject.entity,
+            target: subject.work,
             comment: comment,
             action: action,
             user: subject.user

data/app/services/curation_concerns/working_directory.rb

@@ -48,7 +48,7 @@ module CurationConcerns
         end
 
         def full_filename(id, original_name)
-          pair = id.scan(/..?/).first(4)
+          pair = id.scan(/..?/).first(4).push(id)
           File.join(CurationConcerns.config.working_path, *pair, original_name)
         end
     end

data/app/views/curation_concerns/base/inspect_work.html.erb

@@ -0,0 +1,37 @@
+<h1><%= t("inspect_work.link_text") %></h1>
+<ul class="breadcrumb">
+  <li>
+    Back to <%= link_to @presenter.to_s, [main_app, @presenter] %>
+  </li>
+</ul>
+
+<h3>Workflow</h3>
+<dl>
+  <% workflow = @presenter.inspect_work.workflow %>
+  <dt>Object Name</dt>
+  <dd><%= @presenter.to_s %></dd>
+  <dt>Processing Entity ID</dt>
+  <dd>Entity ID: <%= workflow[:entity_id] %> (Proxy for <%= workflow[:proxy_for] %>)</dd>
+  <dt>Workflow</dt>
+  <dd>Name: <%= workflow[:workflow_name] %> (ID=<%= workflow[:workflow_id] %>)</dd>
+  <dt>State</dt>
+  <dd>State Name: <%= workflow[:state_name] %> (ID=<%= workflow[:state_id] %>)</dd>
+  <dt>Workflow Comments</dt>
+  <dd>
+    <% workflow[:comments].each do |comment| %>
+        <dd><%= comment[:created_at] %>, <%= comment[:comment] %></dd>
+    <% end %>
+  </dd>
+  <dt>Roles</dt>
+  <dd>
+    <% workflow[:roles].each do |role| %>
+      <dd><%= role[:name] %> (ID=<%= role[:id] %>) <%= role[:description] %> Users: <%= role[:users] %></dd>
+  <% end %>
+  </dd>
+</dl>
+
+<h3>Persistence</h3>
+<dl>
+  <dt>Solr</dt>
+  <dd><%= @presenter.inspect_work.solr %></dd>
+</dl>

data/app/views/curation_concerns/base/unavailable.html.erb

@@ -0,0 +1,10 @@
+<h1><%= @presenter %> </h1>
+<span class="state state-<%= @presenter.workflow.state %>"><%= @presenter.workflow.state_label %></span>
+<% if @parent_presenter %>
+    <ul class="breadcrumb">
+        <li><%= link_to @parent_presenter, polymorphic_path([main_app, @parent_presenter]) %></li>
+        <li class="active"><%= @presenter.human_readable_type %></li>
+    </ul>
+<% else %>
+    <span class="human_readable_type">(<%= @presenter.human_readable_type %>)</span>
+<% end %>

data/app/views/curation_concerns/operations/index.html.erb

@@ -13,7 +13,7 @@
       <tbody>
         <% @operations.each do |op| %>
           <tr>
-            <td><%= link_to op.operation_type, sufia.user_operation_path(params[:user_id], op) %></td>
+            <td><%= link_to op.operation_type, curation_concerns.user_operation_path(params[:user_id], op) %></td>
             <td><span class="label <%= op.status == 'failure' ? 'label-danger' : 'label-success' %>"><%= op.status %></span></td>
           </tr>
         <% end %>

data/app/views/curation_concerns/operations/show.html.erb

@@ -18,7 +18,7 @@
         <tbody>
           <% @operation.children.each do |op| %>
             <tr>
-              <td><%= link_to op.operation_type, sufia.user_operation_path(params[:user_id], op) %></td>
+              <td><%= link_to op.operation_type, curation_concerns.user_operation_path(params[:user_id], op) %></td>
               <td><span class="label <%= op.status == 'failure' ? 'label-danger' : 'label-success' %>"><%= op.status %></span></td>
               <td><%= op.message %></td>
             </tr>

data/config/locales/curation_concerns.en.yml

@@ -181,6 +181,7 @@ en:
     workflow:
       default:
         deposit: "Deposit"
+      unauthorized: "The work is not currently available because it has not yet completed the approval process"
   blacklight:
     search:
       fields:
@@ -233,6 +234,8 @@ en:
     submit:
       sipity_workflow_responsibility:
         create: "Add"
+  inspect_work:
+        link_text: 'Inspect Work'
   simple_form:
     required:
       html: '<span class="label label-info required-tag">required</span>'

data/curation_concerns.gemspec

@@ -18,11 +18,11 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'hydra-head', '>= 10.0.0', '< 11'
+  spec.add_dependency 'hydra-head', '>= 10.3.0', '< 11'
   spec.add_dependency 'active-fedora', '>= 10.3.0.rc1'
   spec.add_dependency 'blacklight', '~> 6.3'
   spec.add_dependency 'breadcrumbs_on_rails', '>= 3.0.1', '< 4'
-  spec.add_dependency 'jquery-ui-rails'
+  spec.add_dependency 'jquery-ui-rails', '~> 5.0.5'
   spec.add_dependency 'simple_form', '~> 3.1'
   spec.add_dependency 'hydra-editor', '>= 2', '< 4'
   spec.add_dependency 'rails_autolink'
@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rdf', '>= 1.99'
   spec.add_dependency 'rdf-vocab', '>= 0.8'
   spec.add_dependency 'awesome_nested_set', '~> 3.0'
-  spec.add_dependency 'browse-everything', '~> 0.10'
+  spec.add_dependency 'browse-everything', '~> 0.10', '>= 0.10.5'
   spec.add_dependency 'clipboard-rails', '~> 1.5'
   spec.add_dependency 'power_converter', '~> 0.1', '>= 0.1.2'
   spec.add_dependency 'dry-validation', '~> 0.9'

data/lib/curation_concerns/rails/routes.rb

@@ -16,6 +16,7 @@ module ActionDispatch::Routing
           namespaced_resources curation_concern_name, only: [] do
             member do
               get :file_manager
+              get :inspect_work
             end
           end
         end

data/lib/curation_concerns/version.rb

@@ -1,3 +1,3 @@
 module CurationConcerns
-  VERSION = '1.7.0.beta1'.freeze
+  VERSION = '1.7.0'.freeze
 end

data/lib/curation_concerns/workflow_authorization_exception.rb

@@ -0,0 +1,4 @@
+module CurationConcerns
+  class WorkflowAuthorizationException < StandardError
+  end
+end

data/lib/generators/curation_concerns/templates/workflow.json.erb

@@ -10,6 +10,7 @@
                     "from_states": [],
                     "transition_to": "deposited",
                     "methods": [
+                        "CurationConcerns::Workflow::GrantEditToDepositor",
                         "CurationConcerns::Workflow::ActivateObject"
                     ]
                 }

data/spec/controllers/curation_concerns/generic_works_controller_spec.rb

@@ -4,7 +4,25 @@ require 'spec_helper'
 # which is included into .internal_test_app/app/controllers/generic_works_controller.rb
 describe CurationConcerns::GenericWorksController do
   let(:user) { create(:user) }
-  before { sign_in user }
+  let(:work) { create(:generic_work, user: user) }
+  let!(:sipity_entity) do
+    create(:sipity_entity, proxy_for_global_id: work.to_global_id.to_s)
+  end
+  before do
+    sign_in user
+  end
+
+  describe 'integration test for suppressed documents' do
+    let(:work) do
+      create(:work, :public, state: Vocab::FedoraResourceStatus.inactive)
+    end
+    it 'renders the unavailable message because it is in workflow' do
+      get :show, params: { id: work }
+      expect(response.code).to eq '401'
+      expect(response).to render_template(:unavailable)
+      expect(flash[:notice]).to eq 'The work is not currently available because it has not yet completed the approval process'
+    end
+  end
 
   describe '#show' do
     context 'my own private work' do
@@ -16,6 +34,9 @@ describe CurationConcerns::GenericWorksController do
 
       context "with a parent work" do
         let(:parent) { create(:generic_work, title: ['Parent Work'], user: user, ordered_members: [work]) }
+        let!(:parent_sipity_entity) do
+          create(:sipity_entity, proxy_for_global_id: parent.to_global_id.to_s)
+        end
         it "sets the parent presenter" do
           get :show, params: { id: work, parent_id: parent }
           expect(response).to be_success
@@ -50,7 +71,7 @@ describe CurationConcerns::GenericWorksController do
           allow(presenter).to receive(:export_as_ttl).and_return("ttl graph")
         end
 
-        it 'renders an turtle file' do
+        it 'renders a turtle file' do
           get :show, params: { id: '99999999', format: :ttl }
           expect(response).to be_successful
           expect(response.body).to eq "ttl graph"
@@ -68,6 +89,35 @@ describe CurationConcerns::GenericWorksController do
       end
     end
 
+    context 'with work still in workflow' do
+      before do
+        allow(controller).to receive(:search_results).and_return([nil, document_list])
+      end
+      context 'with a user lacking workflow permission' do
+        before do
+          allow(SolrDocument).to receive(:find).and_return(document)
+        end
+        let(:document_list) { [] }
+        let(:document) { instance_double(SolrDocument, suppressed?: true) }
+        it 'shows the unauthorized message' do
+          get :show, params: { id: '99999' }
+          expect(response.code).to eq '401'
+          expect(response).to render_template(:unavailable)
+          expect(flash[:notice]).to eq 'The work is not currently available because it has not yet completed the approval process'
+        end
+      end
+      context 'with a user granted workflow permission' do
+        let(:document_list) { [document] }
+        let(:document) { instance_double(SolrDocument) }
+        it 'renders without the unauthorized message' do
+          get :show, params: { id: '88888' }
+          expect(response.code).to eq '200'
+          expect(response).to render_template(:show)
+          expect(flash[:notice]).to be_nil
+        end
+      end
+    end
+
     context 'when a ObjectNotFoundError is raised' do
       it 'returns 404 page' do
         allow(controller).to receive(:show).and_raise(ActiveFedora::ObjectNotFoundError)
@@ -193,7 +243,6 @@ describe CurationConcerns::GenericWorksController do
 
       context 'when there are children' do
         let(:work) { create(:work_with_one_file, user: user) }
-
         it 'prompts to change the files access' do
           patch :update, params: { id: work, generic_work: {} }
           expect(response).to redirect_to main_app.confirm_curation_concerns_permission_path(controller.curation_concern)
@@ -238,23 +287,23 @@ describe CurationConcerns::GenericWorksController do
   end
 
   describe '#destroy' do
-    let(:work_to_be_deleted) { create(:private_generic_work, user: user) }
+    let(:work) { create(:private_generic_work, user: user) }
     let(:parent_collection) { create(:collection) }
 
     it 'deletes the work' do
-      delete :destroy, params: { id: work_to_be_deleted }
+      delete :destroy, params: { id: work }
       expect(response).to redirect_to main_app.search_catalog_path
-      expect(GenericWork).not_to exist(work_to_be_deleted.id)
+      expect(GenericWork).not_to exist(work.id)
     end
 
     context "when work is a member of a collection" do
       before do
-        parent_collection.members = [work_to_be_deleted]
+        parent_collection.members = [work]
         parent_collection.save!
       end
       it 'deletes the work and updates the parent collection' do
-        delete :destroy, params: { id: work_to_be_deleted }
-        expect(GenericWork).not_to exist(work_to_be_deleted.id)
+        delete :destroy, params: { id: work }
+        expect(GenericWork).not_to exist(work.id)
         expect(response).to redirect_to main_app.search_catalog_path
         expect(parent_collection.reload.members).to eq []
       end
@@ -262,35 +311,48 @@ describe CurationConcerns::GenericWorksController do
 
     it "invokes the after_destroy callback" do
       expect(CurationConcerns.config.callback).to receive(:run)
-        .with(:after_destroy, work_to_be_deleted.id, user)
-      delete :destroy, params: { id: work_to_be_deleted }
+        .with(:after_destroy, work.id, user)
+      delete :destroy, params: { id: work }
     end
 
     context 'someone elses public work' do
-      let(:work_to_be_deleted) { create(:private_generic_work) }
+      let(:work) { create(:private_generic_work) }
       it 'shows unauthorized message' do
-        delete :destroy, params: { id: work_to_be_deleted }
+        delete :destroy, params: { id: work }
         expect(response.code).to eq '401'
         expect(response).to render_template(:unauthorized)
       end
     end
 
     context 'when I am a repository manager' do
-      let(:work_to_be_deleted) { create(:private_generic_work) }
+      let(:work) { create(:private_generic_work) }
       before { allow_any_instance_of(User).to receive(:groups).and_return(['admin']) }
       it 'someone elses private work should delete the work' do
-        delete :destroy, params: { id: work_to_be_deleted }
-        expect(GenericWork).not_to exist(work_to_be_deleted.id)
+        delete :destroy, params: { id: work }
+        expect(GenericWork).not_to exist(work.id)
       end
     end
   end
 
   describe '#file_manager' do
     let(:work) { create(:private_generic_work, user: user) }
+
     it "is successful" do
       get :file_manager, params: { id: work.id }
       expect(response).to be_success
       expect(assigns(:presenter)).not_to be_blank
     end
   end
+
+  describe '#inspect_work' do
+    let(:work) { create(:private_generic_work, user: user) }
+    context 'when I am a repository manager' do
+      before { allow_any_instance_of(User).to receive(:groups).and_return(['admin']) }
+      it "the response is successful" do
+        get :inspect_work, params: { id: work.id }
+        expect(response).to be_success
+        expect(assigns(:presenter)).not_to be_blank
+      end
+    end
+  end
 end

data/spec/controllers/selects_collections_controller_spec.rb

@@ -11,10 +11,8 @@ end
 describe SelectsCollectionsController, type: :controller do
   describe "#find_collections" do
     it "uses the search builder" do
-      expect(subject.collections_search_builder_class.default_processor_chain).to eq [
-        :default_solr_parameters, :add_query_to_solr,
-        :add_access_controls_to_solr_params, :filter_models,
-        :some_rows, :sort_by_title]
+      expect(subject.collections_search_builder_class.default_processor_chain)
+        .to include(:default_solr_parameters, :add_query_to_solr, :add_access_controls_to_solr_params)
       expect(CurationConcerns::CollectionSearchBuilder).to receive(:new).with(subject).and_call_original
       subject.find_collections
     end

data/spec/factories/generic_works.rb

@@ -99,4 +99,10 @@ FactoryGirl.define do
       end
     end
   end
+
+  # Doesn't set up any edit_users
+  factory :work_without_access, class: GenericWork do
+    title ['Test title']
+    depositor { FactoryGirl.create(:user).user_key }
+  end
 end

data/spec/factories/workflows.rb

@@ -1,5 +1,5 @@
 FactoryGirl.define do
   factory :workflow, class: Sipity::Workflow do
-    name 'generic_work'
+    sequence(:name) { |n| "generic_work-#{n}" }
   end
 end

data/spec/features/add_file_spec.rb

@@ -3,6 +3,9 @@ require 'spec_helper'
 feature 'Add an attached file' do
   let(:user) { create(:user) }
   let!(:work) { create(:work, user: user) }
+  let!(:sipity_entity) do
+    create(:sipity_entity, proxy_for_global_id: work.to_global_id.to_s)
+  end
 
   before do
     sign_in user

data/spec/features/create_child_work_spec.rb

@@ -2,23 +2,23 @@ require 'spec_helper'
 require 'redlock'
 
 feature 'Creating a new child Work', :workflow do
-  let(:user) { FactoryGirl.create(:user) }
-
+  let(:user) { create(:user) }
+  let!(:sipity_entity) do
+    create(:sipity_entity, proxy_for_global_id: parent.to_global_id.to_s)
+  end
   let(:redlock_client_stub) { # stub out redis connection
     client = double('redlock client')
     allow(client).to receive(:lock).and_yield(true)
     allow(Redlock::Client).to receive(:new).and_return(client)
     client
   }
-  let(:parent) { FactoryGirl.create(:generic_work, user: user, title: ["Parent First"]) }
+  let!(:parent) { create(:generic_work, user: user, title: ["Parent First"]) }
 
   before do
     sign_in user
-
     # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
     allow(CharacterizeJob).to receive(:perform_later)
     redlock_client_stub
-    parent
   end
 
   it 'creates the child work' do
@@ -34,7 +34,14 @@ feature 'Creating a new child Work', :workflow do
   end
 
   context "when it's being updated" do
-    let(:curation_concern) { FactoryGirl.create(:generic_work, user: user) }
+    let(:curation_concern) { create(:generic_work, user: user) }
+    let(:new_parent) { create(:generic_work, user: user) }
+    let!(:cc_sipity_entity) do
+      create(:sipity_entity, proxy_for_global_id: curation_concern.to_global_id.to_s)
+    end
+    let!(:new_sipity_entity) do
+      create(:sipity_entity, proxy_for_global_id: new_parent.to_global_id.to_s)
+    end
     before do
       parent.ordered_members << curation_concern
       parent.save!
@@ -46,7 +53,6 @@ feature 'Creating a new child Work', :workflow do
       expect(parent.reload.ordered_members.to_a.length).to eq 1
     end
     it "doesn't lose other memberships" do
-      new_parent = FactoryGirl.create(:generic_work, user: user)
       new_parent.ordered_members << curation_concern
       new_parent.save!
 

data/spec/features/update_file_spec.rb

@@ -4,7 +4,9 @@ feature 'Editing attached files' do
   let(:user) { create(:user) }
   let!(:parent) { create(:work_with_one_file, user: user) }
   let!(:file_set) { parent.file_sets.first }
-
+  let!(:sipity_entity) do
+    create(:sipity_entity, proxy_for_global_id: parent.to_global_id.to_s)
+  end
   around do |example|
     original_adapter = ActiveJob::Base.queue_adapter
     ActiveJob::Base.queue_adapter = :inline
@@ -14,7 +16,6 @@ feature 'Editing attached files' do
 
   before do
     sign_in user
-
     # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
     expect(CharacterizeJob).to receive(:perform_later)
   end

data/spec/forms/curation_concerns/forms/workflow_action_form_spec.rb

@@ -3,9 +3,7 @@ require 'spec_helper'
 RSpec.describe CurationConcerns::Forms::WorkflowActionForm, no_clean: true do
   let(:work) { create(:work) }
   let(:sipity_entity) do
-    create(:sipity_entity,
-           proxy_for_global_id: work.to_global_id.to_s,
-           workflow_state_id: 2)
+    create(:sipity_entity, proxy_for_global_id: work.to_global_id.to_s, workflow_state_id: 2)
   end
   let(:user) { create(:user) }
   let(:current_ability) { double(current_user: user) }
@@ -102,7 +100,7 @@ RSpec.describe CurationConcerns::Forms::WorkflowActionForm, no_clean: true do
 
       it 'will send the #handle_action_taken message to CurationConcerns::Workflow::ActionTakenService' do
         expect(CurationConcerns::Workflow::ActionTakenService).to(
-          receive(:handle_action_taken).with(entity: sipity_entity, comment: kind_of(Sipity::Comment), action: an_action, user: user)
+          receive(:handle_action_taken).with(target: work, comment: kind_of(Sipity::Comment), action: an_action, user: user)
         )
         subject
       end

data/spec/indexers/work_indexer_spec.rb

@@ -37,30 +37,34 @@ describe CurationConcerns::WorkIndexer do
     end
   end
 
-  context "the object status" do
+  describe 'suppressed state' do
+    before { allow(work).to receive(:suppressed?).and_return(suppressed) }
     context "when suppressed" do
-      before { allow(work).to receive(:suppressed?).and_return(true) }
-
-      it "indexed the suppressed field" do
+      let(:suppressed) { true }
+      it "indexes the suppressed field with a true value" do
         expect(solr_document.fetch('suppressed_bsi')).to be true
       end
     end
 
     context "when not suppressed" do
-      it "indexed the suppressed field" do
+      let(:suppressed) { false }
+      it "indexes the suppressed field with a false value" do
         expect(solr_document.fetch('suppressed_bsi')).to be false
       end
     end
   end
 
   context "the actionable workflow roles" do
+    let!(:sipity_entity) do
+      create(:sipity_entity, proxy_for_global_id: work.to_global_id.to_s)
+    end
     before do
-      allow(PowerConverter).to receive(:convert_to_sipity_entity).with(work).and_return(create(:sipity_entity))
+      allow(PowerConverter).to receive(:convert_to_sipity_entity).with(work).and_return(sipity_entity)
       allow(CurationConcerns::Workflow::PermissionQuery).to receive(:scope_roles_associated_with_the_given_entity)
         .and_return(['approve', 'reject'])
     end
     it "indexed the roles and state" do
-      expect(solr_document.fetch('actionable_workflow_roles_ssim')).to eq ["generic_work-approve", "generic_work-reject"]
+      expect(solr_document.fetch('actionable_workflow_roles_ssim')).to eq ["#{sipity_entity.workflow.name}-approve", "#{sipity_entity.workflow.name}-reject"]
       expect(solr_document.fetch('workflow_state_name_ssim')).to eq "initial"
     end
   end

data/spec/jobs/characterize_job_spec.rb

@@ -4,8 +4,8 @@ describe CharacterizeJob do
   include CurationConcerns::FactoryHelpers
 
   let(:file_set)    { FileSet.new(id: file_set_id) }
-  let(:file_set_id) { 'abc12345678' }
-  let(:file_path)   { Rails.root + 'tmp' + 'uploads' + 'ab' + 'c1' + '23' + '45' + 'picture.png' }
+  let(:file_set_id) { 'abc12345' }
+  let(:file_path)   { Rails.root + 'tmp' + 'uploads' + 'ab' + 'c1' + '23' + '45' + 'abc12345' + 'picture.png' }
   let(:filename)    { file_path.to_s }
   let(:file) do
     Hydra::PCDM::File.new.tap do |f|

data/spec/models/curation_concerns/work_behavior_spec.rb

@@ -13,7 +13,7 @@ describe CurationConcerns::WorkBehavior do
   subject { EssentialWork.new }
 
   it 'mixes together all the goodness' do
-    [::CurationConcerns::WithFileSets, ::CurationConcerns::HumanReadableType, CurationConcerns::Noid, CurationConcerns::Serializers, Hydra::WithDepositor, Hydra::AccessControls::Embargoable, Solrizer::Common].each do |mixin|
+    [::CurationConcerns::WithFileSets, ::CurationConcerns::HumanReadableType, CurationConcerns::Noid, CurationConcerns::Serializers, Hydra::WithDepositor, Hydra::AccessControls::Embargoable, Solrizer::Common, ::CurationConcerns::Suppressible].each do |mixin|
       expect(subject.class.ancestors).to include(mixin)
     end
   end

data/spec/models/generic_work_spec.rb

@@ -35,16 +35,25 @@ describe GenericWork do
 
   describe '#suppressed?' do
     let(:work) { described_class.new(state: state) }
-    subject { work.suppressed? }
-
-    context "when the state is 'pending'" do
-      let(:state) { 'pending' }
-      it { is_expected.to be true }
+    context "when state is inactive" do
+      let(:state) { ::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#inactive') }
+      it 'is suppressed' do
+        expect(work).to be_suppressed
+      end
     end
 
-    context "when the state is something else" do
+    context "when the state is active" do
       let(:state) { ::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#active') }
-      it { is_expected.to be false }
+      it 'is not suppressed' do
+        expect(work).not_to be_suppressed
+      end
+    end
+
+    context "when the state is nil" do
+      let(:state) { nil }
+      it 'is not suppressed' do
+        expect(work).not_to be_suppressed
+      end
     end
   end
 

data/spec/models/solr_document_spec.rb

@@ -22,6 +22,19 @@ describe SolrDocument do
     it { is_expected.to eq 'one' }
   end
 
+  describe "#suppressed?" do
+    let(:attributes) { { 'suppressed_bsi' => suppressed_value } }
+    subject { document }
+    context 'when true' do
+      let(:suppressed_value) { true }
+      it { is_expected.to be_suppressed }
+    end
+    context 'when false' do
+      let(:suppressed_value) { false }
+      it { is_expected.not_to be_suppressed }
+    end
+  end
+
   describe "creator" do
     subject { document.creator }