curation_concerns 0.1.0

data/spec/features/embargo_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe 'embargo' do
+  let(:user) { FactoryGirl.create(:user) }
+  before do
+    sign_in user
+  end
+  describe "creating an embargoed object" do
+    before do
+      visit '/'
+    end
+
+    let(:future_date) { 5.days.from_now }
+    let(:later_future_date) { 10.days.from_now }
+
+    it "can be created, displayed and updated" do
+      click_link 'New Generic Work'
+      fill_in 'Title', with: 'Embargo test'
+      choose 'Embargo'
+      fill_in "generic_work_embargo_release_date", with: future_date
+      select 'Private', from: 'Restricted to'
+      select 'Open Access', from: 'then open it up to'
+      click_button 'Create Generic work'
+
+      expect(page).to have_content(future_date.to_datetime.iso8601) # chosen embargo date is on the show page
+
+      click_link "Edit This Generic Work"
+      click_link "Embargo Management Page"
+
+      expect(page).to have_content("This work is under embargo.")
+      expect(page).to have_xpath("//input[@name='generic_work[embargo_release_date]' and @value='#{future_date.to_datetime.iso8601}']")  # current embargo date is pre-populated in edit field
+
+      fill_in "until", with: later_future_date.to_s
+
+      click_button "Update Embargo"
+      expect(page).to have_content(later_future_date.to_date.to_formatted_s(:long_ordinal))
+    end
+  end
+
+  describe "managing embargoes" do
+    before do
+      # admin privs
+      allow_any_instance_of(Ability).to receive(:user_groups).and_return(['admin'])
+    end
+
+    it "should show lists of objects under lease" do
+      visit '/embargoes'
+      expect(page).to have_content 'Manage Embargoes'
+    end
+  end
+end

data/spec/features/lease_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe "leases" do
+  let(:user) { FactoryGirl.create(:user) }
+  before do
+    sign_in user
+  end
+  describe "create a new leased object" do
+
+    let(:future_date) { 5.days.from_now }
+    let(:later_future_date) { 10.days.from_now }
+
+    it "can be created, displayed and updated" do
+      visit '/'
+      click_link 'New Generic Work'
+      fill_in 'Title', with: 'Lease test'
+      choose 'Lease'
+      fill_in "generic_work_lease_expiration_date", with: future_date
+      select 'Open Access', from: 'Is available for'
+      select 'Private', from: 'then restrict it to'
+      click_button 'Create Generic work'
+
+      expect(page).to have_content(future_date.to_datetime.iso8601) # chosen lease date is on the show page
+
+      click_link "Edit This Generic Work"
+      click_link "Lease Management Page"
+
+      expect(page).to have_content("This work is under lease.")
+      expect(page).to have_xpath("//input[@name='generic_work[lease_expiration_date]' and @value='#{future_date.to_datetime.iso8601}']")  # current lease date is pre-populated in edit field
+
+      fill_in "until", with: later_future_date.to_s
+
+      click_button "Update Lease"
+      expect(page).to have_content(later_future_date.to_date.to_formatted_s(:long_ordinal))  # new lease date is displayed in message
+    end
+
+  end
+
+  describe "managing leases" do
+    before do
+      # admin privs
+      allow_any_instance_of(Ability).to receive(:user_groups).and_return(['admin'])
+    end
+    it "should show lists of objects under lease" do
+      visit '/leases'
+      expect(page).to have_content 'Manage Leases'
+    end
+  end
+end

data/spec/features/update_file_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe "Editing attached files" do
+  let(:user) { create(:user) }
+  let!(:parent) { create(:work_with_one_file, user: user) }
+  let!(:generic_file) { parent.generic_files.first }
+
+  before do
+    sign_in user
+
+    # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
+    s2 = double('resque message')
+    expect(CharacterizeJob).to receive(:new).and_return(s2)
+    expect(CurationConcerns.queue).to receive(:push).with(s2).once
+  end
+
+  it "updates the file" do
+    visit "/concern/generic_works/#{parent.id}"
+    click_link 'Edit'
+    expect(page).to have_content "Updating Attached File to \"Test title\""
+
+    attach_file("Upload a file", fixture_file_path('files/image.png'))
+    click_button "Update Attached File"
+
+    expect(page).to have_content "The file A Contained Generic File has been updated."
+
+    #TODO this stuff belongs in an Actor or Controller test:
+    generic_file.reload
+    expect(generic_file.original_file.original_name).to eq 'image.png'
+    expect(generic_file.original_file.mime_type).to eq 'image/png'
+  end
+end

data/spec/features/work_generator_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+require 'rails/generators'
+
+describe "Creating a new Work" do
+  let(:user) { FactoryGirl.create(:user) }
+
+  before do
+    Rails::Generators.invoke("curation_concerns:work", ["Catapult"], destination_root: Rails.root)
+    load 'spec/internal/app/models/catapult.rb'
+    load 'spec/internal/app/controllers/curation_concerns/catapults_controller.rb'
+    load 'spec/internal/app/actors/curation_concerns/catapult_actor.rb'
+    load 'spec/internal/config/initializers/curation_concerns_config.rb'
+    load 'spec/internal/config/routes.rb'
+    load 'app/helpers/curation_concerns/url_helper.rb'
+    sign_in user
+
+    # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
+    s2 = double('resque message')
+    expect(CharacterizeJob).to receive(:new).and_return(s2)
+    expect(CurationConcerns.queue).to receive(:push).with(s2).once
+  end
+
+  after do
+    Rails::Generators.invoke("curation_concerns:work", ["Catapult"], behavior: :revoke, destination_root: Rails.root)
+  end
+
+  it "catapults should behave like generic works" do
+    visit "/concern/catapults/new"
+    # within("form.new_generic_file") do
+    #   attach_file("Upload a file", fixture_file_path('files/image.png'))
+    #   click_button "Attach to Generic Work"
+    # end
+    catapult_title = 'My Test Work'
+    within("form.new_catapult") do
+      fill_in("Title", with: catapult_title)
+      attach_file("Upload a file", fixture_file_path('files/image.png'))
+      choose("visibility_open")
+      click_on("Create Catapult")
+    end
+    click_on("Edit This Catapult")
+    within("form.edit_catapult") do
+      fill_in("Subject", with: 'test')
+      click_on("Update Catapult")
+    end
+    title = "Genealogies of the American West"
+    click_link 'Add a Collection'
+    fill_in('Title', with: title)
+    click_button("Create Collection")
+    click_on("Add files from your dashboard")
+    find("#facet-human_readable_type_sim").click_link('Catapult')
+    within(".modal.fade", :match => :first) do
+      select title, :from => "id"
+      click_on("Add to collection")
+    end
+    expect(page).to have_content('Collection was successfully updated.')
+    expect(page).to have_content(catapult_title)
+  end
+end

data/spec/fixtures/curation_concerns_generic_stub.txt

@@ -0,0 +1 @@
+This is a test fixture for curation_concerns: <%= @id %>.

data/spec/fixtures/small_file.txt

@@ -0,0 +1 @@
+small

data/spec/forms/collection_edit_form_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe CurationConcerns::Forms::CollectionEditForm do
+  let(:collection) { Collection.new }
+  let(:form) { described_class.new(collection) }
+
+  describe "#terms" do
+    subject { form.terms}
+    it { is_expected.to eq [:resource_type, :title, :creator, :contributor, :description,
+                            :tag, :rights, :publisher, :date_created, :subject, :language,
+                            :identifier, :based_near, :related_url] }
+  end
+
+  describe "unique?" do
+    context "with :title" do
+      subject { CurationConcerns::Forms::CollectionEditForm.unique?(:title) }
+      it { is_expected.to be true }
+    end
+  end
+end

data/spec/forms/generic_file_edit_form_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe CurationConcerns::Forms::GenericFileEditForm do
+  subject { described_class.new(GenericFile.new) }
+
+  describe "#terms" do
+    it "should return a list" do
+      expect(subject.terms).to eq([:resource_type, :title, :creator, :contributor, :description, :tag,
+                    :rights, :publisher, :date_created, :subject, :language, :identifier, :based_near, :related_url])
+    end
+
+    it "doesn't contain fields that users shouldn't be allowed to edit" do
+      # date_uploaded is reserved for the original creation date of the record.
+      expect(subject.terms).not_to include(:date_uploaded)
+    end
+  end
+
+  it "should initialize multivalued fields" do
+    expect(subject.title).to eq ['']
+  end
+
+  describe ".model_attributes" do
+    let(:params) { ActionController::Parameters.new(title: ['foo'], description: [''], "permissions_attributes"=>{"2"=>{"access"=>"edit", "_destroy"=>"true", "id"=>"a987551e-b87f-427a-8721-3e5942273125"}})}
+    subject { described_class.model_attributes(params) }
+
+    it "should only change title" do
+      expect(subject['title']).to eq ["foo"]
+      expect(subject['description']).to be_empty
+      expect(subject['permissions_attributes']).to eq("2" => {"access"=>"edit", "id"=>"a987551e-b87f-427a-8721-3e5942273125", "_destroy"=>"true"})
+    end
+  end
+
+end

data/spec/helpers/catalog_helper_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe CurationConcerns::CatalogHelper do
+  before do
+    helper.params[:controller] = 'catalog'
+    allow(helper).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
+    allow(helper).to receive(:search_action_path) do |*args|
+      catalog_index_path *args
+    end
+  end
+
+  describe "all_type_tab" do
+    subject { helper.all_type_tab('All') }
+
+    context "when it is the active tab" do
+      it { should eq "<li class=\"active\"><a href=\"#\">All</a></li>" }
+    end
+
+    context "when it is not the active tab" do
+      before do
+        helper.params[:f] = { 'generic_type_sim' => ['Work'] }
+      end
+      it { should eq "<li><a href=\"/catalog\">All</a></li>" }
+    end
+
+    context "when other parameters are present" do
+      before do
+        helper.params[:f] = { 'generic_type_sim' => ['Work'] }
+        helper.params[:page] = 4
+      end
+      it("should clear them") { should eq "<li><a href=\"/catalog\">All</a></li>" }
+    end
+  end
+
+  describe "type_tab" do
+    subject { helper.type_tab('Works', 'Work') }
+
+    context "when it is the active tab" do
+      before do
+        helper.params[:f] = { 'generic_type_sim' => ['Work'] }
+      end
+      it { should eq "<li class=\"active\"><a href=\"#\">Works</a></li>" }
+    end
+
+    context "when it is not the active tab" do
+      it { should eq "<li><a href=\"/catalog?f%5Bgeneric_type_sim%5D%5B%5D=Work\">Works</a></li>" }
+    end
+
+    # context "when other parameters are present" do
+    #   before do
+    #     helper.params[:f] = { 'generic_type_sim' => ['Collection'] }
+    #     helper.params[:page] = 4
+    #   end
+    #   it("should clear them") { should eq "<li><a href=\"/catalog?f%5Bgeneric_type_sim%5D%5B%5D=Work\">Works</a></li>" }
+    # end
+  end
+
+end

data/spec/helpers/configuration_helper_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Blacklight::ConfigurationHelperBehavior do
+
+  describe "creator facet" do
+    before do
+      allow(helper).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
+    end
+    let(:field) { 'creator_sim' }
+    subject { helper.facet_field_label field }
+    it { should eq 'Creator' }
+  end
+end

data/spec/helpers/curation_concerns/collections_helper_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe CurationConcerns::CollectionsHelper do
+
+  describe "#link_to_select_collection" do
+    let(:collection) { double(id: '123') }
+    let(:collectible) { double(id: '456', human_readable_type: 'Generic Work', to_param: '456') }
+    before do
+      assign(:collection, collection)
+    end
+    subject { helper.link_to_select_collection(collectible) }
+
+    it "has a link that pops up a modal" do
+      expect(subject).to have_selector 'a[data-toggle=modal][data-target="#456-modal"]'
+      expect(subject).to have_link 'Add to a Collection', href: '#'
+    end
+  end
+
+  describe "#link_to_remove_from_collection" do
+    let(:collection) { double(id: '123') }
+    let(:collectible) { double(id: '456') }
+    before do
+      assign(:collection, collection)
+    end
+    subject { helper.link_to_remove_from_collection(collectible) }
+
+    it "has a form that routes to remove the collectible" do
+      expect(subject).to have_selector 'a[data-method=put]'
+      expect(subject).to have_link 'Remove From Collection',
+        href: collections.collection_path('123', collection: { members: 'remove'},
+                                          batch_document_ids: [ '456' ])
+    end
+  end
+
+  describe "#collection_options_for_select" do
+    before do
+      allow(helper).to receive(:current_user).and_return(user)
+    end
+    let(:user) { FactoryGirl.create(:user) }
+    let!(:collection1) { FactoryGirl.create(:collection, user: user, title: 'One') }
+    let!(:collection2) { FactoryGirl.create(:collection, user: user, title: 'Two') }
+    let!(:collection3) { FactoryGirl.create(:collection, user: user, title: 'Three') }
+    subject { helper.collection_options_for_select(collection2) }
+
+    it "excludes the passed in collection" do
+      expect(subject).to eq "<option value=\"#{collection1.id}\">#{collection1.title}</option>\n<option value=\"#{collection3.id}\">#{collection3.title}</option>"
+    end
+  end
+end

data/spec/helpers/render_constraints_helper_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe CurationConcernsHelper do
+  describe "render_constraints_query" do
+    before do
+      # Stub methods from Blacklight::SearchFields
+      allow(helper).to receive(:default_search_field).and_return(CatalogController.blacklight_config.default_search_field)
+      allow(helper).to receive(:label_for_search_field).and_return("Foo")
+    end
+
+    let(:search_params) { { q: 'Simon', search_field: 'publisher', controller: 'catalog' } }
+    subject { helper.render_constraints_query(search_params) }
+
+    it "removes search_field" do
+      node = Capybara::Node::Simple.new(subject)
+      expect(node).to have_link 'Remove constraint Foo: Simon', href: '/'
+    end
+  end
+end

data/spec/helpers/thumbnail_helper_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe CurationConcerns::ThumbnailHelper do
+  let(:work) { GenericWork.new }
+  let(:document) { SolrDocument.new work.to_solr }
+  subject { helper.thumbnail_tag document, {} }
+
+  context "with a representative" do
+    before do
+      allow(work).to receive(:representative).and_return('curation_concerns:test123')
+    end
+    it "draws the thumbnail" do
+      expect(subject).to eq "<img alt=\"Thumbnail\" class=\"canonical-image\" " \
+        "src=\"/downloads/curation_concerns:test123?datastream_id=thumbnail\" />"
+    end
+  end
+
+  it "draws the default thumbnail" do
+    expect(subject).to eq "<span class=\"canonical-image\"></span>"
+  end
+end

data/spec/helpers/url_helper_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe CurationConcerns::UrlHelper do
+  before do
+    GenericWork.destroy_all
+  end
+  let(:profile) { ["{\"datastreams\":{}}"] }
+  let(:work) { FactoryGirl.create(:generic_work) }
+  let(:document) { SolrDocument.new(work.to_solr) }
+  subject { helper.url_for_document document }
+
+  it { should eq "/concern/generic_works/#{work.id}" }
+  it "should use the curation_concern namespace" do
+    expect(helper.url_for_document document).to eq "/concern/generic_works/#{work.id}"
+  end
+  context "when document is a GenericFile" do
+    let(:file) { FactoryGirl.create(:generic_file) }
+    subject { helper.url_for_document file }
+    it { should eq "/concern/generic_files/#{file.id}" }
+  end
+end
+

data/spec/jobs/active_fedora_id_based_job_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe ActiveFedoraIdBasedJob do
+  let (:user) {FactoryGirl.find_or_create(:jill)}
+  let (:file) {GenericFile.new.tap do |gf|
+                  gf.apply_depositor_metadata(user)
+                  gf.save!
+                end}
+
+  it "finds object" do
+    job = ActiveFedoraIdBasedJob.new(file.id)
+    expect(job.generic_file).to_not be_nil
+  end
+end

data/spec/jobs/audit_job_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe AuditJob do
+  let(:user) { FactoryGirl.create(:user) }
+
+  let(:file) do
+    generic_file = GenericFile.create do |file|
+      file.apply_depositor_metadata(user)
+      Hydra::Works::AddFileToGenericFile.call(file, File.open(fixture_file_path('world.png')), :original_file, versioning: true)
+    end
+  end
+  let(:file_id) { file.original_file.id }
+
+  let(:job) { AuditJob.new(file.id, file_id, uri) }
+
+  describe "audit on content" do
+    let(:uri) { file.original_file.uri }
+    it "should pass" do
+      expect(job.run).to eq(true)
+    end
+  end
+
+  describe "audit on a version of the content" do
+    let(:uri) { CurationConcerns::VersioningService.latest_version_of(file.original_file).uri }
+    it "should pass" do
+      expect(job.run).to eq(true)
+    end
+  end
+
+  describe "audit on an invalid version of the content" do
+    let(:uri) { CurationConcerns::VersioningService.latest_version_of(file.original_file).uri + "bogus" }
+    it "should fail" do
+      expect(job.run).to eq(false)
+    end
+  end
+
+  describe "run_audit" do
+    let(:uri) { CurationConcerns::VersioningService.latest_version_of(file.original_file).uri }
+    let!(:old) { ChecksumAuditLog.create(generic_file_id: file.id, file_id: file_id, version: uri, pass: 1, created_at: 2.minutes.ago) }
+    let!(:new) { ChecksumAuditLog.create(generic_file_id: file.id, file_id: file_id, version: uri, pass: 0) }
+    let(:mock_service) { double('mock fixity check service') }
+  
+    before do
+      allow(ActiveFedora::FixityService).to receive(:new).and_return(mock_service)
+      allow(mock_service).to receive(:check).and_return(true, false, false, true, false)
+    end
+  
+    it "should not prune failed audits" do
+      5.times { job.send(:run_audit) }
+      expect(ChecksumAuditLog.logs_for(file.id, file_id).map(&:pass)).to eq [0, 1, 0, 0, 1, 0, 1]
+    end
+  end
+end

data/spec/jobs/characterize_job_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe CharacterizeJob do
+  let(:user) { FactoryGirl.find_or_create(:jill) }
+
+  let(:generic_file) do
+    GenericFile.create do |file|
+      file.apply_depositor_metadata(user)
+      Hydra::Works::AddFileToGenericFile.call(file, File.open(fixture_file_path('charter.docx')), :original_file)
+    end
+  end
+
+  subject { CharacterizeJob.new(generic_file.id) }
+
+  # Now that CreateDerivativesJob calls generic_file.create_derivatives directly
+  # this test needs to be travis exempt.  
+  it 'runs CurationConcerns::CharacterizationService that spawns a CreateDerivativesJob', unless: $in_travis do
+    expect(CurationConcerns::CharacterizationService).to receive(:run).with(generic_file)
+    expect(CreateDerivativesJob).to receive(:new).with(generic_file.id).once.and_call_original
+    subject.run
+  end
+
+end

data/spec/jobs/copy_permissions_job_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe CopyPermissionsJob do
+
+  let(:user) { FactoryGirl.create(:user) }
+  context 'for valid pid' do
+    let(:generic_work) { FactoryGirl.create(:generic_work, user: user ) }
+    let(:another_user) { FactoryGirl.create(:user) }
+    let(:generic_file_1) { FactoryGirl.create(:generic_file, user: user) }
+    let(:generic_file_2) { FactoryGirl.create(:generic_file, user: user) }
+
+    before do
+      generic_work.edit_users += [another_user]
+      generic_work.generic_files = [generic_file_1, generic_file_2]
+      generic_work.save
+    end
+    subject { CopyPermissionsJob.new(generic_work.id) }
+
+    it 'applies group/editors permissions to attached files' do
+
+      expect(generic_work.generic_files).to eq [generic_file_1, generic_file_2]
+      expect(generic_work.edit_users).to eq [user.user_key, another_user.user_key]
+      expect(generic_file_1.edit_users).to eq [user.user_key]
+      expect(generic_file_2.edit_users).to eq [user.user_key]
+      generic_work.save
+
+      subject.run
+
+      generic_work.reload.generic_files.each do |file|
+        expect(file.edit_users).to eq [user.user_key, another_user.user_key]
+      end
+    end
+  end
+
+  describe "an open access work" do
+    let(:generic_work) { FactoryGirl.create(:work_with_files) }
+    subject { CopyPermissionsJob.new(generic_work.id) }
+
+    it "copies visibility to its contained files" do
+      generic_work.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+      generic_work.save
+      expect(generic_work.generic_files.first.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE
+      subject.run
+      generic_work.reload.generic_files.each do |file|
+        expect(file.visibility).to eq 'open'
+      end
+    end
+  end
+end

data/spec/jobs/create_derivatives_job_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe CurationConcerns::CreateDerivativesJob do
+  before do
+    @ffmpeg_enabled = CurationConcerns.config.enable_ffmpeg
+    CurationConcerns.config.enable_ffmpeg = true
+    allow(ActiveFedora::Base).to receive(:find).with('123').and_return(generic_file)
+    allow(generic_file).to receive(:original_file).and_return(double("orignal_file", :has_content? => true))
+  end
+  let(:generic_file) { GenericFile.new }
+
+  after do
+    CurationConcerns.config.enable_ffmpeg = @ffmpeg_enabled
+  end
+
+  subject { CreateDerivativesJob.new('123') }
+
+  it "should call create_derivatives and save on a generic_file" do
+    expect(generic_file).to receive(:create_derivatives)
+    expect(generic_file).to receive(:save)
+    subject.run
+  end
+end