curation_concerns 0.1.0

data/spec/controllers/embargoes_controller_spec.rb

@@ -0,0 +1,114 @@
+require 'spec_helper'
+
+describe EmbargoesController do
+  let(:user) { FactoryGirl.create(:user) }
+  let(:a_work) { FactoryGirl.create(:generic_work, user: user) }
+  let(:not_my_work) { FactoryGirl.create(:generic_work) }
+
+  before { sign_in user }
+
+  describe "#index" do
+    context "when I am NOT a repository manager" do
+      it "should redirect" do
+        get :index
+        expect(response).to redirect_to root_path
+      end
+    end
+    context "when I am a repository manager" do
+      before { allow_any_instance_of(User).to receive(:groups).and_return(['admin']) }
+      it "should show me the page" do
+        get :index
+        expect(response).to be_success
+      end
+    end
+  end
+
+  describe "#edit" do
+    context "when I do not have edit permissions for the object" do
+      it "should redirect" do
+        get :edit, id: not_my_work
+        expect(response.status).to eq 302
+        expect(flash[:alert]).to eq 'You are not authorized to access this page.'
+      end
+    end
+    context "when I have permission to edit the object" do
+      it "should show me the page" do
+        get :edit, id: a_work
+        expect(response).to be_success
+      end
+    end
+  end
+
+
+
+  describe "#destroy" do
+    context "when I do not have edit permissions for the object" do
+      it "should deny access" do
+        get :destroy, id: not_my_work
+        expect(response).to fail_redirect_and_flash(root_path, 'You are not authorized to access this page.') 
+      end
+    end
+
+    context "when I have permission to edit the object" do
+      before do
+        expect(ActiveFedora::Base).to receive(:find).with(a_work.id).and_return(a_work)
+        a_work.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
+        a_work.visibility_during_embargo = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
+        a_work.visibility_after_embargo = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+        a_work.embargo_release_date = release_date.to_s
+        a_work.save(validate: false)
+        get :destroy, id: a_work
+      end
+
+      context "with an active embargo" do
+        let(:release_date) { Date.today+2 }
+
+        it "should deactivate embargo without updating visibility and redirect" do
+          expect(a_work.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
+          expect(response).to redirect_to edit_embargo_path(a_work)
+        end
+      end
+
+      context "with an expired embargo" do
+        let(:release_date) { Date.today-2 }
+
+        it "should deactivate embargo, update the visibility and redirect" do
+          expect(a_work.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+          expect(response).to redirect_to confirm_curation_concerns_permission_path(a_work)
+        end
+      end
+    end
+  end
+
+  describe "#update" do
+    context "when I have permission to edit the object" do
+      let(:a_file) { FactoryGirl.create(:generic_file, visibility: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED) }
+      let(:release_date) { Date.today+2 }
+      before do
+        a_work.generic_files << a_file
+        a_work.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
+        a_work.visibility_during_embargo = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
+        a_work.visibility_after_embargo = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+        a_work.embargo_release_date = release_date.to_s
+        a_work.embargo.save(validate: false)
+        a_work.save(validate: false)
+      end
+
+      it "should copy visibility from curation_concern to all of the identified files" do
+        pending "Is this ever used?  If so, write this test!"
+        fail
+        patch :update, batch_document_ids: [a_work.id], embargoes: { "0" => { copy_visibility: a_work.id} }
+      end
+
+      context "with an expired embargo" do
+        let(:release_date) { Date.today-2 }
+        it "should deactivate embargo, update the visibility and redirect" do
+          patch :update, batch_document_ids: [a_work.id], embargoes: { "0" => { copy_visibility: a_work.id} }
+          expect(a_work.reload.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+          expect(a_file.reload.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+          expect(response).to redirect_to embargoes_path
+        end
+      end
+    end
+  end
+end

data/spec/controllers/leases_controller_spec.rb

@@ -0,0 +1,94 @@
+require 'spec_helper'
+
+describe LeasesController do
+  let(:user) { FactoryGirl.create(:user) }
+  let(:a_work) { FactoryGirl.create(:generic_work, user: user) }
+  let(:not_my_work) { FactoryGirl.create(:generic_work) }
+
+  before { sign_in user }
+
+  describe "#index" do
+    context "when I am NOT a repository manager" do
+      it "should redirect" do
+        get :index
+        expect(response).to redirect_to root_path
+      end
+    end
+    context "when I am a repository manager" do
+      before { allow_any_instance_of(User).to receive(:groups).and_return(['admin']) }
+      it "should show me the page" do
+        get :index
+        expect(response).to be_success
+      end
+    end
+  end
+
+  describe "#edit" do
+    context "when I do not have edit permissions for the object" do
+      it "should redirect" do
+        get :edit, id: not_my_work
+        expect(response.status).to eq 302
+        expect(flash[:alert]).to eq 'You are not authorized to access this page.'
+      end
+    end
+    context "when I have permission to edit the object" do
+      it "should show me the page" do
+        get :edit, id: a_work
+        expect(response).to be_success
+      end
+    end
+  end
+
+
+
+  describe "#destroy" do
+    context "when I do not have edit permissions for the object" do
+      it "should deny access" do
+        get :destroy, id: not_my_work
+        expect(response).to fail_redirect_and_flash(root_path, 'You are not authorized to access this page.')
+      end
+    end
+
+    context "when I have permission to edit the object" do
+      before do
+        expect(ActiveFedora::Base).to receive(:find).with(a_work.id).and_return(a_work)
+        a_work.visibility_during_lease = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+        a_work.visibility_after_lease = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE
+        a_work.lease_expiration_date = release_date.to_s
+        expect(CurationConcerns.queue).to receive(:push).with(an_instance_of(VisibilityCopyWorker))
+        get :destroy, id: a_work
+      end
+
+      context "with an active lease" do
+        let(:release_date) { Date.today+2 }
+        it "should deactivate the lease without updating visibility and redirect" do
+          expect(a_work.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+          expect(response).to redirect_to edit_lease_path(a_work)
+        end
+      end
+
+      context "with an expired lease" do
+        let(:release_date) { Date.today-2 }
+
+        it "should deactivate the lease, update the visibility and redirect" do
+          expect(a_work.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE
+          expect(response).to redirect_to edit_lease_path(a_work)
+        end
+      end
+    end
+  end
+
+  describe "#update" do
+    context "when I have permission to edit the object" do
+      before do
+        expect(ActiveFedora::Base).to receive(:find).with(a_work.id).and_return(a_work)
+      end
+      it "should deactivate lease and redirect" do
+        expect(a_work).to receive(:deactivate_lease!)
+        expect(a_work).to receive(:save)
+        patch :update, batch_document_ids: [a_work.id]
+        expect(response).to redirect_to leases_path
+      end
+    end
+  end
+end

data/spec/factories/collections.rb

@@ -0,0 +1,15 @@
+FactoryGirl.define do
+  # The ::Collection model is defined in spec/internal/app/models by the
+  # curation_concerns:install generator.
+  factory :collection do
+    transient do
+      user { FactoryGirl.create(:user) }
+    end
+
+    title "Test collection title"
+
+    after(:build) do |collection, evaluator|
+      collection.apply_depositor_metadata(evaluator.user.user_key)
+    end
+  end
+end

data/spec/factories/create_curation_concern.rb

@@ -0,0 +1,3 @@
+def FactoryGirl.create_curation_concern(factory_name, user, override_attributes = {})
+  FactoryGirl.create(factory_name, override_attributes.merge(user: user))
+end

data/spec/factories/generic_files.rb

@@ -0,0 +1,31 @@
+FactoryGirl.define do
+  # The ::GenericFile model is defined in spec/internal/app/models by the
+  # curation_concerns:install generator.
+  factory :generic_file, class: GenericFile do
+    transient do
+      user { FactoryGirl.create(:user) }
+      content nil
+    end
+
+    after(:create) do |file, evaluator|
+      if evaluator.content
+        Hydra::Works::UploadFileToGenericFile.call(file, evaluator.content)
+      end
+    end
+
+    factory :file_with_work do
+      after(:build) do |file, evaluator|
+        file.title = ['testfile']
+      end
+      after(:create) do |file, evaluator|
+        if evaluator.content
+          Hydra::Works::UploadFileToGenericFile.call(file, evaluator.content)
+        end
+        FactoryGirl.create(:generic_work, user: evaluator.user).generic_files << file
+      end
+    end
+    after(:build) do |file, evaluator|
+      file.apply_depositor_metadata(evaluator.user.user_key)
+    end
+  end
+end

data/spec/factories/generic_works.rb

@@ -0,0 +1,54 @@
+FactoryGirl.define do
+  # The ::GenericWork model is defined in spec/internal/app/models by the
+  # curation_concerns:install generator.
+  factory :generic_work, aliases: [:work, :private_generic_work], class: GenericWork do
+    transient do
+      user { FactoryGirl.create(:user) }
+    end
+
+    title ["Test title"]
+    visibility Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE
+
+    after(:build) do |work, evaluator|
+      work.apply_depositor_metadata(evaluator.user.user_key)
+    end
+
+
+    factory :public_generic_work do
+      visibility Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
+    end
+
+    factory :work_with_one_file do
+      before(:create) do |work, evaluator|
+        work.generic_files << FactoryGirl.create(:generic_file, user: evaluator.user, title:['A Contained Generic File'], filename:['filename.pdf'])
+      end
+    end
+
+    factory :work_with_files do
+      before(:create) { |work, evaluator| 2.times { work.generic_files << FactoryGirl.create(:generic_file, user: evaluator.user) } }
+    end
+
+    factory :with_embargo_date do
+      transient do
+        embargo_date { Date.tomorrow.to_s }
+      end
+      factory :embargoed_work do
+        after(:build) { |work, evaluator| work.apply_embargo(evaluator.embargo_date, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC) }
+      end
+
+      factory :embargoed_work_with_files do
+        after(:build) { |work, evaluator| work.apply_embargo(evaluator.embargo_date, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC) }
+        after(:create) { |work, evaluator| 2.times { work.generic_files << FactoryGirl.create(:generic_file, user: evaluator.user) } }
+      end
+
+      factory :leased_work do
+        after(:build) { |work, evaluator| work.apply_lease(evaluator.embargo_date, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE) }
+      end
+
+      factory :leased_work_with_files do
+        after(:build) { |work, evaluator| work.apply_lease(evaluator.embargo_date, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC, Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE) }
+        after(:create) { |work, evaluator| 2.times { work.generic_files << FactoryGirl.create(:generic_file, user: evaluator.user) } }
+      end
+    end
+  end
+end

data/spec/factories/users.rb

@@ -0,0 +1,28 @@
+FactoryGirl.define do
+  factory :user do
+    sequence(:email) {|n| "email-#{srand}@test.com" }
+    password 'a password'
+    password_confirmation 'a password'
+    factory :admin do
+      after(:build) do |user|
+        def user.groups
+          ["admin"]
+        end
+      end
+    end
+
+    factory :jill do
+      email 'jilluser@example.com'
+    end
+
+    factory :archivist, aliases: [:user_with_fixtures] do
+      email 'archivist1@example.com'
+    end
+
+    factory :curator do
+      email 'curator1@example.com'
+    end
+
+  end
+
+end

data/spec/features/add_file_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe "Add an attached file" do
+  let(:user) { FactoryGirl.create(:user) }
+  let!(:work) { FactoryGirl.create(:work, user: user) }
+
+  before do
+    sign_in user
+    # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
+    s2 = double('resque message')
+    expect(CharacterizeJob).to receive(:new).and_return(s2)
+    expect(CurationConcerns.queue).to receive(:push).with(s2).once
+  end
+
+  it "should update the file" do
+    visit "/concern/generic_works/#{work.id}"
+    click_link 'Attach a File'
+
+    within("form.new_generic_file") do
+      fill_in("Title", with: 'image.png')
+      attach_file("Upload a file", fixture_file_path('files/image.png'))
+      click_on("Attach to Generic Work")
+    end
+
+    visit "/concern/generic_works/#{work.id}"
+    within '.related_files' do
+      expect(page).to have_link "image.png"
+    end
+  end
+end

data/spec/features/collection_spec.rb

@@ -0,0 +1,222 @@
+require 'spec_helper'
+include CurationConcerns::SearchPathsHelper
+
+describe 'collection' do
+  def create_collection(title, description)
+    click_link 'Add a Collection'
+    fill_in('Title', with: title)
+    fill_in('collection_description', with: description)
+    click_button("Create Collection")
+    expect(page).to have_content 'Items in this Collection'
+    expect(page).to have_content title
+    expect(page).to have_content description
+  end
+
+  let(:title1) {"Test Collection 1"}
+  let(:description1) {"Description for collection 1 we are testing."}
+  let(:title2) {"Test Collection 2"}
+  let(:description2) {"Description for collection 2 we are testing."}
+
+  let(:user) { FactoryGirl.create(:user, email: 'user1@example.com') }
+  let(:user_key) { user.user_key }
+  let(:generic_works) do
+    (0..12).map do |x|
+      GenericWork.new.tap do |f|
+        f.title = ["title #{x}"]
+        f.apply_depositor_metadata('user1@example.com')
+        f.save!
+      end
+    end
+  end
+  let(:gw1) { generic_works[0]}
+  let(:gw2) { generic_works[1]}
+
+  before(:all) do
+    @old_resque_inline_value = Resque.inline
+    Resque.inline = true
+  end
+
+  after(:all) do
+    Resque.inline = @old_resque_inline_value
+    GenericWork.destroy_all
+    Collection.destroy_all
+  end
+
+  describe 'create collection' do
+    before do
+      sign_in user
+      visit search_path_for_my_collections
+    end
+    it "should create a collection" do
+      title = "Genealogies of the American West"
+      description = "All about Genealogies of the American West"
+      click_link 'Add a Collection'
+      fill_in('Title', with: title)
+      fill_in('collection_description', with: description)
+      click_button("Create Collection")
+      expect(page).to have_content 'Items in this Collection'
+      expect(page).to have_content title
+      expect(page).to have_content description
+    end
+  end
+
+  describe 'delete collection' do
+    before (:each) do
+      @collection = Collection.new title:'collection title'
+      @collection.description = 'collection description'
+      @collection.apply_depositor_metadata(user_key)
+      @collection.save
+      sign_in user
+      visit main_app.catalog_index_path(:'f[generic_type_sim][]' => 'Collection', works: 'mine')
+    end
+
+    it "should delete a collection" do
+      expect(page).to have_content(@collection.title)
+      within("#document_#{@collection.id}") do
+        first(".itemtrash").click
+      end
+      expect(page).to_not have_content(@collection.title)
+      expect(page).to have_content("Collection was successfully deleted.")
+    end
+  end
+
+  describe 'show collection' do
+    before do
+      @collection = FactoryGirl.create(:collection, user:user, title: 'collection title', description:'collection description')
+      # @collection = Collection.new title: 'collection title'
+      # @collection.description = ['collection description']
+      # @collection.apply_depositor_metadata(user_key)
+      @collection.members = [gw1,gw2]
+      @collection.save
+      sign_in user
+      visit search_path_for_my_collections
+    end
+
+    it "should show a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      expect(page).to have_content(@collection.title)
+      within('#document_'+@collection.id) do
+        click_link("collection title")
+      end
+      expect(page).to have_content(@collection.title)
+      expect(page).to have_content(@collection.description)
+      # Should have search results / contents listing
+      expect(page).to have_content(gw1.title.first)
+      expect(page).to have_content(gw2.title.first)
+      expect(page).to_not have_css(".pager")
+
+    end
+
+    it "should hide collection descriptive metadata when searching a collection" do
+      expect(page).to have_content(@collection.title)
+      within("#document_#{@collection.id}") do
+        click_link("collection title")
+      end
+      expect(page).to have_content(@collection.title)
+      expect(page).to have_content(@collection.description)
+      expect(page).to have_content(gw1.title.first)
+      expect(page).to have_content(gw2.title.first)
+      fill_in('collection_search', with: gw1.title.first)
+      click_button('collection_submit')
+      # Should not have Collection Descriptive metadata table
+      expect(page).to_not have_content("Descriptions")
+      expect(page).to have_content(@collection.title)
+      expect(page).to have_content(@collection.description)
+      # Should have search results / contents listing
+      expect(page).to have_content(gw1.title.first)
+      expect(page).to_not have_content(gw2.title.first)
+      # Should not have Dashboard content in contents listing
+      expect(page).to_not have_content("Visibility")
+    end
+  end
+
+  describe 'edit collection' do
+    before (:each) do
+      @collection = Collection.new(title: 'Awesome Title')
+      @collection.description = 'collection description'
+      @collection.apply_depositor_metadata(user_key)
+      @collection.members = [gw1, gw2]
+      @collection.save
+      sign_in user
+      visit search_path_for_my_collections
+    end
+
+    it "should edit and update collection metadata" do
+      expect(page).to have_content(@collection.title)
+      within("#document_#{@collection.id}") do
+        click_link('Edit Collection')
+      end
+      expect(page).to have_field('collection_title', with: @collection.title)
+      expect(page).to have_field('collection_description', with: @collection.description)
+      new_title = "Altered Title"
+      new_description = "Completely new Description text."
+      creators = ["Dorje Trollo", "Vajrayogini"]
+      fill_in('Title', with: new_title)
+      fill_in('collection_description', with: new_description)
+      fill_in('Creator', with: creators.first)
+      #within('.form-actions') do
+        click_button('Update Collection')
+      #end
+      expect(page).to_not have_content(@collection.title)
+      expect(page).to_not have_content(@collection.description)
+      expect(page).to have_content(new_title)
+      expect(page).to have_content(new_description)
+      expect(page).to have_content(creators.first)
+    end
+
+    it "should remove a work from a collection" do
+      expect(page).to have_content(@collection.title)
+      within("#document_#{@collection.id}") do
+        click_link('Edit Collection')
+      end
+      expect(page).to have_field('collection_title', with: @collection.title)
+      expect(page).to have_field('collection_description', with: @collection.description)
+      expect(page).to have_content(gw1.title.first)
+      expect(page).to have_content(gw2.title.first)
+      within("#document_#{gw1.id}") do
+        click_link('Remove From Collection')
+      end
+      expect(page).to have_content(@collection.title)
+      expect(page).to have_content(@collection.description)
+      expect(page).to_not have_content(gw1.title.first)
+      expect(page).to have_content(gw2.title.first)
+    end
+
+    it "should remove all works from a collection" do
+      skip "This is from Sufia, not sure if it should be here."
+      expect(page).to have_content(@collection.title)
+      within('#document_'+@collection.id) do
+        click_link('Edit Collection')
+      end
+      expect(page).to have_field('collection_title', with: @collection.title)
+      expect(page).to have_field('collection_description', with: @collection.description)
+      expect(page).to have_content(gw1.title.first)
+      expect(page).to have_content(gw2.title.first)
+      first('input#check_all').click
+      click_link('Remove From Collection')
+      expect(page).to have_content(@collection.title)
+      expect(page).to have_content(@collection.description)
+      expect(page).to_not have_content(gw1.title.first)
+      expect(page).to_not have_content(gw2.title.first)
+    end
+  end
+
+  describe 'show pages of a collection' do
+    before (:each) do
+      @collection = Collection.new title:'collection title'
+      @collection.description = 'collection description'
+      @collection.apply_depositor_metadata(user_key)
+      @collection.members = generic_works
+      @collection.save!
+      sign_in user
+      visit search_path_for_my_collections
+    end
+
+    it "should show a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      expect(page).to have_content(@collection.title)
+      within('#document_'+@collection.id) do
+        click_link("collection title")
+      end
+      expect(page).to have_css(".pager")
+    end
+  end
+end

data/spec/features/create_work_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe "Creating a new Work" do
+  let(:user) { FactoryGirl.create(:user) }
+
+  before do
+    sign_in user
+
+    # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
+    s2 = double('resque message')
+    expect(CharacterizeJob).to receive(:new).and_return(s2)
+    expect(CurationConcerns.queue).to receive(:push).with(s2).once
+  end
+
+  it "should create the work and allow you to attach a file" do
+    visit "/concern/generic_works/new"
+    work_title = 'My Test Work'
+    within("form.new_generic_work") do
+      fill_in("Title", with: work_title)
+      attach_file("Upload a file", fixture_file_path('files/image.png'))
+      choose("visibility_open")
+      click_on("Create Generic work")
+    end
+    within '.related_files' do
+      expect(page).to have_link "image.png"
+    end
+
+    title = "Genealogies of the American West"
+    click_link 'Add a Collection'
+    fill_in('Title', with: title)
+    click_button("Create Collection")
+    click_on("Add files from your dashboard")
+    find("#facet-human_readable_type_sim").click_link('Generic Work')
+
+    # Works can be added to collections
+    within(".modal.fade", :match => :first) do
+      select title, :from => "id"
+      click_on("Add to collection")
+    end
+    expect(page).to have_content('Collection was successfully updated.')
+    expect(page).to have_content(work_title)
+  end
+end