curation_concerns 0.1.0 → 0.2.0

data/spec/services/thumbnail_path_service_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe CurationConcerns::ThumbnailPathService do
+  subject { described_class.call(object) }
+
+  context "with a FileSet" do
+    let(:object) { FileSet.new(id: '999', mime_type: mime_type) }
+    let(:mime_type) { 'image/jpeg' }
+    context "that has a thumbnail" do
+      before do
+        allow(File).to receive(:exist?).and_return(true)
+      end
+      it { is_expected.to eq '/downloads/999?file=thumbnail' }
+    end
+
+    context "that is an audio" do
+      let(:mime_type) { 'audio/x-wav' }
+      it { is_expected.to eq '/assets/audio.png' }
+    end
+
+    context "that has no thumbnail" do
+      it { is_expected.to eq '/assets/default.png' }
+    end
+  end
+
+  context "with a Work" do
+    context "that has a thumbnail" do
+      let(:object) { GenericWork.new(thumbnail_id: '999') }
+      let(:representative) { FileSet.new(id: '777') }
+      before do
+        allow(File).to receive(:exist?).and_return(true)
+        allow(FileSet).to receive(:load_instance_from_solr).with('999').and_return(representative)
+      end
+
+      it { is_expected.to eq '/downloads/999?file=thumbnail' }
+    end
+
+    context "that doesn't have a representative" do
+      let(:object) { FileSet.new }
+      it { is_expected.to eq '/assets/default.png' }
+    end
+  end
+end

data/spec/services/versioning_service_spec.rb

@@ -1,32 +1,31 @@
 require 'spec_helper'
 
 describe CurationConcerns::VersioningService do
-  describe "#latest_version_of" do
+  describe '#latest_version_of' do
     let(:file) do
-      generic_file = GenericFile.create do |f|
+      FileSet.create do |f|
         f.apply_depositor_metadata('mjg36')
       end
     end
 
     before do
       # Add the original_file (this service  creates a version after saving when you call it with versioning: true)
-      Hydra::Works::AddFileToGenericFile.call(file, File.open(fixture_file_path('world.png')), :original_file, versioning: true)
+      Hydra::Works::AddFileToFileSet.call(file, File.open(fixture_file_path('world.png')), :original_file, versioning: true)
     end
 
-    describe  "latest_version_of" do
+    describe 'latest_version_of' do
       subject { described_class.latest_version_of(file.original_file).label }
 
-      context "with one version" do
-        it { is_expected.to eq "version1" }
+      context 'with one version' do
+        it { is_expected.to eq 'version1' }
       end
 
-      context "with two versions" do
+      context 'with two versions' do
         before do
           file.original_file.create_version
         end
-        it { is_expected.to eq "version2" }
+        it { is_expected.to eq 'version2' }
       end
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -1,4 +1,9 @@
-ENV["RAILS_ENV"] ||= 'test'
+if ENV['CI']
+  require 'coveralls'
+  Coveralls.wear!
+end
+
+ENV['RAILS_ENV'] ||= 'test'
 
 require 'factory_girl'
 require 'database_cleaner'
@@ -11,35 +16,35 @@ require 'rspec/rails'
 require 'rspec/active_model/mocks'
 require 'capybara/poltergeist'
 Capybara.javascript_driver = :poltergeist
-Capybara.default_wait_time = ENV['TRAVIS'] ? 30 : 15
+Capybara.default_max_wait_time = ENV['TRAVIS'] ? 30 : 15
 require 'capybara/rspec'
 require 'capybara/rails'
 
 $in_travis = !ENV['TRAVIS'].nil? && ENV['TRAVIS'] == 'true'
 
-if ENV['COVERAGE'] || ENV['CI']
+if ENV['COVERAGE'] || $in_travis
   require 'simplecov'
-  require 'coveralls'
 
-  ENGINE_ROOT = File.expand_path('../..', __FILE__)
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter if ENV["CI"]
-  SimpleCov.start do
-    add_filter '/spec/'
+  SimpleCov.root(File.expand_path('../..', __FILE__))
+  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  SimpleCov.start('rails') do
+    add_filter '/spec'
   end
+  SimpleCov.command_name('spec')
 end
 
 require 'curation_concerns'
 
-Dir["./spec/support/**/*.rb"].sort.each {|f| require f}
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 require File.expand_path('../matchers', __FILE__)
 
-FactoryGirl.definition_file_paths = [File.expand_path("../factories", __FILE__)]
+FactoryGirl.definition_file_paths = [File.expand_path('../factories', __FILE__)]
 FactoryGirl.find_definitions
 
 require 'active_fedora/cleaner'
 RSpec.configure do |config|
   config.use_transactional_fixtures = false
-  config.fixture_path = File.expand_path("../fixtures", __FILE__)
+  config.fixture_path = File.expand_path('../fixtures', __FILE__)
 
   config.before :each do
     if Capybara.current_driver == :rack_test
@@ -55,7 +60,7 @@ RSpec.configure do |config|
   end
 
   config.before :each do |example|
-    unless (example.metadata[:type] == :view || example.metadata[:no_clean])
+    unless example.metadata[:type] == :view || example.metadata[:no_clean]
       ActiveFedora::Cleaner.clean!
     end
   end
@@ -68,6 +73,8 @@ RSpec.configure do |config|
   config.include Controllers::EngineHelpers, type: :controller
   config.include Rails.application.routes.url_helpers, type: :routing
   config.include Capybara::DSL
+  config.include InputSupport, type: :input
+  config.include Capybara::RSpecMatchers, type: :input
   config.infer_spec_type_from_file_location!
   config.deprecation_stream
 end
@@ -84,9 +91,10 @@ if defined?(ClamAV)
 else
   class ClamAV
     include Singleton
-    def scanfile(f)
+    def scanfile(_f)
       0
     end
+
     def loaddb
       nil
     end

data/spec/support/curation_concerns/factory_helpers.rb

@@ -1,6 +1,7 @@
 module CurationConcerns
   module FactoryHelpers
     module_function
+
     def load_factories_for(context, klass)
       context.instance_exec(klass) do |curation_concern_class|
         let(:curation_concern_type_underscore) { curation_concern_class.name.underscore }

data/spec/support/features/fixture_file_upload.rb

@@ -4,10 +4,12 @@ module Features
     def curation_concerns_fixture_file_upload(path, content_type = 'text/plain', binary = false)
       Rack::Test::UploadedFile.new(fixture_file_path(path), content_type, binary)
     end
+
     def fixture_file(path)
       File.open(fixture_file_path(path))
     end
-    def fixture_file_path(path)      
+
+    def fixture_file_path(path)
       File.join(CurationConcerns::Engine.root.to_s, 'spec/fixtures', path)
     end
   end

data/spec/support/features/session_helpers.rb

@@ -5,8 +5,9 @@ module Features
       user.reload # because the user isn't re-queried via Warden
       super(user, scope: :user, run_callbacks: false)
     end
+
     # Regular logout
-    def logout(user=:user)
+    def logout(user = :user)
       super(user)
     end
 
@@ -27,9 +28,7 @@ module Features
       user = if who.instance_of?(User)
                who
              else
-               FactoryGirl.build(:user).tap do |u|
-                 u.save!
-               end
+               FactoryGirl.build(:user).tap(&:save!)
              end
       visit new_user_session_path
       fill_in 'Email', with: user.email

data/spec/support/features.rb

@@ -5,15 +5,12 @@ RSpec.configure do |config|
   config.include Warden::Test::Helpers, type: :feature
   config.include Features::SessionHelpers, type: :feature
   config.include Features::FixtureFileUpload
-  
+
   config.before(:each, type: :feature) do
     Warden.test_mode!
-    @old_resque_inline_value = Resque.inline
-    Resque.inline = true
   end
 
   config.after(:each, type: :feature) do
     Warden.test_reset!
-    Resque.inline = @old_resque_inline_value
   end
 end

data/spec/support/input_support.rb

@@ -0,0 +1,11 @@
+module InputSupport
+  extend ActiveSupport::Concern
+
+  include RSpec::Rails::HelperExampleGroup
+
+  def input_for(object, attribute_name, options = {})
+    helper.simple_form_for object, url: '' do |f|
+      f.input attribute_name, options
+    end
+  end
+end

data/spec/support/matchers/api_responses.rb

@@ -0,0 +1,22 @@
+# RSpec matchers for API default JSON responses.
+# Creates a matcher like respond_forbidden or respond_not_found corresponding to each of the Api::V1.default_responses
+# Accepts optional overrides to the expected response body.
+# @example Override the description expected in the JSON body of a :forbidden response
+#   expect(response).to respond_forbidden(description:"You can't create for that identity")
+::CurationConcerns::API.default_responses.each_pair do |response_type, default_response_body|
+  RSpec::Matchers.define "respond_#{response_type}".to_sym do |expectation_options|
+    match do |response|
+      @expected_response_body = expectation_options.nil? ? default_response_body : default_response_body.merge(expectation_options)
+      expect(response.body).to_not be_empty
+      json = JSON.parse(response.body)
+      expect(response.code).to eq(@expected_response_body[:code].to_s)
+      @expected_response_body.each_pair do |key, value|
+        expect(json[key.to_s]).to eq(value.as_json)
+      end
+    end
+
+    failure_message do |actual|
+      "expected #{default_response_body[:code]} status code. Got #{actual.code} status code.\nexpected an Authentication Required response like this:\n #{@expected_response_body.to_json} \ngot\n #{actual.body}\nTo override expectations about the response body, provide a Hash of overrides in your call to :respond_#{response_type} "
+    end
+  end
+end

data/spec/support/shared/shared_examples_has_dc_metadata.rb

@@ -1,5 +1,4 @@
 shared_examples 'has_dc_metadata' do
-
   # Single-valued fields
   it { should have_unique_field(:created) }
   it { should have_unique_field(:date_uploaded) }
@@ -13,5 +12,4 @@ shared_examples 'has_dc_metadata' do
   it { should have_multivalue_field(:source) }
   it { should have_multivalue_field(:language) }
   it { should have_multivalue_field(:subject) }
-
 end

data/spec/support/shared/shared_examples_is_embargoable.rb

@@ -1,8 +1,6 @@
 shared_examples 'is_embargoable' do
-
-  it "has an embargo_release_date attribute" do
+  it 'has an embargo_release_date attribute' do
     expect(subject).to respond_to(:embargo_release_date)
     expect(subject).to respond_to(:embargo_release_date=)
   end
-
 end

data/spec/support/shared/shared_examples_with_access_rights.rb

@@ -1,27 +1,26 @@
 shared_examples 'with_access_rights' do
-
   def prepare_subject_for_access_rights_visibility_test!
     # I am doing this because the actual persistence of the objects requires
     # so much more and I don't know for certain if it has happened.
     allow(subject).to receive(:persisted?).and_return(true)
   end
 
-  it "has an under_embargo?" do
-    expect {
+  it 'has an under_embargo?' do
+    expect do
       subject.under_embargo?
-    }.to_not raise_error
+    end.to_not raise_error
   end
 
-  it "has a visibility attribute" do
+  it 'has a visibility attribute' do
     expect(subject).to respond_to(:visibility)
     expect(subject).to respond_to(:visibility=)
   end
 
   describe 'open access' do
-    it "has an open_access?" do
-      expect {
+    it 'has an open_access?' do
+      expect do
         subject.open_access?
-      }.to_not raise_error
+      end.to_not raise_error
     end
 
     it 'sets visibility' do
@@ -38,10 +37,10 @@ shared_examples 'with_access_rights' do
       expect(subject).to be_authenticated_only_access
     end
 
-    it "has an authenticated_only_access?" do
-      expect {
+    it 'has an authenticated_only_access?' do
+      expect do
         subject.authenticated_only_access?
-      }.to_not raise_error
+      end.to_not raise_error
     end
   end
 
@@ -52,12 +51,10 @@ shared_examples 'with_access_rights' do
       expect(subject).to be_private_access
     end
 
-
-    it "has an private_access?" do
-      expect {
+    it 'has an private_access?' do
+      expect do
         subject.private_access?
-      }.to_not raise_error
+      end.to_not raise_error
     end
   end
-
 end

data/spec/tasks/rake_spec.rb

@@ -1,24 +1,22 @@
 require 'spec_helper'
 require 'rake'
 
-describe "Rake tasks" do
-
-  describe "curation_concerns:migrate" do
-    let(:namespaced_id) { "curation_concerns:123" }
-    let(:corrected_id)  { "123" }
+describe 'Rake tasks' do
+  describe 'curation_concerns:migrate' do
+    let(:namespaced_id) { 'curation_concerns:123' }
+    let(:corrected_id)  { '123' }
     before do
-      load File.expand_path("../../../curation_concerns-models/lib/tasks/migrate.rake", __FILE__)
+      load File.expand_path('../../../curation_concerns-models/lib/tasks/migrate.rake', __FILE__)
       Rake::Task.define_task(:environment)
     end
 
-    describe "deleting the namespace from ChecksumAuditLog#generic_file_id" do
+    describe 'deleting the namespace from ChecksumAuditLog#file_set_id' do
       before do
-        ChecksumAuditLog.create(generic_file_id: namespaced_id)
-        Rake::Task["curation_concerns:migrate:audit_logs"].invoke
+        ChecksumAuditLog.create(file_set_id: namespaced_id)
+        Rake::Task['curation_concerns:migrate:audit_logs'].invoke
       end
-      subject { ChecksumAuditLog.first.generic_file_id }
+      subject { ChecksumAuditLog.first.file_set_id }
       it { is_expected.to eql corrected_id }
     end
   end
-
 end

data/spec/test_app_templates/Gemfile.extra

@@ -1 +1,4 @@
-# placeholder to use for pinning against specific gem commit references
+# placeholder to use for pinning against specific gem commit references
+# gem 'hydra-works', github: 'projecthydra-labs/hydra-works', branch: 'master'
+# gem 'hydra-pcdm', github: 'projecthydra-labs/hydra-pcdm', branch: 'master'
+# gem 'activefedora-aggregation', github: 'projecthydra-labs/activefedora-aggregation', branch: 'master'

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -1,14 +1,14 @@
 require 'rails/generators'
 
 class TestAppGenerator < Rails::Generators::Base
-  source_root "../../spec/test_app_templates"
+  source_root '../../spec/test_app_templates'
 
   def install_engine
-    generate 'curation_concerns:install'
+    generate 'curation_concerns:install', '-f'
   end
 
   def run_migrations
-    rake "db:migrate"
+    rake 'db:migrate'
   end
 
   def generate_generic_work
@@ -20,36 +20,4 @@ class TestAppGenerator < Rails::Generators::Base
     remove_file 'spec/controllers/curation_concerns/generic_works_controller_spec.rb'
     remove_file 'spec/actors/curation_concerns/generic_work_actor_spec.rb'
   end
-
-  def enable_av_transcoding
-    file_path = "app/models/generic_file.rb"
-      inject_into_file file_path, after: /include ::CurationConcerns::GenericFileBehavior/ do
-      %q(
-  directly_contains_one :ogg, through: :files, type: ::RDF::URI("http://pcdm.org/use#ServiceFile"), class_name: "Hydra::PCDM::File"
-  directly_contains_one :mp3, through: :files, type: ::RDF::URI("http://pcdm.org/use#File"), class_name: "Hydra::PCDM::File"    
-  directly_contains_one :mp4, through: :files, type: ::RDF::URI("http://pcdm.org/use#ServiceFile"), class_name: "Hydra::PCDM::File"
-  directly_contains_one :webm, through: :files, type: ::RDF::URI("http://pcdm.org/use#File"), class_name: "Hydra::PCDM::File"
-
-
-  # This was taken directly from Sufia's GenericFile::Derivative.
-  makes_derivatives do |obj|
-    case obj.original_file.mime_type
-    when *pdf_mime_types
-      obj.transform_file :original_file, thumbnail: { format: 'jpg', size: '338x493' }
-    when *office_document_mime_types
-      obj.transform_file :original_file, { thumbnail: { format: 'jpg', size: '200x150>' } }, processor: :document
-     when *audio_mime_types
-      obj.transform_file :original_file, { mp3: { format: 'mp3' }, ogg: { format: 'ogg' } }, processor: :audio
-    when *video_mime_types
-      obj.transform_file :original_file, { webm: { format: 'webm' }, mp4: { format: 'mp4' }, thumbnail: { format: 'jpg' } }, processor: :video
-    when *image_mime_types
-      obj.transform_file :original_file, thumbnail: { format: 'jpg', size: '200x150>' }
-    end
-  end
-    )
-    end
-
-
-  end
-
 end

data/spec/views/catalog/index.html.erb_spec.rb

@@ -10,7 +10,6 @@ describe 'catalog/index.html.erb' do
     allow(view).to receive(:search_action_path).and_return('/catalog')
     allow(view).to receive(:has_search_parameters?).and_return(true)
 
-
     allow(view).to receive(:current_users_collections).and_return([])
     allow(view).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
     stub_template 'catalog/_search_sidebar.html.erb' => ''
@@ -24,7 +23,7 @@ describe 'catalog/index.html.erb' do
     params[:view] = 'gallery'
 
     resp = []
-    assign(:response, resp )
+    assign(:response, resp)
     allow(resp).to receive(:total_pages).and_return(1)
     allow(resp).to receive(:current_page).and_return(1)
     allow(resp).to receive(:limit_value).and_return(10)
@@ -36,24 +35,22 @@ describe 'catalog/index.html.erb' do
     assign(:document_list, [doc])
   end
 
-  context "when user does not have permissions" do
-    before  { allow(view).to receive(:can?).and_return(false) }
+  context 'when user does not have permissions' do
+    before { allow(view).to receive(:can?).and_return(false) }
     it 'appears on page without error' do
       render
       page = Capybara::Node::Simple.new(rendered)
       expect(page).to have_link(collection.title)
-      expect(page).to have_content "List of files deposited"
+      expect(page).to have_content 'List of files deposited'
     end
   end
-  context "when user has all the permissions" do
-    before  { allow(view).to receive(:can?).and_return(true) }
+  context 'when user has all the permissions' do
+    before { allow(view).to receive(:can?).and_return(true) }
     it 'appears on page without error' do
       render
       page = Capybara::Node::Simple.new(rendered)
       expect(page).to have_link(collection.title)
-      expect(page).to have_content "List of files deposited"
+      expect(page).to have_content 'List of files deposited'
     end
   end
-
-
 end

data/spec/views/curation_concerns/base/_attributes.html.erb_spec.rb

@@ -1,20 +1,23 @@
 require 'spec_helper'
 
 describe 'curation_concerns/base/_attributes.html.erb' do
-
   let(:creator)     { 'Bilbo' }
   let(:contributor) { 'Frodo' }
   let(:subject)     { 'history' }
 
-  let(:curation_concern) { double(creator: [creator],
-                                  contributor: [contributor],
-                                  subject: [subject]) }
+  let(:solr_document) { SolrDocument.new(subject_tesim: subject,
+                                         contributor_tesim: contributor,
+                                         creator_tesim: creator) }
+  let(:ability) { nil }
+  let(:presenter) do
+    CurationConcerns::WorkShowPresenter.new(solr_document, ability)
+  end
 
   before do
     allow(view).to receive(:dom_class) { '' }
-    allow(view).to receive(:permission_badge_for) { '' }
 
-    render partial: 'attributes', locals: { curation_concern: curation_concern }
+    assign(:presenter, presenter)
+    render
   end
 
   it 'has links to search for other objects with the same metadata' do

data/spec/views/curation_concerns/base/_form_permission.html.erb_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe 'curation_concerns/base/_form_permission.html.erb' do
+  let(:curation_concern) { GenericWork.new }
+  before do
+    f = double('form', object: curation_concern, object_name: nil, input: nil)
+    render partial: "curation_concerns/base/form_permission", locals: { f: f }
+  end
+
+  it 'has a permissions note' do
+    expect(rendered).to have_content('Please note, making something visible to the world')
+  end
+end

data/spec/views/curation_concerns/base/show.html.erb_spec.rb

@@ -1,29 +1,49 @@
 require 'spec_helper'
 
 describe 'curation_concerns/base/show.html.erb' do
+  let(:object_profile) { ["{\"id\":\"999\"}"] }
+  let(:contributor) { 'Frodo' }
+  let(:creator)     { 'Bilbo' }
+  let(:solr_document) {
+    SolrDocument.new(
+      id: '999',
+      object_profile_ssm: object_profile,
+      has_model_ssim: ['GenericWork'],
+      human_readable_type_tesim: ['Generic Work'],
+      contributor_tesim: contributor,
+      creator_tesim: creator,
+      rights_tesim: ['http://creativecommons.org/licenses/by/3.0/us/']
+    )
+  }
 
-  let!(:curation_concern) { FactoryGirl.create(:private_generic_work) }
+  let(:ability) { nil }
+  let(:presenter) do
+    CurationConcerns::WorkShowPresenter.new(solr_document, ability)
+  end
 
-  context "for editors" do
+  context 'for editors' do
     before do
-      allow(view).to receive(:can?).and_return(true)
+      allow(view).to receive(:can?).with(:edit, String).and_return(true)
+      allow(view).to receive(:can?).with(:collect, String).and_return(true)
+      assign(:presenter, presenter)
+      render
     end
 
-    it 'has links to edit' do # and add to collections' do
-      render file: 'curation_concerns/base/show', locals: { curation_concern: curation_concern }
-      expect(rendered).to have_link("Edit This Generic Work", href: edit_polymorphic_path([:curation_concerns, curation_concern]))
-      # expect(rendered).to have_selector "a[data-toggle='modal'][data-target='##{curation_concern.to_param}-modal']", text: "Add to a Collection"
-      # expect(rendered).to have_selector("div.modal##{curation_concern.to_param}-modal form[action='#{collections.collections_path}'] input[value='Add to collection']")
+    it 'draws the page' do
+      expect(rendered).to have_link 'Attribution 3.0 United States', href: 'http://creativecommons.org/licenses/by/3.0/us/'
+      expect(rendered).to have_link 'Edit This Generic Work', href: edit_polymorphic_path([:curation_concerns, presenter])
     end
   end
 
-  context "for non-editors" do
-    it 'does not have links to edit' do #, but has add to collection' do
-      render file: 'curation_concerns/base/show', locals: { curation_concern: curation_concern }
-      expect(rendered).not_to have_content("Edit this Generic Work")
-
-      # expect(rendered).to have_selector "a[data-toggle='modal'][data-target='##{curation_concern.to_param}-modal']", text: "Add to a Collection"
-      # expect(rendered).to have_selector("div.modal##{curation_concern.to_param}-modal form[action='#{collections.collections_path}'] input[value='Add to collection']")
+  context 'for non-editors' do
+    before do
+      assign(:presenter, presenter)
+      allow(view).to receive(:can?).with(:edit, String).and_return(false)
+      allow(view).to receive(:can?).with(:collect, String).and_return(false)
+      render
+    end
+    it 'does not have links to edit' do
+      expect(rendered).not_to have_content('Edit this Generic Work')
     end
   end
 end

data/spec/views/curation_concerns/base/show.json.jbuilder_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe 'curation_concerns/base/show.json.jbuilder' do
+  let(:curation_concern) { FactoryGirl.create(:generic_work) }
+
+  before do
+    assign(:curation_concern, curation_concern)
+    render
+  end
+
+  it "renders json of the curation_concern" do
+    json = JSON.parse(rendered)
+    expect(json['id']).to eq curation_concern.id
+    expect(json['title']).to eq curation_concern.title
+    expected_fields = curation_concern.class.fields.select { |f| ![:has_model, :create_date].include? f }
+    expected_fields << :date_created
+    expected_fields.each do |field_symbol|
+      expect(json).to have_key(field_symbol.to_s)
+    end
+  end
+end