curation_concerns 0.1.0 → 0.2.0

data/spec/models/checksum_audit_log_spec.rb

@@ -3,64 +3,69 @@ require 'spec_helper'
 describe ChecksumAuditLog do
   before do
     # stub out characterization so it does not get audited
-    allow_any_instance_of(CurationConcerns::CharacterizationService).to receive(:characterize)
+    allow_any_instance_of(Hydra::Works::CharacterizationService).to receive(:characterize)
   end
 
   let(:f) do
-    GenericFile.create do |gf|
-      gf.add_file(File.open(fixture_path + '/world.png'), path: 'content', original_name: 'world.png')
+    file = FileSet.create do |gf|
       gf.apply_depositor_metadata('mjg36')
     end
+    # TODO: Mock addition of file to fileset to avoid calls to .save.
+    # This will speed up tests and avoid uneccesary integration testing for fedora funcationality.
+    Hydra::Works::AddFileToFileSet.call(file, File.open(fixture_path + '/world.png'), :original_file)
+    file
   end
 
-  let(:version_uri) { CurationConcerns::VersioningService.create(f.content); f.content.versions.first.uri }
-  let(:content_id) { f.content.id }
-  let(:old) { ChecksumAuditLog.create(generic_file_id: f.id, file_id: content_id, version: version_uri, pass: 1, created_at: 2.minutes.ago) }
-  let(:new) { ChecksumAuditLog.create(generic_file_id: f.id, file_id: content_id, version: version_uri, pass: 0, created_at: 1.minute.ago) }
+  let(:version_uri) do
+    CurationConcerns::VersioningService.create(f.original_file)
+    f.original_file.versions.first.uri
+  end
+  let(:content_id) { f.original_file.id }
+  let(:old) { described_class.create(file_set_id: f.id, file_id: content_id, version: version_uri, pass: 1, created_at: 2.minutes.ago) }
+  let(:new) { described_class.create(file_set_id: f.id, file_id: content_id, version: version_uri, pass: 0, created_at: 1.minute.ago) }
 
-  context "a file with multiple checksums audits" do
-    specify "should return a list of logs for this datastream sorted by date descending" do
-      logs = ChecksumAuditLog.logs_for(f.id, content_id)
+  context 'a file with multiple checksums audits' do
+    specify 'should return a list of logs for this datastream sorted by date descending' do
+      logs = described_class.logs_for(f.id, content_id)
       expect(logs).to eq([new, old])
     end
   end
 
-  context "after multiple checksum audits where the checksum does not change" do
-    specify "only one of them should be kept" do
-      success1 = ChecksumAuditLog.create(generic_file_id: f.id, file_id: content_id, version: version_uri, pass: 1)
-      ChecksumAuditLog.prune_history(f.id, content_id)
-      success2 = ChecksumAuditLog.create(generic_file_id: f.id, file_id: content_id, version: version_uri, pass: 1)
-      ChecksumAuditLog.prune_history(f.id, content_id)
-      success3 = ChecksumAuditLog.create(generic_file_id: f.id, file_id: content_id, version: version_uri, pass: 1)
-      ChecksumAuditLog.prune_history(f.id, content_id)
+  context 'after multiple checksum audits where the checksum does not change' do
+    specify 'only one of them should be kept' do
+      success1 = described_class.create(file_set_id: f.id, file_id: content_id, version: version_uri, pass: 1)
+      described_class.prune_history(f.id, content_id)
+      success2 = described_class.create(file_set_id: f.id, file_id: content_id, version: version_uri, pass: 1)
+      described_class.prune_history(f.id, content_id)
+      success3 = described_class.create(file_set_id: f.id, file_id: content_id, version: version_uri, pass: 1)
+      described_class.prune_history(f.id, content_id)
 
-      expect { ChecksumAuditLog.find(success2.id) }.to raise_exception ActiveRecord::RecordNotFound
-      expect { ChecksumAuditLog.find(success3.id) }.to raise_exception ActiveRecord::RecordNotFound
-      expect(ChecksumAuditLog.find(success1.id)).not_to be_nil
-      logs = ChecksumAuditLog.logs_for(f.id, content_id)
+      expect { described_class.find(success2.id) }.to raise_exception ActiveRecord::RecordNotFound
+      expect { described_class.find(success3.id) }.to raise_exception ActiveRecord::RecordNotFound
+      expect(described_class.find(success1.id)).not_to be_nil
+      logs = described_class.logs_for(f.id, content_id)
       expect(logs).to eq([success1, new, old])
     end
   end
 
-  context "should have an audit log history" do
+  context 'should have an audit log history' do
     before do
-      ChecksumAuditLog.create(generic_file_id: f.id, file_id: f.content.id, version: 'v2', pass: 1)
-      ChecksumAuditLog.create(generic_file_id: f.id, file_id: 'thumbnail', version: 'v1', pass: 1)
+      described_class.create(file_set_id: f.id, file_id: content_id, version: 'v2', pass: 1)
+      described_class.create(file_set_id: f.id, file_id: 'thumbnail', version: 'v1', pass: 1)
     end
 
     it "has an audit log history" do
-      audit = ChecksumAuditLog.get_audit_log(f.id, f.content.id, version_uri)
-      expect(audit.generic_file_id).to eq(f.id)
+      audit = described_class.get_audit_log(f.id, content_id, version_uri)
+      expect(audit.file_set_id).to eq(f.id)
       expect(audit.version).to eq(version_uri)
 
-      audit = ChecksumAuditLog.get_audit_log(f.id, f.content.id, 'v2')
-      expect(audit.generic_file_id).to eq(f.id)
+      audit = described_class.get_audit_log(f.id, content_id, 'v2')
+      expect(audit.file_set_id).to eq(f.id)
       expect(audit.version).to eq('v2')
 
-      audit = ChecksumAuditLog.get_audit_log(f.id, 'thumbnail', 'v1')
-      expect(audit.generic_file_id).to eq(f.id)
+      audit = described_class.get_audit_log(f.id, 'thumbnail', 'v1')
+      expect(audit.file_set_id).to eq(f.id)
       expect(audit.version).to eq('v1')
-
     end
   end
 end

data/spec/models/curation_concerns/collection_behavior_spec.rb

@@ -7,22 +7,27 @@ describe CurationConcerns::CollectionBehavior do
   let(:collection) { FactoryGirl.build(:collection) }
   subject { collection }
 
-  it "should not allow a collection to be saved without a title" do
-     subject.title = nil
-     expect{ subject.save! }.to raise_error(ActiveFedora::RecordInvalid)
+  it 'does not allow a collection to be saved without a title' do
+    subject.title = nil
+    expect { subject.save! }.to raise_error(ActiveFedora::RecordInvalid)
   end
 
-  describe "::bytes" do
+  describe "indexer" do
+    subject { Collection.indexer }
+    it { is_expected.to eq CurationConcerns::CollectionIndexer }
+  end
+
+  describe '::bytes' do
     subject { collection.bytes }
 
-    context "with no items" do
+    context 'with no items' do
       before { collection.save }
       it { is_expected.to eq 0 }
     end
 
-    context "with two 50 byte files" do
-      let(:bitstream) { double("content", size: "50")}
-      let(:file) { mock_model ::GenericFile, content: bitstream }
+    context 'with two 50 byte files' do
+      let(:bitstream) { double('content', size: '50') }
+      let(:file) { mock_model ::FileSet, content: bitstream }
       before { allow(collection).to receive(:members).and_return([file, file]) }
       it { is_expected.to eq 100 }
     end
@@ -31,25 +36,29 @@ describe CurationConcerns::CollectionBehavior do
   context '.add_member' do
     let(:collectible?) { nil }
     let(:proposed_collectible) { double(collections: []) }
-    before(:each) {
+    before(:each) do
       allow(proposed_collectible).to receive(:can_be_member_of_collection?).with(subject).and_return(collectible?)
+      # Added for solrizing interface.
+      allow(proposed_collectible).to receive(:pcdm_object?).and_return(true)
+      allow(proposed_collectible).to receive(:collection?).and_return(false)
+      allow(proposed_collectible).to receive(:id).and_return("1")
       allow(proposed_collectible).to receive(:save).and_return(true)
-    }
+    end
 
     context 'with itself' do
       it 'does not add it to the collection\'s members' do
-        expect {
+        expect do
           subject.add_member(subject)
-        }.to_not change{ subject.members.size }
+        end.to_not change { subject.members.size }
       end
     end
 
     context 'with a non-collectible object' do
       let(:collectible?) { false }
       it 'does not add it to the collection\'s members' do
-        expect {
+        expect do
           subject.add_member(proposed_collectible)
-        }.to_not change{ subject.members.size }
+        end.to_not change { subject.members.size }
       end
     end
 
@@ -59,9 +68,9 @@ describe CurationConcerns::CollectionBehavior do
         allow(collection).to receive(:members).and_return([])
       end
       it 'adds it to the collection\'s members' do
-        expect {
+        expect do
           subject.add_member(proposed_collectible)
-        }.to change{ subject.members.size }.by(1)
+        end.to change { subject.members.size }.by(1)
       end
     end
   end
@@ -70,38 +79,42 @@ describe CurationConcerns::CollectionBehavior do
     let(:collection1) { FactoryGirl.build(:collection) }
     let(:work1) { FactoryGirl.build(:work) }
 
-    it 'should be a pcdm:Collection' do
+    it 'is a pcdm:Collection' do
       expect(subject.pcdm_collection?).to be true
-      expect(subject.type).to include RDFVocabularies::PCDMTerms.Collection
+      expect(subject.type).to include Hydra::PCDM::Vocab::PCDMTerms.Collection
     end
-    it 'should not be a pcdm:Object' do
+    it 'does not be a pcdm:Object' do
       expect(subject.pcdm_object?).to be false
-      expect(subject.type).to_not include RDFVocabularies::PCDMTerms.Object
+      expect(subject.type).to_not include Hydra::PCDM::Vocab::PCDMTerms.Object
     end
-    it 'should have child objects' do
-      expect(subject.child_generic_works).to eq []
-      expect(subject.child_generic_work_ids).to eq []
-      expect(subject.child_generic_works << work1).to eq [work1]
-      expect(subject.child_generic_works).to eq [work1]
-      expect(subject.child_generic_work_ids).to eq [work1.id]
+
+    it 'contains objects' do
+      expect(subject.works).to eq []
+      expect(subject.work_ids).to eq []
+      expect(subject.members << work1).to eq [work1]
+      expect(subject.works).to eq [work1]
+      expect(subject.work_ids).to eq [work1.id]
     end
-    it 'should have child collections' do
-      expect(subject.child_collections).to eq []
-      expect(subject.child_collection_ids).to eq []
-      expect(subject.child_collections << collection1).to eq [collection1]
-      expect(subject.child_collections).to eq [collection1]
-      expect(subject.child_collection_ids).to eq [collection1.id]
+
+    it 'contains collections' do
+      expect(subject.collections).to eq []
+      expect(subject.collection_ids).to eq []
+      expect(subject.members << collection1).to eq [collection1]
+      expect(subject.collections).to eq [collection1]
+      expect(subject.collection_ids).to eq [collection1.id]
     end
-    it 'should have related objects' do
+    it 'has related objects' do
       expect(subject.related_objects).to eq []
       expect(subject.related_objects << work1).to eq [work1]
       expect(subject.related_objects).to eq [work1]
     end
-    it 'should have parent collections' do
-      expect(subject.parent_collections).to eq []
-      expect(collection1.child_collections << subject).to eq [subject]
+    it 'has parent collections' do
+      expect(subject.in_collections).to eq []
+      expect(collection1.members << subject).to eq [subject]
+      # Function of auto-save/indexing issues.
+      subject.save
       collection1.save
-      expect(subject.parent_collections).to eq [collection1]
+      expect(subject.in_collections).to eq [collection1]
     end
   end
 end

data/spec/models/curation_concerns/file_set/derivatives_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe CurationConcerns::FileSet do
+  let(:file_set) { FileSet.create { |gf| gf.apply_depositor_metadata('jcoyne@example.com') } }
+
+  before do
+    allow(file_set).to receive(:mime_type).and_return(mime_type)
+  end
+
+  after do
+    dir = File.join(CurationConcerns.config.derivatives_path, file_set.id)
+    FileUtils.rm_r(dir) if File.directory?(dir)
+  end
+
+  describe 'image derivative' do
+    let(:mime_type) { 'image/jp2' }
+    let(:file_name) { File.join(fixture_path, 'image.jp2') }
+    it 'only makes one thumbnail' do
+      expect_any_instance_of(Hydra::Derivatives::Processors::Image).to receive(:process).once
+      file_set.create_derivatives(file_name)
+    end
+  end
+
+  describe 'pdf derivative' do
+    let(:mime_type) { 'application/pdf' }
+    let(:file_name) { File.join(fixture_path, 'test.pdf') }
+    it 'makes one thumbnail and extracts full text' do
+      expect_any_instance_of(Hydra::Derivatives::Processors::Image).to receive(:process).once
+      expect_any_instance_of(Hydra::Derivatives::Processors::FullText).to receive(:process).once
+      file_set.create_derivatives(file_name)
+    end
+  end
+
+  describe 'office derivative' do
+    let(:mime_type) { 'application/vnd.openxmlformats-officedocument.wordprocessingml.document' }
+    let(:file_name) { File.join(fixture_path, 'charter.docx') }
+    it 'makes one thumbnail and extracts full text' do
+      expect_any_instance_of(Hydra::Derivatives::Processors::Document).to receive(:process).once
+      expect_any_instance_of(Hydra::Derivatives::Processors::FullText).to receive(:process).once
+      file_set.create_derivatives(file_name)
+    end
+  end
+
+  describe 'audiovisual transcoding', unless: $in_travis do
+    before do
+      # stub the name service so it's easer to find where the file will be
+      allow(CurationConcerns::DerivativePath).to receive(:derivative_path_for_reference) do |object, key|
+        "#{Rails.root}/tmp/derivatives/#{object.id}/#{key}.#{key}"
+      end
+    end
+
+    context 'with a video (.avi) file' do
+      let(:mime_type) { 'video/avi' }
+      let(:file_name) { File.join(fixture_path, 'countdown.avi') }
+
+      it 'transcodes to webm and mp4' do
+        new_webm = "#{Rails.root}/tmp/derivatives/#{file_set.id}/webm.webm"
+        new_mp4 = "#{Rails.root}/tmp/derivatives/#{file_set.id}/mp4.mp4"
+        expect {
+          file_set.create_derivatives(file_name)
+        }.to change { File.exist?(new_webm) }
+          .from(false).to(true)
+          .and change { File.exist?(new_mp4) }
+          .from(false).to(true)
+      end
+    end
+
+    context 'with an audio (.wav) file' do
+      let(:mime_type) { 'audio/wav' }
+      let(:file_name) { File.join(fixture_path, 'piano_note.wav') }
+
+      it 'transcodes to mp3 and ogg' do
+        new_mp3 = "#{Rails.root}/tmp/derivatives/#{file_set.id}/mp3.mp3"
+        new_ogg = "#{Rails.root}/tmp/derivatives/#{file_set.id}/ogg.ogg"
+        expect {
+          file_set.create_derivatives(file_name)
+        }.to change { File.exist?(new_mp3) }
+          .from(false).to(true)
+          .and change { File.exist?(new_ogg) }
+          .from(false).to(true)
+      end
+    end
+  end
+end

data/spec/models/curation_concerns/work_behavior_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe CurationConcerns::WorkBehavior do
+  before do
+    class EssentialWork < ActiveFedora::Base
+      include CurationConcerns::WorkBehavior
+      include CurationConcerns::BasicMetadata
+    end
+  end
+  after do
+    Object.send(:remove_const, :EssentialWork)
+  end
+
+  subject { EssentialWork.new }
+
+  it 'mixs together all the goodness' do
+    [::CurationConcerns::WithFileSets, ::CurationConcerns::HumanReadableType, CurationConcerns::Noid, CurationConcerns::Serializers, Hydra::WithDepositor, Hydra::AccessControls::Embargoable, Solrizer::Common].each do |mixin|
+      expect(subject.class.ancestors).to include(mixin)
+    end
+  end
+  describe '#to_s' do
+    it 'uses the provided titles' do
+      subject.title = %w(Hello World)
+      expect(subject.to_s).to eq('Hello | World')
+    end
+
+    it 'falls back on label if no titles are given' do
+      subject.title = []
+      subject.label = 'Spam'
+      expect(subject.to_s).to eq('Spam')
+    end
+
+    it 'with no label or titles it is "No Title"' do
+      subject.title = []
+      subject.label = nil
+      expect(subject.to_s).to eq('No Title')
+    end
+  end
+  describe 'human_readable_type' do
+    it 'has a default' do
+      expect(subject.human_readable_type).to eq 'Essential Work'
+    end
+    it 'is settable' do
+      EssentialWork.human_readable_type = 'Custom Type'
+      expect(subject.human_readable_type).to eq 'Custom Type'
+    end
+  end
+
+  it 'inherits (and extends) to_solr behaviors from superclass' do
+    expect(subject.to_solr.keys).to include(:id)
+    expect(subject.to_solr.keys).to include('has_model_ssim')
+  end
+end