cucumber 2.0.0.beta.2 → 2.0.0.beta.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec39cd25b8f17917a20fd5af809119a9ecad0671
-  data.tar.gz: 43aced438654c8263f00185586f45c42daeedab0
+  metadata.gz: 1b115e5b0a7ae23e6b0372462a320314ee144811
+  data.tar.gz: 3143905ef42ea795c85cc6163dedf95bd670f582
 SHA512:
-  metadata.gz: 8b7126a89b0f2e88fc81dfbd3aebf4998928f8f49033ba67a453a74525234b1d73f811aba9346bafe2c0274fbc6cc8b4deb45c5a0a4411e54cbf47c3e5ece726
-  data.tar.gz: 4c81bc4dd772677dc1888a4da72eaf8401093440274faac071beb52f9dc320e481e6b34735486aec2e3c3b914d9096e3b273591265e379082447efa0f288a9d1
+  metadata.gz: 1144b0d0bdf707e16db0b4d389aa7242f870df050db0da4ffe6c749e26309dfbd0bec80eb3db5995c27456e8cddd610bcb242d4a407a3a5887a0933c510e2744
+  data.tar.gz: dcfa6d1ca0b6af5abb794495a6872509976519c40af52075f78056593dfde8d397e10ae7d67ae3f2aa710ac2a6401aaca6c481747033d38d8d35c911f20acb08

data/History.md

@@ -1,12 +1,29 @@
-## [In Git](https://github.com/cucumber/cucumber/compare/v.2.0.0.beta.1...master)
+## [In Git](https://github.com/cucumber/cucumber/compare/v.2.0.0.beta.2...master)
 
-### Bugfixes
+### Removed Features
 
-  * Better reporting of exceptions in Before / After hooks ([723](https://github.com/cucumber/cucumber/pull/723) @mattwynne)
+  * The `--dotcucumber` option is no longer supported and `stepdefs.json` is no longer written. (Aslak Hellesøy)
 
-### New features
+### New Features
+
+  * Include both outline step and expanded step in error backtrace ([730](https://github.com/cucumber/cucumber/pull/730) @brasmusson)
+  * Add TestCase#outline? for conditionals in Before / After hooks ([728](https://github.com/cucumber/cucumber/pull/728) [Erran Carey](https://github.com/erran))
+  * Support embedding images directly in HTML and JSON reports ([696](https://github.com/cucumber/cucumber/pull/696),[695](https://github.com/cucumber/cucumber/pull/695/files) @brasmusson)
 
-* Support embedding images directly in HTML and JSON reports ([696](https://github.com/cucumber/cucumber/pull/696),[695](https://github.com/cucumber/cucumber/pull/695/files) @brasmusson)
+### Bugfixes
+
+  * Pass hook output to the formatters appropriately ([732](https://github.com/cucumber/cucumber/pull/732) @brasmusson)
+  * Added tests for, and re-added behaviour to support Scenario#failed? in hooks (Matt Wynne)
+  * Rescuing ArgumentError in HTML formatter so Cucumber won't stop tests due bad encoding ([690](https://github.com/cucumber/cucumber/pull/690) @awls99)
+  * Add back support for the DataTable API ([729](https://github.com/cucumber/cucumber/pull/729) @mattwynne and @tooky)
+  * Fix Windows support loading files properly ([739](https://github.com/cucumber/cucumber/issues/739) @os97673)
+
+## [v2.0.0.beta.2](https://github.com/cucumber/cucumber/compare/v.2.0.0.beta.1...v.2.0.0.beta.2)
+
+### Bugfixes
+
+  * Better reporting of exceptions in Before / After hooks ([723](https://github.com/cucumber/cucumber/pull/723) @mattwynne)
+  * Add `#source_tag_names` method to `TestCase` object passed to hooks (@mattwynne)
 
 ## [v2.0.0.beta.1 ](https://github.com/cucumber/cucumber/compare/v1.3.8...v.2.0.0.beta.1)
 
@@ -22,8 +39,8 @@ all.
 
 * Better snippet comment ([579](https://github.com/cucumber/cucumber/pull/579) Jeff Nyman)
 * Random scenario ordering with `--order random`
-* Embed plain text ([712](https://github.com/cucumber/cucumber/pull/712) @bingwei
-* Support the cucumber-reporting tools also when using Scenario Outlines ([700](https://github.com/cucumber/cucumber/pull/700) @brasmusson
+* Embed plain text ([712](https://github.com/cucumber/cucumber/pull/712) @bingwei)
+* Support the cucumber-reporting tools also when using Scenario Outlines ([700](https://github.com/cucumber/cucumber/pull/700) @brasmusson)
 
 ### Features removed
 
@@ -45,6 +62,7 @@ all.
 
 ## [v1.3.16](https://github.com/cucumber/cucumber/compare/v1.3.15...v1.3.16)
 
+* Pass output from the step definition on to the JSON formatter ([701](https://github.com/cucumber/cucumber/pull/701) @brasmusson)
 * Add RSpec 3 test double support ([689](https://github.com/cucumber/cucumber/pull/689) @cyphactor)
 * Fix bug with rerun formatter and `--expand` option ([710](https://github.com/cucumber/cucumber/pull/710) @brasmusson)
 

data/cucumber.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = ">= 1.9.3"
 
-  s.add_dependency 'cucumber-core', '~> 1.0.0.beta.2'
+  s.add_dependency 'cucumber-core', '~> 1.0.0.beta.3'
   s.add_dependency 'builder', '>= 2.1.2'
   s.add_dependency 'diff-lcs', '>= 1.1.3'
   s.add_dependency 'gherkin', '~> 2.12'

data/features/docs/defining_steps/nested_steps.feature

@@ -1,6 +1,5 @@
 Feature: Nested Steps
 
-
   Background:
     Given a scenario with a step that looks like this:
       """gherkin

data/features/docs/defining_steps/printing_messages.feature

@@ -121,6 +121,7 @@ Feature: Pretty formatter - Printing messages
             | 1    | anno1 | fail   |  Line: 1: anno1
              (RuntimeError)
             ./features/step_definitions/puts_steps.rb:13:in `/^I use message (.+) in line (.+) (?:with result (.+))$/'
+            features/f.feature:29:in `Given I use message anno1 in line 1 with result fail'
             features/f.feature:25:in `Given I use message <ann> in line <line> with result <result>'
             | 2    | anno2 | pass   |  Line: 2: anno2
       """

data/features/docs/defining_steps/table_diffing.feature

@@ -22,8 +22,8 @@ Feature: Table diffing
         }))
       end
       """
-    When I run `cucumber -i features/tables.feature`
-    Then it should fail with:
+    When I run `cucumber features/tables.feature`
+    Then it should fail with exactly:
       """
       Feature: Tables
 
@@ -31,8 +31,12 @@ Feature: Table diffing
           Then the table should be: # features/step_definitions/steps.rb:1
             | x | y |
             | a | b |
-            | a | c |
-            Tables were not identical (Cucumber::MultilineArgument::DataTable::Different)
+            Tables were not identical:
+            
+              |     x |     y |
+              | (-) a | (-) b |
+              | (+) a | (+) c |
+             (Cucumber::MultilineArgument::DataTable::Different)
             ./features/step_definitions/steps.rb:2:in `/the table should be:/'
             features/tables.feature:3:in `Then the table should be:'
 
@@ -41,5 +45,6 @@ Feature: Table diffing
 
       1 scenario (1 failed)
       1 step (1 failed)
+      0m0.012s
 
       """

data/features/docs/exception_in_after_step_hook.feature

@@ -86,6 +86,7 @@ Feature: Exception in AfterStep Block
             | does something naughty |
             This step has been very very naughty (NaughtyStepException)
             ./features/support/env.rb:4:in `AfterStep'
+            features/naughty_step_in_scenario_outline.feature:9:in `Given this step does something naughty'
             features/naughty_step_in_scenario_outline.feature:4:in `Given this step <Might Work>'
             | passes                 |
 

data/features/docs/formatters/json_formatter.feature

@@ -83,6 +83,17 @@ Feature: JSON output formatter
           Given I embed data directly
 
       """
+    And a file named "features/out_scenario_out_scenario_outline.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+        Scenario Outline:
+          Given this step <status>
+          Examples:
+          | status |
+          | passes |
+      """
 
   # Need to investigate why this won't pass in-process. error_message doesn't get det?
   @spawn
@@ -538,7 +549,7 @@ Feature: JSON output formatter
               {
                 "keyword": "Given ",
                 "name": "this step passes",
-                "line": 4,
+                "line": 8,
                 "match": {
                   "location": "features/step_definitions/steps.rb:1"
                 },
@@ -560,13 +571,13 @@ Feature: JSON output formatter
               {
                 "keyword": "Given ",
                 "name": "this step fails",
-                "line": 4,
+                "line": 9,
                 "match": {
                   "location": "features/step_definitions/steps.rb:4"
                 },
                 "result": {
                   "status": "failed",
-                  "error_message" : " (RuntimeError)\n./features/step_definitions/steps.rb:4:in `/^this step fails$/'\nfeatures/outline.feature:4:in `Given this step <status>'",
+                  "error_message" : " (RuntimeError)\n./features/step_definitions/steps.rb:4:in `/^this step fails$/'\nfeatures/outline.feature:9:in `Given this step fails'\nfeatures/outline.feature:4:in `Given this step <status>'",
 		  "duration": 1
                 }
               }
@@ -583,7 +594,7 @@ Feature: JSON output formatter
               {
                 "keyword": "Given ",
                 "name": "this step passes",
-                "line": 4,
+                "line": 13,
                 "match": {
                   "location": "features/step_definitions/steps.rb:1"
                 },
@@ -647,3 +658,39 @@ Feature: JSON output formatter
     ]
 
     """
+  @spawn
+  Scenario: handle output from hooks
+     Given a file named "features/step_definitions/output_steps.rb" with:
+      """
+      Before do
+        puts "Before hook 1"
+        embed "src", "mime_type", "label"
+      end
+
+      Before do
+        puts "Before hook 2"
+        embed "src", "mime_type", "label"
+      end
+ 
+      AfterStep do
+        puts "AfterStep hook 1"
+        embed "src", "mime_type", "label"
+      end
+
+      AfterStep do
+        puts "AfterStep hook 2"
+        embed "src", "mime_type", "label"
+      end
+
+      After do
+        puts "After hook 1"
+        embed "src", "mime_type", "label"
+      end
+
+      After do
+        puts "After hook 2"
+        embed "src", "mime_type", "label"
+      end
+      """
+    When I run `cucumber --format json features/out_scenario_out_scenario_outline.feature`
+    Then it should pass

data/features/docs/formatters/junit_formatter.feature

@@ -259,6 +259,7 @@ You *must* specify --out DIR for the junit formatter
       ]]>
           <![CDATA[ (RuntimeError)
       ./features/step_definitions/steps.rb:4:in `/^this step fails$/'
+      features/scenario_outline.feature:9:in `Given this step fails'
       features/scenario_outline.feature:4:in `Given this step <type>']]>
         </failure>
         <system-out/>

data/features/docs/gherkin/outlines.feature

@@ -62,6 +62,7 @@ Feature: Scenario outlines
             | failing | passing     |
             RuntimeError (RuntimeError)
             ./features/step_definitions/steps.rb:2:in `/^failing without a table$/'
+            features/outline_sample.feature:12:in `Given failing without a table'
             features/outline_sample.feature:6:in `Given <state> without a table'
 
           Examples: Only passing
@@ -92,6 +93,7 @@ Feature: Scenario outlines
             | failing | passing     |
             RuntimeError (RuntimeError)
             ./features/step_definitions/steps.rb:2:in `/^failing without a table$/'
+            features/outline_sample.feature:12:in `Given failing without a table'
             features/outline_sample.feature:6:in `Given <state> without a table'
 
           Examples: Only passing
@@ -121,6 +123,7 @@ Feature: Scenario outlines
             | failing | passing     |
             RuntimeError (RuntimeError)
             ./features/step_definitions/steps.rb:2:in `/^failing without a table$/'
+            features/outline_sample.feature:12:in `Given failing without a table'
             features/outline_sample.feature:6:in `Given <state> without a table'
 
       Failing Scenarios:
@@ -141,6 +144,7 @@ Feature: Scenario outlines
 
       RuntimeError (RuntimeError)
       ./features/step_definitions/steps.rb:2:in `/^failing without a table$/'
+      features/outline_sample.feature:12:in `Given failing without a table'
       features/outline_sample.feature:6:in `Given <state> without a table'
 
       Failing Scenarios:

data/features/docs/output_from_hooks.feature

@@ -0,0 +1,128 @@
+Feature: Hook output feature
+
+  Calls to puts and embed in hook, should be passed to the formatters.
+
+  Background:
+    Given the standard step definitions
+
+  Scenario: Output from hooks
+    Given a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+        Scenario Outline:
+          Given this step <status>
+          Examples:
+          | status |
+          | passes  |
+      """
+    And a file named "features/step_definitions/output_steps.rb" with:
+      """
+      Before do
+        puts "Before hook 1"
+        embed "src", "mime_type", "label"
+      end
+
+      Before do
+        puts "Before hook 2"
+        embed "src", "mime_type", "label"
+      end
+ 
+      AfterStep do
+        puts "AfterStep hook 1"
+        embed "src", "mime_type", "label"
+      end
+
+      AfterStep do
+        puts "AfterStep hook 2"
+        embed "src", "mime_type", "label"
+      end
+
+      After do
+        puts "After hook 1"
+        embed "src", "mime_type", "label"
+      end
+
+      After do
+        puts "After hook 2"
+        embed "src", "mime_type", "label"
+      end
+      """
+    When I run `cucumber -f debug`
+    Then the stderr should not contain anything
+    Then it should pass with:
+      """
+      before_features
+        before_feature
+          before_tags
+          after_tags
+          feature_name
+          before_feature_element
+            before_tags
+            after_tags
+            scenario_name
+            puts
+            embed
+            puts
+            embed
+            before_steps
+              before_step
+                before_step_result
+                  step_name
+                after_step_result
+              after_step
+              puts
+              embed
+              puts
+              embed
+            after_steps
+            puts
+            embed
+            puts
+            embed
+          after_feature_element
+          before_feature_element
+            before_tags
+            after_tags
+            scenario_name
+            before_steps
+              before_step
+                before_step_result
+                  step_name
+                after_step_result
+              after_step
+            after_steps
+            before_examples_array
+              before_examples
+                examples_name
+                before_outline_table
+                  before_table_row
+                    before_table_cell
+                      table_cell_value
+                    after_table_cell
+                  after_table_row
+                  puts
+                  embed
+                  puts
+                  embed
+                  before_table_row
+                    before_table_cell
+                      table_cell_value
+                    after_table_cell
+                  after_table_row
+                  puts
+                  embed
+                  puts
+                  embed
+                  puts
+                  embed
+                  puts
+                  embed
+                after_outline_table
+              after_examples
+            after_examples_array
+          after_feature_element
+        after_feature
+      after_features
+      """

data/features/docs/wire_protocol_table_diffing.feature

@@ -103,13 +103,16 @@ Feature: Wire protocol table diffing
       | ["invoke",{"id":"1","args":[]}]                      | ["diff!",[[["a"]],[["b"]]]]         |
       | ["end_scenario"]                                     | ["success"]                         |
     When I run `cucumber -f progress`
-    And it should fail with:
+    And it should fail with exactly:
       """
       F
 
       (::) failed steps (::)
 
-      Tables were not identical (Cucumber::MultilineArgument::DataTable::Different)
+      Tables were not identical:
+      
+        | (-) a | (+) b |
+       (Cucumber::MultilineArgument::DataTable::Different)
       features/wired.feature:3:in `Given we're all wired'
 
       Failing Scenarios:
@@ -117,5 +120,6 @@ Feature: Wire protocol table diffing
 
       1 scenario (1 failed)
       1 step (1 failed)
+      0m0.012s
 
       """

data/features/docs/writing_support_code/after_hooks.feature

@@ -0,0 +1,56 @@
+Feature: After Hooks
+
+  After hooks can be used to clean up any state you've altered during your
+  scenario, or to check the status of the scenario and act accordingly.
+
+  You can ask a scenario whether it has failed, for example.
+
+  Mind you, even if it hasn't failed yet, you can still make the scenario
+  fail if your After hook throws an error.
+
+  Background:
+    Given the standard step definitions
+
+  Scenario: Check the failed status of a scenario in a hook
+    Given a file named "features/support/debug_hook.rb" with:
+      """
+      After do |scenario|
+        if scenario.failed?
+          puts "eek"
+        end
+      end
+      """
+    And a file named "features/fail.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step fails
+      """
+    When I run `cucumber -f progress`
+    Then the output should contain:
+      """
+      eek
+      """
+
+  Scenario: Make a scenario fail from an After hook
+    Given a file named "features/support/bad_hook.rb" with:
+      """
+      After do
+        fail 'yikes'
+      end
+      """
+    And a file named "features/pass.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    When I run `cucumber -f pretty`
+    Then it should fail with:
+      """
+        Scenario:                # features/pass.feature:2
+          Given this step passes # features/step_definitions/steps.rb:1
+            yikes (RuntimeError)
+            ./features/support/bad_hook.rb:2:in `After'
+      """
+