csvlint 1.0.0 → 1.1.0

data/features/support/aruba.rb

@@ -1,12 +1,12 @@
-require 'aruba'
-require 'aruba/cucumber'
+require "aruba"
+require "aruba/cucumber"
 
-require 'csvlint/cli'
+require "csvlint/cli"
 
 module Csvlint
   class CliRunner
     # Allow everything fun to be injected from the outside while defaulting to normal implementations.
-    def initialize(argv, stdin = STDIN, stdout = STDOUT, stderr = STDERR, kernel = Kernel)
+    def initialize(argv, stdin = $stdin, stdout = $stdout, stderr = $stderr, kernel = Kernel)
       @argv, @stdin, @stdout, @stderr, @kernel = argv, stdin, stdout, stderr, kernel
     end
 
@@ -22,11 +22,11 @@ module Csvlint
 
         # Thor::Base#start does not have a return value, assume success if no exception is raised.
         0
-      rescue StandardError => e
+      rescue => e
         # The ruby interpreter would pipe this to STDERR and exit 1 in the case of an unhandled exception
         b = e.backtrace
         @stderr.puts("#{b.shift}: #{e.message} (#{e.class})")
-        @stderr.puts(b.map{|s| "\tfrom #{s}"}.join("\n"))
+        @stderr.puts(b.map { |s| "\tfrom #{s}" }.join("\n"))
         1
       rescue SystemExit => e
         e.status

data/features/support/earl_formatter.rb

@@ -1,33 +1,33 @@
-require 'rdf'
-require 'rdf/turtle'
+require "rdf"
+require "rdf/turtle"
 
 class EarlFormatter
   def initialize(step_mother, io, options)
     output = RDF::Resource.new("")
     @graph = RDF::Graph.new
-    @graph << [ CSVLINT, RDF.type, RDF::DOAP.Project ]
-    @graph << [ CSVLINT, RDF.type, EARL.TestSubject ]
-    @graph << [ CSVLINT, RDF.type, EARL.Software ]
-    @graph << [ CSVLINT, RDF::DOAP.name, "csvlint" ]
-    @graph << [ CSVLINT, RDF::DC.title, "csvlint" ]
-    @graph << [ CSVLINT, RDF::DOAP.description, "CSV validator" ]
-    @graph << [ CSVLINT, RDF::DOAP.homepage, RDF::Resource.new("https://github.com/theodi/csvlint.rb") ]
-    @graph << [ CSVLINT, RDF::DOAP.license, RDF::Resource.new("https://raw.githubusercontent.com/theodi/csvlint.rb/master/LICENSE.md") ]
-    @graph << [ CSVLINT, RDF::DOAP["programming-language"], "Ruby" ]
-    @graph << [ CSVLINT, RDF::DOAP.implements, RDF::Resource.new("http://www.w3.org/TR/tabular-data-model/") ]
-    @graph << [ CSVLINT, RDF::DOAP.implements, RDF::Resource.new("http://www.w3.org/TR/tabular-metadata/") ]
-    @graph << [ CSVLINT, RDF::DOAP.developer, ODI ]
-    @graph << [ CSVLINT, RDF::DOAP.maintainer, ODI ]
-    @graph << [ CSVLINT, RDF::DOAP.documenter, ODI ]
-    @graph << [ CSVLINT, RDF::FOAF.maker, ODI ]
-    @graph << [ CSVLINT, RDF::DC.creator, ODI ]
-    @graph << [ output, RDF::FOAF["primaryTopic"], CSVLINT ]
-    @graph << [ output, RDF::DC.issued, DateTime.now ]
-    @graph << [ output, RDF::FOAF.maker, ODI ]
-    @graph << [ ODI, RDF.type, RDF::FOAF.Organization ]
-    @graph << [ ODI, RDF.type, EARL.Assertor ]
-    @graph << [ ODI, RDF::FOAF.name, "Open Data Institute" ]
-    @graph << [ ODI, RDF::FOAF.homepage, "https://theodi.org/" ]
+    @graph << [CSVLINT, RDF.type, RDF::DOAP.Project]
+    @graph << [CSVLINT, RDF.type, EARL.TestSubject]
+    @graph << [CSVLINT, RDF.type, EARL.Software]
+    @graph << [CSVLINT, RDF::DOAP.name, "csvlint"]
+    @graph << [CSVLINT, RDF::DC.title, "csvlint"]
+    @graph << [CSVLINT, RDF::DOAP.description, "CSV validator"]
+    @graph << [CSVLINT, RDF::DOAP.homepage, RDF::Resource.new("https://github.com/theodi/csvlint.rb")]
+    @graph << [CSVLINT, RDF::DOAP.license, RDF::Resource.new("https://raw.githubusercontent.com/theodi/csvlint.rb/master/LICENSE.md")]
+    @graph << [CSVLINT, RDF::DOAP["programming-language"], "Ruby"]
+    @graph << [CSVLINT, RDF::DOAP.implements, RDF::Resource.new("http://www.w3.org/TR/tabular-data-model/")]
+    @graph << [CSVLINT, RDF::DOAP.implements, RDF::Resource.new("http://www.w3.org/TR/tabular-metadata/")]
+    @graph << [CSVLINT, RDF::DOAP.developer, ODI]
+    @graph << [CSVLINT, RDF::DOAP.maintainer, ODI]
+    @graph << [CSVLINT, RDF::DOAP.documenter, ODI]
+    @graph << [CSVLINT, RDF::FOAF.maker, ODI]
+    @graph << [CSVLINT, RDF::DC.creator, ODI]
+    @graph << [output, RDF::FOAF["primaryTopic"], CSVLINT]
+    @graph << [output, RDF::DC.issued, DateTime.now]
+    @graph << [output, RDF::FOAF.maker, ODI]
+    @graph << [ODI, RDF.type, RDF::FOAF.Organization]
+    @graph << [ODI, RDF.type, EARL.Assertor]
+    @graph << [ODI, RDF::FOAF.name, "Open Data Institute"]
+    @graph << [ODI, RDF::FOAF.homepage, "https://theodi.org/"]
   end
 
   def scenario_name(keyword, name, file_colon_line, source_indent)
@@ -40,27 +40,27 @@ class EarlFormatter
       passed = false unless s.status == :passed
     end
     a = RDF::Node.new
-    @graph << [ a, RDF.type, EARL.Assertion ]
-    @graph << [ a, EARL.assertedBy, ODI ]
-    @graph << [ a, EARL.subject, CSVLINT ]
-    @graph << [ a, EARL.test, @test ]
-    @graph << [ a, EARL.mode, EARL.automatic ]
+    @graph << [a, RDF.type, EARL.Assertion]
+    @graph << [a, EARL.assertedBy, ODI]
+    @graph << [a, EARL.subject, CSVLINT]
+    @graph << [a, EARL.test, @test]
+    @graph << [a, EARL.mode, EARL.automatic]
     r = RDF::Node.new
-    @graph << [ a, EARL.result, r ]
-    @graph << [ r, RDF.type, EARL.TestResult ]
-    @graph << [ r, EARL.outcome, passed ? EARL.passed : EARL.failed ]
-    @graph << [ r, RDF::DC.date, DateTime.now ]
+    @graph << [a, EARL.result, r]
+    @graph << [r, RDF.type, EARL.TestResult]
+    @graph << [r, EARL.outcome, passed ? EARL.passed : EARL.failed]
+    @graph << [r, RDF::DC.date, DateTime.now]
   end
 
   def after_features(features)
-    RDF::Writer.for(:ttl).open("csvlint-earl.ttl", { :prefixes => { "earl" => EARL }, :standard_prefixes => true, :canonicalize => true, :literal_shorthand => true }) do |writer|
+    RDF::Writer.for(:ttl).open("csvlint-earl.ttl", {prefixes: {"earl" => EARL}, standard_prefixes: true, canonicalize: true, literal_shorthand: true}) do |writer|
       writer << @graph
-    end 
+    end
   end
 
   private
-    EARL = RDF::Vocabulary.new("http://www.w3.org/ns/earl#")
-    ODI = RDF::Resource.new("https://theodi.org/")
-    CSVLINT = RDF::Resource.new("https://github.com/theodi/csvlint.rb")
 
+  EARL = RDF::Vocabulary.new("http://www.w3.org/ns/earl#")
+  ODI = RDF::Resource.new("https://theodi.org/")
+  CSVLINT = RDF::Resource.new("https://github.com/theodi/csvlint.rb")
 end

data/features/support/env.rb

@@ -1,23 +1,22 @@
-require 'coveralls'
-Coveralls.wear_merged!('test_frameworks')
+require "coveralls"
+Coveralls.wear_merged!("test_frameworks")
 
-$:.unshift File.join( File.dirname(__FILE__), "..", "..", "lib")
+$:.unshift File.join(File.dirname(__FILE__), "..", "..", "lib")
 
-require 'rspec/expectations'
-require 'cucumber/rspec/doubles'
-require 'csvlint'
-require 'byebug'
+require "rspec/expectations"
+require "cucumber/rspec/doubles"
+require "csvlint"
+require "byebug"
 
-require 'spork'
+require "spork"
 
 Spork.each_run do
-  require 'csvlint'
+  require "csvlint"
 end
 
 class CustomWorld
   def default_csv_options
-    return {
-    }
+    {}
   end
 end
 

data/features/support/load_tests.rb

@@ -1,6 +1,6 @@
-require 'json'
-require 'open-uri'
-require 'uri'
+require "json"
+require "open-uri"
+require "uri"
 
 BASE_URI = "https://w3c.github.io/csvw/tests/"
 BASE_PATH = File.join(File.dirname(__FILE__), "..", "fixtures", "csvw")
@@ -11,109 +11,113 @@ SCRIPT_FILE_PATH = File.join(File.dirname(__FILE__), "..", "..", "bin", "run-csv
 Dir.mkdir(BASE_PATH) unless Dir.exist?(BASE_PATH)
 
 def cache_file(filename)
-	file = File.join(BASE_PATH, filename)
-	uri = URI.join(BASE_URI, filename)
-	unless File.exist?(file)
-		if filename.include? "/"
-			levels = filename.split("/")[0..-2]
-			for i in 0..levels.length
-				dir = File.join(BASE_PATH, levels[0..i].join("/"))
-				Dir.mkdir(dir) unless Dir.exist?(dir)
-			end
-		end
-		STDERR.puts("storing #{file} locally")
-		File.open(file, 'wb') do |f|
-      f.puts URI.open(uri, 'rb').read
-		end
-	end
-	return uri, file
+  file = File.join(BASE_PATH, filename)
+  uri = URI.join(BASE_URI, filename)
+  unless File.exist?(file)
+    if filename.include? "/"
+      levels = filename.split("/")[0..-2]
+      for i in 0..levels.length
+        dir = File.join(BASE_PATH, levels[0..i].join("/"))
+        Dir.mkdir(dir) unless Dir.exist?(dir)
+      end
+    end
+    warn("storing #{file} locally")
+    File.open(file, "wb") do |f|
+      f.puts URI.open(uri, "rb").read
+    end
+  end
+  [uri, file]
 end
 
-File.open(SCRIPT_FILE_PATH, 'w') do |file|
-	File.chmod(0755, SCRIPT_FILE_PATH)
-  manifest = JSON.parse( URI.open("#{BASE_URI}manifest-validation.jsonld").read )
-	manifest["entries"].each do |entry|
-		type = "valid"
-		case entry["type"]
-		when "csvt:WarningValidationTest"
-			type = "warnings"
-		when "csvt:NegativeValidationTest"
-			type = "errors"
-		end
-		file.puts "echo \"#{entry["id"].split("#")[-1]}: #{entry["name"].gsub("`", "'")}\""
-		file.puts "echo \"#{type}: #{entry["comment"].gsub("\"", "\\\"").gsub("`", "'")}\""
-		if entry["action"].end_with?(".json")
-			file.puts "csvlint --schema=features/fixtures/csvw/#{entry["action"]}"
-		elsif entry["option"] && entry["option"]["metadata"]
-			file.puts "csvlint features/fixtures/csvw/#{entry["action"]} --schema=features/fixtures/csvw/#{entry["option"]["metadata"]}"
-		else
-			file.puts "csvlint features/fixtures/csvw/#{entry["action"]}"
-		end
-		file.puts "echo"
-	end
-end unless File.exist? SCRIPT_FILE_PATH
+unless File.exist? SCRIPT_FILE_PATH
+  File.open(SCRIPT_FILE_PATH, "w") do |file|
+    File.chmod(0o755, SCRIPT_FILE_PATH)
+    manifest = JSON.parse(URI.open("#{BASE_URI}manifest-validation.jsonld").read)
+    manifest["entries"].each do |entry|
+      type = "valid"
+      case entry["type"]
+      when "csvt:WarningValidationTest"
+        type = "warnings"
+      when "csvt:NegativeValidationTest"
+        type = "errors"
+      end
+      file.puts "echo \"#{entry["id"].split("#")[-1]}: #{entry["name"].tr("`", "'")}\""
+      file.puts "echo \"#{type}: #{entry["comment"].gsub("\"", "\\\"").tr("`", "'")}\""
+      if entry["action"].end_with?(".json")
+        file.puts "csvlint --schema=features/fixtures/csvw/#{entry["action"]}"
+      elsif entry["option"] && entry["option"]["metadata"]
+        file.puts "csvlint features/fixtures/csvw/#{entry["action"]} --schema=features/fixtures/csvw/#{entry["option"]["metadata"]}"
+      else
+        file.puts "csvlint features/fixtures/csvw/#{entry["action"]}"
+      end
+      file.puts "echo"
+    end
+  end
+end
 
-File.open(VALIDATION_FEATURE_FILE_PATH, 'w') do |file|
-	file.puts "# Auto-generated file based on standard validation CSVW tests from #{BASE_URI}manifest-validation.jsonld"
-	file.puts ""
+unless File.exist? VALIDATION_FEATURE_FILE_PATH
+  File.open(VALIDATION_FEATURE_FILE_PATH, "w") do |file|
+    file.puts "# Auto-generated file based on standard validation CSVW tests from #{BASE_URI}manifest-validation.jsonld"
+    file.puts ""
 
-  manifest = JSON.parse( URI.open("#{BASE_URI}manifest-validation.jsonld").read )
+    manifest = JSON.parse(URI.open("#{BASE_URI}manifest-validation.jsonld").read)
 
-	file.puts "Feature: #{manifest["label"]}"
-	file.puts ""
+    file.puts "Feature: #{manifest["label"]}"
+    file.puts ""
 
-	manifest["entries"].each do |entry|
-		action_uri, action_file = cache_file(entry["action"])
-		metadata = nil
-		provided_files = []
-		missing_files = []
-		file.puts "\t# #{entry["id"]}"
-		file.puts "\t# #{entry["comment"]}"
-		file.puts "\tScenario: #{entry["id"]} #{entry["name"].gsub("<", "less than")}"
-		if entry["action"].end_with?(".json")
-			file.puts "\t\tGiven I have a metadata file called \"csvw/#{entry["action"]}\""
-			file.puts "\t\tAnd the metadata is stored at the url \"#{action_uri}\""
-		else
-			file.puts "\t\tGiven I have a CSV file called \"csvw/#{entry["action"]}\""
-			file.puts "\t\tAnd it has a Link header holding \"#{entry["httpLink"]}\"" if entry["httpLink"]
-			file.puts "\t\tAnd it is stored at the url \"#{action_uri}\""
-			if entry["option"] && entry["option"]["metadata"]
-				# no need to store the file here, as it will be listed in the 'implicit' list, which all get stored
-				metadata = URI.join(BASE_URI, entry["option"]["metadata"])
-				file.puts "\t\tAnd I have a metadata file called \"csvw/#{entry["option"]["metadata"]}\""
-				file.puts "\t\tAnd the metadata is stored at the url \"#{metadata}\""
-			end
-			provided_files << action_uri.to_s
-			if entry["name"].include?("/.well-known/csvm")
-				file.puts "\t\tAnd I have a file called \"w3.org/.well-known/csvm\" at the url \"https://www.w3.org/.well-known/csvm\""
-	  			missing_files << "#{action_uri}.json"
-	  			missing_files << URI.join(action_uri, 'csvm.json').to_s
-			else
-				missing_files << URI.join(action_uri, '/.well-known/csvm').to_s
-			end
-  			missing_files << "#{action_uri}-metadata.json"
-  			missing_files << URI.join(action_uri, 'csv-metadata.json').to_s
-		end
-		entry["implicit"].each do |implicit|
-			implicit_uri, implicit_file = cache_file(implicit)
-			provided_files << implicit_uri.to_s
-			unless implicit_uri == metadata
-				file.puts "\t\tAnd I have a file called \"csvw/#{implicit}\" at the url \"#{implicit_uri}\""
-			end
-		end if entry["implicit"]
-		missing_files.each do |uri|
-			file.puts "\t\tAnd there is no file at the url \"#{uri}\"" unless provided_files.include? uri
-		end
-		file.puts "\t\tWhen I carry out CSVW validation"
-		if entry["type"] == "csvt:WarningValidationTest"
-			file.puts "\t\tThen there should not be errors"
-			file.puts "\t\tAnd there should be warnings"
-		elsif entry["type"] == "csvt:NegativeValidationTest"
-	    	file.puts "\t\tThen there should be errors"
-		else
-		    file.puts "\t\tThen there should not be errors"
-		    file.puts "\t\tAnd there should not be warnings"
-		end
-		file.puts "\t"
-	end
-end unless File.exist? VALIDATION_FEATURE_FILE_PATH
+    manifest["entries"].each do |entry|
+      action_uri, action_file = cache_file(entry["action"])
+      metadata = nil
+      provided_files = []
+      missing_files = []
+      file.puts "\t# #{entry["id"]}"
+      file.puts "\t# #{entry["comment"]}"
+      file.puts "\tScenario: #{entry["id"]} #{entry["name"].gsub("<", "less than")}"
+      if entry["action"].end_with?(".json")
+        file.puts "\t\tGiven I have a metadata file called \"csvw/#{entry["action"]}\""
+        file.puts "\t\tAnd the metadata is stored at the url \"#{action_uri}\""
+      else
+        file.puts "\t\tGiven I have a CSV file called \"csvw/#{entry["action"]}\""
+        file.puts "\t\tAnd it has a Link header holding \"#{entry["httpLink"]}\"" if entry["httpLink"]
+        file.puts "\t\tAnd it is stored at the url \"#{action_uri}\""
+        if entry["option"] && entry["option"]["metadata"]
+          # no need to store the file here, as it will be listed in the 'implicit' list, which all get stored
+          metadata = URI.join(BASE_URI, entry["option"]["metadata"])
+          file.puts "\t\tAnd I have a metadata file called \"csvw/#{entry["option"]["metadata"]}\""
+          file.puts "\t\tAnd the metadata is stored at the url \"#{metadata}\""
+        end
+        provided_files << action_uri.to_s
+        if entry["name"].include?("/.well-known/csvm")
+          file.puts "\t\tAnd I have a file called \"w3.org/.well-known/csvm\" at the url \"https://www.w3.org/.well-known/csvm\""
+          missing_files << "#{action_uri}.json"
+          missing_files << URI.join(action_uri, "csvm.json").to_s
+        else
+          missing_files << URI.join(action_uri, "/.well-known/csvm").to_s
+        end
+        missing_files << "#{action_uri}-metadata.json"
+        missing_files << URI.join(action_uri, "csv-metadata.json").to_s
+      end
+      entry["implicit"]&.each do |implicit|
+        implicit_uri, implicit_file = cache_file(implicit)
+        provided_files << implicit_uri.to_s
+        unless implicit_uri == metadata
+          file.puts "\t\tAnd I have a file called \"csvw/#{implicit}\" at the url \"#{implicit_uri}\""
+        end
+      end
+      missing_files.each do |uri|
+        file.puts "\t\tAnd there is no file at the url \"#{uri}\"" unless provided_files.include? uri
+      end
+      file.puts "\t\tWhen I carry out CSVW validation"
+      if entry["type"] == "csvt:WarningValidationTest"
+        file.puts "\t\tThen there should not be errors"
+        file.puts "\t\tAnd there should be warnings"
+      elsif entry["type"] == "csvt:NegativeValidationTest"
+        file.puts "\t\tThen there should be errors"
+      else
+        file.puts "\t\tThen there should not be errors"
+        file.puts "\t\tAnd there should not be warnings"
+      end
+      file.puts "\t"
+    end
+  end
+end

data/features/support/webmock.rb

@@ -1,3 +1,3 @@
-require 'webmock/cucumber'
+require "webmock/cucumber"
 
-WebMock.disable_net_connect!(allow: %r{csvw/tests})
+WebMock.disable_net_connect!(allow: %r{csvw/tests})