coverband 4.2.7 → 5.0.0.rc.7

data/test/coverband/configuration_test.rb

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
-require File.expand_path('../test_helper', File.dirname(__FILE__))
+require File.expand_path("../test_helper", File.dirname(__FILE__))
 
 class BaseTest < Minitest::Test
   def setup
+    Coverband.configuration.reset
     super
     Coverband.configuration.reset
     Coverband.configure do |config|
-      config.root                = Dir.pwd
-      config.s3_bucket           = nil
-      config.root_paths          = ['/app_path/']
-      config.ignore              = ['config/envionments']
-      config.reporter            = 'std_out'
-      config.store               = Coverband::Adapters::RedisStore.new(Coverband::Test.redis, redis_namespace: 'coverband_test')
+      config.root = Dir.pwd
+      config.root_paths = ["/app_path/"]
+      config.ignore = ["config/envionments"]
+      config.reporter = "std_out"
+      config.store = Coverband::Adapters::RedisStore.new(Coverband::Test.redis, redis_namespace: "coverband_test")
     end
   end
 
@@ -22,9 +22,9 @@ class BaseTest < Minitest::Test
     assert_equal expected, Coverband.configuration.ignore
   end
 
-  test 'ignore works with plus equal' do
+  test "ignore works with plus equal" do
     Coverband.configure do |config|
-      config.ignore += ['config/initializers']
+      config.ignore += ["config/initializers"]
     end
     Coverband::Collectors::Coverage.instance.reset_instance
     expected = ["vendor/",
@@ -38,23 +38,12 @@ class BaseTest < Minitest::Test
     assert_equal expected, Coverband.configuration.ignore
   end
 
-  test 'ignore' do
-    Coverband::Collectors::Coverage.instance.reset_instance
-    assert !Coverband.configuration.gem_paths.first.nil?
-  end
-
-  test 'gem_paths' do
-    Coverband::Collectors::Coverage.instance.reset_instance
-    assert !Coverband.configuration.gem_paths.first.nil?
-  end
-
-  test 'groups' do
+  test "ignore" do
     Coverband::Collectors::Coverage.instance.reset_instance
-    Coverband.configuration.track_gems = true
-    assert_equal %w[App Gems], Coverband.configuration.groups.keys
+    assert !Coverband.configuration.ignore.first.nil?
   end
 
-  test 'all_root_paths' do
+  test "all_root_paths" do
     Coverband::Collectors::Coverage.instance.reset_instance
     current_paths = Coverband.configuration.root_paths.dup
     # verify previous bug fix
@@ -64,30 +53,54 @@ class BaseTest < Minitest::Test
     assert_equal current_paths, Coverband.configuration.root_paths
   end
 
-  test 's3 options' do
+  test "store raises when not set to supported adapter" do
+    Coverband::Collectors::Coverage.instance.reset_instance
+    assert_raises RuntimeError do
+      Coverband.configure do |config|
+        config.store = "fake"
+      end
+    end
+  end
+
+  test "store defaults to redis store" do
     Coverband::Collectors::Coverage.instance.reset_instance
+    assert_equal Coverband.configuration.store.class, Coverband::Adapters::RedisStore
+  end
+
+  test "store is a service store when api_key is set" do
+    Coverband::Collectors::Coverage.instance.reset_instance
+    Coverband.configuration.reset
     Coverband.configure do |config|
-      config.s3_bucket = 'bucket'
-      config.s3_region = 'region'
-      config.s3_access_key_id = 'key_id'
-      config.s3_secret_access_key = 'secret'
+      config.redis_url = nil
+      config.api_key = "test-key"
     end
-    assert_equal 'bucket', Coverband.configuration.s3_bucket
-    assert_equal 'region', Coverband.configuration.s3_region
-    assert_equal 'key_id', Coverband.configuration.s3_access_key_id
-    assert_equal 'secret', Coverband.configuration.s3_secret_access_key
+    assert_equal Coverband.configuration.store.class.to_s, "Coverband::Adapters::WebServiceStore"
   end
 
-  test 'store raises issues' do
+  test "store raises when api key set but not set to service" do
     Coverband::Collectors::Coverage.instance.reset_instance
+    Coverband.configuration.reset
+    assert_raises RuntimeError do
+      Coverband.configure do |config|
+        config.api_key = "test-key"
+        config.redis_url = "redis://localhost:3333"
+        config.store = Coverband::Adapters::RedisStore.new(Coverband::Test.redis, redis_namespace: "coverband_test")
+      end
+    end
+  end
+
+  test "store raises when api key and redis_url" do
+    Coverband::Collectors::Coverage.instance.reset_instance
+    Coverband.configuration.reset
     assert_raises RuntimeError do
       Coverband.configure do |config|
-        config.store = 'fake'
+        config.api_key = "test-key"
+        config.redis_url = "redis://localhost:3333"
       end
     end
   end
 
-  test 'use_oneshot_lines_coverage' do
+  test "use_oneshot_lines_coverage" do
     refute Coverband.configuration.use_oneshot_lines_coverage
 
     Coverband.configuration.stubs(:one_shot_coverage_implemented_in_ruby_version?).returns(true)
@@ -101,7 +114,7 @@ class BaseTest < Minitest::Test
     exception = assert_raises Exception do
       Coverband.configuration.use_oneshot_lines_coverage = true
     end
-    assert_equal 'One shot line coverage is only available in ruby >= 2.6', exception.message
+    assert_equal "One shot line coverage is only available in ruby >= 2.6", exception.message
     refute Coverband.configuration.use_oneshot_lines_coverage
   end
 end

data/test/coverband/coverband_test.rb

@@ -1,42 +1,42 @@
 # frozen_string_literal: true
 
-require File.expand_path('../test_helper', File.dirname(__FILE__))
+require File.expand_path("../test_helper", File.dirname(__FILE__))
 
 class CoverbandTest < Minitest::Test
-  test 'Coverband#start kicks off background reporting if enabled and not in rack server' do
-    Coverband.configuration.stubs(:background_reporting_enabled).returns(:true)
+  test "Coverband#start kicks off background reporting if enabled and not in rack server" do
+    Coverband.configuration.stubs(:background_reporting_enabled).returns(true)
     Coverband::RackServerCheck.expects(:running?).returns(false)
     Coverband::Background.expects(:start)
     Coverband.start
   end
 
-  test 'Coverband#start delays background reporting if enabled and running in a rack server' do
+  test "Coverband#start delays background reporting if enabled and running in a rack server" do
     Coverband.configuration.stubs(:background_reporting_enabled).returns(true)
     Coverband::RackServerCheck.expects(:running?).returns(true)
     Coverband::Background.expects(:start).never
     Coverband.start
   end
 
-  test 'Coverband#start does not kick off background reporting if not enabled' do
+  test "Coverband#start does not kick off background reporting if not enabled" do
     Coverband.configuration.stubs(:background_reporting_enabled).returns(false)
     Coverband::Background.expects(:start).never
     ::Coverband.start
   end
 
-  test 'Coverband#configured? works' do
+  test "Coverband#configured? works" do
     Coverband.configure
     assert Coverband.configured?
   end
 
-  test 'Eager load coverage block' do
-    Coverband.eager_loading_coverage {
-      #some code
+  test "Eager load coverage block" do
+    Coverband.eager_loading_coverage do
+      # some code
       1 + 1
-    }
+    end
     assert_equal :runtime, Coverband.configuration.store.type
   end
 
-  test 'Eager load coverage' do
+  test "Eager load coverage" do
     Coverband.eager_loading_coverage!
     assert_equal :eager_loading, Coverband.configuration.store.type
     Coverband.runtime_coverage!

data/test/coverband/integrations/background_middleware_test.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
-require 'rack'
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
+require "rack"
 
 class BackgroundMiddlewareTest < Minitest::Test
   def setup
@@ -11,23 +11,23 @@ class BackgroundMiddlewareTest < Minitest::Test
     end
   end
 
-  test 'call app' do
-    request = Rack::MockRequest.env_for('/anything.json')
+  test "call app" do
+    request = Rack::MockRequest.env_for("/anything.json")
     Coverband::Collectors::Coverage.instance.reset_instance
     middleware = Coverband::BackgroundMiddleware.new(fake_app)
     results = middleware.call(request)
-    assert_equal '/anything.json', results.last
+    assert_equal "/anything.json", results.last
   end
 
-  test 'pass all rack lint checks' do
+  test "pass all rack lint checks" do
     Coverband::Collectors::Coverage.instance.reset_instance
     app = Rack::Lint.new(Coverband::BackgroundMiddleware.new(fake_app))
-    env = Rack::MockRequest.env_for('/hello')
+    env = Rack::MockRequest.env_for("/hello")
     app.call(env)
   end
 
-  test 'starts background reporter when configured' do
-    request = Rack::MockRequest.env_for('/anything.json')
+  test "starts background reporter when configured" do
+    request = Rack::MockRequest.env_for("/anything.json")
     Coverband.configuration.stubs(:background_reporting_enabled).returns(true)
     Coverband::Background.expects(:start)
     middleware = Coverband::BackgroundMiddleware.new(fake_app)
@@ -38,7 +38,7 @@ class BackgroundMiddlewareTest < Minitest::Test
 
   def fake_app
     @fake_app ||= lambda do |env|
-      [200, { 'Content-Type' => 'text/plain' }, env['PATH_INFO']]
+      [200, {"Content-Type" => "text/plain"}, env["PATH_INFO"]]
     end
   end
 end

data/test/coverband/integrations/background_test.rb

@@ -1,28 +1,40 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 class BackgroundTest < Minitest::Test
   class ThreadDouble < Struct.new(:alive)
-    def exit; end
+    def exit
+    end
 
     def alive?
       alive
     end
   end
 
+  def setup
+    Coverband.configuration.reset
+    super
+    Coverband.configure do |config|
+      config.background_reporting_sleep_seconds = 60
+      Coverband.configuration.reporting_wiggle = 0
+    end
+  end
+
   def test_start
+    sleep_seconds = Coverband.configuration.background_reporting_sleep_seconds.to_i
     Thread.expects(:new).yields.returns(ThreadDouble.new(true))
     Coverband::Background.expects(:loop).yields
-    Coverband::Background.expects(:sleep).with(30)
+    Coverband::Background.expects(:sleep).with(sleep_seconds)
     Coverband::Collectors::Coverage.instance.expects(:report_coverage).once
     2.times { Coverband::Background.start }
   end
 
   def test_start_with_wiggle
+    sleep_seconds = Coverband.configuration.background_reporting_sleep_seconds.to_i
     Thread.expects(:new).yields.returns(ThreadDouble.new(true))
     Coverband::Background.expects(:loop).yields
-    Coverband::Background.expects(:sleep).with(35)
+    Coverband::Background.expects(:sleep).with(sleep_seconds + 5)
     Coverband::Background.expects(:rand).with(10).returns(5)
     Coverband.configuration.reporting_wiggle = 10
     Coverband::Collectors::Coverage.instance.expects(:report_coverage).once
@@ -32,7 +44,7 @@ class BackgroundTest < Minitest::Test
   def test_start_dead_thread
     Thread.expects(:new).yields.returns(ThreadDouble.new(false)).twice
     Coverband::Background.expects(:loop).yields.twice
-    Coverband::Background.expects(:sleep).with(30).twice
+    Coverband::Background.expects(:sleep).with(60).twice
     Coverband::Collectors::Coverage.instance.expects(:report_coverage).twice
     2.times { Coverband::Background.start }
   end

data/test/coverband/integrations/rack_server_check_test.rb

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 class RackServerCheckTest < Minitest::Test
-  test 'returns true when running in rack server' do
-    caller_locations = ['blah/lib/rack/server.rb'].map { |path| OpenStruct.new(path: path, label: 'foo') }
+  test "returns true when running in rack server" do
+    caller_locations = ["blah/lib/rack/server.rb"].map { |path| OpenStruct.new(path: path, label: "foo") }
     Kernel.expects(:caller_locations).returns(caller_locations)
     assert(Coverband::RackServerCheck.running?)
   end
 
-  test 'returns false when not running in rack server' do
-    caller_locations = ['blah/lib/sidekiq/worker.rb'].map { |path| OpenStruct.new(path: path, label: 'foo') }
+  test "returns false when not running in rack server" do
+    caller_locations = ["blah/lib/sidekiq/worker.rb"].map { |path| OpenStruct.new(path: path, label: "foo") }
     Kernel.expects(:caller_locations).returns(caller_locations)
     refute(Coverband::RackServerCheck.running?)
   end
 
-  test 'returns true if running within a rails server' do
-    caller_locations = [OpenStruct.new(path: '/lib/rails/commands/commands_tasks.rb', label: 'server')]
+  test "returns true if running within a rails server" do
+    caller_locations = [OpenStruct.new(path: "/lib/rails/commands/commands_tasks.rb", label: "server")]
     Kernel.expects(:caller_locations).returns(caller_locations)
     assert(Coverband::RackServerCheck.running?)
   end

data/test/coverband/integrations/report_middleware_test.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
-require 'coverband/integrations/report_middleware'
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
+require "coverband/integrations/report_middleware"
 
 class ReportMiddlewareTest < Minitest::Test
   def setup
@@ -11,21 +11,21 @@ class ReportMiddlewareTest < Minitest::Test
     end
   end
 
-  test 'reports coverage' do
-    request = Rack::MockRequest.env_for('/anything.json')
+  test "reports coverage" do
+    request = Rack::MockRequest.env_for("/anything.json")
     Coverband::Collectors::Coverage.instance.expects(:report_coverage)
     middleware = Coverband::ReportMiddleware.new(fake_app)
     middleware.call(request)
   end
 
-  test 'reports coverage when an error is raised' do
-    request = Rack::MockRequest.env_for('/anything.json')
+  test "reports coverage when an error is raised" do
+    request = Rack::MockRequest.env_for("/anything.json")
     Coverband::Collectors::Coverage.instance.reset_instance
     Coverband::Collectors::Coverage.instance.expects(:report_coverage).once
     middleware = Coverband::ReportMiddleware.new(fake_app_raise_error)
     begin
       middleware.call(request)
-    rescue StandardError
+    rescue
       nil
     end
   end
@@ -34,11 +34,11 @@ class ReportMiddlewareTest < Minitest::Test
 
   def fake_app
     @fake_app ||= lambda do |env|
-      [200, { 'Content-Type' => 'text/plain' }, env['PATH_INFO']]
+      [200, {"Content-Type" => "text/plain"}, env["PATH_INFO"]]
     end
   end
 
   def fake_app_raise_error
-    @fake_app_raise_error ||= -> { raise 'hell' }
+    @fake_app_raise_error ||= -> { raise "hell" }
   end
 end

data/test/coverband/integrations/resque_worker_test.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 class ResqueWorkerTest < Minitest::Test
   def enqueue_and_run_job
     Resque.enqueue(TestResqueJob)
-    queue = ENV['QUEUE'] = 'resque_coverband'
+    ENV["QUEUE"] = "resque_coverband"
     worker = Resque::Worker.new
     worker.startup
     worker.work_one_job
@@ -21,9 +21,9 @@ class ResqueWorkerTest < Minitest::Test
     Resque.redis = redis
   end
 
-  test 'resque job coverage' do
-    relative_job_file = './test/coverband/integrations/test_resque_job.rb'
-    resque_job_file = File.expand_path('./test_resque_job.rb', File.dirname(__FILE__))
+  test "resque job coverage" do
+    relative_job_file = "./test/coverband/integrations/test_resque_job.rb"
+    resque_job_file = File.expand_path("./test_resque_job.rb", File.dirname(__FILE__))
     require resque_job_file
 
     enqueue_and_run_job
@@ -35,13 +35,13 @@ class ResqueWorkerTest < Minitest::Test
     Coverband.runtime_coverage!
     report = Coverband.configuration.store.get_coverage_report
 
-    if RUBY_PLATFORM == 'java'
+    if RUBY_PLATFORM == "java"
       # NOTE: the todo test only issue seems to be slightly different in JRuby
       # were nothing is showing up as runtime Coverage... This appears to be a test only issue
-      assert_equal 1, report[Coverband::EAGER_TYPE][relative_job_file]['data'][6]
+      assert_equal 1, report[Coverband::EAGER_TYPE][relative_job_file]["data"][6]
     else
-      assert_equal 0, report[Coverband::EAGER_TYPE][relative_job_file]['data'][6]
-      assert_equal 1, report[Coverband::RUNTIME_TYPE][relative_job_file]['data'][6]
+      assert_equal 0, report[Coverband::EAGER_TYPE][relative_job_file]["data"][6]
+      assert_equal 1, report[Coverband::RUNTIME_TYPE][relative_job_file]["data"][6]
     end
   end
 end

data/test/coverband/integrations/test_resque_job.rb

@@ -4,6 +4,6 @@ class TestResqueJob
   @queue = :resque_coverband
 
   def self.perform
-    'resque job perform'
+    "resque job perform"
   end
 end

data/test/coverband/reporters/base_test.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 class ReportsBaseTest < Minitest::Test
   def setup
     super
   end
 
-  test '#merge_arrays basic merge preserves order and counts' do
+  test "#merge_arrays basic merge preserves order and counts" do
     first = [0, 0, 1, 0, 1]
     second = [nil, 0, 1, 0, 0]
     expects = [0, 0, 2, 0, 1]
@@ -15,7 +15,7 @@ class ReportsBaseTest < Minitest::Test
     assert_equal expects, Coverband::Reporters::Base.send(:merge_arrays, first, second)
   end
 
-  test '#merge_arrays basic merge preserves order and counts different lengths' do
+  test "#merge_arrays basic merge preserves order and counts different lengths" do
     first = [0, 0, 1, 0, 1]
     second = [nil, 0, 1, 0, 0, 0, 0, 1]
     expects = [0, 0, 2, 0, 1, 0, 0, 1]
@@ -23,7 +23,7 @@ class ReportsBaseTest < Minitest::Test
     assert_equal expects, Coverband::Reporters::Base.send(:merge_arrays, first, second)
   end
 
-  test '#merge_arrays basic merge preserves nils' do
+  test "#merge_arrays basic merge preserves nils" do
     first = [0, 1, 2, nil, nil, nil]
     second = [0, 1, 2, nil, 0, 1, 2]
     expects = [0, 2, 4, nil, 0, 1, 2]
@@ -33,16 +33,16 @@ class ReportsBaseTest < Minitest::Test
 
   test "#get_current_scov_data_imp doesn't ignore folders with default ignore keys" do
     Coverband.configure do |config|
-      config.reporter          = 'std_out'
-      config.root              = '/full/remote_app/path'
+      config.reporter = "std_out"
+      config.root = "/full/remote_app/path"
     end
 
-    key = '/a_path/that_has_erb_in/thepath.rb'
-    roots = ['/app/', '/full/remote_app/path/']
+    key = "/a_path/that_has_erb_in/thepath.rb"
+    roots = ["/app/", "/full/remote_app/path/"]
 
     lines_hit = [1, 3, 6]
     store.stubs(:merged_coverage).returns(key => lines_hit)
-    expected = { key => [1, 3, 6] }
+    expected = {key => [1, 3, 6]}
 
     assert_equal expected, Coverband::Reporters::Base.send(:get_current_scov_data_imp, store, roots)[:merged]
   end