coverband 4.2.7 → 5.0.0.rc.7

data/test/coverband/utils/source_file_test.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 ####
 # Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
@@ -8,32 +8,32 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 ####
 describe Coverband::Utils::SourceFile do
   COVERAGE_FOR_SAMPLE_RB = [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil, nil, nil, nil, nil, nil, nil].freeze
-  describe 'a source file initialized with some coverage data' do
+  describe "a source file initialized with some coverage data" do
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('sample.rb'), COVERAGE_FOR_SAMPLE_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB)
     end
 
-    it 'has a filename' do
+    it "has a filename" do
       assert subject.filename
     end
 
-    it 'has source equal to src' do
+    it "has source equal to src" do
       assert_equal subject.source, subject.src
     end
 
-    it 'has a project filename which removes the project directory' do
-      assert_equal '/test/fixtures/sample.rb', subject.project_filename
+    it "has a project filename which removes the project directory" do
+      assert_equal "/test/fixtures/sample.rb", subject.project_filename
     end
 
-    it 'has source_lines equal to lines' do
+    it "has source_lines equal to lines" do
       assert_equal subject.source_lines, subject.lines
     end
 
-    it 'has 16 source lines' do
+    it "has 16 source lines" do
       assert_equal 16, subject.lines.count
     end
 
-    it 'has all source lines of type Coverband::Utils::SourceFile::Line' do
+    it "has all source lines of type Coverband::Utils::SourceFile::Line" do
       subject.lines.each do |line|
         assert line.is_a?(Coverband::Utils::SourceFile::Line)
       end
@@ -43,161 +43,111 @@ describe Coverband::Utils::SourceFile do
       assert_equal "class Foo\n", subject.line(2).source
     end
 
-    it 'returns lines number 2, 3, 4, 7 for covered_lines' do
+    it "returns lines number 2, 3, 4, 7 for covered_lines" do
       assert_equal [2, 3, 4, 7], subject.covered_lines.map(&:line)
     end
 
-    it 'returns lines number 8 for missed_lines' do
+    it "returns lines number 8 for missed_lines" do
       assert_equal [8], subject.missed_lines.map(&:line)
     end
 
-    it 'returns lines number 1, 5, 6, 9, 10, 16 for never_lines' do
+    it "returns lines number 1, 5, 6, 9, 10, 16 for never_lines" do
       assert_equal [1, 5, 6, 9, 10, 16], subject.never_lines.map(&:line)
     end
 
-    it 'returns line numbers 11, 12, 13, 14, 15 for skipped_lines' do
+    it "returns line numbers 11, 12, 13, 14, 15 for skipped_lines" do
       assert_equal [11, 12, 13, 14, 15], subject.skipped_lines.map(&:line)
     end
 
-    it 'has 80% covered_percent' do
+    it "has 80% covered_percent" do
       assert_equal 80.0, subject.covered_percent
     end
 
-    it 'working for nil last_updated_at' do
+    it "working for nil last_updated_at" do
       assert_equal "not available", subject.last_updated_at
     end
   end
 
-  describe 'simulating potential Ruby 1.9 defect -- see Issue #56' do
+  describe "simulating potential Ruby 1.9 defect -- see Issue #56" do
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('sample.rb'), COVERAGE_FOR_SAMPLE_RB + [nil])
+      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB + [nil])
     end
 
-    it 'has 16 source lines regardless of extra data in coverage array' do
+    it "has 16 source lines regardless of extra data in coverage array" do
       # Do not litter test output with known warning
       capture_stderr { assert_equal 16, subject.lines.count }
     end
 
-    it 'prints a warning to stderr if coverage array contains more data than lines in the file' do
-      captured_output = capture_stderr do
+    it "prints a warning to stderr if coverage array contains more data than lines in the file" do
+      captured_output = capture_stderr {
         subject.lines
-      end
+      }
 
       assert(captured_output.match(/^Warning: coverage data/))
     end
   end
 
-  describe 'a file that is never relevant' do
+  describe "a file that is never relevant" do
     COVERAGE_FOR_NEVER_RB = [nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('never.rb'), COVERAGE_FOR_NEVER_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("never.rb"), COVERAGE_FOR_NEVER_RB)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 100.0, subject.covered_percent
     end
   end
 
-  describe 'a file where nothing is ever executed mixed with skipping #563' do
+  describe "a file where nothing is ever executed mixed with skipping #563" do
     COVERAGE_FOR_SKIPPED_RB = [nil, nil, nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('skipped.rb'), COVERAGE_FOR_SKIPPED_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 0.0, subject.covered_percent
     end
   end
 
-  describe 'a file where everything is skipped and missed #563' do
+  describe "a file where everything is skipped and missed #563" do
     COVERAGE_FOR_SKIPPED_RB_2 = [nil, nil, 0, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('skipped.rb'), COVERAGE_FOR_SKIPPED_RB_2)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB_2)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 0.0, subject.covered_percent
     end
   end
 
-  describe 'a file where everything is skipped/irrelevamt but executed #563' do
+  describe "a file where everything is skipped/irrelevamt but executed #563" do
     COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, nil, nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('skipped_and_executed.rb'), COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped_and_executed.rb"), COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 0.0, subject.covered_percent
     end
   end
-
-  describe 'correctly identifies gems' do
-    COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, 1, 1, nil].freeze
-
-    describe 'the word gem in a path' do
-      subject do
-        Coverband::Utils::SourceFile.new('lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert_equal nil, subject.gem?
-      end
-    end
-
-    describe 'a folder gem in the path' do
-      subject do
-        Coverband::Utils::SourceFile.new('/var/gems/rubocop-0.67.0/lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert subject.gem?
-      end
-    end
-  end
-
-  describe 'correctly reports gem name' do
-    COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, 1, 1, nil].freeze
-
-    describe 'the word gem in a path' do
-      subject do
-        Coverband::Utils::SourceFile.new('lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert_equal nil, subject.gem_name
-      end
-    end
-
-    describe 'a folder gem in the path' do
-      subject do
-        Coverband::Utils::SourceFile.new('/var/gems/rubocop-0.67.0/lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert_equal 'rubocop-0.67.0', subject.gem_name
-      end
-    end
-  end
-
-
 end

data/test/dog.rb

@@ -2,6 +2,6 @@
 
 class Dog
   def bark
-    'woof'
+    "woof"
   end
 end

data/test/fake_app/basic_rack.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'rack'
+require "rack"
 
 class HelloWorld
   def call(_env)
-    [200, { 'Content-Type' => 'text/html' }, 'Hello Rack!']
+    [200, {"Content-Type" => "text/html"}, "Hello Rack!"]
   end
 end

data/test/fixtures/app/controllers/sample_controller.rb

@@ -1,7 +1,7 @@
 # Foo class
 class Foo
   def initialize
-    @foo = 'baz'
+    @foo = "baz"
   end
 
   def bar

data/test/fixtures/app/models/user.rb

@@ -1,7 +1,7 @@
 # Foo class
 class Foo
   def initialize
-    @foo = 'baz'
+    @foo = "baz"
   end
 
   def bar

data/test/fixtures/sample.rb

@@ -1,7 +1,7 @@
 # Foo class
 class Foo
   def initialize
-    @foo = 'baz'
+    @foo = "baz"
   end
 
   def bar

data/test/fixtures/utf-8.rb

@@ -1,3 +1 @@
-# encoding: utf-8
-
 puts "135°C"

data/test/forked/rails_full_stack_test.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../rails_test_helper', File.dirname(__FILE__))
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
 
 class RailsFullStackTest < Minitest::Test
   include Capybara::DSL
@@ -11,8 +11,8 @@ class RailsFullStackTest < Minitest::Test
     rails_setup
     # preload first coverage hit
     Coverband.report_coverage
-    require 'rainbow'
-    Rainbow('this text is red').red
+    require "rainbow"
+    Rainbow("this text is red").red
   end
 
   def teardown
@@ -24,30 +24,27 @@ class RailsFullStackTest < Minitest::Test
   # We have to combine everything in one test
   # because we can only initialize rails once per test
   # run. Possibly fork test runs to avoid this problem in future?
-  unless ENV['COVERBAND_MEMORY_TEST']
-    test 'this is how we do it' do
-      visit '/dummy/show'
+  unless ENV["COVERBAND_MEMORY_TEST"]
+    test "this is how we do it" do
+      visit "/dummy/show"
       Coverband.report_coverage
-      assert_content('I am no dummy')
-      visit '/coverage'
-      within page.find('a', text: /dummy_controller.rb/).find(:xpath, '../..') do
-        assert_selector('td', text: '100.0 %')
+      assert_content("I am no dummy")
+      visit "/coverage"
+      within page.find("a", text: /dummy_controller.rb/).find(:xpath, "../..") do
+        assert_selector("td", text: "100.0 %")
       end
 
-      # Test gems are reporting coverage
-      assert_content('Gems')
-      assert page.html.match('rainbow/wrapper.rb')
-
       # Test eager load data stored separately
       dummy_controller = "./test/rails#{Rails::VERSION::MAJOR}_dummy/app/controllers/dummy_controller.rb"
       store.type = :eager_loading
       eager_expected = [1, 1, 0, nil, nil]
-      results = store.coverage[dummy_controller]['data']
+      results = store.coverage[dummy_controller]["data"]
       assert_equal(eager_expected, results)
 
       store.type = Coverband::RUNTIME_TYPE
       runtime_expected = [0, 0, 1, nil, nil]
-      results = store.coverage[dummy_controller]['data']
+      results = store.coverage[dummy_controller]["data"]
+      assert_equal(runtime_expected, results)
     end
   end
 
@@ -55,20 +52,20 @@ class RailsFullStackTest < Minitest::Test
   # as we run it in single test mode via the benchmarks.
   # Add new tests below this test
   ###
-  if ENV['COVERBAND_MEMORY_TEST']
-    test 'memory usage' do
-      return unless ENV['COVERBAND_MEMORY_TEST']
+  if ENV["COVERBAND_MEMORY_TEST"]
+    test "memory usage" do
+      return unless ENV["COVERBAND_MEMORY_TEST"]
 
       # we don't want this to run during our standard test suite
       # as the below profiler changes the runtime
       # and shold only be included for isolated processes
       begin
-        require 'memory_profiler'
+        require "memory_profiler"
 
         # warmup
         3.times do
-          visit '/dummy/show'
-          assert_content('I am no dummy')
+          visit "/dummy/show"
+          assert_content("I am no dummy")
           Coverband.report_coverage
         end
 
@@ -76,10 +73,10 @@ class RailsFullStackTest < Minitest::Test
         capture = StringIO.new
         $stdout = capture
 
-        MemoryProfiler.report do
+        MemoryProfiler.report {
           15.times do
-            visit '/dummy/show'
-            assert_content('I am no dummy')
+            visit "/dummy/show"
+            assert_content("I am no dummy")
             Coverband.report_coverage
             ###
             # Set to nil not {} as it is easier to verify that no memory is retained when nil gets released
@@ -91,12 +88,12 @@ class RailsFullStackTest < Minitest::Test
             # needed to test older versions to discover when we had the regression
             # Coverband::Collectors::Coverage.instance.send(:add_previous_results, nil)
           end
-        end.pretty_print
+        }.pretty_print
         data = $stdout.string
         $stdout = previous_out
         if data.match(/retained objects by gem(.*)retained objects by file/m)[0]&.match(/coverband/)
           puts data
-          raise 'leaking memory!!!'
+          raise "leaking memory!!!"
         end
       ensure
         $stdout = previous_out

data/test/forked/rails_rake_full_stack_test.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-require File.expand_path('../rails_test_helper', File.dirname(__FILE__))
-require 'rails'
-require 'pundit'
+require File.expand_path("../rails_test_helper", File.dirname(__FILE__))
+require "rails"
 
 class RailsRakeFullStackTest < Minitest::Test
   def setup
@@ -11,31 +10,13 @@ class RailsRakeFullStackTest < Minitest::Test
     Coverband.configure("./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb")
   end
 
-  test 'rake tasks shows coverage properly within eager_loading' do
-    store.instance_variable_set(:@redis_namespace, 'coverband_test')
-    store.clear!
-    system("COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile middleware")
-    store.instance_variable_set(:@redis_namespace, 'coverband_test')
-    store.type = :eager_loading
-    pundit_file = store.coverage.keys.grep(/pundit.rb/).first
-    refute_nil pundit_file
-    pundit_coverage = store.coverage[pundit_file]
-    refute_nil pundit_coverage
-    assert_includes pundit_coverage['data'], 1
-
-    store.type = Coverband::RUNTIME_TYPE
-    if ENV['SIMULATE_ONESHOT']
-      pundit_coverage = store.get_coverage_report[Coverband::RUNTIME_TYPE][pundit_file]
-      assert pundit_coverage['data'].compact.all? { |el| el == 0 }
-    else
-      pundit_coverage = store.coverage[pundit_file]
-      assert_nil pundit_coverage
-    end
-  end
+  # test 'rake tasks shows coverage properly within eager_loading' do
+  # this was testing gem data, which we no logner support and I dont know if this makes sense anymre
+  # end
 
   test "ignored rake tasks don't add coverage" do
     store.clear!
-    store.instance_variable_set(:@redis_namespace, 'coverband_test')
+    store.instance_variable_set(:@redis_namespace, "coverband_test")
     store.send(:save_report, basic_coverage_full_path)
     output = `COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile coverband:clear`
     assert_nil output.match(/Coverband: Reported coverage via thread/)
@@ -49,7 +30,7 @@ class RailsRakeFullStackTest < Minitest::Test
   test "doesn't exit non-zero with error on missing redis" do
     output = `COVERBAND_CONFIG=./test/rails#{Rails::VERSION::MAJOR}_dummy/config/coverband_missing_redis.rb bundle exec rake -f test/rails#{Rails::VERSION::MAJOR}_dummy/Rakefile -T`
     assert_equal 0, $?.to_i
-    if ENV['COVERBAND_HASH_REDIS_STORE']
+    if ENV["COVERBAND_HASH_REDIS_STORE"]
       assert output.match(/Redis is not available/)
     else
       assert output.match(/coverage failed to store/)