coverband 4.2.5.rc.2 → 5.0.0.rc.3

data/test/coverband/reporters/html_test.rb

@@ -1,95 +1,83 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 class ReportHTMLTest < Minitest::Test
   def setup
     super
     @store = Coverband.configuration.store
     Coverband.configure do |config|
-      config.store             = @store
-      config.root              = fixtures_root
-      config.ignore            = ['notsomething.rb', 'lib/*']
+      config.store = @store
+      config.root = fixtures_root
+      config.ignore = ["notsomething.rb", "lib/*"]
     end
     mock_file_hash
   end
 
-  test 'generate dynamic content hosted html report' do
+  test "generate dynamic content hosted html report" do
     @store.send(:save_report, basic_coverage)
 
     html = Coverband::Reporters::HTMLReport.new(@store,
-                                                static: false,
-                                                open_report: false).report
-    assert_match 'Generated by', html
+      open_report: false).report
+    assert_match "Generated by", html
   end
 
-  test 'files with no Coverage but in project are shown in reports' do
+  test "files with no Coverage but in project are shown in reports" do
     @store.send(:save_report, basic_source_fixture_coverage)
 
     html = Coverband::Reporters::HTMLReport.new(@store,
-                                                static: false,
-                                                open_report: false).report
-    assert_match 'sample.rb', html
+      open_report: false).report
+    assert_match "sample.rb", html
     # in project, but not in coverage data
-    assert_match 'app/models/user.rb', html
+    assert_match "app/models/user.rb", html
   end
 
-  test 'files with no Coverage but in project details page list warning' do
+  test "files with no Coverage but in project details page list warning" do
     @store.send(:save_report, basic_coverage_full_path)
 
-    filename = basic_coverage_file_full_path
+    basic_coverage_file_full_path
     base_path = Dir.pwd
     # in project, but not in coverage data
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: "#{Dir.pwd}/test/fixtures/app/models/user.rb",
-                                                base_path: base_path,
-                                                open_report: false).file_details
-    assert_match 'This file was never loaded', html
-  end
-
-  test 'generate static HTML report file' do
-    @store.send(:save_report, basic_coverage)
-
-    reporter = Coverband::Reporters::HTMLReport.new(@store,
-                                                    static: true,
-                                                    open_report: false)
-    Coverband::Utils::HTMLFormatter.any_instance.expects(:format_static_html!).once
-    reporter.report
+      filename: "#{Dir.pwd}/test/fixtures/app/models/user.rb",
+      base_path: base_path,
+      open_report: false).file_details
+    assert_match "This file was never loaded", html
   end
 
-  test 'generate dynamic content detailed file report' do
+  test "generate dynamic content detailed file report" do
     @store.send(:save_report, basic_coverage_full_path)
 
     filename = basic_coverage_file_full_path
-    base_path = '/coverage'
+    base_path = "/coverage"
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: filename,
-                                                base_path: base_path,
-                                                open_report: false).file_details
-    assert_match 'Coverage first seen', html
+      filename: filename,
+      base_path: base_path,
+      open_report: false).file_details
+    assert_match "Coverage first seen", html
   end
 
-  test 'generate dynamic content detailed file report handles missing file' do
+  test "generate dynamic content detailed file report handles missing file" do
     @store.send(:save_report, basic_coverage_full_path)
 
-    filename = 'missing_path'
-    base_path = '/coverage'
+    filename = "missing_path"
+    base_path = "/coverage"
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: filename,
-                                                base_path: base_path,
-                                                open_report: false).file_details
-    assert_match 'File No Longer Available', html
+      filename: filename,
+      base_path: base_path,
+      open_report: false).file_details
+    assert_match "File No Longer Available", html
   end
 
-  test 'generate dynamic content detailed file report does not allow loading real non project files' do
+  test "generate dynamic content detailed file report does not allow loading real non project files" do
     @store.send(:save_report, basic_coverage_full_path)
 
     filename = "#{test_root}/test_helper.rb"
-    base_path = '/coverage'
+    base_path = "/coverage"
     html = Coverband::Reporters::HTMLReport.new(Coverband.configuration.store,
-                                                filename: filename,
-                                                base_path: base_path,
-                                                open_report: false).file_details
-    assert_match 'File No Longer Available', html
+      filename: filename,
+      base_path: base_path,
+      open_report: false).file_details
+    assert_match "File No Longer Available", html
   end
 end

data/test/coverband/reporters/web_test.rb

@@ -1,13 +1,12 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
-require 'aws-sdk-s3'
-require File.expand_path('../../../lib/coverband/reporters/web', File.dirname(__FILE__))
-require 'rack/test'
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
+require File.expand_path("../../../lib/coverband/reporters/web", File.dirname(__FILE__))
+require "rack/test"
 
-ENV['RACK_ENV'] = 'test'
+ENV["RACK_ENV"] = "test"
 
-if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
+if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2.0")
   module Coverband
     class WebTest < Minitest::Test
       include Rack::Test::Methods
@@ -18,29 +17,28 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
 
       def teardown
         super
-        Coverband.configuration.s3_bucket = nil
       end
 
-      test 'renders index content' do
-        get '/'
+      test "renders index content" do
+        get "/"
         assert last_response.ok?
-        assert_match 'Coverband Admin', last_response.body
+        assert_match "Coverband Admin", last_response.body
       end
 
-      test 'renders index content for empty path' do
-        get ''
+      test "renders index content for empty path" do
+        get ""
         assert last_response.ok?
-        assert_match 'Coverband Admin', last_response.body
+        assert_match "Coverband Admin", last_response.body
       end
 
-      test 'renders 404' do
-        get '/show'
+      test "renders 404" do
+        get "/show"
         assert last_response.not_found?
-        assert_equal '404 error!', last_response.body
+        assert_equal "404 error!", last_response.body
       end
 
-      test 'clears coverband' do
-        post '/clear'
+      test "clears coverband" do
+        post "/clear"
         assert_equal 301, last_response.status
       end
     end

data/test/coverband/utils/absolute_file_converter_test.rb

@@ -1,53 +1,53 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 module Coverband
   module Utils
     class AbsoluteFileConverterTest < ::Minitest::Test
       def test_convert
         converter = AbsoluteFileConverter.new([FileUtils.pwd])
-        assert_equal("#{FileUtils.pwd}/lib/coverband.rb", converter.convert('./lib/coverband.rb'))
+        assert_equal("#{FileUtils.pwd}/lib/coverband.rb", converter.convert("./lib/coverband.rb"))
       end
 
       def test_convert_multiple_roots
-        converter = AbsoluteFileConverter.new(['/foo/bar', FileUtils.pwd])
-        assert_equal("#{FileUtils.pwd}/Rakefile", converter.convert('./Rakefile'))
+        converter = AbsoluteFileConverter.new(["/foo/bar", FileUtils.pwd])
+        assert_equal("#{FileUtils.pwd}/Rakefile", converter.convert("./Rakefile"))
       end
 
-      test 'relative_path_to_full leave filename from a key with a local path' do
-        converter = AbsoluteFileConverter.new(['/app/', '/full/remote_app/path/'])
-        assert_equal '/full/remote_app/path/is/a/path.rb', converter.convert('/full/remote_app/path/is/a/path.rb')
+      test "relative_path_to_full leave filename from a key with a local path" do
+        converter = AbsoluteFileConverter.new(["/app/", "/full/remote_app/path/"])
+        assert_equal "/full/remote_app/path/is/a/path.rb", converter.convert("/full/remote_app/path/is/a/path.rb")
       end
 
-      test 'relative_path_to_full fix filename from a key with a swappable path' do
-        key = '/app/is/a/path.rb'
-        converter = AbsoluteFileConverter.new(['/app/', '/full/remote_app/path/'])
-        expected_path = '/full/remote_app/path/is/a/path.rb'
+      test "relative_path_to_full fix filename from a key with a swappable path" do
+        key = "/app/is/a/path.rb"
+        converter = AbsoluteFileConverter.new(["/app/", "/full/remote_app/path/"])
+        expected_path = "/full/remote_app/path/is/a/path.rb"
         File.expects(:exist?).with(key).returns(false)
         File.expects(:exist?).with(expected_path).returns(true)
         assert_equal expected_path, converter.convert(key)
       end
 
-      test 'relative_path_to_full fix filename a changing deploy path with quotes' do
-        converter = AbsoluteFileConverter.new(['/box/apps/app_name/releases/\\d+/', '/full/remote_app/path/'])
-        expected_path = '/full/remote_app/path/app/models/user.rb'
-        key = '/box/apps/app_name/releases/20140725203539/app/models/user.rb'
+      test "relative_path_to_full fix filename a changing deploy path with quotes" do
+        converter = AbsoluteFileConverter.new(['/box/apps/app_name/releases/\\d+/', "/full/remote_app/path/"])
+        expected_path = "/full/remote_app/path/app/models/user.rb"
+        key = "/box/apps/app_name/releases/20140725203539/app/models/user.rb"
         File.expects(:exist?).with('/box/apps/app_name/releases/\\d+/app/models/user.rb').returns(false)
         File.expects(:exist?).with(expected_path).returns(true)
         assert_equal expected_path, converter.convert(key)
         assert_equal expected_path, converter.convert(key)
       end
 
-      test 'relative_path_to_full fix filename a changing deploy path real world examples' do
-        current_app_root = '/var/local/company/company.d/79'
-        converter = AbsoluteFileConverter.new(['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"])
+      test "relative_path_to_full fix filename a changing deploy path real world examples" do
+        current_app_root = "/var/local/company/company.d/79"
+        converter = AbsoluteFileConverter.new(["/var/local/company/company.d/[0-9]*/", "#{current_app_root}/"])
 
-        expected_path = '/var/local/company/company.d/79/app/controllers/dashboard_controller.rb'
-        key = '/var/local/company/company.d/78/app/controllers/dashboard_controller.rb'
-        File.expects(:exist?).with('/var/local/company/company.d/[0-9]*/app/controllers/dashboard_controller.rb').returns(false)
+        expected_path = "/var/local/company/company.d/79/app/controllers/dashboard_controller.rb"
+        key = "/var/local/company/company.d/78/app/controllers/dashboard_controller.rb"
+        File.expects(:exist?).with("/var/local/company/company.d/[0-9]*/app/controllers/dashboard_controller.rb").returns(false)
         File.expects(:exist?).with(expected_path).returns(true)
-        roots = ['/var/local/company/company.d/[0-9]*/', "#{current_app_root}/"]
+        # roots = ["/var/local/company/company.d/[0-9]*/", "#{current_app_root}/"]
         assert_equal expected_path, converter.convert(key)
         assert_equal expected_path, converter.convert(key)
       end

data/test/coverband/utils/file_hasher_test.rb

@@ -1,28 +1,22 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 module Coverband
   module Utils
     class FileHasherTest < Minitest::Test
       def test_hash_same_file
-        refute_nil FileHasher.hash('./test/dog.rb')
-        assert_equal(FileHasher.hash('./test/dog.rb'), FileHasher.hash('./test/dog.rb'))
-        assert_equal(FileHasher.hash(File.expand_path('./test/dog.rb')), FileHasher.hash('./test/dog.rb'))
+        refute_nil FileHasher.hash("./test/dog.rb")
+        assert_equal(FileHasher.hash("./test/dog.rb"), FileHasher.hash("./test/dog.rb"))
+        assert_equal(FileHasher.hash(File.expand_path("./test/dog.rb")), FileHasher.hash("./test/dog.rb"))
       end
 
       def test_hash_different_files
-        refute_equal(FileHasher.hash('./test/dog.rb'), FileHasher.hash('./lib/coverband.rb'))
+        refute_equal(FileHasher.hash("./test/dog.rb"), FileHasher.hash("./lib/coverband.rb"))
       end
 
       def test_hash_file_not_exists
-        assert_nil(FileHasher.hash('./made_up_file.py'))
-      end
-
-      def test_hash_gem_file
-        spec = Gem::Specification.find_by_name('rainbow')
-        assert FileHasher.hash("./gems/rainbow-#{spec.version}/lib/rainbow.rb",
-                               path_converter: AbsoluteFileConverter.new(Coverband.configuration.gem_paths))
+        assert_nil(FileHasher.hash("./made_up_file.py"))
       end
     end
   end

data/test/coverband/utils/file_list_test.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 ####
 # Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
@@ -9,46 +9,46 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 describe Coverband::Utils::FileList do
   subject do
     original_result = {
-      source_fixture('sample.rb') => {'first_updated_at' => Time.at(0), 'data' => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil]},
-      source_fixture('app/models/user.rb') => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-      source_fixture('app/controllers/sample_controller.rb') => [nil, 2, 2, 0, nil, nil, 0, nil, nil, nil]
+      source_fixture("sample.rb") => {"first_updated_at" => Time.at(0), "data" => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil]},
+      source_fixture("app/models/user.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
+      source_fixture("app/controllers/sample_controller.rb") => [nil, 2, 2, 0, nil, nil, 0, nil, nil, nil]
     }
     Coverband::Utils::Result.new(original_result).files
   end
 
-  it 'has 11 covered lines' do
+  it "has 11 covered lines" do
     assert_equal 11, subject.covered_lines
   end
 
-  it 'has 3 missed lines' do
+  it "has 3 missed lines" do
     assert_equal 3, subject.missed_lines
   end
 
-  it 'has 17 never lines' do
+  it "has 17 never lines" do
     assert_equal 17, subject.never_lines
   end
 
-  it 'has 14 lines of code' do
+  it "has 14 lines of code" do
     assert_equal 14, subject.lines_of_code
   end
 
-  it 'has 5 skipped lines' do
+  it "has 5 skipped lines" do
     assert_equal 5, subject.skipped_lines
   end
 
-  it 'has the correct covered percent' do
+  it "has the correct covered percent" do
     assert_equal 78.57142857142857, subject.covered_percent
   end
 
-  it 'has the correct covered percentages' do
+  it "has the correct covered percentages" do
     assert_equal [50.0, 80.0, 100.0], subject.covered_percentages
   end
 
-  it 'has the correct covered strength' do
+  it "has the correct covered strength" do
     assert_equal 0.9285714285714286, subject.covered_strength
   end
 
-  it 'has correct first_seen_at' do
+  it "has correct first_seen_at" do
     assert_equal Time.at(0), subject.first_seen_at
   end
 end

data/test/coverband/utils/html_formatter_test.rb

@@ -1,41 +1,27 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 class HTMLFormatterTest < Minitest::Test
   def setup
     super
-    @store = Coverband::Adapters::RedisStore.new(Coverband::Test.redis, redis_namespace: 'coverband_test')
+    @store = Coverband::Adapters::RedisStore.new(Coverband::Test.redis, redis_namespace: "coverband_test")
   end
 
-  test 'generate dynamic content hosted html report' do
+  test "generate dynamic content hosted html report" do
     Coverband.configure do |config|
-      config.store             = @store
-      config.ignore            = ['notsomething.rb']
+      config.store = @store
+      config.ignore = ["notsomething.rb"]
     end
     mock_file_hash
     @store.send(:save_report, basic_coverage_full_path)
 
     notice = nil
-    base_path = '/coverage'
+    base_path = "/coverage"
     filtered_report_files = Coverband::Reporters::Base.report(@store, {})
     html = Coverband::Utils::HTMLFormatter.new(filtered_report_files,
-                                               base_path: base_path,
-                                               notice: notice).format_dynamic_html!
-    assert_match 'loading source data', html
-  end
-
-  test 'generate static HTML report file' do
-    Coverband.configure do |config|
-      config.store             = @store
-      config.ignore            = ['notsomething.rb']
-    end
-    mock_file_hash
-    @store.send(:save_report, basic_coverage_full_path)
-
-    filtered_report_files = Coverband::Reporters::Base.report(@store, {})
-    Coverband::Utils::HTMLFormatter.new(filtered_report_files).format_static_html!
-    html = File.read("#{Coverband.configuration.root}/coverage/index.html")
-    assert_match 'Coverage first seen', html
+      base_path: base_path,
+      notice: notice).format_dynamic_html!
+    assert_match "loading source data", html
   end
 end

data/test/coverband/utils/lines_classifier_test.rb

@@ -1,34 +1,34 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 ####
 # Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
 # initial version of test pulled into Coverband from Simplecov 12/17/2018
 ####
 describe Coverband::Utils::LinesClassifier do
-  describe '#classify' do
+  describe "#classify" do
     def subject
       Coverband::Utils::LinesClassifier.new
     end
 
-    describe 'relevant lines' do
-      it 'determines code as relevant' do
+    describe "relevant lines" do
+      it "determines code as relevant" do
         classified_lines = subject.classify [
-          'module Foo',
-          '  class Baz',
-          '    def Bar',
+          "module Foo",
+          "  class Baz",
+          "    def Bar",
           "      puts 'hi'",
-          '    end',
-          '  end',
-          'end'
+          "    end",
+          "  end",
+          "end"
         ]
 
         assert_equal 7, classified_lines.length
         assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::RELEVANT })
       end
 
-      it 'determines invalid UTF-8 byte sequences as relevant' do
+      it "determines invalid UTF-8 byte sequences as relevant" do
         classified_lines = subject.classify [
           "bytes = \"\xF1t\xEBrn\xE2ti\xF4n\xE0liz\xE6ti\xF8n\""
         ]
@@ -38,11 +38,11 @@ describe Coverband::Utils::LinesClassifier do
       end
     end
 
-    describe 'not-relevant lines' do
-      it 'determines whitespace is not-relevant' do
+    describe "not-relevant lines" do
+      it "determines whitespace is not-relevant" do
         classified_lines = subject.classify [
-          '',
-          '   ',
+          "",
+          "   ",
           "\t\t"
         ]
 
@@ -50,11 +50,11 @@ describe Coverband::Utils::LinesClassifier do
         assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
       end
 
-      describe 'comments' do
-        it 'determines comments are not-relevant' do
+      describe "comments" do
+        it "determines comments are not-relevant" do
           classified_lines = subject.classify [
-            '#Comment',
-            ' # Leading space comment',
+            "#Comment",
+            " # Leading space comment",
             "\t# Leading tab comment"
           ]
 
@@ -72,27 +72,27 @@ describe Coverband::Utils::LinesClassifier do
         end
       end
 
-      describe ':nocov: blocks' do
-        it 'determines :nocov: blocks are not-relevant' do
+      describe ":nocov: blocks" do
+        it "determines :nocov: blocks are not-relevant" do
           classified_lines = subject.classify [
-            '# :nocov:',
-            'def hi',
-            'end',
-            '# :nocov:'
+            "# :nocov:",
+            "def hi",
+            "end",
+            "# :nocov:"
           ]
 
           assert_equal 4, classified_lines.length
           assert(classified_lines.all? { |line| line == Coverband::Utils::LinesClassifier::NOT_RELEVANT })
         end
 
-        it 'determines all lines after a non-closing :nocov: as not-relevant' do
+        it "determines all lines after a non-closing :nocov: as not-relevant" do
           classified_lines = subject.classify [
-            '# :nocov:',
+            "# :nocov:",
             "puts 'Not relevant'",
-            '# :nocov:',
+            "# :nocov:",
             "puts 'Relevant again'",
             "puts 'Still relevant'",
-            '# :nocov:',
+            "# :nocov:",
             "puts 'Not relevant till the end'",
             "puts 'Ditto'"
           ]