coverband 4.2.5.rc.2 → 5.0.0.rc.3

data/test/coverband/utils/relative_file_converter_test.rb

@@ -1,38 +1,38 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 module Coverband
   module Utils
     class RelativeFileConverterTest < ::Minitest::Test
       def test_convert
-        converter = RelativeFileConverter.new(['/bar/tmp/'])
-        assert_equal('./gracie.rb', converter.convert('/bar/tmp/gracie.rb'))
+        converter = RelativeFileConverter.new(["/bar/tmp/"])
+        assert_equal("./gracie.rb", converter.convert("/bar/tmp/gracie.rb"))
       end
 
       def test_convert_without_leading_forward_slash
-        converter = RelativeFileConverter.new(['/foo/bar'])
-        assert_equal('./file.rb', converter.convert('/foo/bar/file.rb'))
+        converter = RelativeFileConverter.new(["/foo/bar"])
+        assert_equal("./file.rb", converter.convert("/foo/bar/file.rb"))
       end
 
       def test_multiple_roots
-        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
-        assert_equal('./josie.rb', converter.convert('/foo/bar/josie.rb'))
+        converter = RelativeFileConverter.new(["/bar/tmp/", "/foo/bar/"])
+        assert_equal("./josie.rb", converter.convert("/foo/bar/josie.rb"))
       end
 
       def test_no_match
-        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
-        assert_equal('/foo/josie.rb', converter.convert('/foo/josie.rb'))
+        converter = RelativeFileConverter.new(["/bar/tmp/", "/foo/bar/"])
+        assert_equal("/foo/josie.rb", converter.convert("/foo/josie.rb"))
       end
 
       def test_middle_path_match
-        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
-        assert_equal('/tmp/foo/bar/josie.rb', converter.convert('/tmp/foo/bar/josie.rb'))
+        converter = RelativeFileConverter.new(["/bar/tmp/", "/foo/bar/"])
+        assert_equal("/tmp/foo/bar/josie.rb", converter.convert("/tmp/foo/bar/josie.rb"))
       end
 
       def test_already_relative_file
-        converter = RelativeFileConverter.new(['/bar/tmp/', '/foo/bar/'])
-        assert_equal('./foo/bar/josie.rb', converter.convert('./foo/bar/josie.rb'))
+        converter = RelativeFileConverter.new(["/bar/tmp/", "/foo/bar/"])
+        assert_equal("./foo/bar/josie.rb", converter.convert("./foo/bar/josie.rb"))
       end
     end
   end

data/test/coverband/utils/result_test.rb

@@ -1,59 +1,59 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 ####
 # Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
 # initial version of test pulled into Coverband from Simplecov 12/19/2018
 ####
-describe 'result' do
-  describe 'with a (mocked) Coverage.result' do
+describe "result" do
+  describe "with a (mocked) Coverage.result" do
     let(:original_result) do
       {
-        source_fixture('sample.rb') => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
-        source_fixture('app/models/user.rb') => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-        source_fixture('app/controllers/sample_controller.rb') => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil]
+        source_fixture("sample.rb") => [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil],
+        source_fixture("app/models/user.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil],
+        source_fixture("app/controllers/sample_controller.rb") => [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil]
       }
     end
 
-    describe 'a simple cov result initialized from that' do
+    describe "a simple cov result initialized from that" do
       subject { Coverband::Utils::Result.new(original_result) }
 
-      it 'has 3 filenames' do
+      it "has 3 filenames" do
         assert_equal 3, subject.filenames.count
       end
 
-      it 'has 3 source files' do
+      it "has 3 source files" do
         assert_equal 3, subject.source_files.count
         subject.source_files.each do |source_file|
           assert source_file.is_a?(Coverband::Utils::SourceFile)
         end
       end
 
-      it 'returns an instance of Coverband::Utils::FileList for source_files and files' do
+      it "returns an instance of Coverband::Utils::FileList for source_files and files" do
         assert subject.files.is_a?(Coverband::Utils::FileList)
         assert subject.source_files.is_a?(Coverband::Utils::FileList)
       end
 
-      it 'has files equal to source_files' do
+      it "has files equal to source_files" do
         assert_equal subject.source_files, subject.files
       end
 
-      it 'has accurate covered percent' do
+      it "has accurate covered percent" do
         # in our fixture, there are 13 covered line (result in 1) in all 15 relevant line (result in non-nil)
         assert_equal 86.66666666666667, subject.covered_percent
       end
 
-      it 'has accurate covered percentages' do
+      it "has accurate covered percentages" do
         assert_equal [80.0, 80.0, 100.0], subject.covered_percentages
       end
 
       %i[covered_percent
-         covered_percentages
-         covered_strength
-         covered_lines
-         missed_lines
-         total_lines].each do |msg|
+        covered_percentages
+        covered_strength
+        covered_lines
+        missed_lines
+        total_lines].each do |msg|
         it "responds to #{msg}" do
           assert(subject.respond_to?(msg))
         end

data/test/coverband/utils/results_test.rb

@@ -1,52 +1,52 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
-describe 'results' do
-  describe 'with a (mocked) Coverage.result' do
-    let(:source_file) { Coverband::Utils::SourceFile.new(source_fixture('app/models/user.rb'), run_lines) }
+describe "results" do
+  describe "with a (mocked) Coverage.result" do
+    let(:source_file) { Coverband::Utils::SourceFile.new(source_fixture("app/models/user.rb"), run_lines) }
     let(:eager_lines) { [nil, 1, 1, 0, nil, nil, 1, 0, nil, nil] }
-    let(:run_lines) { [nil, nil, nil, 1, nil, nil, nil,nil, nil, nil] }
+    let(:run_lines) { [nil, nil, nil, 1, nil, nil, nil, nil, nil, nil] }
     let(:original_result) do
       orig = {
-        Coverband::MERGED_TYPE => {source_fixture('app/models/user.rb') => eager_lines},
+        Coverband::MERGED_TYPE => {source_fixture("app/models/user.rb") => eager_lines}
       }
-      orig.merge!({Coverband::EAGER_TYPE => {source_fixture('app/models/user.rb') => eager_lines}}) if eager_lines
-      orig.merge!({Coverband::RUNTIME_TYPE => {source_fixture('app/models/user.rb') => run_lines}}) if run_lines
+      orig[Coverband::EAGER_TYPE] = {source_fixture("app/models/user.rb") => eager_lines} if eager_lines
+      orig[Coverband::RUNTIME_TYPE] = {source_fixture("app/models/user.rb") => run_lines} if run_lines
       orig
     end
     subject { Coverband::Utils::Results.new(original_result) }
 
-    describe 'runtime relevant lines is supported' do
-      it 'has correct runtime relevant coverage' do
+    describe "runtime relevant lines is supported" do
+      it "has correct runtime relevant coverage" do
         assert_equal 50.0, subject.runtime_relevant_coverage(source_file)
       end
 
-      it 'has correct runtime relevant lines' do
+      it "has correct runtime relevant lines" do
         assert_equal 2, subject.runtime_relavent_lines(source_file)
       end
     end
 
-    describe 'runtime relevant lines when no runtime coverage exists' do
+    describe "runtime relevant lines when no runtime coverage exists" do
       let(:run_lines) { nil }
 
-      it 'has correct runtime relevant lines' do
+      it "has correct runtime relevant lines" do
         assert_equal 0.0, subject.runtime_relevant_coverage(source_file)
       end
 
-      it 'has correct runtime relevant lines' do
+      it "has correct runtime relevant lines" do
         assert_equal 2, subject.runtime_relavent_lines(source_file)
       end
     end
 
-    describe 'runtime relevant lines when no eager coverage exists' do
+    describe "runtime relevant lines when no eager coverage exists" do
       let(:eager_lines) { nil }
 
-      it 'has correct runtime relevant lines' do
+      it "has correct runtime relevant lines" do
         assert_equal 100.0, subject.runtime_relevant_coverage(source_file)
       end
 
-      it 'has correct runtime relevant lines' do
+      it "has correct runtime relevant lines" do
         assert_equal 1, subject.runtime_relavent_lines(source_file)
       end
     end

data/test/coverband/utils/source_file_line_test.rb

@@ -1,165 +1,165 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 ####
 # Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
 # initial version of test pulled into Coverband from Simplecov 12/19/2018
 ####
 describe Coverband::Utils::SourceFile::Line do
-  describe 'a source line' do
+  describe "a source line" do
     subject do
-      Coverband::Utils::SourceFile::Line.new('# the ruby source', 5, 3)
+      Coverband::Utils::SourceFile::Line.new("# the ruby source", 5, 3)
     end
 
     it 'returns "# the ruby source" as src' do
-      assert_equal '# the ruby source', subject.src
+      assert_equal "# the ruby source", subject.src
     end
 
-    it 'returns the same for source as for src' do
+    it "returns the same for source as for src" do
       assert_equal subject.src, subject.source
     end
 
-    it 'has line number 5' do
+    it "has line number 5" do
       assert_equal 5, subject.line_number
     end
 
-    it 'has equal line_number, line and number' do
+    it "has equal line_number, line and number" do
       assert_equal subject.line, subject.line_number
       assert_equal subject.number, subject.line_number
     end
 
-    describe 'flagged as skipped!' do
+    describe "flagged as skipped!" do
       before do
         subject.skipped!
       end
-      it 'is not covered' do
+      it "is not covered" do
         refute subject.covered?
       end
 
-      it 'is skipped' do
+      it "is skipped" do
         assert subject.skipped?
       end
 
-      it 'is not missed' do
+      it "is not missed" do
         refute subject.missed?
       end
 
-      it 'is not never' do
+      it "is not never" do
         refute subject.never?
       end
 
-      it 'status is skipped' do
-        assert_equal 'skipped', subject.status
+      it "status is skipped" do
+        assert_equal "skipped", subject.status
       end
     end
   end
 
-  describe 'A source line with coverage' do
+  describe "A source line with coverage" do
     subject do
-      Coverband::Utils::SourceFile::Line.new('# the ruby source', 5, 3)
+      Coverband::Utils::SourceFile::Line.new("# the ruby source", 5, 3)
     end
 
-    it 'has coverage of 3' do
+    it "has coverage of 3" do
       assert_equal 3, subject.coverage
     end
 
-    it 'is covered' do
+    it "is covered" do
       assert subject.covered?
     end
 
-    it 'is not skipped' do
+    it "is not skipped" do
       refute subject.skipped?
     end
 
-    it 'is not missed' do
+    it "is not missed" do
       refute subject.missed?
     end
 
-    it 'is not never' do
+    it "is not never" do
       refute subject.never?
     end
 
-    it 'status is covered' do
-      assert_equal 'covered', subject.status
+    it "status is covered" do
+      assert_equal "covered", subject.status
     end
   end
 
-  describe 'A source line without coverage' do
+  describe "A source line without coverage" do
     subject do
-      Coverband::Utils::SourceFile::Line.new('# the ruby source', 5, 0)
+      Coverband::Utils::SourceFile::Line.new("# the ruby source", 5, 0)
     end
 
-    it 'has coverage of 0' do
+    it "has coverage of 0" do
       assert_equal 0, subject.coverage
     end
 
-    it 'is not covered' do
+    it "is not covered" do
       refute subject.covered?
     end
 
-    it 'is not skipped' do
+    it "is not skipped" do
       refute subject.skipped?
     end
 
-    it 'is missed' do
+    it "is missed" do
       assert subject.missed?
     end
 
-    it 'is not never' do
+    it "is not never" do
       refute subject.never?
     end
 
-    it 'status is missed' do
-      assert_equal 'missed', subject.status
+    it "status is missed" do
+      assert_equal "missed", subject.status
     end
   end
 
-  describe 'A source line with no code' do
+  describe "A source line with no code" do
     subject do
-      Coverband::Utils::SourceFile::Line.new('# the ruby source', 5, nil)
+      Coverband::Utils::SourceFile::Line.new("# the ruby source", 5, nil)
     end
 
-    it 'has nil coverage' do
+    it "has nil coverage" do
       assert_nil subject.coverage
     end
 
-    it 'is not covered' do
+    it "is not covered" do
       refute subject.covered?
     end
 
-    it 'is not skipped' do
+    it "is not skipped" do
       refute subject.skipped?
     end
 
-    it 'is not missed' do
+    it "is not missed" do
       refute subject.missed?
     end
 
-    it 'is never' do
+    it "is never" do
       assert subject.never?
     end
 
-    it 'status is never' do
-      assert_equal 'never', subject.status
+    it "status is never" do
+      assert_equal "never", subject.status
     end
   end
 
-  it 'raises ArgumentError when initialized with invalid src' do
+  it "raises ArgumentError when initialized with invalid src" do
     assert_raises ArgumentError do
       Coverband::Utils::SourceFile::Line.new(:symbol, 5, 3)
     end
   end
 
-  it 'raises ArgumentError when initialized with invalid line_number' do
+  it "raises ArgumentError when initialized with invalid line_number" do
     assert_raises ArgumentError do
-      Coverband::Utils::SourceFile::Line.new('some source', 'five', 3)
+      Coverband::Utils::SourceFile::Line.new("some source", "five", 3)
     end
   end
 
-  it 'raises ArgumentError when initialized with invalid coverage' do
+  it "raises ArgumentError when initialized with invalid coverage" do
     assert_raises ArgumentError do
-      Coverband::Utils::SourceFile::Line.new('some source', 5, 'three')
+      Coverband::Utils::SourceFile::Line.new("some source", 5, "three")
     end
   end
 end

data/test/coverband/utils/source_file_test.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper', File.dirname(__FILE__))
+require File.expand_path("../../test_helper", File.dirname(__FILE__))
 
 ####
 # Thanks for all the help SimpleCov https://github.com/colszowka/simplecov-html
@@ -8,32 +8,32 @@ require File.expand_path('../../test_helper', File.dirname(__FILE__))
 ####
 describe Coverband::Utils::SourceFile do
   COVERAGE_FOR_SAMPLE_RB = [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil, nil, nil, nil, nil, nil, nil].freeze
-  describe 'a source file initialized with some coverage data' do
+  describe "a source file initialized with some coverage data" do
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('sample.rb'), COVERAGE_FOR_SAMPLE_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB)
     end
 
-    it 'has a filename' do
+    it "has a filename" do
       assert subject.filename
     end
 
-    it 'has source equal to src' do
+    it "has source equal to src" do
       assert_equal subject.source, subject.src
     end
 
-    it 'has a project filename which removes the project directory' do
-      assert_equal '/test/fixtures/sample.rb', subject.project_filename
+    it "has a project filename which removes the project directory" do
+      assert_equal "/test/fixtures/sample.rb", subject.project_filename
     end
 
-    it 'has source_lines equal to lines' do
+    it "has source_lines equal to lines" do
       assert_equal subject.source_lines, subject.lines
     end
 
-    it 'has 16 source lines' do
+    it "has 16 source lines" do
       assert_equal 16, subject.lines.count
     end
 
-    it 'has all source lines of type Coverband::Utils::SourceFile::Line' do
+    it "has all source lines of type Coverband::Utils::SourceFile::Line" do
       subject.lines.each do |line|
         assert line.is_a?(Coverband::Utils::SourceFile::Line)
       end
@@ -43,161 +43,111 @@ describe Coverband::Utils::SourceFile do
       assert_equal "class Foo\n", subject.line(2).source
     end
 
-    it 'returns lines number 2, 3, 4, 7 for covered_lines' do
+    it "returns lines number 2, 3, 4, 7 for covered_lines" do
       assert_equal [2, 3, 4, 7], subject.covered_lines.map(&:line)
     end
 
-    it 'returns lines number 8 for missed_lines' do
+    it "returns lines number 8 for missed_lines" do
       assert_equal [8], subject.missed_lines.map(&:line)
     end
 
-    it 'returns lines number 1, 5, 6, 9, 10, 16 for never_lines' do
+    it "returns lines number 1, 5, 6, 9, 10, 16 for never_lines" do
       assert_equal [1, 5, 6, 9, 10, 16], subject.never_lines.map(&:line)
     end
 
-    it 'returns line numbers 11, 12, 13, 14, 15 for skipped_lines' do
+    it "returns line numbers 11, 12, 13, 14, 15 for skipped_lines" do
       assert_equal [11, 12, 13, 14, 15], subject.skipped_lines.map(&:line)
     end
 
-    it 'has 80% covered_percent' do
+    it "has 80% covered_percent" do
       assert_equal 80.0, subject.covered_percent
     end
 
-    it 'working for nil last_updated_at' do
+    it "working for nil last_updated_at" do
       assert_equal "not available", subject.last_updated_at
     end
   end
 
-  describe 'simulating potential Ruby 1.9 defect -- see Issue #56' do
+  describe "simulating potential Ruby 1.9 defect -- see Issue #56" do
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('sample.rb'), COVERAGE_FOR_SAMPLE_RB + [nil])
+      Coverband::Utils::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB + [nil])
     end
 
-    it 'has 16 source lines regardless of extra data in coverage array' do
+    it "has 16 source lines regardless of extra data in coverage array" do
       # Do not litter test output with known warning
       capture_stderr { assert_equal 16, subject.lines.count }
     end
 
-    it 'prints a warning to stderr if coverage array contains more data than lines in the file' do
-      captured_output = capture_stderr do
+    it "prints a warning to stderr if coverage array contains more data than lines in the file" do
+      captured_output = capture_stderr {
         subject.lines
-      end
+      }
 
       assert(captured_output.match(/^Warning: coverage data/))
     end
   end
 
-  describe 'a file that is never relevant' do
+  describe "a file that is never relevant" do
     COVERAGE_FOR_NEVER_RB = [nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('never.rb'), COVERAGE_FOR_NEVER_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("never.rb"), COVERAGE_FOR_NEVER_RB)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 100.0, subject.covered_percent
     end
   end
 
-  describe 'a file where nothing is ever executed mixed with skipping #563' do
+  describe "a file where nothing is ever executed mixed with skipping #563" do
     COVERAGE_FOR_SKIPPED_RB = [nil, nil, nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('skipped.rb'), COVERAGE_FOR_SKIPPED_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 0.0, subject.covered_percent
     end
   end
 
-  describe 'a file where everything is skipped and missed #563' do
+  describe "a file where everything is skipped and missed #563" do
     COVERAGE_FOR_SKIPPED_RB_2 = [nil, nil, 0, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('skipped.rb'), COVERAGE_FOR_SKIPPED_RB_2)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped.rb"), COVERAGE_FOR_SKIPPED_RB_2)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 0.0, subject.covered_percent
     end
   end
 
-  describe 'a file where everything is skipped/irrelevamt but executed #563' do
+  describe "a file where everything is skipped/irrelevamt but executed #563" do
     COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, nil, nil, nil].freeze
 
     subject do
-      Coverband::Utils::SourceFile.new(source_fixture('skipped_and_executed.rb'), COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
+      Coverband::Utils::SourceFile.new(source_fixture("skipped_and_executed.rb"), COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
     end
 
-    it 'has 0.0 covered_strength' do
+    it "has 0.0 covered_strength" do
       assert_equal 0.0, subject.covered_strength
     end
 
-    it 'has 0.0 covered_percent' do
+    it "has 0.0 covered_percent" do
       assert_equal 0.0, subject.covered_percent
     end
   end
-
-  describe 'correctly identifies gems' do
-    COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, 1, 1, nil].freeze
-
-    describe 'the word gem in a path' do
-      subject do
-        Coverband::Utils::SourceFile.new('lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert_equal nil, subject.gem?
-      end
-    end
-
-    describe 'a folder gem in the path' do
-      subject do
-        Coverband::Utils::SourceFile.new('/var/gems/rubocop-0.67.0/lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert subject.gem?
-      end
-    end
-  end
-
-  describe 'correctly reports gem name' do
-    COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB = [nil, nil, 1, 1, 0, 1, 1, nil].freeze
-
-    describe 'the word gem in a path' do
-      subject do
-        Coverband::Utils::SourceFile.new('lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert_equal nil, subject.gem_name
-      end
-    end
-
-    describe 'a folder gem in the path' do
-      subject do
-        Coverband::Utils::SourceFile.new('/var/gems/rubocop-0.67.0/lib/rubocop/cop/gemspec/required_ruby_version.rb', COVERAGE_FOR_SKIPPED_AND_EXECUTED_RB)
-      end
-
-      it 'allows the word gem in path' do
-        assert_equal 'rubocop-0.67.0', subject.gem_name
-      end
-    end
-  end
-
-
 end