coveralls_reborn 0.9.0 → 0.10.0

data/spec/coveralls/coveralls_spec.rb

@@ -1,106 +1,101 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Coveralls do
   before do
-    SimpleCov.stub(:start)
+    allow(SimpleCov).to receive(:start)
     stub_api_post
-    Coveralls.testing = true
+    described_class.testing = true
   end
 
-  describe "#will_run?" do
-    it "checks CI environemnt variables" do
-      Coveralls.will_run?.should be_truthy
+  describe '#will_run?' do
+    it 'checks CI environemnt variables' do
+      expect(described_class).to be_will_run
     end
 
-    context "with CI disabled" do
+    context 'with CI disabled' do
       before do
-        @ci = ENV['CI']
-        ENV['CI'] = nil
-        @coveralls_run_locally = ENV['COVERALLS_RUN_LOCALLY']
-        ENV['COVERALLS_RUN_LOCALLY'] = nil
-
-        Coveralls.testing = false
+        allow(ENV).to receive(:[])
+        allow(ENV).to receive(:[]).with('COVERALLS_RUN_LOCALLY').and_return(nil)
+        allow(ENV).to receive(:[]).with('CI').and_return(nil)
+        described_class.testing = false
       end
 
-      after do
-        ENV['CI'] = @ci
-        ENV['COVERALLS_RUN_LOCALLY'] = @coveralls_run_locally
-      end
-
-      it "indicates no run" do
-        Coveralls.will_run?.should be_falsy
+      it 'indicates no run' do
+        expect(described_class).not_to be_will_run
       end
     end
   end
 
-  describe "#should_run?" do
-    it "outputs to stdout when running locally" do
-      Coveralls.testing = false
-      Coveralls.run_locally = true
+  describe '#should_run?' do
+    it 'outputs to stdout when running locally' do
+      described_class.testing = false
+      described_class.run_locally = true
       silence do
-        Coveralls.should_run?
+        described_class.should_run?
       end
     end
   end
 
-  describe "#wear!" do
-    it "receives block" do
-      ::SimpleCov.should_receive(:start)
+  describe '#wear!' do
+    it 'receives block' do
       silence do
         subject.wear! do
           add_filter 's'
         end
       end
+
+      expect(::SimpleCov).to have_received(:start)
     end
 
-    it "uses string" do
-      ::SimpleCov.should_receive(:start).with 'test_frameworks'
+    it 'uses string' do
       silence do
         subject.wear! 'test_frameworks'
       end
+
+      expect(::SimpleCov).to have_received(:start).with 'test_frameworks'
     end
 
-    it "uses default" do
-      ::SimpleCov.should_receive(:start).with no_args
+    it 'uses default' do
       silence do
         subject.wear!
       end
-      ::SimpleCov.filters.map(&:filter_argument).should include 'vendor'
+
+      expect(::SimpleCov).to have_received(:start).with no_args
+      expect(::SimpleCov.filters.map(&:filter_argument)).to include 'vendor'
     end
   end
 
-  describe "#wear_merged!" do
-    it "sets formatter to NilFormatter" do
-      ::SimpleCov.should_receive(:start).with 'rails'
+  describe '#wear_merged!' do
+    it 'sets formatter to NilFormatter' do
       silence do
         subject.wear_merged! 'rails' do
-          add_filter "/spec/"
+          add_filter '/spec/'
         end
       end
-      ::SimpleCov.formatter.should be Coveralls::NilFormatter
+
+      expect(::SimpleCov).to have_received(:start).with 'rails'
+      expect(::SimpleCov.formatter).to be Coveralls::NilFormatter
     end
   end
 
-  describe "#push!" do
-    it "sends existing test results" do
+  describe '#push!' do
+    it 'sends existing test results' do
       result = false
       silence do
         result = subject.push!
       end
-      result.should be_truthy
+      expect(result).to be_truthy
     end
   end
 
-  describe "#setup!" do
-    it "sets SimpleCov adapter" do
+  describe '#setup!' do
+    it 'sets SimpleCov adapter' do
       SimpleCovTmp = SimpleCov
       Object.send :remove_const, :SimpleCov
       silence { subject.setup! }
       SimpleCov = SimpleCovTmp
     end
   end
-
-  after(:all) do
-    setup_formatter
-  end
 end

data/spec/coveralls/fixtures/app/controllers/sample.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Foo class
 class Foo
   def initialize

data/spec/coveralls/fixtures/app/models/airplane.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 # Foo class
 class Foo
   def initialize
     @foo = 'baz'
   end
-  
+
   def bar
     @foo
   end
-end
+end

data/spec/coveralls/output_spec.rb

@@ -1,91 +1,78 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Coveralls::Output do
-  it "defaults the IO to $stdout" do
-    old_stdout = $stdout
-    out = StringIO.new
-    $stdout = out
-    Coveralls::Output.puts "this is a test"
-    expect(out.string).to eq "this is a test\n"
-    $stdout = old_stdout
+  it 'defaults the IO to $stdout' do
+    expect { described_class.puts 'this is a test' }.to output("this is a test\n").to_stdout
   end
 
-  it "accepts an IO injection" do
+  it 'accepts an IO injection' do
     out = StringIO.new
-    Coveralls::Output.output = out
-    Coveralls::Output.puts "this is a test"
+    allow(described_class).to receive(:output).and_return(out)
+    described_class.puts 'this is a test'
     expect(out.string).to eq "this is a test\n"
   end
 
-  describe ".puts" do
-    it "accepts an IO injection" do
+  describe '.puts' do
+    it 'accepts an IO injection' do
       out = StringIO.new
-      Coveralls::Output.puts "this is a test", output: out
+      described_class.puts 'this is a test', output: out
       expect(out.string).to eq "this is a test\n"
     end
   end
 
-  describe ".print" do
-    it "accepts an IO injection" do
+  describe '.print' do
+    it 'accepts an IO injection' do
       out = StringIO.new
-      Coveralls::Output.print "this is a test", output: out
-      expect(out.string).to eq "this is a test"
+      described_class.print 'this is a test', output: out
+      expect(out.string).to eq 'this is a test'
     end
   end
 
   describe 'when silenced' do
-    before do
-      @original_stdout = $stdout
-      @output = StringIO.new
-      Coveralls::Output.silent = true
-      $stdout = @output
-    end
-    it "should not puts" do
-      Coveralls::Output.puts "foo"
-      @output.rewind
-      @output.read.should == ""
-    end
-    it "should not print" do
-      Coveralls::Output.print "foo"
-      @output.rewind
-      @output.read.should == ""
+    before { described_class.silent = true }
+
+    it 'does not puts' do
+      expect { described_class.puts 'foo' }.not_to output("foo\n").to_stdout
     end
-    after do
-      $stdout = @original_stdout
+
+    it 'does not print' do
+      expect { described_class.print 'foo' }.not_to output('foo').to_stdout
     end
   end
 
   describe '.format' do
-    it "accepts a color argument" do
+    it 'accepts a color argument' do
       require 'term/ansicolor'
       string = 'Hello'
-      ansi_color_string =  Term::ANSIColor.red(string)
-      Coveralls::Output.format(string, color: 'red').should eq(ansi_color_string)
+      ansi_color_string = Term::ANSIColor.red(string)
+      expect(described_class.format(string, color: 'red')).to eq(ansi_color_string)
     end
 
-    it "also accepts no color arguments" do
-      unformatted_string = "Hi Doggie!"
-      Coveralls::Output.format(unformatted_string).should eq(unformatted_string)
+    it 'also accepts no color arguments' do
+      unformatted_string = 'Hi Doggie!'
+      expect(described_class.format(unformatted_string)).to eq(unformatted_string)
     end
 
-    it "rejects formats unrecognized by Term::ANSIColor" do
+    it 'rejects formats unrecognized by Term::ANSIColor' do
       string = 'Hi dog!'
-      Coveralls::Output.format(string, color: "not_a_real_color").should eq(string)
+      expect(described_class.format(string, color: 'not_a_real_color')).to eq(string)
     end
 
-    it "accepts more than 1 color argument" do
+    it 'accepts more than 1 color argument' do
       string = 'Hi dog!'
-      multi_formatted_string = Term::ANSIColor.red{ Term::ANSIColor.underline(string) }
-      Coveralls::Output.format(string, color: 'red underline').should eq(multi_formatted_string)
+      multi_formatted_string = Term::ANSIColor.red { Term::ANSIColor.underline(string) }
+      expect(described_class.format(string, color: 'red underline')).to eq(multi_formatted_string)
     end
 
-    context "no color" do
-      before { Coveralls::Output.no_color = true }
+    context 'without color' do
+      before { described_class.no_color = true }
 
-      it "does not add color to string" do
-        unformatted_string = "Hi Doggie!"
-        Coveralls::Output.format(unformatted_string, color: 'red').
-          should eq(unformatted_string)
+      it 'does not add color to string' do
+        unformatted_string = 'Hi Doggie!'
+        expect(described_class.format(unformatted_string, color: 'red'))
+          .to eq(unformatted_string)
       end
     end
   end

data/spec/coveralls/simple_cov/formatter_spec.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Coveralls::SimpleCov::Formatter do
+  before do
+    stub_api_post
+  end
+
+  def source_fixture(filename)
+    File.expand_path(File.join(File.dirname(__FILE__), '..', 'fixtures', filename))
+  end
+
+  let(:result) do
+    SimpleCov::Result.new(source_fixture('app/controllers/sample.rb') => [nil, 1, 1, 1, nil, 0, 1, 1, nil, nil],
+                          source_fixture('app/models/airplane.rb')    => [0, 0, 0, 0, 0],
+                          source_fixture('app/models/dog.rb')         => [1, 1, 1, 1, 1],
+                          source_fixture('app/models/house.rb')       => [nil, nil, nil, nil, nil, nil, nil, nil, nil, nil],
+                          source_fixture('app/models/robot.rb')       => [1, 1, 1, 1, nil, nil, 1, 0, nil, nil],
+                          source_fixture('app/models/user.rb')        => [nil, 1, 1, 1, 1, 0, 1, 0, nil, nil],
+                          source_fixture('sample.rb')                 => [nil, 1, 1, 1, nil, 0, 1, 1, nil, nil])
+  end
+
+  describe '#format' do
+    context 'when should run' do
+      before do
+        Coveralls.testing = true
+        Coveralls.noisy = false
+      end
+
+      it 'posts json' do
+        expect(result.files).not_to be_empty
+        silence do
+          expect(described_class.new.format(result)).to be_truthy
+        end
+      end
+    end
+
+    context 'when should not run, noisy' do
+      it 'only displays result' do
+        silence do
+          expect(described_class.new.display_result(result)).to be_truthy
+        end
+      end
+    end
+
+    context 'without files' do
+      let(:result) { SimpleCov::Result.new({}) }
+
+      it 'shows note that no files have been covered' do
+        Coveralls.noisy = true
+        Coveralls.testing = false
+
+        silence do
+          expect do
+            described_class.new.format(result)
+          end.not_to raise_error
+        end
+      end
+    end
+
+    context 'with api error' do
+      it 'rescues' do
+        e = SocketError.new
+
+        silence do
+          expect(described_class.new.display_error(e)).to be_falsy
+        end
+      end
+    end
+
+    describe '#get_source_files' do
+      let(:source_files) { described_class.new.get_source_files(result) }
+
+      it 'nils the skipped lines' do
+        source_file = source_files.first
+        expect(source_file[:coverage]).not_to eq result.files.first.coverage
+        expect(source_file[:coverage]).to eq [nil, 1, 1, 1, nil, 0, 1, 1, nil, nil, nil, nil, nil]
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 require 'webmock'
 require 'vcr'
@@ -12,15 +14,15 @@ end
 
 def setup_formatter
   SimpleCov.formatter = if ENV['TRAVIS'] || ENV['COVERALLS_REPO_TOKEN']
-    InceptionFormatter
-  else
-    SimpleCov::Formatter::HTMLFormatter
-  end
+                          InceptionFormatter
+                        else
+                          SimpleCov::Formatter::HTMLFormatter
+                        end
 
   # SimpleCov.start 'test_frameworks'
   SimpleCov.start do
     add_filter do |source_file|
-      source_file.filename =~ /spec/ && !(source_file.filename =~ /fixture/)
+      source_file.filename =~ /spec/ && source_file.filename !~ /fixture/
     end
   end
 end
@@ -38,26 +40,21 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.include WebMock::API
-  config.expect_with :rspec do |c|
-    c.syntax = [:should, :expect]
-  end
-  config.mock_with :rspec do |c|
-    c.syntax = [:should, :expect]
-  end
   config.after(:suite) do
+    setup_formatter
     WebMock.disable!
   end
 end
 
 def stub_api_post
-  body = "{\"message\":\"\",\"url\":\"\"}"
-  stub_request(:post, Coveralls::API::API_BASE+"/jobs").with(
+  body = '{"message":"","url":""}'
+  stub_request(:post, Coveralls::API::API_BASE + '/jobs').with(
     headers: {
-      'Accept'=>'*/*; q=0.5, application/xml',
-      'Accept-Encoding'=>'gzip, deflate',
-      'Content-Length'=>/.+/,
-      'Content-Type'=>/.+/,
-      'User-Agent'=>'Ruby'
+      'Accept' => '*/*; q=0.5, application/xml',
+      'Accept-Encoding' => 'gzip, deflate',
+      'Content-Length' => /.+/,
+      'Content-Type' => /.+/,
+      'User-Agent' => 'Ruby'
     }
   ).to_return(status: 200, body: body, headers: {})
 end

metadata

@@ -1,14 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: coveralls_reborn
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
+- Nick Merwin
+- Wil Gieseler
 - Geremia Taglialatela
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-31 00:00:00.000000000 Z
+date: 2017-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -39,63 +41,65 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.15.1
 - !ruby/object:Gem::Dependency
-  name: tins
+  name: term-ansicolor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: term-ansicolor
+  name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 0.20.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 0.20.0
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: tins
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.0
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.0
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '1.16'
 description: A Ruby implementation of the Coveralls API.
 email:
+- nick@lemurheavy.com
+- supapuerco@gmail.com
 - tagliala.dev@gmail.com
 executables:
 - coveralls
@@ -104,6 +108,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
@@ -132,7 +137,7 @@ files:
 - spec/coveralls/fixtures/app/vendor/vendored_gem.rb
 - spec/coveralls/fixtures/sample.rb
 - spec/coveralls/output_spec.rb
-- spec/coveralls/simplecov_spec.rb
+- spec/coveralls/simple_cov/formatter_spec.rb
 - spec/spec_helper.rb
 homepage: https://coveralls.io
 licenses:
@@ -146,7 +151,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -170,5 +175,5 @@ test_files:
 - spec/coveralls/fixtures/app/vendor/vendored_gem.rb
 - spec/coveralls/fixtures/sample.rb
 - spec/coveralls/output_spec.rb
-- spec/coveralls/simplecov_spec.rb
+- spec/coveralls/simple_cov/formatter_spec.rb
 - spec/spec_helper.rb

data/spec/coveralls/simplecov_spec.rb

@@ -1,82 +0,0 @@
-require 'spec_helper'
-
-describe Coveralls::SimpleCov::Formatter do
-
-  before do
-    stub_api_post
-  end
-
-  def source_fixture(filename)
-    File.expand_path( File.join( File.dirname( __FILE__ ), 'fixtures', filename ) )
-  end
-
-  let(:result) {
-
-    SimpleCov::Result.new({
-      source_fixture( 'sample.rb' )                  => [nil, 1, 1, 1, nil, 0, 1, 1, nil, nil],
-      source_fixture( 'app/models/user.rb' )         => [nil, 1, 1, 1, 1, 0, 1, 0, nil, nil],
-      source_fixture( 'app/models/robot.rb' )        => [1, 1, 1, 1, nil, nil, 1, 0, nil, nil],
-      source_fixture( 'app/models/house.rb' )        => [nil, nil, nil, nil, nil, nil, nil, nil, nil, nil],
-      source_fixture( 'app/models/airplane.rb' )     => [0, 0, 0, 0, 0],
-      source_fixture( 'app/models/dog.rb' )          => [1, 1, 1, 1, 1],
-      source_fixture( 'app/controllers/sample.rb' )  => [nil, 1, 1, 1, nil, 0, 1, 1, nil, nil]
-    })
-  }
-
-  describe "#format" do
-    context "should run" do
-      before do
-        Coveralls.testing = true
-        Coveralls.noisy = false
-      end
-
-      it "posts json" do
-        result.files.should_not be_empty
-        silence do
-          Coveralls::SimpleCov::Formatter.new.format(result).should be_truthy
-        end
-      end
-    end
-
-    context "should not run, noisy" do
-      it "only displays result" do
-        silence do
-          Coveralls::SimpleCov::Formatter.new.display_result(result).should be_truthy
-        end
-      end
-    end
-
-    context "no files" do
-      let(:result) { SimpleCov::Result.new({}) }
-      it "shows note that no files have been covered" do
-        Coveralls.noisy = true
-        Coveralls.testing = false
-
-        silence do
-          expect do
-            Coveralls::SimpleCov::Formatter.new.format(result)
-          end.not_to raise_error
-        end
-      end
-    end
-
-    context "with api error" do
-      it "rescues" do
-        e = SocketError.new
-
-        silence do
-          Coveralls::SimpleCov::Formatter.new.display_error(e).should be_falsy
-        end
-      end
-    end
-
-    context "#get_source_files" do
-      let(:source_files) { Coveralls::SimpleCov::Formatter.new.get_source_files(result) }
-      it "nils the skipped lines" do
-        source_file = source_files.first
-        source_file[:coverage].should_not eq result.files.first.coverage
-        source_file[:coverage].should eq [nil, 1, 1, 1, nil, 0, nil, nil, nil, nil, nil]
-      end
-    end
-  end
-end