coveralls_reborn 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e8a2382688150917f88dd65c6dbfe10bc8493d96
-  data.tar.gz: cac2d0782c26a3c024a4669348a1ac7f349fa1a5
+  metadata.gz: f4cd807256f3b2424a9ebd737660d179e8bb448f
+  data.tar.gz: 1c83b8e8be4f2d03bf62c26996ff34c52c0f3be2
 SHA512:
-  metadata.gz: 2153cfea1a78341b8a885372824eb86a3c4c65b651a99bed8c32d70c23dbe6d1dc50eac20cfabdb77190aa4016a652eb2b316a016c965503c4d3e6516bd00227
-  data.tar.gz: 978e7712cc5f2979bdd9b75424fc18326fc7693b5ea50b0863acf1e5bd672994df24cf0e732a312d68bc4dbd9e75e78a1ce28fbd691111cc4b8a455e0f919cc3
+  metadata.gz: ffd14ccfc5339a43af2951d40be456a27b2d3d805406cd8fe5519a23eea58e6324c5c6ce5b8c5f8ea5ab626d139d3081a6a8efd14b4b62b870299237fad9e13a
+  data.tar.gz: 359db8935442a61cb3d676d73a59ac9be7a5f2647ca238b80daa824d84012485253564274a550d80e7099539538e70f2d43e86bdea61b1458a61aeaa6797f3e0

data/.rubocop.yml

@@ -0,0 +1,59 @@
+require: rubocop-rspec
+
+AllCops:
+  DisplayCopNames: true
+  TargetRubyVersion: 2.1
+  Exclude:
+    - 'spec/coveralls/fixtures/**/*'
+    - 'vendor/bundle/**/*'
+
+Lint/HandleExceptions:
+  Enabled: false
+
+Metrics/AbcSize:
+  Max: 37
+
+Metrics/CyclomaticComplexity:
+  Max: 18
+
+Metrics/PerceivedComplexity:
+  Max: 19
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Exclude:
+    - 'lib/coveralls/configuration.rb'
+    - 'spec/**/*'
+
+Naming/AccessorMethodName:
+  Exclude:
+    - 'lib/coveralls/configuration.rb'
+
+RSpec/ExampleLength:
+  Max: 8
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 4
+
+Style/Documentation:
+  Enabled: false
+
+# TODO: Remove when targeting Ruby 2.3 because it is already enabled.
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always

data/.travis.yml

@@ -7,18 +7,23 @@ sudo: false
 before_install:
   - gem update bundler
 
+env:
+  global:
+    # --dev improves JRuby startup time
+    # --debug reports proper coverage to SimpleCov
+    # See https://github.com/jruby/jruby/wiki/Improving-startup-time
+    - JRUBY_OPTS="--dev --debug"
+
 rvm:
-  - 1.9.3
-  - 2.0.0
   - 2.1.10
   - 2.2.8
   - 2.3.5
   - 2.4.2
   - ruby-head
-  - jruby
+  - jruby-9.1.13.0
 
 matrix:
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby
+    - rvm: jruby-9.1.13.0
   fast_finish: true

data/Gemfile

@@ -1,29 +1,30 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in coveralls-ruby.gemspec
 gemspec
 
-gem 'rake', '~> 12.0'
-gem 'rspec', '~> 3.6'
-gem 'simplecov', require: false
-gem 'truthy', '~> 1.0'
-gem 'vcr', '~> 3.0'
-gem 'webmock', Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.0') ? '~> 2.3' : '~> 3.0'
-
-platforms :ruby_19 do
-  gem 'term-ansicolor', '~> 1.3.0'
-  gem 'tins', '~> 1.6.0'
+platforms :jruby do
+  gem 'jruby-openssl', '~> 0.9.21'
 end
 
-platforms :jruby do
-  gem 'jruby-openssl'
+platforms :rbx do
+  gem 'rubinius-developer_tools', '~> 2.0'
+  gem 'rubysl', '~> 2.2'
 end
 
-platform :rbx do
-  gem 'rubysl', '~> 2.0'
-  gem 'rubinius-developer_tools'
+group :development do
+  gem 'rake', '~> 12.2'
+  gem 'rspec', '~> 3.7'
+  gem 'rubocop', '~> 0.51.0'
+  gem 'rubocop-rspec', '~> 1.20'
+  gem 'simplecov', '~> 0.15.1', require: false
+  gem 'truthy', '~> 1.0'
+  gem 'vcr', '~> 3.0'
+  gem 'webmock', '~> 3.1'
 end
 
 group :test do
-  gem 'pry'
+  gem 'pry', '~> 0.11.3'
 end

data/LICENSE

@@ -1,22 +1,21 @@
-Copyright (c) 2012 Wil Gieseler
-
 MIT License
 
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
+Copyright (c) 2017 Wil Gieseler
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -1,5 +1,11 @@
-# [Coveralls Reborn](http://coveralls.io) for Ruby [![Test Coverage](https://coveralls.io/repos/tagliala/coveralls-ruby-reborn/badge.svg?branch=master)](https://coveralls.io/r/tagliala/coveralls-ruby-reborn) [![Build Status](https://secure.travis-ci.org/tagliala/coveralls-ruby-reborn.svg?branch=master)](https://travis-ci.org/tagliala/coveralls-ruby-reborn) [![Gem Version](https://badge.fury.io/rb/coveralls.svg)](http://badge.fury.io/rb/coveralls)
+# [Coveralls Reborn](http://coveralls.io) for Ruby [![Test Coverage](https://coveralls.io/repos/tagliala/coveralls-ruby-reborn/badge.svg?branch=master)](https://coveralls.io/r/tagliala/coveralls-ruby-reborn) [![Build Status](https://secure.travis-ci.org/tagliala/coveralls-ruby-reborn.svg?branch=master)](https://travis-ci.org/tagliala/coveralls-ruby-reborn) [![Gem Version](https://badge.fury.io/rb/coveralls_reborn.svg)](http://badge.fury.io/rb/coveralls_reborn) [![Dependency Status](https://gemnasium.com/badges/github.com/tagliala/coveralls-ruby-reborn.svg)](https://gemnasium.com/github.com/tagliala/coveralls-ruby-reborn)
 
 ### [Read the docs →](https://coveralls.zendesk.com/hc/en-us/articles/201769485-Ruby-Rails)
 
 An up-to-date fork of [lemurheavy/coveralls-ruby](https://github.com/lemurheavy/coveralls-ruby)
+
+Add to your `Gemfile`:
+
+```rb
+gem 'coveralls_reborn', '~> 0.10.0', require: false
+```

data/Rakefile

@@ -1,14 +1,20 @@
 #!/usr/bin/env rake
-require "bundler/gem_tasks"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
 
 # Travis!
 require 'rubygems'
 require 'rake'
 require 'rspec/core/rake_task'
 
-desc "Run RSpec"
+require 'rubocop/rake_task'
+
+RuboCop::RakeTask.new
+
+desc 'Run RSpec'
 RSpec::Core::RakeTask.new do |t|
   t.verbose = false
 end
 
-task default: :spec
+task default: %i[rubocop spec]

data/bin/coveralls

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 lib = File.expand_path(File.dirname(__FILE__) + '/../lib')
 $LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
@@ -6,4 +7,4 @@ $LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
 require 'coveralls'
 require 'coveralls/command'
 
-Coveralls::CommandLine.start
+Coveralls::CommandLine.start

data/coveralls-ruby.gemspec

@@ -1,29 +1,31 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'coveralls/version'
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Geremia Taglialatela"]
-  gem.email         = ["tagliala.dev@gmail.com"]
-  gem.description   = "A Ruby implementation of the Coveralls API."
-  gem.summary       = "A Ruby implementation of the Coveralls API."
-  gem.homepage      = "https://coveralls.io"
-  gem.license       = "MIT"
+  gem.authors       = ['Nick Merwin', 'Wil Gieseler', 'Geremia Taglialatela']
+  gem.email         = ['nick@lemurheavy.com', 'supapuerco@gmail.com', 'tagliala.dev@gmail.com']
+  gem.description   = 'A Ruby implementation of the Coveralls API.'
+  gem.summary       = 'A Ruby implementation of the Coveralls API.'
+  gem.homepage      = 'https://coveralls.io'
+  gem.license       = 'MIT'
 
-  gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.files         = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name          = "coveralls_reborn"
-  gem.require_paths = ["lib"]
+  gem.name          = 'coveralls_reborn'
+  gem.require_paths = ['lib']
   gem.version       = Coveralls::VERSION
 
-  gem.required_ruby_version = '>= 1.9.3'
+  gem.required_ruby_version = '>= 2.1'
 
   gem.add_dependency 'json', '~> 2.1'
   gem.add_dependency 'simplecov', '~> 0.15.1'
-  gem.add_dependency 'tins', '~> 1.6'
   gem.add_dependency 'term-ansicolor', '~> 1.3'
   gem.add_dependency 'thor', '~> 0.20.0'
+  gem.add_dependency 'tins', '~> 1.6'
 
-  gem.add_development_dependency 'bundler', '~> 1.15'
+  gem.add_development_dependency 'bundler', '~> 1.16'
 end

data/lib/coveralls/api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'net/https'
 require 'tempfile'
@@ -8,121 +10,123 @@ module Coveralls
       API_HOST = ENV['COVERALLS_ENDPOINT']
       API_DOMAIN = ENV['COVERALLS_ENDPOINT']
     else
-      API_HOST = ENV['COVERALLS_DEVELOPMENT'] ? "localhost:3000" : "coveralls.io"
-      API_PROTOCOL = ENV['COVERALLS_DEVELOPMENT'] ? "http" : "https"
-      API_DOMAIN = "#{API_PROTOCOL}://#{API_HOST}"
+      API_HOST = ENV['COVERALLS_DEVELOPMENT'] ? 'localhost:3000' : 'coveralls.io'
+      API_PROTOCOL = ENV['COVERALLS_DEVELOPMENT'] ? 'http' : 'https'
+      API_DOMAIN = "#{API_PROTOCOL}://#{API_HOST}".freeze
     end
 
-    API_BASE = "#{API_DOMAIN}/api/v1"
+    API_BASE = "#{API_DOMAIN}/api/v1".freeze
 
     def self.post_json(endpoint, hash)
       disable_net_blockers!
 
       uri = endpoint_to_uri(endpoint)
 
-      Coveralls::Output.puts("#{ JSON.pretty_generate(hash) }", color: "green") if ENV['COVERALLS_DEBUG']
-      Coveralls::Output.puts("[Coveralls] Submitting to #{API_BASE}", color: "cyan")
+      Coveralls::Output.puts(JSON.pretty_generate(hash).to_s, color: 'green') if ENV['COVERALLS_DEBUG']
+      Coveralls::Output.puts("[Coveralls] Submitting to #{API_BASE}", color: 'cyan')
 
       client  = build_client(uri)
       request = build_request(uri.path, hash)
 
       response = client.request(request)
 
-      response_hash = JSON.load(response.body.to_str)
+      response_hash = JSON.parse(response.body.to_str)
 
       if response_hash['message']
-        Coveralls::Output.puts("[Coveralls] #{ response_hash['message'] }", color: "cyan")
+        Coveralls::Output.puts("[Coveralls] #{response_hash['message']}", color: 'cyan')
       end
 
       if response_hash['url']
-        Coveralls::Output.puts("[Coveralls] #{ Coveralls::Output.format(response_hash['url'], color: "underline") }", color: "cyan")
+        Coveralls::Output.puts("[Coveralls] #{Coveralls::Output.format(response_hash['url'], color: 'underline')}", color: 'cyan')
       end
 
       case response
       when Net::HTTPServiceUnavailable
-        Coveralls::Output.puts("[Coveralls] API timeout occured, but data should still be processed", color: "red")
+        Coveralls::Output.puts('[Coveralls] API timeout occured, but data should still be processed', color: 'red')
       when Net::HTTPInternalServerError
-        Coveralls::Output.puts("[Coveralls] API internal error occured, we're on it!", color: "red")
+        Coveralls::Output.puts("[Coveralls] API internal error occured, we're on it!", color: 'red')
       end
     end
 
-    private
+    class << self
+      private
 
-    def self.disable_net_blockers!
-      begin
-        require 'webmock'
+      def disable_net_blockers!
+        begin
+          require 'webmock'
 
-        allow = WebMock::Config.instance.allow || []
-        WebMock::Config.instance.allow = [*allow].push API_HOST
-      rescue LoadError
-      end
+          allow = WebMock::Config.instance.allow || []
+          WebMock::Config.instance.allow = [*allow].push API_HOST
+        rescue LoadError
+        end
 
-      begin
-        require 'vcr'
+        begin
+          require 'vcr'
 
-        VCR.send(VCR.version.major < 2 ? :config : :configure) do |c|
-          c.ignore_hosts API_HOST
+          VCR.send(VCR.version.major < 2 ? :config : :configure) do |c|
+            c.ignore_hosts API_HOST
+          end
+        rescue LoadError
         end
-      rescue LoadError
       end
-    end
 
-    def self.endpoint_to_uri(endpoint)
-      URI.parse("#{API_BASE}/#{endpoint}")
-    end
+      def endpoint_to_uri(endpoint)
+        URI.parse("#{API_BASE}/#{endpoint}")
+      end
 
-    def self.build_client(uri)
-      client = Net::HTTP.new(uri.host, uri.port)
-      client.use_ssl = true if uri.port == 443
-      client.verify_mode = OpenSSL::SSL::VERIFY_NONE
+      def build_client(uri)
+        client = Net::HTTP.new(uri.host, uri.port)
+        client.use_ssl = true if uri.port == 443
+        client.verify_mode = OpenSSL::SSL::VERIFY_NONE
 
-      unless client.respond_to?(:ssl_version=)
-        Net::HTTP.ssl_context_accessor("ssl_version")
-      end
+        unless client.respond_to?(:ssl_version=)
+          Net::HTTP.ssl_context_accessor('ssl_version')
+        end
 
-      client.ssl_version = 'TLSv1'
+        client.ssl_version = 'TLSv1'
 
-      client
-    end
+        client
+      end
 
-    def self.build_request(path, hash)
-      request  = Net::HTTP::Post.new(path)
-      boundary = rand(1_000_000).to_s
+      def build_request(path, hash)
+        request  = Net::HTTP::Post.new(path)
+        boundary = rand(1_000_000).to_s
 
-      request.body         = build_request_body(hash, boundary)
-      request.content_type = "multipart/form-data, boundary=#{boundary}"
+        request.body         = build_request_body(hash, boundary)
+        request.content_type = "multipart/form-data, boundary=#{boundary}"
 
-      request
-    end
+        request
+      end
 
-    def self.build_request_body(hash, boundary)
-      hash = apified_hash(hash)
-      file = hash_to_file(hash)
+      def build_request_body(hash, boundary)
+        hash = apified_hash(hash)
+        file = hash_to_file(hash)
 
-      "--#{boundary}\r\n" \
-      "Content-Disposition: form-data; name=\"json_file\"; filename=\"#{File.basename(file.path)}\"\r\n" \
-      "Content-Type: text/plain\r\n\r\n" +
-      File.read(file.path) +
-      "\r\n--#{boundary}--\r\n"
-    end
+        "--#{boundary}\r\n" \
+        "Content-Disposition: form-data; name=\"json_file\"; filename=\"#{File.basename(file.path)}\"\r\n" \
+        "Content-Type: text/plain\r\n\r\n" +
+          File.read(file.path) +
+          "\r\n--#{boundary}--\r\n"
+      end
 
-    def self.hash_to_file(hash)
-      file = nil
-      Tempfile.open(['coveralls-upload', 'json']) do |f|
-        f.write(JSON.dump hash)
-        file = f
+      def hash_to_file(hash)
+        file = nil
+        Tempfile.open(['coveralls-upload', 'json']) do |f|
+          f.write(JSON.dump(hash))
+          file = f
+        end
+        File.new(file.path, 'rb')
       end
-      File.new(file.path, 'rb')
-    end
 
-    def self.apified_hash hash
-      config = Coveralls::Configuration.configuration
-      if ENV['COVERALLS_DEBUG'] || Coveralls.testing
-        Coveralls::Output.puts "[Coveralls] Submitting with config:", color: "yellow"
-        output = JSON.pretty_generate(config).gsub(/"repo_token": ?"(.*?)"/,'"repo_token": "[secure]"')
-        Coveralls::Output.puts output, color: "yellow"
+      def apified_hash(hash)
+        config = Coveralls::Configuration.configuration
+        if ENV['COVERALLS_DEBUG'] || Coveralls.testing
+          Coveralls::Output.puts '[Coveralls] Submitting with config:', color: 'yellow'
+          output = JSON.pretty_generate(config).gsub(/"repo_token": ?"(.*?)"/, '"repo_token": "[secure]"')
+          Coveralls::Output.puts output, color: 'yellow'
+        end
+        hash.merge(config)
       end
-      hash.merge(config)
     end
   end
 end

data/lib/coveralls/command.rb

@@ -1,69 +1,73 @@
-require "thor"
+# frozen_string_literal: true
+
+require 'thor'
 
 module Coveralls
   class CommandLine < Thor
-
-    desc "push", "Runs your test suite and pushes the coverage results to Coveralls."
+    desc 'push', 'Runs your test suite and pushes the coverage results to Coveralls.'
     def push
       return unless ensure_can_run_locally!
-      ENV["COVERALLS_RUN_LOCALLY"] = "true"
-      cmds = ["bundle exec rake"]
+      ENV['COVERALLS_RUN_LOCALLY'] = 'true'
+      cmds = ['bundle exec rake']
       if File.exist?('.travis.yml')
-        cmds = YAML.load_file('.travis.yml')["script"] || cmds rescue cmds
+        cmds = begin
+                 YAML.load_file('.travis.yml')['script'] || cmds
+               rescue StandardError
+                 cmds
+               end
       end
       cmds.each { |cmd| system cmd }
-      ENV["COVERALLS_RUN_LOCALLY"] = nil
+      ENV['COVERALLS_RUN_LOCALLY'] = nil
     end
 
-    desc "report", "Runs your test suite locally and displays coverage statistics."
+    desc 'report', 'Runs your test suite locally and displays coverage statistics.'
     def report
-      ENV["COVERALLS_NOISY"] = "true"
-      exec "bundle exec rake"
-      ENV["COVERALLS_NOISY"] = nil
+      ENV['COVERALLS_NOISY'] = 'true'
+      exec 'bundle exec rake'
+      ENV['COVERALLS_NOISY'] = nil
     end
 
-    desc "open", "View this repository on Coveralls."
+    desc 'open', 'View this repository on Coveralls.'
     def open
-      open_token_based_url "https://coveralls.io/repos/%@"
+      open_token_based_url 'https://coveralls.io/repos/%@'
     end
 
-    desc "service", "View this repository on your CI service's website."
+    desc 'service', "View this repository on your CI service's website."
     def service
-      open_token_based_url "https://coveralls.io/repos/%@/service"
+      open_token_based_url 'https://coveralls.io/repos/%@/service'
     end
 
-    desc "last", "View the last build for this repository on Coveralls."
+    desc 'last', 'View the last build for this repository on Coveralls.'
     def last
-      open_token_based_url "https://coveralls.io/repos/%@/last_build"
+      open_token_based_url 'https://coveralls.io/repos/%@/last_build'
     end
 
-    desc "version", "See version"
+    desc 'version', 'See version'
     def version
       Coveralls::Output.puts Coveralls::VERSION
     end
 
     private
 
-    def open_token_based_url url
+    def open_token_based_url(url)
       config = Coveralls::Configuration.configuration
       if config[:repo_token]
-        url = url.gsub("%@", config[:repo_token])
+        url = url.gsub('%@', config[:repo_token])
         `open #{url}`
       else
-        Coveralls::Output.puts "No repo_token configured."
+        Coveralls::Output.puts 'No repo_token configured.'
       end
     end
 
     def ensure_can_run_locally!
       config = Coveralls::Configuration.configuration
       if config[:repo_token].nil?
-        Coveralls::Output.puts "Coveralls cannot run locally because no repo_secret_token is set in .coveralls.yml", color: "red"
-        Coveralls::Output.puts "Please try again when you get your act together.", color: "red"
+        Coveralls::Output.puts 'Coveralls cannot run locally because no repo_secret_token is set in .coveralls.yml', color: 'red'
+        Coveralls::Output.puts 'Please try again when you get your act together.', color: 'red'
 
         return false
       end
       true
     end
-
   end
 end