couchrest 0.33 → 0.34

data/spec/couchrest/more/extended_doc_attachment_spec.rb

@@ -66,7 +66,7 @@ describe "ExtendedDocument attachments" do
   
     it 'should set the content-type if passed' do
       @obj.create_attachment(:file => @file_ext, :name => @attachment_name, :content_type => @content_type)
-      @obj['_attachments'][@attachment_name]['content-type'].should == @content_type
+      @obj['_attachments'][@attachment_name]['content_type'].should == @content_type
     end
   end
 
@@ -100,7 +100,7 @@ describe "ExtendedDocument attachments" do
       file = File.open(FIXTURE_PATH + '/attachments/README')
       @file.should_not == file
       @obj.update_attachment(:file => file, :name => @attachment_name, :content_type => @content_type)
-      @obj['_attachments'][@attachment_name]['content-type'].should == @content_type
+      @obj['_attachments'][@attachment_name]['content_type'].should == @content_type
     end
   
     it 'should delete an attachment that exists' do

data/spec/couchrest/more/extended_doc_spec.rb

@@ -1,7 +1,9 @@
+# encoding: utf-8
+
 require File.expand_path("../../../spec_helper", __FILE__)
 require File.join(FIXTURE_PATH, 'more', 'article')
 require File.join(FIXTURE_PATH, 'more', 'course')
-
+require File.join(FIXTURE_PATH, 'more', 'cat')
 
 describe "ExtendedDocument" do
   
@@ -17,8 +19,11 @@ describe "ExtendedDocument" do
   end
   
   class WithCallBacks < CouchRest::ExtendedDocument
+    include ::CouchRest::Validation
     use_database TEST_SERVER.default_database
     property :name
+    property :run_before_validate
+    property :run_after_validate
     property :run_before_save
     property :run_after_save
     property :run_before_create
@@ -26,24 +31,56 @@ describe "ExtendedDocument" do
     property :run_before_update
     property :run_after_update
     
-    save_callback :before do |object| 
+    before_validate do |object|
+      object.run_before_validate = true
+    end
+    after_validate do |object| 
+      object.run_after_validate = true
+    end
+    before_save do |object| 
       object.run_before_save = true
     end
-    save_callback :after do |object| 
+    after_save do |object| 
       object.run_after_save = true
     end
-    create_callback :before do |object| 
+    before_create do |object| 
       object.run_before_create = true
     end
-    create_callback :after do |object| 
+    after_create do |object| 
       object.run_after_create = true
     end
-    update_callback :before do |object| 
+    before_update do |object| 
       object.run_before_update = true
     end
-    update_callback :after do |object| 
+    after_update do |object| 
       object.run_after_update = true
     end
+    
+    property :run_one
+    property :run_two
+    property :run_three
+    
+    before_save :run_one_method, :run_two_method do |object| 
+      object.run_three = true
+    end
+    def run_one_method
+      self.run_one = true
+    end
+    def run_two_method
+      self.run_two = true
+    end
+    
+    attr_accessor :run_it
+    property :conditional_one
+    property :conditional_two
+    
+    before_save :conditional_one_method, :conditional_two_method, :if => proc { self.run_it }
+    def conditional_one_method
+      self.conditional_one = true
+    end
+    def conditional_two_method
+      self.conditional_two = true
+    end
   end
   
   class WithTemplateAndUniqueID < CouchRest::ExtendedDocument
@@ -85,15 +122,17 @@ describe "ExtendedDocument" do
   end
   
   describe "a new model" do
-    it "should be a new_record" do
+    it "should be a new document" do
       @obj = Basic.new
       @obj.rev.should be_nil
-      @obj.should be_a_new_record
+      @obj.should be_new
+      @obj.should be_new_document
+      @obj.should be_new_record
     end
-    it "should be a new_document" do
-      @obj = Basic.new
-      @obj.rev.should be_nil
-      @obj.should be_a_new_document
+
+    it "should not failed on a nil value in argument" do
+      @obj = Basic.new(nil)
+      @obj.should == { 'couchrest-type' => 'Basic' }
     end
   end
   
@@ -101,7 +140,7 @@ describe "ExtendedDocument" do
     it "should instantialize and save a document" do
       article = Article.create(:title => 'my test')
       article.title.should == 'my test'
-      article.should_not be_new_document 
+      article.should_not be_new
     end 
     
     it "should trigger the create callbacks" do
@@ -125,6 +164,27 @@ describe "ExtendedDocument" do
       @art.update_attributes_without_saving('date' => Time.now, :title => "super danger")
       @art['title'].should == "super danger"
     end
+    it "should silently ignore _id" do
+      @art.update_attributes_without_saving('_id' => 'foobar')
+      @art['_id'].should_not == 'foobar'
+    end
+    it "should silently ignore _rev" do
+      @art.update_attributes_without_saving('_rev' => 'foobar')
+      @art['_rev'].should_not == 'foobar'
+    end
+    it "should silently ignore created_at" do
+      @art.update_attributes_without_saving('created_at' => 'foobar')
+      @art['created_at'].should_not == 'foobar'
+    end
+    it "should silently ignore updated_at" do
+      @art.update_attributes_without_saving('updated_at' => 'foobar')
+      @art['updated_at'].should_not == 'foobar'
+    end
+    it "should also work using attributes= alias" do
+      @art.respond_to?(:attributes=).should be_true
+      @art.attributes = {'date' => Time.now, :title => "something else"}
+      @art['title'].should == "something else"
+    end
     
     it "should flip out if an attribute= method is missing" do
       lambda {
@@ -409,6 +469,25 @@ describe "ExtendedDocument" do
     it "should set the type" do
       @sobj['couchrest-type'].should == 'Basic'
     end
+    
+    describe "save!" do
+      
+      before(:each) do
+        @sobj = Card.new(:first_name => "Marcos", :last_name => "Tapajós")
+      end
+      
+      it "should return true if save the document" do
+        @sobj.save!.should == true
+      end
+      
+      it "should raise error if don't save the document" do
+        @sobj.first_name = nil
+        lambda {  @sobj.save!.should == true }.should raise_error(RuntimeError)
+      end
+
+    end
+    
+    
   end
   
   describe "saving a model with a unique_id configured" do
@@ -419,7 +498,7 @@ describe "ExtendedDocument" do
     end
     
     it "should be a new document" do
-      @art.should be_a_new_document
+      @art.should be_new
       @art.title.should be_nil
     end
     
@@ -527,12 +606,46 @@ describe "ExtendedDocument" do
       @doc = WithCallBacks.new
     end
     
+    
+    describe "validate" do
+      it "should run before_validate before validating" do
+        @doc.run_before_validate.should be_nil
+        @doc.should be_valid
+        @doc.run_before_validate.should be_true
+      end
+      it "should run after_validate after validating" do
+        @doc.run_after_validate.should be_nil
+        @doc.should be_valid
+        @doc.run_after_validate.should be_true
+      end
+    end
     describe "save" do
       it "should run the after filter after saving" do
         @doc.run_after_save.should be_nil
         @doc.save.should be_true
         @doc.run_after_save.should be_true
       end
+      it "should run the grouped callbacks before saving" do
+        @doc.run_one.should be_nil
+        @doc.run_two.should be_nil
+        @doc.run_three.should be_nil
+        @doc.save.should be_true
+        @doc.run_one.should be_true
+        @doc.run_two.should be_true
+        @doc.run_three.should be_true
+      end
+      it "should not run conditional callbacks" do
+        @doc.run_it = false
+        @doc.save.should be_true
+        @doc.conditional_one.should be_nil
+        @doc.conditional_two.should be_nil
+      end
+      it "should run conditional callbacks" do
+        @doc.run_it = true
+        @doc.save.should be_true
+        @doc.conditional_one.should be_true
+        @doc.conditional_two.should be_true
+      end
     end
     describe "create" do
       it "should run the before save filter when creating" do
@@ -585,4 +698,49 @@ describe "ExtendedDocument" do
       @doc.other_arg.should == "foo-foo"
     end
   end
+  
+  describe "recursive validation on an extended document" do
+    before :each do
+      reset_test_db!
+      @cat = Cat.new(:name => 'Sockington')
+    end
+    
+    it "should not save if a nested casted model is invalid" do
+      @cat.favorite_toy = CatToy.new
+      @cat.should_not be_valid
+      @cat.save.should be_false
+      lambda{@cat.save!}.should raise_error
+    end
+    
+    it "should save when nested casted model is valid" do
+      @cat.favorite_toy = CatToy.new(:name => 'Squeaky')
+      @cat.should be_valid
+      @cat.save.should be_true
+      lambda{@cat.save!}.should_not raise_error
+    end
+    
+    it "should not save when nested collection contains an invalid casted model" do
+      @cat.toys = [CatToy.new(:name => 'Feather'), CatToy.new]
+      @cat.should_not be_valid
+      @cat.save.should be_false
+      lambda{@cat.save!}.should raise_error
+    end
+    
+    it "should save when nested collection contains valid casted models" do
+      @cat.toys = [CatToy.new(:name => 'feather'), CatToy.new(:name => 'ball-o-twine')]
+      @cat.should be_valid
+      @cat.save.should be_true
+      lambda{@cat.save!}.should_not raise_error
+    end
+    
+    it "should not fail if the nested casted model doesn't have validation" do
+      Cat.property :trainer, :cast_as => 'Person'
+      Cat.validates_presence_of :name
+      cat = Cat.new(:name => 'Mr Bigglesworth')
+      cat.trainer = Person.new
+      cat.trainer.validatable?.should be_false
+      cat.should be_valid
+      cat.save.should be_true
+    end
+  end
 end

data/spec/couchrest/more/extended_doc_view_spec.rb

@@ -348,12 +348,19 @@ describe "ExtendedDocument views" do
   describe "with a collection" do
     before(:all) do
       reset_test_db!
-      @titles = ["very uniq one", "really interesting", "some fun",
+      titles = ["very uniq one", "really interesting", "some fun",
         "really awesome", "crazy bob", "this rocks", "super rad"]
-      @titles.each_with_index do |title,i|
+      titles.each_with_index do |title,i|
         a = Article.new(:title => title, :date => Date.today)
         a.save
       end
+
+      titles = ["yesterday very uniq one", "yesterday really interesting", "yesterday some fun",
+        "yesterday really awesome", "yesterday crazy bob", "yesterday this rocks"]
+      titles.each_with_index do |title,i|
+        a = Article.new(:title => title, :date => Date.today - 1)
+        a.save
+      end
     end 
     require 'date'
     it "should return a proxy that looks like an array of 7 Article objects" do
@@ -373,10 +380,6 @@ describe "ExtendedDocument views" do
         a.should_not be_nil
       end
     end 
-    it "should have the amount of paginated pages" do
-      articles = Article.by_date :key => Date.today
-      articles.paginate(:per_page => 3).amount_pages.should == 3
-    end
     it "should provide a class method to access the collection directly" do
       articles = Article.collection_proxy_for('Article', 'by_date', :descending => true,
         :key => Date.today, :include_docs => true)
@@ -405,10 +408,6 @@ describe "ExtendedDocument views" do
       end
     end
     it "should provide a class method to get a collection for a view" do
-      class Article
-        provides_collection :article_details, 'Article', 'by_date', :descending => true, :include_docs => true
-      end
-
       articles = Article.find_all_article_details(:key => Date.today)
       articles.class.should == Array
       articles.size.should == 7
@@ -421,6 +420,14 @@ describe "ExtendedDocument views" do
       lambda{Article.collection_proxy_for('Article', nil)}.should raise_error
       lambda{Article.paginate(:design_doc => 'Article')}.should raise_error
     end
+    it "should be able to span multiple keys" do
+      articles = Article.by_date :startkey => Date.today, :endkey => Date.today - 1
+      articles.paginate(:page => 1, :per_page => 3).size.should == 3
+      articles.paginate(:page => 2, :per_page => 3).size.should == 3
+      articles.paginate(:page => 3, :per_page => 3).size.should == 3
+      articles.paginate(:page => 4, :per_page => 3).size.should == 3
+      articles.paginate(:page => 5, :per_page => 3).size.should == 1
+    end
   end
 
 end

data/spec/couchrest/more/property_spec.rb

@@ -1,9 +1,12 @@
+# encoding: utf-8
 require File.expand_path('../../../spec_helper', __FILE__)
 require File.join(FIXTURE_PATH, 'more', 'person')
 require File.join(FIXTURE_PATH, 'more', 'card')
 require File.join(FIXTURE_PATH, 'more', 'invoice')
 require File.join(FIXTURE_PATH, 'more', 'service')
 require File.join(FIXTURE_PATH, 'more', 'event')
+require File.join(FIXTURE_PATH, 'more', 'cat')
+require File.join(FIXTURE_PATH, 'more', 'user')
 
 
 describe "ExtendedDocument properties" do
@@ -54,6 +57,30 @@ describe "ExtendedDocument properties" do
     @card.updated_at.should_not be_nil
   end
   
+  
+  describe "mass assignment protection" do
+
+    it "should not store protected attribute using mass assignment" do
+      cat_toy = CatToy.new(:name => "Zorro")
+      cat = Cat.create(:name => "Helena", :toys => [cat_toy], :favorite_toy => cat_toy, :number => 1)
+      cat.number.should be_nil
+      cat.number = 1
+      cat.save
+      cat.number.should == 1
+    end
+
+    it "should not store protected attribute when 'declare accessible poperties, assume all the rest are protected'" do
+      user = User.create(:name => "Marcos Tapajós", :admin => true)
+      user.admin.should be_nil
+    end
+
+    it "should not store protected attribute when 'declare protected properties, assume all the rest are accessible'" do
+      user = SpecialUser.create(:name => "Marcos Tapajós", :admin => true)
+      user.admin.should be_nil
+    end
+
+  end
+  
   describe "validation" do
     before(:each) do
       @invoice = Invoice.new(:client_name => "matt", :employee_name => "Chris", :location => "San Diego, CA")
@@ -94,7 +121,7 @@ describe "ExtendedDocument properties" do
       @invoice.location = nil
       @invoice.should_not be_valid
       @invoice.save.should be_false
-      @invoice.should be_new_document
+      @invoice.should be_new
     end
   end
   
@@ -132,14 +159,17 @@ describe "ExtendedDocument properties" do
   describe "casting" do
     describe "cast keys to any type" do
       before(:all) do
-        event_doc = { :subject => "Some event", :occurs_at => Time.now }
+        event_doc = { :subject => "Some event", :occurs_at => Time.now, :end_date => Date.today }
         e = Event.database.save_doc event_doc
 
         @event = Event.get e['id']
       end
-      it "should cast created_at to Time" do
+      it "should cast occurs_at to Time" do
         @event['occurs_at'].should be_an_instance_of(Time)
       end
+      it "should cast end_date to Date" do
+        @event['end_date'].should be_an_instance_of(Date)
+      end
     end
     
     describe "casting to Float object" do
@@ -191,5 +221,69 @@ describe "ExtendedDocument properties" do
     end
 
   end
+end
+
+describe "a newly created casted model" do
+  before(:each) do
+    reset_test_db!
+    @cat = Cat.new(:name => 'Toonces')
+    @squeaky_mouse = CatToy.new(:name => 'Squeaky')
+  end
+  
+  describe "assigned assigned to a casted property" do
+    it "should have casted_by set to its parent" do
+      @squeaky_mouse.casted_by.should be_nil
+      @cat.favorite_toy = @squeaky_mouse
+      @squeaky_mouse.casted_by.should === @cat
+    end
+  end
+  
+  describe "appended to a casted collection" do
+    it "should have casted_by set to its parent" do
+      @squeaky_mouse.casted_by.should be_nil
+      @cat.toys << @squeaky_mouse
+      @squeaky_mouse.casted_by.should === @cat
+      @cat.save
+      @cat.toys.first.casted_by.should === @cat
+    end
+  end
   
+  describe "list assigned to a casted collection" do
+    it "should have casted_by set on all elements" do
+      toy1 = CatToy.new(:name => 'Feather')
+      toy2 = CatToy.new(:name => 'Mouse')
+      @cat.toys = [toy1, toy2]
+      toy1.casted_by.should === @cat
+      toy2.casted_by.should === @cat
+      @cat.save
+      @cat = Cat.get(@cat.id)
+      @cat.toys[0].casted_by.should === @cat
+      @cat.toys[1].casted_by.should === @cat
+    end
+  end
 end
+
+describe "a casted model retrieved from the database" do
+  before(:each) do
+    reset_test_db!
+    @cat = Cat.new(:name => 'Stimpy')
+    @cat.favorite_toy = CatToy.new(:name => 'Stinky')
+    @cat.toys << CatToy.new(:name => 'Feather')
+    @cat.toys << CatToy.new(:name => 'Mouse')
+    @cat.save
+    @cat = Cat.get(@cat.id)
+  end
+  
+  describe "as a casted property" do
+    it "should already be casted_by its parent" do
+      @cat.favorite_toy.casted_by.should === @cat
+    end
+  end
+  
+  describe "from a casted collection" do
+    it "should already be casted_by its parent" do
+      @cat.toys[0].casted_by.should === @cat
+      @cat.toys[1].casted_by.should === @cat
+    end
+  end
+end