couchrest 0.33 → 0.34

data/spec/couchrest/core/database_spec.rb

@@ -65,22 +65,27 @@ describe CouchRest::Database do
   
   describe "saving a view" do
     before(:each) do
-      @view = {'test' => {'map' => 'function(doc) {
-        if (doc.word && !/\W/.test(doc.word)) {
-          emit(doc.word,null);
+      @view = {'test' => {'map' => <<-JS
+        function(doc) {
+          var reg = new RegExp("\\\\W");
+          if (doc.word && !reg.test(doc.word)) {
+            emit(doc.word,null);
+          }
         }
-      }'}}
+      JS
+      }}
       @db.save_doc({
         "_id" => "_design/test",
         :views => @view
       })
     end
     it "should work properly" do
-      @db.bulk_save([
+      r = @db.bulk_save([
         {"word" => "once"},
         {"word" => "and again"}
       ])
-      @db.view('test/test')['total_rows'].should == 1
+      r = @db.view('test/test')
+      r['total_rows'].should == 1
     end
     it "should round trip" do
       @db.get("_design/test")['views'].should == @view
@@ -131,9 +136,16 @@ describe CouchRest::Database do
       rs = @db.view('first/test', :include_docs => true) do |row|
         rows << row
       end
-      rows.length.should == 4
+      rows.length.should == 3
       rs["total_rows"].should == 3
     end
+    it "should accept a block with several params" do
+      rows = []
+      rs = @db.view('first/test', :include_docs => true, :limit => 2) do |row|
+        rows << row
+      end
+      rows.length.should == 2
+    end
   end
 
   describe "GET (document by id) when the doc exists" do
@@ -253,7 +265,7 @@ describe CouchRest::Database do
   describe "PUT attachment from file" do
     before(:each) do
       filename = FIXTURE_PATH + '/attachments/couchdb.png'
-      @file = File.open(filename)
+      @file = File.open(filename, "rb")
     end
     after(:each) do
       @file.close
@@ -552,7 +564,7 @@ describe CouchRest::Database do
         newdoc['artist'].should == 'Zappa'
       end
       it "should fail without an _id" do
-        lambda{@db.copy({"not"=>"a real doc"})}.should raise_error(ArgumentError)
+        lambda{@db.copy_doc({"not"=>"a real doc"})}.should raise_error(ArgumentError)
       end
     end
     describe "to an existing location" do
@@ -711,4 +723,4 @@ describe CouchRest::Database do
   end
 
 
-end
+end

data/spec/couchrest/core/document_spec.rb

@@ -83,6 +83,14 @@ describe CouchRest::Document do
       @doc.id.should == @resp["id"]
       @doc.rev.should == @resp["rev"]
     end
+    it "should generate a correct URI" do
+      @doc.uri.should == "#{@db.root}/#{@doc.id}"
+      URI.parse(@doc.uri).to_s.should == @doc.uri
+    end
+    it "should generate a correct URI with revision" do
+      @doc.uri(true).should == "#{@db.root}/#{@doc.id}?rev=#{@doc.rev}"
+      URI.parse(@doc.uri(true)).to_s.should == @doc.uri(true)
+    end
   end
 
   describe  "bulk saving" do
@@ -264,4 +272,4 @@ describe "dealing with attachments" do
     end
   end
   
-end
+end

data/spec/couchrest/helpers/streamer_spec.rb

@@ -9,6 +9,14 @@ describe CouchRest::Streamer do
     @streamer = CouchRest::Streamer.new(@db)
     @docs = (1..1000).collect{|i| {:integer => i, :string => i.to_s}}
     @db.bulk_save(@docs)
+    @db.save_doc({
+      "_id" => "_design/first",
+      :views => {
+        :test => {
+	  :map => "function(doc){for(var w in doc){ if(!w.match(/^_/))emit(w,doc[w])}}"
+        }
+      }
+    })
   end
   
   it "should yield each row in a view" do
@@ -19,5 +27,26 @@ describe CouchRest::Streamer do
     end
     count.should == 1001
   end
-  
-end
+
+  it "should accept several params" do
+    count = 0
+    @streamer.view("_design/first/_view/test", :include_docs => true, :limit => 5) do |row|
+      count += 1
+    end
+    count.should == 5
+  end
+
+  it "should accept both view formats" do
+    count = 0
+    @streamer.view("_design/first/_view/test") do |row|
+      count += 1
+    end
+    count.should == 2000
+    count = 0
+    @streamer.view("first/test") do |row|
+      count += 1
+    end
+    count.should == 2000
+  end
+
+end

data/spec/couchrest/more/attribute_protection_spec.rb

@@ -0,0 +1,94 @@
+require File.expand_path("../../../spec_helper", __FILE__)
+
+describe "ExtendedDocument", "no declarations" do
+  class NoProtection < CouchRest::ExtendedDocument
+    use_database TEST_SERVER.default_database
+    property :name
+    property :phone
+  end
+
+  it "should not protect anything through new" do
+    user = NoProtection.new(:name => "will", :phone => "555-5555")
+
+    user.name.should == "will"
+    user.phone.should == "555-5555"
+  end
+
+  it "should not protect anything through attributes=" do
+    user = NoProtection.new
+    user.attributes = {:name => "will", :phone => "555-5555"}
+
+    user.name.should == "will"
+    user.phone.should == "555-5555"
+  end
+end
+
+describe "ExtendedDocument", "accessible flag" do
+  class WithAccessible < CouchRest::ExtendedDocument
+    use_database TEST_SERVER.default_database
+    property :name, :accessible => true
+    property :admin, :default => false
+  end
+
+  it "should recognize accessible properties" do
+    props = WithAccessible.accessible_properties.map { |prop| prop.name}
+    props.should include("name")
+    props.should_not include("admin")
+  end
+
+  it "should protect non-accessible properties set through new" do
+    user = WithAccessible.new(:name => "will", :admin => true) 
+
+    user.name.should == "will"
+    user.admin.should == false
+  end
+
+  it "should protect non-accessible properties set through attributes=" do
+    user = WithAccessible.new
+    user.attributes = {:name => "will", :admin => true}
+
+    user.name.should == "will"
+    user.admin.should == false
+  end
+end
+
+describe "ExtendedDocument", "protected flag" do
+  class WithProtected < CouchRest::ExtendedDocument
+    use_database TEST_SERVER.default_database
+    property :name
+    property :admin, :default => false, :protected => true
+  end
+
+  it "should recognize protected properties" do
+    props = WithProtected.protected_properties.map { |prop| prop.name}
+    props.should_not include("name")
+    props.should include("admin")
+  end
+
+  it "should protect non-accessible properties set through new" do
+    user = WithProtected.new(:name => "will", :admin => true) 
+
+    user.name.should == "will"
+    user.admin.should == false
+  end
+
+  it "should protect non-accessible properties set through attributes=" do
+    user = WithProtected.new
+    user.attributes = {:name => "will", :admin => true}
+
+    user.name.should == "will"
+    user.admin.should == false
+  end
+end
+
+describe "ExtendedDocument", "protected flag" do
+  class WithBoth < CouchRest::ExtendedDocument
+    use_database TEST_SERVER.default_database
+    property :name, :accessible => true
+    property :admin, :default => false, :protected => true
+  end
+
+  it "should raise an error when both are set" do
+    lambda { WithBoth.new }.should raise_error 
+  end
+end

data/spec/couchrest/more/casted_extended_doc_spec.rb

@@ -43,16 +43,14 @@ describe "assigning a value to casted attribute after initializing an object" do
     @car.driver.should be_nil
   end
   
-  # Note that this isn't casting the attribute, it's just assigning it a value
-  # (see "should not cast attribute")
   it "should let you assign the value" do
     @car.driver = @driver
     @car.driver.name.should == 'Matt'
   end
   
-  it "should not cast attribute" do
+  it "should cast attribute" do
     @car.driver = JSON.parse(JSON.generate(@driver))
-    @car.driver.should_not be_instance_of(Driver)
+    @car.driver.should be_instance_of(Driver)
   end
 
 end

data/spec/couchrest/more/casted_model_spec.rb

@@ -4,6 +4,8 @@ require File.expand_path('../../../spec_helper', __FILE__)
 require File.join(FIXTURE_PATH, 'more', 'card')
 require File.join(FIXTURE_PATH, 'more', 'cat')
 require File.join(FIXTURE_PATH, 'more', 'person')
+require File.join(FIXTURE_PATH, 'more', 'question')
+require File.join(FIXTURE_PATH, 'more', 'course')
 
 
 class WithCastedModelMixin < Hash
@@ -21,6 +23,26 @@ class DummyModel < CouchRest::ExtendedDocument
   property :keywords,         :cast_as => ["String"]
 end
 
+class CastedCallbackDoc < CouchRest::ExtendedDocument
+  use_database TEST_SERVER.default_database
+  raise "Default DB not set" if TEST_SERVER.default_database.nil?
+  property :callback_model, :cast_as => 'WithCastedCallBackModel'
+end
+class WithCastedCallBackModel < Hash
+  include CouchRest::CastedModel
+  include CouchRest::Validation
+  property :name
+  property :run_before_validate
+  property :run_after_validate
+  
+  before_validate do |object|
+    object.run_before_validate = true
+  end
+  after_validate do |object| 
+    object.run_after_validate = true
+  end
+end
+
 describe CouchRest::CastedModel do
   
   describe "A non hash class including CastedModel" do
@@ -106,7 +128,40 @@ describe CouchRest::CastedModel do
       @obj.keywords.should be_an_instance_of(Array)
       @obj.keywords.first.should == 'couch'
     end
+  end
+  
+  describe "update attributes without saving" do
+    before(:each) do
+      @question = Question.new(:q => "What is your quest?", :a => "To seek the Holy Grail")
+    end
+    it "should work for attribute= methods" do
+      @question.q.should == "What is your quest?"
+      @question['a'].should == "To seek the Holy Grail"
+      @question.update_attributes_without_saving(:q => "What is your favorite color?", 'a' => "Blue")
+      @question['q'].should == "What is your favorite color?"
+      @question.a.should == "Blue"
+    end
+    
+    it "should also work for attributes= alias" do
+      @question.respond_to?(:attributes=).should be_true
+      @question.attributes = {:q => "What is your favorite color?", 'a' => "Blue"}
+      @question['q'].should == "What is your favorite color?"
+      @question.a.should == "Blue"
+    end
+    
+    it "should flip out if an attribute= method is missing" do
+      lambda {
+        @q.update_attributes_without_saving('foo' => "something", :a => "No green")
+      }.should raise_error(NoMethodError)
+    end
     
+    it "should not change any attributes if there is an error" do
+      lambda {
+        @q.update_attributes_without_saving('foo' => "something", :a => "No green")
+      }.should raise_error(NoMethodError)
+      @question.q.should == "What is your quest?"
+      @question.a.should == "To seek the Holy Grail"
+    end
   end
   
   describe "saved document with casted models" do
@@ -154,6 +209,10 @@ describe CouchRest::CastedModel do
       toy = CatToy.new :name => "Mouse"
       @cat.toys.push(toy)
       @cat.save.should be_true
+      @cat = Cat.get @cat.id
+      @cat.toys.class.should == CastedArray
+      @cat.toys.first.class.should == CatToy
+      @cat.toys.first.should === toy
     end
 
     it "should fail because name is not present" do
@@ -165,13 +224,183 @@ describe CouchRest::CastedModel do
     
     it "should not fail if the casted model doesn't have validation" do
       Cat.property :masters, :cast_as => ['Person'], :default => []
-      Cat.validates_present :name
+      Cat.validates_presence_of :name
       cat = Cat.new(:name => 'kitty')
       cat.should be_valid
       cat.masters.push Person.new
       cat.should be_valid
     end
+  end
+  
+  describe "calling valid?" do
+    before :each do
+      @cat = Cat.new
+      @toy1 = CatToy.new
+      @toy2 = CatToy.new
+      @toy3 = CatToy.new
+      @cat.favorite_toy = @toy1
+      @cat.toys << @toy2
+      @cat.toys << @toy3
+    end
+    
+    describe "on the top document" do
+      it "should put errors on all invalid casted models" do
+        @cat.should_not be_valid
+        @cat.errors.should_not be_empty
+        @toy1.errors.should_not be_empty
+        @toy2.errors.should_not be_empty
+        @toy3.errors.should_not be_empty
+      end
+      
+      it "should not put errors on valid casted models" do
+        @toy1.name = "Feather"
+        @toy2.name = "Twine" 
+        @cat.should_not be_valid
+        @cat.errors.should_not be_empty
+        @toy1.errors.should be_empty
+        @toy2.errors.should be_empty
+        @toy3.errors.should_not be_empty
+      end
+    end
+    
+    describe "on a casted model property" do
+      it "should only validate itself" do
+        @toy1.should_not be_valid
+        @toy1.errors.should_not be_empty
+        @cat.errors.should be_empty
+        @toy2.errors.should be_empty
+        @toy3.errors.should be_empty
+      end
+    end
+    
+    describe "on a casted model inside a casted collection" do
+      it "should only validate itself" do
+        @toy2.should_not be_valid
+        @toy2.errors.should_not be_empty
+        @cat.errors.should be_empty
+        @toy1.errors.should be_empty
+        @toy3.errors.should be_empty
+      end
+    end
+  end
+  
+  describe "calling new? on a casted model" do
+    before :each do
+      reset_test_db!
+      @cat = Cat.new(:name => 'Sockington')
+      @favorite_toy = CatToy.new(:name => 'Catnip Ball')
+      @cat.favorite_toy = @favorite_toy
+      @cat.toys << CatToy.new(:name => 'Fuzzy Stick')
+    end
     
+    it "should be true on new" do
+      CatToy.new.should be_new
+      CatToy.new.new_record?.should be_true
+    end
+    
+    it "should be true after assignment" do
+      @cat.should be_new
+      @cat.favorite_toy.should be_new
+      @cat.toys.first.should be_new
+    end
+    
+    it "should not be true after create or save" do
+      @cat.create
+      @cat.save
+      @cat.favorite_toy.should_not be_new
+      @cat.toys.first.should_not be_new
+    end
+    
+    it "should not be true after get from the database" do
+      @cat.save
+      @cat = Cat.get(@cat.id)
+      @cat.favorite_toy.should_not be_new
+      @cat.toys.first.should_not be_new
+    end
+    
+    it "should still be true after a failed create or save" do
+      @cat.name = nil
+      @cat.create.should be_false
+      @cat.save.should be_false
+      @cat.favorite_toy.should be_new
+      @cat.toys.first.should be_new
+    end
+  end
+  
+  describe "calling base_doc from a nested casted model" do
+    before :each do
+      @course = Course.new(:title => 'Science 101')
+      @professor = Person.new(:name => 'Professor Plum')
+      @cat = Cat.new(:name => 'Scratchy')
+      @toy1 = CatToy.new
+      @toy2 = CatToy.new
+      @course.professor = @professor
+      @professor.pet = @cat
+      @cat.favorite_toy = @toy1
+      @cat.toys << @toy2
+    end
+    
+    it "should reference the top document for" do
+      @course.base_doc.should === @course
+      @professor.casted_by.should === @course
+      @professor.base_doc.should === @course
+      @cat.base_doc.should === @course
+      @toy1.base_doc.should === @course
+      @toy2.base_doc.should === @course
+    end
+    
+    it "should call setter on top document" do
+      @toy1.base_doc.should_not be_nil
+      @toy1.base_doc.title = 'Tom Foolery'
+      @course.title.should == 'Tom Foolery'
+    end
+    
+    it "should return nil if not yet casted" do
+      person = Person.new
+      person.base_doc.should == nil
+    end
+  end
+  
+  describe "calling base_doc.save from a nested casted model" do
+    before :each do
+      reset_test_db!
+      @cat = Cat.new(:name => 'Snowball')
+      @toy = CatToy.new
+      @cat.favorite_toy = @toy
+    end
+    
+    it "should not save parent document when casted model is invalid" do
+      @toy.should_not be_valid
+      @toy.base_doc.save.should be_false
+      lambda{@toy.base_doc.save!}.should raise_error
+    end
+    
+    it "should save parent document when nested casted model is valid" do
+      @toy.name = "Mr Squeaks"
+      @toy.should be_valid
+      @toy.base_doc.save.should be_true
+      lambda{@toy.base_doc.save!}.should_not raise_error
+    end
   end
   
+  describe "callbacks" do
+    before(:each) do
+      @doc = CastedCallbackDoc.new
+      @model = WithCastedCallBackModel.new
+      @doc.callback_model = @model
+    end
+    
+    describe "validate" do
+      it "should run before_validate before validating" do
+        @model.run_before_validate.should be_nil
+        @model.should be_valid
+        @model.run_before_validate.should be_true
+      end
+      it "should run after_validate after validating" do
+        @model.run_after_validate.should be_nil
+        @model.should be_valid
+        @model.run_after_validate.should be_true
+      end      
+    end
+  end
 end