cosmos 4.5.1 → 5.0.2

data/lib/cosmos/packets/packet_config.rb

@@ -1,18 +1,26 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/config/config_parser'
 require 'cosmos/packets/packet'
 require 'cosmos/packets/parsers/packet_parser'
 require 'cosmos/packets/parsers/packet_item_parser'
-require 'cosmos/packets/parsers/macro_parser'
 require 'cosmos/packets/parsers/limits_parser'
 require 'cosmos/packets/parsers/limits_response_parser'
 require 'cosmos/packets/parsers/state_parser'
@@ -26,7 +34,7 @@ require 'nokogiri'
 require 'ostruct'
 
 module Cosmos
-
+  # Reads a command or telemetry configuration file and builds a hash of packets.
   class PacketConfig
     # @return [String] The name of this configuration. To be used by higher
     #   level classes to store information about the current PacketConfig.
@@ -121,10 +129,9 @@ module Cosmos
       @building_generic_conversion = false
 
       process_target_name = process_target_name.upcase
-      parser = ConfigParser.new("http://cosmosrb.com/docs/cmdtlm")
+      parser = ConfigParser.new("http://cosmosc2.com/docs/v5")
       parser.instance_variable_set(:@target_name, process_target_name)
       parser.parse_file(filename) do |keyword, params|
-
         if @building_generic_conversion
           case keyword
           # Complete a generic conversion
@@ -201,9 +208,10 @@ module Cosmos
           when 'SELECT_ITEM', 'SELECT_PARAMETER', 'DELETE_ITEM', 'DELETE_PARAMETER', 'ITEM',\
               'PARAMETER', 'ID_ITEM', 'ID_PARAMETER', 'ARRAY_ITEM', 'ARRAY_PARAMETER', 'APPEND_ITEM',\
               'APPEND_PARAMETER', 'APPEND_ID_ITEM', 'APPEND_ID_PARAMETER', 'APPEND_ARRAY_ITEM',\
-              'APPEND_ARRAY_PARAMETER', 'MACRO_APPEND_START', 'MACRO_APPEND_END', 'ALLOW_SHORT',\
-              'HAZARDOUS', 'PROCESSOR', 'META', 'DISABLE_MESSAGES', 'HIDDEN', 'DISABLED'
+              'APPEND_ARRAY_PARAMETER', 'ALLOW_SHORT', 'HAZARDOUS', 'PROCESSOR', 'META',\
+              'DISABLE_MESSAGES', 'HIDDEN', 'DISABLED'
             raise parser.error("No current packet for #{keyword}") unless @current_packet
+
             process_current_packet(parser, keyword, params)
 
           #######################################################################
@@ -215,6 +223,7 @@ module Cosmos
               'LIMITS', 'LIMITS_RESPONSE', 'UNITS', 'FORMAT_STRING', 'DESCRIPTION',\
               'MINIMUM_VALUE', 'MAXIMUM_VALUE', 'DEFAULT_VALUE', 'OVERFLOW', 'OVERLAP'
             raise parser.error("No current item for #{keyword}") unless @current_item
+
             process_current_item(parser, keyword, params)
 
           else
@@ -235,6 +244,7 @@ module Cosmos
 
       @telemetry.each do |target_name, packets|
         next if target_name == 'UNKNOWN'
+
         FileUtils.mkdir_p(File.join(output_dir, target_name, 'cmd_tlm'))
         filename = File.join(output_dir, target_name, 'cmd_tlm', target_name.downcase + '_tlm.txt')
         begin
@@ -252,6 +262,7 @@ module Cosmos
 
       @commands.each do |target_name, packets|
         next if target_name == 'UNKNOWN'
+
         FileUtils.mkdir_p(File.join(output_dir, target_name, 'cmd_tlm'))
         filename = File.join(output_dir, target_name, 'cmd_tlm', target_name.downcase + '_cmd.txt')
         begin
@@ -288,7 +299,7 @@ module Cosmos
     end
 
     # Add current packet into hash if it exists
-    def finish_packet()
+    def finish_packet
       finish_item()
       if @current_packet
         @warnings += @current_packet.check_bit_offsets
@@ -343,6 +354,7 @@ module Cosmos
         if (@current_cmd_or_tlm == TELEMETRY) && (keyword.split('_')[1] == 'PARAMETER')
           raise parser.error("#{keyword} only applies to command packets")
         end
+
         usage = "#{keyword} <#{keyword.split('_')[1]} NAME>"
         finish_item()
         parser.verify_num_parameters(1, 1, usage)
@@ -362,18 +374,6 @@ module Cosmos
           'APPEND_ARRAY_ITEM', 'APPEND_ARRAY_PARAMETER'
         start_item(parser)
 
-      # Start the creation of a macro-expanded list of items
-      # This simulates an array of structures of multiple items in the packet by repeating
-      # each item in the list multiple times with a different "index" added to the name.
-      when 'MACRO_APPEND_START'
-        Logger.warn "MACRO_APPEND_START/END is deprecated. Please use new ERB macro syntax."
-        MacroParser.start(parser)
-
-      # End the creation of a macro-expanded list of items
-      when 'MACRO_APPEND_END'
-        finish_item()
-        MacroParser.end(parser, @current_packet)
-
       # Allow this packet to be received with less data than the defined length
       # without generating a warning.
       when 'ALLOW_SHORT'
@@ -404,6 +404,11 @@ module Cosmos
         else
           meta_values = []
         end
+        meta_values.each_with_index do |value, index|
+          if String === value
+            meta_values[index] = value.to_utf8
+          end
+        end
         if @current_item
           # Item META
           @current_item.meta[params[0].to_s.upcase] = meta_values
@@ -442,10 +447,11 @@ module Cosmos
           # require should be performed in target.txt
           klass = params[0].filename_to_class_name.to_class
           raise parser.error("#{params[0].filename_to_class_name} class not found. Did you require the file in target.txt?", usage) unless klass
+
           conversion = klass.new(*params[1..(params.length - 1)])
           @current_item.public_send("#{keyword.downcase}=".to_sym, conversion)
           if klass != ProcessorConversion and (conversion.converted_type.nil? or conversion.converted_bit_size.nil?)
-            msg = "Read Conversion #{params[0].filename_to_class_name} on item #{@current_item.name} does not specify converted type or bit size. Will not be supported by DART"
+            msg = "Read Conversion #{params[0].filename_to_class_name} on item #{@current_item.name} does not specify converted type or bit size"
             @warnings << msg
             Logger.instance.warn @warnings[-1]
           end
@@ -498,7 +504,7 @@ module Cosmos
         end
         @converted_bit_size = Integer(params[1]) if params[1]
         if @converted_type.nil? or @converted_bit_size.nil?
-          msg = "Generic Conversion on item #{@current_item.name} does not specify converted type or bit size. Will not be supported by DART"
+          msg = "Generic Conversion on item #{@current_item.name} does not specify converted type or bit size"
           @warnings << msg
           Logger.instance.warn @warnings[-1]
         end
@@ -546,10 +552,12 @@ module Cosmos
         if @current_cmd_or_tlm == TELEMETRY
           raise parser.error("#{keyword} only applies to command parameters")
         end
+
         usage = "MINIMUM_VALUE <MINIMUM VALUE>"
         parser.verify_num_parameters(1, 1, usage)
         min = ConfigParser.handle_defined_constants(
-          params[0].convert_to_value, @current_item.data_type, @current_item.bit_size)
+          params[0].convert_to_value, @current_item.data_type, @current_item.bit_size
+        )
         @current_item.range = Range.new(min, @current_item.range.end)
 
       # Update the maximum value for the current command parameter
@@ -557,10 +565,12 @@ module Cosmos
         if @current_cmd_or_tlm == TELEMETRY
           raise parser.error("#{keyword} only applies to command parameters")
         end
+
         usage = "MAXIMUM_VALUE <MAXIMUM VALUE>"
         parser.verify_num_parameters(1, 1, usage)
         max = ConfigParser.handle_defined_constants(
-          params[0].convert_to_value, @current_item.data_type, @current_item.bit_size)
+          params[0].convert_to_value, @current_item.data_type, @current_item.bit_size
+        )
         @current_item.range = Range.new(@current_item.range.begin, max)
 
       # Update the default value for the current command parameter
@@ -568,14 +578,16 @@ module Cosmos
         if @current_cmd_or_tlm == TELEMETRY
           raise parser.error("#{keyword} only applies to command parameters")
         end
+
         usage = "DEFAULT_VALUE <DEFAULT VALUE>"
         parser.verify_num_parameters(1, 1, usage)
-        if ((@current_item.data_type == :STRING) ||
-            (@current_item.data_type == :BLOCK))
+        if (@current_item.data_type == :STRING) ||
+           (@current_item.data_type == :BLOCK)
           @current_item.default = params[0]
         else
           @current_item.default = ConfigParser.handle_defined_constants(
-            params[0].convert_to_value, @current_item.data_type, @current_item.bit_size)
+            params[0].convert_to_value, @current_item.data_type, @current_item.bit_size
+          )
         end
 
       # Update the overflow type for the current command parameter
@@ -594,7 +606,6 @@ module Cosmos
     def start_item(parser)
       finish_item()
       @current_item = PacketItemParser.parse(parser, @current_packet, @current_cmd_or_tlm, @warnings)
-      MacroParser.new_item()
     end
 
     # Finish updating packet item

data/lib/cosmos/packets/packet_item.rb

@@ -1,16 +1,26 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/packets/structure_item'
 require 'cosmos/packets/packet_item_limits'
 require 'cosmos/conversions/conversion'
+require 'cosmos/io/json_rpc' # Includes needed as_json code
 
 module Cosmos
   # Maintains knowledge of an item in a Packet
@@ -101,7 +111,8 @@ module Cosmos
     def format_string=(format_string)
       if format_string
         raise ArgumentError, "#{@name}: format_string must be a String but is a #{format_string.class}" unless String === format_string
-        raise ArgumentError, "#{@name}: format_string invalid '#{format_string}'" unless format_string =~ /%.*(b|B|d|i|o|u|x|X|e|E|f|g|G|a|A|c|p|s|%)/
+        raise ArgumentError, "#{@name}: format_string invalid '#{format_string}'" unless /%.*(b|B|d|i|o|u|x|X|e|E|f|g|G|a|A|c|p|s|%)/.match?(format_string)
+
         @format_string = format_string.clone.freeze
       else
         @format_string = nil
@@ -111,6 +122,7 @@ module Cosmos
     def read_conversion=(read_conversion)
       if read_conversion
         raise ArgumentError, "#{@name}: read_conversion must be a Cosmos::Conversion but is a #{read_conversion.class}" unless Cosmos::Conversion === read_conversion
+
         @read_conversion = read_conversion.clone
       else
         @read_conversion = nil
@@ -120,6 +132,7 @@ module Cosmos
     def write_conversion=(write_conversion)
       if write_conversion
         raise ArgumentError, "#{@name}: write_conversion must be a Cosmos::Conversion but is a #{write_conversion.class}" unless Cosmos::Conversion === write_conversion
+
         @write_conversion = write_conversion.clone
       else
         @write_conversion = nil
@@ -155,7 +168,8 @@ module Cosmos
     def description=(description)
       if description
         raise ArgumentError, "#{@name}: description must be a String but is a #{description.class}" unless String === description
-        @description = description.clone.freeze
+
+        @description = description.to_utf8.freeze
       else
         @description = nil
       end
@@ -164,6 +178,7 @@ module Cosmos
     def units_full=(units_full)
       if units_full
         raise ArgumentError, "#{@name}: units_full must be a String but is a #{units_full.class}" unless String === units_full
+
         @units_full = units_full.clone.freeze
       else
         @units_full = nil
@@ -173,6 +188,7 @@ module Cosmos
     def units=(units)
       if units
         raise ArgumentError, "#{@name}: units must be a String but is a #{units.class}" unless String === units
+
         @units = units.clone.freeze
       else
         @units = nil
@@ -187,20 +203,24 @@ module Cosmos
           case data_type
           when :INT, :UINT
             raise ArgumentError, "#{@name}: default must be a Integer but is a #{@default.class}" unless Integer === @default
+
             if @range
               raise ArgumentError, "#{@name}: minimum must be a Integer but is a #{@range.first.class}" unless Integer === @range.first
               raise ArgumentError, "#{@name}: maximum must be a Integer but is a #{@range.last.class}" unless Integer === @range.last
             end
           when :FLOAT
             raise ArgumentError, "#{@name}: default must be a Float but is a #{@default.class}" unless Float === @default or Integer === @default
+
             @default = @default.to_f
             if @range
               raise ArgumentError, "#{@name}: minimum must be a Float but is a #{@range.first.class}" unless Float === @range.first or Integer === @range.first
               raise ArgumentError, "#{@name}: maximum must be a Float but is a #{@range.last.class}" unless Float === @range.last or Integer === @range.last
+
               @range = ((@range.first.to_f)..(@range.last.to_f))
             end
           when :BLOCK, :STRING
             raise ArgumentError, "#{@name}: default must be a String but is a #{@default.class}" unless String === @default
+
             @default = @default.clone.freeze
           end
         end
@@ -210,6 +230,7 @@ module Cosmos
     def range=(range)
       if range
         raise ArgumentError, "#{@name}: range must be a Range but is a #{range.class}" unless Range === range
+
         @range = range.clone.freeze
       else
         @range = nil
@@ -219,6 +240,7 @@ module Cosmos
     def hazardous=(hazardous)
       if hazardous
         raise ArgumentError, "#{@name}: hazardous must be a Hash but is a #{hazardous.class}" unless Hash === hazardous
+
         @hazardous = hazardous.clone
       else
         @hazardous = nil
@@ -228,6 +250,7 @@ module Cosmos
     def state_colors=(state_colors)
       if state_colors
         raise ArgumentError, "#{@name}: state_colors must be a Hash but is a #{state_colors.class}" unless Hash === state_colors
+
         @state_colors = state_colors.clone
       else
         @state_colors = nil
@@ -237,6 +260,7 @@ module Cosmos
     def limits=(limits)
       if limits
         raise ArgumentError, "#{@name}: limits must be a PacketItemLimits but is a #{limits.class}" unless PacketItemLimits === limits
+
         @limits = limits.clone
       else
         @limits = nil
@@ -250,6 +274,7 @@ module Cosmos
     def meta=(meta)
       if meta
         raise ArgumentError, "#{@name}: meta must be a Hash but is a #{meta.class}" unless Hash === meta
+
         @meta = meta.clone
       else
         @meta = nil
@@ -352,7 +377,7 @@ module Cosmos
           config << parameter_config()
         end
       end
-      config << " #{self.endianness}" if (self.endianness != default_endianness && self.data_type != :STRING && self.data_type != :BLOCK)
+      config << " #{self.endianness}" if self.endianness != default_endianness && self.data_type != :STRING && self.data_type != :BLOCK
       config << "\n"
 
       config << "    REQUIRED\n" if self.required
@@ -392,10 +417,72 @@ module Cosmos
 
       if @meta
         @meta.each do |key, values|
-          config << "    META #{key.to_s.quote_if_necessary} #{values.map {|a| a.to_s.quote_if_necessary}.join(" ")}\n"
+          config << "    META #{key.to_s.quote_if_necessary} #{values.map { |a| a.to_s.quote_if_necessary }.join(" ")}\n"
+        end
+      end
+
+      config
+    end
+
+    def as_json
+      config = {}
+      config['name'] = self.name
+      config['bit_offset'] = self.bit_offset
+      config['bit_size'] = self.bit_size
+      config['data_type'] = self.data_type.to_s
+      config['array_size'] = self.array_size if self.array_size
+      config['description'] = self.description
+      config['id_value'] = self.id_value.as_json if self.id_value
+      if @default
+        config['default'] = @default.as_json
+      end
+      if self.range
+        config['minimum'] = self.range.first.as_json
+        config['maximum'] = self.range.last.as_json
+      end
+      config['endianness'] = self.endianness.to_s
+      config['required'] = self.required
+      config['format_string'] = self.format_string if self.format_string
+      if self.units
+        config['units'] = self.units
+        config['units_full'] = self.units_full
+      end
+      config['overflow'] = self.overflow.to_s
+      if @states
+        states = {}
+        config['states'] = states
+        @states.each do |state_name, state_value|
+          state = {}
+          states[state_name] = state
+          state['value'] = state_value.as_json
+          state['hazardous'] = @hazardous[state_name] if @hazardous and @hazardous[state_name]
+          state['color'] = @state_colors[state_name].to_s if @state_colors and @state_colors[state_name]
+        end
+      end
+
+      config['read_conversion'] = self.read_conversion.as_json if self.read_conversion
+      config['write_conversion'] = self.write_conversion.as_json if self.write_conversion
+
+      if self.limits
+        if self.limits.values
+          config['limits'] ||= {}
+          config['limits']['persistence_setting'] = self.limits.persistence_setting
+          config['limits']['enabled'] = true if self.limits.enabled
+          self.limits.values.each do |limits_set, limits_values|
+            limits = {}
+            limits['red_low'] =  limits_values[0]
+            limits['yellow_low'] = limits_values[1]
+            limits['yellow_high'] = limits_values[2]
+            limits['red_high'] = limits_values[3]
+            limits['green_low'] = limits_values[4] if limits_values[4]
+            limits['green_high'] = limits_values[5] if limits_values[5]
+            config['limits'][limits_set] = limits
+          end
         end
+        config['limits_response'] = self.limits.response.as_json if self.limits.response
       end
 
+      config['meta'] = @meta if @meta
       config
     end
 

data/lib/cosmos/packets/packet_item_limits.rb

@@ -1,17 +1,25 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 require 'cosmos/packets/limits_response'
 
 module Cosmos
-
   # Maintains knowledge of limits for a PacketItem
   class PacketItemLimits
     # Array of all limit states
@@ -70,6 +78,7 @@ module Cosmos
       if values
         raise ArgumentError, "values must be a Hash but is a #{values.class}" unless Hash === values
         raise ArgumentError, "values must be a Hash with a :DEFAULT key" unless values.keys.include?(:DEFAULT)
+
         @values = values.clone
       else
         @values = nil
@@ -78,12 +87,14 @@ module Cosmos
 
     def state=(state)
       raise ArgumentError, "state must be one of #{LIMITS_STATES} but is #{state}" unless LIMITS_STATES.include?(state)
+
       @state = state
     end
 
     def response=(response)
       if response
         raise ArgumentError, "response must be a Cosmos::LimitsResponse but is a #{response.class}" unless Cosmos::LimitsResponse === response
+
         @response = response.clone
       else
         @response = nil
@@ -135,6 +146,5 @@ module Cosmos
       hash['persistence_count'] = self.persistence_count
       hash
     end
-
   end
 end # module Cosmos

data/lib/cosmos/packets/parsers/format_string_parser.rb

@@ -1,15 +1,23 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 module Cosmos
-
   class FormatStringParser
     # @param parser [ConfigParser] Configuration parser
     # @param item [Packet] The current item
@@ -53,6 +61,5 @@ module Cosmos
     rescue Exception
       raise @parser.error("Invalid FORMAT_STRING specified for type #{item.data_type}: #{@parser.parameters[0]}", @usage)
     end
-
   end
 end # module Cosmos

data/lib/cosmos/packets/parsers/limits_parser.rb

@@ -1,15 +1,23 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 module Cosmos
-
   class LimitsParser
     # @param parser [ConfigParser] Configuration parser
     # @param packet [Packet] The current packet
@@ -19,6 +27,7 @@ module Cosmos
     #   appended with any warnings found when parsing the limits
     def self.parse(parser, packet, cmd_or_tlm, item, warnings)
       raise parser.error("Items with STATE can't define LIMITS") if item.states
+
       @parser = LimitsParser.new(parser)
       @parser.verify_parameters(cmd_or_tlm)
       @parser.create_limits(packet, item, warnings)
@@ -33,6 +42,7 @@ module Cosmos
       if cmd_or_tlm == PacketConfig::COMMAND
         raise @parser.error("LIMITS only applies to telemetry items")
       end
+
       @usage = "LIMITS <LIMITS SET> <PERSISTENCE> <ENABLED/DISABLED> <RED LOW LIMIT> <YELLOW LOW LIMIT> <YELLOW HIGH LIMIT> <RED HIGH LIMIT> <GREEN LOW LIMIT (Optional)> <GREEN HIGH LIMIT (Optional)>"
       @parser.verify_num_parameters(7, 9, @usage)
     end
@@ -59,7 +69,7 @@ module Cosmos
       # Values must be initialized with a :DEFAULT key
       if !item.limits.values
         if limits_set == :DEFAULT
-          item.limits.values = {:DEFAULT => []}
+          item.limits.values = { :DEFAULT => [] }
         else
           raise @parser.error("DEFAULT limits set must be defined for #{packet.target_name} #{packet.packet_name} #{item.name} before setting limits set #{limits_set}")
         end
@@ -73,7 +83,7 @@ module Cosmos
       msg = "TELEMETRY Item #{packet.target_name} #{packet.packet_name} #{item.name} #{get_limits_set()} limits _TYPE_ setting conflict with DEFAULT"
       # XOR our setting with the items current setting
       # If it returns true then we have a mismatch and log the error
-      if (get_enabled() ^ item.limits.enabled)
+      if get_enabled() ^ item.limits.enabled
         warnings << msg.sub('_TYPE_', 'enable')
         Logger.instance.warn warnings[-1]
       end
@@ -98,6 +108,7 @@ module Cosmos
       if enabled != 'ENABLED' and enabled != 'DISABLED'
         raise @parser.error("Initial LIMITS state must be ENABLED or DISABLED.", @usage)
       end
+
       enabled == 'ENABLED' ? true : false
     end
 
@@ -120,6 +131,7 @@ module Cosmos
       if (red_low > yellow_low) or (yellow_low >= yellow_high) or (yellow_high > red_high)
         raise @parser.error("Invalid limits specified. Ensure yellow limits are within red limits.", @usage)
       end
+
       [red_low, yellow_low, yellow_high, red_high]
     end
 
@@ -140,8 +152,8 @@ module Cosmos
       if (yellow_low > green_low) or (green_low >= green_high) or (green_high > yellow_high)
         raise @parser.error("Invalid limits specified. Ensure green limits are within yellow limits.", @usage)
       end
+
       [green_low, green_high]
     end
-
   end
 end # module Cosmos

data/lib/cosmos/packets/parsers/limits_response_parser.rb

@@ -1,15 +1,23 @@
 # encoding: ascii-8bit
 
-# Copyright 2014 Ball Aerospace & Technologies Corp.
+# Copyright 2022 Ball Aerospace & Technologies Corp.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
+# under the terms of the GNU Affero General Public License
 # as published by the Free Software Foundation; version 3 with
 # attribution addendums as found in the LICENSE.txt
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# This program may also be used under the terms of a commercial or
+# enterprise edition license of COSMOS if purchased from the
+# copyright holder
 
 module Cosmos
-
   class LimitsResponseParser
     # @param parser [ConfigParser] Configuration parser
     # @param item [Packet] The current item
@@ -30,6 +38,7 @@ module Cosmos
       if cmd_or_tlm == PacketConfig::COMMAND
         raise @parser.error("LIMITS_RESPONSE only applies to telemetry items")
       end
+
       @usage = "LIMITS_RESPONSE <RESPONSE CLASS FILENAME> <RESPONSE SPECIFIC OPTIONS>"
       @parser.verify_num_parameters(1, nil, @usage)
     end
@@ -39,6 +48,7 @@ module Cosmos
       # require should be performed in target.txt
       klass = @parser.parameters[0].filename_to_class_name.to_class
       raise @parser.error("#{@parser.parameters[0].filename_to_class_name} class not found. Did you require the file in target.txt?", @usage) unless klass
+
       if @parser.parameters[1]
         item.limits.response = klass.new(*@parser.parameters[1..(@parser.parameters.length - 1)])
       else
@@ -47,6 +57,5 @@ module Cosmos
     rescue Exception => err
       raise @parser.error(err, @usage)
     end
-
   end
 end # module Cosmos