cosmos 4.0.1-universal-java-1.8 → 4.0.2-universal-java-1.8

data/lib/cosmos/interfaces/protocols/template_protocol.rb

@@ -30,6 +30,12 @@ module Cosmos
     # @param discard_leading_bytes (see TerminatedProtocol#initialize)
     # @param sync_pattern (see TerminatedProtocol#initialize)
     # @param fill_fields (see TerminatedProtocol#initialize)
+    # @param response_timeout [Float] Number of seconds to wait before timing out
+    #   when waiting for a response
+    # @param response_polling_period [Float] Number of seconds to wait between polling
+    #   for a response
+    # @param raise_exceptions [String] Whether to raise exceptions when errors
+    #   occur in the protocol like unexpected responses or response timeouts.
     def initialize(
       write_termination_characters,
       read_termination_characters,
@@ -41,7 +47,8 @@ module Cosmos
       sync_pattern = nil,
       fill_fields = false,
       response_timeout = 5.0,
-      response_polling_period = 0.02
+      response_polling_period = 0.02,
+      raise_exceptions = false
     )
       super(
         write_termination_characters,
@@ -62,6 +69,7 @@ module Cosmos
       @response_timeout = @response_timeout.to_f if @response_timeout
       @response_polling_period = response_polling_period.to_f
       @connect_complete_time = nil
+      @raise_exceptions = ConfigParser.handle_true_false(raise_exceptions)
     end
 
     def reset
@@ -128,9 +136,17 @@ module Cosmos
         # Scan the response for the variables in brackets <VARIABLE>
         # Write the packet value with each of the values received
         response_values = response_string.scan(response_regexp)[0]
-        raise "Unexpected response received: #{response_string}" if !response_values || (response_values.length != response_item_names.length)
-        response_values.each_with_index do |value, i|
-          result_packet.write(response_item_names[i], value)
+        if !response_values || (response_values.length != response_item_names.length)
+          handle_error("#{@interface.name}: Unexpected response: #{response_string}")
+        else
+          response_values.each_with_index do |value, i|
+            begin
+              result_packet.write(response_item_names[i], value)
+            rescue => error
+              handle_error("#{@interface.name}: Could not write value #{value} due to #{error.message}")
+              break
+            end
+          end
         end
 
         @response_packets.clear
@@ -157,6 +173,13 @@ module Cosmos
       begin
         @response_template = packet.read("RSP_TEMPLATE").strip
         @response_packet = packet.read("RSP_PACKET").strip
+        # If the template or packet are empty set them to nil. This allows for
+        # the user to remove the RSP_TEMPLATE and RSP_PACKET values and avoid
+        # any response timeouts
+        if @response_template.empty? || @response_packet.empty?
+          @response_template = nil
+          @response_packet = nil
+        end
       rescue
         # If there is no response template we set to nil
         @response_template = nil
@@ -174,8 +197,11 @@ module Cosmos
       data = raw_packet.buffer(false)
       # Scan the template for variables in brackets <VARIABLE>
       # Read these values from the packet and substitute them in the template
+      # and in the @response_packet name
       @template.scan(/<(.*?)>/).each do |variable|
-        data.gsub!("<#{variable[0]}>", packet.read(variable[0], :RAW).to_s)
+        value = packet.read(variable[0], :RAW).to_s
+        data.gsub!("<#{variable[0]}>", value)
+        @response_packet.gsub!("<#{variable[0]}>", value) if @response_packet
       end
 
       return raw_packet
@@ -196,7 +222,7 @@ module Cosmos
           sleep(@response_polling_period)
           retry if !response_timeout_time
           retry if response_timeout_time and Time.now < response_timeout_time
-          raise Timeout::Error, "Timeout waiting for response"
+          handle_error("#{@interface.name}: Timeout waiting for response")
         end
 
         @response_template = nil
@@ -205,5 +231,10 @@ module Cosmos
       end
       return super(packet, data)
     end
+
+    def handle_error(msg)
+      Logger.error(msg)
+      raise msg if @raise_exceptions
+    end
   end
 end

data/lib/cosmos/interfaces/udp_interface.rb

@@ -42,7 +42,7 @@ module Cosmos
       @hostname = ConfigParser.handle_nil(hostname)
       if @hostname
         @hostname = @hostname.to_s
-        @hostname = '127.0.0.1' if @hostname.casecmp('LOCALHOST')
+        @hostname = '127.0.0.1' if @hostname.casecmp('LOCALHOST').zero?
       end
       @write_dest_port = ConfigParser.handle_nil(write_dest_port)
       @write_dest_port = write_dest_port.to_i if @write_dest_port
@@ -51,7 +51,7 @@ module Cosmos
       @write_src_port = ConfigParser.handle_nil(write_src_port)
       @write_src_port = @write_src_port.to_i if @write_src_port
       @interface_address = ConfigParser.handle_nil(interface_address)
-      if @interface_address && @interface_address.casecmp('LOCALHOST')
+      if @interface_address && @interface_address.casecmp('LOCALHOST').zero?
         @interface_address = '127.0.0.1'
       end
       @ttl = ttl.to_i
@@ -61,7 +61,7 @@ module Cosmos
       @read_timeout = ConfigParser.handle_nil(read_timeout)
       @read_timeout = @read_timeout.to_f if @read_timeout
       @bind_address = ConfigParser.handle_nil(bind_address)
-      if @bind_address && @bind_address.casecmp('LOCALHOST')
+      if @bind_address && @bind_address.casecmp('LOCALHOST').zero?
         @bind_address = '127.0.0.1'
       end
       @write_socket = nil

data/lib/cosmos/packets/packet_config.rb

@@ -1283,6 +1283,7 @@ module Cosmos
 
       # Define the units of the current telemetry item
       when 'UNITS'
+        raise parser.error("Items with STATE can't define UNITS") if @current_item.states
         usage = "UNITS <FULL UNITS NAME> <ABBREVIATED UNITS NAME>"
         parser.verify_num_parameters(2, 2, usage)
         @current_item.units_full = params[0]

data/lib/cosmos/packets/parsers/format_string_parser.rb

@@ -14,6 +14,7 @@ module Cosmos
     # @param parser [ConfigParser] Configuration parser
     # @param item [Packet] The current item
     def self.parse(parser, item)
+      raise parser.error("Items with STATE can't define FORMAT_STRING") if item.states
       @parser = FormatStringParser.new(parser)
       @parser.verify_parameters()
       @parser.create_format_string(item)

data/lib/cosmos/packets/parsers/limits_parser.rb

@@ -18,6 +18,7 @@ module Cosmos
     # @param warnings [Array<String>] Array of string warnings which will be
     #   appended with any warnings found when parsing the limits
     def self.parse(parser, packet, cmd_or_tlm, item, warnings)
+      raise parser.error("Items with STATE can't define LIMITS") if item.states
       @parser = LimitsParser.new(parser)
       @parser.verify_parameters(cmd_or_tlm)
       @parser.create_limits(packet, item, warnings)

data/lib/cosmos/packets/parsers/state_parser.rb

@@ -20,6 +20,9 @@ module Cosmos
     # @param warnings [Array<String>] Array of string warnings which will be
     #   appended with any warnings found when parsing the limits
     def self.parse(parser, packet, cmd_or_tlm, item, warnings)
+      raise parser.error("Items with LIMITS can't define STATE") if item.limits.values
+      raise parser.error("Items with FORMAT_STRING can't define STATE") if item.format_string
+      raise parser.error("Items with UNITS can't define STATE") if item.units
       @parser = StateParser.new(parser)
       @parser.verify_parameters(cmd_or_tlm)
       @parser.create_state(packet, cmd_or_tlm, item, warnings)

data/lib/cosmos/packets/telemetry.rb

@@ -166,7 +166,7 @@ module Cosmos
     # @param packet_name (see #packet) The packet name.  LATEST is supported.
     # @return [Array<PacketItem>] The telemetry item names for the given target and packet name
     def item_names(target_name, packet_name)
-      if LATEST_PACKET_NAME.casecmp(packet_name) == 0
+      if LATEST_PACKET_NAME.casecmp(packet_name).zero?
         target_upcase = target_name.to_s.upcase
         target_latest_data = @config.latest_data[target_upcase]
         raise "Telemetry Target '#{target_upcase}' does not exist" unless target_latest_data

data/lib/cosmos/tools/cmd_sequence/cmd_sequence.rb

@@ -568,7 +568,7 @@ module Cosmos
     end
 
     # Finds the given filename by looking in the system sequences path as
-    # well as in each target's sequences directory. If the file can not be
+    # well as in each target's sequences directory. If the file can't be
     # found an Error dialog is created.
     # @param filename [String] Filename to locate
     def find_sequence(filename)

data/lib/cosmos/tools/cmd_tlm_server/limits_groups_background_task.rb

@@ -18,9 +18,10 @@ module Cosmos
     FUTURE_TIME = Time.new("3000")
     PAST_TIME = Time.new("1900")
 
-    def initialize(initial_delay = 0)
+    def initialize(initial_delay = 0, task_delay = 0.5)
       super()
       @initial_delay = Float(initial_delay)
+      @task_delay = Float(task_delay)
       @name = "Limits Groups"
       @groups = get_limits_groups()
       # Initialize all the group names as instance variables
@@ -87,9 +88,9 @@ module Cosmos
         check_methods.each {|method| self.send(method.intern) }
         now = Time.now
         @status = "#{now.formatted}: Checking groups took #{now - start}s"
-        sleep_time = 1 - (now - start)
+        sleep_time = @task_delay - (now - start)
         sleep_time = 0 if sleep_time < 0
-        broken = @sleeper.sleep(sleep_time) # Run the checks at 1Hz
+        broken = @sleeper.sleep(sleep_time)
         break if broken
       end
     end

data/lib/cosmos/tools/tlm_grapher/tabbed_plots_tool/tabbed_plots_config.rb

@@ -428,7 +428,7 @@ module Cosmos
               # Build the index into the hash of the form "TARGET_NAME PACKET_NAME"
               # Note that + is used to create a new object and then << is used to concatenate
               # to the new object.
-              if packet_name.casecmp(Telemetry::LATEST_PACKET_NAME) == 0
+              if packet_name.casecmp(Telemetry::LATEST_PACKET_NAME).zero?
                 packets = System.telemetry.latest_packets(target_name, data_object.item_name)
                 packets.each do |packet|
                   index = (packet.target_name + ' ') << packet.packet_name

data/lib/cosmos/tools/tlm_viewer/screen.rb

@@ -329,7 +329,7 @@ module Cosmos
       end
 
       unless @widgets.invalid.empty?
-        Qt::MessageBox.information(self, "Screen #{@full_name}", "The following telemetry items could not be created: \n" + @widgets.invalid.join("\n"))
+        Qt::MessageBox.information(self, "Screen #{@full_name}", "In #{filename}, the following telemetry items could not be created: \n" + @widgets.invalid.join("\n"))
       end
 
       # Process all settings before we show the screen
@@ -383,8 +383,8 @@ module Cosmos
             System.telemetry.packet_and_item(*parameters[0..2])
             widget = klass.new(layout_stack[-1], *parameters)
           end
-        rescue
-          @widgets.invalid << parameters.join(" ")
+        rescue => err
+          @widgets.invalid << "#{parser.line_number}: #{parameters.join(" ").strip} due to #{err.message}"
           return nil
         end
       else

data/lib/cosmos/tools/tlm_viewer/widgets/formatfontvalue_widget.rb

@@ -12,25 +12,20 @@ require 'cosmos'
 require 'cosmos/tools/tlm_viewer/widgets/formatvalue_widget'
 
 module Cosmos
-
-  # FormatfontvalueWidget class
-  #
   # This class implements a value with configurable font values.  The font
   # can also be updated after it is created.
   # It inherits from the FormatvalueWidget class.
   class FormatfontvalueWidget < FormatvalueWidget
-
-    def initialize (parent_layout, target_name, packet_name, item_name, format_string, value_type = :CONVERTED, characters = 12,
-      font_name = 'arial', font_size = 100, font_weight = Qt::Font::Normal, font_slant = false)
+    def initialize(parent_layout, target_name, packet_name, item_name, format_string,
+                   value_type = :CONVERTED, characters = 12, font_name = 'arial',
+                   font_size = 100, font_weight = Qt::Font::Normal, font_italics = false)
       super(parent_layout, target_name, packet_name, item_name, format_string, value_type, characters)
-      setFont(Cosmos.getFont(font_name, font_size.to_i, font_weight, font_slant))
+      setFont(Cosmos.getFont(font_name, font_size.to_i, font_weight, font_italics))
       setFixedWidth(self.fontMetrics.width('X') * characters.to_i + 10)
     end
 
     def font=(font)
       setFont(font)
     end
-
   end
-
-end # module Cosmos
+end

data/lib/cosmos/tools/tlm_viewer/widgets/limits_widget.rb

@@ -20,7 +20,7 @@ module Cosmos
 
     def initialize(parent_layout, target_name, packet_name, item_name, value_type, width, height)
       super(target_name, packet_name, item_name, value_type)
-      @value_type = :CONVERTED if @value_type == :WITH_UNITS
+      raise "Invalid value_type #{@value_type} for LimitsWidget" if @value_type == :RAW
       @width = width.to_i
       @height = height.to_i
       @value = 0

data/lib/cosmos/tools/tlm_viewer/widgets/matrixbycolumns_widget.rb

@@ -17,11 +17,13 @@ module Cosmos
     include Widget
     include LayoutWidget
 
-    def initialize(parent_layout, num_columns, hSpacing = 0, vSpacing = 0)
+    def initialize(parent_layout, num_columns, horizontal_spacing = 0, vertical_spacing = 0)
       super()
       @num_columns = num_columns.to_i
       @row = 0
       @column = 0
+      setHorizontalSpacing(horizontal_spacing.to_i)
+      setVerticalSpacing(vertical_spacing.to_i)
       parent_layout.addLayout(self) if parent_layout
     end
 

data/lib/cosmos/top_level.rb

@@ -607,8 +607,7 @@ module Cosmos
   #
   # @param class_name_or_class_filename [String] The name of the class or the file which contains the
   #   Ruby class to require
-  # @param log_error [Boolean] Whether to log an error if we can not require
-  #   the class
+  # @param log_error [Boolean] Whether to log an error if we can't require the class
   def self.require_class(class_name_or_class_filename, log_error = true)
     if class_name_or_class_filename.downcase[-3..-1] == '.rb' or (class_name_or_class_filename[0] == class_name_or_class_filename[0].downcase)
       class_filename = class_name_or_class_filename
@@ -627,8 +626,7 @@ module Cosmos
   # Requires a file with a standard error message if it fails
   #
   # @param filename [String] The name of the file to require
-  # @param log_error [Boolean] Whether to log an error if we can not require
-  #   the class
+  # @param log_error [Boolean] Whether to log an error if we can't require the class
   def self.require_file(filename, log_error = true)
     begin
       require filename

data/lib/cosmos/utilities/csv.rb

@@ -25,7 +25,7 @@ module Cosmos
       @archive = nil
       @archive_file = ""
       Object::CSV.read(input_file).each do |line|
-        @hash[line[0]] = line[1..-1].compact
+        @hash[line[0]] = line[1..-1]
       end
     end
 

data/lib/cosmos/version.rb

@@ -1,12 +1,12 @@
 # encoding: ascii-8bit
 
-COSMOS_VERSION = '4.0.1'
+COSMOS_VERSION = '4.0.2'
 module Cosmos
   module Version
     MAJOR = '4'
     MINOR = '0'
-    PATCH = '1'
-    BUILD = '012697c6665f9dd1c47b86ed75b21c9bc928973f'
+    PATCH = '2'
+    BUILD = 'e9da0b19c0c72edef48b0717440a06c0da1d5690'
   end
-  VERSION = '4.0.1'
+  VERSION = '4.0.2'
 end

data/spec/interfaces/protocols/template_protocol_spec.rb

@@ -12,6 +12,7 @@ require 'spec_helper'
 require 'cosmos/interfaces/protocols/template_protocol'
 require 'cosmos/interfaces/interface'
 require 'cosmos/streams/stream'
+require 'cosmos/utilities/logger'
 
 module Cosmos
   describe TemplateProtocol do
@@ -33,7 +34,7 @@ module Cosmos
 
     describe "initialize" do
       it "initializes attributes" do
-        @interface.add_protocol(TemplateProtocol, ['0xABCD','0xABCD'], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD), :READ_WRITE)
         expect(@interface.read_protocols[0].instance_variable_get(:@data)).to eq ''
       end
     end
@@ -41,7 +42,7 @@ module Cosmos
     describe "connect" do
       it "supports an initial read delay" do
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xABCD', '0xABCD', 0, 2], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD 0 2), :READ_WRITE)
         time = Time.now
         @interface.connect
         expect(@interface.read_protocols[0].instance_variable_get(:@connect_complete_time)).to be >= time + 2.0
@@ -51,7 +52,7 @@ module Cosmos
     describe "disconnect" do
       it "unblocks writes waiting for responses" do
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xABCD', '0xABCD'], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD), :READ_WRITE)
         packet = Packet.new('TGT', 'CMD')
         packet.append_item("CMD_TEMPLATE", 1024, :STRING)
         packet.get_item("CMD_TEMPLATE").default = "SOUR:VOLT"
@@ -72,7 +73,7 @@ module Cosmos
     describe "read_data" do
       it "ignores all data during the connect period" do
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xABCD', '0xABCD', 0, 1.5], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD 0 1.5), :READ_WRITE)
         start = Time.now
         @interface.connect
         $read_buffer = "\x31\x30\xAB\xCD"
@@ -85,7 +86,7 @@ module Cosmos
     describe "write" do
       it "waits before writing during the initial delay period" do
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xABCD','0xABCD',0,1.5], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD 0 1.5), :READ_WRITE)
         packet = Packet.new('TGT', 'CMD')
         packet.append_item("VOLTAGE", 16, :UINT)
         packet.get_item("VOLTAGE").default = 1
@@ -102,7 +103,7 @@ module Cosmos
 
       it "works without a response" do
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xABCD','0xABCD'], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD), :READ_WRITE)
         packet = Packet.new('TGT', 'CMD')
         packet.append_item("VOLTAGE", 16, :UINT)
         packet.get_item("VOLTAGE").default = 1
@@ -115,9 +116,9 @@ module Cosmos
         expect($write_buffer).to eql("SOUR:VOLT 1, (@2)\xAB\xCD")
       end
 
-      it "times out if it doesn't receive a response" do
+      it "logs an error if it doesn't receive a response" do
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xA','0xA',0,nil,1,true,0,nil,false,1.5], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xA 0xA 0 nil 1 true 0 nil false 1.5), :READ_WRITE)
         @interface.target_names = ['TGT']
         packet = Packet.new('TGT', 'CMD')
         packet.append_item("CMD_TEMPLATE", 1024, :STRING)
@@ -129,23 +130,61 @@ module Cosmos
         packet.restore_defaults
         @interface.connect
         start = Time.now
-        expect { @interface.write(packet) }.to raise_error(Timeout::Error)
+        logger = class_double("Cosmos::Logger").as_stubbed_const(:transfer_nested_constants => true)
+        expect(logger).to receive(:error).with("StreamInterface: Timeout waiting for response")
+        @interface.write(packet)
         expect(Time.now - start).to be_within(0.1).of(1.5)
       end
 
+      it "disconnects if it doesn't receive a response" do
+        @interface.instance_variable_set(:@stream, TemplateStream.new)
+        @interface.add_protocol(TemplateProtocol, %w(0xA 0xA 0 nil 1 true 0 nil false 1.5 0.02 true), :READ_WRITE)
+        @interface.target_names = ['TGT']
+        packet = Packet.new('TGT', 'CMD')
+        packet.append_item("CMD_TEMPLATE", 1024, :STRING)
+        packet.get_item("CMD_TEMPLATE").default = "GO"
+        packet.append_item("RSP_TEMPLATE", 1024, :STRING)
+        packet.get_item("RSP_TEMPLATE").default = "<VOLTAGE>"
+        packet.append_item("RSP_PACKET", 1024, :STRING)
+        packet.get_item("RSP_PACKET").default = "DATA"
+        packet.restore_defaults
+        @interface.connect
+        start = Time.now
+        expect { @interface.write(packet) }.to raise_error(/Timeout waiting for response/)
+        expect(Time.now - start).to be_within(0.1).of(1.5)
+      end
+
+      it "doesn't expect responses for empty response fields" do
+        @interface.instance_variable_set(:@stream, TemplateStream.new)
+        @interface.add_protocol(TemplateProtocol, %w(0xA 0xA 0 nil 1 true 0 nil false nil), :READ_WRITE)
+        @interface.target_names = ['TGT']
+        packet = Packet.new('TGT', 'CMD')
+        packet.append_item("CMD_TEMPLATE", 1024, :STRING)
+        packet.get_item("CMD_TEMPLATE").default = "GO"
+        packet.append_item("RSP_TEMPLATE", 1024, :STRING)
+        packet.get_item("RSP_TEMPLATE").default = ""
+        packet.append_item("RSP_PACKET", 1024, :STRING)
+        packet.get_item("RSP_PACKET").default = ""
+        packet.restore_defaults
+        @interface.connect
+        start = Time.now
+        logger = class_double("Cosmos::Logger").as_stubbed_const(:transfer_nested_constants => true)
+        expect(logger).to_not receive(:error)
+        @interface.write(packet)
+      end
+
       it "processes responses" do
         rsp_pkt = Packet.new('TGT', 'READ_VOLTAGE')
         rsp_pkt.append_item("VOLTAGE", 16, :UINT)
         allow(System).to receive_message_chain(:telemetry, :packet).and_return(rsp_pkt)
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xABCD','0xABCD', 0, nil, 1, true, 0, nil, false, nil, nil], :READ_WRITE)
-      #@interface.add_protocol(TemplateProtocol, ['0xABCD','0xABCD'], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD 0 nil 1 true 0 nil false nil nil), :READ_WRITE)
         @interface.target_names = ['TGT']
         packet = Packet.new('TGT', 'CMD')
         packet.append_item("VOLTAGE", 16, :UINT)
         packet.get_item("VOLTAGE").default = 11
         packet.append_item("CHANNEL", 16, :UINT)
-        packet.get_item("CHANNEL").default = 20
+        packet.get_item("CHANNEL").default = 1
         packet.append_item("CMD_TEMPLATE", 1024, :STRING)
         packet.get_item("CMD_TEMPLATE").default = "SOUR:VOLT <VOLTAGE>, (@<CHANNEL>)"
         packet.append_item("RSP_TEMPLATE", 1024, :STRING)
@@ -158,16 +197,81 @@ module Cosmos
         $read_buffer = "\x31\x30\xAB\xCD" # ASCII 31, 30 is '10'
         Thread.new { sleep(0.5); read_result = @interface.read }
         @interface.write(packet)
-        expect($write_buffer).to eql("SOUR:VOLT 11, (@20)\xAB\xCD")
+        sleep 0.55
+        expect($write_buffer).to eql("SOUR:VOLT 11, (@1)\xAB\xCD")
         expect(read_result.read("VOLTAGE")).to eq 10
       end
 
+      it "handles templates with more values than the response" do
+        rsp_pkt = Packet.new('TGT', 'READ_VOLTAGE')
+        rsp_pkt.append_item("VOLTAGE", 16, :UINT)
+        allow(System).to receive_message_chain(:telemetry, :packet).and_return(rsp_pkt)
+        @interface.instance_variable_set(:@stream, TemplateStream.new)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD 0 nil 1 true 0 nil false nil), :READ_WRITE)
+        @interface.target_names = ['TGT']
+        packet = Packet.new('TGT', 'CMD')
+        packet.append_item("VOLTAGE", 16, :UINT)
+        packet.get_item("VOLTAGE").default = 12
+        packet.append_item("CHANNEL", 16, :UINT)
+        packet.get_item("CHANNEL").default = 2
+        packet.append_item("CMD_TEMPLATE", 1024, :STRING)
+        packet.get_item("CMD_TEMPLATE").default = "SOUR:VOLT <VOLTAGE>, (@<CHANNEL>)"
+        packet.append_item("RSP_TEMPLATE", 1024, :STRING)
+        packet.get_item("RSP_TEMPLATE").default = "<VOLTAGE>;<CURRENT>"
+        packet.append_item("RSP_PACKET", 1024, :STRING)
+        packet.get_item("RSP_PACKET").default = "READ_VOLTAGE"
+        packet.restore_defaults
+        @interface.connect
+        read_result = nil
+        $read_buffer = "\x31\x30\xAB\xCD" # ASCII 31, 30 is '10'
+        Thread.new { sleep(0.5); read_result = @interface.read }
+        logger = class_double("Cosmos::Logger").as_stubbed_const(:transfer_nested_constants => true)
+        expect(logger).to receive(:error) do |arg|
+          expect(arg).to match(/Unexpected response: 10/)
+        end
+        @interface.write(packet)
+        sleep 0.55
+        expect($write_buffer).to eql("SOUR:VOLT 12, (@2)\xAB\xCD")
+      end
+
+      it "handles responses with more values than the template" do
+        rsp_pkt = Packet.new('TGT', 'READ_VOLTAGE')
+        rsp_pkt.append_item("VOLTAGE", 16, :UINT)
+        allow(System).to receive_message_chain(:telemetry, :packet).and_return(rsp_pkt)
+        @interface.instance_variable_set(:@stream, TemplateStream.new)
+        @interface.add_protocol(TemplateProtocol, %w(0xABCD 0xABCD 0 nil 1 true 0 nil false nil), :READ_WRITE)
+        @interface.target_names = ['TGT']
+        packet = Packet.new('TGT', 'CMD')
+        packet.append_item("VOLTAGE", 16, :UINT)
+        packet.get_item("VOLTAGE").default = 12
+        packet.append_item("CHANNEL", 16, :UINT)
+        packet.get_item("CHANNEL").default = 2
+        packet.append_item("CMD_TEMPLATE", 1024, :STRING)
+        packet.get_item("CMD_TEMPLATE").default = "SOUR:VOLT <VOLTAGE>, (@<CHANNEL>)"
+        packet.append_item("RSP_TEMPLATE", 1024, :STRING)
+        packet.get_item("RSP_TEMPLATE").default = "<VOLTAGE>"
+        packet.append_item("RSP_PACKET", 1024, :STRING)
+        packet.get_item("RSP_PACKET").default = "READ_VOLTAGE"
+        packet.restore_defaults
+        @interface.connect
+        read_result = nil
+        $read_buffer = "\x31\x30\x3B\x31\x31\xAB\xCD" # ASCII is '10;11'
+        Thread.new { sleep(0.5); read_result = @interface.read }
+        logger = class_double("Cosmos::Logger").as_stubbed_const(:transfer_nested_constants => true)
+        expect(logger).to receive(:error) do |arg|
+          expect(arg).to match(/Could not write value 10;11/)
+        end
+        @interface.write(packet)
+        sleep 0.55
+        expect($write_buffer).to eql("SOUR:VOLT 12, (@2)\xAB\xCD")
+      end
+
       it "ignores response lines" do
         rsp_pkt = Packet.new('TGT', 'READ_VOLTAGE')
         rsp_pkt.append_item("VOLTAGE", 16, :UINT)
         allow(System).to receive_message_chain(:telemetry, :packet).and_return(rsp_pkt)
         @interface.instance_variable_set(:@stream, TemplateStream.new)
-        @interface.add_protocol(TemplateProtocol, ['0xAD','0xA', 1], :READ_WRITE)
+        @interface.add_protocol(TemplateProtocol, %w(0xAD 0xA 1), :READ_WRITE)
         @interface.target_names = ['TGT']
         packet = Packet.new('TGT', 'CMD')
         packet.append_item("VOLTAGE", 16, :UINT)
@@ -196,7 +300,7 @@ module Cosmos
       rsp_pkt.append_item("STRING", 512, :STRING)
       allow(System).to receive_message_chain(:telemetry, :packet).and_return(rsp_pkt)
       @interface.instance_variable_set(:@stream, TemplateStream.new)
-      @interface.add_protocol(TemplateProtocol, ['0xAD','0xA', 0, nil, 2], :READ_WRITE)
+      @interface.add_protocol(TemplateProtocol, %w(0xAD 0xA 0 nil 2), :READ_WRITE)
       @interface.target_names = ['TGT']
       packet = Packet.new('TGT', 'CMD')
       packet.append_item("CMD_TEMPLATE", 1024, :STRING)