cookstyle 7.7.2 → 7.8.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/config/cookstyle.yml +7 -3
- data/config/disable_all.yml +4 -0
- data/config/upstream.yml +38 -16
- data/lib/cookstyle/version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +4 -4
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +3 -4
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -3
- data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +6 -6
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +3 -5
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +5 -5
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +3 -1
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +6 -4
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +2 -4
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +2 -3
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +3 -4
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +3 -4
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +3 -5
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +3 -5
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +3 -4
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +6 -4
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +4 -2
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +4 -2
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +4 -2
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +2 -3
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +3 -1
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +2 -2
- data/lib/rubocop/cop/chef/style/attribute_keys.rb +4 -4
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +9 -9
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_format.rb +2 -2
- data/lib/rubocop/cop/chef/style/file_mode.rb +2 -2
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -2
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +2 -2
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -2
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +2 -2
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +2 -2
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +2 -2
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +2 -2
- metadata +4 -4
@@ -24,7 +24,7 @@ module RuboCop
|
|
24
24
|
#
|
25
25
|
# @example
|
26
26
|
#
|
27
|
-
#
|
27
|
+
# #### incorrect
|
28
28
|
# apt_repository 'atom-ppa' do
|
29
29
|
# uri 'http://ppa.launchpad.net/webupd8team/atom/ubuntu'
|
30
30
|
# components ['main']
|
@@ -32,7 +32,7 @@ module RuboCop
|
|
32
32
|
# key 'C2518248EEA14886'
|
33
33
|
# end
|
34
34
|
#
|
35
|
-
#
|
35
|
+
# #### correct
|
36
36
|
# apt_repository 'atom-ppa' do
|
37
37
|
# uri 'ppa:webupd8team/atom'
|
38
38
|
# components ['main']
|
@@ -21,12 +21,14 @@ module RuboCop
|
|
21
21
|
module Modernize
|
22
22
|
# The sysctl_param resource was renamed to sysctl when it was added to Chef Infra Client 14.0. The new resource name should be used.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# sysctl_param 'fs.aio-max-nr' do
|
26
28
|
# value '1048576'
|
27
29
|
# end
|
28
30
|
#
|
29
|
-
#
|
31
|
+
# #### correct
|
30
32
|
# sysctl 'fs.aio-max-nr' do
|
31
33
|
# value '1048576'
|
32
34
|
# end
|
@@ -23,14 +23,14 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# %w(bmon htop vim curl).each do |pkg|
|
28
28
|
# package pkg do
|
29
29
|
# action :install
|
30
30
|
# end
|
31
31
|
# end
|
32
32
|
#
|
33
|
-
#
|
33
|
+
# #### correct
|
34
34
|
# package %w(bmon htop vim curl)
|
35
35
|
#
|
36
36
|
class UseMultipackageInstalls < Base
|
@@ -23,10 +23,10 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# require File.expand_path('../../libraries/helpers', __FILE__)
|
28
28
|
#
|
29
|
-
#
|
29
|
+
# #### correct
|
30
30
|
# require_relative '../libraries/helpers'
|
31
31
|
#
|
32
32
|
class UseRequireRelative < Base
|
@@ -21,7 +21,9 @@ module RuboCop
|
|
21
21
|
module Modernize
|
22
22
|
# Chef Infra Client 15.0 and later includes a windows_uac resource that should be used to set Windows UAC values instead of setting registry keys directly.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# registry_key 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\System' do
|
26
28
|
# values [{ name: 'EnableLUA', type: :dword, data: 0 },
|
27
29
|
# { name: 'PromptOnSecureDesktop', type: :dword, data: 0 },
|
@@ -30,7 +32,7 @@ module RuboCop
|
|
30
32
|
# action :create
|
31
33
|
# end
|
32
34
|
#
|
33
|
-
#
|
35
|
+
# #### correct
|
34
36
|
# windows_uac 'Set Windows UAC settings' do
|
35
37
|
# enable_uac false
|
36
38
|
# prompt_on_secure_desktop true
|
@@ -23,7 +23,7 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# zypper_repo 'apache' do
|
28
28
|
# baseurl 'http://download.opensuse.org/repositories/Apache'
|
29
29
|
# path '/openSUSE_Leap_42.2'
|
@@ -31,7 +31,7 @@ module RuboCop
|
|
31
31
|
# priority '100'
|
32
32
|
# end
|
33
33
|
#
|
34
|
-
#
|
34
|
+
# #### correct
|
35
35
|
# zypper_repository 'apache' do
|
36
36
|
# baseurl 'http://download.opensuse.org/repositories/Apache'
|
37
37
|
# path '/openSUSE_Leap_42.2'
|
@@ -21,7 +21,9 @@ module RuboCop
|
|
21
21
|
module RedundantCode
|
22
22
|
# There is no need to pass `distribution node['lsb']['codename']` to an apt_repository resource as this is done automatically by the apt_repository resource.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# apt_repository 'my repo' do
|
26
28
|
# uri 'http://packages.example.com/debian'
|
27
29
|
# components %w(stable main)
|
@@ -29,7 +31,7 @@ module RuboCop
|
|
29
31
|
# distribution node['lsb']['codename']
|
30
32
|
# end
|
31
33
|
#
|
32
|
-
#
|
34
|
+
# #### correct
|
33
35
|
# apt_repository 'my repo' do
|
34
36
|
# uri 'http://packages.example.com/debian'
|
35
37
|
# components %w(stable main)
|
@@ -21,7 +21,9 @@ module RuboCop
|
|
21
21
|
module RedundantCode
|
22
22
|
# There is no need to notify an apt-get update when an apt_repository is created as this is done automatically by the apt_repository resource.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# apt_repository 'my repo' do
|
26
28
|
# uri 'http://packages.example.com/debian'
|
27
29
|
# components %w(stable main)
|
@@ -29,7 +31,7 @@ module RuboCop
|
|
29
31
|
# notifies :run, 'execute[apt-get update]', :immediately
|
30
32
|
# end
|
31
33
|
#
|
32
|
-
#
|
34
|
+
# #### correct
|
33
35
|
# apt_repository 'my repo' do
|
34
36
|
# uri 'http://packages.example.com/debian'
|
35
37
|
# components %w(stable main)
|
@@ -21,13 +21,15 @@ module RuboCop
|
|
21
21
|
module RedundantCode
|
22
22
|
# If a resource includes the `compile_time` property there's no need to also use `.run_action(:some_action)` on the resource block
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# chef_gem 'deep_merge' do
|
26
28
|
# action :nothing
|
27
29
|
# compile_time true
|
28
30
|
# end.run_action(:install)
|
29
31
|
#
|
30
|
-
#
|
32
|
+
# #### correct
|
31
33
|
# chef_gem 'deep_merge' do
|
32
34
|
# action :install
|
33
35
|
# compile_time true
|
@@ -24,11 +24,11 @@ module RuboCop
|
|
24
24
|
#
|
25
25
|
# @example
|
26
26
|
#
|
27
|
-
#
|
27
|
+
# #### incorrect
|
28
28
|
# platform?('redhat') || platform?('ubuntu')
|
29
29
|
# platform_family?('debian') || platform_family?('rhel')
|
30
30
|
#
|
31
|
-
#
|
31
|
+
# #### correct
|
32
32
|
# platform?('redhat', 'ubuntu')
|
33
33
|
# platform_family?('debian', 'rhel')
|
34
34
|
#
|
@@ -51,12 +51,11 @@ module RuboCop
|
|
51
51
|
#
|
52
52
|
# @example
|
53
53
|
#
|
54
|
-
#
|
55
|
-
# # bad
|
54
|
+
# #### incorrect
|
56
55
|
# property :config_file, String, required: true, name_property: true
|
57
56
|
# attribute :config_file, String, required: true, name_attribute: true
|
58
57
|
#
|
59
|
-
#
|
58
|
+
# #### correct
|
60
59
|
# property :config_file, String, required: true
|
61
60
|
#
|
62
61
|
class NamePropertyIsRequired < Base
|
@@ -24,7 +24,7 @@ module RuboCop
|
|
24
24
|
#
|
25
25
|
# @example
|
26
26
|
#
|
27
|
-
#
|
27
|
+
# #### incorrect
|
28
28
|
# node['platform'].to_s
|
29
29
|
# node['platform_family'].to_s
|
30
30
|
# node['platform_version'].to_s
|
@@ -33,7 +33,7 @@ module RuboCop
|
|
33
33
|
# node['os'].to_s
|
34
34
|
# node['name'].to_s
|
35
35
|
#
|
36
|
-
#
|
36
|
+
# #### correct
|
37
37
|
# node['platform']
|
38
38
|
# node['platform_family']
|
39
39
|
# node['platform_version']
|
@@ -23,11 +23,11 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# property :config_file, String, regex: /.*/
|
28
28
|
# attribute :config_file, String, regex: /.*/
|
29
29
|
#
|
30
|
-
#
|
30
|
+
# #### correct
|
31
31
|
# property :config_file, String
|
32
32
|
# attribute :config_file, String
|
33
33
|
#
|
@@ -26,10 +26,10 @@ module RuboCop
|
|
26
26
|
#
|
27
27
|
# @example
|
28
28
|
#
|
29
|
-
#
|
29
|
+
# #### incorrect
|
30
30
|
# property :bob, String, required: true, default: 'foo'
|
31
31
|
#
|
32
|
-
#
|
32
|
+
# #### correct
|
33
33
|
# property :bob, String, required: true
|
34
34
|
#
|
35
35
|
class PropertyWithRequiredAndDefault < Base
|
@@ -21,7 +21,9 @@ module RuboCop
|
|
21
21
|
module RedundantCode
|
22
22
|
# Every Chef Infra resource already includes a sensitive property with a default value of false.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# property :sensitive, [true, false], default: false
|
26
28
|
#
|
27
29
|
class SensitivePropertyInResource < Base
|
@@ -23,11 +23,11 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# property :config_file, String, default: nil
|
28
28
|
# property :config_file, [String, NilClass], default: nil
|
29
29
|
#
|
30
|
-
#
|
30
|
+
# #### correct
|
31
31
|
# property :config_file, String
|
32
32
|
# property :config_file, [String, NilClass]
|
33
33
|
#
|
@@ -23,11 +23,11 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# property :foo, String, desired_state: true
|
28
28
|
# attribute :foo, String, desired_state: true
|
29
29
|
#
|
30
|
-
#
|
30
|
+
# #### correct
|
31
31
|
# property :foo, String
|
32
32
|
# attribute :foo, String
|
33
33
|
#
|