cookstyle 7.7.2 → 7.8.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/config/cookstyle.yml +7 -3
- data/config/disable_all.yml +4 -0
- data/config/upstream.yml +38 -16
- data/lib/cookstyle/version.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +4 -4
- data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/property_without_type.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +3 -4
- data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
- data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +2 -2
- data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -3
- data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +4 -4
- data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +3 -3
- data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +6 -6
- data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
- data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +3 -5
- data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +5 -5
- data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +3 -3
- data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +3 -1
- data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +6 -4
- data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +2 -4
- data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +5 -4
- data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +2 -3
- data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +3 -4
- data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +3 -4
- data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +3 -5
- data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +3 -5
- data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +3 -4
- data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +6 -4
- data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
- data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +4 -2
- data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
- data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +4 -2
- data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +4 -2
- data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +4 -2
- data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +2 -3
- data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +3 -1
- data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -2
- data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
- data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
- data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +2 -2
- data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +2 -2
- data/lib/rubocop/cop/chef/style/attribute_keys.rb +4 -4
- data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +9 -9
- data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -2
- data/lib/rubocop/cop/chef/style/comments_format.rb +2 -2
- data/lib/rubocop/cop/chef/style/file_mode.rb +2 -2
- data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -2
- data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +2 -2
- data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -2
- data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -2
- data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +2 -2
- data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
- data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +2 -2
- data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +2 -2
- data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +2 -2
- metadata +4 -4
@@ -23,7 +23,7 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# ::File.open('/proc/1/comm').gets.chomp == 'systemd'
|
28
28
|
# ::File.open('/proc/1/comm').chomp == 'systemd'
|
29
29
|
# File.open('/proc/1/comm').gets.chomp == 'systemd'
|
@@ -35,7 +35,7 @@ module RuboCop
|
|
35
35
|
# File.exist?('/proc/1/comm') && File.open('/proc/1/comm').chomp == 'systemd'
|
36
36
|
# only_if 'test -f /bin/systemctl && /bin/systemctl'
|
37
37
|
#
|
38
|
-
#
|
38
|
+
# #### correct
|
39
39
|
# node['init_package'] == 'systemd'
|
40
40
|
# only_if { node['init_package'] == 'systemd' }
|
41
41
|
#
|
@@ -19,13 +19,11 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# The Ohai default recipe previously allowed a user to ship custom Ohai plugins to a system by including them
|
23
|
-
# in a directory in the Ohai cookbook. This functionality was replaced with the ohai_plugin resource, which
|
24
|
-
# should be used instead as it doesn't require forking the ohai cookbook.
|
22
|
+
# The Ohai default recipe previously allowed a user to ship custom Ohai plugins to a system by including them in a directory in the Ohai cookbook. This functionality was replaced with the ohai_plugin resource, which should be used instead as it doesn't require forking the ohai cookbook.
|
25
23
|
#
|
26
24
|
# @example
|
27
25
|
#
|
28
|
-
#
|
26
|
+
# #### incorrect
|
29
27
|
# include_recipe 'ohai::default'
|
30
28
|
# include_recipe 'ohai'
|
31
29
|
#
|
@@ -19,15 +19,16 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef
|
23
|
-
# Infra Client 14.0. The new resource name should be used.
|
22
|
+
# The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef Infra Client 14.0. The new resource name should be used.
|
24
23
|
#
|
25
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
26
27
|
# openssl_rsa_key '/etc/httpd/ssl/server.key' do
|
27
28
|
# key_length 2048
|
28
29
|
# end
|
29
30
|
#
|
30
|
-
#
|
31
|
+
# #### correct
|
31
32
|
# openssl_rsa_private_key '/etc/httpd/ssl/server.key' do
|
32
33
|
# key_length 2048
|
33
34
|
# end
|
@@ -19,10 +19,11 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# The openssl_x509 resource was renamed to openssl_x509_certificate in Chef Infra Client 14.4.
|
23
|
-
# The new resource name should be used.
|
22
|
+
# The openssl_x509 resource was renamed to openssl_x509_certificate in Chef Infra Client 14.4. The new resource name should be used.
|
24
23
|
#
|
25
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
26
27
|
# openssl_x509 '/etc/httpd/ssl/mycert.pem' do
|
27
28
|
# common_name 'www.f00bar.com'
|
28
29
|
# org 'Foo Bar'
|
@@ -30,7 +31,7 @@ module RuboCop
|
|
30
31
|
# country 'US'
|
31
32
|
# end
|
32
33
|
#
|
33
|
-
#
|
34
|
+
# #### correct
|
34
35
|
# openssl_x509_certificate '/etc/httpd/ssl/mycert.pem' do
|
35
36
|
# common_name 'www.f00bar.com'
|
36
37
|
# org 'Foo Bar'
|
@@ -19,15 +19,16 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# The osx_config_profile resource was renamed to osx_profile.
|
23
|
-
# The new resource name should be used.
|
22
|
+
# The osx_config_profile resource was renamed to osx_profile. The new resource name should be used.
|
24
23
|
#
|
25
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
26
27
|
# osx_config_profile 'Install screensaver profile' do
|
27
28
|
# profile 'screensaver/com.company.screensaver.mobileconfig'
|
28
29
|
# end
|
29
30
|
#
|
30
|
-
#
|
31
|
+
# #### correct
|
31
32
|
# osx_profile 'Install screensaver profile' do
|
32
33
|
# profile 'screensaver/com.company.screensaver.mobileconfig'
|
33
34
|
# end
|
@@ -19,12 +19,11 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# Use the archive_file resource built into Chef Infra Client 15+ instead of using the powershell_script
|
23
|
-
# resource to run Expand-Archive
|
22
|
+
# Use the archive_file resource built into Chef Infra Client 15+ instead of using the powershell_script resource to run Expand-Archive
|
24
23
|
#
|
25
24
|
# @example
|
26
25
|
#
|
27
|
-
#
|
26
|
+
# #### incorrect
|
28
27
|
# powershell_script 'Expand website' do
|
29
28
|
# code 'Expand-Archive "C:\\file.zip" -DestinationPath "C:\\inetpub\\wwwroot\\" -Force'
|
30
29
|
# end
|
@@ -23,7 +23,7 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# powershell_script 'Create Directory' do
|
28
28
|
# code "New-Item -ItemType Directory -Force -Path C:\mydir"
|
29
29
|
# guard_interpreter :powershell_script
|
@@ -34,7 +34,7 @@ module RuboCop
|
|
34
34
|
# guard_interpreter :powershell_script
|
35
35
|
# end
|
36
36
|
#
|
37
|
-
#
|
37
|
+
# #### correct
|
38
38
|
# powershell_script 'Create Directory' do
|
39
39
|
# code "New-Item -ItemType Directory -Force -Path C:\mydir"
|
40
40
|
# end
|
@@ -19,17 +19,16 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# Use the powershell_package resource built into Chef Infra Client instead of the powershell_script
|
23
|
-
# resource to run Install-Package
|
22
|
+
# Use the powershell_package resource built into Chef Infra Client instead of the powershell_script resource to run Install-Package
|
24
23
|
#
|
25
24
|
# @example
|
26
25
|
#
|
27
|
-
#
|
26
|
+
# #### incorrect
|
28
27
|
# powershell_script 'Expand website' do
|
29
28
|
# code 'Install-Package -Name docker'
|
30
29
|
# end
|
31
30
|
#
|
32
|
-
#
|
31
|
+
# #### correct
|
33
32
|
# powershell_package 'docker'
|
34
33
|
#
|
35
34
|
class PowershellInstallPackage < Base
|
@@ -19,17 +19,16 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# Use the windows_feature resource built into Chef Infra Client 14+ instead of the powershell_script resource
|
23
|
-
# to run Install-WindowsFeature or Add-WindowsFeature
|
22
|
+
# Use the windows_feature resource built into Chef Infra Client 14+ instead of the powershell_script resource to run Install-WindowsFeature or Add-WindowsFeature
|
24
23
|
#
|
25
24
|
# @example
|
26
25
|
#
|
27
|
-
#
|
26
|
+
# #### incorrect
|
28
27
|
# powershell_script 'Install Feature' do
|
29
28
|
# code 'Install-WindowsFeature -Name "Net-framework-Core"'
|
30
29
|
# end
|
31
30
|
#
|
32
|
-
#
|
31
|
+
# #### correct
|
33
32
|
# windows_feature 'Net-framework-Core' do
|
34
33
|
# action :install
|
35
34
|
# install_method :windows_feature_powershell
|
@@ -23,10 +23,10 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# property :bob, String, name_attribute: true
|
28
28
|
#
|
29
|
-
#
|
29
|
+
# #### correct
|
30
30
|
# property :bob, String, name_property: true
|
31
31
|
#
|
32
32
|
class PropertyWithNameAttribute < Base
|
@@ -23,13 +23,13 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# def initialize(*args)
|
28
28
|
# super
|
29
29
|
# @resource_name = :foo
|
30
30
|
# end
|
31
31
|
#
|
32
|
-
#
|
32
|
+
# #### correct
|
33
33
|
# resource_name :create
|
34
34
|
|
35
35
|
class ResourceNameFromInitialize < Base
|
@@ -20,13 +20,11 @@ module RuboCop
|
|
20
20
|
module Cop
|
21
21
|
module Chef
|
22
22
|
module Modernize
|
23
|
-
# set_or_return within a method should not be used to define property in a resource. Instead use
|
24
|
-
# the property method which properly validates and defines properties in a way that works with
|
25
|
-
# reporting and documentation functionality in Chef Infra Client
|
23
|
+
# set_or_return within a method should not be used to define property in a resource. Instead use the property method which properly validates and defines properties in a way that works with reporting and documentation functionality in Chef Infra Client
|
26
24
|
#
|
27
25
|
# @example
|
28
26
|
#
|
29
|
-
#
|
27
|
+
# #### incorrect
|
30
28
|
# def severity(arg = nil)
|
31
29
|
# set_or_return(
|
32
30
|
# :severity, arg,
|
@@ -35,7 +33,7 @@ module RuboCop
|
|
35
33
|
# )
|
36
34
|
# end
|
37
35
|
#
|
38
|
-
#
|
36
|
+
# #### correct
|
39
37
|
# property :severity, String
|
40
38
|
#
|
41
39
|
class SetOrReturnInResources < Base
|
@@ -20,20 +20,18 @@ module RuboCop
|
|
20
20
|
module Cop
|
21
21
|
module Chef
|
22
22
|
module Modernize
|
23
|
-
# In HWRPs and LWRPs you defined attributes, but custom resources changed the name to
|
24
|
-
# be properties to avoid confusion with chef recipe attributes. When writing a custom resource
|
25
|
-
# they should be called properties even though the two are aliased.
|
23
|
+
# In HWRPs and LWRPs you defined attributes, but custom resources changed the name to be properties to avoid confusion with chef recipe attributes. When writing a custom resource they should be called properties even though the two are aliased.
|
26
24
|
#
|
27
25
|
# @example
|
28
26
|
#
|
29
|
-
#
|
27
|
+
# #### incorrect
|
30
28
|
# attribute :something, String
|
31
29
|
#
|
32
30
|
# action :create do
|
33
31
|
# # some action code because we're in a custom resource
|
34
32
|
# end
|
35
33
|
#
|
36
|
-
#
|
34
|
+
# #### correct
|
37
35
|
# property :something, String
|
38
36
|
#
|
39
37
|
# action :create do
|
@@ -21,7 +21,9 @@ module RuboCop
|
|
21
21
|
module Modernize
|
22
22
|
# There is no need to check if the chef_gem resource supports compile_time as Chef Infra Client 12.1 and later support the compile_time property.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# chef_gem 'ultradns-sdk' do
|
26
28
|
# compile_time true if Chef::Resource::ChefGem.method_defined?(:compile_time)
|
27
29
|
# action :nothing
|
@@ -37,7 +39,7 @@ module RuboCop
|
|
37
39
|
# action :nothing
|
38
40
|
# end
|
39
41
|
#
|
40
|
-
#
|
42
|
+
# #### correct
|
41
43
|
# chef_gem 'ultradns-sdk' do
|
42
44
|
# compile_time true
|
43
45
|
# action :nothing
|
@@ -19,12 +19,11 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# It is not longer necessary respond_to?(:foo) or defined?(foo) in metadata. This was used to support new metadata
|
23
|
-
# methods in Chef 11 and early versions of Chef 12.
|
22
|
+
# It is not longer necessary respond_to?(:foo) or defined?(foo) in metadata. This was used to support new metadata methods in Chef 11 and early versions of Chef 12.
|
24
23
|
#
|
25
24
|
# @example
|
26
25
|
#
|
27
|
-
#
|
26
|
+
# #### incorrect
|
28
27
|
# chef_version '>= 13' if respond_to?(:chef_version)
|
29
28
|
# chef_version '>= 13' if defined?(chef_version)
|
30
29
|
# chef_version '>= 13' unless defined?(Ridley::Chef::Cookbook::Metadata)
|
@@ -32,7 +31,7 @@ module RuboCop
|
|
32
31
|
# chef_version '>= 13'
|
33
32
|
# end
|
34
33
|
#
|
35
|
-
#
|
34
|
+
# #### correct
|
36
35
|
# chef_version '>= 13'
|
37
36
|
#
|
38
37
|
class RespondToInMetadata < Base
|
@@ -23,12 +23,12 @@ module RuboCop
|
|
23
23
|
#
|
24
24
|
# @example
|
25
25
|
#
|
26
|
-
#
|
26
|
+
# #### incorrect
|
27
27
|
# provides :foo if respond_to?(:provides)
|
28
28
|
#
|
29
29
|
# provides :foo if defined? provides
|
30
30
|
#
|
31
|
-
#
|
31
|
+
# #### correct
|
32
32
|
# provides :foo
|
33
33
|
#
|
34
34
|
class RespondToProvides < Base
|
@@ -19,15 +19,17 @@ module RuboCop
|
|
19
19
|
module Cop
|
20
20
|
module Chef
|
21
21
|
module Modernize
|
22
|
-
# The sc_windows resource from the sc cookbook allowed for the creation of windows services on legacy Chef Infra Client releases. Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions without the need for additional cookbook dependencies. See the windows_service documentation at https://docs.chef.io/
|
22
|
+
# The sc_windows resource from the sc cookbook allowed for the creation of windows services on legacy Chef Infra Client releases. Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions without the need for additional cookbook dependencies. See the windows_service documentation at https://docs.chef.io/resources/windows_service for additional details on creating services with the windows_service resource.
|
23
23
|
#
|
24
|
-
#
|
24
|
+
# @example
|
25
|
+
#
|
26
|
+
# #### incorrect
|
25
27
|
# sc_windows 'chef-client' do
|
26
28
|
# path "C:\\opscode\\chef\\bin"
|
27
29
|
# action :create
|
28
30
|
# end
|
29
31
|
#
|
30
|
-
#
|
32
|
+
# #### correct
|
31
33
|
# windows_service 'chef-client' do
|
32
34
|
# action :create
|
33
35
|
# binary_path_name "C:\\opscode\\chef\\bin"
|
@@ -38,7 +40,7 @@ module RuboCop
|
|
38
40
|
|
39
41
|
minimum_target_chef_version '14.0'
|
40
42
|
|
41
|
-
MSG = 'Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions without the need for the sc cookbook dependency. See the windows_service documentation at https://docs.chef.io/
|
43
|
+
MSG = 'Chef Infra Client 14.0 and later includes :create, :delete, and :configure actions without the need for the sc cookbook dependency. See the windows_service documentation at https://docs.chef.io/resources/windows_service for additional details.'
|
42
44
|
RESTRICT_ON_SEND = [:sc_windows].freeze
|
43
45
|
|
44
46
|
def on_send(node)
|