cookstyle 7.32.2 → 7.32.7

data/lib/rubocop/cop/chef/modernize/node_roles_include.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node['roles'].include?('foo')
         #
-        #   #### correct
+        #   ### correct
         #   node.role?('foo')
         #
         class NodeRolesInclude < Base

data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'ohai::default'
         #   include_recipe 'ohai'
         #

data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   openssl_rsa_key '/etc/httpd/ssl/server.key' do
         #     key_length 2048
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   openssl_rsa_private_key '/etc/httpd/ssl/server.key' do
         #     key_length 2048
         #   end

data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   openssl_x509 '/etc/httpd/ssl/mycert.pem' do
         #     common_name 'www.f00bar.com'
         #     org 'Foo Bar'
@@ -31,7 +31,7 @@ module RuboCop
         #     country 'US'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   openssl_x509_certificate '/etc/httpd/ssl/mycert.pem' do
         #     common_name 'www.f00bar.com'
         #     org 'Foo Bar'

data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   osx_config_profile 'Install screensaver profile' do
         #     profile 'screensaver/com.company.screensaver.mobileconfig'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   osx_profile 'Install screensaver profile' do
         #     profile 'screensaver/com.company.screensaver.mobileconfig'
         #   end

data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   powershell_script 'Expand website' do
         #     code 'Expand-Archive "C:\\file.zip" -DestinationPath "C:\\inetpub\\wwwroot\\" -Force'
         #   end

data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   powershell_script 'Create Directory' do
         #     code "New-Item -ItemType Directory -Force -Path C:\mydir"
         #     guard_interpreter :powershell_script
@@ -34,7 +34,7 @@ module RuboCop
         #     guard_interpreter :powershell_script
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   powershell_script 'Create Directory' do
         #     code "New-Item -ItemType Directory -Force -Path C:\mydir"
         #   end

data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   powershell_script 'Expand website' do
         #     code 'Install-Package -Name docker'
         #   end
         #
-        #  #### correct
+        #  ### correct
         #  powershell_package 'docker'
         #
         class PowershellInstallPackage < Base

data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   powershell_script 'Install Feature' do
         #     code 'Install-WindowsFeature -Name "Net-framework-Core"'
         #   end
         #
-        #  #### correct
+        #  ### correct
         #  windows_feature 'Net-framework-Core' do
         #    action :install
         #    install_method :windows_feature_powershell

data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   property :bob, String, name_attribute: true
         #
-        #   #### correct
+        #   ### correct
         #   property :bob, String, name_property: true
         #
         class PropertyWithNameAttribute < Base

data/lib/rubocop/cop/chef/modernize/provides_initializer.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def initialize(*args)
         #     super
         #     @provides = :foo
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   provides :foo
         #
         class ProvidesFromInitialize < Base

data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def initialize(*args)
         #     super
         #     @resource_name = :foo
         #   end
         #
-        #  #### correct
+        #  ### correct
         #  resource_name :create
 
         class ResourceNameFromInitialize < Base

data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #    def severity(arg = nil)
         #      set_or_return(
         #        :severity, arg,
@@ -32,7 +32,7 @@ module RuboCop
         #      )
         #    end
         #
-        #   #### correct
+        #   ### correct
         #   property :severity, String
         #
         class SetOrReturnInResources < Base

data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   attribute :something, String
         #
         #   action :create do
         #     # some action code because we're in a custom resource
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   property :something, String
         #
         #   action :create do

data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_gem 'ultradns-sdk' do
         #     compile_time true if Chef::Resource::ChefGem.method_defined?(:compile_time)
         #     action :nothing
@@ -39,7 +39,7 @@ module RuboCop
         #     action :nothing
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   chef_gem 'ultradns-sdk' do
         #     compile_time true
         #     action :nothing

data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_version '>= 13' if respond_to?(:chef_version)
         #   chef_version '>= 13' if defined?(chef_version)
         #   chef_version '>= 13' unless defined?(Ridley::Chef::Cookbook::Metadata)
@@ -31,7 +31,7 @@ module RuboCop
         #     chef_version '>= 13'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   chef_version '>= 13'
         #
         class RespondToInMetadata < Base

data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   provides :foo if respond_to?(:provides)
         #
         #   provides :foo if defined? provides
         #
-        #   #### correct
+        #   ### correct
         #   provides :foo
         #
         class RespondToProvides < Base

data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   resource_name :foo if respond_to?(:resource_name)
         #
-        #   #### correct
+        #   ### correct
         #   resource_name :foo
         #
         class RespondToResourceName < Base

data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   sc_windows 'chef-client' do
         #     path "C:\\opscode\\chef\\bin"
         #     action :create
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   windows_service 'chef-client' do
         #     action :create
         #     binary_path_name "C:\\opscode\\chef\\bin"

data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   seven_zip_archive "C:\file.zip" do
         #     path 'C:\expand_here'
         #   end

data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   Mixlib::ShellOut.new('foo').run_command
         #
-        #   #### correct
+        #   ### correct
         #   shell_out('foo')
         #
         class ShellOutHelper < Base

data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   execute 'install package foo' do
         #     command "choco install --source=artifactory \"foo\" -y --no-progress --ignore-package-exit-codes"
         #   end

data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #  #### incorrect
+        #  ### incorrect
         #    apt_repository 'atom-ppa' do
         #      uri 'http://ppa.launchpad.net/webupd8team/atom/ubuntu'
         #      components ['main']
@@ -31,7 +31,7 @@ module RuboCop
         #      key 'C2518248EEA14886'
         #    end
         #
-        #  #### correct
+        #  ### correct
         #    apt_repository 'atom-ppa' do
         #      uri 'ppa:webupd8team/atom'
         #      components ['main']

data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb

@@ -23,12 +23,12 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   sysctl_param 'fs.aio-max-nr' do
         #     value '1048576'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   sysctl 'fs.aio-max-nr' do
         #     value '1048576'
         #   end

data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require 'mixlib/shellout'
         #
         class UnnecessaryMixlibShelloutRequire < Base

data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node['cloud']['provider'] == 'alibaba'
         #   node['cloud']['provider'] == 'ec2'
         #   node['cloud']['provider'] == 'gce'
@@ -35,7 +35,7 @@ module RuboCop
         #   node['cloud']['provider'] == 'digital_ocean'
         #   node['cloud']['provider'] == 'softlayer'
         #
-        #   #### correct
+        #   ### correct
         #   alibaba?
         #   ec2?
         #   gce?

data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb

@@ -23,11 +23,11 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   ENV['CI']
         #   ENV['TEST_KITCHEN']
         #
-        #   #### correct
+        #   ### correct
         #   ci?
         #   kitchen?
         #

data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   node['init_package'] == 'systemd'
         #
-        #   #### correct
+        #   ### correct
         #   systemd?
         #
         class UseChefLanguageSystemdHelper < Base

data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb

@@ -23,14 +23,14 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   %w(bmon htop vim curl).each do |pkg|
         #     package pkg do
         #       action :install
         #     end
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   package %w(bmon htop vim curl)
         #
         class UseMultipackageInstalls < Base

data/lib/rubocop/cop/chef/modernize/use_require_relative.rb

@@ -23,10 +23,10 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   require File.expand_path('../../libraries/helpers', __FILE__)
         #
-        #   #### correct
+        #   ### correct
         #   require_relative '../libraries/helpers'
         #
         class UseRequireRelative < Base

data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   def whyrun_supported?
         #    true
         #   end

data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   include_recipe 'windows::default'
         #   include_recipe 'windows'
         #

data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   registry_key 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\System' do
         #     values [{ name: 'EnableLUA', type: :dword, data: 0 },
         #             { name: 'PromptOnSecureDesktop', type: :dword, data: 0 },
@@ -32,7 +32,7 @@ module RuboCop
         #     action :create
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   windows_uac 'Set Windows UAC settings' do
         #     enable_uac false
         #     prompt_on_secure_desktop true

data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   windows_zipfile 'C:\\files\\' do
         #     source 'C:\\Temp\\file.zip'
         #   end

data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   zipfile "C:\file.zip" do
         #     path 'C:\expand_here'
         #   end

data/lib/rubocop/cop/chef/modernize/zypper_repo.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   zypper_repo 'apache' do
         #     baseurl 'http://download.opensuse.org/repositories/Apache'
         #     path '/openSUSE_Leap_42.2'
@@ -31,7 +31,7 @@ module RuboCop
         #     priority '100'
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   zypper_repository 'apache' do
         #     baseurl 'http://download.opensuse.org/repositories/Apache'
         #     path '/openSUSE_Leap_42.2'

data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   apt_repository 'my repo' do
         #     uri 'http://packages.example.com/debian'
         #     components %w(stable main)
@@ -31,7 +31,7 @@ module RuboCop
         #     distribution node['lsb']['codename']
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   apt_repository 'my repo' do
         #     uri 'http://packages.example.com/debian'
         #     components %w(stable main)

data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   apt_repository 'my repo' do
         #     uri 'http://packages.example.com/debian'
         #     components %w(stable main)
@@ -31,7 +31,7 @@ module RuboCop
         #     notifies :run, 'execute[apt-get update]', :immediately
         #   end
         #
-        #   #### correct
+        #   ### correct
         #   apt_repository 'my repo' do
         #     uri 'http://packages.example.com/debian'
         #     components %w(stable main)

data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect in metadata.rb:
+        #   ### incorrect in metadata.rb:
         #
         #    attribute 'zookeeper_bridge/server',
         #              display_name: 'zookeeper server',

data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect in metadata.rb:
+        #   ### incorrect in metadata.rb:
         #
         #   conflicts "another_cookbook"
         #

data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   allowed_actions [:create, :remove]
         #
         #   # also bad

data/lib/rubocop/cop/chef/redundant/double_compile_time.rb

@@ -23,13 +23,13 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   chef_gem 'deep_merge' do
         #     action :nothing
         #     compile_time true
         #   end.run_action(:install)
         #
-        #   #### correct
+        #   ### correct
         #   chef_gem 'deep_merge' do
         #     action :install
         #     compile_time true

data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   grouping 'windows_log_rotate', title: 'Demonstration cookbook with code to switch loggers'
         #
         class GroupingMetadata < Base

data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb

@@ -23,7 +23,7 @@ module RuboCop
         #
         # @example
         #
-        #   #### incorrect
+        #   ### incorrect
         #   long_description 'this is my cookbook and this description will never be seen'
         #
         class LongDescriptionMetadata < Base