cookstyle 7.32.2 → 7.32.7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (261) hide show
  1. checksums.yaml +4 -4
  2. data/bin/cookstyle +7 -0
  3. data/config/chefstyle.yml +741 -0
  4. data/config/cookstyle.yml +46 -46
  5. data/config/default.yml +0 -2
  6. data/lib/cookstyle/version.rb +1 -1
  7. data/lib/cookstyle.rb +7 -15
  8. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +2 -2
  9. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -2
  10. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +2 -2
  11. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -2
  12. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +2 -2
  13. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +2 -2
  14. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +2 -2
  15. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +2 -2
  16. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -2
  17. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +2 -2
  18. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  19. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -2
  20. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
  21. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  22. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
  23. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
  24. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -2
  25. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -2
  26. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +2 -2
  27. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +2 -2
  28. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +2 -2
  29. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +2 -2
  30. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -2
  33. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -2
  34. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +2 -2
  36. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +2 -2
  37. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +2 -2
  39. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +2 -2
  40. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +2 -2
  41. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -2
  42. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +2 -2
  43. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -2
  44. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -2
  45. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  46. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +2 -2
  47. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -2
  48. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +2 -2
  49. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  50. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +2 -2
  51. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +1 -1
  52. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +2 -2
  53. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -2
  55. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +2 -2
  56. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  57. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -2
  58. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -2
  59. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +2 -2
  60. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  61. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +2 -2
  63. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  64. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +1 -1
  65. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +1 -1
  66. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -2
  67. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -2
  68. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +2 -2
  69. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +2 -2
  71. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -2
  72. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -2
  75. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +2 -2
  77. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +2 -2
  78. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +4 -4
  80. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +2 -2
  81. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +2 -2
  82. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -2
  83. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +2 -2
  84. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -2
  88. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +2 -2
  89. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -2
  90. data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +4 -4
  91. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -2
  92. data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -2
  93. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -2
  94. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
  95. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +2 -2
  96. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -2
  97. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
  98. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +2 -2
  99. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -2
  100. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -2
  101. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
  102. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +2 -2
  103. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +2 -2
  106. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +2 -2
  107. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +2 -2
  108. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -2
  109. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -2
  110. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +2 -2
  111. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
  112. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +2 -2
  114. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
  115. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -2
  116. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -2
  117. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +2 -2
  118. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +2 -2
  119. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -2
  120. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  121. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  122. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +6 -6
  123. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  124. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  125. data/lib/rubocop/cop/chef/effortless/node_environment.rb +1 -1
  126. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +1 -1
  127. data/lib/rubocop/cop/chef/effortless/node_roles.rb +1 -1
  128. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  129. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  130. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +2 -2
  131. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
  132. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -2
  133. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
  134. data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -2
  135. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +1 -1
  138. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +2 -2
  139. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -2
  140. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +2 -2
  141. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +2 -2
  142. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +2 -2
  143. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -2
  144. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +2 -2
  145. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +3 -3
  146. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  147. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
  149. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
  154. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  155. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
  156. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  157. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +2 -2
  158. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
  159. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +2 -2
  160. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
  161. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +2 -2
  162. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  163. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -2
  164. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  165. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +2 -2
  166. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +2 -2
  167. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  168. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
  169. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -2
  170. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
  171. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +2 -2
  172. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +2 -2
  173. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +2 -2
  174. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
  175. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -2
  176. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +2 -2
  177. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +2 -2
  178. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -2
  179. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +2 -2
  180. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
  181. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +2 -2
  182. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +2 -2
  183. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +2 -2
  184. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
  185. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +2 -2
  186. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -2
  187. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +2 -2
  188. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  189. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -2
  190. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +1 -1
  191. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +2 -2
  192. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +2 -2
  193. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  194. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +2 -2
  195. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +2 -2
  196. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +2 -2
  197. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
  198. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -2
  199. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  200. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  201. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
  202. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  203. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +1 -1
  204. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -2
  205. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +2 -2
  206. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +2 -2
  207. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  208. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  209. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  210. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +2 -2
  211. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  212. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  213. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +2 -2
  214. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +2 -2
  215. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +2 -2
  216. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +2 -2
  217. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -2
  218. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  219. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  220. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -2
  224. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  225. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -2
  226. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  227. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -2
  228. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +1 -1
  229. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +2 -2
  230. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -2
  231. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +2 -2
  232. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  233. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  234. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +2 -2
  235. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +2 -2
  236. data/lib/rubocop/cop/chef/style/attribute_keys.rb +4 -4
  237. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -2
  238. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  239. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +2 -2
  240. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -2
  241. data/lib/rubocop/cop/chef/style/comments_format.rb +2 -2
  242. data/lib/rubocop/cop/chef/style/file_mode.rb +2 -2
  243. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -2
  244. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +2 -2
  245. data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -2
  246. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -2
  247. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +2 -2
  248. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -2
  249. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +2 -2
  250. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +2 -2
  251. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +2 -2
  252. data/lib/rubocop/cop/chefstyle/ruby/gemspec_license.rb +55 -0
  253. data/lib/rubocop/cop/chefstyle/ruby/gemspec_require_rubygems.rb +46 -0
  254. data/lib/rubocop/cop/chefstyle/ruby/legacy_powershell_out_methods.rb +36 -0
  255. data/lib/rubocop/cop/chefstyle/ruby/require_net_https.rb +54 -0
  256. data/lib/rubocop/cop/chefstyle/ruby/unless_defined_require.rb +122 -0
  257. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +2 -2
  258. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +2 -2
  259. metadata +8 -4
  260. data/config/disable_all.yml +0 -987
  261. data/config/upstream.yml +0 -5132
@@ -23,22 +23,22 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # require 'chef-vault'
28
28
  #
29
- # #### incorrect
29
+ # ### incorrect
30
30
  # ChefVault::Item
31
31
  #
32
- # #### incorrect
32
+ # ### incorrect
33
33
  # include_recipe 'chef-vault'
34
34
  #
35
- # #### incorrect
35
+ # ### incorrect
36
36
  # chef_gem 'chef-vault'
37
37
  #
38
- # #### incorrect
38
+ # ### incorrect
39
39
  # chef_vault_item_for_environment(arg, arg1)
40
40
  #
41
- # #### incorrect
41
+ # ### incorrect
42
42
  # chef_vault_item(arg, arg1)
43
43
  #
44
44
  class ChefVaultUsed < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # data_bag_item('admins', login)
28
28
  # data_bag(data_bag_name)
29
29
  class CookbookUsesDatabags < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'chef-vault'
28
28
  #
29
29
  class DependsChefVault < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # node.environment == "production"
28
28
  # node.chef_environment == "production"
29
29
  #
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # node.policy_group == "foo"
28
28
  #
29
29
  class CookbookUsesPolicygroups < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # node.role?('web_server')
28
28
  # node.roles.include?('web_server')
29
29
  #
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # search(:node, 'chef_environment:foo')
28
28
  # search(:node, 'role:bar')
29
29
  #
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # search(:node, 'run_list:recipe\[bacula\:\:server\]')
28
28
  #
29
29
  class CookbookUsesSearch < Base
@@ -23,12 +23,12 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # def action_create
28
28
  # # :create action code here
29
29
  # end
30
30
  #
31
- # #### correct
31
+ # ### correct
32
32
  # action :create do
33
33
  # # :create action code here
34
34
  # end
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # def initialize(*args)
28
28
  # super
29
29
  # @actions = [ :create, :add ]
@@ -35,7 +35,7 @@ module RuboCop
35
35
  # @allowed_actions = [ :create, :add ]
36
36
  # end
37
37
  #
38
- # #### correct
38
+ # ### correct
39
39
  # allowed_actions [ :create, :add ]
40
40
  #
41
41
  class AllowedActionsFromInitialize < Base
@@ -23,11 +23,11 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # include_recipe 'apt::default'
28
28
  # include_recipe 'apt'
29
29
  #
30
- # #### correct
30
+ # ### correct
31
31
  # apt_update
32
32
  #
33
33
  class IncludingAptDefaultRecipe < Base
@@ -23,13 +23,13 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # source 'http://community.opscode.com/api/v3'
28
28
  # source 'https://supermarket.getchef.com'
29
29
  # source 'https://api.berkshelf.com'
30
30
  # site :opscode
31
31
  #
32
- # #### correct
32
+ # ### correct
33
33
  # source 'https://supermarket.chef.io'
34
34
  #
35
35
  class LegacyBerksfileSource < Base
@@ -23,12 +23,12 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'build-essential'
28
28
  # include_recipe 'build-essential::default'
29
29
  # include_recipe 'build-essential'
30
30
  #
31
- # #### correct
31
+ # ### correct
32
32
  # build_essential 'install compilation tools'
33
33
  #
34
34
  class UseBuildEssentialResource < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'build-essential'
28
28
  # depends 'chef_handler'
29
29
  # depends 'chef_hostname'
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'libarchive'
28
28
  # depends 'windows_dns'
29
29
  # depends 'windows_uac'
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # chef_gem 'nokogiri'
28
28
  #
29
29
  class ChefGemNokogiri < Base
@@ -23,12 +23,12 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # action_class.class_eval do
28
28
  # foo
29
29
  # end
30
30
  #
31
- # #### correct
31
+ # ### correct
32
32
  # action_class do
33
33
  # foo
34
34
  # end
@@ -23,12 +23,12 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # build_essential 'install build tools' do
28
28
  # action :nothing
29
29
  # end.run_action(:install)
30
30
  #
31
- # #### correct
31
+ # ### correct
32
32
  # build_essential 'install build tools' do
33
33
  # compile_time true
34
34
  # end
@@ -23,10 +23,10 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # only_if 'test -f /bin/foo'
28
28
  #
29
- # #### correct
29
+ # ### correct
30
30
  # only_if { ::File.exist?('bin/foo') }
31
31
  #
32
32
  class ConditionalUsingTest < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # template '/etc/cron.d/backup' do
28
28
  # source 'cron_backup_job.erb'
29
29
  # owner 'root'
@@ -71,7 +71,7 @@ module RuboCop
71
71
  # action :delete
72
72
  # end
73
73
  #
74
- # #### correct
74
+ # ### correct
75
75
  # cron_d 'backup' do
76
76
  # minute '1'
77
77
  # hour '1'
@@ -23,10 +23,10 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # cron_manage 'mike'
28
28
  #
29
- # #### correct
29
+ # ### correct
30
30
  # cron_access 'mike'
31
31
  #
32
32
  class CronManageResource < Base
@@ -23,11 +23,11 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # plain_text_data = Chef::DataBagItem.load('foo', 'bar')
28
28
  # encrypted_data = Chef::EncryptedDataBagItem.load('foo2', 'bar2')
29
29
  #
30
- # #### correct
30
+ # ### correct
31
31
  # plain_text_data = data_bag_item('foo', 'bar')
32
32
  # encrypted_data = data_bag_item('foo2', 'bar2')
33
33
  #
@@ -23,12 +23,12 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # declare_action_class do
28
28
  # foo
29
29
  # end
30
30
  #
31
- # #### correct
31
+ # ### correct
32
32
  # action_class do
33
33
  # foo
34
34
  # end
@@ -23,19 +23,19 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # def initialize(*args)
28
28
  # super
29
29
  # @action = :create
30
30
  # end
31
31
  #
32
- # #### incorrect
32
+ # ### incorrect
33
33
  # def initialize(*args)
34
34
  # super
35
35
  # @default_action = :create
36
36
  # end
37
37
  #
38
- # #### correct
38
+ # ### correct
39
39
  # default_action :create
40
40
 
41
41
  class DefaultActionFromInitialize < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # if defined?(ChefSpec)
28
28
  # def create_yum_repository(resource_name)
29
29
  # ChefSpec::Matchers::ResourceMatcher.new(:yum_repository, :create, resource_name)
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'chef-vault'
28
28
  #
29
29
  class DependsOnChefVaultCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'chocolatey_source'
28
28
  # depends 'chocolatey_config'
29
29
  #
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'kernel_module'
28
28
  #
29
29
  class DependsOnKernelModuleCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'locale'
28
28
  #
29
29
  class DependsOnLocaleCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'openssl'
28
28
  #
29
29
  class DependsOnOpensslCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'timezone_lwrp'
28
28
  #
29
29
  class DependsOnTimezoneLwrpCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'windows_firewall'
28
28
  #
29
29
  class DependsOnWindowsFirewallCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'zypper'
28
28
  #
29
29
  class DependsOnZypperCookbook < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # include Chef::DSL::Recipe
28
28
  # include Chef::DSL::IncludeRecipe
29
29
  #
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # def initialize(*args)
28
28
  # super
29
29
  # end
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # execute 'apt-get update'
28
28
  #
29
29
  # execute 'Apt all the apt cache' do
@@ -34,7 +34,7 @@ module RuboCop
34
34
  # notifies :run, 'execute[apt-get update]', :immediately
35
35
  # end
36
36
  #
37
- # #### correct
37
+ # ### correct
38
38
  # apt_update
39
39
  #
40
40
  # apt_update 'update apt cache'
@@ -23,13 +23,13 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # execute "Delete chef-client service" do
28
28
  # command "sc.exe delete chef-client"
29
29
  # action :run
30
30
  # end
31
31
  #
32
- # #### correct
32
+ # ### correct
33
33
  # windows_service 'chef-client' do
34
34
  # action :delete
35
35
  # end
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # execute "sleep 60" do
28
28
  # command "sleep 60"
29
29
  # action :run
@@ -35,7 +35,7 @@ module RuboCop
35
35
  # code 'sleep 60'
36
36
  # end
37
37
  #
38
- # #### correct
38
+ # ### correct
39
39
  # chef_sleep '60'
40
40
  #
41
41
  class ExecuteSleep < Cop
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # file '/etc/sysctl.d/ipv4.conf' do
28
28
  # notifies :run, 'execute[sysctl -p /etc/sysctl.d/ipv4.conf]', :immediately
29
29
  # content '9000 65500'
@@ -33,7 +33,7 @@ module RuboCop
33
33
  # action :nothing
34
34
  # end
35
35
  #
36
- # #### correct
36
+ # ### correct
37
37
  # sysctl 'net.ipv4.ip_local_port_range' do
38
38
  # value '9000 65500'
39
39
  # end
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # execute 'set tz' do
28
28
  # command 'tzutil.exe /s UTC'
29
29
  # end
@@ -35,7 +35,7 @@ module RuboCop
35
35
  # not_if { shell_out('tzutil.exe /g').stdout.include?('UTC') }
36
36
  # end
37
37
  #
38
- # #### correct
38
+ # ### correct
39
39
  # timezone 'UTC'
40
40
  #
41
41
  class ExecuteTzUtil < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # # ~FC013
28
28
  #
29
29
  class FoodcriticComments < Base
@@ -23,10 +23,10 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # default_action :foo if defined?(default_action)
28
28
  #
29
- # #### correct
29
+ # ### correct
30
30
  # default_action :foo
31
31
  #
32
32
  class IfProvidesDefaultAction < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # require 'chef/mixin/shell_out'
28
28
  # include Chef::Mixin::ShellOut
29
29
  # require 'chef/mixin/powershell_out'
@@ -23,14 +23,14 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'libarchive'
28
28
  #
29
29
  # libarchive_file "C:\file.zip" do
30
30
  # path 'C:\expand_here'
31
31
  # end
32
32
  #
33
- # #### correct
33
+ # ### correct
34
34
  # archive_file "C:\file.zip" do
35
35
  # path 'C:\expand_here'
36
36
  # end
@@ -23,14 +23,14 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # mac_os_x_userdefaults 'full keyboard access to all controls' do
28
28
  # domain 'AppleKeyboardUIMode'
29
29
  # global true
30
30
  # value '2'
31
31
  # end
32
32
  #
33
- # #### correct
33
+ # ### correct
34
34
  # macos_userdefaults 'full keyboard access to all controls' do
35
35
  # domain 'AppleKeyboardUIMode'
36
36
  # global true
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # depends 'minitest-handler'
28
28
  #
29
29
  class MinitestHandlerUsage < Base
@@ -23,7 +23,7 @@ module RuboCop
23
23
  #
24
24
  # @example
25
25
  #
26
- # #### incorrect
26
+ # ### incorrect
27
27
  # ::File.open('/proc/1/comm').gets.chomp == 'systemd'
28
28
  # ::File.open('/proc/1/comm').chomp == 'systemd'
29
29
  # File.open('/proc/1/comm').gets.chomp == 'systemd'
@@ -35,7 +35,7 @@ module RuboCop
35
35
  # File.exist?('/proc/1/comm') && File.open('/proc/1/comm').chomp == 'systemd'
36
36
  # only_if 'test -f /bin/systemctl && /bin/systemctl'
37
37
  #
38
- # #### correct
38
+ # ### correct
39
39
  # node['init_package'] == 'systemd'
40
40
  # only_if { node['init_package'] == 'systemd' }
41
41
  #