cookstyle 7.28.2 → 7.31.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (256) hide show
  1. checksums.yaml +4 -4
  2. data/config/cookstyle.yml +15 -0
  3. data/config/upstream.yml +3 -0
  4. data/lib/cookstyle/version.rb +2 -2
  5. data/lib/rubocop/chef/cookbook_helpers.rb +2 -0
  6. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +1 -1
  7. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +1 -1
  8. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +1 -1
  9. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +1 -1
  10. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +1 -1
  11. data/lib/rubocop/cop/chef/correctness/invalid_cookbook_name.rb +1 -1
  12. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +1 -1
  13. data/lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb +1 -1
  14. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +1 -1
  15. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +1 -1
  16. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +1 -1
  17. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +1 -1
  18. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -2
  19. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +1 -1
  20. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -2
  21. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -2
  22. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +1 -1
  23. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +1 -1
  24. data/lib/rubocop/cop/chef/correctness/lazy_in_resource_guard.rb +1 -1
  25. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +1 -1
  26. data/lib/rubocop/cop/chef/correctness/metadata_malformed_version.rb +1 -1
  27. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +1 -1
  28. data/lib/rubocop/cop/chef/correctness/metadata_missing_version.rb +1 -1
  29. data/lib/rubocop/cop/chef/correctness/node_normal.rb +1 -1
  30. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +1 -1
  31. data/lib/rubocop/cop/chef/correctness/node_save.rb +1 -1
  32. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +1 -1
  33. data/lib/rubocop/cop/chef/correctness/octal_mode_as_string.rb +1 -1
  34. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +1 -1
  35. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +1 -1
  36. data/lib/rubocop/cop/chef/correctness/powershell_file_exists.rb +1 -1
  37. data/lib/rubocop/cop/chef/correctness/property_without_type.rb +1 -1
  38. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +1 -1
  39. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +1 -1
  40. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +1 -1
  41. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +1 -1
  42. data/lib/rubocop/cop/chef/correctness/service_resource.rb +1 -1
  43. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +1 -1
  44. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +1 -1
  45. data/lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb +1 -1
  46. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +1 -1
  47. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +1 -1
  48. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +2 -2
  49. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +4 -4
  50. data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb +3 -3
  51. data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb +1 -1
  52. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +1 -1
  53. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +1 -1
  54. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +1 -1
  55. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +1 -1
  56. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +1 -1
  57. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +1 -1
  58. data/lib/rubocop/cop/chef/deprecation/delivery.rb +44 -0
  59. data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb +1 -1
  60. data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb +1 -1
  61. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +1 -1
  62. data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb +1 -1
  63. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +1 -1
  64. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +3 -2
  65. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +1 -1
  66. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +3 -3
  67. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +1 -1
  68. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +1 -1
  69. data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb +1 -1
  70. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +1 -1
  71. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb +1 -1
  72. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +1 -1
  73. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +1 -1
  74. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +1 -1
  75. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +1 -1
  76. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +1 -1
  77. data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb +1 -1
  78. data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb +1 -1
  79. data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb +1 -1
  80. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +1 -1
  81. data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb +1 -1
  82. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +1 -1
  83. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +1 -1
  84. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +1 -1
  85. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +1 -1
  86. data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb +1 -1
  87. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +1 -1
  88. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +1 -1
  89. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +1 -1
  90. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +1 -1
  91. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +1 -1
  92. data/lib/rubocop/cop/chef/deprecation/node_set.rb +1 -1
  93. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +1 -1
  94. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -2
  95. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +1 -1
  96. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +1 -1
  97. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +2 -2
  98. data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb +1 -1
  99. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +1 -1
  100. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +1 -1
  101. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -2
  102. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +1 -1
  103. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +1 -1
  104. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +1 -1
  105. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +1 -1
  106. data/lib/rubocop/cop/chef/deprecation/resource_without_unified_mode_true.rb +1 -1
  107. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +1 -1
  108. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +1 -1
  109. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +3 -3
  110. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +1 -1
  111. data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb +1 -1
  112. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +1 -1
  113. data/lib/rubocop/cop/chef/deprecation/use_yaml_dump.rb +1 -1
  114. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -2
  115. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +1 -1
  116. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +1 -1
  117. data/lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb +1 -1
  118. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +1 -1
  119. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +1 -1
  120. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +1 -1
  121. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +1 -1
  122. data/lib/rubocop/cop/chef/effortless/berksfile.rb +1 -1
  123. data/lib/rubocop/cop/chef/effortless/chef_vault_used.rb +2 -2
  124. data/lib/rubocop/cop/chef/effortless/data_bags.rb +1 -1
  125. data/lib/rubocop/cop/chef/effortless/depends_chef_vault.rb +1 -1
  126. data/lib/rubocop/cop/chef/effortless/node_environment.rb +2 -2
  127. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +2 -2
  128. data/lib/rubocop/cop/chef/effortless/node_roles.rb +2 -2
  129. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +1 -1
  130. data/lib/rubocop/cop/chef/effortless/search_used.rb +1 -1
  131. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +1 -1
  132. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +2 -2
  133. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +1 -1
  134. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -2
  135. data/lib/rubocop/cop/chef/modernize/build_essential.rb +1 -1
  136. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +1 -1
  137. data/lib/rubocop/cop/chef/modernize/chef_15_resources.rb +1 -1
  138. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +2 -2
  139. data/lib/rubocop/cop/chef/modernize/class_eval_action_class.rb +1 -1
  140. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +1 -1
  141. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +1 -1
  142. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +1 -1
  143. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +1 -1
  144. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +1 -1
  145. data/lib/rubocop/cop/chef/modernize/declare_action_class.rb +1 -1
  146. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +1 -1
  147. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +1 -1
  148. data/lib/rubocop/cop/chef/modernize/definitions.rb +1 -1
  149. data/lib/rubocop/cop/chef/modernize/depends_chef_vault_cookbook.rb +1 -1
  150. data/lib/rubocop/cop/chef/modernize/depends_chocolatey_cookbooks.rb +1 -1
  151. data/lib/rubocop/cop/chef/modernize/depends_kernel_module_cookbook.rb +1 -1
  152. data/lib/rubocop/cop/chef/modernize/depends_locale_cookbook.rb +1 -1
  153. data/lib/rubocop/cop/chef/modernize/depends_openssl_cookbook.rb +1 -1
  154. data/lib/rubocop/cop/chef/modernize/depends_timezone_lwrp_cookbook.rb +1 -1
  155. data/lib/rubocop/cop/chef/modernize/depends_windows_firewall_cookbook.rb +1 -1
  156. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +1 -1
  157. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +1 -1
  158. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +1 -1
  159. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -3
  160. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -2
  161. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +3 -3
  162. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -2
  163. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +3 -3
  164. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +1 -1
  165. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +1 -1
  166. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +1 -1
  167. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +3 -3
  168. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +1 -1
  169. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +1 -1
  170. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +2 -2
  171. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +1 -1
  172. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +1 -1
  173. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +1 -1
  174. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +1 -1
  175. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +1 -1
  176. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +1 -1
  177. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +1 -1
  178. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +1 -1
  179. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +1 -1
  180. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +1 -1
  181. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +1 -1
  182. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +2 -2
  183. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +1 -1
  184. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +1 -1
  185. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +1 -1
  186. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -2
  187. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +1 -1
  188. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +1 -1
  189. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +1 -1
  190. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +1 -1
  191. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +1 -1
  192. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -2
  193. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +1 -1
  194. data/lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb +1 -1
  195. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +1 -1
  196. data/lib/rubocop/cop/chef/modernize/use_chef_language_cloud_helpers.rb +1 -1
  197. data/lib/rubocop/cop/chef/modernize/use_chef_language_env_helpers.rb +1 -1
  198. data/lib/rubocop/cop/chef/modernize/use_chef_language_systemd_helper.rb +1 -1
  199. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +2 -2
  200. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +1 -1
  201. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +1 -1
  202. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +1 -1
  203. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -2
  204. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +1 -1
  205. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +2 -2
  206. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +1 -1
  207. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +1 -1
  208. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +1 -1
  209. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +1 -1
  210. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +1 -1
  211. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +1 -1
  212. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +1 -1
  213. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +1 -1
  214. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +1 -1
  215. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +1 -1
  216. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +1 -1
  217. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +1 -1
  218. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +1 -1
  219. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +1 -1
  220. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +1 -1
  221. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +1 -1
  222. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +1 -1
  223. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +1 -1
  224. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +1 -1
  225. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +1 -1
  226. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +1 -1
  227. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +1 -1
  228. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +1 -1
  229. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +54 -14
  230. data/lib/rubocop/cop/chef/security/ssh_private_key.rb +1 -1
  231. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +1 -1
  232. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +1 -1
  233. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +1 -1
  234. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +1 -1
  235. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +1 -1
  236. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +1 -1
  237. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +1 -1
  238. data/lib/rubocop/cop/chef/style/attribute_keys.rb +5 -5
  239. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +1 -1
  240. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +1 -1
  241. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +1 -1
  242. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +1 -1
  243. data/lib/rubocop/cop/chef/style/comments_format.rb +1 -1
  244. data/lib/rubocop/cop/chef/style/file_mode.rb +1 -1
  245. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +1 -1
  246. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +1 -1
  247. data/lib/rubocop/cop/chef/style/negating_only_if.rb +1 -1
  248. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +1 -1
  249. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +1 -1
  250. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +1 -1
  251. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +3 -3
  252. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +1 -1
  253. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
  254. data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb +1 -1
  255. data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb +1 -1
  256. metadata +5 -4
@@ -68,7 +68,7 @@ module RuboCop
68
68
  def on_send(node)
69
69
  resource_name?(node) do |name|
70
70
  return if valid_provides?(name)
71
- add_offense(node, message: MSG, severity: :warning) do |corrector|
71
+ add_offense(node, severity: :warning) do |corrector|
72
72
  if name.to_s == "#{cookbook_name}_#{File.basename(processed_source.path, '.rb')}"
73
73
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
74
74
  else
@@ -31,7 +31,7 @@ module RuboCop
31
31
  RESTRICT_ON_SEND = [:provider_base].freeze
32
32
 
33
33
  def on_send(node)
34
- add_offense(node, message: MSG, severity: :warning)
34
+ add_offense(node, severity: :warning)
35
35
  end
36
36
  end
37
37
  end
@@ -38,7 +38,7 @@ module RuboCop
38
38
  MSG = "Don't use updated = true/false to update resource state. This will cause failures in Chef Infra Client 13 and later."
39
39
 
40
40
  def on_lvasgn(node)
41
- add_offense(node, message: MSG, severity: :warning) if node.node_parts.first == :updated
41
+ add_offense(node, severity: :warning) if node.node_parts.first == :updated
42
42
  end
43
43
 
44
44
  # potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from
@@ -60,7 +60,7 @@ module RuboCop
60
60
  # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
61
61
  return if unified_mode?(processed_source.ast)
62
62
  range = source_range(processed_source.buffer, 1, 0)
63
- add_offense(range, message: MSG, severity: :refactor) do |corrector|
63
+ add_offense(range, severity: :refactor) do |corrector|
64
64
  insert_below_provides(corrector) || insert_below_resource_name(corrector)
65
65
  end
66
66
  end
@@ -44,7 +44,7 @@ module RuboCop
44
44
  def on_send(node)
45
45
  positional_shellout?(node) do |h|
46
46
  next unless h.braces?
47
- add_offense(h, message: MSG, severity: :refactor) do |corrector|
47
+ add_offense(h, severity: :refactor) do |corrector|
48
48
  corrector.replace(h, h.source[1..-2])
49
49
  end
50
50
  end
@@ -49,7 +49,7 @@ module RuboCop
49
49
  match_property_in_resource?(:ruby_block, 'action', node) do |ruby_action|
50
50
  ruby_action.arguments.each do |action|
51
51
  next unless action.source == ':create'
52
- add_offense(action, message: MSG, severity: :warning) do |corrector|
52
+ add_offense(action, severity: :warning) do |corrector|
53
53
  corrector.replace(action, ':run')
54
54
  end
55
55
  end
@@ -45,15 +45,15 @@ module RuboCop
45
45
 
46
46
  def on_send(node)
47
47
  calls_run_command?(node) do
48
- add_offense(node, message: MSG, severity: :warning) unless defines_run_command?(processed_source.ast)
48
+ add_offense(node, severity: :warning) unless defines_run_command?(processed_source.ast)
49
49
  end
50
50
 
51
51
  require_mixin_command?(node) do
52
- add_offense(node, message: MSG, severity: :warning)
52
+ add_offense(node, severity: :warning)
53
53
  end
54
54
 
55
55
  include_mixin_command?(node) do
56
- add_offense(node, message: MSG, severity: :warning)
56
+ add_offense(node, severity: :warning)
57
57
  end
58
58
  end
59
59
  end
@@ -49,7 +49,7 @@ module RuboCop
49
49
 
50
50
  def on_send(node)
51
51
  search_method?(node) do
52
- add_offense(node, message: MSG, severity: :warning) do |corrector|
52
+ add_offense(node, severity: :warning) do |corrector|
53
53
  corrector.replace(node, corrected_string(node))
54
54
  end if positional_arguments?(node)
55
55
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
  RESTRICT_ON_SEND = [:use_automatic_resource_name].freeze
41
41
 
42
42
  def on_send(node)
43
- add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
43
+ add_offense(node.loc.selector, severity: :warning) do |corrector|
44
44
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
45
45
  end
46
46
  end
@@ -46,7 +46,7 @@ module RuboCop
46
46
  node = node.parent
47
47
  end
48
48
 
49
- add_offense(node, message: MSG, severity: :warning) do |corrector|
49
+ add_offense(node, severity: :warning) do |corrector|
50
50
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
51
51
  end
52
52
  end
@@ -36,7 +36,7 @@ module RuboCop
36
36
  RESTRICT_ON_SEND = [:to_yaml].freeze
37
37
 
38
38
  def on_send(node)
39
- add_offense(node, message: MSG, severity: :warning) do |corrector|
39
+ add_offense(node, severity: :warning) do |corrector|
40
40
  corrector.replace(node, "YAML.dump(#{node.receiver.source})")
41
41
  end
42
42
  end
@@ -49,13 +49,13 @@ module RuboCop
49
49
 
50
50
  def on_block(node)
51
51
  match_property_in_resource?(:user, 'supports', node) do |property|
52
- add_offense(property, message: MSG, severity: :warning) do |corrector|
52
+ add_offense(property, severity: :warning) do |corrector|
53
53
  new_text = []
54
54
 
55
55
  property.arguments.first.each_pair do |k, v|
56
56
  # account for a strange edge case where the person incorrectly makes "manage_home a method
57
57
  # the code would be broken, but without this handling cookstyle would explode
58
- key_value = (k.send_type? && k.method_name == :manage_home) ? 'manage_home' : k.value
58
+ key_value = (k.send_type? && k.method?(:manage_home)) ? 'manage_home' : k.value
59
59
 
60
60
  new_text << "#{key_value} #{v.source}"
61
61
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
  def on_block(node)
46
46
  match_property_in_resource?(nil, 'verify', node) do |verify|
47
47
  return unless verify.source.match?(/%{file}/)
48
- add_offense(verify, message: MSG, severity: :warning) do |corrector|
48
+ add_offense(verify, severity: :warning) do |corrector|
49
49
  corrector.replace(verify.loc.expression, verify.loc.expression.source.gsub('%{file}', '%{path}'))
50
50
  end
51
51
  end
@@ -48,7 +48,7 @@ module RuboCop
48
48
 
49
49
  def on_block(node)
50
50
  match_property_in_resource?(:windows_feature, :install_method, node) do |prop_node|
51
- add_offense(prop_node, message: MSG, severity: :warning) if prop_node.source.include?(':servermanagercmd')
51
+ add_offense(prop_node, severity: :warning) if prop_node.source.include?(':servermanagercmd')
52
52
  end
53
53
  end
54
54
  end
@@ -48,7 +48,7 @@ module RuboCop
48
48
  return unless offense.arguments.count == 1 # we can only analyze simple string args
49
49
  return unless offense.arguments.first.str_type? # anything else is fine
50
50
 
51
- add_offense(offense, message: MSG, severity: :warning) do |corrector|
51
+ add_offense(offense, severity: :warning) do |corrector|
52
52
  corrector.replace(offense.arguments.first.source_range, ":#{offense.arguments.first.value}")
53
53
  end
54
54
  end
@@ -65,7 +65,7 @@ module RuboCop
65
65
 
66
66
  def check_action(ast_obj)
67
67
  if ast_obj.respond_to?(:value) && ast_obj.value == :change
68
- add_offense(ast_obj, message: MSG, severity: :warning) do |corrector|
68
+ add_offense(ast_obj, severity: :warning) do |corrector|
69
69
  if ast_obj.parent.send_type? # :change was the only action
70
70
  corrector.replace(ast_obj, ':create')
71
71
  # chances are it's [:create, :change] since that's all that makes sense, but double check that theory
@@ -50,7 +50,7 @@ module RuboCop
50
50
 
51
51
  def on_send(node)
52
52
  windows_helper?(node) do |method|
53
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
53
+ add_offense(node, severity: :refactor) do |corrector|
54
54
  case method
55
55
  when :nt_version
56
56
  corrector.replace(node, 'node[\'platform_version\'].to_f')
@@ -39,7 +39,7 @@ module RuboCop
39
39
  def on_send(node)
40
40
  xml_ruby_recipe?(node) do
41
41
  node = node.parent if node.parent&.conditional? && node.parent&.single_line_condition? # make sure we catch any inline conditionals
42
- add_offense(node, message: MSG, severity: :warning) do |corrector|
42
+ add_offense(node, severity: :warning) do |corrector|
43
43
  corrector.remove(node)
44
44
  end
45
45
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
  def on_send(node)
42
42
  yum_dnf_compat_recipe_usage?(node) do
43
43
  node = node.parent if node.parent&.conditional? && node.parent&.single_line?
44
- add_offense(node, message: MSG, severity: :warning) do |corrector|
44
+ add_offense(node, severity: :warning) do |corrector|
45
45
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
46
46
  end
47
47
  end
@@ -30,7 +30,7 @@ module RuboCop
30
30
  # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
31
31
  range = source_range(processed_source.buffer, 1, 0)
32
32
 
33
- add_offense(range, message: MSG, severity: :refactor)
33
+ add_offense(range, severity: :refactor)
34
34
  end
35
35
  end
36
36
  end
@@ -72,12 +72,12 @@ module RuboCop
72
72
  return unless require?(node) ||
73
73
  chef_vault_item_for_environment?(node) ||
74
74
  chef_vault_item?(node)
75
- add_offense(node.loc.expression, message: MSG, severity: :refactor)
75
+ add_offense(node.loc.expression, severity: :refactor)
76
76
  end
77
77
 
78
78
  def on_const(node)
79
79
  vault_const?(node) do
80
- add_offense(node.loc.expression, message: MSG, severity: :refactor)
80
+ add_offense(node.loc.expression, severity: :refactor)
81
81
  end
82
82
  end
83
83
  end
@@ -31,7 +31,7 @@ module RuboCop
31
31
  RESTRICT_ON_SEND = [:data_bag, :data_bag_item].freeze
32
32
 
33
33
  def on_send(node)
34
- add_offense(node, message: MSG, severity: :refactor)
34
+ add_offense(node, severity: :refactor)
35
35
  end
36
36
  end
37
37
  end
@@ -37,7 +37,7 @@ module RuboCop
37
37
 
38
38
  def on_send(node)
39
39
  depends?(node) do
40
- add_offense(node.loc.expression, message: MSG, severity: :refactor)
40
+ add_offense(node.loc.expression, severity: :refactor)
41
41
  end
42
42
  end
43
43
  end
@@ -34,8 +34,8 @@ module RuboCop
34
34
  def on_send(node)
35
35
  if node.receiver &&
36
36
  node.receiver.send_type? &&
37
- node.receiver.method_name == :node
38
- add_offense(node, message: MSG, severity: :refactor)
37
+ node.receiver.method?(:node)
38
+ add_offense(node, severity: :refactor)
39
39
  end
40
40
  end
41
41
  end
@@ -33,8 +33,8 @@ module RuboCop
33
33
  def on_send(node)
34
34
  if node.receiver &&
35
35
  node.receiver.send_type? &&
36
- node.receiver.method_name == :node
37
- add_offense(node, message: MSG, severity: :refactor)
36
+ node.receiver.method?(:node)
37
+ add_offense(node, severity: :refactor)
38
38
  end
39
39
  end
40
40
  end
@@ -34,8 +34,8 @@ module RuboCop
34
34
  def on_send(node)
35
35
  if node.receiver &&
36
36
  node.receiver.send_type? &&
37
- node.receiver.method_name == :node
38
- add_offense(node, message: MSG, severity: :refactor)
37
+ node.receiver.method?(:node)
38
+ add_offense(node, severity: :refactor)
39
39
  end
40
40
  end
41
41
  end
@@ -33,7 +33,7 @@ module RuboCop
33
33
 
34
34
  def on_send(node)
35
35
  if node.arguments[1]&.value&.match?(/chef_environment|role/)
36
- add_offense(node, message: MSG, severity: :refactor)
36
+ add_offense(node, severity: :refactor)
37
37
  end
38
38
  end
39
39
  end
@@ -31,7 +31,7 @@ module RuboCop
31
31
  RESTRICT_ON_SEND = [:search].freeze
32
32
 
33
33
  def on_send(node)
34
- add_offense(node, message: MSG, severity: :refactor)
34
+ add_offense(node, severity: :refactor)
35
35
  end
36
36
  end
37
37
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
  return if node.arguments? # if they passed in arguments they may actually need this
46
46
  return if node.parent && includes_poise?(node.parent)
47
47
 
48
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
48
+ add_offense(node, severity: :refactor) do |corrector|
49
49
  # @todo when we drop ruby 2.4 support we can convert this to use delete_suffix
50
50
  corrector.replace(node, node.source.gsub("def #{node.method_name}", "action :#{node.method_name.to_s.gsub(/^action_/, '')} do"))
51
51
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
  MSG = 'The allowed actions of a resource can be set with the "allowed_actions" helper instead of using the initialize method.'
46
46
 
47
47
  def on_def(node)
48
- return unless node.method_name == :initialize
48
+ return unless node.method?(:initialize)
49
49
  return if node.body.nil? # nil body is an empty initialize method
50
50
 
51
51
  node.body.each_node do |x|
@@ -54,7 +54,7 @@ module RuboCop
54
54
  !x.node_parts.empty? &&
55
55
  %i(@actions @allowed_actions).include?(x.node_parts.first)
56
56
 
57
- add_offense(x, message: MSG, severity: :refactor) do |corrector|
57
+ add_offense(x, severity: :refactor) do |corrector|
58
58
  # insert the new allowed_actions call above the initialize method, but not if one already exists (this is sadly common)
59
59
  unless action_methods?(processed_source.ast)
60
60
  initialize_node = initialize_method(processed_source.ast).first
@@ -44,7 +44,7 @@ module RuboCop
44
44
 
45
45
  def on_send(node)
46
46
  apt_recipe_usage?(node) do
47
- add_offense(node, message: MSG, severity: :refactor)
47
+ add_offense(node, severity: :refactor)
48
48
  end
49
49
  end
50
50
  end
@@ -52,13 +52,13 @@ module RuboCop
52
52
 
53
53
  def on_send(node)
54
54
  berksfile_source?(node) do
55
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
55
+ add_offense(node, severity: :refactor) do |corrector|
56
56
  corrector.replace(node, "source 'https://supermarket.chef.io'")
57
57
  end
58
58
  end
59
59
 
60
60
  berksfile_site?(node) do
61
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
61
+ add_offense(node, severity: :refactor) do |corrector|
62
62
  corrector.replace(node, "source 'https://supermarket.chef.io'")
63
63
  end
64
64
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  build_essential_recipe_usage?(node) do
46
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
46
+ add_offense(node, severity: :refactor) do |corrector|
47
47
  corrector.replace(node, "build_essential 'install compilation tools'")
48
48
  end
49
49
  end
@@ -48,7 +48,7 @@ module RuboCop
48
48
 
49
49
  def on_send(node)
50
50
  legacy_depends?(node) do
51
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
51
+ add_offense(node, severity: :refactor) do |corrector|
52
52
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
53
53
  end
54
54
  end
@@ -45,7 +45,7 @@ module RuboCop
45
45
 
46
46
  def on_send(node)
47
47
  legacy_depends?(node) do
48
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
48
+ add_offense(node, severity: :refactor) do |corrector|
49
49
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
50
50
  end
51
51
  end
@@ -41,7 +41,7 @@ module RuboCop
41
41
  def on_block(node)
42
42
  match_property_in_resource?(:chef_gem, 'package_name', node) do |pkg_name|
43
43
  return unless pkg_name.arguments&.first&.str_content == 'nokogiri'
44
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
44
+ add_offense(node, severity: :refactor) do |corrector|
45
45
  node = node.parent if node.parent&.block_type? # make sure we get the whole block not just the method in the block
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
@@ -50,7 +50,7 @@ module RuboCop
50
50
 
51
51
  def on_send(node)
52
52
  nokogiri_install?(node) do
53
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
53
+ add_offense(node, severity: :refactor) do |corrector|
54
54
  node = node.parent if node.parent&.block_type? # make sure we get the whole block not just the method in the block
55
55
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
56
56
  end
@@ -51,7 +51,7 @@ module RuboCop
51
51
 
52
52
  def on_block(node)
53
53
  class_eval_action_class?(node) do
54
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
54
+ add_offense(node, severity: :refactor) do |corrector|
55
55
  corrector.replace(node, node.source.gsub('.class_eval', ''))
56
56
  end
57
57
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  compile_time_resource?(node) do
46
- add_offense(node, message: MSG, severity: :refactor)
46
+ add_offense(node, severity: :refactor)
47
47
  end
48
48
  end
49
49
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
  def on_send(node)
43
43
  resource_conditional?(node) do |conditional|
44
44
  return unless conditional.value.match?(/^test -[ef] \S*$/)
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  new_string = "{ ::File.exist?('#{conditional.value.match(/^test -[ef] (\S*)$/)[1]}') }"
47
47
  corrector.replace(conditional, new_string)
48
48
  end
@@ -78,7 +78,7 @@ module RuboCop
78
78
  def on_block(node)
79
79
  file_or_template?(node) do |file_name|
80
80
  return unless file_name.start_with?('/etc/cron.d/')
81
- add_offense(node, message: MSG, severity: :refactor)
81
+ add_offense(node, severity: :refactor)
82
82
  end
83
83
  end
84
84
  end
@@ -39,7 +39,7 @@ module RuboCop
39
39
  RESTRICT_ON_SEND = [:cron_manage].freeze
40
40
 
41
41
  def on_send(node)
42
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
42
+ add_offense(node, severity: :refactor) do |corrector|
43
43
  corrector.replace(node, node.source.gsub(/^cron_manage/, 'cron_access'))
44
44
  end
45
45
  end
@@ -46,7 +46,7 @@ module RuboCop
46
46
 
47
47
  def on_send(node)
48
48
  data_bag_class_load?(node) do
49
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
49
+ add_offense(node, severity: :refactor) do |corrector|
50
50
  corrector.replace(node,
51
51
  node.source.gsub(/Chef::(EncryptedDataBagItem|DataBagItem).load/, 'data_bag_item'))
52
52
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
  RESTRICT_ON_SEND = [:declare_action_class].freeze
44
44
 
45
45
  def on_send(node)
46
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
46
+ add_offense(node, severity: :refactor) do |corrector|
47
47
  corrector.replace(node, node.source.gsub('declare_action_class', 'action_class'))
48
48
  end
49
49
  end
@@ -55,7 +55,7 @@ module RuboCop
55
55
  def on_ivasgn(node)
56
56
  action_variable_assignment?(node) do
57
57
  return unless initialize_method(node.parent.parent)
58
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
58
+ add_offense(node, severity: :refactor) do |corrector|
59
59
  # insert the new default_action call above the initialize method, but not if one already exists (this is sadly common)
60
60
  unless default_action_method?(processed_source.ast)
61
61
  initialize_node = initialize_method(processed_source.ast).first
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_if(node)
44
44
  chefspec_matcher?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -27,7 +27,7 @@ module RuboCop
27
27
  MSG = 'Legacy Chef Infra definitions should be rewritten as custom resources to take full advantage of the Chef Infra feature set.'
28
28
 
29
29
  def on_block(node)
30
- add_offense(node, message: MSG, severity: :refactor) if node.respond_to?(:method_name) && node.method_name == :define
30
+ add_offense(node, severity: :refactor) if node.respond_to?(:method_name) && node.method?(:define)
31
31
  end
32
32
  end
33
33
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  legacy_depends?(node) do
46
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
46
+ add_offense(node, severity: :refactor) do |corrector|
47
47
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
48
48
  end
49
49
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  legacy_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -42,7 +42,7 @@ module RuboCop
42
42
 
43
43
  def on_send(node)
44
44
  zypper_depends?(node) do
45
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
45
+ add_offense(node, severity: :refactor) do |corrector|
46
46
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
47
47
  end
48
48
  end
@@ -43,7 +43,7 @@ module RuboCop
43
43
 
44
44
  def on_send(node)
45
45
  dsl_include?(node) do
46
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
46
+ add_offense(node, severity: :refactor) do |corrector|
47
47
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
48
48
  end
49
49
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def on_def(node)
42
42
  empty_initialize?(node) do
43
- add_offense(node, message: MSG, severity: :refactor) do |corrector|
43
+ add_offense(node, severity: :refactor) do |corrector|
44
44
  corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
45
45
  end
46
46
  end