cookstyle 7.28.2 → 7.31.0

data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb

@@ -59,19 +59,19 @@ module RuboCop
 
           def on_send(node)
             include_shellout?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end
 
             require_shellout?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end
 
             shellout_new?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.replace(node, node.source.gsub('Chef::ShellOut', 'Mixlib::ShellOut'))
               end
             end

data/lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb

@@ -46,7 +46,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:vagrant_key?, :vagrant_domain?, :vagrant_user?, :require_chef_gem, :best_ip_for, :nexus?, :ios_xr?, :ruby_20?, :ruby_19?, :includes_recipe?, :wrlinux?, :dev_null, :nexentacore_platform?, :opensolaris_platform?, :nexentacore?, :opensolaris?].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :refactor)
+            add_offense(node, severity: :refactor)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb

@@ -43,7 +43,7 @@ module RuboCop
 
           def on_send(node)
             chef_platform_windows?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.replace(node, "platform?('windows')")
               end
             end

data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb

@@ -45,7 +45,7 @@ module RuboCop
             # We want to catch calls like ChefCLI::CLI.whatever or places where classes are defined in the ChefDK module
             return unless node.const_name == 'ChefDK' && (node.parent&.module_type? || node.parent&.const_type?)
 
-            add_offense(node, message: MSG, severity: :warning) do |corrector|
+            add_offense(node, severity: :warning) do |corrector|
               corrector.replace(node, node.source.gsub('ChefDK', 'ChefCLI'))
             end
           end

data/lib/rubocop/cop/chef/deprecation/cheffile.rb

@@ -30,7 +30,7 @@ module RuboCop
             # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
             range = source_range(processed_source.buffer, 1, 0)
 
-            add_offense(range, message: MSG, severity: :warning)
+            add_offense(range, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb

@@ -37,7 +37,7 @@ module RuboCop
 
           def on_block(node)
             coverage_reporter?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(node)
               end
             end

data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb

@@ -49,7 +49,7 @@ module RuboCop
 
           def on_const(node)
             chefspec_runner?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.replace(node, 'ChefSpec::ServerRunner')
               end
             end

data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb

@@ -43,7 +43,7 @@ module RuboCop
             match_property_in_resource?(:chocolatey_package, 'action', node) do |choco_action|
               choco_action.arguments.each do |action|
                 next unless action.source == ':uninstall'
-                add_offense(action, message: MSG, severity: :warning) do |corrector|
+                add_offense(action, severity: :warning) do |corrector|
                   corrector.replace(action, ':remove')
                 end
               end

data/lib/rubocop/cop/chef/deprecation/delivery.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2022, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # The Delivery CLI from Chef Delivery/Workflow is no longer bundled with Chef Workstation as Chef Delivery is end of life as of Dec 31st 2021.
+        #
+        # Users of Delivery / Workflow would include a `.delivery` directory in their cookbooks. This directory would include Delivery local-mode configs
+        # or Delivery cookbooks. The contents of this directory are now obsolete and should be removed.
+        #
+        class Delivery < Base
+          include RangeHelp
+
+          MSG = 'Do not include a `.delivery` directory for the `delivery` command in your cookbooks. Chef Delivery (Workflow) went EOL Dec 31st 2021 and the delivery command was removed from Chef Workstation Feb 2022.'
+
+          def on_new_investigation
+            return unless File.exist?(File.join(File.dirname(processed_source.path) + '/.delivery'))
+
+            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
+            range = source_range(processed_source.buffer, 1, 0)
+
+            add_offense(range, severity: :warning)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/depends_chef_nginx_cookbook.rb

@@ -42,7 +42,7 @@ module RuboCop
 
           def on_send(node)
             depends_compat_resource?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/deprecation/depends_chef_reporting_cookbook.rb

@@ -39,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             legacy_depends?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb

@@ -42,7 +42,7 @@ module RuboCop
 
           def on_send(node)
             depends_compat_resource?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/deprecation/depends_omnibus_updater_cookbook.rb

@@ -42,7 +42,7 @@ module RuboCop
 
           def on_send(node)
             legacy_depends?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb

@@ -40,7 +40,7 @@ module RuboCop
 
           def on_send(node)
             depends_partial_search?(node) do
-              add_offense(node, message: MSG, severity: :warning)
+              add_offense(node, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/depends_poise.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 #
-# Copyright:: 2019, Chef Software, Inc.
+# Copyright:: 2019-2022, Chef Software, Inc.
 # Author:: Tim Smith (<tsmith@chef.io>)
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -26,6 +26,7 @@ module RuboCop
         #   #### incorrect
         #   depends 'poise'
         #   depends 'poise-service'
+        #   depends 'poise-hoist'
         #
         class CookbookDependsOnPoise < Base
           MSG = 'Cookbooks should not depend on the deprecated Poise framework'
@@ -37,7 +38,7 @@ module RuboCop
 
           def on_send(node)
             depends_method?(node) do |arg|
-              add_offense(node, message: MSG, severity: :warning) if %w(poise poise-service).include?(arg.value)
+              add_offense(node, severity: :warning) if %w(poise poise-service poise-hoist).include?(arg.value)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb

@@ -114,7 +114,7 @@ module RuboCop
           def on_send(node)
             chefspec_definition?(node) do |plat, ver|
               next unless legacy_chefspec_platform(plat.value, ver.value)
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 if replacement = replacement_string(plat.value, ver.value) # rubocop: disable Lint/AssignmentInCondition
                   corrector.replace(ver, "'#{replacement}'")
                 end

data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb

@@ -54,19 +54,19 @@ module RuboCop
 
           def on_send(node)
             deprecated_mixin?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end
 
             deprecated_dsl?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end
 
             dsl_mixin_require?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb

@@ -51,7 +51,7 @@ module RuboCop
 
           def on_send(node)
             platform_method?(node) do
-              add_offense(node, message: MSG, severity: :warning)
+              add_offense(node, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb

@@ -55,7 +55,7 @@ module RuboCop
         ).freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/deprecated_sudo_actions.rb

@@ -51,7 +51,7 @@ module RuboCop
               next unless prop_node.arguments.first.sym_type?
               next unless [s(:sym, :install), s(:sym, :remove)].include?(prop_node.arguments.first)
 
-              add_offense(prop_node, message: MSG, severity: :warning) do |corrector|
+              add_offense(prop_node, severity: :warning) do |corrector|
                 corrector.replace(prop_node, prop_node.source
                   .gsub('install', 'create')
                   .gsub('remove', 'delete'))

data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb

@@ -33,7 +33,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:older_than_win_2012_or_8?].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb

@@ -53,7 +53,7 @@ module RuboCop
               next unless prop_node.arguments.first.sym_type?
               next unless [s(:sym, :add), s(:sym, :delete)].include?(prop_node.arguments.first)
 
-              add_offense(prop_node, message: MSG, severity: :warning) do |corrector|
+              add_offense(prop_node, severity: :warning) do |corrector|
                 corrector.replace(prop_node, prop_node.source
                   .gsub('add', 'create')
                   .gsub('delete', 'remove'))

data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb

@@ -53,7 +53,7 @@ module RuboCop
           def on_block(node)
             %w(url keyurl mirrorexpire).each do |prop|
               match_property_in_resource?(:yum_repository, prop, node) do |prop_node|
-                add_offense(prop_node, message: MSG, severity: :warning)  do |corrector|
+                add_offense(prop_node, severity: :warning) do |corrector|
                   corrector.replace(prop_node, prop_node.source
                     .gsub(/^url/, 'baseurl')
                     .gsub(/^keyurl/, 'gpgkey')

data/lib/rubocop/cop/chef/deprecation/easy_install.rb

@@ -33,7 +33,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:easy_install].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb

@@ -39,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             control_group?(node) do
-              add_offense(node.loc.selector, message: MSG, severity: :warning)
+              add_offense(node.loc.selector, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/epic_fail.rb

@@ -40,7 +40,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:epic_fail].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning) do |corrector|
+            add_offense(node, severity: :warning) do |corrector|
               corrector.replace(node, 'ignore_failure true')
             end
           end

data/lib/rubocop/cop/chef/deprecation/erl_call.rb

@@ -33,7 +33,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:erl_call].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/execute_path_property.rb

@@ -40,7 +40,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:execute, 'path', node) do |offense|
-              add_offense(offense, message: MSG, severity: :warning) # @todo: we could probably autocorrect this with some work
+              add_offense(offense, severity: :warning) # @todo: we could probably autocorrect this with some work
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb

@@ -56,7 +56,7 @@ module RuboCop
                 return
               end
 
-              add_offense(offense, message: MSG, severity: :warning)
+              add_offense(offense, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb

@@ -34,7 +34,7 @@ module RuboCop
           def on_send(node)
             return unless node.arguments.first == s(:str, 'foodcritic')
 
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb

@@ -105,7 +105,7 @@ module RuboCop
           def on_class(node)
             return if has_provides?
             HWRP?(node) do |inherit|
-              add_offense(inherit, message: MSG, severity: :warning) do |corrector|
+              add_offense(inherit, severity: :warning) do |corrector|
                 resource_name_ast(node) do |ast_match|
                   # build a new string to add after that includes the new line and the proper indentation
                   new_string = "\n" + ast_match.source.dup.gsub('resource_name', 'provides').prepend(' ' * indentation(ast_match))

data/lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb

@@ -76,7 +76,7 @@ module RuboCop
           def on_class(node)
             return if unified_mode?(processed_source.ast)
             HWRP?(node) do |inherit|
-              add_offense(inherit, message: MSG, severity: :warning)
+              add_offense(inherit, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb

@@ -47,7 +47,7 @@ module RuboCop
 
           def on_class(node)
             inherits_from_compat_resource?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.replace(node, node.source.gsub('ChefCompat', 'Chef'))
               end
             end

data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb

@@ -44,7 +44,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:launchd, 'hash', node) do |offense|
-              add_offense(offense.loc.expression, message: MSG, severity: :warning) do |corrector|
+              add_offense(offense.loc.expression, severity: :warning) do |corrector|
                 corrector.replace(offense.loc.expression, offense.loc.expression.source.gsub(/^hash/, 'plist_hash'))
               end
             end

data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb

@@ -69,7 +69,7 @@ module RuboCop
 
           def on_send(node)
             legacy_notify?(node) do |notify_type, action, type, name, timing|
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 service_value = case name.type
                                 when :str
                                   "'#{type.source}[#{name.value}]'"

data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb

@@ -43,7 +43,7 @@ module RuboCop
 
           def on_send(node)
             old_yum_recipe?(node) do
-              add_offense(node, message: MSG, severity: :warning)
+              add_offense(node, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb

@@ -33,7 +33,7 @@ module RuboCop
           def on_send(node)
             return unless node.arguments.first == s(:str, 'chefspec/librarian')
 
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb

@@ -36,7 +36,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:locale, 'lc_all', node) do |property|
-              add_offense(property, message: MSG, severity: :warning)
+              add_offense(property, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb

@@ -53,7 +53,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:log, 'notifies', node) do |prop_node|
-              add_offense(prop_node, message: MSG, severity: :warning)
+              add_offense(prop_node, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb

@@ -48,7 +48,7 @@ module RuboCop
 
           def on_block(node)
             match_property_in_resource?(:macos_userdefaults, 'global', node) do |global|
-              add_offense(global.loc.expression, message: MSG, severity: :warning) do |corrector|
+              add_offense(global.loc.expression, severity: :warning) do |corrector|
                 corrector.remove(range_with_surrounding_space(range: global.loc.expression, side: :left))
               end
             end

data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb

@@ -47,7 +47,7 @@ module RuboCop
 
           def on_send(node)
             name_property_with_default?(node) do |default|
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 range = range_with_surrounding_comma(range_with_surrounding_space(range: default.loc.expression, side: :left), :left)
                 corrector.remove(range)
               end

data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb

@@ -68,7 +68,7 @@ module RuboCop
 
           def on_send(node)
             node_ohai_methods?(node) do
-              add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
+              add_offense(node.loc.selector, severity: :warning) do |corrector|
                 corrector.replace(node, "node['#{node.method_name}']")
               end
             end

data/lib/rubocop/cop/chef/deprecation/node_set.rb

@@ -42,7 +42,7 @@ module RuboCop
 
           def on_send(node)
             node_set?(node) do
-              add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
+              add_offense(node.loc.selector, severity: :warning) do |corrector|
                 corrector.replace(node.loc.selector, 'normal')
               end
             end

data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb

@@ -42,7 +42,7 @@ module RuboCop
 
           def on_send(node)
             node_set_unless?(node) do
-              add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
+              add_offense(node.loc.selector, severity: :warning) do |corrector|
                 corrector.replace(node.loc.selector, 'normal_unless')
               end
             end

data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb

@@ -56,11 +56,11 @@ module RuboCop
 
           def add_offense_for_bare_assignment(sub_node)
             if sub_node.receiver == s(:send, nil, :node) # node['foo'] scenario
-              add_offense(sub_node.receiver.loc.selector, message: MSG, severity: :warning)
+              add_offense(sub_node.receiver.loc.selector, severity: :warning)
             elsif sub_node.receiver &&
                   sub_node.receiver&.node_parts[0] == s(:send, nil, :node) &&
                   sub_node.receiver&.node_parts[1] == :[] # node['foo']['bar'] scenario
-              add_offense(sub_node.receiver.node_parts.first.loc.selector, message: MSG, severity: :warning)
+              add_offense(sub_node.receiver.node_parts.first.loc.selector, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb

@@ -57,7 +57,7 @@ module RuboCop
 
           def on_send(node)
             partial_search_class?(node) do
-              add_offense(node, message: MSG, severity: :warning)
+              add_offense(node, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb

@@ -52,7 +52,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:partial_search].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/poise_archive.rb

@@ -47,13 +47,13 @@ module RuboCop
 
           def on_send(node)
             depends_poise_archive?(node) do
-              add_offense(node, message: MSG, severity: :warning)
+              add_offense(node, severity: :warning)
             end
           end
 
           def on_block(node)
             match_resource_type?(:poise_archive, node) do
-              add_offense(node, message: MSG, severity: :warning)
+              add_offense(node, severity: :warning)
             end
           end
         end

data/lib/rubocop/cop/chef/deprecation/policyfile_community_source.rb

@@ -41,7 +41,7 @@ module RuboCop
 
           def on_send(node)
             community_source?(node) do
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.replace(node, 'default_source :supermarket')
               end
             end

data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb

@@ -47,7 +47,7 @@ module RuboCop
 
           def on_send(node)
             ps_cb_helper?(node) do |ver|
-              add_offense(node, message: MSG, severity: :warning) do |corrector|
+              add_offense(node, severity: :warning) do |corrector|
                 corrector.replace(node, "node['powershell']['version'].to_f == #{ver.source}")
               end
             end

data/lib/rubocop/cop/chef/deprecation/require_recipe.rb

@@ -41,7 +41,7 @@ module RuboCop
 
           def on_send(node)
             require_recipe?(node) do
-              add_offense(node.loc.selector, message: MSG, severity: :warning) do |corrector|
+              add_offense(node.loc.selector, severity: :warning) do |corrector|
                 corrector.replace(node.loc.selector, 'include_recipe')
               end
             end

data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb

@@ -37,9 +37,9 @@ module RuboCop
           def_node_search :calls_provides?, '(send nil? :provides ...)'
 
           def on_def(node)
-            return unless node.method_name == :provides?
+            return unless node.method?(:provides?)
 
-            add_offense(node, message: MSG, severity: :warning) unless calls_provides?(processed_source.ast)
+            add_offense(node, severity: :warning) unless calls_provides?(processed_source.ast)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb

@@ -34,7 +34,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:dsl_name].freeze
 
           def on_send(node)
-            add_offense(node, message: MSG, severity: :warning)
+            add_offense(node, severity: :warning)
           end
 
           # potential autocorrect is new_resource.updated_by_last_action true, but we need to actually see what class we were called from